[OpenJDK 2D-Dev] [PATCH] Request for review: 6888734, regression test fails when java.security.manager is enabled

Phil Race Phil.Race at Sun.COM
Mon Nov 30 21:37:12 UTC 2009


Roman Kennke wrote:
> I added the (previously closed) testcase, keeping it in the same
> relative directory location:
>
> http://cr.openjdk.java.net/~rkennke/6888734/webrev.01/
>
> Is this ok?
>   

Almost. Reg tests don't have the classpath exception.

And probably the copyright year should be a range, starting
with whatever the existing year is.

-phil.
>
> /Roman
>
>
> Am Montag, den 30.11.2009, 11:19 -0800 schrieb Phil Race:
>   
>> The fix looks fine to me. One thing. The test is
>> in closed just because no one got round to moving it to open.
>> At least I don't see any reason it can't be opened up.
>> Now would be a good time and it can be included with this
>> changeset.
>> Don't forget to tag it with this additional bug ID.
>>
>> -phil.
>>
>> Roman Kennke wrote:
>>     
>>> Hi again,
>>>
>>> is this ok for committing?
>>>
>>> Thanks, Roman
>>>
>>> Am Donnerstag, den 15.10.2009, 15:22 +0200 schrieb Roman Kennke:
>>>       
>>>> Hi there,
>>>>
>>>> Here's a fix for Bug#6888734. One regression test was failing with an
>>>> AccessControlException in new FontManager code. We need to move
>>>> Class.forName() and newInstance() call into the privileged block. Webrev
>>>> here:
>>>>
>>>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.00/
>>>>
>>>> Good? Comments?
>>>>
>>>> /Roman
>>>>
>>>>
>>>>         
>>>       
>
>
>   




More information about the 2d-dev mailing list