[OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

[Mario Torre]

Il 25/09/2009 22:29, Jim Graham ha scritto:

Hi Jim,

> I think we could add a quick "if (loops == null) {...}" in those 2
> classes and maybe add a comment "// assert(some pipe will always be a
> LoopBasedPipe)" to indicate that we aren't checking the types of the
> pipes because we think it is always true in case that assumption changes
> in the future. Does that make sense?

Not sure if this is what you mean:

http://cr.openjdk.java.net/~neugens/100068/webrev.09

Looks like it doesn't break stuff, I did the usual test with Java2D demo.

Cheers,
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Geschäftsführer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/