[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

[Phil Race]

Andrew John Hughes wrote:
> 2009/10/26 Phil Race <Phil.Race at sun.com>:
>   
>> The fix looks fine. I think it should go via the build forest, in the
>> expectation
>> that build is likely to integrate to master before AWT or 2D (which
>> would have been the second choice).
>>
>>     
>
> Ok, I can push this now or do you still want to?
>   

You can go ahead but I think it would be better to push it to build-dev.

Acc. to http://openjdk.java.net/projects/jdk7/builds/   AWT/Swing integrate
right before build, but I'm not sure AWT are integrating this time and if
they I think a PIT build repo has already been spun off since its now so 
close
to the integration slot.

-phil.




>   
>> And its not a proprietary vs open thing, rather it seemed more efficient
>> to me to do both at once.
>>
>>     
>
> Yes, I agree that's (slightly) more efficient but my point was that
> only Sun developers can patch the proprietary tree - I don't have the
> option of doing 'both at once'.  So, by taking such a stance you're
> effectively ruling out direct external contribution.
>
>   
>> -phil.
>>
>> Andrew John Hughes wrote:
>>     
>>> 2009/10/26 Phil Race <Phil.Race at sun.com>:
>>>
>>>       
>>>> Igor is also fixing the closed src ..
>>>>
>>>> -phil.
>>>>
>>>>
>>>>         
>>> Right, well obviously I can't fix the proprietary source code base by
>>> definition.  I don't think that's an acceptable reason for refusing
>>> external contributions.  If you want to continue to maintain a
>>> proprietary version as well, then you need to be prepared to integrate
>>> community contributions into it.
>>>
>>> I've applied the following webrev to the AWT tree:
>>>
>>> http://cr.openjdk.java.net/~andrew/6895287/webrev.01/
>>>
>>> and it builds.  It also works when applied to the IcedTea forest,
>>> removing the original error I posted.
>>>
>>> Just give the nod and I can push this.
>>>
>>>
>>>       
>>>> Andrew John Hughes wrote:
>>>>
>>>>         
>>>>> 2009/10/26 Igor Nekrestyanov <Igor.Nekrestyanov at sun.com>:
>>>>>
>>>>>
>>>>>           
>>>>>> Andrew,
>>>>>>
>>>>>> i've filed 6895287 for this and plan to fix it soon.
>>>>>> (this will likely a bit faster in terms of "time to get fix into
>>>>>> master").
>>>>>>
>>>>>> -igor
>>>>>>
>>>>>>
>>>>>>
>>>>>>             
>>>>> Thanks for filing a bug ID for this.  I'm already working on a webrev
>>>>> for this, so let's not duplicate the work.  I'll post it as soon as it
>>>>> builds.
>>>>>
>>>>>
>>>>>
>>>>>           
>>>>>> On 10/26/09 11:19 AM, Andrew John Hughes wrote:
>>>>>>
>>>>>>
>>>>>>             
>>>>>>> 2009/10/26 Kelly O'Hair<Kelly.Ohair at sun.com>:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>>>>> Is someone fixing this bootstrap build problem with
>>>>>>>> FontManager.getFontPath(true) and the fontchecker?
>>>>>>>>
>>>>>>>> Not sure I care much how it gets fixed, I just need it fixed.
>>>>>>>>
>>>>>>>> -kto
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>                 
>>>>>>> You and me both!  I'll look at removing fontchecker.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>>>             
>>>>>
>>>>>           
>>>>         
>>>
>>>
>>>       
>>     
>
>
>
>