[OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised
Phil Race
Phil.Race at Sun.COM
Wed Oct 28 18:24:48 UTC 2009
Mario,
PS .. sponsor and reviewer are different roles although
quite commonly a sponsor will also be a reviewer.
The sponsor is basically there to help you through the
bureaucracy and the reviewer checks the actual code
In this case since you have a userid you can push and I'm
not sure you need a sponsor for that but Jennifer is
the sponsor who will get the sun bug ID to push under.
You normally need two reviewers and reviewers are supposed
to be group members. At this point this fix has been reviewed
well enough that I think one of the reviewers being a group
member is more than good enough. In the case that its not
free free to cite me ..
-phil.
Jennifer Godinez wrote:
> Hi Mario,
>
> http://bugs.openjdk.java.net/show_bug.cgi?id=100068
>
> First, please update the above bugzilla report with the latest approved
> webrev.
>
> If you have signed the SCA, then go ahead and push your change.
>
> Jennifer
>
>
> Andrew John Hughes wrote:
>> 2009/10/28 Mario Torre <mario.torre at aicas.com>:
>>> Il 21/10/2009 23:23, Jennifer Godinez ha scritto:
>>>> Hi Mario,
>>>>
>>>> You can submit the patch using the steps in
>>>> http://openjdk.java.net/contribute/
>>>>
>>>> Let me know if you have any questions.
>>>>
>>>> Jennifer
>>> Hi Jennifer,
>>>
>>> As far as I understand I need two sponsors, I guess one is Jim, but
>>> I'm not
>>> sure if I can count Roman as valid for the other (actually, I don't
>>> know the
>>> rules to chose the sponsors).
>>>
>>> If I understand correctly the "Looks good to go..." means either
>>> "push" or
>>> "we'll push for you", unless there is something else I have to do?
>>>
>>> Thanks,
>>> Mario
>>> --
>>> Mario Torre, Software Developer, http://www.jroller.com/neugens/
>>> aicas Allerton Interworks Computer Automated Systems GmbH
>>> Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
>>> http://www.aicas.com * Tel: +49-721-663 968-44
>>> pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
>>> Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF
>>>
>>> USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
>>> Geschäftsführer: Dr. James J. Hunt
>>>
>>> Please, support open standards:
>>> http://endsoftpatents.org/
>>>
>>>
>>
>> Mario,
>>
>> Sounds to me like you can go ahead and push the patch to the 2d
>> forest, with a Reviewed-by: flar, rkennke. You presumably have an
>> OpenJDK account from your cacio work.
>> Hop on IRC if you need a hand with the practicalities.
>>
>> Cheers,
More information about the 2d-dev
mailing list