[OpenJDK 2D-Dev] Various fixes to pisces stroke widening code

Denis Lila dlila at redhat.com
Wed Aug 4 18:27:11 UTC 2010


Hello Jim.

> I'd need to see a final webrev and approve it and then anyone with an
> OpenJDK user id can push it.  
The final webrev is http://icedtea.classpath.org/~dlila/webrevs/fpBetterAAv2/webrev/
The only things that have changed since the last one you commented on
are the "y == boundsMaxY - 1" check, and a few comments in Renderer.java.

> I'll also have to create a bugid for the change set.
I've already submitted a bug that this patch would fix. The ID is 6967436.

> Are you a registered OpenJDK developer?
Not just yet. I will be soon, I think.

Thanks,
Denis.

----- "Jim Graham" <james.graham at oracle.com> wrote:

> Hi Denis,

> 
> 
> 			...jim
> 
> Denis Lila wrote:
> > Hello Jim.
> > 
> >> I'm guessing the test for "y == boundsMaxY-1" at line 470 could
> >> probably also be deleted now (since it will be handled by the end 
> >> test when y reaches maxY)?
> > 
> > Indeed it can. I've done this, and also updated a few comments that
> > might have been misleading (they were written before certain
> changes
> > were made).
> > 
> >> It looks fine.  Hopefully we can eventually figure out why the
> sorting
> >> on the fly didn't pan out.
> > 
> > Wonderful! So, will it be committed?
> > 
> > Thanks,
> > Denis.
> > 
> > ----- "Jim Graham" <james.graham at oracle.com> wrote:
> > 
> >> Hi Denis,
> >>
> > 
> >> Denis Lila wrote:
> >>> Hi Jim. 
> >>>
> >>>     Thanks for all your suggestions. I fixed the edge array
> >> indexing
> >>> issue, the moveTo bug (not assigning x0), and the double
> >>> initialization issue. I also improved the emission of the last
> row
> >>> to what you said. The link is the same as the last one I sent.
> > 
> >> But everything looks in order!
> >>
> >> 			...jim



More information about the 2d-dev mailing list