[OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

Jim Graham james.graham at oracle.com
Wed Aug 4 22:39:07 UTC 2010


Hi Denis,

First, comments on the high level normalizer (Normalizing iterator):

- If there is no normalization going on, I would use the Shape's own 
flattening (i.e. getPathIterator(at, flat)).  The reason being that some 
shapes may know how to flatten themselves better, or faster, than a 
Flattening Iterator.  In particular, rectangles and polygons would 
simply ignore the argument and save themselves the cost of wrapping with 
an extra iterator.  This would probably only be a big issue for very 
long Polygons.

- Line 331 - the initializations to NaN aren't necessary as far as I can 
tell...?

- Rather than saving "mode" in the normalizing iterator, how about 
saving 2 constants: (0.0, 0.5) for AA and (0.25, 0.25) for non-AA and 
then simply add those constants in rather than having to have the 
conditional with the 2 different equations?

			...jim




More information about the 2d-dev mailing list