[OpenJDK 2D-Dev] Use of obsolete png_check_sig function in splashscreen_png.c

Andrew John Hughes ahughes at redhat.com
Thu May 20 07:53:17 UTC 2010


With libpng 1.4, the png_check_sig function has been removed, having
been deprecated in previous releases:

http://www.libpng.org/pub/png/src/libpng-1.2.x-to-1.4.x-summary.txt

This function is used in splashscreen_png.c and can be easily be
replaced with png_sig_cmp, as in this webrev:

http://cr.openjdk.java.net/~andrew/libpng/webrev.01/

This actually makes the line clearer as the not operator is no longer needed.
I know OpenJDK still uses an in-tree libpng 1.2 by default, but this
fix still works with that version and also means that the code will
still build, should the internal libpng be upgraded to 1.4.

Ok to push this?  If so, can I have a bug ID for it?

Thanks,
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8



More information about the 2d-dev mailing list