[OpenJDK 2D-Dev] [Fwd: Need reviewer for change in freetypeScaler.c]
Phil Race
philip.race at oracle.com
Tue Oct 5 16:26:11 UTC 2010
It might be best if you provided the regression test first as pasting
that into the
bug description as the test case there would make it more apparent what
the user impact is.
Then the evaluation will be what you found as the cause.
-phil.
On 10/5/2010 2:33 AM, Pavel Tisnovsky wrote:
> Phil Race wrote:
>> Whilst the fix looks reasonable I'm a bit confused since you say the
>> referenced regression test for
>> 6703377 fails and yet it passes for me on a 6open build .. which is what
>> I'd hoped would happen
>> for a test specifically designed to test that bug.
> Hi Phil,
>
> thank you very much for your comments. I'm going to create regression
> test targeted only to this issue based on
> java/awt/Graphics2D/DrawString/RotTransText.java.
>
> Could you please create a new bug id for this issue or do I have to
> create reg.test first?
>
> Pavel
>
>> Note that this fix would need to be pushed under a new bug id, and
>> either the regression test
>> would need to be updated to reference the new bug (in addition to the
>> old one), or if it can't
>> reproduce the problem, you'd need to update it or provide a new one.
>>
>> -phil.
>>
>> On 10/4/2010 4:14 AM, Pavel Tisnovsky wrote:
>>> Hi,
>>>
>>> can someone please review a patch (see attachment) which I posted about
>>> two weeks before? This mail was probably lost due to JavaOne ;-)
>>>
>>> Thank you in advance
>>> Pavel
More information about the 2d-dev
mailing list