[OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces
Jim Graham
james.graham at oracle.com
Tue Oct 19 23:18:28 UTC 2010
On 10/19/2010 10:38 AM, Denis Lila wrote:
> Hi Jim.
>
> If I haven't replied to a suggestion, that means I've implemented and
> I thought it was a good idea, so I don't have anything to say about it.
That's mostly true too for me, but there are a couple that I might go
back to - I'll let you know when I think I've reached a 100% coverage
(getting close).
>> getTransformedPoints isn't used?
>> getUntransformedPoints isn't used?
>> fillWithIndxes(float) isn't used?
>> evalQuad isn't used? (Though it does provide symmetry with evalCubic
>> which is used)
>> getFlatness* aren't used?
>> ptSegDistSq isn't used?
>
> Should I get rid of these? I wanted to do it, but I wanted to wait until
> just before pushing because I was afraid I'd start needing them again at
> some point in the future.
OK, use your best judgment. If they are small and they add to symmetry
of services (like evalQuad) or they might be used later, then it isn't a
big deal, but dead code in private APIs shouldn't be just left laying
around if we can help it.
...jim
More information about the 2d-dev
mailing list