[OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

[Denis Lila]

Hi Jim.

> In the meantime, can you outline the tests that you ran?

I ran Java2D without any problems. There's also been an
icedtea bug http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=450
related to a look and feel (tinylaf: http://www.muntjak.de/hans/java/tinylaf/tinylaf-1_4_0.zip
to run a demo, download, extract and run tinycp.jar) that wasn't being
painted properly. Now it looks good (I think there's no LCD text antialiasing, but
that's a different story).

I also wrote rendered at least 50000 random cubic curves. I didn't
inspect these too closely - this test was just to find any obvious
errors. There weren't any.

Most importantly, I also ran this test suite:
http://icedtea.classpath.org/hg/gfx-test/

It generates a lot of images using a reference java implementation and
an implementation to be tested. I used closed source java as a reference,
and I ran it using a fresh checkout of the 2d branch of openjdk7:
http://icedtea.classpath.org/~dlila/prevPiscesSungfx/results/

and a fresh checkout of the 2d branch with my patch applied:
http://icedtea.classpath.org/~dlila/latestPiscesSungfx/

As you can see, the number of images that are the same as the reference
implementation has increased subtantially. It has also increased
consistenly across all categories.
I've gone through most of the images, and the ones that are different
aren't dramatically different. The differences are barely noticeable.
The improvement is even greater when compared to openjdk6 which produces
some pretty scary test results, especially in the scaled rectangles
category (but I haven't uploaded these tests so you'll just have to trust
me on this ;-)  )

NOTE: the webrev has changed slightly since the last e-mail I sent. The 
gfx test suite revealed a bug in the drawing of dashed rectangles, so
to fix it I have changed a line in Dasher.closePath from "if(needsMoveTo) {"
to "if(needsMoveTo || !dashOn) {"

> Also, have you used J2DBench at all?  I know you ran some of your own
> benchmarks, but didn't know if you were familiar with this tool:
> 
> 	{OpenJDK}/src/share/demo/java2d/J2DBench/

I was going to run these today, but fixing the dashing bug above and
rerunning the tests took a while and it's already 8:30 pm here and I have to
go home. I'll run them tomorrow morning.

Regards,
Denis.

----- "Jim Graham" <james.graham at oracle.com> wrote:

> Hi Denis,
> 
> I'll be focusing on this later today, just a last proofread.
> 

> 
> 				...jim
> 
> On 10/21/2010 12:27 PM, Denis Lila wrote:
> > Good to push?
> >
> > http://icedtea.classpath.org/~dlila/webrevs/noflatten2/webrev/