[OpenJDK 2D-Dev] <AWT Dev> Please review change in regression test sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java

[Pavel Tisnovsky]

Hi Artem,

could you please create a bug id so I'll be able to push this change to tl?

Thank you in advance
Pavel

Artem Ananiev wrote:
> Hi, Pavel,
> 
> indeed, the names are confusing. Your changes look correct.
> 
> Thanks,
> 
> Artem
> 
> On 9/10/2010 2:12 PM, Pavel Tisnovsky wrote:
>> Hi,
>>
>> can anybody please review the simple change in regression test
>> sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java?
>>
>>
>> Webrev containing this change is available here:
>> http://cr.openjdk.java.net/~ptisnovs/OnScreenRenderingResizeTest/
>>
>> I replaced the call of a method Point.move() by Point.translate()
>> because this test did not work correctly in those cases when the top
>> (and probably left) screen area is occupied by a toolbar/panel (which is
>> the default settings for GNOME for example).
>>
>> I've successfully tested this changed regression test on RHEL5 with
>> GNOME installed (with and without top panel).
>>
>> Cheers
>> Pavel T.
>>
>> PS: the name of the method Point.move() is a bit confusing for me as I
>> (and probably also author of the test) have thought it is similar to
>> Point.translate() ;-)