[OpenJDK 2D-Dev] CubicCurve2D.solveCubic and containment/intersection bugs.

[Denis Lila]

> I think so, but Phil knows more about the scripts that verify a push.
> 
> I think they do look for the bugids in the regression tests so I don't
> know what happens if they find a mismatch. I think you are probably OK
> as long as one of the tests lists the bug you are claiming to fix on
> that push...

By the way, is the cubic solver improvement good to go? I tried to
address the last concerns and questions you had about it in this e-mail:
http://mail.openjdk.java.net/pipermail/2d-dev/2011-January/001769.html
where I also propose some concrete documentation changes.

Thank you,
Denis.

----- Original Message -----

> 
> ...jim
> 
> On 1/19/11 10:57 AM, Denis Lila wrote:
> >> In general, if you can, you should write a short regression test
> >> and
> >> push it with your checkin. I probably should have mentioned that
> >> before
> >> you pushed since these bugs sound like they are conducive to a tiny
> >> automatic regression test.
> >
> > Sorry about that.
> >
> >> At this point we'd need a new bugid to push any regression tests.
> >> Is
> >> there another bugid associated with this general set of problems
> >> that
> >> we
> >> could use to generate them and push them?
> >
> > The cubic solver is somewhat related. Should I push any regression
> > tests
> > with that?
> >
> > Regards,
> > Denis.