[OpenJDK 2D-Dev] CubicCurve2D.solveCubic and containment/intersection bugs.

[Denis Lila]

> What are we regressing from? Is it slower than the previous OpenJDK
> rasterizer?

The rasterizer has always gotten faster. The regression is in the
Dasher, because of this changeset:
http://hg.openjdk.java.net/jdk7/2d-gate/jdk/diff/065e6c5a8027/src/share/classes/sun/java2d/pisces/Dasher.java
where I removed flattening but didn't implement any heuristics to
improve the Dashing performance because the changeset was already
pretty big and we wanted to get something in.

> Is there a publicly available build available that does reproduce it?
> If not, if you create a regression test for it and send it my way I
> can run it against a recent build of mine that doesn't have your fixes and
> then we can push the test under the bugid and evaluate it as "likely
> fixed when NNN was fixed"...

Publically available? I don't know about that, but I tested it myself
with a build without my fixes. I attached a regression test.

Regards,
Denis.

----- Original Message -----
> On 1/27/2011 2:03 PM, Denis Lila wrote:
> >> When I first saw "I am Denis Lila" I chuckled because it came
> >> across like "I am Ironman"
> >
> > :-D
> >
> > Well, it is pushed. Now all that's left on my end is the performance
> > improvement for pisces (dashing in particular). Could you please
> > file
> > a performance regression bug for it?
> 

> 
> > PS: I was looking at 4074742 and I think last week's pushes fixed
> > it.
> > I mean, that's an RFE for more precision, and declaring such things
> > "fixed" is pretty loaded, but I can't reproduce it with the given
> > reproducer anymore, and the current method is very accurate so I
> > think it should be closed.
> 

> 
> ...jim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Test4074742.java
Type: text/x-java
Size: 1689 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20110128/606b9f08/Test4074742.java>