From philip.race at oracle.com Tue Mar 1 22:49:45 2011 From: philip.race at oracle.com (philip.race at oracle.com) Date: Tue, 01 Mar 2011 22:49:45 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6974985: Jave2Demo threw exceptions when xrender enabled in OEL5.5 Message-ID: <20110301225024.367A247BA3@hg.openjdk.java.net> Changeset: bbbf427a9007 Author: ceisserer Date: 2011-03-01 14:49 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/bbbf427a9007 6974985: Jave2Demo threw exceptions when xrender enabled in OEL5.5 Reviewed-by: prr ! make/sun/awt/mapfile-mawt-vers ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/solaris/native/sun/java2d/x11/XRSurfaceData.c From heuermh at acm.org Wed Mar 2 18:18:53 2011 From: heuermh at acm.org (Michael Heuer) Date: Wed, 2 Mar 2011 13:18:53 -0500 (EST) Subject: [OpenJDK 2D-Dev] seeking help with text rendering In-Reply-To: Message-ID: Hello, We have an outstanding issue Text rendering in PText and JLabel via PSwing appear not to respect antialiasing rendering hints http://code.google.com/p/piccolo2d/issues/detail?id=117 where code that goes down slightly different text rendering paths looks competely different with regards to antialiasing. There is a runnable jar attached to that issue that demonstrates the problem. We're looking for some help analyzing where the issue lies, in our library, in Swing text components, in Swing look & feel, or in the Java2D renderer(s). Thank you, michael From philip.race at oracle.com Wed Mar 2 18:43:59 2011 From: philip.race at oracle.com (Phil Race) Date: Wed, 02 Mar 2011 10:43:59 -0800 Subject: [OpenJDK 2D-Dev] seeking help with text rendering In-Reply-To: References: Message-ID: <4D6E8FEF.1070000@oracle.com> Michael, I don't know anything about what the P* stuff is, and can't speak for OS X, but the results all look correct in the screen shots for Sun/Oracle's Swing / Java2D on Windows. So I'd say your problems are in the P* stuff. Remember "gasp" may not be AA-ed - it AA's only for the sizes at which the font 'gasp' table says to do so. -phil. On 3/2/2011 10:18 AM, Michael Heuer wrote: > Hello, > > We have an outstanding issue > > Text rendering in PText and JLabel via PSwing appear not to respect > antialiasing rendering hints > > http://code.google.com/p/piccolo2d/issues/detail?id=117 > > > where code that goes down slightly different text rendering paths looks > competely different with regards to antialiasing. There is a runnable jar > attached to that issue that demonstrates the problem. > > We're looking for some help analyzing where the issue lies, in our > library, in Swing text components, in Swing look& feel, or in the Java2D > renderer(s). > > Thank you, > > michael > From heuermh at acm.org Wed Mar 2 19:05:24 2011 From: heuermh at acm.org (Michael Heuer) Date: Wed, 2 Mar 2011 14:05:24 -0500 (EST) Subject: [OpenJDK 2D-Dev] seeking help with text rendering In-Reply-To: <4D6E8FEF.1070000@oracle.com> Message-ID: Hello Phil, Thanks for your reply. On Windows XP I see that jlabel-*, jtextcomponent-*, pswing-*, and phtmlview-* all render the same, in that they ignore the LCD-specific rendering hints (compare e.g. jlabel-lcd-hbgr and java2d-lcd-hbgr, which look very different on my LCD monitor, since HBGR is not appropriate for it). PText uses java.awt.TextLayout.draw to render text, see PText.java, line 522 http://code.google.com/p/piccolo2d/source/browse/piccolo2d.java/trunk/core/src/main/java/org/piccolo2d/nodes/PText.java#522 Why this should look different than Graphics2D.drawString, as in AbstractJava2DTextRenderingBenchmark, line 68 http://dishevelled.svn.sourceforge.net/viewvc/dishevelled/trunk/text-rendering-benchmark/src/main/java/org/dishevelled/text/java2d/AbstractJava2DTextRenderingBenchmark.java?revision=996&view=markup michael On Wed, 2 Mar 2011, Phil Race wrote: > Michael, > > I don't know anything about what the P* stuff is, and can't speak for OS X, > but the results all look correct in the screen shots for Sun/Oracle's > Swing / Java2D on Windows. So I'd say your problems are in the P* stuff. > Remember "gasp" may not be AA-ed - it AA's only for the sizes at which > the font 'gasp' table says to do so. > > -phil. > > On 3/2/2011 10:18 AM, Michael Heuer wrote: > > Hello, > > > > We have an outstanding issue > > > > Text rendering in PText and JLabel via PSwing appear not to respect > > antialiasing rendering hints > > > > http://code.google.com/p/piccolo2d/issues/detail?id=117 > > > > > > where code that goes down slightly different text rendering paths looks > > competely different with regards to antialiasing. There is a runnable jar > > attached to that issue that demonstrates the problem. > > > > We're looking for some help analyzing where the issue lies, in our > > library, in Swing text components, in Swing look& feel, or in the Java2D > > renderer(s). > > > > Thank you, > > > > michael > > > > From heuermh at acm.org Wed Mar 2 19:10:10 2011 From: heuermh at acm.org (Michael Heuer) Date: Wed, 2 Mar 2011 14:10:10 -0500 (EST) Subject: [OpenJDK 2D-Dev] seeking help with text rendering In-Reply-To: Message-ID: Sorry, > PText uses java.awt.TextLayout.draw to render text, see should read > PText uses java.awt.font.TextLayout.draw to render text, see On Wed, 2 Mar 2011, Michael Heuer wrote: > Hello Phil, > > Thanks for your reply. > > On Windows XP I see that jlabel-*, jtextcomponent-*, pswing-*, and > phtmlview-* all render the same, in that they ignore the LCD-specific > rendering hints (compare e.g. jlabel-lcd-hbgr and java2d-lcd-hbgr, which > look very different on my LCD monitor, since HBGR is not appropriate for > it). > > > PText uses java.awt.TextLayout.draw to render text, see > > PText.java, line 522 > http://code.google.com/p/piccolo2d/source/browse/piccolo2d.java/trunk/core/src/main/java/org/piccolo2d/nodes/PText.java#522 > > > Why this should look different than Graphics2D.drawString, as in > > AbstractJava2DTextRenderingBenchmark, line 68 > http://dishevelled.svn.sourceforge.net/viewvc/dishevelled/trunk/text-rendering-benchmark/src/main/java/org/dishevelled/text/java2d/AbstractJava2DTextRenderingBenchmark.java?revision=996&view=markup > > michael > > > On Wed, 2 Mar 2011, Phil Race wrote: > > > Michael, > > > > I don't know anything about what the P* stuff is, and can't speak for OS X, > > but the results all look correct in the screen shots for Sun/Oracle's > > Swing / Java2D on Windows. So I'd say your problems are in the P* stuff. > > Remember "gasp" may not be AA-ed - it AA's only for the sizes at which > > the font 'gasp' table says to do so. > > > > -phil. > > > > On 3/2/2011 10:18 AM, Michael Heuer wrote: > > > Hello, > > > > > > We have an outstanding issue > > > > > > Text rendering in PText and JLabel via PSwing appear not to respect > > > antialiasing rendering hints > > > > > > http://code.google.com/p/piccolo2d/issues/detail?id=117 > > > > > > > > > where code that goes down slightly different text rendering paths looks > > > competely different with regards to antialiasing. There is a runnable jar > > > attached to that issue that demonstrates the problem. > > > > > > We're looking for some help analyzing where the issue lies, in our > > > library, in Swing text components, in Swing look& feel, or in the Java2D > > > renderer(s). > > > > > > Thank you, > > > > > > michael > > > > > > > > > From philip.race at oracle.com Wed Mar 2 19:33:48 2011 From: philip.race at oracle.com (Phil Race) Date: Wed, 02 Mar 2011 11:33:48 -0800 Subject: [OpenJDK 2D-Dev] seeking help with text rendering In-Reply-To: References: Message-ID: <4D6E9B9C.60107@oracle.com> TextLayout gets its AA hint from the constructor of the TextLayout not from the Graphics2D etc. So it was created inappropriately, it won't work as you expect. -phil. On 3/2/2011 11:10 AM, Michael Heuer wrote: > Sorry, > >> PText uses java.awt.TextLayout.draw to render text, see > should read > >> PText uses java.awt.font.TextLayout.draw to render text, see > > On Wed, 2 Mar 2011, Michael Heuer wrote: > >> Hello Phil, >> >> Thanks for your reply. >> >> On Windows XP I see that jlabel-*, jtextcomponent-*, pswing-*, and >> phtmlview-* all render the same, in that they ignore the LCD-specific >> rendering hints (compare e.g. jlabel-lcd-hbgr and java2d-lcd-hbgr, which >> look very different on my LCD monitor, since HBGR is not appropriate for >> it). >> >> >> PText uses java.awt.TextLayout.draw to render text, see >> >> PText.java, line 522 >> http://code.google.com/p/piccolo2d/source/browse/piccolo2d.java/trunk/core/src/main/java/org/piccolo2d/nodes/PText.java#522 >> >> >> Why this should look different than Graphics2D.drawString, as in >> >> AbstractJava2DTextRenderingBenchmark, line 68 >> http://dishevelled.svn.sourceforge.net/viewvc/dishevelled/trunk/text-rendering-benchmark/src/main/java/org/dishevelled/text/java2d/AbstractJava2DTextRenderingBenchmark.java?revision=996&view=markup >> >> michael >> >> >> On Wed, 2 Mar 2011, Phil Race wrote: >> >>> Michael, >>> >>> I don't know anything about what the P* stuff is, and can't speak for OS X, >>> but the results all look correct in the screen shots for Sun/Oracle's >>> Swing / Java2D on Windows. So I'd say your problems are in the P* stuff. >>> Remember "gasp" may not be AA-ed - it AA's only for the sizes at which >>> the font 'gasp' table says to do so. >>> >>> -phil. >>> >>> On 3/2/2011 10:18 AM, Michael Heuer wrote: >>>> Hello, >>>> >>>> We have an outstanding issue >>>> >>>> Text rendering in PText and JLabel via PSwing appear not to respect >>>> antialiasing rendering hints >>>> >>>> http://code.google.com/p/piccolo2d/issues/detail?id=117 >>>> >>>> >>>> where code that goes down slightly different text rendering paths looks >>>> competely different with regards to antialiasing. There is a runnable jar >>>> attached to that issue that demonstrates the problem. >>>> >>>> We're looking for some help analyzing where the issue lies, in our >>>> library, in Swing text components, in Swing look& feel, or in the Java2D >>>> renderer(s). >>>> >>>> Thank you, >>>> >>>> michael >>>> >>> >> From philip.race at oracle.com Wed Mar 2 19:32:34 2011 From: philip.race at oracle.com (Phil Race) Date: Wed, 02 Mar 2011 11:32:34 -0800 Subject: [OpenJDK 2D-Dev] seeking help with text rendering In-Reply-To: References: Message-ID: <4D6E9B52.8070606@oracle.com> Michael, On 3/2/2011 11:05 AM, Michael Heuer wrote: > Hello Phil, > > Thanks for your reply. > > On Windows XP I see that jlabel-*, jtextcomponent-*, pswing-*, and > phtmlview-* all render the same, in that they ignore the LCD-specific > rendering hints I don't know what you are looking at but I am looking at text-rendering-winxp.png at the URL you referenced and JLabel does NOT ignore the LCD hints, and this XP PNG doesn't have a Jtextcomponent that I can see. > (compare e.g. jlabel-lcd-hbgr and java2d-lcd-hbgr, which > look very different on my LCD monitor, since HBGR is not appropriate for > it). I'm not sure what you meant . If you say they are different doesn't that mean something is in fact listening to them? But where is the "java2d-lcd-hbgr" sample ? Oh, is in the OS X one. As I said I don't know about that. Mac doing whatever it wants I suppose. If I had to guess they simply didn't hook up Swing to properly honour the hints or you aren't setting the hint in a way that OS X believe is applicable. So all a Mac oddity. I'm just looking at XP. Show me only on Windows (or Linux) where we do the right thing. -phil. > > PText uses java.awt.TextLayout.draw to render text, see > > PText.java, line 522 > http://code.google.com/p/piccolo2d/source/browse/piccolo2d.java/trunk/core/src/main/java/org/piccolo2d/nodes/PText.java#522 > > > Why this should look different than Graphics2D.drawString, as in > > AbstractJava2DTextRenderingBenchmark, line 68 > http://dishevelled.svn.sourceforge.net/viewvc/dishevelled/trunk/text-rendering-benchmark/src/main/java/org/dishevelled/text/java2d/AbstractJava2DTextRenderingBenchmark.java?revision=996&view=markup > > michael > > > On Wed, 2 Mar 2011, Phil Race wrote: > >> Michael, >> >> I don't know anything about what the P* stuff is, and can't speak for OS X, >> but the results all look correct in the screen shots for Sun/Oracle's >> Swing / Java2D on Windows. So I'd say your problems are in the P* stuff. >> Remember "gasp" may not be AA-ed - it AA's only for the sizes at which >> the font 'gasp' table says to do so. >> >> -phil. >> >> On 3/2/2011 10:18 AM, Michael Heuer wrote: >>> Hello, >>> >>> We have an outstanding issue >>> >>> Text rendering in PText and JLabel via PSwing appear not to respect >>> antialiasing rendering hints >>> >>> http://code.google.com/p/piccolo2d/issues/detail?id=117 >>> >>> >>> where code that goes down slightly different text rendering paths looks >>> competely different with regards to antialiasing. There is a runnable jar >>> attached to that issue that demonstrates the problem. >>> >>> We're looking for some help analyzing where the issue lies, in our >>> library, in Swing text components, in Swing look& feel, or in the Java2D >>> renderer(s). >>> >>> Thank you, >>> >>> michael >>> >> From heuermh at acm.org Wed Mar 2 20:37:39 2011 From: heuermh at acm.org (Michael Heuer) Date: Wed, 2 Mar 2011 15:37:39 -0500 (EST) Subject: [OpenJDK 2D-Dev] seeking help with text rendering In-Reply-To: <4D6E9B52.8070606@oracle.com> Message-ID: On Wed, 2 Mar 2011, Phil Race wrote: > Michael, > > On 3/2/2011 11:05 AM, Michael Heuer wrote: > > Hello Phil, > > > > Thanks for your reply. > > > > On Windows XP I see that jlabel-*, jtextcomponent-*, pswing-*, and > > phtmlview-* all render the same, in that they ignore the LCD-specific > > rendering hints > > > I don't know what you are looking at but I am looking at > text-rendering-winxp.png > at the URL you referenced and JLabel does NOT ignore the LCD hints, > and this XP PNG doesn't have a Jtextcomponent that I can see. > > > (compare e.g. jlabel-lcd-hbgr and java2d-lcd-hbgr, which > > look very different on my LCD monitor, since HBGR is not appropriate for > > it). > > I'm not sure what you meant . If you say they are different doesn't > that mean something is in fact listening to them? > > But where is the "java2d-lcd-hbgr" sample ? Oh, is in the OS X one. > As I said I don't know about that. Mac doing whatever it wants I > suppose. If I had to guess they simply didn't hook up Swing to > properly honour the hints or you aren't setting the hint in a way > that OS X believe is applicable. So all a Mac oddity. > I'm just looking at XP. Show me only on Windows (or Linux) > where we do the right thing. Sorry, those screen captures are quite old. Running the jar attached to the issue will show all the different combinations. Note that the rendering for JLabel and friends are influenced by the Windows XP system property setting described in comment #1 and by the look and feel setting for Mac OSX (cross-platform vs. Mac OSX look and feel) and OpenJDK on linux (cross-platform vs. GTK look and feel). michael From heuermh at acm.org Wed Mar 2 20:38:35 2011 From: heuermh at acm.org (Michael Heuer) Date: Wed, 2 Mar 2011 15:38:35 -0500 (EST) Subject: [OpenJDK 2D-Dev] seeking help with text rendering In-Reply-To: <4D6E9B9C.60107@oracle.com> Message-ID: Very interesting! I will investigate whether we can set the hint appropriately then. michael On Wed, 2 Mar 2011, Phil Race wrote: > TextLayout gets its AA hint from the constructor of the TextLayout > not from the Graphics2D etc. > So it was created inappropriately, it won't work as you expect. > > -phil. > > On 3/2/2011 11:10 AM, Michael Heuer wrote: > > Sorry, > > > >> PText uses java.awt.TextLayout.draw to render text, see > > should read > > > >> PText uses java.awt.font.TextLayout.draw to render text, see > > > > On Wed, 2 Mar 2011, Michael Heuer wrote: > > > >> Hello Phil, > >> > >> Thanks for your reply. > >> > >> On Windows XP I see that jlabel-*, jtextcomponent-*, pswing-*, and > >> phtmlview-* all render the same, in that they ignore the LCD-specific > >> rendering hints (compare e.g. jlabel-lcd-hbgr and java2d-lcd-hbgr, which > >> look very different on my LCD monitor, since HBGR is not appropriate for > >> it). > >> > >> > >> PText uses java.awt.TextLayout.draw to render text, see > >> > >> PText.java, line 522 > >> http://code.google.com/p/piccolo2d/source/browse/piccolo2d.java/trunk/core/src/main/java/org/piccolo2d/nodes/PText.java#522 > >> > >> > >> Why this should look different than Graphics2D.drawString, as in > >> > >> AbstractJava2DTextRenderingBenchmark, line 68 > >> http://dishevelled.svn.sourceforge.net/viewvc/dishevelled/trunk/text-rendering-benchmark/src/main/java/org/dishevelled/text/java2d/AbstractJava2DTextRenderingBenchmark.java?revision=996&view=markup > >> > >> michael > >> > >> > >> On Wed, 2 Mar 2011, Phil Race wrote: > >> > >>> Michael, > >>> > >>> I don't know anything about what the P* stuff is, and can't speak for OS X, > >>> but the results all look correct in the screen shots for Sun/Oracle's > >>> Swing / Java2D on Windows. So I'd say your problems are in the P* stuff. > >>> Remember "gasp" may not be AA-ed - it AA's only for the sizes at which > >>> the font 'gasp' table says to do so. > >>> > >>> -phil. > >>> > >>> On 3/2/2011 10:18 AM, Michael Heuer wrote: > >>>> Hello, > >>>> > >>>> We have an outstanding issue > >>>> > >>>> Text rendering in PText and JLabel via PSwing appear not to respect > >>>> antialiasing rendering hints > >>>> > >>>> http://code.google.com/p/piccolo2d/issues/detail?id=117 > >>>> > >>>> > >>>> where code that goes down slightly different text rendering paths looks > >>>> competely different with regards to antialiasing. There is a runnable jar > >>>> attached to that issue that demonstrates the problem. > >>>> > >>>> We're looking for some help analyzing where the issue lies, in our > >>>> library, in Swing text components, in Swing look& feel, or in the Java2D > >>>> renderer(s). > >>>> > >>>> Thank you, > >>>> > >>>> michael > >>>> > >>> > >> > > From philip.race at oracle.com Fri Mar 4 00:06:48 2011 From: philip.race at oracle.com (philip.race at oracle.com) Date: Fri, 04 Mar 2011 00:06:48 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7023589: Xrender : NullPointerException in sun.font.XRGlyphCache.freeGlyphs running Java 2D demo Message-ID: <20110304000729.519CE47C41@hg.openjdk.java.net> Changeset: 01dcb496946e Author: ceisserer Date: 2011-03-03 16:06 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/01dcb496946e 7023589: Xrender : NullPointerException in sun.font.XRGlyphCache.freeGlyphs running Java 2D demo Reviewed-by: prr ! src/share/classes/sun/font/StrikeCache.java ! src/solaris/classes/sun/font/XRGlyphCache.java From dlila at redhat.com Fri Mar 4 21:04:12 2011 From: dlila at redhat.com (Denis Lila) Date: Fri, 4 Mar 2011 16:04:12 -0500 (EST) Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <119116158.211038.1299272072222.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <1208014447.211146.1299272652538.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Hi. In my last push to pisces I introduced a regression. The scanline iterator doesn't iterate over the last scanline. This: http://icedtea.classpath.org/~dlila/webrevs/7019861_skipped_last_scanline/webrev/ fixes it. The webrev also includes a workaround for a hotspot bug and a minor optimization in Renderer.java (eliminating a range check on edgeBucketCounts). Is it ok to push? Thank you, Denis. From james.graham at oracle.com Fri Mar 4 23:19:45 2011 From: james.graham at oracle.com (Jim Graham) Date: Fri, 04 Mar 2011 15:19:45 -0800 Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <1208014447.211146.1299272652538.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> References: <1208014447.211146.1299272652538.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <4D717391.4090808@oracle.com> Hi Denis, Renderer.java: line 52: and => or? line 355: Make that "16" a constant? line 535: Would it work to use pminY and pmaxY? Will there be any active edges to iterate outside of that range? Stroker.java: Is this blocking anyone until they find the Hotspot problem? ...jim On 3/4/2011 1:04 PM, Denis Lila wrote: > Hi. > > In my last push to pisces I introduced a regression. > The scanline iterator doesn't iterate over the last > scanline. This: http://icedtea.classpath.org/~dlila/webrevs/7019861_skipped_last_scanline/webrev/ > fixes it. > > The webrev also includes a workaround for a hotspot > bug and a minor optimization in Renderer.java (eliminating > a range check on edgeBucketCounts). > > Is it ok to push? > > Thank you, > Denis. From dlila at redhat.com Fri Mar 4 23:40:37 2011 From: dlila at redhat.com (Denis Lila) Date: Fri, 4 Mar 2011 18:40:37 -0500 (EST) Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <4D717391.4090808@oracle.com> Message-ID: <551102634.216501.1299282037004.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Hi Jim. > line 52: and => or? No, because our ranges are half open, so if lastCrossing == end, that means the line ends just before end and hence doesn't cross it. > line 355: Make that "16" a constant? Sure. > Is this blocking anyone until they find the Hotspot problem? Not to my knowledge, but it has been very annoying when running some of my own tests. > line 535: Would it work to use pminY and pmaxY? Will there be any > active edges to iterate outside of that range? I'm not sure I understand. I do use pminY and pmaxY - just their subpixel versions. If we used pminY and pmaxY instead of subpix_pminY and subpix_pmaxY that would just mean we'd have to compute the subpixel versions in _endRendering (or ScanlineIterator.). I've updated the webrev. Thank you, Denis. ----- Original Message ----- > Hi Denis, > > Renderer.java: > > > > > Stroker.java: > > > ...jim > > On 3/4/2011 1:04 PM, Denis Lila wrote: > > Hi. > > > > In my last push to pisces I introduced a regression. > > The scanline iterator doesn't iterate over the last > > scanline. This: > > http://icedtea.classpath.org/~dlila/webrevs/7019861_skipped_last_scanline/webrev/ > > fixes it. > > > > The webrev also includes a workaround for a hotspot > > bug and a minor optimization in Renderer.java (eliminating > > a range check on edgeBucketCounts). > > > > Is it ok to push? > > > > Thank you, > > Denis. From philip.race at oracle.com Fri Mar 4 23:54:35 2011 From: philip.race at oracle.com (philip.race at oracle.com) Date: Fri, 04 Mar 2011 23:54:35 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7023591: Xrender: java2D font demo - text highlighting tab content is black Message-ID: <20110304235512.55CE247D0D@hg.openjdk.java.net> Changeset: f82f0af7de5b Author: prr Date: 2011-03-04 15:54 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f82f0af7de5b 7023591: Xrender: java2D font demo - text highlighting tab content is black Reviewed-by: flar ! src/share/classes/sun/java2d/pipe/AAShapePipe.java From lana.steuck at oracle.com Mon Mar 7 17:35:43 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 07 Mar 2011 17:35:43 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d: 12 new changesets Message-ID: <20110307173543.9B88F47F0D@hg.openjdk.java.net> Changeset: 0fd0aeb592cb Author: jqzuo Date: 2010-12-09 10:58 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/rev/0fd0aeb592cb Merge Changeset: 20955959b7b7 Author: jqzuo Date: 2010-12-22 15:55 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/rev/20955959b7b7 Merge Changeset: 08fe18caf411 Author: jqzuo Date: 2011-01-10 13:45 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/rev/08fe18caf411 Merge Changeset: aee1b0183364 Author: jqzuo Date: 2011-01-24 17:14 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/rev/aee1b0183364 Merge Changeset: 12764a5a3aec Author: jqzuo Date: 2011-02-01 15:03 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/rev/12764a5a3aec Merge Changeset: df3abd560cbd Author: jqzuo Date: 2011-02-09 16:05 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/rev/df3abd560cbd Merge Changeset: e2370dfcc721 Author: paulk Date: 2011-02-14 14:29 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/rev/e2370dfcc721 7019371: JDK7 is not building UPX. IFTW wrappers are not compressed. Reviewed-by: billyh, jqzuo ! make/deploy-rules.gmk Changeset: 5466f13d19be Author: jqzuo Date: 2011-02-21 14:18 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/rev/5466f13d19be Merge Changeset: da55264ff2fb Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/da55264ff2fb 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 5d86d951426a Author: cl Date: 2011-02-23 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/5d86d951426a Merge Changeset: 0f62a65fb666 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/0f62a65fb666 Added tag jdk7-b131 for changeset 5d86d951426a ! .hgtags Changeset: b1fafacc3040 Author: katleman Date: 2011-03-03 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/b1fafacc3040 Added tag jdk7-b132 for changeset 0f62a65fb666 ! .hgtags From lana.steuck at oracle.com Mon Mar 7 17:35:48 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 07 Mar 2011 17:35:48 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jaxp: 4 new changesets Message-ID: <20110307173549.14CEA47F0E@hg.openjdk.java.net> Changeset: a57220f22751 Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/a57220f22751 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: eab6f27131e4 Author: cl Date: 2011-02-23 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/eab6f27131e4 Merge Changeset: abe04c59a556 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/abe04c59a556 Added tag jdk7-b131 for changeset eab6f27131e4 ! .hgtags Changeset: 8e1148c7911b Author: katleman Date: 2011-03-03 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/8e1148c7911b Added tag jdk7-b132 for changeset abe04c59a556 ! .hgtags From lana.steuck at oracle.com Mon Mar 7 17:35:51 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 07 Mar 2011 17:35:51 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jaxws: 4 new changesets Message-ID: <20110307173551.C9D5347F0F@hg.openjdk.java.net> Changeset: 9e3904866cab Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/9e3904866cab 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 438abc0356cd Author: cl Date: 2011-02-23 15:49 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/438abc0356cd Merge Changeset: 0e57c3272d37 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/0e57c3272d37 Added tag jdk7-b131 for changeset 438abc0356cd ! .hgtags Changeset: 359d0c8c00a0 Author: katleman Date: 2011-03-03 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/359d0c8c00a0 Added tag jdk7-b132 for changeset 0e57c3272d37 ! .hgtags From lana.steuck at oracle.com Mon Mar 7 17:35:43 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 07 Mar 2011 17:35:43 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/corba: 4 new changesets Message-ID: <20110307173551.E075347F10@hg.openjdk.java.net> Changeset: a9335b646c1c Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/corba/rev/a9335b646c1c 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 9d6dd2cdfcb9 Author: cl Date: 2011-02-23 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/corba/rev/9d6dd2cdfcb9 Merge Changeset: 1b1e75e8f476 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/corba/rev/1b1e75e8f476 Added tag jdk7-b131 for changeset 9d6dd2cdfcb9 ! .hgtags Changeset: 671fe2e623ff Author: katleman Date: 2011-03-03 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/corba/rev/671fe2e623ff Added tag jdk7-b132 for changeset 1b1e75e8f476 ! .hgtags From lana.steuck at oracle.com Mon Mar 7 17:36:04 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 07 Mar 2011 17:36:04 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/langtools: 22 new changesets Message-ID: <20110307173652.4C2E147F13@hg.openjdk.java.net> Changeset: 22ea7d483794 Author: ohair Date: 2011-02-16 13:30 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/22ea7d483794 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 67221b8643b4 Author: cl Date: 2011-02-23 15:49 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/67221b8643b4 Merge Changeset: 80bbd1da4a72 Author: cl Date: 2011-02-24 15:16 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/80bbd1da4a72 Added tag jdk7-b131 for changeset 67221b8643b4 ! .hgtags Changeset: c6cb387190ee Author: jjg Date: 2011-02-09 14:04 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/c6cb387190ee 7016750: tools/javac/nio/CompileTest failing in nightly test Reviewed-by: mcimadamore ! test/tools/javac/nio/compileTest/CompileTest.java Changeset: 3ce4e1a07e92 Author: jjg Date: 2011-02-09 14:10 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/3ce4e1a07e92 7010792: remove bad debugging method from javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/Scanner.java Changeset: bfa59f3e84bd Author: jjg Date: 2011-02-09 18:26 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/bfa59f3e84bd 7018447: langtools launcher template fails if tools run from their own directory Reviewed-by: jjg Contributed-by: daniel.smith at oracle.com ! src/share/bin/launcher.sh-template Changeset: a19b1f4f23c9 Author: jjg Date: 2011-02-10 14:24 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/a19b1f4f23c9 7018098: CacheFSInfo persists too long Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/CacheFSInfo.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/file/T7018098.java Changeset: 747a7601b6d6 Author: jjg Date: 2011-02-10 14:27 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/747a7601b6d6 7018452: langtools not buildable on Mac Reviewed-by: ohair ! make/build.xml Changeset: e0c16199b2e0 Author: jjg Date: 2011-02-10 15:05 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/e0c16199b2e0 6485027: javac incorrectly handles relative paths in manifest classpath Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/Paths.java ! test/tools/javac/Paths/Class-Path.sh + test/tools/javac/Paths/Class-Path2.sh ! test/tools/javac/Paths/Diagnostics.sh Changeset: bfeed79c70aa Author: jjg Date: 2011-02-11 17:10 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/bfeed79c70aa 6505047: javax.lang.model.element.Element.getEnclosingElement() doesn't return null for type parameter Reviewed-by: darcy + test/tools/javac/processing/model/element/TestTypeParameter.java Changeset: ef6c66215a93 Author: jjg Date: 2011-02-14 14:27 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/ef6c66215a93 7008433: Minor copyright changes Reviewed-by: jjg Contributed-by: kelly.ohair at oracle.com ! test/tools/javac/4917091/Test255.java ! test/tools/javac/4917091/Test256a.java ! test/tools/javac/4917091/Test256b.java Changeset: 351027202f60 Author: mcimadamore Date: 2011-02-15 11:49 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/351027202f60 7017664: Add listeners infrastracture to javac scopes Summary: Add listeners to javac scopes, added CompoundScope and correct invalidation logic for ImplementationCache Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/scope/7017664/CompoundScopeTest.java + test/tools/javac/scope/7017664/ImplementationCacheTest.java Changeset: fa0e4e1916f4 Author: mcimadamore Date: 2011-02-15 11:51 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/fa0e4e1916f4 7017104: improve error reporting for uncaught/undeclared exceptions from try-with-resources Summary: twr should generate better error message when uncaught exceptions are thrown by implicit call of close() method Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/TryWithResources/ResourceInterface.out ! test/tools/javac/TryWithResources/TwrFlow.out + test/tools/javac/diags/examples/UnreportedExceptionImplicitClose.java Changeset: 846d6644bb70 Author: lana Date: 2011-02-15 08:35 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/846d6644bb70 Merge Changeset: 0c24826853b2 Author: dlsmith Date: 2011-02-16 10:27 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/0c24826853b2 6990136: Cleanup use of Type.clone() Summary: Introduced factory methods in class Types which can be used rather than clone(). Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: 4ce95dc0b908 Author: mcimadamore Date: 2011-02-18 12:28 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/4ce95dc0b908 7020043: Project Coin: diamond allowed on non-generic type Summary: Diamond oerator should be disallowed on non-generic class types (i.e. String) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/generics/diamond/neg/Neg12.java + test/tools/javac/generics/diamond/neg/Neg12.out Changeset: 3d45cc94ee0f Author: ksrini Date: 2011-02-18 08:12 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/3d45cc94ee0f 7018859: javac turn off the Zip optimization by default Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! test/tools/javac/4241573/T4241573.java ! test/tools/javac/6508981/TestInferBinaryName.java ! test/tools/javac/api/6411310/Test.java ! test/tools/javac/api/T6838467.java ! test/tools/javac/api/T6877206.java Changeset: 51e643f41a3a Author: mcimadamore Date: 2011-02-18 16:17 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/51e643f41a3a 7020626: diamond: add diagnostic test for diamond and non-generic classes Summary: Fix failure in regression test CheckExamples Reviewed-by: jjg + test/tools/javac/diags/examples/DiamondNonGeneric.java Changeset: 75e25df50873 Author: darcy Date: 2011-02-18 15:55 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/75e25df50873 7020047: Project Coin: generate null-check around try-with-resources close call Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/TryWithResources/TwrNullTests.java Changeset: de5524670f80 Author: lana Date: 2011-02-21 14:35 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/de5524670f80 Merge Changeset: e3d011d59a33 Author: lana Date: 2011-02-24 18:05 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/e3d011d59a33 Merge Changeset: e77e98f936e8 Author: katleman Date: 2011-03-03 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/e77e98f936e8 Added tag jdk7-b132 for changeset e3d011d59a33 ! .hgtags From lana.steuck at oracle.com Mon Mar 7 17:36:05 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 07 Mar 2011 17:36:05 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/hotspot: 55 new changesets Message-ID: <20110307173746.A6BFB47F16@hg.openjdk.java.net> Changeset: cdef89d821bd Author: ohair Date: 2011-02-16 13:30 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/cdef89d821bd 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 0aa3b4908911 Author: cl Date: 2011-02-23 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/0aa3b4908911 Merge Changeset: 2015d9b41531 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/2015d9b41531 Added tag jdk7-b131 for changeset 0aa3b4908911 ! .hgtags Changeset: f3e07ceeaed9 Author: trims Date: 2011-02-25 11:42 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/f3e07ceeaed9 Added tag hs21-b02 for changeset e9aa2ca89ad6 ! .hgtags Changeset: 7dc5384467e0 Author: coleenp Date: 2011-02-12 10:28 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/7dc5384467e0 7022659: errorHandler doesn't compile without precompiled headers Summary: add proper includes in errorHandler.hpp Reviewed-by: phh, kamg ! src/share/vm/utilities/errorReporter.hpp Changeset: c798c277ddd1 Author: brutisso Date: 2011-02-03 20:49 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/c798c277ddd1 7015169: GC Cause not always set Summary: Sometimes the gc cause was not always set. This caused JStat to print the wrong information. Reviewed-by: tonyp, ysr Contributed-by: suenaga.yasumasa at oss.ntt.co.jp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.hpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.hpp ! src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.hpp ! src/share/vm/gc_interface/gcCause.cpp ! src/share/vm/gc_interface/gcCause.hpp ! src/share/vm/services/heapDumper.cpp Changeset: c5a923563727 Author: ysr Date: 2011-02-07 22:19 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/c5a923563727 6912621: iCMS: Error: assert(_markBitMap.isMarked(addr + 1),"Missing Printezis bit?") Summary: Fix block_size_if_printezis_bits() so it does not expect the bits, only uses them when available. Fix block_size_no_stall() so it does not stall when the bits are missing such cases, letting the caller deal with zero size returns. Constant pool cache oops do not need to be unparsable or conc_unsafe after their klass pointer is installed. Some cosmetic clean-ups and some assertion checking for conc-usafety which, in the presence of class file redefinition, has no a-priori time boundedness, so all GCs must be able to safely deal with putatively conc-unsafe objects in a stop-world pause. Reviewed-by: jmasa, johnc ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/cpCacheKlass.cpp ! src/share/vm/oops/cpCacheKlass.hpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/oops/oop.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandleWalk.cpp Changeset: e5383553fd4e Author: stefank Date: 2011-02-08 12:33 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/e5383553fd4e 7014851: Remove unused parallel compaction code Summary: Removed. Reviewed-by: jcoomes, brutisso ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/oops/arrayKlassKlass.cpp ! src/share/vm/oops/compiledICHolderKlass.cpp ! src/share/vm/oops/constMethodKlass.cpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/cpCacheKlass.cpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/klassKlass.cpp ! src/share/vm/oops/klassPS.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/methodDataKlass.cpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/methodKlass.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlassKlass.cpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.pcgc.inline.hpp ! src/share/vm/oops/typeArrayKlass.cpp Changeset: 59e20a452a2a Author: johnc Date: 2011-02-09 09:43 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/59e20a452a2a 7017008: G1: Turn on compressed oops by default. Summary: Normally compressed oops is enabled when the maximum heap size is under a certain limit, except when G1 is also enabled. Remove this limitation. Also re-enable GCBasher testing with G1 on 64 bit windows in jprt. Reviewed-by: jcoomes, brutisso, tonyp ! make/jprt.properties ! src/share/vm/runtime/arguments.cpp Changeset: 183658a2d0b3 Author: ysr Date: 2011-02-10 14:48 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/183658a2d0b3 7018302: newly added assert related to size of constantPoolOop causes secondary assertions or crashes Summary: 6912621 used a raw oop in the newly added assert following an allocation attempt that could result in a GC. Reviewed-by: jmasa ! src/share/vm/oops/constantPoolKlass.cpp Changeset: 55cc33cf55bc Author: stefank Date: 2011-02-11 14:15 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/55cc33cf55bc 7018257: jmm_DumpThreads allocates into permgen Summary: Don't allocate in permgen Reviewed-by: ysr, sla ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/services/management.cpp Changeset: f7702f8c0e25 Author: tonyp Date: 2011-02-14 22:21 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/f7702f8c0e25 Merge ! make/jprt.properties ! src/share/vm/services/management.cpp Changeset: 02368ad6c63f Author: trims Date: 2011-02-16 17:26 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/02368ad6c63f Merge Changeset: 15d6977f04b0 Author: sla Date: 2011-02-10 13:03 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/15d6977f04b0 7017824: Add support for creating 64-bit Visual Studio projects Summary: Updated create.bat and ProjectCreator Reviewed-by: brutisso, stefank, ohair ! make/windows/create.bat ! make/windows/makefiles/compile.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/rules.make - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 ! make/windows/projectfiles/common/Makefile ! src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp ! src/share/tools/ProjectCreator/BuildConfig.java ! src/share/tools/ProjectCreator/DirectoryTree.java ! src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java ! src/share/tools/ProjectCreator/Util.java ! src/share/tools/ProjectCreator/WinGammaPlatform.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC6.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC7.java ! src/share/vm/adlc/adlc.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp Changeset: 7aa1f99ca301 Author: coleenp Date: 2011-02-12 10:28 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/7aa1f99ca301 7019157: errorHandler doesn't compile with super old gcc without precompiled headers Summary: old gccs don't support precompiled headers so have to supply includes Reviewed-by: phh, kamg ! src/share/vm/utilities/errorReporter.hpp Changeset: 54df4702df97 Author: rottenha Date: 2011-02-14 03:19 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/54df4702df97 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java Changeset: de14f1eee390 Author: dcubed Date: 2011-02-15 19:00 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/de14f1eee390 6954420: 2/4 jps shows "process information unavailable" sometimes Summary: Make sure the backing store file is flushed in create_sharedmem_resources() and get_user_name_slow() no longer checks the size of the backing store file. Reviewed-by: briand, swamyv, acorn, poonam ! src/os/windows/vm/perfMemory_windows.cpp Changeset: b76d12f4ab2d Author: dholmes Date: 2011-02-14 19:27 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/b76d12f4ab2d 7018429: JPRT: Update Makefile to use ALT_JDK_TARGET_IMPORT_PATH for copying JDK Summary: Set JDK_IMPORT_PATH to ALT_JDK_TARGET_IMPORT_PATH if it is defined Reviewed-by: phh, ohair ! make/Makefile ! make/defs.make Changeset: 5415131bc5ab Author: dholmes Date: 2011-02-16 01:42 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/5415131bc5ab Merge Changeset: c08677f98289 Author: coleenp Date: 2011-02-16 11:34 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/c08677f98289 6840152: JVM crashes when heavyweight monitors are used Summary: Turn off biased locking if !UseFastLocking or UseHeavyMonitors options are requested. Reviewed-by: phh, never, dcubed, dholmes ! src/share/vm/runtime/arguments.cpp Changeset: 3adec115d40d Author: coleenp Date: 2011-02-16 17:12 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/3adec115d40d 7019689: Non-dependent name is found in dependent base class although it should be rejected Summary: fix hashtable.hpp to qualify non-dependant name with "this" Reviewed-by: phh, never, poonam Contributed-by: volker.simonis at gmail.com ! src/share/vm/utilities/hashtable.hpp Changeset: a959935a5732 Author: coleenp Date: 2011-02-16 16:25 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/a959935a5732 Merge Changeset: 6e70f1bb7f6f Author: coleenp Date: 2011-02-18 18:26 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/6e70f1bb7f6f 7019557: SharedMiscDataSize too small for 64-bit fastdebug JVM Summary: Increase default SharedMiscDataSize Reviewed-by: dcubed, kamg ! src/share/vm/runtime/globals.hpp Changeset: f77b3ec064b0 Author: rottenha Date: 2011-02-21 04:49 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/f77b3ec064b0 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 4f26f535a225 Author: never Date: 2011-01-31 17:48 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/4f26f535a225 6354181: nsk.logging.stress.threads.scmhml001 fails assertion in "src/share/vm/oops/instanceKlass.cpp, 111" Reviewed-by: jrose, acorn ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/classfile/loaderConstraints.cpp ! src/share/vm/classfile/systemDictionary.cpp Changeset: 638119ce7cfd Author: twisti Date: 2011-02-01 03:38 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/638119ce7cfd 7009309: JSR 292: compiler/6991596/Test6991596.java crashes on fastdebug JDK7/b122 Reviewed-by: kvn, never ! agent/src/share/classes/sun/jvm/hotspot/runtime/StubRoutines.java ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/interpreter_x86.hpp ! src/cpu/x86/vm/interpreter_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.hpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/zero/vm/stubRoutines_zero.cpp ! src/cpu/zero/vm/stubRoutines_zero.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fbf3184da15d Author: twisti Date: 2011-02-01 05:51 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/fbf3184da15d 7012339: JSR 292 crash in G1SATBCardTableModRefBS::write_ref_field_pre_work() Reviewed-by: jrose, never ! src/share/vm/oops/cpCacheOop.cpp Changeset: c52cba2a3359 Author: kvn Date: 2011-02-01 10:27 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/c52cba2a3359 7014998: assert(is_T_family(features) == is_niagara(features)) failed: Niagara should be T series Summary: Use substring search instead of compare and convert string to upper case before search. Reviewed-by: never, phh, iveresov ! src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp Changeset: 194c9fdee631 Author: kvn Date: 2011-02-07 09:46 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/194c9fdee631 7017240: C2: native memory leak in nsk/regression/b4675027 on windows-x86 in comp mode with G1 Summary: Add ResourceMark into PhaseIdealLoop::build_and_optimize(). Reviewed-by: never ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp Changeset: 3763ca6579b7 Author: kvn Date: 2011-02-07 10:25 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/3763ca6579b7 7013538: Java memory leak with escape analysis Summary: Don't allocate VectorSet iterator on C heap. Reuse resource storage in EA. Reviewed-by: never ! src/share/vm/libadt/vectset.cpp ! src/share/vm/libadt/vectset.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp ! src/share/vm/opto/phase.cpp Changeset: f7de3327c683 Author: kvn Date: 2011-02-07 10:34 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/f7de3327c683 7017124: Fix some VM stats to avoid 32-bit overflow Summary: Added new method inc_stat_counter() to increment long statistic values and use atomic long load and store. Reviewed-by: dholmes, jrose, phh, never ! src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.inline.hpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/opto/indexSet.cpp ! src/share/vm/opto/indexSet.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp Changeset: 336d17dff7cc Author: kvn Date: 2011-02-08 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/336d17dff7cc 7014874: Incorrect COOPs modes on solaris-{sparcv9,amd64} with ParallelGC Summary: Align old gen size down to keep specified heap size. Reviewed-by: ysr ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp Changeset: 72d6c57d0658 Author: iveresov Date: 2011-02-09 16:34 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/72d6c57d0658 7017434: Tiered needs to support reprofiling Summary: Tiered needs to support proper method reprofiling after deopts. Reviewed-by: kvn ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.hpp Changeset: 62a8557e8f36 Author: twisti Date: 2011-02-10 00:47 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/62a8557e8f36 7018277: JSR 292 change test/compiler/6987555/Test6987555.java to new MH syntax Summary: test/compiler/6987555/Test6987555.java currently does not compile because the MH return-type syntax has changed. Reviewed-by: never ! test/compiler/6987555/Test6987555.java Changeset: ab42c7e1cf83 Author: kvn Date: 2011-02-10 14:25 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/ab42c7e1cf83 7017746: Regression : C2 compiler crash due to SIGSEGV in PhaseCFG::schedule_early() Summary: Add TEMP edges (and KILL projections) before duplicated operands are removed in Expand() methods. Reviewed-by: never ! src/cpu/sparc/vm/sparc.ad ! src/share/vm/adlc/output_c.cpp ! src/share/vm/opto/node.cpp + test/compiler/7017746/Test.java Changeset: bf29934d2f4f Author: kvn Date: 2011-02-10 19:34 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/bf29934d2f4f 7018849: 7017124 fix broke VM build on some platforms Summary: Use atomic load and store in inc_stat_counter() only on SPARC and X86. Reviewed-by: iveresov ! src/share/vm/memory/allocation.inline.hpp Changeset: 173926398291 Author: twisti Date: 2011-02-11 03:17 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/173926398291 7018673: Zero: 6953144, 6990754 and 7009756 made some changes which broke Zero Reviewed-by: kvn, chrisphi, twisti ! src/os_cpu/linux_zero/vm/atomic_linux_zero.inline.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/oops/methodOop.cpp Changeset: 34457f6ac818 Author: never Date: 2011-02-11 12:05 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/34457f6ac818 7018506: CTW swallowing OOMs after symbol changes Reviewed-by: kvn, iveresov, coleenp ! src/share/vm/classfile/classLoader.cpp Changeset: 28bf941f445e Author: twisti Date: 2011-02-14 03:21 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/28bf941f445e 7018378: JSR 292: _bound_int_mh produces wrong result on 64-bit SPARC Reviewed-by: kvn ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp Changeset: 2a57c59eb548 Author: never Date: 2011-02-14 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/2a57c59eb548 7018101: os::dll_address_to_function_name returning wrong answers in 64 bit Reviewed-by: acorn, kvn, dsamersoff ! src/os/solaris/vm/os_solaris.cpp Changeset: 850b2295a494 Author: kvn Date: 2011-02-14 14:36 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/850b2295a494 Merge ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 1957c1478794 Author: never Date: 2011-02-15 22:18 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/1957c1478794 7019819: bare oop in ciField Reviewed-by: kvn, iveresov ! src/share/vm/ci/ciField.cpp Changeset: 6bbaedb03534 Author: never Date: 2011-02-09 15:02 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/6bbaedb03534 7016474: string compare intrinsic improvements Reviewed-by: kvn ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad Changeset: 5841dc1964f0 Author: never Date: 2011-02-22 15:26 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/5841dc1964f0 7021531: lock ordering problems after fix for 6354181 Reviewed-by: kvn, jrose ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp Changeset: a97fd181b813 Author: kvn Date: 2011-02-23 11:18 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/a97fd181b813 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/runtime/globals.hpp Changeset: 162b62460264 Author: dholmes Date: 2011-02-24 21:38 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/162b62460264 7021953: Remove flags from globals.hpp inadvertently dragged in by 7016023 Summary: removed erroneous flags Reviewed-by: kvn, dcubed ! src/share/vm/runtime/globals.hpp Changeset: cf16c93393f5 Author: rottenha Date: 2011-02-25 03:29 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/cf16c93393f5 Merge ! src/share/vm/runtime/globals.hpp Changeset: 02f78cfa4656 Author: stefank Date: 2011-02-21 11:26 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/02f78cfa4656 7020992: jmm_DumpThreads should not allocate system object arrays outside the perm gen Summary: Allocate ordinary object arrays Reviewed-by: ysr, never, mchung ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/services/management.cpp Changeset: 8bbefb9743ae Author: tonyp Date: 2011-02-25 10:58 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/8bbefb9743ae Merge Changeset: 76b97f73ee91 Author: tonyp Date: 2011-02-25 08:17 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/76b97f73ee91 Merge Changeset: 5a4223160326 Author: trims Date: 2011-02-25 12:46 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/5a4223160326 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java Changeset: 658d198b2e04 Author: trims Date: 2011-02-25 12:46 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/658d198b2e04 7022570: Bump the HS21 build number to 03 Summary: Update the HS21 build number to 03 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 0e531ab5ba04 Author: trims Date: 2011-03-01 11:53 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/0e531ab5ba04 Merge Changeset: a8d643a4db47 Author: katleman Date: 2011-03-03 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/a8d643a4db47 Added tag jdk7-b132 for changeset 0e531ab5ba04 ! .hgtags Changeset: 1b3a350709e4 Author: trims Date: 2011-03-03 15:13 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/1b3a350709e4 Added tag hs21-b03 for changeset a8d643a4db47 ! .hgtags From lana.steuck at oracle.com Mon Mar 7 17:38:04 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 07 Mar 2011 17:38:04 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 59 new changesets Message-ID: <20110307174817.73B3247F1A@hg.openjdk.java.net> Changeset: 0355c60c2da4 Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/0355c60c2da4 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 9b2631288894 Author: ohair Date: 2011-02-16 14:33 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/9b2631288894 7010594: Add /SAFESEH to links on windows to verify safe exceptions Reviewed-by: alanb ! make/common/Defs-windows.gmk ! make/common/shared/Defs-windows.gmk Changeset: 5e09deee1967 Author: andrew Date: 2011-02-23 17:10 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5e09deee1967 7021314: Build should not install javaws man page Summary: Only install javaws.1 when not building OpenJDK Reviewed-by: alanb, ohair ! make/common/Release.gmk Changeset: 8ac52c85f9e9 Author: cl Date: 2011-02-23 15:49 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/8ac52c85f9e9 Merge Changeset: 11c9a066a5a4 Author: cl Date: 2011-02-24 15:16 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/11c9a066a5a4 Added tag jdk7-b131 for changeset 8ac52c85f9e9 ! .hgtags Changeset: d7de46ec011b Author: jrose Date: 2011-02-11 01:26 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/d7de46ec011b 7013417: JSR 292 needs to support variadic method handle calls Summary: Implement MH.asVarargsCollector, etc., and remove withTypeHandler. Reviewed-by: twisti ! src/share/classes/java/dyn/MethodHandle.java ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/package-info.java ! src/share/classes/sun/dyn/AdapterMethodHandle.java ! src/share/classes/sun/dyn/CallSiteImpl.java ! src/share/classes/sun/dyn/InvokeGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/MethodTypeImpl.java ! test/java/dyn/InvokeDynamicPrintArgs.java ! test/java/dyn/JavaDocExamplesTest.java ! test/java/dyn/MethodHandlesTest.java ! test/java/dyn/indify/Indify.java Changeset: c86c60ad8822 Author: jrose Date: 2011-02-11 01:26 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c86c60ad8822 7012650: implement JSR 292 EG adjustments through January 2010 Summary: misc. EG changes and polishes (excluding 7013417) Reviewed-by: twisti ! src/share/classes/java/dyn/CallSite.java ! src/share/classes/java/dyn/ClassValue.java ! src/share/classes/java/dyn/ConstantCallSite.java ! src/share/classes/java/dyn/InvokeDynamicBootstrapError.java ! src/share/classes/java/dyn/Linkage.java ! src/share/classes/java/dyn/MethodHandle.java ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/MethodType.java ! src/share/classes/java/dyn/MutableCallSite.java + src/share/classes/java/dyn/SwitchPoint.java - src/share/classes/java/dyn/Switcher.java ! src/share/classes/java/dyn/VolatileCallSite.java ! src/share/classes/java/dyn/WrongMethodTypeException.java ! src/share/classes/java/dyn/package-info.java ! src/share/classes/sun/dyn/AdapterMethodHandle.java ! src/share/classes/sun/dyn/FromGeneric.java ! src/share/classes/sun/dyn/InvokeGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/ToGeneric.java + src/share/classes/sun/dyn/WrapperInstance.java ! test/java/dyn/InvokeGenericTest.java ! test/java/dyn/JavaDocExamplesTest.java ! test/java/dyn/MethodHandlesTest.java Changeset: a2241b109aa1 Author: jrose Date: 2011-02-11 01:26 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/a2241b109aa1 7013730: JSR 292 reflective operations should report errors with standard exception types Summary: remove NoAccessException, replace it by ReflectiveOperationException subtypes; adjust javadoc of exceptions Reviewed-by: twisti ! src/share/classes/java/dyn/CallSite.java ! src/share/classes/java/dyn/Linkage.java ! src/share/classes/java/dyn/MethodHandles.java - src/share/classes/java/dyn/NoAccessException.java ! src/share/classes/sun/dyn/CallSiteImpl.java ! src/share/classes/sun/dyn/FilterGeneric.java ! src/share/classes/sun/dyn/FilterOneArgument.java ! src/share/classes/sun/dyn/FromGeneric.java ! src/share/classes/sun/dyn/InvokeGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MemberName.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/MethodHandleNatives.java ! src/share/classes/sun/dyn/SpreadGeneric.java ! src/share/classes/sun/dyn/ToGeneric.java ! src/share/classes/sun/dyn/util/ValueConversions.java ! src/share/classes/sun/dyn/util/VerifyAccess.java ! test/java/dyn/InvokeGenericTest.java ! test/java/dyn/JavaDocExamplesTest.java ! test/java/dyn/MethodHandlesTest.java Changeset: 5e4a41d0fccd Author: jrose Date: 2011-02-15 00:16 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5e4a41d0fccd 7016261: JSR 292 MethodType objects should be serializable Summary: Define private writeObject, readObject, and readResolve methods. Also add unit tests. Reviewed-by: twisti ! src/share/classes/java/dyn/MethodType.java + test/java/dyn/MethodTypeTest.java Changeset: 56cbd0504a53 Author: jrose Date: 2011-02-15 00:16 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/56cbd0504a53 7014755: JSR 292 member lookup interaction with security manager Summary: add security manager interactions for Lookup methods Reviewed-by: twisti ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/package-info.java Changeset: 52bcd47b4521 Author: jrose Date: 2011-02-15 00:16 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/52bcd47b4521 7016520: JSR 292 rules for polymorphic signature processing must be in package-info Summary: insert rules for bytecode processors to recognize signature polymorphic names Reviewed-by: twisti ! src/share/classes/java/dyn/MethodHandle.java Changeset: f6cd84cfed70 Author: trims Date: 2011-02-25 12:48 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f6cd84cfed70 Merge - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java Changeset: fa6547fa57e6 Author: lana Date: 2011-02-21 14:22 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/fa6547fa57e6 Merge Changeset: 5a6bd7df28b8 Author: lana Date: 2011-02-11 15:51 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5a6bd7df28b8 Merge - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 14d9e6af8889 Author: andrew Date: 2011-02-15 15:09 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/14d9e6af8889 7017581: missing copyright header in test/sun/java2d/pipe/RegionOps.java Reviewed-by: anthony ! test/sun/java2d/pipe/RegionOps.java Changeset: 7c98b6b4e8a7 Author: dav Date: 2011-02-16 01:12 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/7c98b6b4e8a7 6994933: java.awt.Desktop feature is "intermittently" supported on Solaris. Really unexpected behavior. Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XDesktopPeer.java ! src/solaris/native/sun/xawt/awt_Desktop.c Changeset: 41da8f9ea83a Author: lana Date: 2011-02-21 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/41da8f9ea83a Merge Changeset: eeaad0d340b2 Author: peytoia Date: 2011-02-09 18:00 +0900 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/eeaad0d340b2 7017800: (tz) Support tzdata2011b Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java Changeset: 493a9eeb9bca Author: alexp Date: 2011-02-10 21:36 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/493a9eeb9bca 6993171: JavaTest/JDK7b114 - no help text is shown for interview questions, JavaTest HANGS UP Reviewed-by: rupashka ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JLayer.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/plaf/LayerUI.java ! test/javax/swing/JComponent/6989617/bug6989617.java Changeset: be8045e2d792 Author: lana Date: 2011-02-11 12:14 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/be8045e2d792 Merge - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 82f7b8f6b174 Author: alexp Date: 2011-02-15 16:40 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/82f7b8f6b174 6956842: BasicTreeUI.getPreferredSize(JComp c) is delegated to getPreferredSize(c, true) not (c, false) Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java Changeset: be44bda15fcf Author: okutsu Date: 2011-02-16 16:51 +0900 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/be44bda15fcf 6936350: API clarification needed on useDaylightTime() for timezones that have defined usage dates Reviewed-by: peytoia ! src/share/classes/java/util/SimpleTimeZone.java ! src/share/classes/java/util/TimeZone.java + test/java/util/TimeZone/DaylightTimeTest.java Changeset: f326139e7fda Author: malenkov Date: 2011-02-16 18:32 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f326139e7fda 6980124: closed/javax/swing/plaf/synth/SynthPainter/unitTest/UnitTest.java fails Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java Changeset: 888baed5c55b Author: rupashka Date: 2011-02-18 00:16 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/888baed5c55b 7016693: javax/swing/JScrollBar/6542335/bug6542335.java failed on Ubuntu Reviewed-by: alexp ! test/javax/swing/JScrollBar/6542335/bug6542335.java Changeset: db0a6fd0fea9 Author: amenkov Date: 2011-02-18 13:21 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/db0a6fd0fea9 6801236: test closed/javax/sound/sampled/FileWriter/WaveBigEndian.java fails Reviewed-by: alexp ! src/share/classes/com/sun/media/sound/services/javax.sound.sampled.spi.FormatConversionProvider Changeset: 64b4226f171f Author: amenkov Date: 2011-02-18 13:27 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/64b4226f171f 7000132: Misplaced description in javax.sound.sampled.AudioSystem.getTargetDataLine Reviewed-by: dav ! src/share/classes/javax/sound/sampled/AudioSystem.java Changeset: a93bb05d00fd Author: alexp Date: 2011-02-18 19:21 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/a93bb05d00fd 6474153: LookAndFeel.makeKeyBindings(...) doesn't ignore last element in keyBindingList with odd size Reviewed-by: rupashka ! src/share/classes/javax/swing/LookAndFeel.java + test/javax/swing/LookAndFeel/6474153/bug6474153.java Changeset: 3772a3d90b40 Author: rupashka Date: 2011-02-18 20:09 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/3772a3d90b40 6997102: Test case has hard code, so that applet thread threw exception Reviewed-by: alexp ! test/javax/swing/JFileChooser/6798062/bug6798062.html ! test/javax/swing/JFileChooser/6798062/bug6798062.java Changeset: 2cc71008b6db Author: lana Date: 2011-02-21 14:31 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/2cc71008b6db Merge ! src/share/classes/javax/swing/JComponent.java Changeset: cfd397d86474 Author: sundar Date: 2011-02-11 10:38 +0530 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/cfd397d86474 6604827: JavaDoc for ScriptEngineFactory.getMethodCallSyntax contains an error. Reviewed-by: mchung ! src/share/classes/javax/script/ScriptEngineFactory.java Changeset: 05a0271173a6 Author: ohair Date: 2011-02-10 20:48 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/05a0271173a6 Merge - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java - src/share/demo/zipfs - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: 1dc0c3021d13 Author: ohair Date: 2011-02-11 01:45 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/1dc0c3021d13 Merge Changeset: 8711aedb08f2 Author: sherman Date: 2011-02-11 12:20 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/8711aedb08f2 7007596: (zipfs) FileSystems.newFileSystem(FileRef...) always employs zipfs regardless the real Path type. Summary: updated newFileSystem() to throw UOE exception for non-zip/jar file Reviewed-by: alanb ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystemProvider.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh Changeset: 8860e17db3bd Author: weijun Date: 2011-02-12 05:09 +0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/8860e17db3bd 6742654: Code insertion/replacement attacks against signed jars 6911041: JCK api/signaturetest tests fails for Mixed Code PIT builds (b91) for all trains 6921823: JarVerifier csdomain field not initialized 6921839: Update trusted.libraries list Reviewed-by: dgu ! make/java/security/Makefile ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/jar/JarVerifier.java ! src/share/classes/java/util/jar/JavaUtilJarAccessImpl.java ! src/share/classes/sun/misc/JarIndex.java ! src/share/classes/sun/misc/JavaUtilJarAccess.java ! src/share/classes/sun/security/util/SignatureFileVerifier.java Changeset: de923c0ec3c4 Author: weijun Date: 2011-02-12 07:30 +0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/de923c0ec3c4 7016698: test sun/security/krb5/runNameEquals.sh failed on Ubuntu Reviewed-by: valeriep ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java Changeset: 21a1e86dedc2 Author: sherman Date: 2011-02-11 17:09 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/21a1e86dedc2 6996192: Console.readPassword race: input echo off must be prior to writing prompt Summary: To turn off echo before prompt Reviewed-by: alanb ! src/share/classes/java/io/Console.java Changeset: b04e86b3e27e Author: dcubed Date: 2011-02-14 09:31 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b04e86b3e27e 6637230: 2/3 jps doesn't work for application waiting for direct attach Summary: Properly handle exceptions thrown when querying a monitored VM. Reviewed-by: dsamersoff, swamyv ! src/share/classes/sun/tools/jps/Jps.java Changeset: fefc740bff52 Author: alanb Date: 2011-02-14 18:30 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/fefc740bff52 7016704: TEST_BUG: java/nio/file/Files/walk_file_tree.sh fails with new version of find (lnx) Reviewed-by: forax ! test/java/nio/file/Files/walkFileTree/PrintFileTree.java Changeset: 28037efa90a3 Author: mduigou Date: 2011-02-14 10:38 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/28037efa90a3 6934356: Vector.writeObject() serialization may deadlock Summary: No longer synchronize on self while writing other objects. Reviewed-by: alanb, forax, mduigou, peterjones Contributed-by: Neil Richards ! src/share/classes/java/util/Vector.java + test/java/util/Vector/SerializationDeadlock.java + test/java/util/Vector/SimpleSerialization.java Changeset: 2633daa325ed Author: mduigou Date: 2011-02-14 10:48 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/2633daa325ed Merge Changeset: 338c5b815ff2 Author: mduigou Date: 2011-02-14 11:00 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/338c5b815ff2 6927486: Hashtable writeObject() may deadlock Summary: Do not synchronize on self while writing hash table elements Reviewed-by: alanb, mduigou Contributed-by: Neil Richards ! src/share/classes/java/util/Hashtable.java + test/java/util/Hashtable/SerializationDeadlock.java + test/java/util/Hashtable/SimpleSerialization.java Changeset: 44c99f30f9df Author: xuelei Date: 2011-02-14 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/44c99f30f9df 7018897: CertPath validation cannot handle self-signed cert with bad KeyUsage Summary: Remove KeyUsage checking for trust anchors Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java Changeset: 9024288330c4 Author: weijun Date: 2011-02-15 12:11 +0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/9024288330c4 7018928: test failure: sun/security/krb5/auto/SSL.java Reviewed-by: valeriep ! test/sun/security/krb5/auto/BadKdc1.java ! test/sun/security/krb5/auto/BadKdc2.java ! test/sun/security/krb5/auto/BadKdc3.java ! test/sun/security/krb5/auto/BadKdc4.java ! test/sun/security/krb5/auto/CleanState.java ! test/sun/security/krb5/auto/CrossRealm.java ! test/sun/security/krb5/auto/HttpNegotiateServer.java ! test/sun/security/krb5/auto/IgnoreChannelBinding.java ! test/sun/security/krb5/auto/KerberosHashEqualsTest.java ! test/sun/security/krb5/auto/LifeTimeInSeconds.java ! test/sun/security/krb5/auto/LoginModuleOptions.java ! test/sun/security/krb5/auto/MaxRetries.java ! test/sun/security/krb5/auto/MoreKvno.java ! test/sun/security/krb5/auto/NewSalt.java ! test/sun/security/krb5/auto/NonMutualSpnego.java ! test/sun/security/krb5/auto/SSL.java ! test/sun/security/krb5/auto/SpnegoReqFlags.java ! test/sun/security/krb5/auto/Test5653.java Changeset: b578c9ccfb01 Author: lana Date: 2011-02-15 08:34 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b578c9ccfb01 Merge Changeset: afa89f8ab9c8 Author: chegar Date: 2011-02-16 12:38 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/afa89f8ab9c8 6562203: Thread doesn't terminate immediately if it was stopped before start Reviewed-by: dholmes, alanb ! src/share/classes/java/lang/Thread.java - test/java/lang/Thread/StopBeforeStart.java Changeset: dbc74475822f Author: sherman Date: 2011-02-16 11:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/dbc74475822f 6999337: java.exe fails to start if some directory names in path to java binaries contain Russian characters Summary: updated to make sure the system properties are accessable by vm during initialization Reviewed-by: alanb, mchung ! src/share/classes/java/lang/System.java Changeset: 6e33b377aa6e Author: smarks Date: 2011-02-16 18:22 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/6e33b377aa6e 7018392: update URLJarFile.java to use try-with-resources Reviewed-by: alanb, chegar, hawtin ! src/share/classes/sun/net/www/protocol/jar/URLJarFile.java Changeset: 15ef6cf616d6 Author: chegar Date: 2011-02-17 09:56 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/15ef6cf616d6 7017901: OOME in java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java Summary: Unbounded queues should be disabled in the test Reviewed-by: alanb ! test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java Changeset: 302877469037 Author: alanb Date: 2011-02-17 20:50 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/302877469037 6526860: (fc) FileChannel.position returns 0 when FileOutputStream opened in append mode Reviewed-by: forax ! src/share/classes/sun/nio/ch/FileChannelImpl.java ! src/solaris/classes/sun/nio/fs/UnixChannelFactory.java ! test/java/nio/channels/FileChannel/Position.java Changeset: a5861eb81f3c Author: alanb Date: 2011-02-17 20:53 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/a5861eb81f3c Merge Changeset: dd143033cef1 Author: sundar Date: 2011-02-18 12:07 +0530 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/dd143033cef1 7018459: javax.script code comments have issues with HTML4 validation and Accessibility compliance Reviewed-by: jjh ! src/share/classes/javax/script/ScriptEngineFactory.java Changeset: 5bf920749b97 Author: smarks Date: 2011-02-18 12:43 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5bf920749b97 7018385: update javax.sql classes to use try-with-resources Reviewed-by: alanb, lancea, darcy ! src/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java Changeset: 42e4205db024 Author: mduigou Date: 2011-02-21 13:37 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/42e4205db024 7001685: Renable EnumSetBash Test Reviewed-by: alanb, ohair, darcy ! test/ProblemList.txt Changeset: 3ebece41badd Author: lana Date: 2011-02-21 14:33 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/3ebece41badd Merge - test/java/lang/Thread/StopBeforeStart.java Changeset: f046a44e92fd Author: jgodinez Date: 2011-02-24 15:00 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f046a44e92fd 7022228: JPRT failure: RuntimeException in SupportedMedia regression test Reviewed-by: igor, prr ! src/windows/classes/sun/print/Win32PrintService.java Changeset: 094c70388ab0 Author: lana Date: 2011-02-24 18:04 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/094c70388ab0 Merge - test/java/lang/Thread/StopBeforeStart.java Changeset: 6bbc7a473495 Author: lana Date: 2011-03-01 14:04 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/6bbc7a473495 Merge - test/java/lang/Thread/StopBeforeStart.java Changeset: b88e4395c437 Author: katleman Date: 2011-03-03 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b88e4395c437 Added tag jdk7-b132 for changeset 6bbc7a473495 ! .hgtags Changeset: 1356371db8c9 Author: lana Date: 2011-03-06 23:37 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/1356371db8c9 Merge - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java - test/java/lang/Thread/StopBeforeStart.java From james.graham at oracle.com Mon Mar 7 21:20:56 2011 From: james.graham at oracle.com (Jim Graham) Date: Mon, 07 Mar 2011 13:20:56 -0800 Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <551102634.216501.1299282037004.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> References: <551102634.216501.1299282037004.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <4D754C38.7010205@oracle.com> Hi Denis, On 3/4/2011 3:40 PM, Denis Lila wrote: > Hi Jim. > >> line 52: and => or? > > No, because our ranges are half open, so if lastCrossing == end, > that means the line ends just before end and hence doesn't cross it. Forgive my ascii art shorthand, "=>" was supposed to be an arrow, not a comparison operator. I was saying that you use the word "and" on that line and it should be changed to the word "or" because a non-compliant edge can be invalid by violating either (i.e. "or") condition. In other words/symbols: "and" ===should be===>>>> "or" Also, in rereading it, you talk about the edges crossing outside of the range but my brain immediately goes to the fact that when they first came in they may have had huge extents, but they were then clipped. Perhaps it would be better to use the term "edge fragment stored in the edges array" or "clipped edge". Also, the word "cross" is a little overloaded. What about: // Preconditions: Only subpixel scanlines in the range // (start <= subpixel_y <= end) will be evaluated. No // edge may have a valid (i.e. inside the supplied clip) // crossing that would be generated outside that range. >> Is this blocking anyone until they find the Hotspot problem? > > Not to my knowledge, but it has been very annoying when running > some of my own tests. Just curious if the "final" attribute on local variables might be causing it problems? >> line 535: Would it work to use pminY and pmaxY? Will there be any >> active edges to iterate outside of that range? > > I'm not sure I understand. I do use pminY and pmaxY - just their > subpixel versions. If we used pminY and pmaxY instead of subpix_pminY > and subpix_pmaxY that would just mean we'd have to compute the subpixel > versions in _endRendering (or ScanlineIterator.). I guess I meant the spmin/maxY. The pmin/maxY have been rounded out to the next full pixel boundary and then you convert back to sub-pixel precision, but in doing so you then force the iterator to iterate through any subpixel positions before spminY and after spmaxY. This is probably in the noise for any but the smallest shapes, but still - isn't it wasted effort? ...jim From steven.loomis at sun.com Tue Mar 8 01:27:14 2011 From: steven.loomis at sun.com (steven.loomis at sun.com) Date: Tue, 08 Mar 2011 01:27:14 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7017324: Kerning crash in JDK 7 since ICU layout update Message-ID: <20110308012744.7D8D247F60@hg.openjdk.java.net> Changeset: 9f88ef1d373f Author: srl Date: 2011-03-07 17:23 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/9f88ef1d373f 7017324: Kerning crash in JDK 7 since ICU layout update Reviewed-by: igor, prr ! src/share/native/sun/font/layout/KernTable.cpp + test/java/awt/font/TextLayout/KernCrash.java From steven.loomis at sun.com Tue Mar 8 03:40:06 2011 From: steven.loomis at sun.com (steven.loomis at sun.com) Date: Tue, 08 Mar 2011 03:40:06 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6962082: merge back in lines from bad merge in CR 6501644 and open up a test Message-ID: <20110308034017.937FC47F86@hg.openjdk.java.net> Changeset: be2e229513a7 Author: srl Date: 2011-03-07 19:37 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/be2e229513a7 6962082: merge back in lines from bad merge in CR 6501644 and open up a test Reviewed-by: igor, prr ! src/share/native/sun/font/layout/LayoutEngine.cpp + test/java/awt/font/TextLayout/CombiningPerf.java From dlila at redhat.com Tue Mar 8 14:14:28 2011 From: dlila at redhat.com (Denis Lila) Date: Tue, 8 Mar 2011 09:14:28 -0500 (EST) Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <4D754C38.7010205@oracle.com> Message-ID: <744891768.399042.1299593668056.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Hi Jim. > Forgive my ascii art shorthand, "=>" was supposed to be an arrow, not > a > comparison operator. I was saying that you use the word "and" on that > line and it should be changed to the word "or" because a non-compliant > edge can be invalid by violating either (i.e. "or") condition. In > other > words/symbols: > > "and" ===should be===>>>> "or" Aha, I see. I usually use "==>" for implication. > Also, in rereading it, you talk about the edges crossing outside of > the > range but my brain immediately goes to the fact that when they first > came in they may have had huge extents, but they were then clipped. > Perhaps it would be better to use the term "edge fragment stored in > the > edges array" or "clipped edge". Also, the word "cross" is a little > overloaded. What about: > > // Preconditions: Only subpixel scanlines in the range > // (start <= subpixel_y <= end) will be evaluated. No > // edge may have a valid (i.e. inside the supplied clip) > // crossing that would be generated outside that range. I do like this better. > Just curious if the "final" attribute on local variables might be > causing it problems? No, I don't think so. What's happening is that the compiler is trying to unswitch the loop by moving one of the switch statements outside of the loop. Once it does that, the IR graph ends up with many code paths, and in one of them, a variable that is used for a future array index is set to a value that makes the index always < 0. When int to long conversion nodes are created are created by the parser, we give the node a type of int[0,max_int]. So, when the index is proven to be <0, that node is killed. However, the control path that leads to that node's computation is not killed (in this case, that's because it's an OSR compilation and it doesn't have enough information to prove it's dead code). So we end up with a phi node with a control input whose corresponding data input is dead, and this causes problems in some future dominator computations. The workaround fixes it by doing the loop unswitching manually. > I guess I meant the spmin/maxY. The pmin/maxY have been rounded out to > the next full pixel boundary and then you convert back to sub-pixel > precision, but in doing so you then force the iterator to iterate > through any subpixel positions before spminY and after spmaxY. This is > probably in the noise for any but the smallest shapes, but still - > isn't > it wasted effort? Good point. I completely forgot we had the spm* variables. I updated the webrev. Regards, Denis. ----- Original Message ----- > Hi Denis, > ... From dlila at redhat.com Tue Mar 8 15:20:45 2011 From: dlila at redhat.com (Denis Lila) Date: Tue, 8 Mar 2011 10:20:45 -0500 (EST) Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <744891768.399042.1299593668056.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <365238282.401383.1299597645824.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> I also removed the System.exit(1) calls in PiscesTileGenerator. It doesn't seem like a good idea to shut down the whole VM because of a rendering bug. ----- Original Message ----- > Hi Jim. > > > Forgive my ascii art shorthand, "=>" was supposed to be an arrow, > > not > > a > > comparison operator. I was saying that you use the word "and" on > > that > > line and it should be changed to the word "or" because a > > non-compliant > > edge can be invalid by violating either (i.e. "or") condition. In > > other > > words/symbols: > > > > "and" ===should be===>>>> "or" > > Aha, I see. I usually use "==>" for implication. > > > Also, in rereading it, you talk about the edges crossing outside of > > the > > range but my brain immediately goes to the fact that when they first > > came in they may have had huge extents, but they were then clipped. > > Perhaps it would be better to use the term "edge fragment stored in > > the > > edges array" or "clipped edge". Also, the word "cross" is a little > > overloaded. What about: > > > > // Preconditions: Only subpixel scanlines in the range > > // (start <= subpixel_y <= end) will be evaluated. No > > // edge may have a valid (i.e. inside the supplied clip) > > // crossing that would be generated outside that range. > > I do like this better. > > > Just curious if the "final" attribute on local variables might be > > causing it problems? > > No, I don't think so. What's happening is that the compiler is trying > to unswitch the loop by moving one of the switch statements outside > of the loop. Once it does that, the IR graph ends up with many code > paths, and in one of them, a variable that is used for a future > array index is set to a value that makes the index always < 0. > When int to long conversion nodes are created are created by the > parser, we give the node a type of int[0,max_int]. So, when the > index is proven to be <0, that node is killed. However, the control > path that leads to that node's computation is not killed (in this > case, that's because it's an OSR compilation and it doesn't have > enough information to prove it's dead code). So we end up with a > phi node with a control input whose corresponding data input is > dead, and this causes problems in some future dominator computations. > The workaround fixes it by doing the loop unswitching manually. > > > I guess I meant the spmin/maxY. The pmin/maxY have been rounded out > > to > > the next full pixel boundary and then you convert back to sub-pixel > > precision, but in doing so you then force the iterator to iterate > > through any subpixel positions before spminY and after spmaxY. This > > is > > probably in the noise for any but the smallest shapes, but still - > > isn't > > it wasted effort? > > Good point. I completely forgot we had the spm* variables. > > I updated the webrev. > > Regards, > Denis. > > ----- Original Message ----- > > Hi Denis, > > > ... From jennifer.godinez at oracle.com Tue Mar 8 19:52:59 2011 From: jennifer.godinez at oracle.com (jennifer.godinez at oracle.com) Date: Tue, 08 Mar 2011 19:52:59 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7020528: closed/java/awt/print/PageFormat/PageFormatFromAttributes.java failed Message-ID: <20110308195330.8900247FBA@hg.openjdk.java.net> Changeset: 48d97c8653f0 Author: jgodinez Date: 2011-03-08 11:47 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/48d97c8653f0 7020528: closed/java/awt/print/PageFormat/PageFormatFromAttributes.java failed Reviewed-by: igor, prr ! src/windows/native/sun/windows/awt_PrintJob.cpp From james.graham at oracle.com Tue Mar 8 21:51:24 2011 From: james.graham at oracle.com (Jim Graham) Date: Tue, 08 Mar 2011 13:51:24 -0800 Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <551102634.216501.1299282037004.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> References: <551102634.216501.1299282037004.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <4D76A4DC.6000905@oracle.com> Hi Denis, On 3/4/2011 3:40 PM, Denis Lila wrote: >> line 355: Make that "16" a constant? > > Sure. You created the constant, but didn't give it a value. ;-) New stuff: Stroker.java: lines 1002 & 1083 - can breaking points of a cubic generate quad segments and vice versa? I'm guessing that they both can make lines so they need the "case 4" case. The rest looks good... ...jim From andrew.brygin at oracle.com Wed Mar 9 10:37:23 2011 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Wed, 09 Mar 2011 10:37:23 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7022280: Parfait reports Format string argument mismatch in /jdk/src/solaris/native/sun/awt/awt_GraphicsEnv.c Message-ID: <20110309103804.10B3447FE5@hg.openjdk.java.net> Changeset: 69ec42543dd9 Author: bae Date: 2011-03-09 13:08 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/69ec42543dd9 7022280: Parfait reports Format string argument mismatch in /jdk/src/solaris/native/sun/awt/awt_GraphicsEnv.c Reviewed-by: jgodinez, prr ! src/solaris/native/sun/awt/awt_GraphicsEnv.c From james.graham at oracle.com Wed Mar 9 12:21:00 2011 From: james.graham at oracle.com (Jim Graham) Date: Wed, 09 Mar 2011 04:21:00 -0800 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7022280: Parfait reports Format string argument mismatch in /jdk/src/solaris/native/sun/awt/awt_GraphicsEnv.c In-Reply-To: <20110309103804.10B3447FE5@hg.openjdk.java.net> References: <20110309103804.10B3447FE5@hg.openjdk.java.net> Message-ID: <4D7770AC.3060401@oracle.com> Please revert this fix and re-read the X11 protocol. Something *else* went wrong for parfait to think that we wanted to parse a 64-bit value there. VisualID values are small numbers and transferred as 32-bit quantities in the protocol. If the typedef ended up with a 64-bit representation from the header files then we have probably not configured something correctly... ...jim On 3/9/11 2:37 AM, andrew.brygin at oracle.com wrote: > Changeset: 69ec42543dd9 > Author: bae > Date: 2011-03-09 13:08 +0300 > URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/69ec42543dd9 > > 7022280: Parfait reports Format string argument mismatch in /jdk/src/solaris/native/sun/awt/awt_GraphicsEnv.c > Reviewed-by: jgodinez, prr > > ! src/solaris/native/sun/awt/awt_GraphicsEnv.c > From dlila at redhat.com Wed Mar 9 13:56:44 2011 From: dlila at redhat.com (Denis Lila) Date: Wed, 9 Mar 2011 08:56:44 -0500 (EST) Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <4D76A4DC.6000905@oracle.com> Message-ID: <1665857794.460178.1299679004417.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> > You created the constant, but didn't give it a value. ;-) Ah, sorry (that's what I get for making a simple change in vim and not building). > lines 1002 & 1083 - can breaking points of a cubic generate quad > segments and vice versa? No, the functions that generate the offset curves can only return a line or a curve of the same degree as the curve whose offset they're generating. > The rest looks good... Thanks (I updated the webrev. Should I push?), Denis. PS: in the future, when it comes down to such a simple change, should I go ahead and push, or must I wait for final confirmation? ----- Original Message ----- > Hi Denis, > > On 3/4/2011 3:40 PM, Denis Lila wrote: > >> line 355: Make that "16" a constant? > > > > Sure. > > > New stuff: > > Stroker.java: > > > > ...jim From philip.race at oracle.com Wed Mar 9 18:00:23 2011 From: philip.race at oracle.com (Phil Race) Date: Wed, 09 Mar 2011 10:00:23 -0800 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7022280: Parfait reports Format string argument mismatch in /jdk/src/solaris/native/sun/awt/awt_GraphicsEnv.c In-Reply-To: <4D7770AC.3060401@oracle.com> References: <20110309103804.10B3447FE5@hg.openjdk.java.net> <4D7770AC.3060401@oracle.com> Message-ID: <4D77C037.9030105@oracle.com> That's what I had supposed too, but the client definition depends on the machine definition of long. % more x.c #include #include #include int main( int ac, char** av) { VisualID id; printf("sz=%d\n", sizeof(id)); } % cc -I/usr/openwin/include x.c rincewind 125% file a.out a.out: ELF 32-bit MSB executable SPARC32PLUS Version 1, V8+ Required, dynamically linked, not stripped % a.out sz=4 % cc -I/usr/openwin/include -m64 x.c % file a.out a.out: ELF 64-bit MSB executable SPARCV9 Version 1, dynamically linked, not stripped % a.out sz=8 -phil. Jim Graham wrote: > Please revert this fix and re-read the X11 protocol. Something *else* > went wrong for parfait to think that we wanted to parse a 64-bit value > there. VisualID values are small numbers and transferred as 32-bit > quantities in the protocol. If the typedef ended up with a 64-bit > representation from the header files then we have probably not > configured something correctly... > > ...jim > > On 3/9/11 2:37 AM, andrew.brygin at oracle.com wrote: >> Changeset: 69ec42543dd9 >> Author: bae >> Date: 2011-03-09 13:08 +0300 >> URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/69ec42543dd9 >> >> 7022280: Parfait reports Format string argument mismatch in >> /jdk/src/solaris/native/sun/awt/awt_GraphicsEnv.c >> Reviewed-by: jgodinez, prr >> >> ! src/solaris/native/sun/awt/awt_GraphicsEnv.c >> From james.graham at oracle.com Wed Mar 9 20:35:17 2011 From: james.graham at oracle.com (Jim Graham) Date: Wed, 09 Mar 2011 12:35:17 -0800 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7022280: Parfait reports Format string argument mismatch in /jdk/src/solaris/native/sun/awt/awt_GraphicsEnv.c In-Reply-To: <4D77C037.9030105@oracle.com> References: <20110309103804.10B3447FE5@hg.openjdk.java.net> <4D7770AC.3060401@oracle.com> <4D77C037.9030105@oracle.com> Message-ID: <4D77E485.2040608@oracle.com> Note that these sources were originally created in a day when "unsigned long" was a 32-bit quantity in most places and often used to make sure you didn't get a 16-bit integer. That sizing rule of thumb changed over the years and now it usually gives you a 64-bit quantity. (Don't you just love C?) In looking deeper into the SERVER64 directive which controls this (setting it would use a CARD32 to define a VisualID which has a more concrete 32-bit definition), it looks like they are specifically intending that to not be used for client code, but I can find no explanation via Google. The closest that I could find was a commit comment to the sources for some X11 client code that mentioned that SERVER64 should not be used in client sources because it could wreak havoc, but no explanation as to why. My guess is that they didn't really embrace "machine dependent typedef" technology to ensure that these quantities were declared as 32-bit quantities until it was too late and they had spawned a mixture of versions of Xlib that just had whatever "unsigned long" compiled to. (Still, you'd think they would have noticed this as soon as the first 64-bit Xlib failed to interpret the protocol correctly, no? Or maybe they thought that "unsigned long" was a more natural type for the compilers to play with?) As a result, to go back and fix it for the client libraries would cause this compatibility havoc and so they only fix it now for server sources. It's sloppy, but probably necessary due to practical concerns. So I guess it would appear that they really do want these local types to be 64-bit quantities despite the fact that the protocol defines their data as 32-bit values. So, after quite a bit of obscure digging, it looks like our use of the header files is actually correct and so this fix is accurate now despite the conceptual conflict with the definition of the protocol. %lx, according to the printf/scanf man pages, should track the size of "unsigned long" on any given platform and it shouldn't misinterpret the correct value of any 32-bit hex string that it parses so I guess there is no problem here (other than my now feeling quite a bit more disgusted/amused with the cobbled state of the X11 APIs ;-). Apologies for the disruption... :-( ...jim On 3/9/11 10:00 AM, Phil Race wrote: > That's what I had supposed too, but the client definition depends on the > machine > definition of long. > > % more x.c > #include > #include > #include > > int main( int ac, char** av) { > VisualID id; > printf("sz=%d\n", sizeof(id)); > } > > % cc -I/usr/openwin/include x.c > rincewind 125% file a.out > a.out: ELF 32-bit MSB executable SPARC32PLUS Version 1, V8+ Required, > dynamically linked, not stripped > % a.out > sz=4 > > > % cc -I/usr/openwin/include -m64 x.c > % file a.out > a.out: ELF 64-bit MSB executable SPARCV9 Version 1, dynamically linked, > not stripped > % a.out > sz=8 > > -phil. > > Jim Graham wrote: >> Please revert this fix and re-read the X11 protocol. Something *else* >> went wrong for parfait to think that we wanted to parse a 64-bit value >> there. VisualID values are small numbers and transferred as 32-bit >> quantities in the protocol. If the typedef ended up with a 64-bit >> representation from the header files then we have probably not >> configured something correctly... >> >> ...jim >> >> On 3/9/11 2:37 AM, andrew.brygin at oracle.com wrote: >>> Changeset: 69ec42543dd9 >>> Author: bae >>> Date: 2011-03-09 13:08 +0300 >>> URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/69ec42543dd9 >>> >>> 7022280: Parfait reports Format string argument mismatch in >>> /jdk/src/solaris/native/sun/awt/awt_GraphicsEnv.c >>> Reviewed-by: jgodinez, prr >>> >>> ! src/solaris/native/sun/awt/awt_GraphicsEnv.c >>> > From james.graham at oracle.com Thu Mar 10 00:30:05 2011 From: james.graham at oracle.com (Jim Graham) Date: Wed, 09 Mar 2011 16:30:05 -0800 Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <1665857794.460178.1299679004417.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> References: <1665857794.460178.1299679004417.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <4D781B8D.3080601@oracle.com> [Resending due to bounces...] On 3/9/2011 5:56 AM, Denis Lila wrote: >> lines 1002& 1083 - can breaking points of a cubic generate quad >> segments and vice versa? > > No, the functions that generate the offset curves can only > return a line or a curve of the same degree as the curve > whose offset they're generating. Then why does the code to handle the opposing curve type exist in these functions? ...jim From andrew.brygin at oracle.com Thu Mar 10 09:00:24 2011 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Thu, 10 Mar 2011 09:00:24 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6710434: PIT: Reg test java/awt/Graphics2D/ClipPrimitivesTest.java fails in pit build 6u10_b26 Message-ID: <20110310090042.D0B8A47024@hg.openjdk.java.net> Changeset: 87444344d616 Author: bae Date: 2011-03-10 11:18 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/87444344d616 6710434: PIT: Reg test java/awt/Graphics2D/ClipPrimitivesTest.java fails in pit build 6u10_b26 Reviewed-by: flar, prr ! src/share/native/sun/java2d/loops/ProcessPath.c From dlila at redhat.com Thu Mar 10 14:38:35 2011 From: dlila at redhat.com (Denis Lila) Date: Thu, 10 Mar 2011 09:38:35 -0500 (EST) Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <4D781B8D.3080601@oracle.com> Message-ID: <823468743.523326.1299767915625.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> > [Resending due to bounces...] > > On 3/9/2011 5:56 AM, Denis Lila wrote: > >> lines 1002& 1083 - can breaking points of a cubic generate quad > >> segments and vice versa? > > > > No, the functions that generate the offset curves can only > > return a line or a curve of the same degree as the curve > > whose offset they're generating. > > Then why does the code to handle the opposing curve type exist in > these > functions? > > ...jim Because everything was copied from somethingTo, which had to handle both types of curves, and I applied constant propagation and dead code elimination very mechanically for fear or breaking something. Should I remove the cases that never execute? Regards, Denis. From james.graham at oracle.com Thu Mar 10 18:59:38 2011 From: james.graham at oracle.com (Jim Graham) Date: Thu, 10 Mar 2011 10:59:38 -0800 Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <823468743.523326.1299767915625.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> References: <823468743.523326.1299767915625.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <4D791F9A.2030609@oracle.com> Hi Denis, Yes, that was the point of my original question. I was asking how you felt about the dead code, apologies that it took so long to get on the same page. I don't have a strong opinion there, I was just making you aware that there was more dead code. Another option would be to move just the switch statement into a secondary shared function which might be small enough not to trigger that compiler bug. But, I'll leave those decisions up to you. I was just pointing out that you missed some potentially dead code... ...jim On 3/10/2011 6:38 AM, Denis Lila wrote: >> [Resending due to bounces...] >> >> On 3/9/2011 5:56 AM, Denis Lila wrote: >>>> lines 1002& 1083 - can breaking points of a cubic generate quad >>>> segments and vice versa? >>> >>> No, the functions that generate the offset curves can only >>> return a line or a curve of the same degree as the curve >>> whose offset they're generating. >> >> Then why does the code to handle the opposing curve type exist in >> these >> functions? >> >> ...jim > > Because everything was copied from somethingTo, which had to handle > both types of curves, and I applied constant propagation and dead > code elimination very mechanically for fear or breaking something. > Should I remove the cases that never execute? > > Regards, > Denis. From dlila at redhat.com Thu Mar 10 19:06:51 2011 From: dlila at redhat.com (Denis Lila) Date: Thu, 10 Mar 2011 14:06:51 -0500 (EST) Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <4D791F9A.2030609@oracle.com> Message-ID: <1326073415.534143.1299784011015.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Hi Jim. > Yes, that was the point of my original question. I was asking how you > felt about the dead code, apologies that it took so long to get on the > same page. I don't have a strong opinion there, I was just making you > aware that there was more dead code. Another option would be to move > just the switch statement into a secondary shared function which might > be small enough not to trigger that compiler bug. > > But, I'll leave those decisions up to you. I was just pointing out > that > you missed some potentially dead code... Oh, I see. Well, I wasn't aware of it before you asked, so thanks for pointing it out. I guess I'll remove it. As for moving the switch in its own function, I think the compiler would just inline it and then we'd be in the same spot. Shall I push? Thank you, Denis. ----- Original Message ----- > Hi Denis, > > > ...jim > > On 3/10/2011 6:38 AM, Denis Lila wrote: > >> [Resending due to bounces...] > >> > >> On 3/9/2011 5:56 AM, Denis Lila wrote: > >>>> lines 1002& 1083 - can breaking points of a cubic generate quad > >>>> segments and vice versa? > >>> > >>> No, the functions that generate the offset curves can only > >>> return a line or a curve of the same degree as the curve > >>> whose offset they're generating. > >> > >> Then why does the code to handle the opposing curve type exist in > >> these > >> functions? > >> > >> ...jim > > > > Because everything was copied from somethingTo, which had to handle > > both types of curves, and I applied constant propagation and dead > > code elimination very mechanically for fear or breaking something. > > Should I remove the cases that never execute? > > > > Regards, > > Denis. From james.graham at oracle.com Thu Mar 10 19:23:36 2011 From: james.graham at oracle.com (Jim Graham) Date: Thu, 10 Mar 2011 11:23:36 -0800 Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <1326073415.534143.1299784011015.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> References: <1326073415.534143.1299784011015.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <4D792538.1030405@oracle.com> I think the code is good to go, but could you create an automated test case for this? It should be easy to render a simple shape to a rendered image and verify that the last scanline was touched, no? ...jim On 3/10/2011 11:06 AM, Denis Lila wrote: > Hi Jim. > >> Yes, that was the point of my original question. I was asking how you >> felt about the dead code, apologies that it took so long to get on the >> same page. I don't have a strong opinion there, I was just making you >> aware that there was more dead code. Another option would be to move >> just the switch statement into a secondary shared function which might >> be small enough not to trigger that compiler bug. >> >> But, I'll leave those decisions up to you. I was just pointing out >> that >> you missed some potentially dead code... > > Oh, I see. Well, I wasn't aware of it before you asked, so thanks > for pointing it out. I guess I'll remove it. > > As for moving the switch in its own function, I think the compiler > would just inline it and then we'd be in the same spot. > > Shall I push? > > Thank you, > Denis. > > ----- Original Message ----- >> Hi Denis, >> > >> >> ...jim >> >> On 3/10/2011 6:38 AM, Denis Lila wrote: >>>> [Resending due to bounces...] >>>> >>>> On 3/9/2011 5:56 AM, Denis Lila wrote: >>>>>> lines 1002& 1083 - can breaking points of a cubic generate quad >>>>>> segments and vice versa? >>>>> >>>>> No, the functions that generate the offset curves can only >>>>> return a line or a curve of the same degree as the curve >>>>> whose offset they're generating. >>>> >>>> Then why does the code to handle the opposing curve type exist in >>>> these >>>> functions? >>>> >>>> ...jim >>> >>> Because everything was copied from somethingTo, which had to handle >>> both types of curves, and I applied constant propagation and dead >>> code elimination very mechanically for fear or breaking something. >>> Should I remove the cases that never execute? >>> >>> Regards, >>> Denis. From dlila at redhat.com Thu Mar 10 19:28:46 2011 From: dlila at redhat.com (Denis Lila) Date: Thu, 10 Mar 2011 14:28:46 -0500 (EST) Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <4D792538.1030405@oracle.com> Message-ID: <1628858543.534506.1299785326604.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> > I think the code is good to go, but could you create an automated test > case for this? It should be easy to render a simple shape to a > rendered > image and verify that the last scanline was touched, no? Sure. Actually, I've already written it. I just need to make it into a JTreg test. ----- Original Message ----- > > ...jim > > On 3/10/2011 11:06 AM, Denis Lila wrote: > > Hi Jim. > > > >> Yes, that was the point of my original question. I was asking how > >> you > >> felt about the dead code, apologies that it took so long to get on > >> the > >> same page. I don't have a strong opinion there, I was just making > >> you > >> aware that there was more dead code. Another option would be to > >> move > >> just the switch statement into a secondary shared function which > >> might > >> be small enough not to trigger that compiler bug. > >> > >> But, I'll leave those decisions up to you. I was just pointing out > >> that > >> you missed some potentially dead code... > > > > Oh, I see. Well, I wasn't aware of it before you asked, so thanks > > for pointing it out. I guess I'll remove it. > > > > As for moving the switch in its own function, I think the compiler > > would just inline it and then we'd be in the same spot. > > > > Shall I push? > > > > Thank you, > > Denis. > > > > ----- Original Message ----- > >> Hi Denis, > >> > > > >> > >> ...jim > >> > >> On 3/10/2011 6:38 AM, Denis Lila wrote: > >>>> [Resending due to bounces...] > >>>> > >>>> On 3/9/2011 5:56 AM, Denis Lila wrote: > >>>>>> lines 1002& 1083 - can breaking points of a cubic generate quad > >>>>>> segments and vice versa? > >>>>> > >>>>> No, the functions that generate the offset curves can only > >>>>> return a line or a curve of the same degree as the curve > >>>>> whose offset they're generating. > >>>> > >>>> Then why does the code to handle the opposing curve type exist in > >>>> these > >>>> functions? > >>>> > >>>> ...jim > >>> > >>> Because everything was copied from somethingTo, which had to > >>> handle > >>> both types of curves, and I applied constant propagation and dead > >>> code elimination very mechanically for fear or breaking something. > >>> Should I remove the cases that never execute? > >>> > >>> Regards, > >>> Denis. From dlila at redhat.com Thu Mar 10 22:40:31 2011 From: dlila at redhat.com (Denis Lila) Date: Thu, 10 Mar 2011 17:40:31 -0500 (EST) Subject: [OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization In-Reply-To: <4D792538.1030405@oracle.com> Message-ID: <1230631178.553637.1299796831102.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> > I think the code is good to go, but could you create an automated test > case for this? It should be easy to render a simple shape to a > rendered > image and verify that the last scanline was touched, no? Ok, the test is now in the webrev. From matej.knopp at inmethod.com Sat Mar 12 21:44:49 2011 From: matej.knopp at inmethod.com (Matej Knopp) Date: Sat, 12 Mar 2011 16:44:49 -0500 Subject: [OpenJDK 2D-Dev] TrueTypeFont Mac Platform encoded names (Patch) Message-ID: Hi, The TrueTypeFont doesn't support mac platform encodings which makes it impossible to load some of the fonts shipped with Mac OS X. Attached is a straightforward patch to add the support. What are the chances of this getting fixed upstream? btw. Apple's TrueTypeFont implementation doesn't seem to support CompositeFont so even if it gets to OpenJDK it won't be much help for loading TTC files. sun.font.TrueTypeFont seems to be handling this pretty well, apart from the missing support for mac platform encoding. Kind regards, Matej Knopp InMethod -------------- next part -------------- A non-text attachment was scrubbed... Name: TrueTypeFont.patch Type: application/octet-stream Size: 11449 bytes Desc: not available URL: From dlila at redhat.com Tue Mar 15 14:55:42 2011 From: dlila at redhat.com (Denis Lila) Date: Tue, 15 Mar 2011 10:55:42 -0400 (EDT) Subject: [OpenJDK 2D-Dev] [RFC]: 7027667 fix In-Reply-To: <278969223.786988.1300200912094.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <451873486.787013.1300200942882.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Hi. This webrev has a fix for 7027667: http://icedtea.classpath.org/~dlila/webrevs/7027667/webrev/ Although, for some reason, the diff in the webref for AAShapePipe.java shows nothing. It should be (this is what hg diff gives me): diff -r 155d91257957 src/share/classes/sun/java2d/pipe/AAShapePipe.java --- a/src/share/classes/sun/java2d/pipe/AAShapePipe.java Thu Dec 23 08:47:30 2010 -0800 +++ b/src/share/classes/sun/java2d/pipe/AAShapePipe.java Tue Mar 15 10:57:28 2011 -0400 @@ -109,7 +109,7 @@ Region clip = sg.getCompClip(); int abox[] = new int[4]; AATileGenerator aatg = - renderengine.getAATileGenerator(x, y, dx1, dy1, dx2, dy2, 0, 0, + renderengine.getAATileGenerator(x, y, dx1, dy1, dx2, dy2, lw1, lw2, clip, abox); if (aatg == null) { // Nothing to render Is this ok? Thank you, Denis. From philip.race at oracle.com Tue Mar 15 15:50:17 2011 From: philip.race at oracle.com (Phil Race) Date: Tue, 15 Mar 2011 08:50:17 -0700 Subject: [OpenJDK 2D-Dev] [RFC]: 7027667 fix In-Reply-To: <451873486.787013.1300200942882.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> References: <451873486.787013.1300200942882.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <4D7F8AB9.6080001@oracle.com> Denis, I pushed the identical fix about 11 days ago under bug id after Clemens and I spotted problems first in the Xrender pipeline. I think that maybe why your webrev against the 2D repo shows nothing :-) See attached. -phil. On 3/15/2011 7:55 AM, Denis Lila wrote: > Hi. > > This webrev has a fix for 7027667: > http://icedtea.classpath.org/~dlila/webrevs/7027667/webrev/ > > Although, for some reason, the diff in the webref for > AAShapePipe.java shows nothing. It should be (this is what hg diff > gives me): > > diff -r 155d91257957 src/share/classes/sun/java2d/pipe/AAShapePipe.java > --- a/src/share/classes/sun/java2d/pipe/AAShapePipe.java Thu Dec 23 08:47:30 2010 -0800 > +++ b/src/share/classes/sun/java2d/pipe/AAShapePipe.java Tue Mar 15 10:57:28 2011 -0400 > @@ -109,7 +109,7 @@ > Region clip = sg.getCompClip(); > int abox[] = new int[4]; > AATileGenerator aatg = > - renderengine.getAATileGenerator(x, y, dx1, dy1, dx2, dy2, 0, 0, > + renderengine.getAATileGenerator(x, y, dx1, dy1, dx2, dy2, lw1, lw2, > clip, abox); > if (aatg == null) { > // Nothing to render > > Is this ok? > > Thank you, > Denis. -------------- next part -------------- An embedded message was scrubbed... From: philip.race at oracle.com Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7023591: Xrender: java2D font demo - text highlighting tab content is black Date: Fri, 04 Mar 2011 23:54:35 +0000 Size: 2621 URL: From dlila at redhat.com Tue Mar 15 16:22:36 2011 From: dlila at redhat.com (Denis Lila) Date: Tue, 15 Mar 2011 12:22:36 -0400 (EDT) Subject: [OpenJDK 2D-Dev] [RFC]: 7027667 fix In-Reply-To: <4D7F8AB9.6080001@oracle.com> Message-ID: <1880881390.788950.1300206156426.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> > I pushed the identical fix about 11 days ago under bug id after > Clemens > and I spotted > problems first in the Xrender pipeline. I think that maybe why your > webrev against > the 2D repo shows nothing :-) See attached. Oops :/ I pulled all the changes into my local repo but forgot to update. That's why I was still seeing the problem after building. Well, the regression test is written. Do we want to push that (once I change the names to the original bug id, of course)? Regards, Denis. ----- Original Message ----- > Denis, > > > -phil. > > > On 3/15/2011 7:55 AM, Denis Lila wrote: > > Hi. > > > > This webrev has a fix for 7027667: > > http://icedtea.classpath.org/~dlila/webrevs/7027667/webrev/ > > > > Although, for some reason, the diff in the webref for > > AAShapePipe.java shows nothing. It should be (this is what hg diff > > gives me): > > > > diff -r 155d91257957 > > src/share/classes/sun/java2d/pipe/AAShapePipe.java > > --- a/src/share/classes/sun/java2d/pipe/AAShapePipe.java Thu Dec 23 > > 08:47:30 2010 -0800 > > +++ b/src/share/classes/sun/java2d/pipe/AAShapePipe.java Tue Mar 15 > > 10:57:28 2011 -0400 > > @@ -109,7 +109,7 @@ > > Region clip = sg.getCompClip(); > > int abox[] = new int[4]; > > AATileGenerator aatg = > > - renderengine.getAATileGenerator(x, y, dx1, dy1, dx2, dy2, 0, 0, > > + renderengine.getAATileGenerator(x, y, dx1, dy1, dx2, dy2, lw1, > > lw2, > > clip, abox); > > if (aatg == null) { > > // Nothing to render > > > > Is this ok? > > > > Thank you, > > Denis. From philip.race at oracle.com Tue Mar 15 16:39:21 2011 From: philip.race at oracle.com (Phil Race) Date: Tue, 15 Mar 2011 09:39:21 -0700 Subject: [OpenJDK 2D-Dev] [RFC]: 7027667 fix In-Reply-To: <1880881390.788950.1300206156426.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> References: <1880881390.788950.1300206156426.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <4D7F9639.7090905@oracle.com> A regression test would be very welcome and I suggest should mention both both 7023591 and 7027667 in the @bug tag but be pushed under the latter bug ID you created - I am not sure if jcheck now allows bug id re-use but we have a spare one here in any case. -phil. On 3/15/2011 9:22 AM, Denis Lila wrote: >> I pushed the identical fix about 11 days ago under bug id after >> Clemens >> and I spotted >> problems first in the Xrender pipeline. I think that maybe why your >> webrev against >> the 2D repo shows nothing :-) See attached. > Oops :/ > > I pulled all the changes into my local repo but forgot to update. > That's why I was still seeing the problem after building. > > Well, the regression test is written. Do we want to push that > (once I change the names to the original bug id, of course)? > > Regards, > Denis. > > ----- Original Message ----- >> Denis, >> >> -phil. >> >> >> On 3/15/2011 7:55 AM, Denis Lila wrote: >>> Hi. >>> >>> This webrev has a fix for 7027667: >>> http://icedtea.classpath.org/~dlila/webrevs/7027667/webrev/ >>> >>> Although, for some reason, the diff in the webref for >>> AAShapePipe.java shows nothing. It should be (this is what hg diff >>> gives me): >>> >>> diff -r 155d91257957 >>> src/share/classes/sun/java2d/pipe/AAShapePipe.java >>> --- a/src/share/classes/sun/java2d/pipe/AAShapePipe.java Thu Dec 23 >>> 08:47:30 2010 -0800 >>> +++ b/src/share/classes/sun/java2d/pipe/AAShapePipe.java Tue Mar 15 >>> 10:57:28 2011 -0400 >>> @@ -109,7 +109,7 @@ >>> Region clip = sg.getCompClip(); >>> int abox[] = new int[4]; >>> AATileGenerator aatg = >>> - renderengine.getAATileGenerator(x, y, dx1, dy1, dx2, dy2, 0, 0, >>> + renderengine.getAATileGenerator(x, y, dx1, dy1, dx2, dy2, lw1, >>> lw2, >>> clip, abox); >>> if (aatg == null) { >>> // Nothing to render >>> >>> Is this ok? >>> >>> Thank you, >>> Denis. From dlila at redhat.com Tue Mar 15 19:12:42 2011 From: dlila at redhat.com (dlila at redhat.com) Date: Tue, 15 Mar 2011 19:12:42 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7027667: clipped aa rectangles are not drawn properly. Message-ID: <20110315191330.74AA34718B@hg.openjdk.java.net> Changeset: fd8b81c558d3 Author: dlila Date: 2011-03-15 15:15 -0400 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/fd8b81c558d3 7027667: clipped aa rectangles are not drawn properly. Summary: Already fixed. This is just a regression test for it. Reviewed-by: prr + test/sun/java2d/pipe/Test7027667.java From dlila at redhat.com Tue Mar 15 21:04:33 2011 From: dlila at redhat.com (dlila at redhat.com) Date: Tue, 15 Mar 2011 21:04:33 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7019861: Last scanline is skipped in pisces.Renderer. Message-ID: <20110315210442.C661247195@hg.openjdk.java.net> Changeset: 253f3bc64961 Author: dlila Date: 2011-03-15 17:05 -0400 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/253f3bc64961 7019861: Last scanline is skipped in pisces.Renderer. Summary: not skipping it anymore. Reviewed-by: flar ! src/share/classes/sun/java2d/pisces/Helpers.java ! src/share/classes/sun/java2d/pisces/PiscesTileGenerator.java ! src/share/classes/sun/java2d/pisces/Renderer.java ! src/share/classes/sun/java2d/pisces/Stroker.java + test/sun/java2d/pisces/Renderer/Test7019861.java From andrew.brygin at oracle.com Wed Mar 16 16:52:00 2011 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Wed, 16 Mar 2011 16:52:00 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6989760: cmm native compiler warnings Message-ID: <20110316165231.88615471DA@hg.openjdk.java.net> Changeset: 5c61c31d2621 Author: bae Date: 2011-03-16 19:21 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5c61c31d2621 6989760: cmm native compiler warnings Reviewed-by: prr, ohair ! make/sun/cmm/kcms/Makefile ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c From andrew.brygin at oracle.com Thu Mar 17 15:19:16 2011 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Thu, 17 Mar 2011 15:19:16 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7014528: ColorModel and SampleModel gotten from the same ImageTypeSpecifier instance can be not compatible Message-ID: <20110317151941.BF14E47219@hg.openjdk.java.net> Changeset: 4450c35a5f90 Author: bae Date: 2011-03-17 17:45 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/4450c35a5f90 7014528: ColorModel and SampleModel gotten from the same ImageTypeSpecifier instance can be not compatible Reviewed-by: jgodinez, prr ! src/share/classes/java/awt/image/PackedColorModel.java From lana.steuck at oracle.com Sat Mar 19 17:19:21 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 19 Mar 2011 17:19:21 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jaxp: 8 new changesets Message-ID: <20110319171921.C97EF472D2@hg.openjdk.java.net> Changeset: 2473f7027ac5 Author: cl Date: 2011-03-10 17:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/2473f7027ac5 Added tag jdk7-b133 for changeset 8e1148c7911b ! .hgtags Changeset: 877fd25c5a2f Author: ohair Date: 2011-03-02 12:00 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/877fd25c5a2f 7023289: jaxp 1.4.5 development jdk7 2nd integration Reviewed-by: joehw, mchung, alanb ! jaxp.properties Changeset: b693ccf23fb7 Author: lana Date: 2011-03-07 11:56 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/b693ccf23fb7 Merge Changeset: 02d4672e8c05 Author: lana Date: 2011-03-10 20:37 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/02d4672e8c05 Merge Changeset: e8be6b716643 Author: ohair Date: 2011-03-10 13:21 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/e8be6b716643 7025412: make381 issues with quotes in jdk/make/docs/Makefile and other places Reviewed-by: mchung ! make/Makefile Changeset: 1259c6d09d09 Author: mfang Date: 2011-03-14 12:32 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/1259c6d09d09 Merge Changeset: d56b326ae054 Author: ohair Date: 2011-03-15 15:31 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/d56b326ae054 Merge Changeset: 4aa9916693dc Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/4aa9916693dc Added tag jdk7-b134 for changeset d56b326ae054 ! .hgtags From lana.steuck at oracle.com Sat Mar 19 17:19:21 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 19 Mar 2011 17:19:21 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d: 7 new changesets Message-ID: <20110319171921.CC4CC472D3@hg.openjdk.java.net> Changeset: a1c8b847b753 Author: ohrstrom Date: 2011-02-28 10:56 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/rev/a1c8b847b753 7021753: Add a build times report Summary: Report the build times at end of a jdkroot build. Reviewed-by: ohair ! Makefile ! make/Defs-internal.gmk ! make/corba-rules.gmk ! make/deploy-rules.gmk ! make/hotspot-rules.gmk ! make/install-rules.gmk ! make/jaxp-rules.gmk ! make/jaxws-rules.gmk ! make/jdk-rules.gmk ! make/langtools-rules.gmk ! make/sponsors-rules.gmk Changeset: 47ad81d343e8 Author: ohair Date: 2011-03-01 11:54 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/47ad81d343e8 7023111: Add webrev script to make/scripts Reviewed-by: darcy + make/scripts/webrev.ksh Changeset: 258b21c7f4af Author: ohair Date: 2011-03-01 11:54 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/258b21c7f4af Merge Changeset: 27384dd2d8ed Author: ohair Date: 2011-03-03 15:29 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/27384dd2d8ed Merge Changeset: c6f380693342 Author: ohair Date: 2011-03-09 16:26 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/c6f380693342 7026167: Broken fastdebug only build Reviewed-by: cl ! Makefile Changeset: ddc2fcb3682f Author: cl Date: 2011-03-10 17:10 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/ddc2fcb3682f Added tag jdk7-b133 for changeset c6f380693342 ! .hgtags Changeset: 168d9382ebab Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/rev/168d9382ebab Added tag jdk7-b134 for changeset ddc2fcb3682f ! .hgtags From lana.steuck at oracle.com Sat Mar 19 17:19:21 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 19 Mar 2011 17:19:21 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jaxws: 4 new changesets Message-ID: <20110319171921.CF3B0472D4@hg.openjdk.java.net> Changeset: 8393aae2eb24 Author: cl Date: 2011-03-10 17:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/8393aae2eb24 Added tag jdk7-b133 for changeset 359d0c8c00a0 ! .hgtags Changeset: ba12732b1453 Author: ohair Date: 2011-03-10 13:22 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/ba12732b1453 7025412: make381 issues with quotes in jdk/make/docs/Makefile and other places Reviewed-by: mchung ! make/Makefile Changeset: 545de8303fec Author: mfang Date: 2011-03-14 12:33 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/545de8303fec Merge Changeset: d5fc61f18043 Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/d5fc61f18043 Added tag jdk7-b134 for changeset 545de8303fec ! .hgtags From lana.steuck at oracle.com Sat Mar 19 17:19:21 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 19 Mar 2011 17:19:21 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/corba: 2 new changesets Message-ID: <20110319171924.B8D14472D5@hg.openjdk.java.net> Changeset: 918003855fa0 Author: cl Date: 2011-03-10 17:10 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/corba/rev/918003855fa0 Added tag jdk7-b133 for changeset 671fe2e623ff ! .hgtags Changeset: e0b72ae5dc5e Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/corba/rev/e0b72ae5dc5e Added tag jdk7-b134 for changeset 918003855fa0 ! .hgtags From lana.steuck at oracle.com Sat Mar 19 17:19:23 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 19 Mar 2011 17:19:23 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/hotspot: 31 new changesets Message-ID: <20110319172022.99723472D6@hg.openjdk.java.net> Changeset: 70b50ac7e2af Author: cl Date: 2011-03-10 17:10 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/70b50ac7e2af Added tag jdk7-b133 for changeset 1b3a350709e4 ! .hgtags Changeset: f91db74a6810 Author: kamg Date: 2011-02-26 13:33 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/f91db74a6810 7017640: Fix for 6766644 deadlocks on some NSK tests when running with -Xcomp Summary: Dynamic-code generated events should be deferred and processed by service thread Reviewed-by: dsamersoff, dcubed ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiImpl.hpp Changeset: da091bb67459 Author: sla Date: 2011-02-28 14:19 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/da091bb67459 7022037: Pause when exiting if debugger is attached on windows Reviewed-by: dsamersoff, kamg, hosterda ! src/os/linux/vm/os_linux.cpp ! src/os/posix/vm/os_posix.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/utilities/vmError.cpp Changeset: c1a6154012c8 Author: kamg Date: 2011-02-28 16:01 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/c1a6154012c8 7020118: Alter frame assignability to allow for exception handler coverage of invokespecial Summary: Add special rule to allow assignment of frames with uninit flags set. Reviewed-by: never, coleenp ! src/share/vm/classfile/stackMapFrame.cpp ! src/share/vm/classfile/stackMapFrame.hpp ! src/share/vm/classfile/verificationType.hpp Changeset: 23ae54207126 Author: rottenha Date: 2011-02-28 15:35 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/23ae54207126 Merge ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.hpp Changeset: cef8c988e7b8 Author: rottenha Date: 2011-02-28 22:35 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/cef8c988e7b8 Merge Changeset: 5584e20db481 Author: sla Date: 2011-03-02 09:41 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/5584e20db481 7023323: Build failure on VS2003: IsDebuggerPresent not found Summary: #define _WIN32_WINNT 0x500 Reviewed-by: ohrstrom, hosterda, coleenp ! src/os/windows/vm/os_windows.cpp Changeset: 4a9604cd7c5f Author: kamg Date: 2011-03-02 08:18 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/4a9604cd7c5f 6878713: Verifier heap corruption, relating to backward jsrs Summary: Added overflow detection in arena Amalloc methods Reviewed-by: coleenp, phh ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/utilities/globalDefinitions_gcc.hpp ! src/share/vm/utilities/globalDefinitions_sparcWorks.hpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp + test/runtime/6878713/Test6878713.sh + test/runtime/6878713/testcase.jar Changeset: 99bd05619fa4 Author: zgu Date: 2011-03-02 09:16 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/99bd05619fa4 7017110: Add /SAFESEH to links on windows 32bit to verify safe exceptions Summary: Ensure safe exception handler table is generated on Win32 binaries when compile with VS2010 Reviewed-by: acorn, coleenp, dcubed, sla, ohair ! make/windows/makefiles/compile.make ! make/windows/makefiles/launcher.make Changeset: a3c0ec0428a2 Author: zgu Date: 2011-03-02 16:21 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/a3c0ec0428a2 Merge Changeset: 8c0d0510d36f Author: dcubed Date: 2011-03-03 09:31 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/8c0d0510d36f Merge Changeset: 4e0069ff33df Author: johnc Date: 2011-02-28 09:10 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/4e0069ff33df 7022200: G1: optimized build broken Summary: Make the G1 specific version of is_in_closed_subset() available in all builds. Reviewed-by: tonyp, jcoomes ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Changeset: 11303bede852 Author: jcoomes Date: 2011-03-03 21:02 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/11303bede852 Merge Changeset: d89a22843c62 Author: iveresov Date: 2011-02-22 15:25 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/d89a22843c62 7020521: arraycopy stubs place prebarriers incorrectly Summary: Rearranged the pre-barrier placement in arraycopy stubs so that they are properly called in case of chained calls. Also refactored the code a little bit so that it looks uniform across the platforms and is more readable. Reviewed-by: never, kvn ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: d5a078cf7f39 Author: iveresov Date: 2011-02-22 18:13 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/d5a078cf7f39 Merge Changeset: ba5d119730dd Author: kvn Date: 2011-02-23 12:28 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/ba5d119730dd Merge Changeset: d411927672ed Author: never Date: 2011-02-23 19:09 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/d411927672ed 7012072: CompileTheWorld causes incorrect class initialization Reviewed-by: kvn, twisti ! src/share/vm/prims/unsafe.cpp Changeset: 5a41a201d08c Author: kvn Date: 2011-02-24 10:28 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/5a41a201d08c 6812217: Base memory of MergeMem node violates assert during killing expanded AllocateArray node Summary: The assert in MergeMemNode::memory_at() misses the case when address is TOP. Reviewed-by: never ! src/share/vm/opto/memnode.cpp Changeset: 6f3746e69a78 Author: never Date: 2011-02-24 11:09 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/6f3746e69a78 7021603: crash in fill_sync_handler with ExtendedDTrace probes Reviewed-by: iveresov ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: 8190d4b75e09 Author: never Date: 2011-02-24 14:49 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/8190d4b75e09 Merge Changeset: 41d4973cf100 Author: kvn Date: 2011-02-26 12:10 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/41d4973cf100 6942326: x86 code in string_indexof() could read beyond reserved heap space Summary: copy small (<8) strings on stack if str+16 crosses a page boundary and load from stack into XMM. Back up pointer when loading string's tail. Reviewed-by: never ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/memnode.cpp + test/compiler/6942326/Test.java Changeset: 1b4e6a5d98e0 Author: twisti Date: 2011-02-28 06:07 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/1b4e6a5d98e0 7012914: JSR 292 MethodHandlesTest C1: frame::verify_return_pc(return_address) failed: must be a return pc Reviewed-by: never, bdelsart ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/utilities/macros.hpp Changeset: 50c0f22d6d0e Author: never Date: 2011-02-28 17:12 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/50c0f22d6d0e 7023229: extraneous include of precompiled.hpp in hsdis.c Reviewed-by: never, jrose Contributed-by: volker.simonis at gmail.com ! src/share/tools/hsdis/hsdis-demo.c ! src/share/tools/hsdis/hsdis.c Changeset: bc6b27fb3568 Author: never Date: 2011-03-01 10:27 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/bc6b27fb3568 6725983: Assertion "method->method_holder())->is_not_initialized(),"method holder must be initialized" Reviewed-by: kvn, iveresov ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/runtime/globals.hpp Changeset: 0ac769a57c64 Author: iveresov Date: 2011-03-01 14:56 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/0ac769a57c64 6627983: G1: Bad oop deference during marking Summary: Bulk zeroing reduction didn't work with G1, because arraycopy would call pre-barriers on uninitialized oops. The solution is to have version of arraycopy stubs that don't have pre-barriers. Also refactored arraycopy stubs generation on SPARC to be more readable and reduced the number of stubs necessary in some cases. Reviewed-by: jrose, kvn, never ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.hpp ! src/share/vm/memory/barrierSet.cpp ! src/share/vm/memory/barrierSet.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: 8c9c9ee30d71 Author: kvn Date: 2011-03-03 23:31 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/8c9c9ee30d71 Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 3e2b59ab2d07 Author: trims Date: 2011-03-04 14:06 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/3e2b59ab2d07 Merge Changeset: 3c76374706ea Author: trims Date: 2011-03-04 14:06 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/3c76374706ea 7024814: Bump the HS21 build number to 04 Summary: Update the HS21 build number to 04 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 447e6faab4a8 Author: trims Date: 2011-03-11 11:18 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/447e6faab4a8 Merge Changeset: 2707f76d15e3 Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/2707f76d15e3 Added tag jdk7-b134 for changeset 447e6faab4a8 ! .hgtags Changeset: fc1b183bfc0a Author: trims Date: 2011-03-17 17:25 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/fc1b183bfc0a Added tag hs21-b04 for changeset 3c76374706ea ! .hgtags From lana.steuck at oracle.com Sat Mar 19 17:19:33 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 19 Mar 2011 17:19:33 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/langtools: 34 new changesets Message-ID: <20110319172046.039F8472D7@hg.openjdk.java.net> Changeset: 0d056b7b93de Author: cl Date: 2011-03-10 17:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/0d056b7b93de Added tag jdk7-b133 for changeset e77e98f936e8 ! .hgtags Changeset: 015dc9a63efc Author: mcimadamore Date: 2011-02-23 14:16 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/015dc9a63efc 7020657: Javac rejects a fairly common idiom with raw override and interfaces Summary: name clash should not be reported if subinterface/implementing class resolves the clash by defining common overrider Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/7020657/T7020657neg.java + test/tools/javac/generics/7020657/T7020657neg.out + test/tools/javac/generics/7020657/T7020657pos.java Changeset: 3ab7bb46c5c1 Author: mcimadamore Date: 2011-02-23 14:17 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/3ab7bb46c5c1 7019631: issues in test headers in b130 Summary: fix to test headers not containing correct bug ID Reviewed-by: jjg ! test/tools/javac/AnonStaticMember_2.java ! test/tools/javac/InterfaceInInner.java ! test/tools/javac/QualifiedNew.java ! test/tools/javac/generics/6969184/T6969184.java Changeset: 4b0491db73af Author: lana Date: 2011-02-23 10:34 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/4b0491db73af Merge Changeset: 3e30c95da3c6 Author: jjh Date: 2011-02-24 08:40 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/3e30c95da3c6 7018753: tools/javac/varargs/warning/Warn5.java times out on slow machines Summary: Use a single file manager for all JavacTasks Reviewed-by: jjg, mcimadamore ! test/tools/javac/varargs/6199075/T6199075.java ! test/tools/javac/varargs/warning/Warn4.java ! test/tools/javac/varargs/warning/Warn5.java Changeset: 8f0dcb9499db Author: jjg Date: 2011-02-25 12:09 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/8f0dcb9499db 7021650: fix Context issues Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/util/Bark.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/file/CacheFSInfo.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/Context.java ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocTodo.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! test/tools/javac/diags/ArgTypeCompilerFactory.java ! test/tools/javac/diags/Example.java + test/tools/javac/util/context/T7021650.java Changeset: 23b64ad3eec8 Author: jjg Date: 2011-02-25 12:19 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/23b64ad3eec8 7022310: test/tools/javac/diags/Example: args added twice Reviewed-by: mcimadamore ! test/tools/javac/diags/Example.java Changeset: 9286a5d1fae3 Author: mcimadamore Date: 2011-02-28 11:48 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/9286a5d1fae3 7015430: Incorrect thrown type determined for unchecked invocations Summary: Thrown types do not get updated after 15.12.2.8, and do not get erased as per 15.12.2.6 Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/7015430/T7015430.java + test/tools/javac/generics/7015430/T7015430.out Changeset: 9f9df9684cfc Author: mcimadamore Date: 2011-02-28 11:50 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/9f9df9684cfc 7015715: lub gets stuck on type with complex supertype Summary: lub should not scan supertypes unnecessarily Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/generics/inference/T7015715.java Changeset: 9029f694e5df Author: jjg Date: 2011-02-28 12:19 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/9029f694e5df 7022337: repeated warnings about bootclasspath not set Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java - test/tools/javac/T6900037.java - test/tools/javac/T6900037.out + test/tools/javac/options/T6900037.java + test/tools/javac/options/T6900037.out + test/tools/javac/options/T7022337.java Changeset: bf9f162c7104 Author: jjg Date: 2011-02-28 13:37 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/bf9f162c7104 7022741: warning counts are wrong after anno processing Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/processing/TestWarnErrorCount.java ! test/tools/javac/processing/warnings/gold_0.out ! test/tools/javac/processing/warnings/gold_sv_warn_0_2.out ! test/tools/javac/processing/warnings/gold_sv_warn_2_3.out ! test/tools/javac/processing/warnings/gold_sv_warn_5_6.out Changeset: 67d6b2df47ba Author: jjg Date: 2011-02-28 13:42 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/67d6b2df47ba 7022711: compiler crash in try-with-resources Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Kinds.java + test/tools/javac/TryWithResources/T7022711.java + test/tools/javac/TryWithResources/T7022711.out Changeset: 938dda0bec17 Author: jjg Date: 2011-03-01 12:00 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/938dda0bec17 7021183: 269: assertion failure getting enclosing element of an undefined name Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symtab.java + test/tools/javac/processing/model/TestSymtabItems.java Changeset: 02b699d97a55 Author: mcimadamore Date: 2011-03-02 10:56 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/02b699d97a55 6541876: "Enclosing Instance" error new in 1.6 Summary: unqualified 'this' should not be selected in a qualified super() call in a default constructor Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/implicitThis/6541876/T6541876a.java + test/tools/javac/implicitThis/6541876/T6541876b.java ! test/tools/javac/implicitThis/NewBeforeOuterConstructed3.java ! test/tools/javac/nested/4903103/T4903103.java Changeset: 2a5c919f20b8 Author: jjg Date: 2011-03-02 14:03 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/2a5c919f20b8 6986895: compiler gives misleading message for no input files Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/options/T6986895.java Changeset: 3085d0089546 Author: jjg Date: 2011-03-02 21:06 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/3085d0089546 6986892: confusing warning given after errors in annotation processing Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/processing/warnings/UseImplicit/C1.java + test/tools/javac/processing/warnings/UseImplicit/TestProcUseImplicitWarning.java + test/tools/javac/processing/warnings/UseImplicit/err.out + test/tools/javac/processing/warnings/UseImplicit/p/C2.java + test/tools/javac/processing/warnings/UseImplicit/warn.out Changeset: 4baab658f357 Author: jjg Date: 2011-03-02 21:13 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/4baab658f357 6639645: Modeling type implementing missing interfaces Reviewed-by: darcy, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! test/tools/javac/api/6557752/T6557752.java + test/tools/javac/processing/model/element/TestMissingElement/InvalidSource.java + test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java + test/tools/javac/processing/model/element/TestMissingElement2/Generator.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingClass.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass1.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass2.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface1.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface2.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingInterface.java Changeset: e9b8fbb30f5a Author: mcimadamore Date: 2011-03-03 09:43 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/e9b8fbb30f5a 7023233: False positive for -Xlint:try with nested try with resources blocks Summary: Wrong lint warning issued about unused resource when nested try-with-resource blocks are found Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Flow.java + test/tools/javac/TryWithResources/UnusedResourcesTest.java Changeset: c15d788cb381 Author: mcimadamore Date: 2011-03-03 17:32 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/c15d788cb381 7023703: Valid code doesn't compile Summary: leftovers cause problems when analyzing loops in Flow.java Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Flow.java + test/tools/javac/7023703/T7023703neg.java + test/tools/javac/7023703/T7023703neg.out + test/tools/javac/7023703/T7023703pos.java Changeset: 32565546784b Author: mcimadamore Date: 2011-03-03 17:34 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/32565546784b 7022054: Invalid compiler error on covariant overriding methods with the same erasure Summary: Rules for method clash use notion of subsignature, which is sometimes too strict and incompatible with JDK 6 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/7022054/T7022054neg1.java + test/tools/javac/generics/7022054/T7022054neg1.out + test/tools/javac/generics/7022054/T7022054neg2.java + test/tools/javac/generics/7022054/T7022054neg2.out + test/tools/javac/generics/7022054/T7022054pos1.java + test/tools/javac/generics/7022054/T7022054pos2.java Changeset: 8fb48a9ac9ec Author: mcimadamore Date: 2011-03-03 18:05 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/8fb48a9ac9ec 7024212: TestWarnErrorCount fails Summary: TestWarnErrorCount should be executed with -Xlint:all,-path to avoid spurious failures Reviewed-by: jjg ! test/tools/javac/processing/TestWarnErrorCount.java Changeset: 7798e3a5ecf5 Author: jjg Date: 2011-03-04 11:33 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/7798e3a5ecf5 6966736: javac verbose output is inconsistent Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/main/AptJavaCompiler.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/util/Log.java Changeset: ebf7c13df6c0 Author: jjg Date: 2011-03-04 19:53 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/ebf7c13df6c0 6866185: Util.getPackageSourcePath should use lastIndexOf not indexOf and related cleanup Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/javadoc/AnnotationDescImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterizedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/SeeTagImpl.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! src/share/classes/com/sun/tools/javadoc/WildcardTypeImpl.java Changeset: 4ee7de0684f5 Author: jjg Date: 2011-03-04 19:56 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/4ee7de0684f5 6227454: package.html and overview.html may not be read fully Reviewed-by: bpatel ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/resources/javadoc.properties + test/tools/javadoc/6227454/Test.java Changeset: 5e6c661891da Author: jjg Date: 2011-03-04 19:59 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/5e6c661891da 6964914: javadoc does not output number of warnings using user written doclet Reviewed-by: bpatel ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java ! src/share/classes/com/sun/tools/javadoc/Start.java + test/tools/javadoc/6964914/Error.java + test/tools/javadoc/6964914/JavacWarning.java + test/tools/javadoc/6964914/JavadocWarning.java + test/tools/javadoc/6964914/Test.java + test/tools/javadoc/6964914/TestStdDoclet.java + test/tools/javadoc/6964914/TestUserDoclet.java + test/tools/javadoc/T6968833.java Changeset: 74f0c05c51eb Author: mcimadamore Date: 2011-03-07 14:11 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/74f0c05c51eb 7024568: Very long method resolution causing OOM error Summary: Resolve.findMethod scans same receiver type more than once in certain inheritance graphs Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/7024568/T7024568.java + test/tools/javac/7024568/T7024568.out Changeset: ca32f2986301 Author: mcimadamore Date: 2011-03-07 14:31 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/ca32f2986301 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes Summary: Disallow diamond on anonymous innner class creation expression (as per JSR 334's EDR) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/DiamondAndAnonClass.java - test/tools/javac/diags/examples/DiamondInvalidArg.java - test/tools/javac/diags/examples/DiamondInvalidArgs.java ! test/tools/javac/generics/diamond/6996914/T6996914a.java ! test/tools/javac/generics/diamond/6996914/T6996914b.java ! test/tools/javac/generics/diamond/T6939780.java ! test/tools/javac/generics/diamond/T6939780.out ! test/tools/javac/generics/diamond/neg/Neg01.java ! test/tools/javac/generics/diamond/neg/Neg01.out ! test/tools/javac/generics/diamond/neg/Neg02.java ! test/tools/javac/generics/diamond/neg/Neg02.out ! test/tools/javac/generics/diamond/neg/Neg03.java ! test/tools/javac/generics/diamond/neg/Neg03.out ! test/tools/javac/generics/diamond/neg/Neg04.java ! test/tools/javac/generics/diamond/neg/Neg04.out ! test/tools/javac/generics/diamond/neg/Neg05.java ! test/tools/javac/generics/diamond/neg/Neg05.out ! test/tools/javac/generics/diamond/neg/Neg06.java ! test/tools/javac/generics/diamond/neg/Neg06.out ! test/tools/javac/generics/diamond/neg/Neg07.java ! test/tools/javac/generics/diamond/neg/Neg07.out ! test/tools/javac/generics/diamond/neg/Neg08.java ! test/tools/javac/generics/diamond/neg/Neg08.out ! test/tools/javac/generics/diamond/neg/Neg09.java ! test/tools/javac/generics/diamond/neg/Neg09.out ! test/tools/javac/generics/diamond/neg/Neg10.java ! test/tools/javac/generics/diamond/neg/Neg11.java - test/tools/javac/generics/diamond/neg/Neg12.java - test/tools/javac/generics/diamond/neg/Neg12.out ! test/tools/javac/generics/diamond/pos/Pos01.java ! test/tools/javac/generics/diamond/pos/Pos02.java ! test/tools/javac/generics/diamond/pos/Pos03.java ! test/tools/javac/generics/diamond/pos/Pos04.java ! test/tools/javac/generics/diamond/pos/Pos05.java + test/tools/javac/generics/diamond/pos/Pos06.java + test/tools/javac/generics/diamond/pos/Pos07.java - test/tools/javac/multicatch/Neg05.java - test/tools/javac/multicatch/Neg05.out + test/tools/javac/multicatch/Pos09.java Changeset: b1b898c00b71 Author: lana Date: 2011-03-07 11:37 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/b1b898c00b71 Merge Changeset: cb9493a80341 Author: jjg Date: 2011-03-07 13:45 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/cb9493a80341 6980021: javac should document @file command line option Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/OptionName.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! test/tools/javac/diags/CheckResourceKeys.java Changeset: d7dfa105f159 Author: lana Date: 2011-03-10 20:51 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/d7dfa105f159 Merge - test/tools/javac/T6900037.java - test/tools/javac/T6900037.out - test/tools/javac/diags/examples/DiamondInvalidArg.java - test/tools/javac/diags/examples/DiamondInvalidArgs.java - test/tools/javac/generics/diamond/neg/Neg12.java - test/tools/javac/generics/diamond/neg/Neg12.out - test/tools/javac/multicatch/Neg05.java - test/tools/javac/multicatch/Neg05.out Changeset: 0f19e1e98b42 Author: mfang Date: 2011-03-08 23:43 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/0f19e1e98b42 7025324: NLS: t13y fix for 7022005 [ja,zh_CN] javadoc, part of navigation bar in generated html are not translated Reviewed-by: yhuang, ogino, jennyh ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties Changeset: 654336cabc5a Author: mfang Date: 2011-03-13 14:41 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/654336cabc5a Merge Changeset: 3d7acdbb72ca Author: ohair Date: 2011-03-15 15:32 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/3d7acdbb72ca Merge Changeset: 9d0a61ac567b Author: schien Date: 2011-03-17 14:33 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/9d0a61ac567b Added tag jdk7-b134 for changeset 3d7acdbb72ca ! .hgtags From lana.steuck at oracle.com Sat Mar 19 17:22:38 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 19 Mar 2011 17:22:38 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 98 new changesets Message-ID: <20110319173800.73B84472D9@hg.openjdk.java.net> Changeset: 7931291bc5d3 Author: herrick Date: 2011-03-01 17:09 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/7931291bc5d3 7021567: need to create jnlp javadoc for 64 bit bundles. Summary: need to create jnlp javadoc for 64 bit bundles. Reviewed-by: igor, ohair ! make/common/Release.gmk Changeset: c53711f82bfb Author: igor Date: 2011-03-08 14:26 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c53711f82bfb Merge - test/java/lang/Thread/StopBeforeStart.java Changeset: eb54e565c491 Author: ohair Date: 2011-02-26 09:45 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/eb54e565c491 7016175: HTML generated from new JavaDoc has tags added from makefile Reviewed-by: jjg ! make/common/shared/Defs-javadoc.gmk ! make/docs/Makefile Changeset: 391a9ef69036 Author: ohair Date: 2011-02-26 10:12 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/391a9ef69036 Merge Changeset: e88c8381eaca Author: ohair Date: 2011-02-26 12:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e88c8381eaca 7022237: Fix use of \" in the new "release" file at the top of the install, windows issues Reviewed-by: ohrstrom ! make/common/Release.gmk Changeset: 123dd69407f9 Author: ohair Date: 2011-02-26 12:42 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/123dd69407f9 Merge Changeset: ed1d4691da29 Author: ohrstrom Date: 2011-02-28 10:56 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/ed1d4691da29 7021753: Add a build times report Summary: Report the build times at end of a jdkroot build. Reviewed-by: ohair ! make/common/shared/Defs-utils.gmk Changeset: f32f0ae3d873 Author: ohair Date: 2011-03-02 12:09 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f32f0ae3d873 Merge Changeset: 869cba583dd4 Author: ohair Date: 2011-03-02 13:18 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/869cba583dd4 7020815: REBASE should not be required for windows jdk repo builds - can't build with VS 2010 Express Reviewed-by: prr ! make/common/shared/Defs-utils.gmk ! make/common/shared/Sanity.gmk Changeset: e5cd10425e7e Author: ohair Date: 2011-03-03 07:02 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e5cd10425e7e Merge - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java - test/java/lang/Thread/StopBeforeStart.java Changeset: c588355b5bb7 Author: ohair Date: 2011-03-03 15:30 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c588355b5bb7 Merge Changeset: 5e5f68a01d12 Author: ohair Date: 2011-03-08 16:05 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5e5f68a01d12 Merge ! make/common/Release.gmk Changeset: e947a98ea3c1 Author: cl Date: 2011-03-10 17:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e947a98ea3c1 Added tag jdk7-b133 for changeset 5e5f68a01d12 ! .hgtags Changeset: df0de56682b7 Author: dcherepanov Date: 2011-02-24 13:01 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/df0de56682b7 6996708: The event on the tray icon does not trigger and there is no message printed. Reviewed-by: art, ant ! src/windows/native/sun/windows/awt_TrayIcon.cpp Changeset: 75d8c1200df8 Author: dcherepanov Date: 2011-02-25 13:58 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/75d8c1200df8 7020522: Need to reapply the fix for 6664512 Reviewed-by: art, mchung ! src/share/classes/sun/util/logging/PlatformLogger.java Changeset: c27520009762 Author: dcherepanov Date: 2011-02-25 15:33 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c27520009762 7009114: GTK FileDialog lies about it's Bounds Reviewed-by: art, anthony ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11/GtkFileDialogPeer.java ! src/solaris/native/sun/awt/gtk2_interface.c ! src/solaris/native/sun/awt/gtk2_interface.h ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.h Changeset: de0f2f8563eb Author: lana Date: 2011-02-26 23:46 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/de0f2f8563eb Merge - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java - src/share/classes/sun/jkernel/BackgroundDownloader.java - src/share/classes/sun/jkernel/Bundle.java - src/share/classes/sun/jkernel/BundleCheck.java - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java - src/share/classes/sun/jkernel/DigestOutputStream.java - src/share/classes/sun/jkernel/DownloadManager.java - src/share/classes/sun/jkernel/KernelError.java - src/share/classes/sun/jkernel/Mutex.java - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java - src/share/classes/sun/jkernel/StandaloneMessageDigest.java - src/share/classes/sun/jkernel/StandaloneSHA.java - src/share/demo/zipfs - src/windows/native/sun/jkernel/DownloadDialog.cpp - src/windows/native/sun/jkernel/DownloadDialog.h - src/windows/native/sun/jkernel/DownloadHelper.cpp - src/windows/native/sun/jkernel/DownloadHelper.h - src/windows/native/sun/jkernel/graphics/bullet.bmp - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp - src/windows/native/sun/jkernel/graphics/java-icon.ico - src/windows/native/sun/jkernel/graphics/masthead.bmp - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp - src/windows/native/sun/jkernel/kernel.cpp - src/windows/native/sun/jkernel/kernel.def - src/windows/native/sun/jkernel/kernel.h - src/windows/native/sun/jkernel/kernel.rc - src/windows/native/sun/jkernel/kernel_de.rc - src/windows/native/sun/jkernel/kernel_en.rc - src/windows/native/sun/jkernel/kernel_es.rc - src/windows/native/sun/jkernel/kernel_fr.rc - src/windows/native/sun/jkernel/kernel_it.rc - src/windows/native/sun/jkernel/kernel_ja.rc - src/windows/native/sun/jkernel/kernel_ko.rc - src/windows/native/sun/jkernel/kernel_pt_BR.rc - src/windows/native/sun/jkernel/kernel_sv.rc - src/windows/native/sun/jkernel/kernel_zh.rc - src/windows/native/sun/jkernel/kernel_zh_TW.rc - src/windows/native/sun/jkernel/resource.h - src/windows/native/sun/jkernel/stdafx.cpp - src/windows/native/sun/jkernel/stdafx.h - src/windows/native/sun/jkernel/version.rc - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: 024d040af4a3 Author: anthony Date: 2011-03-01 13:49 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/024d040af4a3 7022488: The security warning may disappear unexpectedly Summary: Initialize the fullScreenExclusiveModeState flag in the AwtWindow constructor Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Window.cpp Changeset: b5e609488bc8 Author: dcherepanov Date: 2011-03-01 15:24 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b5e609488bc8 6826397: PIT : Frame System Menu is not seen for when ALT + Space Bar is pressed in jdk7 b55 build. Reviewed-by: art, ant ! src/windows/native/sun/windows/awt_Frame.cpp ! src/windows/native/sun/windows/awt_Frame.h Changeset: 8cd20d3e5448 Author: lana Date: 2011-03-06 20:32 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/8cd20d3e5448 Merge - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java - test/java/lang/Thread/StopBeforeStart.java Changeset: 333bd91466bd Author: lana Date: 2011-03-07 14:44 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/333bd91466bd Merge ! make/sun/xawt/mapfile-vers Changeset: f8fdf9bca159 Author: okutsu Date: 2011-02-22 14:51 +0900 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f8fdf9bca159 7010379: fontconfig update for RHEL 6 Reviewed-by: peytoia ! make/sun/awt/Makefile Changeset: 5957bd3cfdc3 Author: okutsu Date: 2011-02-23 14:09 +0900 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5957bd3cfdc3 6623219: Font.canDisplayUpTo does not work with supplementary characters Reviewed-by: prr, peytoia ! src/share/classes/java/awt/Font.java + test/java/awt/FontClass/SurrogateTest/SupplementaryCanDisplayUpToTest.java Changeset: 30d112b3b6f2 Author: okutsu Date: 2011-02-23 16:50 +0900 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/30d112b3b6f2 6955047: (tz) javadoc for TimeZone.getDisplayName(boolean daylight, int style, Locale locale) is not clear 7021680: (tz) daylight savings time should be daylight saving time Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/TimeZone.java Changeset: ff611d9474cb Author: okutsu Date: 2011-02-24 15:09 +0900 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/ff611d9474cb 7021989: Missing observesDaylightTime override in ZoneInfo Reviewed-by: peytoia ! src/share/classes/sun/util/calendar/ZoneInfo.java Changeset: 01c752a48b51 Author: okutsu Date: 2011-02-24 16:29 +0900 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/01c752a48b51 6772689: java.sql.Date.valueOf("2042-10-xx").toString() wrong in some time zones Reviewed-by: peytoia ! src/share/classes/sun/util/calendar/ZoneInfo.java + test/java/util/TimeZone/Bug6772689.java Changeset: e390ce4509c6 Author: alexp Date: 2011-02-28 18:20 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e390ce4509c6 6826074: JScrollPane does not revalidate the component hierarchy after scrolling Reviewed-by: anthony ! src/share/classes/javax/swing/DefaultDesktopManager.java ! src/share/classes/javax/swing/JViewport.java Changeset: 1ef5b85d41f2 Author: amenkov Date: 2011-02-28 18:36 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/1ef5b85d41f2 7013521: AudioSystem.write for AIFF files closes source audio stream Reviewed-by: dav ! src/share/classes/com/sun/media/sound/AiffFileWriter.java ! src/share/classes/com/sun/media/sound/AuFileWriter.java ! src/share/classes/com/sun/media/sound/SunFileWriter.java ! src/share/classes/com/sun/media/sound/WaveFileWriter.java + test/javax/sound/sampled/FileWriter/WriterCloseInput.java Changeset: d4e3c1f2177a Author: amenkov Date: 2011-03-03 15:41 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/d4e3c1f2177a 6938426: Concurrency bug in ALAW encoder causes random bursts of static/noise in output. Reviewed-by: stayer ! src/share/classes/com/sun/media/sound/AlawCodec.java + test/javax/sound/sampled/FileWriter/AlawEncoderSync.java Changeset: d3df100509ad Author: amenkov Date: 2011-03-03 15:45 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/d3df100509ad 6801206: SoundTestSuite: test050 fails Reviewed-by: stayer ! src/share/classes/com/sun/media/sound/DirectAudioDevice.java + test/javax/sound/sampled/Clip/ClipSetPos.java Changeset: 4e732aba71bf Author: amenkov Date: 2011-03-03 15:57 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/4e732aba71bf 6660470: RealTimeSequencer incorrectly opens (implicitly) synthesizer Reviewed-by: stayer ! src/share/classes/com/sun/media/sound/RealTimeSequencer.java ! src/share/classes/javax/sound/midi/MidiSystem.java + test/javax/sound/midi/Sequencer/SequencerImplicitSynthOpen.java Changeset: 67d4b2e2e5b1 Author: amenkov Date: 2011-03-03 16:40 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/67d4b2e2e5b1 6835393: MidiSystem fails to correctly read Sequence with SMPTE division Reviewed-by: stayer ! src/share/classes/com/sun/media/sound/StandardMidiFileReader.java + test/javax/sound/midi/File/SMPTESequence.java Changeset: 52bdb4237d5e Author: rupashka Date: 2011-03-03 17:47 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/52bdb4237d5e 6796710: Html content in JEditorPane is overlapping on swing components while resizing the application. Reviewed-by: alexp ! src/share/classes/javax/swing/text/html/CSSBorder.java + test/javax/swing/regtesthelpers/Util.java + test/javax/swing/text/CSSBorder/6796710/bug6796710.java Changeset: 7dfcf271b73b Author: alexp Date: 2011-03-03 18:23 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/7dfcf271b73b 6653511: JComponent.safelyGetGraphics() may sometimes return null Reviewed-by: rupashka ! src/share/classes/javax/swing/JComponent.java Changeset: e4ca9353150a Author: alexp Date: 2011-03-03 18:27 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e4ca9353150a Merge Changeset: dc34da6a3fa1 Author: rupashka Date: 2011-03-05 18:27 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/dc34da6a3fa1 6760148: Certain fonts are not correctly soft wrapped when using JTextComponent.print() Reviewed-by: peterz ! src/share/classes/javax/swing/text/Utilities.java ! src/share/classes/javax/swing/text/WrappedPlainView.java Changeset: ca0f223b4be7 Author: lana Date: 2011-03-05 20:54 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/ca0f223b4be7 Merge - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java ! src/share/classes/javax/swing/JComponent.java - src/share/classes/sun/jkernel/BackgroundDownloader.java - src/share/classes/sun/jkernel/Bundle.java - src/share/classes/sun/jkernel/BundleCheck.java - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java - src/share/classes/sun/jkernel/DigestOutputStream.java - src/share/classes/sun/jkernel/DownloadManager.java - src/share/classes/sun/jkernel/KernelError.java - src/share/classes/sun/jkernel/Mutex.java - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java - src/share/classes/sun/jkernel/StandaloneMessageDigest.java - src/share/classes/sun/jkernel/StandaloneSHA.java - src/share/demo/zipfs - src/windows/native/sun/jkernel/DownloadDialog.cpp - src/windows/native/sun/jkernel/DownloadDialog.h - src/windows/native/sun/jkernel/DownloadHelper.cpp - src/windows/native/sun/jkernel/DownloadHelper.h - src/windows/native/sun/jkernel/graphics/bullet.bmp - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp - src/windows/native/sun/jkernel/graphics/java-icon.ico - src/windows/native/sun/jkernel/graphics/masthead.bmp - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp - src/windows/native/sun/jkernel/kernel.cpp - src/windows/native/sun/jkernel/kernel.def - src/windows/native/sun/jkernel/kernel.h - src/windows/native/sun/jkernel/kernel.rc - src/windows/native/sun/jkernel/kernel_de.rc - src/windows/native/sun/jkernel/kernel_en.rc - src/windows/native/sun/jkernel/kernel_es.rc - src/windows/native/sun/jkernel/kernel_fr.rc - src/windows/native/sun/jkernel/kernel_it.rc - src/windows/native/sun/jkernel/kernel_ja.rc - src/windows/native/sun/jkernel/kernel_ko.rc - src/windows/native/sun/jkernel/kernel_pt_BR.rc - src/windows/native/sun/jkernel/kernel_sv.rc - src/windows/native/sun/jkernel/kernel_zh.rc - src/windows/native/sun/jkernel/kernel_zh_TW.rc - src/windows/native/sun/jkernel/resource.h - src/windows/native/sun/jkernel/stdafx.cpp - src/windows/native/sun/jkernel/stdafx.h - src/windows/native/sun/jkernel/version.rc - test/java/lang/Thread/StopBeforeStart.java - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: e3a69b9be2b5 Author: lana Date: 2011-03-07 14:46 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e3a69b9be2b5 Merge Changeset: d26e79640fd4 Author: mduigou Date: 2011-02-21 14:53 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/d26e79640fd4 7019705: Add -XX:+AggressiveOpts options to MOAT test Reviewed-by: alanb ! test/java/util/Collection/MOAT.java Changeset: dbdafe65af60 Author: alanb Date: 2011-02-21 13:54 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/dbdafe65af60 7020517: (fs) FileStore.equals returns true if both volumes have the same serial number Reviewed-by: chegar ! src/windows/classes/sun/nio/fs/WindowsFileStore.java ! test/java/nio/file/FileStore/Basic.java Changeset: d7cb44a4d08a Author: alanb Date: 2011-02-22 10:19 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/d7cb44a4d08a Merge Changeset: 9d8a0369b906 Author: alanb Date: 2011-02-22 12:04 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/9d8a0369b906 7020888: (file) Miscellaneous and trivial clean-ups (typos and opportunities to use suppressed exceptions) Reviewed-by: mduigou, chegar ! src/share/classes/java/io/BufferedReader.java ! src/share/classes/java/io/BufferedWriter.java ! src/share/classes/java/io/File.java ! src/share/classes/java/io/FilterOutputStream.java ! src/share/classes/java/io/PushbackInputStream.java ! src/share/classes/java/io/PushbackReader.java ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/share/classes/java/nio/channels/SocketChannel.java ! src/share/classes/java/nio/file/CopyMoveHelper.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/sun/nio/ch/FileChannelImpl.java ! src/solaris/classes/sun/nio/ch/UnixAsynchronousServerSocketChannelImpl.java ! src/solaris/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java ! test/java/lang/ProcessBuilder/Basic.java Changeset: bac152c6491a Author: alanb Date: 2011-02-22 14:28 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/bac152c6491a 7021327: Changes for 7020888 included changes to other files in error Reviewed-by: chegar ! src/share/classes/java/io/BufferedReader.java ! src/share/classes/java/io/BufferedWriter.java ! src/share/classes/java/io/FilterOutputStream.java ! src/share/classes/java/io/PushbackInputStream.java ! src/share/classes/java/io/PushbackReader.java ! test/java/lang/ProcessBuilder/Basic.java Changeset: b853414b8eef Author: michaelm Date: 2011-02-22 14:44 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b853414b8eef 6702400: ChunkedInputStream expecting -1 from int read, but int->char comparision is wrong Reviewed-by: chegar ! src/share/classes/sun/net/httpserver/ChunkedInputStream.java Changeset: 75216854fb53 Author: valeriep Date: 2011-02-22 12:01 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/75216854fb53 6604496: Support for CKM_AES_CTR (counter mode) Summary: Enhanced SunPKCS11 provider to support AES/CTR/NoPadding transformation. Reviewed-by: vinnie ! src/share/classes/sun/security/pkcs11/P11Cipher.java ! src/share/classes/sun/security/pkcs11/SunPKCS11.java + src/share/classes/sun/security/pkcs11/wrapper/CK_AES_CTR_PARAMS.java ! src/share/classes/sun/security/pkcs11/wrapper/CK_MECHANISM.java ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java ! src/share/native/sun/security/pkcs11/wrapper/p11_convert.c + src/share/native/sun/security/pkcs11/wrapper/pkcs-11v2-20a3.h ! src/share/native/sun/security/pkcs11/wrapper/pkcs11wrapper.h ! test/sun/security/pkcs11/Cipher/TestSymmCiphers.java ! test/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java Changeset: 84e339f1033b Author: smarks Date: 2011-02-22 15:34 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/84e339f1033b 7021209: convert lang, math, util to use try-with-resources Reviewed-by: alanb, darcy, naoto ! src/share/classes/java/lang/Package.java ! src/share/classes/java/util/Currency.java ! src/share/classes/sun/util/calendar/LocalGregorianCalendar.java ! src/solaris/classes/java/util/prefs/FileSystemPreferences.java ! test/java/lang/Character/CheckScript.java ! test/java/lang/Runtime/shutdown/ShutdownHooks.java ! test/java/lang/instrument/BootClassPath/Setup.java ! test/java/lang/instrument/ilib/Inject.java ! test/java/math/BigInteger/BigIntegerTest.java ! test/java/util/Currency/ValidateISO4217.java ! test/java/util/Formatter/FailingConstructors.java ! test/java/util/Locale/LocaleEnhanceTest.java ! test/java/util/ResourceBundle/Bug6204853.java ! test/java/util/Scanner/FailingConstructors.java Changeset: 892c3fc7249e Author: dl Date: 2011-02-23 14:56 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/892c3fc7249e 7017493: ConcurrentLinkedDeque: Unexpected initialization order can lead to crash due to use of Unsafe Reviewed-by: chegar ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListSet.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/concurrent/LinkedTransferQueue.java ! src/share/classes/java/util/concurrent/Phaser.java ! src/share/classes/java/util/concurrent/PriorityBlockingQueue.java ! src/share/classes/java/util/concurrent/SynchronousQueue.java Changeset: 744c2773e3f7 Author: lana Date: 2011-02-23 10:29 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/744c2773e3f7 Merge - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile - src/share/classes/sun/jkernel/BackgroundDownloader.java - src/share/classes/sun/jkernel/Bundle.java - src/share/classes/sun/jkernel/BundleCheck.java - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java - src/share/classes/sun/jkernel/DigestOutputStream.java - src/share/classes/sun/jkernel/DownloadManager.java - src/share/classes/sun/jkernel/KernelError.java - src/share/classes/sun/jkernel/Mutex.java - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java - src/share/classes/sun/jkernel/StandaloneMessageDigest.java - src/share/classes/sun/jkernel/StandaloneSHA.java - src/windows/native/sun/jkernel/DownloadDialog.cpp - src/windows/native/sun/jkernel/DownloadDialog.h - src/windows/native/sun/jkernel/DownloadHelper.cpp - src/windows/native/sun/jkernel/DownloadHelper.h - src/windows/native/sun/jkernel/graphics/bullet.bmp - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp - src/windows/native/sun/jkernel/graphics/java-icon.ico - src/windows/native/sun/jkernel/graphics/masthead.bmp - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp - src/windows/native/sun/jkernel/kernel.cpp - src/windows/native/sun/jkernel/kernel.def - src/windows/native/sun/jkernel/kernel.h - src/windows/native/sun/jkernel/kernel.rc - src/windows/native/sun/jkernel/kernel_de.rc - src/windows/native/sun/jkernel/kernel_en.rc - src/windows/native/sun/jkernel/kernel_es.rc - src/windows/native/sun/jkernel/kernel_fr.rc - src/windows/native/sun/jkernel/kernel_it.rc - src/windows/native/sun/jkernel/kernel_ja.rc - src/windows/native/sun/jkernel/kernel_ko.rc - src/windows/native/sun/jkernel/kernel_pt_BR.rc - src/windows/native/sun/jkernel/kernel_sv.rc - src/windows/native/sun/jkernel/kernel_zh.rc - src/windows/native/sun/jkernel/kernel_zh_TW.rc - src/windows/native/sun/jkernel/resource.h - src/windows/native/sun/jkernel/stdafx.cpp - src/windows/native/sun/jkernel/stdafx.h - src/windows/native/sun/jkernel/version.rc ! test/java/util/Locale/LocaleEnhanceTest.java Changeset: 0f0d6b8f98cc Author: wetmore Date: 2011-02-23 22:54 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/0f0d6b8f98cc 6844879: Source distribution should be more robustly built without the security source distribution Reviewed-by: ohair ! make/common/shared/Defs-java.gmk Changeset: c2c8f9c38fd1 Author: chegar Date: 2011-02-24 12:57 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c2c8f9c38fd1 7020136: java/net/URLConnection/RedirectLimit.java fails intermittently Summary: Increase the socket timeout and clean up the test Reviewed-by: alanb ! test/java/net/URLConnection/RedirectLimit.java Changeset: 1f41e41ef2db Author: chegar Date: 2011-02-24 13:42 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/1f41e41ef2db 6849693: index of fdTable should be less than num. of fdTable in jdk7 Reviewed-by: alanb ! src/solaris/native/java/net/linux_close.c Changeset: 51ef29aafc1b Author: michaelm Date: 2011-02-24 18:35 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/51ef29aafc1b 6835668: Use of /usr/include/linux/ files creates a dependence on kernel-headers Reviewed-by: chegar ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/PlainSocketImpl.c Changeset: b74f1b830484 Author: smarks Date: 2011-02-24 22:26 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b74f1b830484 7022383: add reference to CR for ReadLongZipFileName test to problem list Reviewed-by: ohair ! test/ProblemList.txt Changeset: 32dc1cb2b995 Author: mchung Date: 2011-02-25 11:42 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/32dc1cb2b995 7021939: com.oracle.net is not a NON_CORE_PKGS Reviewed-by: ohair, alanb ! make/common/Release.gmk ! make/docs/NON_CORE_PKGS.gmk Changeset: 5dc98de2a35e Author: mchung Date: 2011-02-25 12:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5dc98de2a35e 7016707: Remove the BootClassLoaderHook for jkernel support Reviewed-by: alanb, ohair ! make/java/java/FILES_java.gmk ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/util/zip/ZipEntry.java - src/share/classes/sun/misc/BootClassLoaderHook.java ! src/share/classes/sun/misc/Launcher.java - test/sun/misc/BootClassLoaderHook/TestHook.java Changeset: 8887cb2f5d19 Author: smarks Date: 2011-02-25 02:06 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/8887cb2f5d19 7021582: convert jar/zip code and tests to use try-with-resources Reviewed-by: alanb, dholmes, sherman ! src/share/classes/java/util/jar/JarFile.java ! test/java/util/jar/JarEntry/GetMethodsReturnClones.java ! test/java/util/jar/JarFile/ScanSignedJar.java ! test/java/util/zip/Available.java ! test/java/util/zip/FileBuilder.java ! test/java/util/zip/GZIP/Accordion.java ! test/java/util/zip/GZIP/GZIPInputStreamRead.java ! test/java/util/zip/InflateIn_DeflateOut.java ! test/java/util/zip/InfoZip.java ! test/java/util/zip/LargeZip.java ! test/java/util/zip/TestEmptyZip.java ! test/java/util/zip/ZipCoding.java ! test/java/util/zip/ZipFile/Assortment.java ! test/java/util/zip/ZipFile/Comment.java ! test/java/util/zip/ZipFile/CopyJar.java ! test/java/util/zip/ZipFile/CorruptedZipFiles.java ! test/java/util/zip/ZipFile/DeleteTempJar.java ! test/java/util/zip/ZipFile/EnumAfterClose.java ! test/java/util/zip/ZipFile/GetDirEntry.java ! test/java/util/zip/ZipFile/LargeZipFile.java ! test/java/util/zip/ZipFile/ManyEntries.java ! test/java/util/zip/ZipFile/ManyZipFiles.java ! test/java/util/zip/ZipFile/ReadAfterClose.java ! test/java/util/zip/ZipFile/ReadZip.java ! test/java/util/zip/ZipFile/ShortRead.java ! test/java/util/zip/zip.java Changeset: 29f25ba547fc Author: chegar Date: 2011-02-28 11:03 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/29f25ba547fc 7022269: clean up fscanf usage in Linux networking native code Reviewed-by: michaelm, alanb ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/net_util_md.c Changeset: a3b6c262195b Author: dholmes Date: 2011-02-28 06:40 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/a3b6c262195b 7022386: gethostbyname_r needs a pointer aligned buffer passed to it Summary: Change buffer type to ensure pointer-alignment Reviewed-by: alanb, chegar ! src/solaris/native/java/net/Inet4AddressImpl.c Changeset: f4613b378874 Author: weijun Date: 2011-02-28 23:02 +0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f4613b378874 7021789: Remove jarsigner -crl option Reviewed-by: mullan ! src/share/classes/com/sun/jarsigner/ContentSignerParameters.java ! src/share/classes/java/security/CodeSigner.java - src/share/classes/sun/misc/JavaSecurityCodeSignerAccess.java ! src/share/classes/sun/misc/SharedSecrets.java ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/sun/security/tools/JarSignerResources.java ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/tools/TimestampedSigner.java ! src/share/classes/sun/security/util/SignatureFileVerifier.java ! test/sun/security/tools/jarsigner/crl.sh Changeset: f8bf888edf20 Author: weijun Date: 2011-03-01 16:22 +0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f8bf888edf20 7020531: test: java/security/cert/CertificateFactory/openssl/OpenSSLCert.java file not closed after run Reviewed-by: alanb, smarks ! test/ProblemList.txt ! test/java/security/cert/CertificateFactory/openssl/OpenSSLCert.java ! test/sun/security/tools/keytool/NewSize7.java Changeset: b7e763a573a4 Author: alanb Date: 2011-03-01 12:03 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b7e763a573a4 7023034: Files.createTempDirectory((Path)null, "temp") does not throw NPE Reviewed-by: forax ! src/share/classes/java/nio/file/Files.java ! test/java/nio/file/Files/TemporaryFiles.java Changeset: 98d2d57d9e73 Author: smarks Date: 2011-03-01 15:05 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/98d2d57d9e73 7022624: use try-with-resources in java.io tests Reviewed-by: alanb ! test/java/io/File/SetLastModified.java ! test/java/io/FileOutputStream/AtomicAppend.java ! test/java/io/OutputStreamWriter/Encode.java ! test/java/io/PrintStream/EncodingConstructor.java ! test/java/io/PrintStream/FailingConstructors.java ! test/java/io/Serializable/evolution/RenamePackage/install/SerialDriver.java ! test/java/io/Serializable/evolution/RenamePackage/test/SerialDriver.java Changeset: 895687e879ca Author: alanb Date: 2011-03-02 16:56 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/895687e879ca 7021987: native2ascii "file cannot be read" error message is broken Reviewed-by: lancea, mchung ! src/share/classes/sun/tools/native2ascii/Main.java ! test/sun/tools/native2ascii/Native2AsciiTests.sh Changeset: 75064373ed6b Author: michaelm Date: 2011-03-03 15:34 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/75064373ed6b 7018606: (process) test/java/lang/ProcessBuilder/Basic.java failing intermittently (win) Reviewed-by: alanb ! test/java/lang/ProcessBuilder/Basic.java Changeset: 7cfb0693eb33 Author: chegar Date: 2011-03-03 16:44 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/7cfb0693eb33 7018137: HTML4 compliance issues Summary: move end list items tags to after nested list Reviewed-by: alanb ! src/share/classes/java/net/URI.java ! src/share/classes/java/net/package.html Changeset: 9b99a14375bc Author: chegar Date: 2011-03-03 16:48 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/9b99a14375bc 6721694: java/lang/Thread/StartOOMTest.java fails with timeout or with crash Summary: the test is not suitable to be run automatically Reviewed-by: alanb ! test/java/lang/Thread/StartOOMTest.java Changeset: 732faed56eb0 Author: coffeys Date: 2011-03-03 16:51 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/732faed56eb0 6750362: Very large LDAP requests throw a OOM on LDAP servers which aren't aware of Paged Results Controls 6748156: add an new JNDI property to control the boolean flag WaitForReply Reviewed-by: vinnie, robm ! src/share/classes/com/sun/jndi/ldap/Connection.java ! src/share/classes/com/sun/jndi/ldap/LdapClient.java ! src/share/classes/com/sun/jndi/ldap/LdapCtx.java ! src/share/classes/com/sun/jndi/ldap/LdapRequest.java + test/com/sun/jndi/ldap/NoWaitForReplyTest.java Changeset: 0bd32f96187d Author: coffeys Date: 2011-03-03 17:00 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/0bd32f96187d Merge Changeset: b645b5bc460b Author: michaelm Date: 2011-03-03 17:14 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b645b5bc460b 7024264: HttpURLConnection/NetPermission doc issue Reviewed-by: chegar ! src/share/classes/java/net/HttpURLConnection.java ! src/share/classes/java/net/NetPermission.java Changeset: 6e596210bf01 Author: michaelm Date: 2011-03-03 17:16 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/6e596210bf01 Merge Changeset: 2fb9e2d4ef46 Author: alanb Date: 2011-03-04 09:29 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/2fb9e2d4ef46 6944810: (ch) Assert failure in sun.nio.ch.PendingIoCache.clearPendingIoMap [win] Reviewed-by: chegar ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/windows/classes/sun/nio/ch/PendingIoCache.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java ! test/ProblemList.txt Changeset: 259011d14d48 Author: alanb Date: 2011-03-04 09:33 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/259011d14d48 Merge Changeset: c4bd93431a20 Author: ksrini Date: 2011-03-04 09:32 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c4bd93431a20 7023963: (misc) fix diamond anon instances in the jdk Reviewed-by: alanb, mchung, mcimadamore, dholmes ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipDirectoryStream.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipPath.java Changeset: 90b7926884a8 Author: sherman Date: 2011-03-04 11:35 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/90b7926884a8 7023244: (zipfs) langtools CompileTest fails on read-only file system Summary: replaced checkAccess with Files.isWritable() Reviewed-by: alanb ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java Changeset: 7b6ad3027f3d Author: alanb Date: 2011-03-04 21:26 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/7b6ad3027f3d 7023403: (ch) sun.nio.ch.SolarisEventPort.startPoll failed with AssertionError Reviewed-by: forax ! src/solaris/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java ! test/java/nio/channels/AsynchronousSocketChannel/Basic.java Changeset: 28bedf6eba87 Author: alanb Date: 2011-03-04 21:28 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/28bedf6eba87 Merge Changeset: 339342f311cc Author: coffeys Date: 2011-03-07 14:43 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/339342f311cc 7025105: TEST_BUG test/com/sun/jndi/ldap/NoWaitForReplyTest.java should be cleaned up Reviewed-by: alanb ! test/com/sun/jndi/ldap/NoWaitForReplyTest.java Changeset: bc0c58d65e97 Author: mullan Date: 2011-03-07 13:20 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/bc0c58d65e97 7022467: SecretKeyFactory doesn't support algorithm "AES" on Windows and Linux Reviewed-by: wetmore, valeriep ! src/share/classes/javax/crypto/SecretKeyFactory.java Changeset: 62b0337d1369 Author: mullan Date: 2011-03-07 13:44 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/62b0337d1369 Merge Changeset: 6d5a992dbac2 Author: lana Date: 2011-03-07 11:36 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/6d5a992dbac2 Merge ! make/common/Release.gmk - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java Changeset: a52da0bada39 Author: valeriep Date: 2011-03-07 14:14 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/a52da0bada39 6994008: PKCS11 should support "RSA" and "RSA/ECB/NoPadding" ciphers Summary: Add support for RSA_X_509 mechanism and aliasing of "RSA" to "RSA/ECB/PKCS1Padding". Reviewed-by: wetmore ! src/share/classes/sun/security/pkcs11/P11RSACipher.java ! src/share/classes/sun/security/pkcs11/SunPKCS11.java ! test/sun/security/pkcs11/Cipher/TestRSACipher.java ! test/sun/security/pkcs11/Cipher/TestRSACipherWrap.java + test/sun/security/pkcs11/Cipher/TestRawRSACipher.java Changeset: 0b6d82c838d4 Author: lana Date: 2011-03-07 14:48 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/0b6d82c838d4 Merge - src/share/classes/sun/misc/BootClassLoaderHook.java - src/share/classes/sun/misc/JavaSecurityCodeSignerAccess.java - test/sun/misc/BootClassLoaderHook/TestHook.java Changeset: 663c7623b96b Author: alanb Date: 2011-03-08 10:32 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/663c7623b96b 7025468: Tests using diamond with anonymous inner classes needs to be reverted Reviewed-by: dholmes, forax ! test/java/nio/file/DirectoryStream/Basic.java ! test/java/util/PriorityQueue/NoNulls.java Changeset: c0bf0f19897a Author: lana Date: 2011-03-10 19:38 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c0bf0f19897a Merge Changeset: c975c4fbca20 Author: lana Date: 2011-03-10 20:49 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c975c4fbca20 Merge ! make/common/Release.gmk - src/share/classes/sun/misc/BootClassLoaderHook.java - src/share/classes/sun/misc/JavaSecurityCodeSignerAccess.java - test/sun/misc/BootClassLoaderHook/TestHook.java Changeset: 6aeed99af874 Author: mchung Date: 2011-03-09 23:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/6aeed99af874 7025631: Remove the modules build support from jdk 7 Reviewed-by: alanb, ohair ! make/Makefile ! make/com/sun/crypto/provider/Makefile ! make/com/sun/java/pack/Makefile ! make/com/sun/java/pack/prop/Makefile ! make/com/sun/jndi/cosnaming/Makefile ! make/com/sun/jndi/dns/Makefile ! make/com/sun/jndi/ldap/Makefile ! make/com/sun/jndi/rmi/registry/Makefile ! make/com/sun/nio/sctp/Makefile ! make/com/sun/org/apache/xml/Makefile ! make/com/sun/rowset/Makefile ! make/com/sun/script/Makefile ! make/com/sun/security/auth/module/Makefile ! make/com/sun/servicetag/Makefile ! make/com/sun/tools/attach/Makefile ! make/common/Defs.gmk ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/common/Release.gmk ! make/common/Sanity.gmk ! make/common/Subdirs.gmk ! make/common/shared/Sanity.gmk ! make/java/awt/Makefile ! make/java/fdlibm/Makefile ! make/java/instrument/Makefile ! make/java/java/Makefile ! make/java/java_crw_demo/Makefile ! make/java/java_hprof_demo/Makefile ! make/java/jli/Makefile ! make/java/jvm/Makefile ! make/java/logging/Makefile ! make/java/main/java/Makefile ! make/java/main/javaw/Makefile ! make/java/management/Makefile ! make/java/net/Makefile ! make/java/nio/Makefile ! make/java/npt/Makefile ! make/java/redist/Makefile ! make/java/redist/fonts/Makefile ! make/java/redist/sajdi/Makefile ! make/java/security/Makefile ! make/java/sql/Makefile ! make/java/text/base/Makefile ! make/java/verify/Makefile ! make/java/zip/Makefile ! make/javax/crypto/Makefile ! make/javax/imageio/Makefile ! make/javax/print/Makefile ! make/javax/sound/Makefile ! make/javax/sound/jsoundalsa/Makefile ! make/javax/sound/jsoundds/Makefile ! make/javax/sql/Makefile ! make/javax/swing/Makefile ! make/javax/swing/plaf/Makefile ! make/jpda/back/Makefile ! make/jpda/transport/Makefile ! make/jpda/transport/shmem/Makefile ! make/jpda/transport/socket/Makefile ! make/jpda/tty/Makefile ! make/launchers/Makefile ! make/mkdemo/jvmti/Makefile ! make/mkdemo/management/Makefile ! make/mksample/dtrace/Makefile ! make/mksample/jmx/jmx-scandir/Makefile ! make/mksample/nbproject/Makefile ! make/mksample/nio/file/Makefile ! make/mksample/nio/multicast/Makefile ! make/mksample/nio/server/Makefile ! make/mksample/scripting/scriptpad/Makefile ! make/mksample/webservices/EbayClient/Makefile ! make/mksample/webservices/EbayServer/Makefile ! make/sun/applet/Makefile ! make/sun/awt/Makefile ! make/sun/cmm/Makefile ! make/sun/cmm/kcms/Makefile ! make/sun/cmm/lcms/Makefile ! make/sun/dcpr/Makefile ! make/sun/font/Makefile ! make/sun/font/t2k/Makefile ! make/sun/headless/Makefile ! make/sun/image/generic/Makefile ! make/sun/image/vis/Makefile ! make/sun/jar/Makefile ! make/sun/javazic/Makefile ! make/sun/jawt/Makefile ! make/sun/jconsole/Makefile ! make/sun/jdbc/Makefile ! make/sun/jdga/Makefile ! make/sun/jpeg/Makefile ! make/sun/launcher/Makefile ! make/sun/management/Makefile ! make/sun/native2ascii/Makefile ! make/sun/net/others/Makefile ! make/sun/net/spi/nameservice/dns/Makefile ! make/sun/nio/cs/Makefile ! make/sun/org/mozilla/javascript/Makefile ! make/sun/pisces/Makefile ! make/sun/rmi/cgi/Makefile ! make/sun/rmi/oldtools/Makefile ! make/sun/rmi/registry/Makefile ! make/sun/rmi/rmi/Makefile ! make/sun/rmi/rmic/Makefile ! make/sun/rmi/rmid/Makefile ! make/sun/security/ec/Makefile ! make/sun/security/jgss/wrapper/Makefile ! make/sun/security/krb5/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile ! make/sun/security/smartcardio/Makefile ! make/sun/security/tools/Makefile ! make/sun/serialver/Makefile ! make/sun/splashscreen/Makefile ! make/sun/text/Makefile ! make/sun/tools/Makefile ! make/sun/tracing/dtrace/Makefile ! make/sun/xawt/Makefile Changeset: 1657b854c956 Author: mchung Date: 2011-03-09 23:59 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/1657b854c956 7026228: Remove make/modules and make/common/Modules.gmk Reviewed-by: alanb, ohair - make/common/Modules.gmk - make/java/nio/mxbean/Makefile - make/modules/Makefile - make/modules/bootmodule.roots - make/modules/jdk7.depconfig - make/modules/modules.config - make/modules/modules.group - make/modules/optional.depconfig - make/modules/tools/Makefile - make/modules/tools/build.xml - make/modules/tools/nbproject/project.properties - make/modules/tools/nbproject/project.xml - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java - make/modules/tools/src/com/sun/classanalyzer/Klass.java - make/modules/tools/src/com/sun/classanalyzer/Module.java - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java Changeset: c28f5ac2d5f8 Author: ohair Date: 2011-03-10 14:48 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c28f5ac2d5f8 7025412: make381 issues with quotes in jdk/make/docs/Makefile and other places Reviewed-by: mchung, herrick ! make/common/shared/Defs-javadoc.gmk ! make/common/shared/Sanity.gmk ! make/docs/Makefile ! make/javax/crypto/Defs-jce.gmk Changeset: 38be400c2608 Author: asaha Date: 2011-03-09 16:44 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/38be400c2608 6908562: JFB Custom Revision Version Build/Makefile changes Reviewed-by: ohair, ksrini, katleman ! make/common/Release.gmk ! make/common/shared/Defs.gmk Changeset: fc680f496eaf Author: asaha Date: 2011-03-14 12:01 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/fc680f496eaf Merge - make/common/Modules.gmk ! make/common/Release.gmk - make/java/nio/mxbean/Makefile - make/modules/Makefile - make/modules/bootmodule.roots - make/modules/jdk7.depconfig - make/modules/modules.config - make/modules/modules.group - make/modules/optional.depconfig - make/modules/tools/Makefile - make/modules/tools/build.xml - make/modules/tools/nbproject/project.properties - make/modules/tools/nbproject/project.xml - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java - make/modules/tools/src/com/sun/classanalyzer/Klass.java - make/modules/tools/src/com/sun/classanalyzer/Module.java - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java Changeset: b1215d1f015b Author: ohair Date: 2011-03-15 15:32 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b1215d1f015b Merge - make/common/Modules.gmk ! make/common/Release.gmk - make/java/nio/mxbean/Makefile - make/modules/Makefile - make/modules/bootmodule.roots - make/modules/jdk7.depconfig - make/modules/modules.config - make/modules/modules.group - make/modules/optional.depconfig - make/modules/tools/Makefile - make/modules/tools/build.xml - make/modules/tools/nbproject/project.properties - make/modules/tools/nbproject/project.xml - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java - make/modules/tools/src/com/sun/classanalyzer/Klass.java - make/modules/tools/src/com/sun/classanalyzer/Module.java - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java ! make/sun/awt/Makefile Changeset: 3de1fed4b9ec Author: ohair Date: 2011-03-15 15:21 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/3de1fed4b9ec 6710813: SwingSet2 source display tabs do not work since JDK 7 b20 6685150: make/mkdemo/jpda/Makefile creates jpda.jar and src.zip instead of examples.jar Reviewed-by: prr ! make/common/Demo.gmk ! make/mkdemo/jfc/SwingSet2/Makefile ! make/mkdemo/jpda/Makefile Changeset: f5ecfc9e274c Author: ohair Date: 2011-03-15 23:46 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f5ecfc9e274c Merge - src/share/classes/sun/misc/BootClassLoaderHook.java - src/share/classes/sun/misc/JavaSecurityCodeSignerAccess.java - test/sun/misc/BootClassLoaderHook/TestHook.java Changeset: d6c6d9566126 Author: katleman Date: 2011-03-16 09:30 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/d6c6d9566126 6973319: incorrect spec version in jdk 7 rt.jar manifest Reviewed-by: ohair ! make/tools/manifest.mf Changeset: 76a2ea69f47f Author: katleman Date: 2011-03-16 09:42 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/76a2ea69f47f 7022473: JDK7 still runs /etc/prtconf to find memory size Reviewed-by: ohair ! make/common/shared/Platform.gmk Changeset: 554adcfb615e Author: ohair Date: 2011-03-16 15:01 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/554adcfb615e 7027923: Disable VS2003 use in preparation for all VS2003 make logic removal Reviewed-by: prr ! make/common/shared/Compiler-msvc.gmk Changeset: 0653cab602f2 Author: schien Date: 2011-03-17 14:33 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/0653cab602f2 Added tag jdk7-b134 for changeset 554adcfb615e ! .hgtags Changeset: 5371ec6c4f41 Author: lana Date: 2011-03-18 23:33 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5371ec6c4f41 Merge - make/common/Modules.gmk - make/java/nio/mxbean/Makefile - make/modules/Makefile - make/modules/bootmodule.roots - make/modules/jdk7.depconfig - make/modules/modules.config - make/modules/modules.group - make/modules/optional.depconfig - make/modules/tools/Makefile - make/modules/tools/build.xml - make/modules/tools/nbproject/project.properties - make/modules/tools/nbproject/project.xml - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java - make/modules/tools/src/com/sun/classanalyzer/Klass.java - make/modules/tools/src/com/sun/classanalyzer/Module.java - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java ! make/sun/cmm/kcms/Makefile - src/share/classes/sun/misc/BootClassLoaderHook.java - src/share/classes/sun/misc/JavaSecurityCodeSignerAccess.java - test/sun/misc/BootClassLoaderHook/TestHook.java From andrew.brygin at oracle.com Tue Mar 22 08:54:35 2011 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Tue, 22 Mar 2011 08:54:35 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6993561: java.awt.image.SampleModel.setSamples() methods not always throw ArrayIndexOutOfBoundsException Message-ID: <20110322085512.B672A47373@hg.openjdk.java.net> Changeset: 7e0c4c994e2e Author: bae Date: 2011-03-22 11:22 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/7e0c4c994e2e 6993561: java.awt.image.SampleModel.setSamples() methods not always throw ArrayIndexOutOfBoundsException Reviewed-by: jgodinez, prr ! src/share/classes/java/awt/image/SampleModel.java ! test/java/awt/image/GetSamplesTest.java From andrew.brygin at oracle.com Tue Mar 22 10:00:12 2011 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Tue, 22 Mar 2011 10:00:12 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6773586: java.awt.image.SampleModel.getPixels() methods not allways throw ArrayIndexOutOfBoundsException Message-ID: <20110322100055.ED4B547377@hg.openjdk.java.net> Changeset: 77a8566be102 Author: bae Date: 2011-03-22 12:28 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/77a8566be102 6773586: java.awt.image.SampleModel.getPixels() methods not allways throw ArrayIndexOutOfBoundsException Reviewed-by: jgodinez, prr ! src/share/classes/java/awt/image/BandedSampleModel.java ! src/share/classes/java/awt/image/ComponentSampleModel.java ! src/share/classes/java/awt/image/SampleModel.java ! src/share/classes/java/awt/image/SinglePixelPackedSampleModel.java From andrew.brygin at oracle.com Fri Mar 25 10:23:23 2011 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Fri, 25 Mar 2011 10:23:23 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6989717: media native code compiler warnings Message-ID: <20110325102352.1B74347472@hg.openjdk.java.net> Changeset: 8ab1b6226eed Author: bae Date: 2011-03-25 12:50 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/8ab1b6226eed 6989717: media native code compiler warnings Reviewed-by: jgodinez, prr ! src/share/native/sun/awt/medialib/mlib_ImageAffine.c ! src/share/native/sun/awt/medialib/mlib_ImageAffineEdge.c ! src/share/native/sun/awt/medialib/mlib_ImageColorTrue2Index.c ! src/share/native/sun/awt/medialib/mlib_ImageConvMxN.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_16ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_16nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_32nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_8ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_8nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_D64nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_F32nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_u16ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_u16nw.c ! src/share/native/sun/awt/medialib/mlib_ImageCopy_Bit.c ! src/share/native/sun/awt/medialib/mlib_ImageCreate.c From andrew.brygin at oracle.com Sun Mar 27 12:41:51 2011 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Sun, 27 Mar 2011 12:41:51 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6985593: Crash in Java_sun_java2d_loops_MaskBlit_MaskBlit on oel5.5-x64 Message-ID: <20110327124218.995B0474F9@hg.openjdk.java.net> Changeset: 0f7256505703 Author: bae Date: 2011-03-27 15:51 +0400 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/0f7256505703 6985593: Crash in Java_sun_java2d_loops_MaskBlit_MaskBlit on oel5.5-x64 Reviewed-by: ceisserer, jgodinez, prr ! src/solaris/classes/sun/java2d/xr/XRPMBlitLoops.java + test/sun/java2d/XRenderBlitsTest.java From linuxhippy at gmail.com Mon Mar 28 16:54:18 2011 From: linuxhippy at gmail.com (Clemens Eisserer) Date: Mon, 28 Mar 2011 18:54:18 +0200 Subject: [OpenJDK 2D-Dev] CR 7029934 : Xrender: Text is truncated with 64 bit Linux JRE In-Reply-To: References: <4D890AFF.6060205@oracle.com> Message-ID: Hi Phil, The problem was caused by the assumption that sizeof(int) == sizeof(XID), however Xlib uses unsigned long for XIDs, even if XIDs are defined to be 32-bit on wire. According to the xorg mailing list ists safe to store those values in 4-byte variables, the only case which needs attention are arrays. In this case the problem was I passed a Glyph* to XRenderCompositeText, which however expected a unsigned int*. Both are 4bytes wide on ia32, but Glyph is 8 bytes on amd64. XRenderFreeGlyphs was also affected. - Clemens PS: I can't access information for 7029934 - which seems to be rather common for many bug-numbers I see floating arround on the mailing lists. Any idea why? 2011/3/22 Clemens Eisserer : > Hi Phil, > > I'll have a look at this one soon. > I also hope to fix the bug causing intellij's editor to be completly > unuseable before jdk7's freeze phase - however I guess I'll need a > little help for that. > > Just remembered that I promies results some time ago, sorry, I'll send it soon. > Its just, university is giving me a really hard time. Starting with > 6th April everything will be far more relaxed =) > > Thanks, Clemens > > > 2011/3/22 Phil Race : >> >> ? ? ? ?Clemens, >> >> Have you tried 64 bit Linux JRE? SQE reports, and I have verified, text is >> truncated >> But only on Linux. Solaris is OK. B&W, greyscale, LCD are all the same. >> >> -phil.. >> >> >> >> >> >> >> >> >> *Change Request ID*: 7029934 >> >> *Synopsis*: Xrender: Text is truncated with 64 bit Linux JRE >> >> >> === *Description* >> ============================================================ >> java version "1.7.0-ea" >> Java(TM) SE Runtime Environment (build 1.7.0-ea-b134) >> Java HotSpot(TM) 64-Bit Server VM (build 21.0-b04, mixed mode) >> >> Platform: OEL6 >> 2.6.32-100.28.5.el6.x86_64 #1 SMP Wed Feb 2 18:40:23 EST 2011 x86_64 x86_64 >> x86_64 GNU/Linux >> >> Problem: >> When launch Java2Demo in OEL6 machine, the text partially shows in the >> application. It only happens in 64 bits java. >> I tried 32 bits java, the demo looks fine. >> >> Please see attached screen shot for detail. >> >> How to reproduce the problem: >> 1, Launch the demo by using jdk1.7.0-b134 ever early versions(like b120) >> 2, When the demo GUI comes up, you can see all text in frame shows only >> partially >> [root at dhcp-santaclara22-2fl-west-10-132-182-109 linux-x64]# bin/java -jar >> -Dsun.java2d.xrender=True demo/jfc/Java2D/*.jar >> XRender pipeline enabled >> Xrender: INFO: Jules library not installed. >> >> You can use the OEL6 machine to reproduce this problem, >> I add machine info is in comments >> >> *** (#1 of 1): 2011-03-22 16:41:39 GMT+00:00 tao.t.zhang at oracle.com >> *** Last Edit: 2011-03-22 17:15:42 GMT+00:00 tao.t.zhang at oracle.com >> >> >> === *Evaluation* >> ============================================================= >> Looks bad. Seems like all text rendering that goes via Xrender is truncated. >> Looks like the first half of any given drawString is visible and the rest is >> missing. Its not specific to Java2Demo. Its in SwingSet2 and in applet >> demos. >> >> It seems to have been this way since the first Xrender build (b97) and its >> not just OEL 6. Its also Ubuntu 10.04, so probably all 64 bit Linuxes. >> But 64 bit Solaris on Intel/AMD is fine! >> >> I reproduced this displaying remotely from an OEL 6 box and an Ubuntu box >> with Solaris 11 x86 as the display server, so its presumably something on >> the client (application) end. >> The code is all the same so maybe its something to do with the compilation. >> >> *** (#1 of 1): 2011-03-22 20:37:53 GMT+00:00 philip.race at oracle.com >> >> >> >> > -------------- next part -------------- A non-text attachment was scrubbed... Name: jdk.patch Type: application/octet-stream Size: 2749 bytes Desc: not available URL: From philip.race at oracle.com Mon Mar 28 17:06:08 2011 From: philip.race at oracle.com (Phil Race) Date: Mon, 28 Mar 2011 10:06:08 -0700 Subject: [OpenJDK 2D-Dev] CR 7029934 : Xrender: Text is truncated with 64 bit Linux JRE In-Reply-To: References: <4D890AFF.6060205@oracle.com> Message-ID: <4D90C000.8070009@oracle.com> Hi Clemns, Thanks for the patch. I'll take a look shortly. You wouldn't be the first person to be (very) surprised that the XID type can be 64 bits I need to look into why this didn't seem to be a problem on Solaris 11 .. I wonder how that can be ? BTW yes, there seems to be a known widespread problem with getting bug updates out. I read (on another openjdk list) that its known and being worked on. I don't know the details. -phil. On 3/28/2011 9:54 AM, Clemens Eisserer wrote: > Hi Phil, > > The problem was caused by the assumption that sizeof(int) == > sizeof(XID), however Xlib uses unsigned long for XIDs, even if XIDs > are defined to be 32-bit on wire. According to the xorg mailing list > ists safe to store those values in 4-byte variables, the only case > which needs attention are arrays. > > In this case the problem was I passed a Glyph* to > XRenderCompositeText, which however expected a unsigned int*. Both are > 4bytes wide on ia32, but Glyph is 8 bytes on amd64. XRenderFreeGlyphs > was also affected. > > - Clemens > > PS: I can't access information for 7029934 - which seems to be rather > common for many bug-numbers I see floating arround on the mailing > lists. Any idea why? > > > 2011/3/22 Clemens Eisserer: >> Hi Phil, >> >> I'll have a look at this one soon. >> I also hope to fix the bug causing intellij's editor to be completly >> unuseable before jdk7's freeze phase - however I guess I'll need a >> little help for that. >> >> Just remembered that I promies results some time ago, sorry, I'll send it soon. >> Its just, university is giving me a really hard time. Starting with >> 6th April everything will be far more relaxed =) >> >> Thanks, Clemens >> >> >> 2011/3/22 Phil Race: >>> Clemens, >>> >>> Have you tried 64 bit Linux JRE? SQE reports, and I have verified, text is >>> truncated >>> But only on Linux. Solaris is OK. B&W, greyscale, LCD are all the same. >>> >>> -phil.. >>> >>> >>> >>> >>> >>> >>> >>> >>> *Change Request ID*: 7029934 >>> >>> *Synopsis*: Xrender: Text is truncated with 64 bit Linux JRE >>> >>> >>> === *Description* >>> ============================================================ >>> java version "1.7.0-ea" >>> Java(TM) SE Runtime Environment (build 1.7.0-ea-b134) >>> Java HotSpot(TM) 64-Bit Server VM (build 21.0-b04, mixed mode) >>> >>> Platform: OEL6 >>> 2.6.32-100.28.5.el6.x86_64 #1 SMP Wed Feb 2 18:40:23 EST 2011 x86_64 x86_64 >>> x86_64 GNU/Linux >>> >>> Problem: >>> When launch Java2Demo in OEL6 machine, the text partially shows in the >>> application. It only happens in 64 bits java. >>> I tried 32 bits java, the demo looks fine. >>> >>> Please see attached screen shot for detail. >>> >>> How to reproduce the problem: >>> 1, Launch the demo by using jdk1.7.0-b134 ever early versions(like b120) >>> 2, When the demo GUI comes up, you can see all text in frame shows only >>> partially >>> [root at dhcp-santaclara22-2fl-west-10-132-182-109 linux-x64]# bin/java -jar >>> -Dsun.java2d.xrender=True demo/jfc/Java2D/*.jar >>> XRender pipeline enabled >>> Xrender: INFO: Jules library not installed. >>> >>> You can use the OEL6 machine to reproduce this problem, >>> I add machine info is in comments >>> >>> *** (#1 of 1): 2011-03-22 16:41:39 GMT+00:00 tao.t.zhang at oracle.com >>> *** Last Edit: 2011-03-22 17:15:42 GMT+00:00 tao.t.zhang at oracle.com >>> >>> >>> === *Evaluation* >>> ============================================================= >>> Looks bad. Seems like all text rendering that goes via Xrender is truncated. >>> Looks like the first half of any given drawString is visible and the rest is >>> missing. Its not specific to Java2Demo. Its in SwingSet2 and in applet >>> demos. >>> >>> It seems to have been this way since the first Xrender build (b97) and its >>> not just OEL 6. Its also Ubuntu 10.04, so probably all 64 bit Linuxes. >>> But 64 bit Solaris on Intel/AMD is fine! >>> >>> I reproduced this displaying remotely from an OEL 6 box and an Ubuntu box >>> with Solaris 11 x86 as the display server, so its presumably something on >>> the client (application) end. >>> The code is all the same so maybe its something to do with the compilation. >>> >>> *** (#1 of 1): 2011-03-22 20:37:53 GMT+00:00 philip.race at oracle.com >>> >>> >>> >>> From andrew.brygin at oracle.com Tue Mar 29 09:43:19 2011 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Tue, 29 Mar 2011 09:43:19 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7030147: java.awt.image.SampleModel.setDataElements() does't throw ArrayIndexOutOfBoundsEx for Integer.MAX_VA Message-ID: <20110329094402.4495C47568@hg.openjdk.java.net> Changeset: d1ec8c106dda Author: bae Date: 2011-03-29 13:10 +0400 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/d1ec8c106dda 7030147: java.awt.image.SampleModel.setDataElements() does't throw ArrayIndexOutOfBoundsEx for Integer.MAX_VA Reviewed-by: jgodinez, prr ! src/share/classes/java/awt/image/SampleModel.java From andrew.brygin at oracle.com Tue Mar 29 14:06:18 2011 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Tue, 29 Mar 2011 14:06:18 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7003516: Methods java.awt.geom.Line2D.Double/Float.getBounds2D() don't satisfy inherited spec Message-ID: <20110329140633.A053B47576@hg.openjdk.java.net> Changeset: 5a0c0ae1c85b Author: bae Date: 2011-03-29 17:11 +0400 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5a0c0ae1c85b 7003516: Methods java.awt.geom.Line2D.Double/Float.getBounds2D() don't satisfy inherited spec Reviewed-by: flar, prr ! src/share/classes/java/awt/Shape.java From philip.race at oracle.com Wed Mar 30 23:35:03 2011 From: philip.race at oracle.com (Phil Race) Date: Wed, 30 Mar 2011 16:35:03 -0700 Subject: [OpenJDK 2D-Dev] CR 7029934 : Xrender: Text is truncated with 64 bit Linux JRE In-Reply-To: References: <4D890AFF.6060205@oracle.com> Message-ID: <4D93BE27.4080305@oracle.com> Hi Clemens, 677 if ((ids = (jint *) (*env)->GetPrimitiveArrayCritical(env, gidArray, NULL)) == NULL) { .. 688 (*env)->ReleasePrimitiveArrayCritical(env, gidArray, gids, JNI_ABORT); ^^^^^ So the release should be on "ids". I wonder if in the 32 bit case (or more precisely sizeof(jint) == sizeof(Glyph) if we could skip the extra malloc and free ? Not sure how critical this is. 723 xids = (Glyph *) malloc(sizeof(unsigned int) * glyphCnt); The cast should now be to (unsigned int*) I can make these changes. BTW when I look at the XRender headers "render.h" I see that it defines typedef unsigned long Glyph; so its not that the XID is defined to be 64 bits its the Glyph type directly and this maybe is something that Xrender should have done differently. Also it is (was) a bug on Solaris as well. It was pilot error on my part that made me think otherwise. The only thing I've seen that concerns me is I've had a couple of abrupt disconnects from the Xserver shutting down Java2Demo. I am not sure if that's an Xserver problem or a client problem or if its even specific to this 64 bit remote display scenario or what .. because its not been that easy to reproduce. -phil. Clemens Eisserer wrote: > Hi Phil, > > The problem was caused by the assumption that sizeof(int) == > sizeof(XID), however Xlib uses unsigned long for XIDs, even if XIDs > are defined to be 32-bit on wire. According to the xorg mailing list > ists safe to store those values in 4-byte variables, the only case > which needs attention are arrays. > > In this case the problem was I passed a Glyph* to > XRenderCompositeText, which however expected a unsigned int*. Both are > 4bytes wide on ia32, but Glyph is 8 bytes on amd64. XRenderFreeGlyphs > was also affected. > > - Clemens > > PS: I can't access information for 7029934 - which seems to be rather > common for many bug-numbers I see floating arround on the mailing > lists. Any idea why? > > > 2011/3/22 Clemens Eisserer : > >> Hi Phil, >> >> I'll have a look at this one soon. >> I also hope to fix the bug causing intellij's editor to be completly >> unuseable before jdk7's freeze phase - however I guess I'll need a >> little help for that. >> >> Just remembered that I promies results some time ago, sorry, I'll send it soon. >> Its just, university is giving me a really hard time. Starting with >> 6th April everything will be far more relaxed =) >> >> Thanks, Clemens >> >> >> 2011/3/22 Phil Race : >> >>> Clemens, >>> >>> Have you tried 64 bit Linux JRE? SQE reports, and I have verified, text is >>> truncated >>> But only on Linux. Solaris is OK. B&W, greyscale, LCD are all the same. >>> >>> -phil.. >>> >>> >>> >>> >>> >>> >>> >>> >>> *Change Request ID*: 7029934 >>> >>> *Synopsis*: Xrender: Text is truncated with 64 bit Linux JRE >>> >>> >>> === *Description* >>> ============================================================ >>> java version "1.7.0-ea" >>> Java(TM) SE Runtime Environment (build 1.7.0-ea-b134) >>> Java HotSpot(TM) 64-Bit Server VM (build 21.0-b04, mixed mode) >>> >>> Platform: OEL6 >>> 2.6.32-100.28.5.el6.x86_64 #1 SMP Wed Feb 2 18:40:23 EST 2011 x86_64 x86_64 >>> x86_64 GNU/Linux >>> >>> Problem: >>> When launch Java2Demo in OEL6 machine, the text partially shows in the >>> application. It only happens in 64 bits java. >>> I tried 32 bits java, the demo looks fine. >>> >>> Please see attached screen shot for detail. >>> >>> How to reproduce the problem: >>> 1, Launch the demo by using jdk1.7.0-b134 ever early versions(like b120) >>> 2, When the demo GUI comes up, you can see all text in frame shows only >>> partially >>> [root at dhcp-santaclara22-2fl-west-10-132-182-109 linux-x64]# bin/java -jar >>> -Dsun.java2d.xrender=True demo/jfc/Java2D/*.jar >>> XRender pipeline enabled >>> Xrender: INFO: Jules library not installed. >>> >>> You can use the OEL6 machine to reproduce this problem, >>> I add machine info is in comments >>> >>> *** (#1 of 1): 2011-03-22 16:41:39 GMT+00:00 tao.t.zhang at oracle.com >>> *** Last Edit: 2011-03-22 17:15:42 GMT+00:00 tao.t.zhang at oracle.com >>> >>> >>> === *Evaluation* >>> ============================================================= >>> Looks bad. Seems like all text rendering that goes via Xrender is truncated. >>> Looks like the first half of any given drawString is visible and the rest is >>> missing. Its not specific to Java2Demo. Its in SwingSet2 and in applet >>> demos. >>> >>> It seems to have been this way since the first Xrender build (b97) and its >>> not just OEL 6. Its also Ubuntu 10.04, so probably all 64 bit Linuxes. >>> But 64 bit Solaris on Intel/AMD is fine! >>> >>> I reproduced this displaying remotely from an OEL 6 box and an Ubuntu box >>> with Solaris 11 x86 as the display server, so its presumably something on >>> the client (application) end. >>> The code is all the same so maybe its something to do with the compilation. >>> >>> *** (#1 of 1): 2011-03-22 20:37:53 GMT+00:00 philip.race at oracle.com >>> >>> >>> >>> >>> From james.graham at oracle.com Wed Mar 30 23:48:22 2011 From: james.graham at oracle.com (Jim Graham) Date: Wed, 30 Mar 2011 16:48:22 -0700 Subject: [OpenJDK 2D-Dev] CR 7029934 : Xrender: Text is truncated with 64 bit Linux JRE In-Reply-To: <4D93BE27.4080305@oracle.com> References: <4D890AFF.6060205@oracle.com> <4D93BE27.4080305@oracle.com> Message-ID: <4D93C146.7000702@oracle.com> Also, perhaps gids could be stack allocated if it is small enough like xids is in the other function? ...jim On 3/30/2011 4:35 PM, Phil Race wrote: > Hi Clemens, > > 677 if ((ids = (jint *) (*env)->GetPrimitiveArrayCritical(env, gidArray, > NULL)) == NULL) { > .. > 688 (*env)->ReleasePrimitiveArrayCritical(env, gidArray, gids, JNI_ABORT); > ^^^^^ > > > So the release should be on "ids". > > I wonder if in the 32 bit case (or more precisely sizeof(jint) == > sizeof(Glyph) > if we could skip the extra malloc and free ? Not sure how critical this is. > > > 723 xids = (Glyph *) malloc(sizeof(unsigned int) * glyphCnt); > > The cast should now be to (unsigned int*) > > I can make these changes. > > BTW when I look at the XRender headers "render.h" I see that it defines > typedef unsigned long Glyph; > > so its not that the XID is defined to be 64 bits its the Glyph type > directly and this maybe is something that Xrender should have done > differently. > > Also it is (was) a bug on Solaris as well. It was pilot error on my part > that made me think otherwise. > > The only thing I've seen that concerns me is I've had a couple of abrupt > disconnects from the Xserver shutting down Java2Demo. I am not sure > if that's an Xserver problem or a client problem or if its even specific > to this 64 bit remote display scenario or what .. because its not > been that easy to reproduce. > > -phil. > > Clemens Eisserer wrote: >> Hi Phil, >> >> The problem was caused by the assumption that sizeof(int) == >> sizeof(XID), however Xlib uses unsigned long for XIDs, even if XIDs >> are defined to be 32-bit on wire. According to the xorg mailing list >> ists safe to store those values in 4-byte variables, the only case >> which needs attention are arrays. >> >> In this case the problem was I passed a Glyph* to >> XRenderCompositeText, which however expected a unsigned int*. Both are >> 4bytes wide on ia32, but Glyph is 8 bytes on amd64. XRenderFreeGlyphs >> was also affected. >> >> - Clemens >> >> PS: I can't access information for 7029934 - which seems to be rather >> common for many bug-numbers I see floating arround on the mailing >> lists. Any idea why? >> >> >> 2011/3/22 Clemens Eisserer : >>> Hi Phil, >>> >>> I'll have a look at this one soon. >>> I also hope to fix the bug causing intellij's editor to be completly >>> unuseable before jdk7's freeze phase - however I guess I'll need a >>> little help for that. >>> >>> Just remembered that I promies results some time ago, sorry, I'll >>> send it soon. >>> Its just, university is giving me a really hard time. Starting with >>> 6th April everything will be far more relaxed =) >>> >>> Thanks, Clemens >>> >>> >>> 2011/3/22 Phil Race : >>>> Clemens, >>>> >>>> Have you tried 64 bit Linux JRE? SQE reports, and I have verified, >>>> text is >>>> truncated >>>> But only on Linux. Solaris is OK. B&W, greyscale, LCD are all the same. >>>> >>>> -phil.. >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> *Change Request ID*: 7029934 >>>> >>>> *Synopsis*: Xrender: Text is truncated with 64 bit Linux JRE >>>> >>>> >>>> === *Description* >>>> ============================================================ >>>> java version "1.7.0-ea" >>>> Java(TM) SE Runtime Environment (build 1.7.0-ea-b134) >>>> Java HotSpot(TM) 64-Bit Server VM (build 21.0-b04, mixed mode) >>>> >>>> Platform: OEL6 >>>> 2.6.32-100.28.5.el6.x86_64 #1 SMP Wed Feb 2 18:40:23 EST 2011 x86_64 >>>> x86_64 >>>> x86_64 GNU/Linux >>>> >>>> Problem: >>>> When launch Java2Demo in OEL6 machine, the text partially shows in the >>>> application. It only happens in 64 bits java. >>>> I tried 32 bits java, the demo looks fine. >>>> >>>> Please see attached screen shot for detail. >>>> >>>> How to reproduce the problem: >>>> 1, Launch the demo by using jdk1.7.0-b134 ever early versions(like >>>> b120) >>>> 2, When the demo GUI comes up, you can see all text in frame shows only >>>> partially >>>> [root at dhcp-santaclara22-2fl-west-10-132-182-109 linux-x64]# bin/java >>>> -jar >>>> -Dsun.java2d.xrender=True demo/jfc/Java2D/*.jar >>>> XRender pipeline enabled >>>> Xrender: INFO: Jules library not installed. >>>> >>>> You can use the OEL6 machine to reproduce this problem, >>>> I add machine info is in comments >>>> >>>> *** (#1 of 1): 2011-03-22 16:41:39 GMT+00:00 tao.t.zhang at oracle.com >>>> *** Last Edit: 2011-03-22 17:15:42 GMT+00:00 tao.t.zhang at oracle.com >>>> >>>> >>>> === *Evaluation* >>>> ============================================================= >>>> Looks bad. Seems like all text rendering that goes via Xrender is >>>> truncated. >>>> Looks like the first half of any given drawString is visible and the >>>> rest is >>>> missing. Its not specific to Java2Demo. Its in SwingSet2 and in applet >>>> demos. >>>> >>>> It seems to have been this way since the first Xrender build (b97) >>>> and its >>>> not just OEL 6. Its also Ubuntu 10.04, so probably all 64 bit Linuxes. >>>> But 64 bit Solaris on Intel/AMD is fine! >>>> >>>> I reproduced this displaying remotely from an OEL 6 box and an >>>> Ubuntu box >>>> with Solaris 11 x86 as the display server, so its presumably >>>> something on >>>> the client (application) end. >>>> The code is all the same so maybe its something to do with the >>>> compilation. >>>> >>>> *** (#1 of 1): 2011-03-22 20:37:53 GMT+00:00 philip.race at oracle.com >>>> >>>> >>>> >>>> > From philip.race at oracle.com Thu Mar 31 03:27:34 2011 From: philip.race at oracle.com (Phil Race) Date: Wed, 30 Mar 2011 20:27:34 -0700 Subject: [OpenJDK 2D-Dev] CR 7029934 : Xrender: Text is truncated with 64 bit Linux JRE In-Reply-To: <4D93C146.7000702@oracle.com> References: <4D890AFF.6060205@oracle.com> <4D93BE27.4080305@oracle.com> <4D93C146.7000702@oracle.com> Message-ID: <4D93F4A6.3060305@oracle.com> Yeah, I thought about that too. Wasn't sure how useful it would be. -phil. On 3/30/2011 4:48 PM, Jim Graham wrote: > Also, perhaps gids could be stack allocated if it is small enough like > xids is in the other function? > > ...jim > > On 3/30/2011 4:35 PM, Phil Race wrote: >> Hi Clemens, >> >> 677 if ((ids = (jint *) (*env)->GetPrimitiveArrayCritical(env, gidArray, >> NULL)) == NULL) { >> .. >> 688 (*env)->ReleasePrimitiveArrayCritical(env, gidArray, gids, >> JNI_ABORT); >> ^^^^^ >> >> >> So the release should be on "ids". >> >> I wonder if in the 32 bit case (or more precisely sizeof(jint) == >> sizeof(Glyph) >> if we could skip the extra malloc and free ? Not sure how critical >> this is. >> >> >> 723 xids = (Glyph *) malloc(sizeof(unsigned int) * glyphCnt); >> >> The cast should now be to (unsigned int*) >> >> I can make these changes. >> >> BTW when I look at the XRender headers "render.h" I see that it defines >> typedef unsigned long Glyph; >> >> so its not that the XID is defined to be 64 bits its the Glyph type >> directly and this maybe is something that Xrender should have done >> differently. >> >> Also it is (was) a bug on Solaris as well. It was pilot error on my part >> that made me think otherwise. >> >> The only thing I've seen that concerns me is I've had a couple of abrupt >> disconnects from the Xserver shutting down Java2Demo. I am not sure >> if that's an Xserver problem or a client problem or if its even specific >> to this 64 bit remote display scenario or what .. because its not >> been that easy to reproduce. >> >> -phil. >> >> Clemens Eisserer wrote: >>> Hi Phil, >>> >>> The problem was caused by the assumption that sizeof(int) == >>> sizeof(XID), however Xlib uses unsigned long for XIDs, even if XIDs >>> are defined to be 32-bit on wire. According to the xorg mailing list >>> ists safe to store those values in 4-byte variables, the only case >>> which needs attention are arrays. >>> >>> In this case the problem was I passed a Glyph* to >>> XRenderCompositeText, which however expected a unsigned int*. Both are >>> 4bytes wide on ia32, but Glyph is 8 bytes on amd64. XRenderFreeGlyphs >>> was also affected. >>> >>> - Clemens >>> >>> PS: I can't access information for 7029934 - which seems to be rather >>> common for many bug-numbers I see floating arround on the mailing >>> lists. Any idea why? >>> >>> >>> 2011/3/22 Clemens Eisserer : >>>> Hi Phil, >>>> >>>> I'll have a look at this one soon. >>>> I also hope to fix the bug causing intellij's editor to be completly >>>> unuseable before jdk7's freeze phase - however I guess I'll need a >>>> little help for that. >>>> >>>> Just remembered that I promies results some time ago, sorry, I'll >>>> send it soon. >>>> Its just, university is giving me a really hard time. Starting with >>>> 6th April everything will be far more relaxed =) >>>> >>>> Thanks, Clemens >>>> >>>> >>>> 2011/3/22 Phil Race : >>>>> Clemens, >>>>> >>>>> Have you tried 64 bit Linux JRE? SQE reports, and I have verified, >>>>> text is >>>>> truncated >>>>> But only on Linux. Solaris is OK. B&W, greyscale, LCD are all the >>>>> same. >>>>> >>>>> -phil.. >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> *Change Request ID*: 7029934 >>>>> >>>>> *Synopsis*: Xrender: Text is truncated with 64 bit Linux JRE >>>>> >>>>> >>>>> === *Description* >>>>> ============================================================ >>>>> java version "1.7.0-ea" >>>>> Java(TM) SE Runtime Environment (build 1.7.0-ea-b134) >>>>> Java HotSpot(TM) 64-Bit Server VM (build 21.0-b04, mixed mode) >>>>> >>>>> Platform: OEL6 >>>>> 2.6.32-100.28.5.el6.x86_64 #1 SMP Wed Feb 2 18:40:23 EST 2011 x86_64 >>>>> x86_64 >>>>> x86_64 GNU/Linux >>>>> >>>>> Problem: >>>>> When launch Java2Demo in OEL6 machine, the text partially shows in >>>>> the >>>>> application. It only happens in 64 bits java. >>>>> I tried 32 bits java, the demo looks fine. >>>>> >>>>> Please see attached screen shot for detail. >>>>> >>>>> How to reproduce the problem: >>>>> 1, Launch the demo by using jdk1.7.0-b134 ever early versions(like >>>>> b120) >>>>> 2, When the demo GUI comes up, you can see all text in frame shows >>>>> only >>>>> partially >>>>> [root at dhcp-santaclara22-2fl-west-10-132-182-109 linux-x64]# bin/java >>>>> -jar >>>>> -Dsun.java2d.xrender=True demo/jfc/Java2D/*.jar >>>>> XRender pipeline enabled >>>>> Xrender: INFO: Jules library not installed. >>>>> >>>>> You can use the OEL6 machine to reproduce this problem, >>>>> I add machine info is in comments >>>>> >>>>> *** (#1 of 1): 2011-03-22 16:41:39 GMT+00:00 tao.t.zhang at oracle.com >>>>> *** Last Edit: 2011-03-22 17:15:42 GMT+00:00 tao.t.zhang at oracle.com >>>>> >>>>> >>>>> === *Evaluation* >>>>> ============================================================= >>>>> Looks bad. Seems like all text rendering that goes via Xrender is >>>>> truncated. >>>>> Looks like the first half of any given drawString is visible and the >>>>> rest is >>>>> missing. Its not specific to Java2Demo. Its in SwingSet2 and in >>>>> applet >>>>> demos. >>>>> >>>>> It seems to have been this way since the first Xrender build (b97) >>>>> and its >>>>> not just OEL 6. Its also Ubuntu 10.04, so probably all 64 bit >>>>> Linuxes. >>>>> But 64 bit Solaris on Intel/AMD is fine! >>>>> >>>>> I reproduced this displaying remotely from an OEL 6 box and an >>>>> Ubuntu box >>>>> with Solaris 11 x86 as the display server, so its presumably >>>>> something on >>>>> the client (application) end. >>>>> The code is all the same so maybe its something to do with the >>>>> compilation. >>>>> >>>>> *** (#1 of 1): 2011-03-22 20:37:53 GMT+00:00 philip.race at oracle.com >>>>> >>>>> >>>>> >>>>> >> From philip.race at oracle.com Thu Mar 31 19:07:01 2011 From: philip.race at oracle.com (Phil Race) Date: Thu, 31 Mar 2011 12:07:01 -0700 Subject: [OpenJDK 2D-Dev] CR 7029934 : Xrender: Text is truncated with 64 bit Linux JRE In-Reply-To: <4D93F4A6.3060305@oracle.com> References: <4D890AFF.6060205@oracle.com> <4D93BE27.4080305@oracle.com> <4D93C146.7000702@oracle.com> <4D93F4A6.3060305@oracle.com> Message-ID: <4D94D0D5.8050101@oracle.com> So .. I took the liberty of revising the fix : http://cr.openjdk.java.net/~prr/7029934/ - In the 32 bit case we now avoid stack or malloc allocation - basically doing what the code was doing previously. - In the 64 bit case we use the stack up to 256 glyphs (maybe this is too much as its going to be 256*8 = 1Kbytes?) and malloc above that. I could reduce it to say 32*8 = 256 bytes. What do people think ? - I got rid of a compiler warning on line 647. This is unrelated but we are trying to eliminate such warnings. -phil. Phil Race wrote: > Yeah, I thought about that too. Wasn't sure how useful it would be. > > -phil. > > On 3/30/2011 4:48 PM, Jim Graham wrote: >> Also, perhaps gids could be stack allocated if it is small enough >> like xids is in the other function? >> >> ...jim >> >> On 3/30/2011 4:35 PM, Phil Race wrote: >>> Hi Clemens, >>> >>> 677 if ((ids = (jint *) (*env)->GetPrimitiveArrayCritical(env, >>> gidArray, >>> NULL)) == NULL) { >>> .. >>> 688 (*env)->ReleasePrimitiveArrayCritical(env, gidArray, gids, >>> JNI_ABORT); >>> ^^^^^ >>> >>> >>> So the release should be on "ids". >>> >>> I wonder if in the 32 bit case (or more precisely sizeof(jint) == >>> sizeof(Glyph) >>> if we could skip the extra malloc and free ? Not sure how critical >>> this is. >>> >>> >>> 723 xids = (Glyph *) malloc(sizeof(unsigned int) * glyphCnt); >>> >>> The cast should now be to (unsigned int*) >>> >>> I can make these changes. >>> >>> BTW when I look at the XRender headers "render.h" I see that it defines >>> typedef unsigned long Glyph; >>> >>> so its not that the XID is defined to be 64 bits its the Glyph type >>> directly and this maybe is something that Xrender should have done >>> differently. >>> >>> Also it is (was) a bug on Solaris as well. It was pilot error on my >>> part >>> that made me think otherwise. >>> >>> The only thing I've seen that concerns me is I've had a couple of >>> abrupt >>> disconnects from the Xserver shutting down Java2Demo. I am not sure >>> if that's an Xserver problem or a client problem or if its even >>> specific >>> to this 64 bit remote display scenario or what .. because its not >>> been that easy to reproduce. >>> >>> -phil. >>> >>> Clemens Eisserer wrote: >>>> Hi Phil, >>>> >>>> The problem was caused by the assumption that sizeof(int) == >>>> sizeof(XID), however Xlib uses unsigned long for XIDs, even if XIDs >>>> are defined to be 32-bit on wire. According to the xorg mailing list >>>> ists safe to store those values in 4-byte variables, the only case >>>> which needs attention are arrays. >>>> >>>> In this case the problem was I passed a Glyph* to >>>> XRenderCompositeText, which however expected a unsigned int*. Both are >>>> 4bytes wide on ia32, but Glyph is 8 bytes on amd64. XRenderFreeGlyphs >>>> was also affected. >>>> >>>> - Clemens >>>> >>>> PS: I can't access information for 7029934 - which seems to be rather >>>> common for many bug-numbers I see floating arround on the mailing >>>> lists. Any idea why? >>>> >>>> >>>> 2011/3/22 Clemens Eisserer : >>>>> Hi Phil, >>>>> >>>>> I'll have a look at this one soon. >>>>> I also hope to fix the bug causing intellij's editor to be completly >>>>> unuseable before jdk7's freeze phase - however I guess I'll need a >>>>> little help for that. >>>>> >>>>> Just remembered that I promies results some time ago, sorry, I'll >>>>> send it soon. >>>>> Its just, university is giving me a really hard time. Starting with >>>>> 6th April everything will be far more relaxed =) >>>>> >>>>> Thanks, Clemens >>>>> >>>>> >>>>> 2011/3/22 Phil Race : >>>>>> Clemens, >>>>>> >>>>>> Have you tried 64 bit Linux JRE? SQE reports, and I have verified, >>>>>> text is >>>>>> truncated >>>>>> But only on Linux. Solaris is OK. B&W, greyscale, LCD are all the >>>>>> same. >>>>>> >>>>>> -phil.. >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> *Change Request ID*: 7029934 >>>>>> >>>>>> *Synopsis*: Xrender: Text is truncated with 64 bit Linux JRE >>>>>> >>>>>> >>>>>> === *Description* >>>>>> ============================================================ >>>>>> java version "1.7.0-ea" >>>>>> Java(TM) SE Runtime Environment (build 1.7.0-ea-b134) >>>>>> Java HotSpot(TM) 64-Bit Server VM (build 21.0-b04, mixed mode) >>>>>> >>>>>> Platform: OEL6 >>>>>> 2.6.32-100.28.5.el6.x86_64 #1 SMP Wed Feb 2 18:40:23 EST 2011 x86_64 >>>>>> x86_64 >>>>>> x86_64 GNU/Linux >>>>>> >>>>>> Problem: >>>>>> When launch Java2Demo in OEL6 machine, the text partially shows >>>>>> in the >>>>>> application. It only happens in 64 bits java. >>>>>> I tried 32 bits java, the demo looks fine. >>>>>> >>>>>> Please see attached screen shot for detail. >>>>>> >>>>>> How to reproduce the problem: >>>>>> 1, Launch the demo by using jdk1.7.0-b134 ever early versions(like >>>>>> b120) >>>>>> 2, When the demo GUI comes up, you can see all text in frame >>>>>> shows only >>>>>> partially >>>>>> [root at dhcp-santaclara22-2fl-west-10-132-182-109 linux-x64]# bin/java >>>>>> -jar >>>>>> -Dsun.java2d.xrender=True demo/jfc/Java2D/*.jar >>>>>> XRender pipeline enabled >>>>>> Xrender: INFO: Jules library not installed. >>>>>> >>>>>> You can use the OEL6 machine to reproduce this problem, >>>>>> I add machine info is in comments >>>>>> >>>>>> *** (#1 of 1): 2011-03-22 16:41:39 GMT+00:00 tao.t.zhang at oracle.com >>>>>> *** Last Edit: 2011-03-22 17:15:42 GMT+00:00 tao.t.zhang at oracle.com >>>>>> >>>>>> >>>>>> === *Evaluation* >>>>>> ============================================================= >>>>>> Looks bad. Seems like all text rendering that goes via Xrender is >>>>>> truncated. >>>>>> Looks like the first half of any given drawString is visible and the >>>>>> rest is >>>>>> missing. Its not specific to Java2Demo. Its in SwingSet2 and in >>>>>> applet >>>>>> demos. >>>>>> >>>>>> It seems to have been this way since the first Xrender build (b97) >>>>>> and its >>>>>> not just OEL 6. Its also Ubuntu 10.04, so probably all 64 bit >>>>>> Linuxes. >>>>>> But 64 bit Solaris on Intel/AMD is fine! >>>>>> >>>>>> I reproduced this displaying remotely from an OEL 6 box and an >>>>>> Ubuntu box >>>>>> with Solaris 11 x86 as the display server, so its presumably >>>>>> something on >>>>>> the client (application) end. >>>>>> The code is all the same so maybe its something to do with the >>>>>> compilation. >>>>>> >>>>>> *** (#1 of 1): 2011-03-22 20:37:53 GMT+00:00 philip.race at oracle.com >>>>>> >>>>>> >>>>>> >>>>>> >>> > From philip.race at oracle.com Thu Mar 31 20:31:26 2011 From: philip.race at oracle.com (Phil Race) Date: Thu, 31 Mar 2011 13:31:26 -0700 Subject: [OpenJDK 2D-Dev] CR 7029934 : Xrender: Text is truncated with 64 bit Linux JRE In-Reply-To: <4D94D0D5.8050101@oracle.com> References: <4D890AFF.6060205@oracle.com> <4D93BE27.4080305@oracle.com> <4D93C146.7000702@oracle.com> <4D93F4A6.3060305@oracle.com> <4D94D0D5.8050101@oracle.com> Message-ID: <4D94E49E.7040505@oracle.com> On 3/31/2011 12:07 PM, Phil Race wrote: > So .. I took the liberty of revising the fix : > http://cr.openjdk.java.net/~prr/7029934/ > > - In the 32 bit case we now avoid stack or malloc allocation - basically > doing what the code was doing previously. > > - In the 64 bit case we use the stack up to 256 glyphs (maybe this is > too much > as its going to be 256*8 = 1Kbytes?) and malloc above that. I could Duh! That's 2Kbytes .. I think I'll dial this back to maybe 64 glyphs = 512 bytes before I push. -phil. From philip.race at oracle.com Thu Mar 31 22:04:14 2011 From: philip.race at oracle.com (philip.race at oracle.com) Date: Thu, 31 Mar 2011 22:04:14 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 7026407: Broken in javax.imageio.metadata.IIOMetadataNode.getTagName() Message-ID: <20110331220452.6F0EF47692@hg.openjdk.java.net> Changeset: 81c8b844e917 Author: prr Date: 2011-03-31 15:02 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/81c8b844e917 7026407: Broken in javax.imageio.metadata.IIOMetadataNode.getTagName() Reviewed-by: jgodinez ! src/share/classes/javax/imageio/metadata/IIOMetadataNode.java From james.graham at oracle.com Thu Mar 31 22:16:49 2011 From: james.graham at oracle.com (Jim Graham) Date: Thu, 31 Mar 2011 15:16:49 -0700 Subject: [OpenJDK 2D-Dev] CR 7029934 : Xrender: Text is truncated with 64 bit Linux JRE In-Reply-To: <4D94E49E.7040505@oracle.com> References: <4D890AFF.6060205@oracle.com> <4D93BE27.4080305@oracle.com> <4D93C146.7000702@oracle.com> <4D93F4A6.3060305@oracle.com> <4D94D0D5.8050101@oracle.com> <4D94E49E.7040505@oracle.com> Message-ID: <4D94FD51.90606@oracle.com> Is there a need to free all of the glyphs in a single call? Perhaps you could just convert and free up to N at a time where N is the size of your stack allocated array? ...jim On 3/31/2011 1:31 PM, Phil Race wrote: > On 3/31/2011 12:07 PM, Phil Race wrote: >> So .. I took the liberty of revising the fix : >> http://cr.openjdk.java.net/~prr/7029934/ >> >> - In the 32 bit case we now avoid stack or malloc allocation - basically >> doing what the code was doing previously. >> >> - In the 64 bit case we use the stack up to 256 glyphs (maybe this is >> too much >> as its going to be 256*8 = 1Kbytes?) and malloc above that. I could > > Duh! That's 2Kbytes .. I think I'll dial this back to maybe 64 glyphs = > 512 bytes > before I push. > > -phil. > From philip.race at oracle.com Thu Mar 31 22:24:04 2011 From: philip.race at oracle.com (Phil Race) Date: Thu, 31 Mar 2011 15:24:04 -0700 Subject: [OpenJDK 2D-Dev] CR 7029934 : Xrender: Text is truncated with 64 bit Linux JRE In-Reply-To: <4D94FD51.90606@oracle.com> References: <4D890AFF.6060205@oracle.com> <4D93BE27.4080305@oracle.com> <4D93C146.7000702@oracle.com> <4D93F4A6.3060305@oracle.com> <4D94D0D5.8050101@oracle.com> <4D94E49E.7040505@oracle.com> <4D94FD51.90606@oracle.com> Message-ID: <4D94FF04.3050402@oracle.com> If there's any latency at all in the call to Xrender such as a server round trip then that would be much slower, so it seems safer to do it as it is now. -phil. On 3/31/2011 3:16 PM, Jim Graham wrote: > Is there a need to free all of the glyphs in a single call? Perhaps > you could just convert and free up to N at a time where N is the size > of your stack allocated array? > > ...jim > > On 3/31/2011 1:31 PM, Phil Race wrote: >> On 3/31/2011 12:07 PM, Phil Race wrote: >>> So .. I took the liberty of revising the fix : >>> http://cr.openjdk.java.net/~prr/7029934/ >>> >>> - In the 32 bit case we now avoid stack or malloc allocation - >>> basically >>> doing what the code was doing previously. >>> >>> - In the 64 bit case we use the stack up to 256 glyphs (maybe this is >>> too much >>> as its going to be 256*8 = 1Kbytes?) and malloc above that. I could >> >> Duh! That's 2Kbytes .. I think I'll dial this back to maybe 64 glyphs = >> 512 bytes >> before I push. >> >> -phil. >> From philip.race at oracle.com Thu Mar 31 22:33:51 2011 From: philip.race at oracle.com (Phil Race) Date: Thu, 31 Mar 2011 15:33:51 -0700 Subject: [OpenJDK 2D-Dev] CR 7029934 : Xrender: Text is truncated with 64 bit Linux JRE In-Reply-To: <4D94FF04.3050402@oracle.com> References: <4D890AFF.6060205@oracle.com> <4D93BE27.4080305@oracle.com> <4D93C146.7000702@oracle.com> <4D93F4A6.3060305@oracle.com> <4D94D0D5.8050101@oracle.com> <4D94E49E.7040505@oracle.com> <4D94FD51.90606@oracle.com> <4D94FF04.3050402@oracle.com> Message-ID: <4D95014F.1050102@oracle.com> Updated the webrev : http://cr.openjdk.java.net/~prr/70299234.2/ reduces the size of the stack allocation and the incorrect else clause Jim pointed out. -phil. Phil Race wrote: > If there's any latency at all in the call to Xrender such as a server > round trip then that would be much slower, so it seems safer to > do it as it is now. > > -phil. > > On 3/31/2011 3:16 PM, Jim Graham wrote: >> Is there a need to free all of the glyphs in a single call? Perhaps >> you could just convert and free up to N at a time where N is the size >> of your stack allocated array? >> >> ...jim >> >> On 3/31/2011 1:31 PM, Phil Race wrote: >>> On 3/31/2011 12:07 PM, Phil Race wrote: >>>> So .. I took the liberty of revising the fix : >>>> http://cr.openjdk.java.net/~prr/7029934/ >>>> >>>> - In the 32 bit case we now avoid stack or malloc allocation - >>>> basically >>>> doing what the code was doing previously. >>>> >>>> - In the 64 bit case we use the stack up to 256 glyphs (maybe this is >>>> too much >>>> as its going to be 256*8 = 1Kbytes?) and malloc above that. I could >>> >>> Duh! That's 2Kbytes .. I think I'll dial this back to maybe 64 glyphs = >>> 512 bytes >>> before I push. >>> >>> -phil. >>> > From james.graham at oracle.com Thu Mar 31 22:39:03 2011 From: james.graham at oracle.com (Jim Graham) Date: Thu, 31 Mar 2011 15:39:03 -0700 Subject: [OpenJDK 2D-Dev] CR 7029934 : Xrender: Text is truncated with 64 bit Linux JRE In-Reply-To: <4D94FF04.3050402@oracle.com> References: <4D890AFF.6060205@oracle.com> <4D93BE27.4080305@oracle.com> <4D93C146.7000702@oracle.com> <4D93F4A6.3060305@oracle.com> <4D94D0D5.8050101@oracle.com> <4D94E49E.7040505@oracle.com> <4D94FD51.90606@oracle.com> <4D94FF04.3050402@oracle.com> Message-ID: <4D950287.3010203@oracle.com> Caveat - I don't have the source code for XRender handy to check, but... Since the request does not return any data it wouldn't require a round trip anyway, at most it would require a flush. (Note that X11 errors are asynchronous, if a request causes an error you find out some time in the future via a callback and they give you a request number for reference which you were supposed to have remembered if you cared to figure out what caused it.) X11 typically uses a fixed sized buffer that gets autoflushed as needed. Most requests in the core protocol are plural requests and so back to back equivalent Xlib calls simply append their work onto the previous request if there is still room in the buffer. When there is no more room in the buffer, it is flushed whether or not the current request is done (i.e. if the Xlib call refers to multiple independent pieces of data, like XFillRectangles() then it will put as many in the buffer as fit, flush it, and keep going until it handles all of the copies you gave it). Some versions of Xlib support flushing the buffer and writing the raw buffer you hand the request back to back so that long requests can be done in one 2-buffered chunk, though. But, those tend to be the typically large requests like sending image data over. I'm not sure they bother with that kind of technique for things like an "XFillRectangles" request where the size of the rectangle list can be easily split up and done incrementally. So, not having seen the actual implementation I can't contradict what you say, but historically they've used a number of techniques that would not require it to be true. Breaking up the XRenderLib requests into multiple calls may or may not have any effect on how many Xlib buffers get flushed... ...jim On 3/31/2011 3:24 PM, Phil Race wrote: > If there's any latency at all in the call to Xrender such as a server > round trip then that would be much slower, so it seems safer to > do it as it is now. > > -phil. > > On 3/31/2011 3:16 PM, Jim Graham wrote: >> Is there a need to free all of the glyphs in a single call? Perhaps >> you could just convert and free up to N at a time where N is the size >> of your stack allocated array? >> >> ...jim >> >> On 3/31/2011 1:31 PM, Phil Race wrote: >>> On 3/31/2011 12:07 PM, Phil Race wrote: >>>> So .. I took the liberty of revising the fix : >>>> http://cr.openjdk.java.net/~prr/7029934/ >>>> >>>> - In the 32 bit case we now avoid stack or malloc allocation - >>>> basically >>>> doing what the code was doing previously. >>>> >>>> - In the 64 bit case we use the stack up to 256 glyphs (maybe this is >>>> too much >>>> as its going to be 256*8 = 1Kbytes?) and malloc above that. I could >>> >>> Duh! That's 2Kbytes .. I think I'll dial this back to maybe 64 glyphs = >>> 512 bytes >>> before I push. >>> >>> -phil. >>> > From philip.race at oracle.com Thu Mar 31 23:26:35 2011 From: philip.race at oracle.com (Phil Race) Date: Thu, 31 Mar 2011 16:26:35 -0700 Subject: [OpenJDK 2D-Dev] CR 7029934 : Xrender: Text is truncated with 64 bit Linux JRE In-Reply-To: <4D950287.3010203@oracle.com> References: <4D890AFF.6060205@oracle.com> <4D93BE27.4080305@oracle.com> <4D93C146.7000702@oracle.com> <4D93F4A6.3060305@oracle.com> <4D94D0D5.8050101@oracle.com> <4D94E49E.7040505@oracle.com> <4D94FD51.90606@oracle.com> <4D94FF04.3050402@oracle.com> <4D950287.3010203@oracle.com> Message-ID: <4D950DAB.40607@oracle.com> So it probably is performance neutral. Is your idea that the code will be cleaner without the malloc ? I'd prefer not to change it again unless there's an identified benefit and we are sure there's no downside on performance. -phil. On 3/31/2011 3:39 PM, Jim Graham wrote: > Caveat - I don't have the source code for XRender handy to check, but... > > Since the request does not return any data it wouldn't require a round > trip anyway, at most it would require a flush. (Note that X11 errors > are asynchronous, if a request causes an error you find out some time > in the future via a callback and they give you a request number for > reference which you were supposed to have remembered if you cared to > figure out what caused it.) > > X11 typically uses a fixed sized buffer that gets autoflushed as > needed. Most requests in the core protocol are plural requests and so > back to back equivalent Xlib calls simply append their work onto the > previous request if there is still room in the buffer. When there is > no more room in the buffer, it is flushed whether or not the current > request is done (i.e. if the Xlib call refers to multiple independent > pieces of data, like XFillRectangles() then it will put as many in the > buffer as fit, flush it, and keep going until it handles all of the > copies you gave it). > > Some versions of Xlib support flushing the buffer and writing the raw > buffer you hand the request back to back so that long requests can be > done in one 2-buffered chunk, though. But, those tend to be the > typically large requests like sending image data over. I'm not sure > they bother with that kind of technique for things like an > "XFillRectangles" request where the size of the rectangle list can be > easily split up and done incrementally. > > So, not having seen the actual implementation I can't contradict what > you say, but historically they've used a number of techniques that > would not require it to be true. Breaking up the XRenderLib requests > into multiple calls may or may not have any effect on how many Xlib > buffers get flushed... > > ...jim > > On 3/31/2011 3:24 PM, Phil Race wrote: >> If there's any latency at all in the call to Xrender such as a server >> round trip then that would be much slower, so it seems safer to >> do it as it is now. >> >> -phil. >> >> On 3/31/2011 3:16 PM, Jim Graham wrote: >>> Is there a need to free all of the glyphs in a single call? Perhaps >>> you could just convert and free up to N at a time where N is the size >>> of your stack allocated array? >>> >>> ...jim >>> >>> On 3/31/2011 1:31 PM, Phil Race wrote: >>>> On 3/31/2011 12:07 PM, Phil Race wrote: >>>>> So .. I took the liberty of revising the fix : >>>>> http://cr.openjdk.java.net/~prr/7029934/ >>>>> >>>>> - In the 32 bit case we now avoid stack or malloc allocation - >>>>> basically >>>>> doing what the code was doing previously. >>>>> >>>>> - In the 64 bit case we use the stack up to 256 glyphs (maybe this is >>>>> too much >>>>> as its going to be 256*8 = 1Kbytes?) and malloc above that. I could >>>> >>>> Duh! That's 2Kbytes .. I think I'll dial this back to maybe 64 >>>> glyphs = >>>> 512 bytes >>>> before I push. >>>> >>>> -phil. >>>> >>