[OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization

Jim Graham james.graham at oracle.com
Fri Mar 4 23:19:45 UTC 2011


Hi Denis,

Renderer.java:

line 52: and => or?

line 355: Make that "16" a constant?

line 535: Would it work to use pminY and pmaxY?  Will there be any 
active edges to iterate outside of that range?

Stroker.java:

Is this blocking anyone until they find the Hotspot problem?

			...jim

On 3/4/2011 1:04 PM, Denis Lila wrote:
> Hi.
>
> In my last push to pisces I introduced a regression.
> The scanline iterator doesn't iterate over the last
> scanline. This: http://icedtea.classpath.org/~dlila/webrevs/7019861_skipped_last_scanline/webrev/
> fixes it.
>
> The webrev also includes a workaround for a hotspot
> bug and a minor optimization in Renderer.java (eliminating
> a range check on edgeBucketCounts).
>
> Is it ok to push?
>
> Thank you,
> Denis.



More information about the 2d-dev mailing list