[OpenJDK 2D-Dev] RFC: 7019861 + workaround + minor optimization
Denis Lila
dlila at redhat.com
Wed Mar 9 13:56:44 UTC 2011
> You created the constant, but didn't give it a value. ;-)
Ah, sorry (that's what I get for making a simple change in vim
and not building).
> lines 1002 & 1083 - can breaking points of a cubic generate quad
> segments and vice versa?
No, the functions that generate the offset curves can only
return a line or a curve of the same degree as the curve
whose offset they're generating.
> The rest looks good...
Thanks (I updated the webrev. Should I push?),
Denis.
PS: in the future, when it comes down to such a simple change,
should I go ahead and push, or must I wait for final confirmation?
----- Original Message -----
> Hi Denis,
>
> On 3/4/2011 3:40 PM, Denis Lila wrote:
> >> line 355: Make that "16" a constant?
> >
> > Sure.
>
>
> New stuff:
>
> Stroker.java:
>
>
>
> ...jim
More information about the 2d-dev
mailing list