[OpenJDK 2D-Dev] CR 7029934 : Xrender: Text is truncated with 64 bit Linux JRE
Phil Race
philip.race at oracle.com
Thu Mar 31 22:24:04 UTC 2011
If there's any latency at all in the call to Xrender such as a server
round trip then that would be much slower, so it seems safer to
do it as it is now.
-phil.
On 3/31/2011 3:16 PM, Jim Graham wrote:
> Is there a need to free all of the glyphs in a single call? Perhaps
> you could just convert and free up to N at a time where N is the size
> of your stack allocated array?
>
> ...jim
>
> On 3/31/2011 1:31 PM, Phil Race wrote:
>> On 3/31/2011 12:07 PM, Phil Race wrote:
>>> So .. I took the liberty of revising the fix :
>>> http://cr.openjdk.java.net/~prr/7029934/
>>>
>>> - In the 32 bit case we now avoid stack or malloc allocation -
>>> basically
>>> doing what the code was doing previously.
>>>
>>> - In the 64 bit case we use the stack up to 256 glyphs (maybe this is
>>> too much
>>> as its going to be 256*8 = 1Kbytes?) and malloc above that. I could
>>
>> Duh! That's 2Kbytes .. I think I'll dial this back to maybe 64 glyphs =
>> 512 bytes
>> before I push.
>>
>> -phil.
>>
More information about the 2d-dev
mailing list