[OpenJDK 2D-Dev] <AWT Dev> A change about the include header file of sun/awt/medialib/mlib_types.h

[Charles Lee]

On 11/15/2011 03:29 AM, Phil Race wrote:
> On 11/14/2011 7:14 AM, Artem Ananiev wrote:
>>
>> (Copying to 2d-dev as mblib is a Java2D area)
>
> The 2D group page has a handy magic decoder ring showing
> which files are AWT and which are 2D.
> http://openjdk.java.net/groups/2d/2dawtfiles.html
>
> I  compiled with this change on Windows and my Solaris 10 system and
> it compiled without any complaint that I noticed.
>
> -phil.
>
>>
>> On 11/14/2011 9:59 AM, Charles Lee wrote:
>>> Hi guys,
>>>
>>> I'd like to propose a change in mlib_types.h, it looks loke:
>>>
>>> -#if defined(__linux__)
>>> -#include <stdint.h> /* for uintptr_t */
>>> -#include <malloc.h> /* for ptrdiff_t */
>>> -#else
>>> -#include <link.h> /* for uintptr_t */
>>> -#include <stddef.h> /* for ptrdiff_t */
>>> -#endif /* __linux__ */
>>> +#include <stdint.h>
>>> +#include <stddef.h>
>>>
>>> The patch is mainly about using POSIX complaint headers to get rid of
>>> the if/else define.
>>>
>>> I have check uintptr_t on the solaris 11 express. It will be 
>>> included in
>>> stdint.h. And my ubuntu works where which malloc.h changed to stddef.h.
>>
>> Does it still compile on Solaris 10? MacOSX?
>>
>>> Would anyone like to take a look at this?
>>
>> Thanks,
>>
>> Artem
>>
>
Thanks Phil. The magic decoder page is really helpful.

-- 
Yours Charles