[OpenJDK 2D-Dev] OpenJDK Warning hackathon :) - patch 1

[Mario Torre]

Il giorno 30/nov/2011, alle ore 20:21, Phil Race ha scritto:
> Mario,
> 
> What is the warning that this fixes ? What is the reasoning ?
> I'm supposing referencing a class constant via an instance is
> somehow considered bad form but who made that call ?
> 
> -phil.
> 
> On 11/30/2011 10:57 AM, Mario Torre wrote:
>> This is the patch against the main jdk8 forest repository:
>> 
>> http://cr.openjdk.java.net/~neugens/warning-hackaton/webrev.02/
>> 
>> Btw, there is also an unused import which doesn't really issues a
>> warning but I thought to clean it as well.
>> 
>> Cheers,
>> Mario
> 


Hi Phil,

On the jdk8-dev (I should probably have CC them then, but I didn't want to cross post,
but I indeed assumed context which was in another mailing list, sorry...) Xiomara 
sent a mail about warnings cleanup and I just picked up some of the j2d since I'm more familiar
with this code.

The compiler issues warning about those classes:

[static] static variable should be qualified by type name, SunGraphics2D, instead of an extpression.

I have more of those, I just thought to send them in separate patches while I go class by class.

Cheers,
Mario
---
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

http://www.ladybug-studio.com

IcedRobot: www.icedrobot.org
Proud GNU Classpath developer: http://www.classpath.org/
Read About us at: http://planet.classpath.org
OpenJDK: http://openjdk.java.net/projects/caciocavallo/

Please, support open standards:
http://endsoftpatents.org/