[OpenJDK 2D-Dev] Please review patch for 7105461
Phil Race
philip.race at oracle.com
Fri Apr 13 18:46:04 UTC 2012
Hi Clemens,
Fix looks reasonable and good to have a fix for this!
I do think it would be safer to be better than the X11 pipeline if
possible ..
-phil.
On 4/13/2012 9:46 AM, Clemens Eisserer wrote:
> Hi,
>
> Please take a look at the patch for bug 7105461, located at
> http://cr.openjdk.java.net/~ceisserer/7105461/webrev.00/
>
> The problem was caused by Swing calling drawLine/fillRect with
> coordinates outside the valid X11 coordinate space.
> I took the same approach of the original X11 pipeline to simply clamp
> the corrdinates to the min/max allowed value although its not enterly
> correct - as it doesn't adjust width/height in case it clamps x/y -
> triggered for exmaple by the following call:
> g.fillRect(-32868, 0, 32968, 10);
>
> Should I take care of this special case, or is it ok to handle it the
> same way the X11 pipeline does?
>
> Thanks, Clemens
More information about the 2d-dev
mailing list