[OpenJDK 2D-Dev] Please review patch for 7150134

Jim Graham james.graham at oracle.com
Fri Apr 13 23:15:20 UTC 2012


I don't understand.  You are checking to see if the line is inside the 
clip, but your test will think that something is inside the clip when it 
is not so the "fast path" code will be used for lines outside the clip. 
  If the case can handle lines outside the clip then why test at all?

			...jim

On 4/13/2012 9:04 AM, Clemens Eisserer wrote:
> Hi Jim,
>
>> For a complex clip it is not enough to test the two endpoints so I don't
>> think this fix will work for a line that spans between two portions of a
>> non-rectangular clip over a region that is outside the clip...
>
> This case is handled by the native clip, so it would just be a missed
> optimization.
> Would you like me to include a check for isRetcangular?
>
> Thanks, Clemens



More information about the 2d-dev mailing list