[OpenJDK 2D-Dev] Please review patch for 7105461
Phil Race
philip.race at oracle.com
Mon Apr 16 22:50:23 UTC 2012
Looks OK to me. I'd like Jim can take a look too ..
-phil.
On 4/13/12 2:15 PM, Clemens Eisserer wrote:
> Hi Phil,
>
> Thanks for taking a look.
>
>> Fix looks reasonable and good to have a fix for this!
>> I do think it would be safer to be better than the X11 pipeline if possible
> I reworked the original patch a bit and put the checks at a higher
> level, based on the following two assumptions:
> - Clipping with the compClip will avoid coordinate overflow all the time
> - The only place where we get unclipped corrdinates is drawLine
> and fillRect, all other primitives go through the DrawHandler, which
> will only receive clipped segments anyway. Lines are already handled
> by the last patch (OOM), so this one only focuses on fillRetc.
>
> http://cr.openjdk.java.net/~ceisserer/7105461/webrev.01/
>
> I also removed a synchronized which served no purpose.
>
> Thanks, Clemens
More information about the 2d-dev
mailing list