[OpenJDK 2D-Dev] Please review patch for bug 7189452

Clemens Eisserer linuxhippy at gmail.com
Mon Aug 6 19:20:00 UTC 2012


Hi,

During playing with bug 7082809 (which will require some more time to
fix), I discovered another bug: 7189452
When rendering text with an xrender-surface as source (texturepaint,
gradientpaint), the pipeline doesn't adjust the offset of the
source-surface relative to the glyph list.
This leads to artifacts like in the attached image (left xrender,
right reference).

Please review my fix for this issue:
http://cr.openjdk.java.net/~ceisserer/7189452/webrev.00/

Is it ok to simly cast the glyphlist-offset to an integral type or
should I better use rounding?
A way to archive higher precision would be to adjust the
transformation of the source-surface, however that would require quite
a bit of extra code (as well as cycles).


Thank you in advance, Clemens
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gradtext.png
Type: image/png
Size: 3189 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20120806/d3e84f75/gradtext.png>


More information about the 2d-dev mailing list