[OpenJDK 2D-Dev] Suggest a modification to isPostscript exception handling

[Phil Race]

Sean,

Without even commenting on the merits or necessity I note that you 
cannot possibly
have even built this patch, much less tested it.

 > 625 return Boolean.FLASE;

-phil.

On 8/23/12 1:58 AM, Sean Chou wrote:
> Hello,
>
>     I updated the repository to 2d, the webrev is now:
> http://cr.openjdk.java.net/~zhouyx/OJDK-429/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ezhouyx/OJDK-429/webrev.01/>
> Please take a look.
>
> ---------- Forwarded message ----------
> From: *Sean Chou* <zhouyx at linux.vnet.ibm.com 
> <mailto:zhouyx at linux.vnet.ibm.com>>
> Date: Thu, Aug 23, 2012 at 2:24 PM
> Subject: Suggest a modification to isPostscript exception handling
> To: 2d-dev at openjdk.java.net <mailto:2d-dev at openjdk.java.net>
>
>
> Hello,
>
>      This is a simple modification to sun/print/PSPrinterJob.java.
>      When sun.print.IPPPrintService.isPostscript method checks if the 
> printer is a postscript printer, if IOException happens, the method 
> assumes the printer is postscript printer (IPPPrintService.java, line 
> 1605). In class PSPrinterJob, it invoke isPostscript and assumes all 
> Throwables to be a postscript printer ( PSPrinterJob.java, line 625 ). 
>  I think it should return false in cases exceptions other 
> than IOException are caught, IOException should not be expanded to all 
> Throwable.
>
> The webrev is at: 
> http://cr.openjdk.java.net/~zhouyx/OJDK-429/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ezhouyx/OJDK-429/webrev.00/>  .
>
> Please take a look.
>
> -- 
> Best Regards,
> Sean Chou
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20120823/ad125509/attachment.html>