From lana.steuck at oracle.com Sat Dec 1 00:44:50 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 01 Dec 2012 00:44:50 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d: 17 new changesets Message-ID: <20121201004452.897D447C53@hg.openjdk.java.net> Changeset: 8bbc72864a41 Author: ohrstrom Date: 2012-11-08 12:24 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/8bbc72864a41 8003161: small fixes to re-enable new build system Reviewed-by: dholmes, alanb, erikj ! common/makefiles/JavaCompilation.gmk Changeset: 78bb27faf889 Author: tbell Date: 2012-11-12 12:34 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/78bb27faf889 8002028: build-infra: need no-hotspot partial build Summary: Added configure option --with-import-hotspot=/path/to/j2sdkimage Reviewed-by: dholmes, tbell Contributed-by: erik.joelsson at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/source-dirs.m4 ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: f2ac4d0edaae Author: tbell Date: 2012-11-13 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/f2ac4d0edaae 8003274: build-infra: Makefile changes needed for sjavac Summary: changes left in build-infra that are related to sjavac Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com, fredrik.ohrstrom at oracle.com ! common/autoconf/spec.gmk.in ! common/makefiles/JavaCompilation.gmk ! common/makefiles/MakeHelpers.gmk Changeset: b772de306dc2 Author: katleman Date: 2012-11-14 12:28 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/b772de306dc2 Merge Changeset: 0e1b5886b06c Author: katleman Date: 2012-11-15 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/0e1b5886b06c Added tag jdk8-b65 for changeset b772de306dc2 ! .hgtags Changeset: a2df4ee40ecb Author: tbell Date: 2012-11-14 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/a2df4ee40ecb 8002026: build-infra: deploy repository building Summary: Change the compare script to handle deploy build artifacts. Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! common/bin/compare.sh ! common/bin/compare_exceptions.sh.incl Changeset: c81c4a5d8b50 Author: tbell Date: 2012-11-14 10:13 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/c81c4a5d8b50 8001875: build-infra: We must be able to force static linking of stdc++ Summary: Ensure that we build with static linking when requested, or do not build at all Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: 582c696033f5 Author: tbell Date: 2012-11-14 10:16 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/582c696033f5 8001941: build-infra: --disable-precompiled-headers does not seem to work Summary: With this fix the flag will do what it advertises Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! common/autoconf/build-performance.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/hotspot-spec.gmk.in Changeset: f59a07f85125 Author: tbell Date: 2012-11-14 10:18 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/f59a07f85125 8003317: build-infra: Configure fails when current dir is part of a symlink Summary: Call macro for removing symbolic links on a copy of the CURDIR variable before comparing Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: e69396d6d3e8 Author: tbell Date: 2012-11-14 10:20 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/e69396d6d3e8 8003327: build-infra: "/bin/sh: : cannot execute" on solaris Summary: Fix quoting inside cut command used in the pipeline Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! common/makefiles/MakeHelpers.gmk Changeset: 06f146c05f49 Author: tbell Date: 2012-11-15 00:54 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/rev/06f146c05f49 Merge Changeset: ecf751a69f6a Author: tbell Date: 2012-11-19 14:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/ecf751a69f6a 8003300: build-infra: fails on solaris when objcopy is not found Summary: Only call BASIC_FIXUP_EXECUTABLE() if objcopy was found. Reviewed-by: tbell Contributed-by: erik.joelsson at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: f8b0bacd4de5 Author: erikj Date: 2012-11-28 13:15 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/f8b0bacd4de5 8001460: build-infra: Linker warnings on macosx Summary: Only linking against jvm variant specific dirs if they are expected to exist. Reviewed-by: ohair ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: 6ff2e1280dc3 Author: erikj Date: 2012-11-28 13:40 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/6ff2e1280dc3 8003844: build-infra: docs target isn't working properly Summary: Fixed docs and docs-clean target. Added compare support for docs. Reviewed-by: ohair, jjg, ohrstrom ! common/bin/compare.sh ! common/makefiles/Main.gmk ! common/makefiles/javadoc/Javadoc.gmk Changeset: 7d7dd520ebfd Author: erikj Date: 2012-11-28 13:48 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/7d7dd520ebfd 8003528: build-infra: Diffs in libjava and hotspot libs on solaris. Summary: Linking against server jvm first if available. Adding filters and exceptions for hotspot lib compare on solaris. Reviewed-by: ohair, ohrstrom ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 ! common/bin/compare_exceptions.sh.incl Changeset: 13bb8c326e7b Author: katleman Date: 2012-11-28 14:03 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/13bb8c326e7b Merge Changeset: 16292f54195c Author: katleman Date: 2012-11-29 11:29 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/16292f54195c Added tag jdk8-b66 for changeset 13bb8c326e7b ! .hgtags From lana.steuck at oracle.com Sat Dec 1 00:44:48 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 01 Dec 2012 00:44:48 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/corba: 2 new changesets Message-ID: <20121201004453.A12B847C54@hg.openjdk.java.net> Changeset: 65771ad1ca55 Author: katleman Date: 2012-11-15 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/65771ad1ca55 Added tag jdk8-b65 for changeset 5132f7900a8f ! .hgtags Changeset: 394515ad2a55 Author: katleman Date: 2012-11-29 11:29 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/394515ad2a55 Added tag jdk8-b66 for changeset 65771ad1ca55 ! .hgtags From lana.steuck at oracle.com Sat Dec 1 00:44:54 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 01 Dec 2012 00:44:54 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxp: 2 new changesets Message-ID: <20121201004507.9A48447C56@hg.openjdk.java.net> Changeset: e6af1ad464e3 Author: katleman Date: 2012-11-15 15:39 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/e6af1ad464e3 Added tag jdk8-b65 for changeset 5cf3c69a93d6 ! .hgtags Changeset: 83df3493ca3c Author: katleman Date: 2012-11-29 11:30 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/83df3493ca3c Added tag jdk8-b66 for changeset e6af1ad464e3 ! .hgtags From lana.steuck at oracle.com Sat Dec 1 00:44:55 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 01 Dec 2012 00:44:55 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxws: 2 new changesets Message-ID: <20121201004503.A82B947C55@hg.openjdk.java.net> Changeset: 3eb7f11cb4e0 Author: katleman Date: 2012-11-15 15:39 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/3eb7f11cb4e0 Added tag jdk8-b65 for changeset fbe54291c9d3 ! .hgtags Changeset: eb06aa51dfc2 Author: katleman Date: 2012-11-29 11:30 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/eb06aa51dfc2 Added tag jdk8-b66 for changeset 3eb7f11cb4e0 ! .hgtags From lana.steuck at oracle.com Sat Dec 1 00:45:28 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 01 Dec 2012 00:45:28 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/hotspot: 42 new changesets Message-ID: <20121201004659.B8B1C47C58@hg.openjdk.java.net> Changeset: ca8168203393 Author: amurillo Date: 2012-11-02 07:44 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ca8168203393 8002181: new hotspot build - hs25-b09 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 857f3ce858dd Author: dholmes Date: 2012-11-05 19:33 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/857f3ce858dd 8002034: Allow Full Debug Symbols when cross-compiling 8001756: Hotspot makefiles report missing OBJCOPY command in the wrong circumstances Reviewed-by: dcubed, dsamersoff, erikj, collins ! make/linux/makefiles/defs.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make Changeset: 3d701c802d01 Author: minqi Date: 2012-11-02 13:30 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/3d701c802d01 8000489: older builds of hsdis don't work anymore after 6879063 Summary: The old function not defined properly, need a definition for export in dll. Also changes made to let new jvm work with old hsdis. Reviewed-by: jrose, sspitsyn, kmo Contributed-by: yumin.qi at oracle.com ! src/share/tools/hsdis/hsdis-demo.c ! src/share/tools/hsdis/hsdis.c ! src/share/tools/hsdis/hsdis.h ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/disassembler.hpp Changeset: 4735d2c84362 Author: kamg Date: 2012-10-11 12:25 -0400 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4735d2c84362 7200776: Implement default methods in interfaces Summary: Add generic type analysis and default method selection algorithms Reviewed-by: coleenp, acorn + src/share/vm/classfile/bytecodeAssembler.cpp + src/share/vm/classfile/bytecodeAssembler.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp + src/share/vm/classfile/defaultMethods.cpp + src/share/vm/classfile/defaultMethods.hpp + src/share/vm/classfile/genericSignatures.cpp + src/share/vm/classfile/genericSignatures.hpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/utilities/growableArray.hpp + src/share/vm/utilities/pair.hpp + src/share/vm/utilities/resourceHash.hpp Changeset: ec204374e626 Author: kamg Date: 2012-11-02 16:09 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ec204374e626 Merge ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/runtime/globals.hpp - test/runtime/7158800/BadUtf8.java - test/runtime/7158800/InternTest.java - test/runtime/7158800/Test7158800.sh - test/runtime/7158800/badstrings.txt Changeset: 9cc901118f6b Author: kamg Date: 2012-11-02 17:18 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/9cc901118f6b Merge Changeset: 69ad7823b1ca Author: zgu Date: 2012-11-05 15:30 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/69ad7823b1ca 8001591: NMT: assertion failed: assert(rec->addr() + rec->size() <= cur->base()) failed: Can not overlap in memSnapshot.cpp Summary: NMT should allow overlapping committed regions as long as they belong to the same reserved region Reviewed-by: dholmes, coleenp ! src/share/vm/services/memPtr.hpp ! src/share/vm/services/memSnapshot.cpp Changeset: 8940ddc1036f Author: zgu Date: 2012-11-05 13:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8940ddc1036f Merge - test/runtime/7158800/BadUtf8.java - test/runtime/7158800/InternTest.java - test/runtime/7158800/Test7158800.sh - test/runtime/7158800/badstrings.txt Changeset: c284cf4781f0 Author: rbackman Date: 2012-10-04 14:55 +0200 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c284cf4781f0 7127792: Add the ability to change an existing PeriodicTask's execution interval Summary: Enables dynamic enrollment / disenrollment from the PeriodicTasks in WatcherThread. Reviewed-by: dholmes, mgronlun ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp ! src/share/vm/runtime/task.cpp ! src/share/vm/runtime/task.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 18fb7da42534 Author: coleenp Date: 2012-11-06 15:09 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/18fb7da42534 8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass Summary: Change types of above methods and field to InstanceKlass and remove unneeded casts from the source files. Reviewed-by: dholmes, coleenp, zgu Contributed-by: harold.seigel at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPool.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/code/compiledIC.cpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compilerOracle.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/fieldDescriptor.hpp ! src/share/vm/runtime/javaCalls.cpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/vframe.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/heapDumper.cpp Changeset: ead8852dd4ef Author: coleenp Date: 2012-11-07 16:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ead8852dd4ef Merge Changeset: 64672b22ef05 Author: twisti Date: 2012-11-02 12:30 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/64672b22ef05 8001658: No need to pass resolved_references as argument to ConstantPoolCacheEntry::set_method_handle_common Reviewed-by: twisti Contributed-by: Bharadwaj Yadavalli ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp Changeset: dbeaeee28bc2 Author: kvn Date: 2012-11-06 09:22 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/dbeaeee28bc2 8002294: assert(VM_Version::supports_ssse3()) failed Summary: Add missing UseSSE check for AES intrinsics. Reviewed-by: roland, twisti ! src/cpu/x86/vm/vm_version_x86.cpp Changeset: f3da5ff1514c Author: kvn Date: 2012-11-06 15:16 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f3da5ff1514c 8002069: Assert failed in C2: assert(field->edge_count() > 0) failed: sanity Summary: Added missed type check of initializing store in ConnectionGraph::find_init_values(). Reviewed-by: roland, twisti, vlivanov ! src/share/vm/opto/escape.cpp + test/compiler/8002069/Test8002069.java Changeset: a4e1bd941ded Author: neliasso Date: 2012-11-08 22:39 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/a4e1bd941ded Merge ! src/share/vm/oops/cpCache.cpp Changeset: b4ee7b773144 Author: amurillo Date: 2012-11-09 08:20 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b4ee7b773144 Merge Changeset: 0f7290a03b24 Author: amurillo Date: 2012-11-09 08:20 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/0f7290a03b24 Added tag hs25-b09 for changeset b4ee7b773144 ! .hgtags Changeset: 4e3e685dbc9d Author: katleman Date: 2012-11-15 15:39 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4e3e685dbc9d Added tag jdk8-b65 for changeset 0f7290a03b24 ! .hgtags Changeset: 3be318ecfae5 Author: amurillo Date: 2012-11-09 08:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/3be318ecfae5 8003231: new hotspot build - hs25-b10 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 6cb0d32b828b Author: bpittore Date: 2012-11-07 17:53 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6cb0d32b828b 8001185: parsing of sun.boot.library.path in os::dll_build_name somewhat broken Summary: dll_dir can contain multiple paths, need to parse them correctly when loading agents Reviewed-by: dholmes, dlong Contributed-by: bill.pittore at oracle.com ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/thread.cpp Changeset: d9a84e246cce Author: cjplummer Date: 2012-11-09 09:45 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d9a84e246cce Merge ! src/share/vm/runtime/thread.cpp Changeset: 429994fc0754 Author: cjplummer Date: 2012-11-14 10:13 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/429994fc0754 Merge Changeset: 6bc207d87e5d Author: mgerdin Date: 2012-11-09 00:38 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6bc207d87e5d 7200229: NPG: possible performance issue exposed by closed/runtime/6559877/Test6559877.java Summary: Reduce the amount of calls to ChunkManager verification code Reviewed-by: jmasa, coleenp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp Changeset: 0400886d2613 Author: coleenp Date: 2012-11-14 22:37 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/0400886d2613 8003259: NPG: Build with gcc 4.7.2 broken by 7045397 Summary: Qualify calls with this pointers to make gcc accept this code. Reviewed-by: coleenp, andrew Contributed-by: peter.levart at gmail.com ! src/share/vm/memory/binaryTreeDictionary.cpp Changeset: c5d4acbb943d Author: johnc Date: 2012-11-15 14:29 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c5d4acbb943d Merge Changeset: bd7a7ce2e264 Author: minqi Date: 2012-11-12 14:03 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/bd7a7ce2e264 6830717: replay of compilations would help with debugging Summary: When java process crashed in compiler thread, repeat the compilation process will help finding root cause. This is done with using SA dump application class data and replay data from core dump, then use debug version of jvm to recompile the problematic java method. Reviewed-by: kvn, twisti, sspitsyn Contributed-by: yumin.qi at oracle.com + agent/doc/c2replay.html ! agent/doc/clhsdb.html ! agent/doc/index.html ! agent/make/Makefile ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciBaseObject.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciConstant.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciEnv.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciInstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciMethod.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciMethodData.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/compiler/CompileTask.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCache.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Field.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Metadata.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MethodData.java ! src/share/vm/ci/ciClassList.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciInstanceKlass.hpp ! src/share/vm/ci/ciMetadata.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciMethodData.cpp ! src/share/vm/ci/ciMethodData.hpp ! src/share/vm/ci/ciObject.hpp ! src/share/vm/ci/ciObjectFactory.hpp + src/share/vm/ci/ciReplay.cpp + src/share/vm/ci/ciReplay.hpp ! src/share/vm/ci/ciSymbol.cpp ! src/share/vm/ci/ciSymbol.hpp ! src/share/vm/ci/ciUtilities.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/interpreter/invocationCounter.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/symbol.cpp ! src/share/vm/oops/symbol.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/array.hpp ! src/share/vm/utilities/utf8.cpp ! src/share/vm/utilities/utf8.hpp ! src/share/vm/utilities/vmError.cpp Changeset: bb33c6fdcf0d Author: bharadwaj Date: 2012-11-15 10:42 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/bb33c6fdcf0d 8001077: remove ciMethod::will_link Summary: Removed will_link and changed all calls to is_loaded(). Reviewed-by: kvn ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/opto/doCall.cpp Changeset: 6b6ddf8c4329 Author: neliasso Date: 2012-11-16 09:59 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6b6ddf8c4329 Merge Changeset: 64812523d72e Author: sspitsyn Date: 2012-10-31 16:20 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/64812523d72e 7194607: VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge Summary: Use verifier_max_size instead of max_size to get code attribute max stack size. Reviewed-by: dcubed, minqi Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp Changeset: 8aaef2cee3b2 Author: minqi Date: 2012-11-08 16:48 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8aaef2cee3b2 Merge ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp - test/runtime/7158800/BadUtf8.java - test/runtime/7158800/InternTest.java - test/runtime/7158800/Test7158800.sh - test/runtime/7158800/badstrings.txt Changeset: ed8b1e39ff4f Author: zgu Date: 2012-11-09 11:04 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ed8b1e39ff4f 8002273: NMT to report JNI memory leaks when -Xcheck:jni is on Summary: Allows NMT to report that JNI thread failed to detach from JVM before exiting, which leaks the JavaThread object when check:jni option is on. Reviewed-by: acorn, dholmes, coleenp, ctornqvi ! src/share/vm/services/memSnapshot.cpp Changeset: 4efcd79826f2 Author: zgu Date: 2012-11-09 11:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4efcd79826f2 Merge Changeset: fb3190e77d3c Author: zgu Date: 2012-11-09 19:24 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/fb3190e77d3c 8001592: NMT: assertion failed: assert(_amount >= amt) failed: Just check: memBaseline.hpp:180 Summary: Fixed NMT that miscounted arena memory when it is used as value or stack object. Reviewed-by: acorn, coleenp ! src/share/vm/services/memBaseline.cpp ! src/share/vm/services/memPtr.hpp ! src/share/vm/services/memSnapshot.cpp ! src/share/vm/services/memSnapshot.hpp ! src/share/vm/services/memTracker.hpp Changeset: e26ce0e8b666 Author: zgu Date: 2012-11-09 16:45 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e26ce0e8b666 Merge Changeset: 8c413497f434 Author: zgu Date: 2012-11-09 22:22 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8c413497f434 Merge ! src/share/vm/services/memSnapshot.cpp Changeset: e4f764ddb06a Author: hseigel Date: 2012-11-12 15:58 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e4f764ddb06a 7122219: Passed StringTableSize value not verified Summary: Check that the values specified for -XX:StringTableSize are within a certain range. Reviewed-by: dholmes, coleenp ! src/share/vm/classfile/symbolTable.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 070d523b96a7 Author: hseigel Date: 2012-11-12 16:15 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/070d523b96a7 8001471: Klass::cast() does nothing Summary: Remove function Klass::cast() and calls to it. Reviewed-by: dholmes, coleenp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciType.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/loaderConstraints.cpp ! src/share/vm/classfile/placeholders.cpp ! src/share/vm/classfile/placeholders.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlass.hpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiGetLoadedClasses.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/jvmtiTrace.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/biasedLocking.cpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/signature.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vframe.cpp ! src/share/vm/services/classLoadingService.hpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/serviceUtil.hpp Changeset: 24e193d2a007 Author: coleenp Date: 2012-11-13 15:14 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/24e193d2a007 Merge Changeset: 80e866b1d053 Author: coleenp Date: 2012-11-16 09:19 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/80e866b1d053 Merge ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/thread.cpp Changeset: cfc5309f03b7 Author: amurillo Date: 2012-11-16 09:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/cfc5309f03b7 Merge Changeset: 01684f7fee1b Author: amurillo Date: 2012-11-16 09:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/01684f7fee1b Added tag hs25-b10 for changeset cfc5309f03b7 ! .hgtags Changeset: 2f6dc76eb8e5 Author: katleman Date: 2012-11-29 11:30 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/2f6dc76eb8e5 Added tag jdk8-b66 for changeset 01684f7fee1b ! .hgtags From lana.steuck at oracle.com Sat Dec 1 00:45:13 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 01 Dec 2012 00:45:13 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/langtools: 23 new changesets Message-ID: <20121201004612.CEDA747C57@hg.openjdk.java.net> Changeset: b5d326a809a1 Author: katleman Date: 2012-11-15 15:40 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/b5d326a809a1 Added tag jdk8-b65 for changeset 5f2faba89cac ! .hgtags Changeset: e6b1abdc11ca Author: rfield Date: 2012-11-13 08:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/e6b1abdc11ca 8003306: Compiler crash: calculation of inner class access modifier Summary: Fix binary sense lost in transition to hasTag Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/InnerConstructor.java Changeset: 2901c7b5339e Author: jjg Date: 2012-11-13 15:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/2901c7b5339e 8003299: Cleanup javac Log support for deferred diagnostics Reviewed-by: mcimadamore, jfranck ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/Log.java Changeset: f14c693a0e48 Author: jjg Date: 2012-11-14 10:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/f14c693a0e48 8003412: javac needs to understand java.lang.annotation.Native Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java ! test/tools/javac/nativeHeaders/NativeHeaderTest.java ! test/tools/javac/nativeHeaders/javahComparison/CompareTest.java + test/tools/javac/nativeHeaders/javahComparison/TestClass4.java + test/tools/javac/nativeHeaders/javahComparison/TestClass5.java Changeset: b486794d160d Author: lana Date: 2012-11-14 16:41 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/b486794d160d Merge Changeset: 33abf479f202 Author: jjg Date: 2012-11-14 17:23 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/33abf479f202 7021614: extend com.sun.source API to support parsing javadoc comments Reviewed-by: ksrini, strarup ! make/build.xml + src/share/classes/com/sun/source/doctree/AttributeTree.java + src/share/classes/com/sun/source/doctree/AuthorTree.java + src/share/classes/com/sun/source/doctree/BlockTagTree.java + src/share/classes/com/sun/source/doctree/CommentTree.java + src/share/classes/com/sun/source/doctree/DeprecatedTree.java + src/share/classes/com/sun/source/doctree/DocCommentTree.java + src/share/classes/com/sun/source/doctree/DocRootTree.java + src/share/classes/com/sun/source/doctree/DocTree.java + src/share/classes/com/sun/source/doctree/DocTreeVisitor.java + src/share/classes/com/sun/source/doctree/EndElementTree.java + src/share/classes/com/sun/source/doctree/EntityTree.java + src/share/classes/com/sun/source/doctree/ErroneousTree.java + src/share/classes/com/sun/source/doctree/IdentifierTree.java + src/share/classes/com/sun/source/doctree/InheritDocTree.java + src/share/classes/com/sun/source/doctree/InlineTagTree.java + src/share/classes/com/sun/source/doctree/LinkTree.java + src/share/classes/com/sun/source/doctree/LiteralTree.java + src/share/classes/com/sun/source/doctree/ParamTree.java + src/share/classes/com/sun/source/doctree/ReferenceTree.java + src/share/classes/com/sun/source/doctree/ReturnTree.java + src/share/classes/com/sun/source/doctree/SeeTree.java + src/share/classes/com/sun/source/doctree/SerialDataTree.java + src/share/classes/com/sun/source/doctree/SerialFieldTree.java + src/share/classes/com/sun/source/doctree/SerialTree.java + src/share/classes/com/sun/source/doctree/SinceTree.java + src/share/classes/com/sun/source/doctree/StartElementTree.java + src/share/classes/com/sun/source/doctree/TextTree.java + src/share/classes/com/sun/source/doctree/ThrowsTree.java + src/share/classes/com/sun/source/doctree/UnknownBlockTagTree.java + src/share/classes/com/sun/source/doctree/UnknownInlineTagTree.java + src/share/classes/com/sun/source/doctree/ValueTree.java + src/share/classes/com/sun/source/doctree/VersionTree.java + src/share/classes/com/sun/source/doctree/package-info.java ! src/share/classes/com/sun/source/tree/Tree.java + src/share/classes/com/sun/source/util/DocTreeScanner.java + src/share/classes/com/sun/source/util/DocTrees.java + src/share/classes/com/sun/source/util/SimpleDocTreeVisitor.java ! src/share/classes/com/sun/source/util/Trees.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/AttrContext.java ! src/share/classes/com/sun/tools/javac/comp/Env.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java + src/share/classes/com/sun/tools/javac/parser/LazyDocCommentTable.java ! src/share/classes/com/sun/tools/javac/parser/ParserFactory.java - src/share/classes/com/sun/tools/javac/parser/SimpleDocCommentTable.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + src/share/classes/com/sun/tools/javac/tree/DCTree.java ! src/share/classes/com/sun/tools/javac/tree/DocCommentTable.java + src/share/classes/com/sun/tools/javac/tree/DocPretty.java + src/share/classes/com/sun/tools/javac/tree/DocTreeMaker.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/SeeTagImpl.java ! test/tools/javac/diags/CheckExamples.java + test/tools/javac/diags/DocCommentProcessor.java ! test/tools/javac/diags/Example.java ! test/tools/javac/diags/RunExamples.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/BadEntity.java + test/tools/javac/diags/examples/BadGreaterThan.java + test/tools/javac/diags/examples/BadInlineTag.java + test/tools/javac/diags/examples/GreaterThanExpected.java + test/tools/javac/diags/examples/MalformedHTML.java + test/tools/javac/diags/examples/MissingSemicolon.java + test/tools/javac/diags/examples/NoTagName.java + test/tools/javac/diags/examples/RefBadParens.java + test/tools/javac/diags/examples/RefIdentifierExpected.java + test/tools/javac/diags/examples/RefSyntaxError.java + test/tools/javac/diags/examples/RefUnexpectedInput.java + test/tools/javac/diags/examples/UnexpectedContent.java + test/tools/javac/diags/examples/UnterminatedInlineTag.java + test/tools/javac/diags/examples/UnterminatedSignature.java + test/tools/javac/doctree/AttrTest.java + test/tools/javac/doctree/AuthorTest.java + test/tools/javac/doctree/BadTest.java + test/tools/javac/doctree/CodeTest.java + test/tools/javac/doctree/DeprecatedTest.java + test/tools/javac/doctree/DocCommentTester.java + test/tools/javac/doctree/DocRootTest.java + test/tools/javac/doctree/ElementTest.java + test/tools/javac/doctree/EntityTest.java + test/tools/javac/doctree/ExceptionTest.java + test/tools/javac/doctree/FirstSentenceTest.java + test/tools/javac/doctree/InheritDocTest.java + test/tools/javac/doctree/LinkPlainTest.java + test/tools/javac/doctree/LinkTest.java + test/tools/javac/doctree/LiteralTest.java + test/tools/javac/doctree/ParamTest.java + test/tools/javac/doctree/ReferenceTest.java + test/tools/javac/doctree/ReturnTest.java + test/tools/javac/doctree/SeeTest.java + test/tools/javac/doctree/SerialDataTest.java + test/tools/javac/doctree/SerialFieldTest.java + test/tools/javac/doctree/SerialTest.java + test/tools/javac/doctree/SimpleDocTreeVisitorTest.java + test/tools/javac/doctree/SinceTest.java + test/tools/javac/doctree/TagTest.java + test/tools/javac/doctree/ThrowableTest.java + test/tools/javac/doctree/ValueTest.java + test/tools/javac/doctree/VersionTest.java Changeset: bfec2a1cc869 Author: jjg Date: 2012-11-15 09:18 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/bfec2a1cc869 8000800: javadoc uses static non-final fields Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/DocType.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/javadoc/ParamTagImpl.java ! test/com/sun/javadoc/MetaTag/MetaTag.java ! test/com/sun/javadoc/testHtmlDocument/TestHtmlDocument.java Changeset: 467f4f754368 Author: jjg Date: 2012-11-15 14:41 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/467f4f754368 8003257: refactor javadoc tool option handling Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocLocale.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/Start.java + src/share/classes/com/sun/tools/javadoc/ToolOption.java Changeset: 400a4e8accd3 Author: jjg Date: 2012-11-15 19:54 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/400a4e8accd3 8002079: update DocFile to use a JavaFileManager Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFile.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFileFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPath.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PathDocFileFactory.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SimpleDocFileFactory.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/StandardDocFileFactory.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java Changeset: bdcef2ef52d2 Author: jjg Date: 2012-11-15 23:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/bdcef2ef52d2 6493690: javadoc should have a javax.tools.Tool service provider installed in tools.jar Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFile.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFileFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PathDocFileFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SimpleDocFileFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/StandardDocFileFactory.java ! src/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/Start.java + src/share/classes/com/sun/tools/javadoc/api/JavadocTaskImpl.java + src/share/classes/com/sun/tools/javadoc/api/JavadocTool.java ! src/share/classes/com/sun/tools/javadoc/resources/javadoc.properties + src/share/classes/javax/tools/DocumentationTool.java ! src/share/classes/javax/tools/JavaCompiler.java ! src/share/classes/javax/tools/ToolProvider.java ! test/tools/javadoc/CheckResourceKeys.java + test/tools/javadoc/api/basic/APITest.java + test/tools/javadoc/api/basic/DocletPathTest.java + test/tools/javadoc/api/basic/GetSourceVersionsTest.java + test/tools/javadoc/api/basic/GetTask_DiagListenerTest.java + test/tools/javadoc/api/basic/GetTask_DocletClassTest.java + test/tools/javadoc/api/basic/GetTask_FileManagerTest.java + test/tools/javadoc/api/basic/GetTask_FileObjectsTest.java + test/tools/javadoc/api/basic/GetTask_OptionsTest.java + test/tools/javadoc/api/basic/GetTask_WriterTest.java + test/tools/javadoc/api/basic/IsSupportedOptionTest.java + test/tools/javadoc/api/basic/JavadocTaskImplTest.java + test/tools/javadoc/api/basic/RunTest.java + test/tools/javadoc/api/basic/TagletPathTest.java + test/tools/javadoc/api/basic/Task_reuseTest.java + test/tools/javadoc/api/basic/pkg/C.java + test/tools/javadoc/api/basic/taglets/UnderlineTaglet.java Changeset: 843d3b191773 Author: jjh Date: 2012-11-16 18:27 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/843d3b191773 8003357: Add support for jtreg -concurrency to langtools/test/Makefile Reviewed-by: jjg ! test/Makefile Changeset: 01c9d4161882 Author: mcimadamore Date: 2012-11-17 19:01 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/01c9d4161882 8003280: Add lambda tests Summary: Turn on lambda expression, method reference and default method support Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/Warner.java ! test/tools/javac/conditional/Conditional.java ! test/tools/javac/defaultMethods/ClassReaderTest/ClassReaderTest.java ! test/tools/javac/defaultMethods/Neg01.java ! test/tools/javac/defaultMethods/Neg02.java ! test/tools/javac/defaultMethods/Neg03.java ! test/tools/javac/defaultMethods/Neg04.java ! test/tools/javac/defaultMethods/Neg05.java ! test/tools/javac/defaultMethods/Neg06.java ! test/tools/javac/defaultMethods/Neg07.java ! test/tools/javac/defaultMethods/Neg08.java ! test/tools/javac/defaultMethods/Neg09.java ! test/tools/javac/defaultMethods/Neg10.java ! test/tools/javac/defaultMethods/Neg11.java ! test/tools/javac/defaultMethods/Neg12.java ! test/tools/javac/defaultMethods/Neg12.out ! test/tools/javac/defaultMethods/Neg13.java ! test/tools/javac/defaultMethods/Neg14.java ! test/tools/javac/defaultMethods/Neg15.java ! test/tools/javac/defaultMethods/Neg16.java ! test/tools/javac/defaultMethods/Pos01.java ! test/tools/javac/defaultMethods/Pos02.java ! test/tools/javac/defaultMethods/Pos04.java ! test/tools/javac/defaultMethods/Pos05.java ! test/tools/javac/defaultMethods/Pos06.java ! test/tools/javac/defaultMethods/Pos07.java ! test/tools/javac/defaultMethods/Pos08.java ! test/tools/javac/defaultMethods/Pos10.java ! test/tools/javac/defaultMethods/Pos11.java ! test/tools/javac/defaultMethods/Pos12.java ! test/tools/javac/defaultMethods/Pos13.java ! test/tools/javac/defaultMethods/Pos14.java ! test/tools/javac/defaultMethods/Pos15.java ! test/tools/javac/defaultMethods/Pos16.java ! test/tools/javac/defaultMethods/TestDefaultBody.java ! test/tools/javac/defaultMethods/TestNoBridgeOnDefaults.java ! test/tools/javac/defaultMethods/fd/FDTest.java ! test/tools/javac/defaultMethods/separate/Separate.java ! test/tools/javac/defaultMethods/super/TestDefaultSuperCall.java ! test/tools/javac/defaultMethods/syntax/TestDefaultMethodsSyntax.java - test/tools/javac/diags/examples/CantAccessArgTypeInFunctionalDesc.java ! test/tools/javac/diags/examples/CantAccessInnerClsConstr.java - test/tools/javac/diags/examples/CantAccessReturnTypeInFunctionalDesc.java - test/tools/javac/diags/examples/CantAccessThrownTypesInFunctionalDesc.java ! test/tools/javac/diags/examples/CantApplySymbolFragment.java ! test/tools/javac/diags/examples/CantApplySymbolsFragment.java ! test/tools/javac/diags/examples/CantRefNonEffectivelyFinalVar.java ! test/tools/javac/diags/examples/CantResolveLocationArgsFragment.java ! test/tools/javac/diags/examples/CantResolveLocationArgsParamsFragment.java - test/tools/javac/diags/examples/CantReturnValueForVoid.java + test/tools/javac/diags/examples/ConditionalTargetCantBeVoid.java ! test/tools/javac/diags/examples/CyclicInference.java ! test/tools/javac/diags/examples/DefaultOverridesObjectMember.java ! test/tools/javac/diags/examples/IncompatibleAbstracts.java ! test/tools/javac/diags/examples/IncompatibleArgTypesInLambda.java ! test/tools/javac/diags/examples/IncompatibleDescsInFunctionalIntf.java ! test/tools/javac/diags/examples/IncompatibleRetTypeInLambda.java ! test/tools/javac/diags/examples/IncompatibleRetTypeInMref.java ! test/tools/javac/diags/examples/IncompatibleThrownTypesInLambda.java ! test/tools/javac/diags/examples/IncompatibleThrownTypesInMref.java ! test/tools/javac/diags/examples/IncompatibleTypesInConditional.java ! test/tools/javac/diags/examples/InvalidGenericDescInFunctionalInterface.java ! test/tools/javac/diags/examples/LocalVarNeedsFinal.java ! test/tools/javac/diags/examples/MissingReturnValue.java ! test/tools/javac/diags/examples/MissingReturnValueFragment.java ! test/tools/javac/diags/examples/NoAbstracts.java ! test/tools/javac/diags/examples/NoSuitableFunctionalIntfInst.java ! test/tools/javac/diags/examples/NonStaticCantBeRefFragment.java ! test/tools/javac/diags/examples/NotAFunctionalIntf.java ! test/tools/javac/diags/examples/NotDefAccessClassIntfCantAccessFragment.java ! test/tools/javac/diags/examples/OverriddenDefault.java ! test/tools/javac/diags/examples/PotentialLambdaFound.java ! test/tools/javac/diags/examples/RedundantSupertype.java ! test/tools/javac/diags/examples/RefAmbiguousFragment.java ! test/tools/javac/diags/examples/TypesIncompatibleAbstractDefault.java ! test/tools/javac/diags/examples/TypesIncompatibleUnrelatedDefaults.java ! test/tools/javac/diags/examples/UnexpectedLambda.java ! test/tools/javac/diags/examples/UnexpectedMref.java + test/tools/javac/diags/examples/UnexpectedReturnValue.java ! test/tools/javac/generics/7022054/T7022054pos1.java + test/tools/javac/generics/7022054/T7022054pos1.out ! test/tools/javac/generics/7022054/T7022054pos2.java + test/tools/javac/generics/7022054/T7022054pos2.out + test/tools/javac/lambda/BadAccess.java + test/tools/javac/lambda/BadAccess.out + test/tools/javac/lambda/BadAccess02.java + test/tools/javac/lambda/BadAccess02.out + test/tools/javac/lambda/BadAccess03.java + test/tools/javac/lambda/BadAccess03.out + test/tools/javac/lambda/BadBreakContinue.java + test/tools/javac/lambda/BadBreakContinue.out + test/tools/javac/lambda/BadConv03.java + test/tools/javac/lambda/BadConv03.out + test/tools/javac/lambda/BadConv04.java + test/tools/javac/lambda/BadConv04.out + test/tools/javac/lambda/BadExpressionLambda.java + test/tools/javac/lambda/BadExpressionLambda.out + test/tools/javac/lambda/BadLambdaExpr.java + test/tools/javac/lambda/BadLambdaPos.java + test/tools/javac/lambda/BadLambdaPos.out + test/tools/javac/lambda/BadMethodCall.java + test/tools/javac/lambda/BadMethodCall.out + test/tools/javac/lambda/BadRecovery.java + test/tools/javac/lambda/BadRecovery.out + test/tools/javac/lambda/BadReturn.java + test/tools/javac/lambda/BadReturn.out + test/tools/javac/lambda/BadStatementInLambda.java + test/tools/javac/lambda/BadStatementInLambda.out + test/tools/javac/lambda/BadStatementInLambda02.java + test/tools/javac/lambda/BadStatementInLambda02.out + test/tools/javac/lambda/BadTargetType.java + test/tools/javac/lambda/BadTargetType.out + test/tools/javac/lambda/Conditional01.java + test/tools/javac/lambda/Conditional02.java + test/tools/javac/lambda/Conditional03.java + test/tools/javac/lambda/Conformance01.java + test/tools/javac/lambda/Defender01.java + test/tools/javac/lambda/DisjunctiveTypeTest.java + test/tools/javac/lambda/EffectivelyFinal01.java + test/tools/javac/lambda/EffectivelyFinal01.out ! test/tools/javac/lambda/EffectivelyFinalTest.java ! test/tools/javac/lambda/EffectivelyFinalTest01.out ! test/tools/javac/lambda/EffectivelyFinalTest02.out + test/tools/javac/lambda/ErroneousArg.java + test/tools/javac/lambda/ErroneousArg.out + test/tools/javac/lambda/ErroneousLambdaExpr.java ! test/tools/javac/lambda/InnerConstructor.java + test/tools/javac/lambda/LambdaCapture01.java + test/tools/javac/lambda/LambdaCapture02.java + test/tools/javac/lambda/LambdaCapture03.java + test/tools/javac/lambda/LambdaCapture04.java + test/tools/javac/lambda/LambdaCapture05.java + test/tools/javac/lambda/LambdaCapture06.java + test/tools/javac/lambda/LambdaConv01.java + test/tools/javac/lambda/LambdaConv03.java + test/tools/javac/lambda/LambdaConv05.java + test/tools/javac/lambda/LambdaConv06.java + test/tools/javac/lambda/LambdaConv08.java + test/tools/javac/lambda/LambdaConv09.java + test/tools/javac/lambda/LambdaConv09.out + test/tools/javac/lambda/LambdaConv10.java + test/tools/javac/lambda/LambdaConv10.out + test/tools/javac/lambda/LambdaConv11.java + test/tools/javac/lambda/LambdaConv12.java + test/tools/javac/lambda/LambdaConv13.java + test/tools/javac/lambda/LambdaConv16.java + test/tools/javac/lambda/LambdaConv17.java + test/tools/javac/lambda/LambdaConv18.java + test/tools/javac/lambda/LambdaConv18.out + test/tools/javac/lambda/LambdaConv19.java + test/tools/javac/lambda/LambdaConv20.java + test/tools/javac/lambda/LambdaConv21.java + test/tools/javac/lambda/LambdaConv21.out + test/tools/javac/lambda/LambdaConv22.java + test/tools/javac/lambda/LambdaConv23.java + test/tools/javac/lambda/LambdaConv24.java + test/tools/javac/lambda/LambdaConversionTest.java + test/tools/javac/lambda/LambdaEffectivelyFinalTest.java + test/tools/javac/lambda/LambdaEffectivelyFinalTest.out + test/tools/javac/lambda/LambdaExpr01.java + test/tools/javac/lambda/LambdaExpr02.java + test/tools/javac/lambda/LambdaExpr04.java + test/tools/javac/lambda/LambdaExpr05.java + test/tools/javac/lambda/LambdaExpr06.java + test/tools/javac/lambda/LambdaExpr07.java + test/tools/javac/lambda/LambdaExpr08.java + test/tools/javac/lambda/LambdaExpr09.java + test/tools/javac/lambda/LambdaExpr10.java + test/tools/javac/lambda/LambdaExpr10.out + test/tools/javac/lambda/LambdaExpr11.java + test/tools/javac/lambda/LambdaExpr12.java + test/tools/javac/lambda/LambdaExpr13.java + test/tools/javac/lambda/LambdaExpr14.java + test/tools/javac/lambda/LambdaExpr15.java + test/tools/javac/lambda/LambdaExpr16.java + test/tools/javac/lambda/LambdaExpr17.java + test/tools/javac/lambda/LambdaExpr18.java + test/tools/javac/lambda/LambdaExpr19.java + test/tools/javac/lambda/LambdaExpr19.out + test/tools/javac/lambda/LambdaExpr20.java + test/tools/javac/lambda/LambdaExprNotVoid.java + test/tools/javac/lambda/LambdaExprNotVoid.out ! test/tools/javac/lambda/LambdaParserTest.java + test/tools/javac/lambda/LambdaScope01.java + test/tools/javac/lambda/LambdaScope02.java + test/tools/javac/lambda/LambdaScope03.java + test/tools/javac/lambda/LambdaScope04.java + test/tools/javac/lambda/LambdaScope04.out + test/tools/javac/lambda/LocalBreakAndContinue.java + test/tools/javac/lambda/MethodReference01.java + test/tools/javac/lambda/MethodReference02.java + test/tools/javac/lambda/MethodReference03.java + test/tools/javac/lambda/MethodReference04.java + test/tools/javac/lambda/MethodReference04.out + test/tools/javac/lambda/MethodReference05.java + test/tools/javac/lambda/MethodReference06.java + test/tools/javac/lambda/MethodReference07.java + test/tools/javac/lambda/MethodReference08.java + test/tools/javac/lambda/MethodReference08.out + test/tools/javac/lambda/MethodReference09.java + test/tools/javac/lambda/MethodReference09.out + test/tools/javac/lambda/MethodReference10.java + test/tools/javac/lambda/MethodReference11.java + test/tools/javac/lambda/MethodReference12.java + test/tools/javac/lambda/MethodReference13.java + test/tools/javac/lambda/MethodReference14.java + test/tools/javac/lambda/MethodReference15.java + test/tools/javac/lambda/MethodReference16.java + test/tools/javac/lambda/MethodReference17.java + test/tools/javac/lambda/MethodReference18.java + test/tools/javac/lambda/MethodReference19.java + test/tools/javac/lambda/MethodReference20.java + test/tools/javac/lambda/MethodReference20.out + test/tools/javac/lambda/MethodReference21.java + test/tools/javac/lambda/MethodReference21.out + test/tools/javac/lambda/MethodReference22.java + test/tools/javac/lambda/MethodReference22.out + test/tools/javac/lambda/MethodReference23.java + test/tools/javac/lambda/MethodReference23.out + test/tools/javac/lambda/MethodReference24.java + test/tools/javac/lambda/MethodReference25.java + test/tools/javac/lambda/MethodReference26.java + test/tools/javac/lambda/MethodReference26.out + test/tools/javac/lambda/MethodReference27.java + test/tools/javac/lambda/MethodReference28.java + test/tools/javac/lambda/MethodReference28.out + test/tools/javac/lambda/MethodReference29.java + test/tools/javac/lambda/MethodReference30.java + test/tools/javac/lambda/MethodReference31.java + test/tools/javac/lambda/MethodReference32.java + test/tools/javac/lambda/MethodReference32.out + test/tools/javac/lambda/MethodReference33.java + test/tools/javac/lambda/MethodReference34.java + test/tools/javac/lambda/MethodReference35.java + test/tools/javac/lambda/MethodReference36.java + test/tools/javac/lambda/MethodReference37.java + test/tools/javac/lambda/MethodReference37.out + test/tools/javac/lambda/MethodReference38.java + test/tools/javac/lambda/MethodReference38.out + test/tools/javac/lambda/MethodReference39.java + test/tools/javac/lambda/MethodReference39.out + test/tools/javac/lambda/MethodReference40.java + test/tools/javac/lambda/MethodReference40.out + test/tools/javac/lambda/MethodReference41.java + test/tools/javac/lambda/MethodReference42.java + test/tools/javac/lambda/MethodReference43.java + test/tools/javac/lambda/MethodReference44.java + test/tools/javac/lambda/MethodReference45.java + test/tools/javac/lambda/MethodReference45.out + test/tools/javac/lambda/MethodReference46.java + test/tools/javac/lambda/MethodReference47.java + test/tools/javac/lambda/MethodReference47.out + test/tools/javac/lambda/MethodReference48.java + test/tools/javac/lambda/MethodReference49.java + test/tools/javac/lambda/MethodReference50.java + test/tools/javac/lambda/MethodReference50.out + test/tools/javac/lambda/MethodReference51.java + test/tools/javac/lambda/MethodReference51.out + test/tools/javac/lambda/MethodReference52.java + test/tools/javac/lambda/MethodReference52.out + test/tools/javac/lambda/MethodReference53.java + test/tools/javac/lambda/MethodReference53.out + test/tools/javac/lambda/MethodReference54.java + test/tools/javac/lambda/MethodReference54.out ! test/tools/javac/lambda/MethodReferenceParserTest.java + test/tools/javac/lambda/MostSpecific01.java + test/tools/javac/lambda/MostSpecific01.out + test/tools/javac/lambda/MostSpecific02.java + test/tools/javac/lambda/MostSpecific02.out + test/tools/javac/lambda/MostSpecific03.java + test/tools/javac/lambda/MostSpecific03.out + test/tools/javac/lambda/MostSpecific04.java + test/tools/javac/lambda/MostSpecific05.java + test/tools/javac/lambda/MostSpecific06.java + test/tools/javac/lambda/MostSpecific06.out + test/tools/javac/lambda/MostSpecific07.java + test/tools/javac/lambda/MostSpecific07.out + test/tools/javac/lambda/NakedThis.java + test/tools/javac/lambda/SourceLevelTest.java + test/tools/javac/lambda/SourceLevelTest.out + test/tools/javac/lambda/TargetType01.java + test/tools/javac/lambda/TargetType02.java + test/tools/javac/lambda/TargetType03.java + test/tools/javac/lambda/TargetType04.java + test/tools/javac/lambda/TargetType04.out + test/tools/javac/lambda/TargetType05.java + test/tools/javac/lambda/TargetType06.java + test/tools/javac/lambda/TargetType06.out + test/tools/javac/lambda/TargetType07.java + test/tools/javac/lambda/TargetType08.java + test/tools/javac/lambda/TargetType10.java + test/tools/javac/lambda/TargetType10.out + test/tools/javac/lambda/TargetType11.java + test/tools/javac/lambda/TargetType11.out + test/tools/javac/lambda/TargetType12.java + test/tools/javac/lambda/TargetType13.java + test/tools/javac/lambda/TargetType13.out + test/tools/javac/lambda/TargetType14.java + test/tools/javac/lambda/TargetType14.out + test/tools/javac/lambda/TargetType15.java + test/tools/javac/lambda/TargetType16.java + test/tools/javac/lambda/TargetType16.out + test/tools/javac/lambda/TargetType17.java + test/tools/javac/lambda/TargetType17.out + test/tools/javac/lambda/TargetType18.java + test/tools/javac/lambda/TargetType19.java + test/tools/javac/lambda/TargetType19.out + test/tools/javac/lambda/TargetType20.java + test/tools/javac/lambda/TargetType20.out + test/tools/javac/lambda/TargetType21.java + test/tools/javac/lambda/TargetType21.out + test/tools/javac/lambda/TargetType22.java + test/tools/javac/lambda/TargetType22.out + test/tools/javac/lambda/TargetType23.java + test/tools/javac/lambda/TargetType23.out + test/tools/javac/lambda/TargetType24.java + test/tools/javac/lambda/TargetType24.out + test/tools/javac/lambda/TargetType25.java + test/tools/javac/lambda/TargetType26.java + test/tools/javac/lambda/TargetType26.out + test/tools/javac/lambda/TargetType27.java + test/tools/javac/lambda/TargetType27.out + test/tools/javac/lambda/TargetType28.java + test/tools/javac/lambda/TargetType28.out + test/tools/javac/lambda/TargetType29.java + test/tools/javac/lambda/TargetType30.java + test/tools/javac/lambda/TargetType31.java + test/tools/javac/lambda/TargetType32.java + test/tools/javac/lambda/TargetType33.java + test/tools/javac/lambda/TargetType33.out + test/tools/javac/lambda/TargetType34.java + test/tools/javac/lambda/TargetType35.java + test/tools/javac/lambda/TargetType36.java + test/tools/javac/lambda/TargetType37.java + test/tools/javac/lambda/TargetType38.java + test/tools/javac/lambda/TargetType38.out + test/tools/javac/lambda/TargetType39.java + test/tools/javac/lambda/TargetType39.out + test/tools/javac/lambda/TargetType40.java + test/tools/javac/lambda/TargetType40.out + test/tools/javac/lambda/TargetType41.java + test/tools/javac/lambda/TargetType41.out + test/tools/javac/lambda/TargetType42.java + test/tools/javac/lambda/TargetType43.java + test/tools/javac/lambda/TargetType43.out + test/tools/javac/lambda/TargetType44.java + test/tools/javac/lambda/TargetType44.out + test/tools/javac/lambda/TargetType45.java + test/tools/javac/lambda/TargetType45.out + test/tools/javac/lambda/TargetType46.java + test/tools/javac/lambda/TargetType46.out + test/tools/javac/lambda/TargetType47.java + test/tools/javac/lambda/TargetType48.java + test/tools/javac/lambda/TargetType49.java + test/tools/javac/lambda/TargetType49.out + test/tools/javac/lambda/TargetType50.java + test/tools/javac/lambda/TargetType50.out ! test/tools/javac/lambda/TestInvokeDynamic.java + test/tools/javac/lambda/TestSelfRef.java + test/tools/javac/lambda/VoidCompatibility.java + test/tools/javac/lambda/VoidCompatibility.out + test/tools/javac/lambda/abort/Abort.java + test/tools/javac/lambda/badMemberRefBytecode/Main.java + test/tools/javac/lambda/badMemberRefBytecode/TestBadMemberRefBytecode.java + test/tools/javac/lambda/badMemberRefBytecode/Use.java + test/tools/javac/lambda/funcInterfaces/Helper.java + test/tools/javac/lambda/funcInterfaces/LambdaTest1.java + test/tools/javac/lambda/funcInterfaces/LambdaTest1_neg1.java + test/tools/javac/lambda/funcInterfaces/LambdaTest1_neg1.out + test/tools/javac/lambda/funcInterfaces/LambdaTest1_neg2.java + test/tools/javac/lambda/funcInterfaces/LambdaTest1_neg2.out + test/tools/javac/lambda/funcInterfaces/LambdaTest1_neg3.java + test/tools/javac/lambda/funcInterfaces/LambdaTest1_neg3.out + test/tools/javac/lambda/funcInterfaces/LambdaTest2_SAM1.java + test/tools/javac/lambda/funcInterfaces/LambdaTest2_SAM2.java + test/tools/javac/lambda/funcInterfaces/LambdaTest2_SAM3.java + test/tools/javac/lambda/funcInterfaces/LambdaTest2_neg1.java + test/tools/javac/lambda/funcInterfaces/LambdaTest2_neg1.out + test/tools/javac/lambda/funcInterfaces/NonSAM1.java + test/tools/javac/lambda/funcInterfaces/NonSAM1.out + test/tools/javac/lambda/funcInterfaces/NonSAM2.java + test/tools/javac/lambda/funcInterfaces/NonSAM2.out + test/tools/javac/lambda/funcInterfaces/NonSAM3.java + test/tools/javac/lambda/funcInterfaces/NonSAM3.out + test/tools/javac/lambda/lambdaExpression/AbstractClass_neg.java + test/tools/javac/lambda/lambdaExpression/AbstractClass_neg.out + test/tools/javac/lambda/lambdaExpression/AccessNonStatic_neg.java + test/tools/javac/lambda/lambdaExpression/AccessNonStatic_neg.out + test/tools/javac/lambda/lambdaExpression/EffectivelyFinal_neg.java + test/tools/javac/lambda/lambdaExpression/EffectivelyFinal_neg.out + test/tools/javac/lambda/lambdaExpression/InvalidExpression1.java + test/tools/javac/lambda/lambdaExpression/InvalidExpression1.out + test/tools/javac/lambda/lambdaExpression/InvalidExpression3.java + test/tools/javac/lambda/lambdaExpression/InvalidExpression3.out + test/tools/javac/lambda/lambdaExpression/InvalidExpression4.java + test/tools/javac/lambda/lambdaExpression/InvalidExpression4.out + test/tools/javac/lambda/lambdaExpression/InvalidExpression5.java + test/tools/javac/lambda/lambdaExpression/InvalidExpression5.out + test/tools/javac/lambda/lambdaExpression/InvalidExpression6.java + test/tools/javac/lambda/lambdaExpression/InvalidExpression6.out + test/tools/javac/lambda/lambdaExpression/LambdaTest1.java + test/tools/javac/lambda/lambdaExpression/LambdaTest2.java + test/tools/javac/lambda/lambdaExpression/LambdaTest3.java + test/tools/javac/lambda/lambdaExpression/LambdaTest4.java + test/tools/javac/lambda/lambdaExpression/LambdaTest5.java + test/tools/javac/lambda/lambdaExpression/LambdaTest6.java + test/tools/javac/lambda/lambdaExpression/SamConversion.java + test/tools/javac/lambda/lambdaExpression/SamConversionComboTest.java + test/tools/javac/lambda/methodReference/BridgeMethod.java + test/tools/javac/lambda/methodReference/MethodRef1.java + test/tools/javac/lambda/methodReference/MethodRef2.java + test/tools/javac/lambda/methodReference/MethodRef3.java + test/tools/javac/lambda/methodReference/MethodRef4.java + test/tools/javac/lambda/methodReference/MethodRef5.java + test/tools/javac/lambda/methodReference/MethodRef6.java + test/tools/javac/lambda/methodReference/MethodRef7.java + test/tools/javac/lambda/methodReference/MethodRef_neg.java + test/tools/javac/lambda/methodReference/MethodRef_neg.out + test/tools/javac/lambda/methodReference/SamConversion.java + test/tools/javac/lambda/methodReference/SamConversionComboTest.java + test/tools/javac/lambda/mostSpecific/StructuralMostSpecificTest.java + test/tools/javac/lambda/speculative/A.java + test/tools/javac/lambda/speculative/DiamondFinder.java + test/tools/javac/lambda/speculative/Main.java + test/tools/javac/lambda/speculative/Main.out + test/tools/javac/lambda/typeInference/InferenceTest11.java + test/tools/javac/lambda/typeInference/InferenceTest2.java + test/tools/javac/lambda/typeInference/InferenceTest2b.java + test/tools/javac/lambda/typeInference/InferenceTest3.java + test/tools/javac/lambda/typeInference/InferenceTest4.java + test/tools/javac/lambda/typeInference/InferenceTest5.java + test/tools/javac/lambda/typeInference/InferenceTest789.java + test/tools/javac/lambda/typeInference/InferenceTest_neg1_2.java + test/tools/javac/lambda/typeInference/InferenceTest_neg1_2.out + test/tools/javac/lambda/typeInference/InferenceTest_neg5.java + test/tools/javac/lambda/typeInference/InferenceTest_neg5.out + test/tools/javac/lambda/typeInference/combo/TypeInferenceComboTest.java ! test/tools/javac/typeAnnotations/newlocations/BasicTest.out Changeset: c0f0c41cafa0 Author: jjg Date: 2012-11-19 11:38 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/c0f0c41cafa0 8001098: Provide a simple light-weight "plug-in" mechanism for javac Reviewed-by: mcimadamore + src/share/classes/com/sun/source/util/Plugin.java ! src/share/classes/com/sun/source/util/Trees.java ! src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/plugin/showtype/Identifiers.java + test/tools/javac/plugin/showtype/Identifiers.out + test/tools/javac/plugin/showtype/Identifiers_PI.out + test/tools/javac/plugin/showtype/ShowTypePlugin.java + test/tools/javac/plugin/showtype/Test.java Changeset: 522a1ee72340 Author: bpatel Date: 2012-11-19 16:10 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/522a1ee72340 8002304: Group methods by types in methods summary section Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlStyle.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/MemberSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/activetitlebar.gif + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/activetitlebar_end.gif + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/script.js ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPaths.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MethodTypes.java ! test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java + test/com/sun/javadoc/testMethodTypes/TestMethodTypes.java + test/com/sun/javadoc/testMethodTypes/pkg1/A.java + test/com/sun/javadoc/testMethodTypes/pkg1/B.java + test/com/sun/javadoc/testMethodTypes/pkg1/D.java ! test/tools/javadoc/api/basic/APITest.java Changeset: 2531de382983 Author: jjg Date: 2012-11-19 16:40 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/2531de382983 8003655: Add javac.jvm.ClassFile.V52 Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java Changeset: a25c53e12bd0 Author: jjg Date: 2012-11-20 07:21 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/a25c53e12bd0 8003649: regression/langtools: tools/javac/doctree Reviewed-by: ksrini ! test/tools/javac/doctree/DocCommentTester.java Changeset: fb97eaf93d61 Author: jjg Date: 2012-11-20 07:25 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/fb97eaf93d61 8003650: java.lang.Exception: expected string not found: pkg/package-frame.html Reviewed-by: ksrini ! test/tools/javadoc/api/basic/GetTask_WriterTest.java ! test/tools/javadoc/api/basic/RunTest.java Changeset: 7538e419a588 Author: mcimadamore Date: 2012-11-20 15:43 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/7538e419a588 8003663: lambda test fails on Windows Summary: fix path separator issue in test Reviewed-by: jjg ! test/tools/javac/lambda/abort/Abort.java Changeset: d898d9ee352f Author: rfield Date: 2012-11-20 09:58 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/d898d9ee352f 8003639: convert lambda testng tests to jtreg and add them Reviewed-by: mcimadamore + test/tools/javac/defaultMethodExecution/DefaultMethodRegressionTests.java - test/tools/javac/defaultMethods/fd/FDTest.java - test/tools/javac/defaultMethods/fd/shapegen/ClassCase.java - test/tools/javac/defaultMethods/fd/shapegen/Hierarchy.java - test/tools/javac/defaultMethods/fd/shapegen/HierarchyGenerator.java - test/tools/javac/defaultMethods/fd/shapegen/Rule.java - test/tools/javac/defaultMethods/fd/shapegen/RuleGroup.java - test/tools/javac/defaultMethods/fd/shapegen/TTNode.java - test/tools/javac/defaultMethods/fd/shapegen/TTParser.java - test/tools/javac/defaultMethods/fd/shapegen/TTShape.java + test/tools/javac/lambda/lambdaExecution/InInterface.java + test/tools/javac/lambda/lambdaExecution/InnerConstructor.java + test/tools/javac/lambda/lambdaExecution/LambdaTranslationTest1.java + test/tools/javac/lambda/lambdaExecution/LambdaTranslationTest2.java + test/tools/javac/lambda/lambdaExecution/TBlock.java + test/tools/javac/lambda/lambdaExecution/TMapper.java + test/tools/javac/lambda/lambdaExecution/TPredicate.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestFDCCE.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestInnerDefault.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestInnerInstance.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestInnerVarArgsThis.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestInstance.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestKinds.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestNew.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestNewInner.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase1.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase2.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase4.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSuper.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSuperDefault.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestTypeConversion.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgs.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgsExt.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgsSuper.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgsSuperDefault.java + test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestVarArgsThis.java + test/tools/javac/lambdaShapes/TEST.properties + test/tools/javac/lambdaShapes/org/openjdk/tests/javac/FDTest.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/AttributeInjector.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassFile.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassFilePreprocessor.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassToInterfaceConverter.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/Compiler.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/DirectedClassLoader.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/SourceModel.java + test/tools/javac/lambdaShapes/org/openjdk/tests/separate/TestHarness.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/ClassCase.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/Hierarchy.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/HierarchyGenerator.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/Rule.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/RuleGroup.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/TTNode.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/TTParser.java + test/tools/javac/lambdaShapes/org/openjdk/tests/shapegen/TTShape.java + test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java + test/tools/javac/lambdaShapes/org/openjdk/tests/vm/FDSeparateCompilationTest.java Changeset: 09ba1bfab344 Author: lana Date: 2012-11-20 11:50 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/09ba1bfab344 Merge - src/share/classes/com/sun/tools/javac/parser/SimpleDocCommentTable.java - test/tools/javac/defaultMethods/fd/FDTest.java - test/tools/javac/defaultMethods/fd/shapegen/ClassCase.java - test/tools/javac/defaultMethods/fd/shapegen/Hierarchy.java - test/tools/javac/defaultMethods/fd/shapegen/HierarchyGenerator.java - test/tools/javac/defaultMethods/fd/shapegen/Rule.java - test/tools/javac/defaultMethods/fd/shapegen/RuleGroup.java - test/tools/javac/defaultMethods/fd/shapegen/TTNode.java - test/tools/javac/defaultMethods/fd/shapegen/TTParser.java - test/tools/javac/defaultMethods/fd/shapegen/TTShape.java - test/tools/javac/diags/examples/CantAccessArgTypeInFunctionalDesc.java - test/tools/javac/diags/examples/CantAccessReturnTypeInFunctionalDesc.java - test/tools/javac/diags/examples/CantAccessThrownTypesInFunctionalDesc.java - test/tools/javac/diags/examples/CantReturnValueForVoid.java Changeset: da48ab364ea4 Author: erikj Date: 2012-11-28 13:37 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/da48ab364ea4 8003844: build-infra: docs target isn't working properly Summary: Adding resources to bootstrap javadoc.jar. Adding missing .js resource suffix Reviewed-by: ohair, jjg, ohrstrom ! makefiles/BuildLangtools.gmk Changeset: 20230f8b0eef Author: katleman Date: 2012-11-28 14:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/20230f8b0eef Merge Changeset: 303b09787a69 Author: katleman Date: 2012-11-29 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/303b09787a69 Added tag jdk8-b66 for changeset 20230f8b0eef ! .hgtags From lana.steuck at oracle.com Sat Dec 1 00:45:28 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 01 Dec 2012 00:45:28 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 43 new changesets Message-ID: <20121201005405.6294147C59@hg.openjdk.java.net> Changeset: 3717bcf9d7a7 Author: dholmes Date: 2012-11-07 23:12 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3717bcf9d7a7 8002040: Allow Full Debug Symbols when cross-compiling Reviewed-by: dcubed, erikj, tbell ! make/common/Defs-linux.gmk Changeset: 1e79fec4a01f Author: ohrstrom Date: 2012-11-08 12:25 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1e79fec4a01f 8003161: small fixes to re-enable new build system Reviewed-by: dholmes, alanb, erikj ! makefiles/CompileNativeLibraries.gmk ! makefiles/CreateJars.gmk Changeset: 170e8ccfbc4f Author: tbell Date: 2012-11-12 10:20 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/170e8ccfbc4f 8002365: build-infra: Build-infra fails on solaris 11.1 on sparc. Summary: Add '-lc' to LDFLAGS for native libraries in CompileNativeLibraries.gmk Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! makefiles/CompileNativeLibraries.gmk Changeset: 2fc142843a93 Author: tbell Date: 2012-11-12 10:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2fc142843a93 8003177: build-infra: Compare reports diff in LocaleDataMetaInfo.class Summary: Remove spurious space in the locale lists Reviewed-by: naoto, ohair, tbell Contributed-by: erik.joelsson at oracle.com ! makefiles/GensrcLocaleDataMetaInfo.gmk Changeset: e9e8a5852690 Author: tbell Date: 2012-11-12 12:35 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e9e8a5852690 8002028: build-infra: need no-hotspot partial build Summary: Added configure option --with-import-hotspot=/path/to/j2sdkimage Reviewed-by: dholmes, tbell Contributed-by: erik.joelsson at oracle.com ! makefiles/Import.gmk Changeset: 84f0439ccaab Author: tbell Date: 2012-11-13 13:46 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/84f0439ccaab 8001965: build-infra: Large compare diffs between new and old on mac Summary: The wrong icon source file was used when building closed Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! makefiles/GensrcIcons.gmk Changeset: 130d3a54d28b Author: katleman Date: 2012-11-14 12:29 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/130d3a54d28b Merge Changeset: c87df8b1f55e Author: katleman Date: 2012-11-15 15:40 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c87df8b1f55e Added tag jdk8-b65 for changeset 130d3a54d28b ! .hgtags Changeset: ed977ca9a969 Author: lana Date: 2012-11-20 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ed977ca9a969 Merge Changeset: 11ba8795bbe9 Author: kshefov Date: 2012-11-14 11:37 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/11ba8795bbe9 7147408: [macosx] Add autodelay to fix a regression test Reviewed-by: serb, alexsch + test/javax/swing/text/StyledEditorKit/4506788/bug4506788.html + test/javax/swing/text/StyledEditorKit/4506788/bug4506788.java Changeset: f32a0aee7bb9 Author: alitvinov Date: 2012-11-14 18:40 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f32a0aee7bb9 6789984: JPasswordField can not receive keyboard input Reviewed-by: naoto, anthony ! src/share/classes/sun/awt/im/InputContext.java ! src/share/classes/sun/awt/im/InputMethodAdapter.java ! src/solaris/classes/sun/awt/X11InputMethod.java Changeset: 0269459afe2a Author: malenkov Date: 2012-11-20 18:56 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0269459afe2a 8003333: Regression: java/beans/EventHandler/Test6277266.java fails with ACE Reviewed-by: art ! test/java/beans/EventHandler/Test6277266.java Changeset: ea368459cca5 Author: lana Date: 2012-11-20 11:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ea368459cca5 Merge Changeset: c3e7ceb22d37 Author: alanb Date: 2012-11-11 10:05 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c3e7ceb22d37 8003253: TEST_BUG: java/nio/channels/AsynchronousChannelGroup/Unbounded.java hang intermittently [win] Reviewed-by: chegar ! test/java/nio/channels/AsynchronousChannelGroup/Unbounded.java Changeset: 5d3f8f9e6c58 Author: okutsu Date: 2012-11-12 11:12 +0900 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5d3f8f9e6c58 8000986: Split java.util.spi.CalendarDataProvider into week parameters and field names portions Reviewed-by: naoto ! make/java/java/FILES_java.gmk ! src/macosx/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/spi/CalendarDataProvider.java + src/share/classes/java/util/spi/CalendarNameProvider.java ! src/share/classes/sun/util/locale/provider/AuxLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/CalendarDataProviderImpl.java ! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java + src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/SPILocaleProviderAdapter.java ! src/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! test/java/util/PluggableLocale/CalendarDataProviderTest.java ! test/java/util/PluggableLocale/CalendarDataProviderTest.sh + test/java/util/PluggableLocale/CalendarNameProviderTest.java + test/java/util/PluggableLocale/CalendarNameProviderTest.sh ! test/java/util/PluggableLocale/GenericTest.java ! test/java/util/PluggableLocale/barprovider.jar ! test/java/util/PluggableLocale/fooprovider.jar ! test/java/util/PluggableLocale/providersrc/CalendarDataProviderImpl.java + test/java/util/PluggableLocale/providersrc/CalendarNameProviderImpl.java ! test/java/util/PluggableLocale/providersrc/Makefile + test/java/util/PluggableLocale/providersrc/java.util.spi.CalendarNameProvider Changeset: be1fb42ef696 Author: mduigou Date: 2012-11-13 20:02 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/be1fb42ef696 7088913: Add compatible static hashCode(primitive) to primitive wrapper classes Summary: Adds static utility methods to each primitive wrapper class to allow calculation of a hashCode value from an unboxed primitive. Reviewed-by: darcy, smarks, dholmes ! src/share/classes/java/lang/Boolean.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java ! test/java/lang/HashCode.java Changeset: 83765e82cacb Author: zhouyx Date: 2012-11-14 13:26 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/83765e82cacb 7201156: jar tool fails to convert file separation characters for list and extract Reviewed-by: alanb, chegar, sherman ! src/share/classes/sun/tools/jar/Main.java + test/tools/jar/JarBackSlash.java Changeset: 0f54a98f9bc9 Author: alanb Date: 2012-11-14 12:56 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0f54a98f9bc9 8003285: TEST_BUG: java/nio/channels/AsynchronousChannelGroup/Unbounded.java fails again [macosx] Reviewed-by: chegar ! test/java/nio/channels/AsynchronousChannelGroup/Unbounded.java Changeset: 369709a13823 Author: jjg Date: 2012-11-14 07:08 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/369709a13823 8000404: rename javax.tools.GenerateNativeHeader to java.lang.annotation.Native Reviewed-by: alanb + src/share/classes/java/lang/annotation/Native.java Changeset: e24123de581c Author: mduigou Date: 2012-11-13 20:02 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e24123de581c 7088952: Add size in bytes constant "BYTES" to primitive type wrapper types Summary: Adds a constant BYTES to each of the primitive wrapper classes (Byte, Character, Double, Float, Integer, Long, Short) with the calculation Primitive.SIZE / Byte.SIZE already made. Reviewed-by: dholmes ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java Changeset: f4de6a38f794 Author: lana Date: 2012-11-14 16:41 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f4de6a38f794 Merge Changeset: ac22a52a732c Author: jgish Date: 2012-11-15 13:46 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ac22a52a732c 6244047: impossible to specify directories to logging FileHandler unless they exist Reviewed-by: alanb ! src/share/classes/java/util/logging/FileHandler.java + test/java/util/logging/CheckLockLocationTest.java Changeset: 51c695958712 Author: weijun Date: 2012-11-16 10:34 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/51c695958712 8003263: redundant cast build failure after 8003120 Reviewed-by: alanb ! src/share/classes/com/sun/naming/internal/ResourceManager.java Changeset: 64a42798ea5e Author: naoto Date: 2012-11-15 20:17 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/64a42798ea5e 7199750: Loading sequence of service provider is changed Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/SPILocaleProviderAdapter.java ! test/java/util/PluggableLocale/CurrencyNameProviderTest.sh ! test/java/util/PluggableLocale/barprovider.jar ! test/java/util/PluggableLocale/providersrc/CurrencyNameProviderImpl2.java Changeset: 0ee09f17361e Author: khazra Date: 2012-11-16 12:28 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0ee09f17361e 8003518: (prefs) Tests in jdk/test/java/util/prefs should not be run concurrently Summary: Add java/util/prefs to exclusiveAccess.dirs in TEST.ROOT Reviewed-by: alanb, mchung ! test/TEST.ROOT Changeset: 6f20caa6e1e9 Author: bchristi Date: 2012-11-16 17:01 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6f20caa6e1e9 7178922: (props) re-visit how os.name is determined on Mac Reviewed-by: alanb, mchung, skovatch, serb ! src/solaris/native/java/lang/java_props_macosx.c Changeset: 25e5df117021 Author: xuelei Date: 2012-11-18 01:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/25e5df117021 8003587: Warning cleanup in package javax.net.ssl Summary: Removes unnecessary imports and adds missing Override annotations Reviewed-by: xuelei Contributed-by: Florian Weimer ! src/share/classes/javax/net/ssl/HandshakeCompletedEvent.java ! src/share/classes/javax/net/ssl/HostnameVerifier.java ! src/share/classes/javax/net/ssl/HttpsURLConnection.java ! src/share/classes/javax/net/ssl/KeyManagerFactory.java ! src/share/classes/javax/net/ssl/SSLContext.java ! src/share/classes/javax/net/ssl/SSLContextSpi.java ! src/share/classes/javax/net/ssl/SSLEngineResult.java ! src/share/classes/javax/net/ssl/SSLParameters.java ! src/share/classes/javax/net/ssl/SSLPermission.java ! src/share/classes/javax/net/ssl/SSLServerSocketFactory.java ! src/share/classes/javax/net/ssl/SSLSession.java ! src/share/classes/javax/net/ssl/SSLSocket.java ! src/share/classes/javax/net/ssl/SSLSocketFactory.java ! src/share/classes/javax/net/ssl/TrustManagerFactory.java ! src/share/classes/javax/net/ssl/X509KeyManager.java Changeset: f740a9ac6eb6 Author: weijun Date: 2012-11-19 11:13 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f740a9ac6eb6 8002344: Krb5LoginModule config class does not return proper KDC list from DNS Reviewed-by: weijun Contributed-by: Severin Gehwolf , Wang Weijun ! src/share/classes/sun/security/krb5/Config.java + test/sun/security/krb5/config/DNS.java + test/sun/security/krb5/config/NamingManager.java + test/sun/security/krb5/config/dns.sh Changeset: 3877706701b1 Author: alanb Date: 2012-11-19 13:17 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3877706701b1 8003607: More ProblemList.txt updates (11/2012) Reviewed-by: lancea ! test/ProblemList.txt ! test/TEST.ROOT Changeset: 2d08b404cd91 Author: jzavgren Date: 2012-11-20 09:26 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2d08b404cd91 8000476: Memory Leaks and uninitialized memory access in PKCS11 and other native code Reviewed-by: dsamersoff, valeriep, chegar ! src/share/bin/wildcard.c ! src/share/native/sun/security/jgss/wrapper/GSSLibStub.c ! src/share/native/sun/security/pkcs11/wrapper/p11_mutex.c ! src/solaris/bin/java_md_solinux.c Changeset: 914cd9b482c8 Author: ksrini Date: 2012-11-19 19:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/914cd9b482c8 8001533: java launcher must launch javafx applications Reviewed-by: ksrini, mchung, kcr, alanb Contributed-by: david.dehaven at oracle.com ! src/share/bin/java.c ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/launcher/resources/launcher.properties ! test/tools/launcher/TestHelper.java Changeset: b1c364c84d09 Author: ksrini Date: 2012-11-19 19:50 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b1c364c84d09 8003660: (launcher) 8001533 regression tests Reviewed-by: ksrini, mchung, kcr, ddehaven Contributed-by: steve.sides at oracle.com + test/tools/launcher/FXLauncherTest.java Changeset: 107a7a52a3c0 Author: lana Date: 2012-11-20 11:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/107a7a52a3c0 Merge Changeset: ccff3b663797 Author: tbell Date: 2012-11-14 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ccff3b663797 8001906: build-infra: warning: [path] bad path element on Solaris Summary: Remove unnecesary -cp parameter from compile line Reviewed-by: ohair, tbell Contributed-by: erik.joelsson at oracle.com ! makefiles/CompileDemos.gmk Changeset: 716efc201640 Author: tbell Date: 2012-11-15 00:55 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/716efc201640 Merge Changeset: 44e845bb5f76 Author: erikj Date: 2012-11-28 09:47 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/44e845bb5f76 8003960: build-infra: Jarsigner launcher has wrong classname Summary: Fixed package name in launcher Reviewed-by: alanb, ohair, ohrstrom ! makefiles/CompileLaunchers.gmk Changeset: ad5741112252 Author: erikj Date: 2012-11-28 13:20 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ad5741112252 8001460: build-infra: Linker warnings on macosx Summary: Remove creation of empty i386 section from fdlibm Reviewed-by: ohair ! makefiles/CompileNativeLibraries.gmk Changeset: 7ecc80d2ff2e Author: erikj Date: 2012-11-28 13:29 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7ecc80d2ff2e 8003477: build-infra: Remove explicit source file listings for libs when possible Reviewed-by: ohair, ohrstrom ! makefiles/CompileNativeLibraries.gmk Changeset: 51d2fd6d9850 Author: erikj Date: 2012-11-28 13:49 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/51d2fd6d9850 8003528: build-infra: Diffs in libjava and hotspot libs on solaris. Summary: Reorder libraries on link command line to match old build. Reviewed-by: ohair, ohrstrom ! makefiles/CompileNativeLibraries.gmk Changeset: 54516ed0f99f Author: erikj Date: 2012-11-28 14:10 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/54516ed0f99f 8003482: build-infra: Use correct manifest in security jars Reviewed-by: ohair, ohrstrom ! makefiles/CreateJars.gmk Changeset: 4d337fae2250 Author: katleman Date: 2012-11-28 14:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4d337fae2250 Merge Changeset: df5619994dc3 Author: katleman Date: 2012-11-29 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/df5619994dc3 Added tag jdk8-b66 for changeset 4d337fae2250 ! .hgtags Changeset: bd3b3cda125d Author: lana Date: 2012-11-30 16:02 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bd3b3cda125d Merge From james.graham at oracle.com Sat Dec 1 01:40:57 2012 From: james.graham at oracle.com (Jim Graham) Date: Fri, 30 Nov 2012 17:40:57 -0800 Subject: [OpenJDK 2D-Dev] [8] request for review: 7124347: [macosx] "java.lang.InternalError: not implemented yet" on call Graphics2D.drawRend In-Reply-To: <50B87E71.3040106@oracle.com> References: <50B362A9.9080104@oracle.com> <50B6A728.2050800@oracle.com> <50B71A4A.4050800@oracle.com> <50B8025B.6070800@oracle.com> <50B87E71.3040106@oracle.com> Message-ID: <50B96029.9070402@oracle.com> I'm OK with the removal of the test, but I didn't look in more depth. Phil already approved from his end, though, so I think you can take this as a concurrence... ...jim On 11/30/12 1:37 AM, Andrew Brygin wrote: > Hi Jim, > > I have verified that we use either the imageComp field from SunGraphics2D > (which can not be null), or some explicit composite type in this method. > So, according to your suggestion, I have removed the check for null. > Please take a look to updated webrev: > > http://cr.openjdk.java.net/~bae/7124347/8/webrev.01/ > > Phil, could you please take a look the the updated fix also? > > Thanks, > Andrew > > > On 30.11.2012 4:48, Jim Graham wrote: >> Hi Andrew, >> >> My belief is that comp should never be null. A simple grep should >> confirm that belief. While I do agree that it can be safer to check >> for null if you aren't sure about the code base, once one piece of >> code does it then it spreads and weakens the API contract so it would >> be better to check and keep the API contract stronger if we can... >> >> ...jim >> >> On 11/29/12 12:18 AM, Andrew Brygin wrote: >>> Hello Jim, >>> >>> I do not think that suggested change allows a null composite per se: >>> the check for null was introduced just to make sure that we can safely >>> call isDerivedFrom method. However, it does not change the method >>> behavior for the case of null composite. >>> >>> If it is impossible to get null composite here for some reason >>> (unfortunately >>> I can not say this for sure), then this check is not required. >>> However, I do not >>> think that the extra check for null may cause any harm. >>> >>> Thanks, >>> Andrew >>> >>> >>> On 29.11.2012 4:07, Jim Graham wrote: >>>> Is there a reason for allowing a null comp in the isSupported method? >>>> >>>> ...jim >>>> >>>> On 11/26/2012 4:38 AM, Andrew Brygin wrote: >>>>> Hello, >>>>> >>>>> could you please review a fix for 7124347? >>>>> >>>>> This fix does not implement getRater() in ogl surfaces. >>>>> Instead, it provides a blit for custom composite, which >>>>> prepares a snapshot of the destination surface (which >>>>> is one of ogl surfaces) and delegates the work to the >>>>> general blit, which now extracts raster from the snapshot. >>>>> A result of general blit's work is transferred to the >>>>> original destination. >>>>> >>>>> Changes in OGLSurfaceDataProcy are required in order to prevent >>>>> getting an accelerated copy of original source image as an >>>>> operand of the blit. Now we first check for composite type, >>>>> and only then (if composite is not specified, or is a kind >>>>> of alpha composite) we take into account other conditions. >>>>> >>>>> So this fix does not change anything for the case of alpha >>>>> composites >>>>> but affects only XOR and custom composites case. >>>>> >>>>> Note that the fix solves the problem only for the case of blits >>>>> (i.e. drawImage()). Other operations may result into the same >>>>> problem if custom composite is used. However, in case of XOR, >>>>> this change solves the problem completely, because other rendering >>>>> operations in the ogl pipeline are ready for XOR composite. >>>>> >>>>> Supplied regression test verifies that the fix makes the problem >>>>> gone. >>>>> I have verified both windows and macosx platforms. >>>>> >>>>> Please take a look and share your comments. >>>>> >>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124347 >>>>> Webrev: http://cr.openjdk.java.net/~bae/7124347/8/webrev.00/ >>>>> >>>>> Thanks, >>>>> Andrew >>> > From jviswana at linux.vnet.ibm.com Mon Dec 3 05:58:16 2012 From: jviswana at linux.vnet.ibm.com (jayashree viswanathan) Date: Mon, 03 Dec 2012 11:28:16 +0530 Subject: [OpenJDK 2D-Dev] Request for review: : [NEW BUG] Printer - tempfile having incorrect extension In-Reply-To: <5051E846.2020302@linux.vnet.ibm.com> References: <5051E846.2020302@linux.vnet.ibm.com> Message-ID: <50BC3F78.4040002@linux.vnet.ibm.com> On 13-09-2012 7:35 PM, jayashree viswanathan wrote: > Hi , > > Looking for a reviewer for a change request . > > Problem statement: > In UnixPrintJob class while constructing a lpr command to queue up > the jobs, we are creating tempfile with .ps extension . > The content of the tempfile will not have appropriate postscript > header[like PSPrinterJob], rather just the data to be printed . > In certain environments[ex., RHEL 6.1] this causes failure and even > the native command [lpr] as constructed by Java just queues up the job > but doesn't prints them. > > webrev for the change is available at > http://cr.openjdk.java.net/~shirishk/20120913_02/webrev.01/ > > Thanks and Regards, > Jayashree Viswanathan > Hi , If you raise a sun bug , can you please share the number ? Thanks and Regards, Jayashree Viswanathan From andrew.brygin at oracle.com Mon Dec 3 12:28:53 2012 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Mon, 03 Dec 2012 12:28:53 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 7124347: [macosx] java.lang.InternalError: not implemented yet on call Graphics2D.drawRenderedImage Message-ID: <20121203123002.DCEE047CD6@hg.openjdk.java.net> Changeset: 3c5bf5ed45a9 Author: bae Date: 2012-12-03 16:26 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3c5bf5ed45a9 7124347: [macosx] java.lang.InternalError: not implemented yet on call Graphics2D.drawRenderedImage Reviewed-by: prr, flar ! src/share/classes/sun/java2d/opengl/OGLBlitLoops.java ! src/share/classes/sun/java2d/opengl/OGLSurfaceDataProxy.java + test/sun/java2d/OpenGL/CustomCompositeTest.java From jviswana at linux.vnet.ibm.com Tue Dec 4 06:26:29 2012 From: jviswana at linux.vnet.ibm.com (jayashree viswanathan) Date: Tue, 04 Dec 2012 11:56:29 +0530 Subject: [OpenJDK 2D-Dev] Request for review: : [NEW BUG] Printer - tempfile having incorrect extension In-Reply-To: <50BC3F78.4040002@linux.vnet.ibm.com> References: <5051E846.2020302@linux.vnet.ibm.com> <50BC3F78.4040002@linux.vnet.ibm.com> Message-ID: <50BD9795.7080407@linux.vnet.ibm.com> On 03-12-2012 11:28 AM, jayashree viswanathan wrote: > On 13-09-2012 7:35 PM, jayashree viswanathan wrote: >> Hi , >> >> Looking for a reviewer for a change request . >> >> Problem statement: >> In UnixPrintJob class while constructing a lpr command to queue up >> the jobs, we are creating tempfile with .ps extension . >> The content of the tempfile will not have appropriate postscript >> header[like PSPrinterJob], rather just the data to be printed . >> In certain environments[ex., RHEL 6.1] this causes failure and even >> the native command [lpr] as constructed by Java just queues up the job >> but doesn't prints them. >> >> webrev for the change is available at >> http://cr.openjdk.java.net/~shirishk/20120913_02/webrev.01/ >> >> Thanks and Regards, >> Jayashree Viswanathan >> > Hi , > > If you raise a sun bug , can you please share the number ? > > Thanks and Regards, > Jayashree Viswanathan Thanks Jennifer for sharing the bug number . It is 8004316 . I see that it is yet to be available in sun bug database and might be available soon . If you are happy with the fix can you please push the change ? Thanks and Regards, Jayashree Viswanathan From jennifer.godinez at oracle.com Tue Dec 4 16:22:41 2012 From: jennifer.godinez at oracle.com (Jennifer Godinez) Date: Tue, 04 Dec 2012 08:22:41 -0800 Subject: [OpenJDK 2D-Dev] Request for review: : [NEW BUG] Printer - tempfile having incorrect extension In-Reply-To: <50BD9795.7080407@linux.vnet.ibm.com> References: <5051E846.2020302@linux.vnet.ibm.com> <50BC3F78.4040002@linux.vnet.ibm.com> <50BD9795.7080407@linux.vnet.ibm.com> Message-ID: <50BE2351.9040301@oracle.com> I approve the change but we need one more reviewer before pushing the change. Jennifer On 12/3/2012 10:26 PM, jayashree viswanathan wrote: > On 03-12-2012 11:28 AM, jayashree viswanathan wrote: >> On 13-09-2012 7:35 PM, jayashree viswanathan wrote: >>> Hi , >>> >>> Looking for a reviewer for a change request . >>> >>> Problem statement: >>> In UnixPrintJob class while constructing a lpr command to queue up >>> the jobs, we are creating tempfile with .ps extension . >>> The content of the tempfile will not have appropriate postscript >>> header[like PSPrinterJob], rather just the data to be printed . >>> In certain environments[ex., RHEL 6.1] this causes failure and even >>> the native command [lpr] as constructed by Java just queues up the job >>> but doesn't prints them. >>> >>> webrev for the change is available at >>> http://cr.openjdk.java.net/~shirishk/20120913_02/webrev.01/ >>> >>> Thanks and Regards, >>> Jayashree Viswanathan >>> >> Hi , >> >> If you raise a sun bug , can you please share the number ? >> >> Thanks and Regards, >> Jayashree Viswanathan > Thanks Jennifer for sharing the bug number . It is 8004316 . I see > that it is yet to be available in sun bug database and might be > available soon . > > If you are happy with the fix can you please push the change ? > > Thanks and Regards, > Jayashree Viswanathan > From luchsh at linux.vnet.ibm.com Tue Dec 11 09:14:17 2012 From: luchsh at linux.vnet.ibm.com (Jonathan Lu) Date: Tue, 11 Dec 2012 17:14:17 +0800 Subject: [OpenJDK 2D-Dev] Request for review: : [NEW BUG] Printer - tempfile having incorrect extension In-Reply-To: <50BE2351.9040301@oracle.com> References: <5051E846.2020302@linux.vnet.ibm.com> <50BC3F78.4040002@linux.vnet.ibm.com> <50BD9795.7080407@linux.vnet.ibm.com> <50BE2351.9040301@oracle.com> Message-ID: <50C6F969.20109@linux.vnet.ibm.com> Thanks a lot, Jannifer! Could anybody else please help to take a look? Best regards - Jonathan On 12/05/2012 12:22 AM, Jennifer Godinez wrote: > I approve the change but we need one more reviewer before pushing the > change. > > Jennifer > > On 12/3/2012 10:26 PM, jayashree viswanathan wrote: >> On 03-12-2012 11:28 AM, jayashree viswanathan wrote: >>> On 13-09-2012 7:35 PM, jayashree viswanathan wrote: >>>> Hi , >>>> >>>> Looking for a reviewer for a change request . >>>> >>>> Problem statement: >>>> In UnixPrintJob class while constructing a lpr command to queue up >>>> the jobs, we are creating tempfile with .ps extension . >>>> The content of the tempfile will not have appropriate postscript >>>> header[like PSPrinterJob], rather just the data to be printed . >>>> In certain environments[ex., RHEL 6.1] this causes failure and even >>>> the native command [lpr] as constructed by Java just queues up the job >>>> but doesn't prints them. >>>> >>>> webrev for the change is available at >>>> http://cr.openjdk.java.net/~shirishk/20120913_02/webrev.01/ >>>> >>>> Thanks and Regards, >>>> Jayashree Viswanathan >>>> >>> Hi , >>> >>> If you raise a sun bug , can you please share the number ? >>> >>> Thanks and Regards, >>> Jayashree Viswanathan >> Thanks Jennifer for sharing the bug number . It is 8004316 . I see >> that it is yet to be available in sun bug database and might be >> available soon . >> >> If you are happy with the fix can you please push the change ? >> >> Thanks and Regards, >> Jayashree Viswanathan >> > From andrew.brygin at oracle.com Tue Dec 11 09:59:43 2012 From: andrew.brygin at oracle.com (Andrew Brygin) Date: Tue, 11 Dec 2012 13:59:43 +0400 Subject: [OpenJDK 2D-Dev] Request for review: : [NEW BUG] Printer - tempfile having incorrect extension In-Reply-To: <50C6F969.20109@linux.vnet.ibm.com> References: <5051E846.2020302@linux.vnet.ibm.com> <50BC3F78.4040002@linux.vnet.ibm.com> <50BD9795.7080407@linux.vnet.ibm.com> <50BE2351.9040301@oracle.com> <50C6F969.20109@linux.vnet.ibm.com> Message-ID: <50C7040F.70706@oracle.com> Hello Jonathan, the change looks fine to me. Thanks, Andrew On 11.12.2012 13:14, Jonathan Lu wrote: > Thanks a lot, Jannifer! > > Could anybody else please help to take a look? > > Best regards > - Jonathan > > On 12/05/2012 12:22 AM, Jennifer Godinez wrote: >> I approve the change but we need one more reviewer before pushing the >> change. >> >> Jennifer >> >> On 12/3/2012 10:26 PM, jayashree viswanathan wrote: >>> On 03-12-2012 11:28 AM, jayashree viswanathan wrote: >>>> On 13-09-2012 7:35 PM, jayashree viswanathan wrote: >>>>> Hi , >>>>> >>>>> Looking for a reviewer for a change request . >>>>> >>>>> Problem statement: >>>>> In UnixPrintJob class while constructing a lpr command to queue up >>>>> the jobs, we are creating tempfile with .ps extension . >>>>> The content of the tempfile will not have appropriate postscript >>>>> header[like PSPrinterJob], rather just the data to be printed . >>>>> In certain environments[ex., RHEL 6.1] this causes failure and even >>>>> the native command [lpr] as constructed by Java just queues up the >>>>> job >>>>> but doesn't prints them. >>>>> >>>>> webrev for the change is available at >>>>> http://cr.openjdk.java.net/~shirishk/20120913_02/webrev.01/ >>>>> >>>>> Thanks and Regards, >>>>> Jayashree Viswanathan >>>>> >>>> Hi , >>>> >>>> If you raise a sun bug , can you please share the number ? >>>> >>>> Thanks and Regards, >>>> Jayashree Viswanathan >>> Thanks Jennifer for sharing the bug number . It is 8004316 . I see >>> that it is yet to be available in sun bug database and might be >>> available soon . >>> >>> If you are happy with the fix can you please push the change ? >>> >>> Thanks and Regards, >>> Jayashree Viswanathan >>> >> > From Sergey.Bylokhov at oracle.com Tue Dec 11 13:28:21 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 11 Dec 2012 17:28:21 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException Message-ID: <50C734F5.8040801@oracle.com> Hello, Please review the fix for jdk 8. PixelToShapeConverter.makePoly() should not try to close path in case of the empty arrays of points. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821 Webrev can be found at: http://cr.openjdk.java.net/~serb/8004821/webrev.00 -- Best regards, Sergey. From luchsh at linux.vnet.ibm.com Wed Dec 12 05:33:15 2012 From: luchsh at linux.vnet.ibm.com (luchsh at linux.vnet.ibm.com) Date: Wed, 12 Dec 2012 05:33:15 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8004316: Printer - tempfile having incorrect extension Message-ID: <20121212053402.7E2F4470B1@hg.openjdk.java.net> Changeset: e8b54ae97344 Author: jviswana Date: 2012-12-12 13:28 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e8b54ae97344 8004316: Printer - tempfile having incorrect extension Reviewed-by: bae, jgodinez ! src/solaris/classes/sun/print/UnixPrintJob.java From luchsh at linux.vnet.ibm.com Wed Dec 12 05:37:48 2012 From: luchsh at linux.vnet.ibm.com (Jonathan Lu) Date: Wed, 12 Dec 2012 13:37:48 +0800 Subject: [OpenJDK 2D-Dev] Request for review: : [NEW BUG] Printer - tempfile having incorrect extension In-Reply-To: <50C7040F.70706@oracle.com> References: <5051E846.2020302@linux.vnet.ibm.com> <50BC3F78.4040002@linux.vnet.ibm.com> <50BD9795.7080407@linux.vnet.ibm.com> <50BE2351.9040301@oracle.com> <50C6F969.20109@linux.vnet.ibm.com> <50C7040F.70706@oracle.com> Message-ID: <50C8182C.6040502@linux.vnet.ibm.com> Hello Andrew, Thanks a lot for reviewing, I've pushed the patch @ http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e8b54ae97344 Cheers - Jonathan On 12/11/2012 05:59 PM, Andrew Brygin wrote: > Hello Jonathan, > > the change looks fine to me. > > Thanks, > Andrew > > On 11.12.2012 13:14, Jonathan Lu wrote: >> Thanks a lot, Jannifer! >> >> Could anybody else please help to take a look? >> >> Best regards >> - Jonathan >> >> On 12/05/2012 12:22 AM, Jennifer Godinez wrote: >>> I approve the change but we need one more reviewer before pushing >>> the change. >>> >>> Jennifer >>> >>> On 12/3/2012 10:26 PM, jayashree viswanathan wrote: >>>> On 03-12-2012 11:28 AM, jayashree viswanathan wrote: >>>>> On 13-09-2012 7:35 PM, jayashree viswanathan wrote: >>>>>> Hi , >>>>>> >>>>>> Looking for a reviewer for a change request . >>>>>> >>>>>> Problem statement: >>>>>> In UnixPrintJob class while constructing a lpr command to queue up >>>>>> the jobs, we are creating tempfile with .ps extension . >>>>>> The content of the tempfile will not have appropriate postscript >>>>>> header[like PSPrinterJob], rather just the data to be printed . >>>>>> In certain environments[ex., RHEL 6.1] this causes failure and even >>>>>> the native command [lpr] as constructed by Java just queues up >>>>>> the job >>>>>> but doesn't prints them. >>>>>> >>>>>> webrev for the change is available at >>>>>> http://cr.openjdk.java.net/~shirishk/20120913_02/webrev.01/ >>>>>> >>>>>> Thanks and Regards, >>>>>> Jayashree Viswanathan >>>>>> >>>>> Hi , >>>>> >>>>> If you raise a sun bug , can you please share the number ? >>>>> >>>>> Thanks and Regards, >>>>> Jayashree Viswanathan >>>> Thanks Jennifer for sharing the bug number . It is 8004316 . I see >>>> that it is yet to be available in sun bug database and might be >>>> available soon . >>>> >>>> If you are happy with the fix can you please push the change ? >>>> >>>> Thanks and Regards, >>>> Jayashree Viswanathan >>>> >>> >> > From jviswana at linux.vnet.ibm.com Wed Dec 12 05:42:03 2012 From: jviswana at linux.vnet.ibm.com (jayashree viswanathan) Date: Wed, 12 Dec 2012 11:12:03 +0530 Subject: [OpenJDK 2D-Dev] Request for review: : [NEW BUG] Printer - tempfile having incorrect extension In-Reply-To: <50C8182C.6040502@linux.vnet.ibm.com> References: <5051E846.2020302@linux.vnet.ibm.com> <50BC3F78.4040002@linux.vnet.ibm.com> <50BD9795.7080407@linux.vnet.ibm.com> <50BE2351.9040301@oracle.com> <50C6F969.20109@linux.vnet.ibm.com> <50C7040F.70706@oracle.com> <50C8182C.6040502@linux.vnet.ibm.com> Message-ID: <50C8192B.2060301@linux.vnet.ibm.com> On 12-12-2012 11:07 AM, Jonathan Lu wrote: > Hello Andrew, > > Thanks a lot for reviewing, > I've pushed the patch @ > http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e8b54ae97344 > > Cheers > - Jonathan > > On 12/11/2012 05:59 PM, Andrew Brygin wrote: >> Hello Jonathan, >> >> the change looks fine to me. >> >> Thanks, >> Andrew >> >> On 11.12.2012 13:14, Jonathan Lu wrote: >>> Thanks a lot, Jannifer! >>> >>> Could anybody else please help to take a look? >>> >>> Best regards >>> - Jonathan >>> >>> On 12/05/2012 12:22 AM, Jennifer Godinez wrote: >>>> I approve the change but we need one more reviewer before pushing >>>> the change. >>>> >>>> Jennifer >>>> >>>> On 12/3/2012 10:26 PM, jayashree viswanathan wrote: >>>>> On 03-12-2012 11:28 AM, jayashree viswanathan wrote: >>>>>> On 13-09-2012 7:35 PM, jayashree viswanathan wrote: >>>>>>> Hi , >>>>>>> >>>>>>> Looking for a reviewer for a change request . >>>>>>> >>>>>>> Problem statement: >>>>>>> In UnixPrintJob class while constructing a lpr command to queue up >>>>>>> the jobs, we are creating tempfile with .ps extension . >>>>>>> The content of the tempfile will not have appropriate postscript >>>>>>> header[like PSPrinterJob], rather just the data to be printed . >>>>>>> In certain environments[ex., RHEL 6.1] this causes failure and >>>>>>> even >>>>>>> the native command [lpr] as constructed by Java just queues up >>>>>>> the job >>>>>>> but doesn't prints them. >>>>>>> >>>>>>> webrev for the change is available at >>>>>>> http://cr.openjdk.java.net/~shirishk/20120913_02/webrev.01/ >>>>>>> >>>>>>> Thanks and Regards, >>>>>>> Jayashree Viswanathan >>>>>>> >>>>>> Hi , >>>>>> >>>>>> If you raise a sun bug , can you please share the number ? >>>>>> >>>>>> Thanks and Regards, >>>>>> Jayashree Viswanathan >>>>> Thanks Jennifer for sharing the bug number . It is 8004316 . I see >>>>> that it is yet to be available in sun bug database and might be >>>>> available soon . >>>>> >>>>> If you are happy with the fix can you please push the change ? >>>>> >>>>> Thanks and Regards, >>>>> Jayashree Viswanathan >>>>> >>>> >>> >> > Hi Andrew , Jennifer and Phil Thanks for reviewing this item and taking it through ! Thanks Jonnathan for committing . Regards, Jayashree Viswanathan From Sergey.Bylokhov at oracle.com Wed Dec 12 15:32:54 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 12 Dec 2012 19:32:54 +0400 Subject: [OpenJDK 2D-Dev] clip with negative width or height in Graphics2D Message-ID: <50C8A3A6.9050203@oracle.com> Hello 2d team, I have a question about clipping in our implementation of SunGraphics2D. Currently if I set usrClip to Rectangle(100,100,-100,-100) the real clip will be clipRegion = 100,100,100,100; But if I set clip to Rectangle2D with the same coordinates the real clip will be clipRegion = 0,0,100,100;(This is because we normalizes usrClip before use). We automatically convert usrClip from Rectangle to Rectangle2D, if our graphics is scaled. So we get different clipRegion depending from scale. What behavior is correct? Should we always normalize usrClip before use or should we treat it as empty/nonexistent rectangle? -- Best regards, Sergey. From james.graham at oracle.com Wed Dec 12 18:48:33 2012 From: james.graham at oracle.com (Jim Graham) Date: Wed, 12 Dec 2012 10:48:33 -0800 Subject: [OpenJDK 2D-Dev] clip with negative width or height in Graphics2D In-Reply-To: <50C8A3A6.9050203@oracle.com> References: <50C8A3A6.9050203@oracle.com> Message-ID: <50C8D181.1020307@oracle.com> It sounds like the code that transforms the clip does not detect if the rectangle is empty first. The clip should be set to a no-area clip if the incoming width or height are negative (or 0)... ...jim On 12/12/2012 7:32 AM, Sergey Bylokhov wrote: > Hello 2d team, > I have a question about clipping in our implementation of SunGraphics2D. > Currently if I set usrClip to Rectangle(100,100,-100,-100) the real clip > will be clipRegion = 100,100,100,100; > But if I set clip to Rectangle2D with the same coordinates the real clip > will be clipRegion = 0,0,100,100;(This is because we normalizes usrClip > before use). > We automatically convert usrClip from Rectangle to Rectangle2D, if our > graphics is scaled. So we get different clipRegion depending from scale. > What behavior is correct? Should we always normalize usrClip before use > or should we treat it as empty/nonexistent rectangle? > From Sergey.Bylokhov at oracle.com Thu Dec 13 11:08:58 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 13 Dec 2012 15:08:58 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. Message-ID: <50C9B74A.7050806@oracle.com> Hello, Please review the fix for jdk 8. Change description: 1 transformShape now symmetric to untransformShape() (setFrameFromDiagonal was removed). 2 getClipBounds now always uses getBounds2D which does not return empty Rectangle if the userclip has negative width or height. Note that if the userclip has negative width or height, our real graphic clip will be empty/no-area. This wasn't true before the fix for the scaled graphics. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004859 Webrev can be found at: http://cr.openjdk.java.net/~serb/8004859/webrev.00 -- Best regards, Sergey. From james.graham at oracle.com Thu Dec 13 20:40:16 2012 From: james.graham at oracle.com (Jim Graham) Date: Thu, 13 Dec 2012 12:40:16 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50C9B74A.7050806@oracle.com> References: <50C9B74A.7050806@oracle.com> Message-ID: <50CA3D30.5020104@oracle.com> This fix breaks other behavior. You need to use setFrameFromDiagonal on the results of the transform because a flip or rotation can cause the transformed points to be unordered and setFFD will sort them as they need to be. It is the incoming rectangle that needs to be checked for being empty, not the results of the transform. The case that will fail with this fix is setting the clip to a valid rectangle in a coordinate system that is rotated by a multiple of 90 degrees or is flipped horizontally or vertically. Those cases will result in an empty clip, but the clip was not empty coming in... ...jim On 12/13/2012 3:08 AM, Sergey Bylokhov wrote: > Hello, > Please review the fix for jdk 8. > Change description: > 1 transformShape now symmetric to untransformShape() > (setFrameFromDiagonal was removed). > 2 getClipBounds now always uses getBounds2D which does not return empty > Rectangle if the userclip has negative width or height. > > Note that if the userclip has negative width or height, our real graphic > clip will be empty/no-area. This wasn't true before the fix for the > scaled graphics. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004859 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8004859/webrev.00 > From Sergey.Bylokhov at oracle.com Thu Dec 13 23:49:28 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 14 Dec 2012 03:49:28 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50CA3D30.5020104@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> Message-ID: <50CA6988.1010508@oracle.com> 14.12.2012 0:40, Jim Graham wrote: > This fix breaks other behavior. > > You need to use setFrameFromDiagonal on the results of the transform > because a flip or rotation can cause the transformed points to be > unordered and setFFD will sort them as they need to be. It is the > incoming rectangle that needs to be checked for being empty, not the > results of the transform. Yes, you are right. After the fix we can skip correct userclip, if it was flipped. Looks like correct solution for this issue is to use setFFD, if incoming rectangle is not empty but transformed rectangle is empty, and use opposite operation if incoming rectangle is empty but transformed rectangle is not empty. So IsEmpty property should not be changed in transformShape() method, Right? Thanks for review! > > The case that will fail with this fix is setting the clip to a valid > rectangle in a coordinate system that is rotated by a multiple of 90 > degrees or is flipped horizontally or vertically. Those cases will > result in an empty clip, but the clip was not empty coming in... > > ...jim > > On 12/13/2012 3:08 AM, Sergey Bylokhov wrote: >> Hello, >> Please review the fix for jdk 8. >> Change description: >> 1 transformShape now symmetric to untransformShape() >> (setFrameFromDiagonal was removed). >> 2 getClipBounds now always uses getBounds2D which does not return empty >> Rectangle if the userclip has negative width or height. >> >> Note that if the userclip has negative width or height, our real graphic >> clip will be empty/no-area. This wasn't true before the fix for the >> scaled graphics. >> >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004859 >> Webrev can be found at: >> http://cr.openjdk.java.net/~serb/8004859/webrev.00 >> -- Best regards, Sergey. From Sergey.Bylokhov at oracle.com Sat Dec 15 17:26:34 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Sat, 15 Dec 2012 21:26:34 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50CA3D30.5020104@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> Message-ID: <50CCB2CA.8030307@oracle.com> Hi, Jim. Could you please review the updated version of the fix: http://cr.openjdk.java.net/~serb/8004859/webrev.01 14.12.2012 0:40, Jim Graham wrote: > This fix breaks other behavior. > > You need to use setFrameFromDiagonal on the results of the transform > because a flip or rotation can cause the transformed points to be > unordered and setFFD will sort them as they need to be. It is the > incoming rectangle that needs to be checked for being empty, not the > results of the transform. In the new version I restore coordinates relation, if it were changed during transform. Swap needed: - If the user provide incorrect rectangle and after transformation we get correct rectangle. - If the user provide correct rectangle and after transformation we get incorrect rectangle. > > The case that will fail with this fix is setting the clip to a valid > rectangle in a coordinate system that is rotated by a multiple of 90 > degrees or is flipped horizontally or vertically. Those cases will > result in an empty clip, but the clip was not empty coming in... > > ...jim > > On 12/13/2012 3:08 AM, Sergey Bylokhov wrote: >> Hello, >> Please review the fix for jdk 8. >> Change description: >> 1 transformShape now symmetric to untransformShape() >> (setFrameFromDiagonal was removed). >> 2 getClipBounds now always uses getBounds2D which does not return empty >> Rectangle if the userclip has negative width or height. >> >> Note that if the userclip has negative width or height, our real graphic >> clip will be empty/no-area. This wasn't true before the fix for the >> scaled graphics. >> >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004859 >> Webrev can be found at: >> http://cr.openjdk.java.net/~serb/8004859/webrev.00 >> -- Best regards, Sergey. From andrew.brygin at oracle.com Mon Dec 17 15:00:47 2012 From: andrew.brygin at oracle.com (Andrew Brygin) Date: Mon, 17 Dec 2012 19:00:47 +0400 Subject: [OpenJDK 2D-Dev] [8] request for review: 7124245: [lcms] ColorConvertOp to color space CS_GRAY apparently converts orange to 244, 244, 0 Message-ID: <50CF339F.7090009@oracle.com> Hello Jennifer and Phil, could you please review a fix for CR 7124245? Bug: http://bugs.sun.com/view_bug.do?bug_id=7124245 Webrev: http://cr.openjdk.java.net/~bae/7124245/8/webrev.00/ The problem with wrong colors is caused by using incorrect image format for buffered images based on integer data buffers. Lcms interprets image data as a sequence of bytes, so we have to adjust data formats for such kind of images according to the system endiannes. I.e. for INT_ARGB image we get BGRA byte sequence on intel, and ARGB byte sequence on sparc. Lcms always creates transforms specific for formats of processed data (input and output). These formats can not be changed, the transform has to be re-created instead. So, we have to adjust input and output formats to the system endianness before we create the transform for given input and output images. Supplied regression test demonstrates the problem. Please take a look. Thanks, Andrew. From lana.steuck at oracle.com Wed Dec 19 02:24:16 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 02:24:16 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d: 16 new changesets Message-ID: <20121219022418.20D9B4724E@hg.openjdk.java.net> Changeset: 98a7af257bee Author: erikj Date: 2012-12-03 10:26 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/98a7af257bee 8003819: build-infra: backslashes at end of LIB and INCLUDE in spec.gmk Summary: Removing trailing backslash from LIB and INCLUDE. Reviewed-by: ohrstrom, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 754f91d22e1c Author: erikj Date: 2012-12-05 09:39 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/754f91d22e1c 8001541: Cannot build on Solaris using softlinks Summary: Fixed softlink resolver macro in configure. Reviewed-by: tbell, ohair ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: ec187d02c95e Author: erikj Date: 2012-12-05 10:12 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/ec187d02c95e 8004281: build-infra: Move all jar creation to images target and put jars in images/lib Summary: Fixed bug in setting up make dependencies in SetupArchive. Reviewed-by: ohair, tbell, dholmes ! common/makefiles/JavaCompilation.gmk Changeset: bd32ef0789ca Author: erikj Date: 2012-12-05 16:35 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/bd32ef0789ca 8003414: build-infra: fails on on windows Summary: Added extra check that windows sdk is valid. Reviewed-by: tbell, ohrstrom, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 9a6ec97ec45c Author: katleman Date: 2012-12-05 12:52 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/9a6ec97ec45c Merge Changeset: c91c581321ce Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/c91c581321ce Added tag jdk8-b67 for changeset 9a6ec97ec45c ! .hgtags Changeset: ab1ab9b148dd Author: smarks Date: 2012-11-28 17:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/ab1ab9b148dd 8004131: move jdi tests out of core testset Reviewed-by: alanb, chegar ! make/jprt.properties Changeset: ad54163c95f5 Author: lana Date: 2012-11-30 16:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/ad54163c95f5 Merge Changeset: 04435608c613 Author: lana Date: 2012-12-10 20:52 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/04435608c613 Merge Changeset: 6b96b7744913 Author: erikj Date: 2012-12-07 17:23 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/6b96b7744913 8004045: build-infra: Error 12 from zip when updating src.zip Summary: Hiding this error from make so that it doesn't fail Reviewed-by: ohrstrom, dholmes ! common/makefiles/JavaCompilation.gmk Changeset: 2795874efd16 Author: erikj Date: 2012-12-11 11:29 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/2795874efd16 8003945: build-infra: problems finding compiler when using --with-dev-kit Summary: Search all compiler names in dev-kit dir first. Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: e175ecff1391 Author: erikj Date: 2012-12-11 11:33 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/e175ecff1391 8001753: build-infra: mismatch with full debug symbol control for hotspot Summary: Enabling hotspot to use the FDS settings established at configure time Reviewed-by: dholmes, ohair ! common/autoconf/generated-configure.sh ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/jdk-options.m4 ! common/makefiles/NativeCompilation.gmk Changeset: cdb401a60cea Author: katleman Date: 2012-12-12 13:19 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/cdb401a60cea Merge Changeset: e9ec00893bb4 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/e9ec00893bb4 Added tag jdk8-b68 for changeset cdb401a60cea ! .hgtags Changeset: fb1bf5e5bc9e Author: henryjen Date: 2012-12-06 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/fb1bf5e5bc9e 8004685: add java.util.function to CORE_PKGS.gmk Reviewed-by: mduigou ! common/makefiles/javadoc/CORE_PKGS.gmk Changeset: e08b0096058f Author: lana Date: 2012-12-14 11:22 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/e08b0096058f Merge From lana.steuck at oracle.com Wed Dec 19 02:24:16 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 02:24:16 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/corba: 2 new changesets Message-ID: <20121219022420.EA5864724F@hg.openjdk.java.net> Changeset: 82000531feaa Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/82000531feaa Added tag jdk8-b67 for changeset 394515ad2a55 ! .hgtags Changeset: 22ddcac208a8 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/22ddcac208a8 Added tag jdk8-b68 for changeset 82000531feaa ! .hgtags From lana.steuck at oracle.com Wed Dec 19 02:24:17 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 02:24:17 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxws: 2 new changesets Message-ID: <20121219022428.9444747250@hg.openjdk.java.net> Changeset: d3fe408f3a9a Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/d3fe408f3a9a Added tag jdk8-b67 for changeset eb06aa51dfc2 ! .hgtags Changeset: 756323c99011 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/756323c99011 Added tag jdk8-b68 for changeset d3fe408f3a9a ! .hgtags From lana.steuck at oracle.com Wed Dec 19 02:24:16 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 02:24:16 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxp: 2 new changesets Message-ID: <20121219022430.3BA9047251@hg.openjdk.java.net> Changeset: b854e7008421 Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/b854e7008421 Added tag jdk8-b67 for changeset 83df3493ca3c ! .hgtags Changeset: 789a855de959 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/789a855de959 Added tag jdk8-b68 for changeset b854e7008421 ! .hgtags From lana.steuck at oracle.com Wed Dec 19 02:24:31 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 02:24:31 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/langtools: 20 new changesets Message-ID: <20121219022559.EBB0E47252@hg.openjdk.java.net> Changeset: e9a13a6c9d5d Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/e9a13a6c9d5d Added tag jdk8-b67 for changeset 303b09787a69 ! .hgtags Changeset: d9fe1f80515d Author: vromero Date: 2012-11-21 18:40 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/d9fe1f80515d 7190862: javap shows an incorrect type for operands if the 'wide' prefix is used 7109747: (javap) classfile not treating iinc_w correctly. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/classfile/Instruction.java ! src/share/classes/com/sun/tools/classfile/Opcode.java + test/tools/javap/T7190862.java Changeset: 3746b071d75b Author: vromero Date: 2012-11-21 19:09 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/3746b071d75b 6574624: javax.tools.JavaCompiler spec contains errors in sample code Reviewed-by: jjg, mcimadamore ! src/share/classes/javax/tools/JavaCompiler.java Changeset: 4d68e2a05b50 Author: jjg Date: 2012-11-27 13:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/4d68e2a05b50 8004068: Fix build problems caused by on-demand imports Reviewed-by: jjg Contributed-by: eric.caspole at amd.com ! src/share/classes/com/sun/tools/javac/code/Types.java Changeset: 1f41a5758cf7 Author: vromero Date: 2012-11-23 15:13 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/1f41a5758cf7 7144981: javac should ignore ignorable characters in input Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java + test/tools/javac/7144981/IgnoreIgnorableCharactersInInput.java Changeset: 969c96b980b7 Author: vromero Date: 2012-11-29 09:41 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/969c96b980b7 7153958: add constant pool reference to class containing inlined constants Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java + test/tools/javac/7153958/pkg/ClassToBeStaticallyImported.java Changeset: 4f9853659bf1 Author: mcimadamore Date: 2012-11-30 15:14 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/4f9853659bf1 8004105: Expression statement lambdas should be void-compatible Summary: Fix lambda compatibility rules as per latest EDR Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! test/tools/javac/lambda/LambdaConv21.java ! test/tools/javac/lambda/LambdaConv21.out ! test/tools/javac/lambda/VoidCompatibility.out Changeset: 34d1ebaf4645 Author: mcimadamore Date: 2012-11-30 15:14 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/34d1ebaf4645 8004102: Add support for generic functional descriptors Summary: Method references are allowed to have a generic functional interface descriptor target Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties - test/tools/javac/diags/examples/InvalidGenericDescInFunctionalInterface.java + test/tools/javac/diags/examples/InvalidGenericLambdaTarget.java + test/tools/javac/lambda/FunctionalInterfaceConversionTest.java - test/tools/javac/lambda/LambdaConversionTest.java + test/tools/javac/lambda/MethodReference57.java + test/tools/javac/lambda/MethodReference58.java + test/tools/javac/lambda/MethodReference58.out Changeset: 9b26c96f5138 Author: mcimadamore Date: 2012-11-30 15:14 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/9b26c96f5138 8004101: Add checks for method reference well-formedness Summary: Bring method reference type-checking in sync with latest EDR Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java + test/tools/javac/diags/examples/StaticBoundMref.java + test/tools/javac/diags/examples/StaticMrefWithTargs.java ! test/tools/javac/lambda/MethodReference30.java + test/tools/javac/lambda/MethodReference55.java + test/tools/javac/lambda/MethodReference55.out + test/tools/javac/lambda/MethodReference56.java + test/tools/javac/lambda/MethodReference56.out ! test/tools/javac/lambda/methodReference/MethodRef1.java ! test/tools/javac/lambda/methodReference/SamConversion.java ! test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestKinds.java Changeset: f6f1fd261f57 Author: mcimadamore Date: 2012-11-30 15:14 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/f6f1fd261f57 8002099: Add support for intersection types in cast expression Summary: Add parser and type-checking support for intersection types in cast expressions Reviewed-by: jjg + src/share/classes/com/sun/source/tree/IntersectionTypeTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java + src/share/classes/javax/lang/model/type/IntersectionType.java ! src/share/classes/javax/lang/model/type/TypeKind.java ! src/share/classes/javax/lang/model/type/TypeVisitor.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor8.java + test/tools/javac/cast/intersection/IntersectionTypeCastTest.java + test/tools/javac/cast/intersection/IntersectionTypeParserTest.java + test/tools/javac/cast/intersection/model/Check.java + test/tools/javac/cast/intersection/model/IntersectionTypeInfo.java + test/tools/javac/cast/intersection/model/Member.java + test/tools/javac/cast/intersection/model/Model01.java + test/tools/javac/cast/intersection/model/ModelChecker.java + test/tools/javac/diags/examples/IntersectionTypesInCastNotSupported.java + test/tools/javac/diags/examples/SecondaryBoundMustBeMarkerIntf.java + test/tools/javac/lambda/Intersection01.java + test/tools/javac/lambda/Intersection01.out ! test/tools/javac/lambda/LambdaParserTest.java + test/tools/javac/lambda/intersection/IntersectionTargetTypeTest.java Changeset: 98e14fc9ee11 Author: lana Date: 2012-11-30 16:34 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/98e14fc9ee11 Merge Changeset: 0e70eb71fec0 Author: mcimadamore Date: 2012-12-04 17:19 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/0e70eb71fec0 8004360: regression test DefaultMethodRegressionTests fails in langtools Summary: ignore broken failing test Reviewed-by: jjg - test/tools/javac/defaultMethodExecution/DefaultMethodRegressionTests.java + test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java Changeset: 014a6a11dfe5 Author: lana Date: 2012-12-10 20:59 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/014a6a11dfe5 Merge - test/tools/javac/defaultMethodExecution/DefaultMethodRegressionTests.java - test/tools/javac/diags/examples/InvalidGenericDescInFunctionalInterface.java - test/tools/javac/lambda/LambdaConversionTest.java Changeset: 13ccb5269f3d Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/13ccb5269f3d Added tag jdk8-b68 for changeset 014a6a11dfe5 ! .hgtags Changeset: c78acf6c2f3e Author: mcimadamore Date: 2012-12-10 12:10 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/c78acf6c2f3e 8004094: Javac compiler error - synthetic method accessor generated with duplicate name Summary: method clash check logic should skip methods marked with ACC_SYNTHETIC Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/8004094/B.java + test/tools/javac/generics/8004094/T8004094.java Changeset: fcf89720ae71 Author: vromero Date: 2012-12-10 16:21 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/fcf89720ae71 8003967: detect and remove all mutable implicit static enum fields in langtools Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/Opcode.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFileFactory.java ! src/share/classes/com/sun/tools/javac/Server.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/TypeTag.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/ConstFold.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/MandatoryWarningHandler.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/javax/lang/model/element/Modifier.java ! src/share/classes/javax/lang/model/util/ElementFilter.java ! src/share/classes/javax/tools/StandardLocation.java + test/tools/javac/T8003967/DetectMutableStaticFields.java Changeset: cfde9737131e Author: jjg Date: 2012-12-11 15:05 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/cfde9737131e 8004828: refactor init of *DocImpl classes Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ConstructorDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/MemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java Changeset: 170e486632d9 Author: jlahoda Date: 2012-12-12 20:26 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/170e486632d9 8004504: ListBuffer could reuse List.nil() as the sentinel element Summary: ListBuffer.last now points to the last elements with client data, or null if none. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/util/ListBuffer.java + test/tools/javac/util/list/ListBufferTest.java Changeset: 376d6c1b49e5 Author: jfranck Date: 2012-12-03 11:16 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/376d6c1b49e5 8001114: Container annotation is not checked for semantic correctness Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.out ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.out ! test/tools/javac/annotations/repeatingAnnotations/NoRepeatableAnno.out + test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.java + test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.out ! test/tools/javac/diags/examples/ContainedByNonDefault.java + test/tools/javac/diags/examples/InvalidDuplicateAnnotation.java Changeset: d7360bf35ee1 Author: lana Date: 2012-12-14 13:15 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/d7360bf35ee1 Merge From lana.steuck at oracle.com Wed Dec 19 02:25:01 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 02:25:01 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/hotspot: 48 new changesets Message-ID: <20121219022722.9A79747253@hg.openjdk.java.net> Changeset: e1d42ba865de Author: amurillo Date: 2012-11-16 09:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e1d42ba865de 8003541: new hotspot build - hs25-b11 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 49cbd3e25ba9 Author: zgu Date: 2012-11-16 09:05 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/49cbd3e25ba9 8003487: NMT: incorrect assertion in VMMemPointerIterator::remove_released_region method (memSnapshot.cpp) Summary: The assertion is applied to only the region to be released, also performs region integrity checking Reviewed-by: acorn, coleenp ! src/share/vm/services/memSnapshot.cpp ! src/share/vm/services/memSnapshot.hpp Changeset: 3ed6de6e139b Author: coleenp Date: 2012-11-20 20:27 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/3ed6de6e139b Merge Changeset: 73e64867adb7 Author: mikael Date: 2012-11-21 09:02 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/73e64867adb7 8003690: Example code in JVMTI GetStackTrace documentation is broken Summary: Fixed to minor errors in example code Reviewed-by: sspitsyn, dholmes ! src/share/vm/prims/jvmti.xml Changeset: 6b881a6b0665 Author: dholmes Date: 2012-11-21 20:07 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6b881a6b0665 8003591: Abstract_VM_Version::internal_vm_info_string needs to stringify FLOAT_ARCH for ease of use Reviewed-by: coleenp, kvn ! src/share/vm/runtime/vm_version.cpp Changeset: ca1be5fbe6ff Author: dholmes Date: 2012-11-21 21:26 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ca1be5fbe6ff Merge Changeset: 7c15faa95ce7 Author: mikael Date: 2012-11-27 07:57 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/7c15faa95ce7 8003879: Duplicate definitions in vmStructs Summary: Removed duplicate entries Reviewed-by: dholmes, sspitsyn ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vmStructs.hpp Changeset: bbc14465e7db Author: zgu Date: 2012-11-28 09:19 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/bbc14465e7db 8003689: MemTracker::init_tracking_options() reads outside array if commandline argument is empty Summary: Fixed potential buffer overrun when giving empty option to NativeMemoryTracking commandline option Reviewed-by: ctornqvi, hseigel, kvn ! src/share/vm/services/memTracker.cpp Changeset: 5de2a5bd519e Author: zgu Date: 2012-11-28 06:42 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5de2a5bd519e Merge Changeset: fe81517cfb77 Author: hseigel Date: 2012-11-28 08:17 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/fe81517cfb77 6924920: Class Data Sharing limit on the java version string can create failures Summary: Truncate the java version string and add a hash value if it is too long. Reviewed-by: dholmes, coleenp ! src/share/vm/memory/filemap.cpp Changeset: b51dc8df86e5 Author: coleenp Date: 2012-11-28 08:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b51dc8df86e5 Merge Changeset: 59c790074993 Author: coleenp Date: 2012-11-28 17:50 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/59c790074993 8003635: NPG: AsynchGetCallTrace broken by Method* virtual call Summary: Make metaspace::contains be lock free and used to see if something is in metaspace, also compare Method* with vtbl pointer. Reviewed-by: dholmes, sspitsyn, dcubed, jmasa ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/compiledICHolder.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/forte.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 53715fb1597d Author: brutisso Date: 2012-11-20 11:40 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/53715fb1597d 7198334: UseNUMA modifies system parameters on non-NUMA system Summary: The flags MinHeapDeltaBytes and UseNUMAInterleaving must be adjusted after the OS have adjusted the UseNUMA flag in the method os::init_2. Reviewed-by: dholmes, brutisso Contributed-by: erik.helin at oracle.com ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/thread.cpp Changeset: 19c1bd641922 Author: coleenp Date: 2012-11-26 12:31 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/19c1bd641922 8003722: More gcc 4.7 compilation errors Summary: Add a few more this->qualifications. Reviewed-by: coleenp, dholmes Contributed-by: duboscq at ssw.jku.at ! src/share/vm/memory/binaryTreeDictionary.cpp Changeset: d0aa87f04bd5 Author: stefank Date: 2012-11-27 10:13 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d0aa87f04bd5 8003720: NPG: Method in interpreter stack frame can be deallocated Summary: Pass down a closure during root scanning to keep the class of the method alive. Reviewed-by: coleenp, jcoomes ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/memory/iterator.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vmThread.hpp + test/runtime/8003720/Asmator.java + test/runtime/8003720/Test8003720.java + test/runtime/8003720/Victim.java + test/runtime/8003720/VictimClassLoader.java Changeset: f34d701e952e Author: stefank Date: 2012-11-27 14:20 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f34d701e952e 8003935: Simplify the needed includes for using Thread::current() Reviewed-by: dholmes, rbackman, coleenp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/stubRoutines_sparc.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/zero/vm/interp_masm_zero.cpp ! src/cpu/zero/vm/stubGenerator_zero.cpp ! src/cpu/zero/vm/stubRoutines_zero.cpp ! src/os/bsd/vm/mutex_bsd.cpp ! src/os/bsd/vm/mutex_bsd.inline.hpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/threadCritical_bsd.cpp ! src/os/bsd/vm/thread_bsd.inline.hpp ! src/os/linux/vm/mutex_linux.cpp ! src/os/linux/vm/mutex_linux.inline.hpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/threadCritical_linux.cpp ! src/os/linux/vm/thread_linux.inline.hpp ! src/os/solaris/vm/mutex_solaris.cpp ! src/os/solaris/vm/mutex_solaris.inline.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/threadCritical_solaris.cpp ! src/os/solaris/vm/thread_solaris.inline.hpp ! src/os/windows/vm/mutex_windows.cpp ! src/os/windows/vm/mutex_windows.inline.hpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/threadCritical_windows.cpp ! src/os/windows/vm/thread_windows.inline.hpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_x86/vm/threadLS_bsd_x86.cpp ! src/os_cpu/bsd_x86/vm/thread_bsd_x86.cpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/bsd_zero/vm/threadLS_bsd_zero.cpp ! src/os_cpu/bsd_zero/vm/thread_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/threadLS_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/thread_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_x86/vm/threadLS_linux_x86.cpp ! src/os_cpu/linux_x86/vm/thread_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/linux_zero/vm/threadLS_linux_zero.cpp ! src/os_cpu/linux_zero/vm/thread_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/threadLS_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/thread_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/threadLS_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/thread_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/os_cpu/windows_x86/vm/threadLS_windows_x86.cpp ! src/os_cpu/windows_x86/vm/thread_windows_x86.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp ! src/share/vm/gc_implementation/g1/ptrQueue.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/resourceArea.cpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/memory/threadLocalAllocBuffer.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/markOop.cpp ! src/share/vm/oops/oop.cpp ! src/share/vm/oops/oopsHierarchy.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.inline.hpp ! src/share/vm/runtime/interfaceSupport.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/javaCalls.cpp ! src/share/vm/runtime/javaCalls.hpp ! src/share/vm/runtime/jniHandles.cpp ! src/share/vm/runtime/memprofiler.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/task.cpp ! src/share/vm/runtime/thread.cpp + src/share/vm/runtime/thread.inline.hpp ! src/share/vm/runtime/threadLocalStorage.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vmThread.hpp ! src/share/vm/runtime/vm_operations.cpp ! src/share/vm/services/memTracker.hpp ! src/share/vm/utilities/array.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/events.cpp ! src/share/vm/utilities/exceptions.cpp ! src/share/vm/utilities/growableArray.cpp ! src/share/vm/utilities/preserveException.hpp ! src/share/vm/utilities/taskqueue.cpp ! src/share/vm/utilities/workgroup.hpp Changeset: 2fc0334f613a Author: johnc Date: 2012-11-27 14:11 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/2fc0334f613a 7194633: G1: Assertion and guarantee failures in block offset table Summary: Add detailed error messages to assertions and guarantees in G1's block offset table. Reviewed-by: ysr, brutisso ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.hpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.inline.hpp ! src/share/vm/memory/space.cpp Changeset: c24f778e9401 Author: johnc Date: 2012-11-29 11:23 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c24f778e9401 Merge ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: b2dbd323c668 Author: jiangli Date: 2012-11-27 17:03 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b2dbd323c668 8003848: Make ConstMethod::generic_signature_index optional and move Method::_max_stack to ConstMethod. Summary: Make ConstMethod::generic_signature_index optional and move Method::_max_stack to ConstMethod. Reviewed-by: bdelsart, sspitsyn, coleenp ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 5505fbbae3d3 Author: cjplummer Date: 2012-11-29 13:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5505fbbae3d3 Merge ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 90273fc0a981 Author: coleenp Date: 2012-11-29 16:50 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/90273fc0a981 8000662: NPG: nashorn ant clean test262 out-of-memory with Java heap Summary: Add ClassLoaderData object for each anonymous class with metaspaces to allocate in. Reviewed-by: twisti, jrose, stefank ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/ci/ciReplay.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/classfile/classLoaderData.inline.hpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/loaderConstraints.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/prims/unsafe.cpp Changeset: dad48145e775 Author: stefank Date: 2012-11-29 23:02 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/dad48145e775 8004199: Change the ASM package for Test8003720 Reviewed-by: kvn, jrose ! test/runtime/8003720/Asmator.java ! test/runtime/8003720/Test8003720.java Changeset: 5fafdef522c6 Author: johnc Date: 2012-11-30 12:01 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5fafdef522c6 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp Changeset: b61d9c88b759 Author: amurillo Date: 2012-11-30 16:45 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b61d9c88b759 Merge Changeset: 25bdce771bb3 Author: amurillo Date: 2012-11-30 16:45 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/25bdce771bb3 Added tag hs25-b11 for changeset b61d9c88b759 ! .hgtags Changeset: 10587a580c51 Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/10587a580c51 Added tag jdk8-b67 for changeset 25bdce771bb3 ! .hgtags Changeset: 816b7e5bf2ed Author: amurillo Date: 2012-11-30 17:00 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/816b7e5bf2ed 8004248: new hotspot build - hs25-b12 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 7cc69864a29b Author: kvn Date: 2012-11-16 15:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/7cc69864a29b 7146636: compiler/6865265/StackOverflowBug.java fails due to changed stack minimum Summary: Increase the stack size in the run parameters. Reviewed-by: kvn Contributed-by: david.r.chase at oracle.com ! test/compiler/6865265/StackOverflowBug.java Changeset: ee32440febeb Author: vlivanov Date: 2012-11-21 05:57 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ee32440febeb 8001538: hs_err file does not list anymore compiled methods in compilation events Summary: Fixed message buffer size calculation. Reviewed-by: kvn, twisti ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/utilities/events.hpp Changeset: beebba0acc11 Author: twisti Date: 2012-11-26 17:25 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/beebba0acc11 7172640: C2: instrinsic implementations in LibraryCallKit should use argument() instead of pop() Reviewed-by: kvn, jrose ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/interpreter/bytecodes.hpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/locknode.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/type.hpp Changeset: 2cd5e15048e6 Author: twisti Date: 2012-11-27 12:48 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/2cd5e15048e6 8003868: fix shark for latest HotSpot and LLVM Reviewed-by: twisti Contributed-by: Roman Kennke ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/assembler_zero.hpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/cpu/zero/vm/globals_zero.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/shark/llvmHeaders.hpp ! src/share/vm/shark/llvmValue.hpp ! src/share/vm/shark/sharkBlock.cpp ! src/share/vm/shark/sharkBuilder.cpp ! src/share/vm/shark/sharkBuilder.hpp ! src/share/vm/shark/sharkCacheDecache.cpp ! src/share/vm/shark/sharkCacheDecache.hpp ! src/share/vm/shark/sharkCodeBuffer.hpp ! src/share/vm/shark/sharkCompiler.cpp ! src/share/vm/shark/sharkConstant.cpp ! src/share/vm/shark/sharkContext.cpp ! src/share/vm/shark/sharkContext.hpp ! src/share/vm/shark/sharkFunction.hpp ! src/share/vm/shark/sharkIntrinsics.cpp ! src/share/vm/shark/sharkMemoryManager.cpp ! src/share/vm/shark/sharkMemoryManager.hpp ! src/share/vm/shark/sharkNativeWrapper.cpp ! src/share/vm/shark/sharkStack.cpp ! src/share/vm/shark/sharkStack.hpp ! src/share/vm/shark/sharkState.cpp ! src/share/vm/shark/sharkTopLevelBlock.cpp ! src/share/vm/shark/sharkTopLevelBlock.hpp ! src/share/vm/shark/sharkType.hpp ! src/share/vm/shark/sharkValue.cpp ! src/share/vm/shark/shark_globals.hpp Changeset: 2aff40cb4703 Author: bharadwaj Date: 2012-11-27 17:24 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/2aff40cb4703 7092905: C2: Keep track of the number of dead nodes Summary: keep an (almost) accurate running count of the reachable (live) flow graph nodes. Reviewed-by: kvn, twisti, jrose, vlivanov ! src/share/tools/LogCompilation/README ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/Phase.java ! src/share/vm/opto/block.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/ifg.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/postaloc.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/opto/stringopts.cpp Changeset: 1acccb7c0b01 Author: kvn Date: 2012-11-27 17:41 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1acccb7c0b01 8003850: add support for constants in stub code Summary: remember the code section and switch back to the proper one when adding constants. Reviewed-by: twisti, kvn Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/codeBuffer.cpp Changeset: 6ab62ad83507 Author: twisti Date: 2012-11-30 11:44 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6ab62ad83507 8003195: AbstractAssembler should not store code pointers but use the CodeSection directly Reviewed-by: twisti, kvn Contributed-by: Bharadwaj Yadavalli ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/assembler_x86.inline.hpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/assembler.inline.hpp ! src/share/vm/asm/codeBuffer.hpp Changeset: cd3d6a6b95d9 Author: twisti Date: 2012-11-30 15:23 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/cd3d6a6b95d9 8003240: x86: move MacroAssembler into separate file Reviewed-by: kvn ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/codeBuffer_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/assembler_x86.inline.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/cpu/x86/vm/icBuffer_x86.cpp ! src/cpu/x86/vm/icache_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/cpu/x86/vm/interpreter_x86_32.cpp ! src/cpu/x86/vm/interpreter_x86_64.cpp ! src/cpu/x86/vm/jniFastGetField_x86_32.cpp ! src/cpu/x86/vm/jniFastGetField_x86_64.cpp + src/cpu/x86/vm/macroAssembler_x86.cpp + src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/metaspaceShared_x86_32.cpp ! src/cpu/x86/vm/metaspaceShared_x86_64.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/nativeInst_x86.cpp ! src/cpu/x86/vm/relocInfo_x86.cpp ! src/cpu/x86/vm/runtime_x86_32.cpp ! src/cpu/x86/vm/runtime_x86_64.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vtableStubs_x86_32.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/os/bsd/vm/osThread_bsd.cpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/linux/vm/osThread_linux.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/solaris/vm/osThread_solaris.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/windows/vm/osThread_windows.cpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.inline.hpp ! src/os_cpu/bsd_x86/vm/assembler_bsd_x86.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_x86/vm/assembler_linux_x86.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_x86/vm/assembler_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/orderAccess_solaris_x86.inline.hpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/assembler_windows_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/assembler.inline.hpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/codeBuffer.hpp + src/share/vm/asm/macroAssembler.hpp + src/share/vm/asm/macroAssembler.inline.hpp ! src/share/vm/c1/c1_MacroAssembler.hpp ! src/share/vm/code/icBuffer.cpp ! src/share/vm/code/relocInfo.cpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/runtime/atomic.cpp ! src/share/vm/runtime/atomic.hpp + src/share/vm/runtime/atomic.inline.hpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/stubCodeGenerator.cpp Changeset: dd38cfd12c3a Author: twisti Date: 2012-12-03 15:48 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/dd38cfd12c3a 8004319: test/gc/7168848/HumongousAlloc.java fails after 7172640 Reviewed-by: kvn, johnc ! src/share/vm/opto/library_call.cpp Changeset: c5d414e98fd4 Author: neliasso Date: 2012-11-26 15:11 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c5d414e98fd4 8003983: LogCompilation tool is broken since c1 support Summary: Fixed emitting and parsing Reviewed-by: jrose, kvn ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogCompilation.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java ! src/share/vm/c1/c1_Compilation.cpp Changeset: b7ff5879152e Author: neliasso Date: 2012-12-06 09:50 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b7ff5879152e 8003934: Fix generation of malformed options to Projectcreator Summary: Makefile produces unmatched quotes due to nmake bug Reviewed-by: jwilhelm, brutisso ! make/windows/projectfiles/common/Makefile Changeset: 228a94f37a67 Author: neliasso Date: 2012-12-06 14:33 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/228a94f37a67 Merge Changeset: f0c2369fda5a Author: twisti Date: 2012-12-06 09:57 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f0c2369fda5a 8003250: SPARC: move MacroAssembler into separate file Reviewed-by: jrose, kvn ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/cpu/sparc/vm/icBuffer_sparc.cpp ! src/cpu/sparc/vm/icache_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.hpp ! src/cpu/sparc/vm/interpreter_sparc.cpp ! src/cpu/sparc/vm/jniFastGetField_sparc.cpp + src/cpu/sparc/vm/macroAssembler_sparc.cpp + src/cpu/sparc/vm/macroAssembler_sparc.hpp + src/cpu/sparc/vm/macroAssembler_sparc.inline.hpp ! src/cpu/sparc/vm/metaspaceShared_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/nativeInst_sparc.cpp ! src/cpu/sparc/vm/nativeInst_sparc.hpp ! src/cpu/sparc/vm/relocInfo_sparc.cpp ! src/cpu/sparc/vm/runtime_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vmreg_sparc.cpp ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/assembler_zero.hpp ! src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/share/vm/adlc/main.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/macroAssembler.hpp ! src/share/vm/asm/macroAssembler.inline.hpp ! src/share/vm/asm/register.hpp ! src/share/vm/code/vmreg.hpp Changeset: 522662fa9c16 Author: twisti Date: 2012-12-06 11:05 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/522662fa9c16 Merge Changeset: d2f8c38e543d Author: roland Date: 2012-12-07 01:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d2f8c38e543d Merge ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/thread.cpp Changeset: 0f80645e9c26 Author: johnc Date: 2012-11-30 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/0f80645e9c26 8004170: G1: Verbose GC output is not getting flushed to log file using JDK 8 Summary: Add flushes to G1CollectedHeap::log_gc_footer() and TraceCPUTime destructor. Reviewed-by: jwilhelm, azeemj, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/timer.cpp Changeset: eade6b2e4782 Author: jmasa Date: 2012-11-29 10:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/eade6b2e4782 8003554: NPG: move Metablock and Metachunk code out of metaspace.cpp Reviewed-by: coleenp + src/share/vm/memory/metablock.cpp + src/share/vm/memory/metachunk.cpp ! src/share/vm/memory/metaspace.cpp Changeset: cbe736bc70fa Author: jwilhelm Date: 2012-12-07 07:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/cbe736bc70fa Merge Changeset: a35a72dd2e12 Author: amurillo Date: 2012-12-07 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/a35a72dd2e12 Merge Changeset: 121aa71316af Author: amurillo Date: 2012-12-07 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/121aa71316af Added tag hs25-b12 for changeset a35a72dd2e12 ! .hgtags Changeset: 8af7d22f1f8f Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8af7d22f1f8f Added tag jdk8-b68 for changeset 121aa71316af ! .hgtags From lana.steuck at oracle.com Wed Dec 19 02:28:11 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 19 Dec 2012 02:28:11 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 105 new changesets Message-ID: <20121219025416.E1AFF47256@hg.openjdk.java.net> Changeset: b0f008ab45d7 Author: twisti Date: 2012-11-30 11:42 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b0f008ab45d7 8001885: JSR 292 classes should use jdk.internal.org.objectweb.asm Reviewed-by: kvn, jrose, twisti Contributed-by: David Chase ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java Changeset: 0fda013e4638 Author: erikj Date: 2012-12-05 10:12 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0fda013e4638 8004281: build-infra: Move all jar creation to images target and put jars in images/lib Reviewed-by: ohair, tbell, dholmes ! makefiles/CompileDemos.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk ! makefiles/Import.gmk Changeset: ce9b02a3a17e Author: katleman Date: 2012-12-05 12:53 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ce9b02a3a17e Merge Changeset: ea0d3a9d0d01 Author: katleman Date: 2012-12-06 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ea0d3a9d0d01 Added tag jdk8-b67 for changeset ce9b02a3a17e ! .hgtags Changeset: 1175410d98ea Author: serb Date: 2012-11-21 15:50 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1175410d98ea 7124552: [macosx] NullPointerException in getBufferStrategy() 7124219: [macosx] Unable to draw images to fullscreen Reviewed-by: bae, anthony ! src/macosx/classes/sun/awt/CGraphicsConfig.java ! src/macosx/classes/sun/java2d/opengl/CGLGraphicsConfig.java ! src/macosx/classes/sun/lwawt/LWCanvasPeer.java ! src/macosx/classes/sun/lwawt/LWComponentPeer.java + src/macosx/classes/sun/lwawt/LWGraphicsConfig.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: 5b2c31d20a64 Author: serb Date: 2012-11-21 15:54 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5b2c31d20a64 7193214: Consider simplifying CPlatformWindow.setResizable() Reviewed-by: anthony, denis ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m Changeset: c9dead63607c Author: serb Date: 2012-11-21 15:58 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c9dead63607c 7154516: [macosx] Popup menus have no visible borders Reviewed-by: anthony, denis ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java Changeset: 9cd48409539e Author: kizune Date: 2012-11-21 20:42 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9cd48409539e 8003273: Missing testcase for 7171812 Reviewed-by: art, serb + test/javax/swing/dnd/7171812/JListWithScroll.java + test/javax/swing/dnd/7171812/bug7171812.java Changeset: 5600005b87fb Author: serb Date: 2012-11-27 17:03 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5600005b87fb 8002308: [macosx] 7198229 should be applied to the user action only Reviewed-by: anthony, skovatch ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m + test/java/awt/Frame/FrameSetSizeStressTest/FrameSetSizeStressTest.java Changeset: 0e91d6f3019c Author: alexsch Date: 2012-11-29 07:42 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0e91d6f3019c 8000423: Diacritic is not applyed to a base letter on Linux Reviewed-by: anthony, serb ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: abee1d528df1 Author: kshefov Date: 2012-11-30 12:39 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/abee1d528df1 7124242: [macosx] Test doesn't work because of the frame round corners in the LaF Reviewed-by: anthony, yan, alexsch ! test/javax/swing/text/CSSBorder/6796710/bug6796710.java Changeset: 35d8085aa14a Author: lana Date: 2012-11-30 17:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/35d8085aa14a Merge Changeset: da55ef766e48 Author: alexsch Date: 2012-12-04 15:26 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/da55ef766e48 6671481: NPE at javax.swing.plaf.basic.BasicTreeUI$Handler.handleSelection Reviewed-by: serb ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java Changeset: bd175c70684c Author: alexsch Date: 2012-12-04 15:56 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bd175c70684c 8003830: NPE at BasicTreeUI$Actions.page:4470 Reviewed-by: serb, alexsch Contributed-by: Jaroslav Tulach ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java + test/javax/swing/JTree/8003830/bug8003830.java Changeset: 009fd6e1d9f5 Author: alexsch Date: 2012-12-04 16:42 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/009fd6e1d9f5 8002077: Possible mnemonic issue on JFileChooser Save button on nimbus L&F Reviewed-by: serb ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUI.java Changeset: 4aad3e6f68d2 Author: jviswana Date: 2012-12-04 17:17 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4aad3e6f68d2 4631925: JColor Chooser is not fully accessible Reviewed-by: alexsch ! src/share/classes/javax/swing/JColorChooser.java ! src/share/classes/javax/swing/colorchooser/ColorChooserPanel.java ! src/share/classes/javax/swing/colorchooser/ColorPanel.java ! src/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java Changeset: ea20c9388d90 Author: aph Date: 2012-12-04 14:02 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ea20c9388d90 8004344: Fix a crash in ToolkitErrorHandler() in XlibWrapper.c Summary: Code does not check for JNU_GetEnv returning NULL. Reviewed-by: anthony ! src/solaris/native/sun/xawt/XlibWrapper.c Changeset: bbbb5c70aa59 Author: lana Date: 2012-12-04 11:41 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bbbb5c70aa59 Merge - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: f389bf27fc4f Author: dbuck Date: 2012-11-20 21:35 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f389bf27fc4f 7198904: (alt-rt) TreeMap.clone is broken Summary: Test case for cr7198904. Issue only found in OracleJDK, but test case is valid for OpenJDK as well Reviewed-by: mduigou, dholmes + test/java/util/TreeMap/Clone.java Changeset: ee6e5b7d5d55 Author: uta Date: 2012-11-23 13:07 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ee6e5b7d5d55 8003898: X11 toolkit can be chosen as the default toolkit Summary: XToolkit is not selected for any values of system-wide environment variables (ex. DISPLAY). Reviewed-by: anthony, art ! src/solaris/native/java/lang/java_props_macosx.c Changeset: 621c379d909d Author: xuelei Date: 2012-11-24 03:34 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/621c379d909d 8001751: Javadoc warnings in JSSE code Reviewed-by: alanb ! src/share/classes/javax/net/ssl/HostnameVerifier.java ! src/share/classes/javax/net/ssl/SNIHostName.java ! src/share/classes/javax/net/ssl/SNIMatcher.java ! src/share/classes/javax/net/ssl/SNIServerName.java ! src/share/classes/javax/net/ssl/SSLParameters.java ! src/share/classes/javax/net/ssl/SSLSocketFactory.java Changeset: f7d45462b225 Author: xuelei Date: 2012-11-24 04:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f7d45462b225 8003950: Adds missing Override annotations and removes unnecessary imports in sun.security.ssl Reviewed-by: xuelei Contributed-by: Florian Weimer ! src/share/classes/sun/security/ssl/AppInputStream.java ! src/share/classes/sun/security/ssl/AppOutputStream.java ! src/share/classes/sun/security/ssl/BaseSSLSocketImpl.java ! src/share/classes/sun/security/ssl/ByteBufferInputStream.java ! src/share/classes/sun/security/ssl/CipherBox.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/CipherSuiteList.java ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/DHClientKeyExchange.java ! src/share/classes/sun/security/ssl/ECDHClientKeyExchange.java ! src/share/classes/sun/security/ssl/ECDHCrypt.java ! src/share/classes/sun/security/ssl/EngineInputRecord.java ! src/share/classes/sun/security/ssl/EngineOutputRecord.java ! src/share/classes/sun/security/ssl/EngineWriter.java ! src/share/classes/sun/security/ssl/ExtensionType.java ! src/share/classes/sun/security/ssl/HandshakeHash.java ! src/share/classes/sun/security/ssl/HandshakeInStream.java ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/HandshakeOutStream.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/HelloExtension.java ! src/share/classes/sun/security/ssl/HelloExtensions.java ! src/share/classes/sun/security/ssl/InputRecord.java ! src/share/classes/sun/security/ssl/JsseJce.java ! src/share/classes/sun/security/ssl/KerberosClientKeyExchange.java ! src/share/classes/sun/security/ssl/KeyManagerFactoryImpl.java ! src/share/classes/sun/security/ssl/Krb5Helper.java ! src/share/classes/sun/security/ssl/OutputRecord.java ! src/share/classes/sun/security/ssl/ProtocolList.java ! src/share/classes/sun/security/ssl/ProtocolVersion.java ! src/share/classes/sun/security/ssl/RSAClientKeyExchange.java ! src/share/classes/sun/security/ssl/RSASignature.java ! src/share/classes/sun/security/ssl/RenegotiationInfoExtension.java ! src/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketFactoryImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketImpl.java ! src/share/classes/sun/security/ssl/SSLSessionContextImpl.java ! src/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/share/classes/sun/security/ssl/SSLSocketFactoryImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java ! src/share/classes/sun/security/ssl/ServerNameExtension.java ! src/share/classes/sun/security/ssl/SessionId.java ! src/share/classes/sun/security/ssl/SunJSSE.java ! src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java ! src/share/classes/sun/security/ssl/SupportedEllipticCurvesExtension.java ! src/share/classes/sun/security/ssl/SupportedEllipticPointFormatsExtension.java ! src/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java ! src/share/classes/sun/security/ssl/UnknownExtension.java ! src/share/classes/sun/security/ssl/X509KeyManagerImpl.java ! src/share/classes/sun/security/ssl/X509TrustManagerImpl.java Changeset: d30c13172254 Author: xuelei Date: 2012-11-24 04:27 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d30c13172254 8003951: Removes unused variables in sun.security.ssl Reviewed-by: xuelei Contributed-by: Florian Weimer ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/JsseJce.java ! src/share/classes/sun/security/ssl/SSLServerSocketImpl.java ! src/share/classes/sun/security/ssl/SSLSessionContextImpl.java ! src/share/classes/sun/security/ssl/SSLSocketFactoryImpl.java ! src/share/classes/sun/security/ssl/X509TrustManagerImpl.java Changeset: 8970128e040d Author: uta Date: 2012-11-26 15:54 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/8970128e040d 7162111: TEST_BUG: change tests run in headless mode [macosx] (open) Summary: In problem tests detection of AWT headless mode was introduced or AWT dependence was removed. Reviewed-by: alanb ! test/ProblemList.txt ! test/demo/jvmti/mtrace/TraceJFrame.java ! test/java/io/Serializable/resolveClass/deserializeButton/Foo.java ! test/java/io/Serializable/resolveClass/deserializeButton/Test.java ! test/java/io/Serializable/resolveClass/deserializeButton/run.sh Changeset: 054470092795 Author: mullan Date: 2012-11-26 08:12 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/054470092795 7167056: Clarify that BasicPermission names that contain non-wildcard asterisks are not invalid Reviewed-by: weijun, xuelei ! src/share/classes/com/sun/net/ssl/SSLPermission.java ! src/share/classes/java/lang/RuntimePermission.java ! src/share/classes/java/net/NetPermission.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/sql/SQLPermission.java ! src/share/classes/java/util/PropertyPermission.java ! src/share/classes/javax/net/ssl/SSLPermission.java + test/java/security/BasicPermission/Wildcard.java Changeset: ea66140be78d Author: mullan Date: 2012-11-26 08:23 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ea66140be78d Merge - makefiles/docs/CORE_PKGS.gmk - makefiles/docs/Makefile - makefiles/docs/NON_CORE_PKGS.gmk - makefiles/docs/Notes.html - makefiles/mapfiles/launchers/mapfile-amd64 - makefiles/mapfiles/launchers/mapfile-i586 - makefiles/mapfiles/libawt_headless/reorder-i586 - makefiles/mapfiles/libjava/reorder-i586 - makefiles/mapfiles/libjpeg/reorder-i586 - makefiles/mapfiles/libnio/mapfile-bsd - makefiles/mapfiles/libnio/reorder-i586 - makefiles/mapfiles/libverify/reorder-i586 - makefiles/mapfiles/libzip/reorder-i586 - makefiles/sun/xawt/ToBin.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/sql/SQLPermission.java ! src/share/classes/java/util/PropertyPermission.java ! src/share/classes/javax/net/ssl/SSLPermission.java - src/share/classes/sun/net/www/protocol/gopher/GopherClient.java - src/share/classes/sun/net/www/protocol/gopher/Handler.java Changeset: d7ed56d57d97 Author: mullan Date: 2012-11-26 08:34 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d7ed56d57d97 Merge Changeset: c2e80176a697 Author: mduigou Date: 2012-11-26 15:08 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c2e80176a697 8001634: Initial set of functional interface types Summary: Add the core functional interfaces used by the JSR335 libraries. Reviewed-by: dholmes, briangoetz, darcy ! make/docs/CORE_PKGS.gmk ! make/java/java/Makefile + src/share/classes/java/util/function/BinaryOperator.java + src/share/classes/java/util/function/Block.java + src/share/classes/java/util/function/DoubleBinaryOperator.java + src/share/classes/java/util/function/DoubleBlock.java + src/share/classes/java/util/function/DoubleFunction.java + src/share/classes/java/util/function/DoubleSupplier.java + src/share/classes/java/util/function/DoubleUnaryOperator.java + src/share/classes/java/util/function/Function.java + src/share/classes/java/util/function/IntBinaryOperator.java + src/share/classes/java/util/function/IntBlock.java + src/share/classes/java/util/function/IntFunction.java + src/share/classes/java/util/function/IntSupplier.java + src/share/classes/java/util/function/IntUnaryOperator.java + src/share/classes/java/util/function/LongBinaryOperator.java + src/share/classes/java/util/function/LongBlock.java + src/share/classes/java/util/function/LongFunction.java + src/share/classes/java/util/function/LongSupplier.java + src/share/classes/java/util/function/LongUnaryOperator.java + src/share/classes/java/util/function/Predicate.java + src/share/classes/java/util/function/Supplier.java + src/share/classes/java/util/function/UnaryOperator.java + src/share/classes/java/util/function/package-info.java Changeset: ddf97baea570 Author: chegar Date: 2012-11-27 17:15 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ddf97baea570 8003833: Spurious NPE from Socket.getIn/OutputStream Reviewed-by: alanb, dsamersoff ! src/share/classes/java/net/AbstractPlainSocketImpl.java + test/java/net/Socket/Streams.java Changeset: 40311b5f478f Author: robm Date: 2012-11-28 00:47 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/40311b5f478f 8003597: TEST_BUG: Eliminate dependency on javaweb from closed net tests Reviewed-by: chegar + test/java/net/ResponseCache/Test.java + test/java/net/Socket/B6210227.java Changeset: 39b25d5880c6 Author: sherman Date: 2012-11-27 21:51 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/39b25d5880c6 4235519: Make sun.misc.BASE64{De,En}coder classes public Summary: to add java.util.Base64 Reviewed-by: alanb, mduigou ! make/java/java/FILES_java.gmk Changeset: c6ed2c238d4f Author: sherman Date: 2012-11-27 22:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c6ed2c238d4f 8004088: hg push for bug#4235519 failed to push all files Summary: pushed all base64 files Reviewed-by: alanb, mduigou + src/share/classes/java/util/Base64.java + test/java/util/Base64/TestBase64.java + test/java/util/Base64/TestBase64Golden.java + test/java/util/Base64/baseEncode.txt + test/java/util/Base64/mimeEncode.txt + test/java/util/Base64/plain.txt + test/java/util/Base64/urlEncode.txt Changeset: 46c627801490 Author: xuelei Date: 2012-11-28 05:18 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/46c627801490 8004019: Removes unused method HandshakeHash.setCertificateVerifyAlg() Summary: certification verification in HandshakeHash was abandoned during TLS 1.2 implementation Reviewed-by: xuelei, weijun Contributed-by: Florian Weimer ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/HandshakeHash.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/MAC.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java ! src/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java Changeset: 735b93462eed Author: jfranck Date: 2012-11-28 09:21 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/735b93462eed 7154390: Add support for repeating annotations in j.l.r.AnnotatedElement Reviewed-by: darcy ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/annotation/ContainedBy.java ! src/share/classes/java/lang/annotation/ContainerFor.java + src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java ! src/share/classes/java/lang/reflect/AccessibleObject.java ! src/share/classes/java/lang/reflect/AnnotatedElement.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/reflect/annotation/AnnotationParser.java + src/share/classes/sun/reflect/annotation/AnnotationSupport.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java + test/java/lang/annotation/repeatingAnnotations/RepeatedUnitTest.java + test/java/lang/annotation/repeatingAnnotations/subpackage/Containee.java + test/java/lang/annotation/repeatingAnnotations/subpackage/Container.java + test/java/lang/annotation/repeatingAnnotations/subpackage/InheritedContainee.java + test/java/lang/annotation/repeatingAnnotations/subpackage/InheritedContainer.java + test/java/lang/annotation/repeatingAnnotations/subpackage/InheritedNonRepeated.java + test/java/lang/annotation/repeatingAnnotations/subpackage/NonRepeated.java + test/java/lang/annotation/repeatingAnnotations/subpackage/package-info.java Changeset: 3b6a2fe6d75c Author: dfuchs Date: 2012-11-28 15:14 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3b6a2fe6d75c 8003476: Cleanup warnings in com.sun.jmx.snmp code Reviewed-by: alanb, smarks ! src/share/classes/com/sun/jmx/snmp/EnumRowStatus.java ! src/share/classes/com/sun/jmx/snmp/Enumerated.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/AclImpl.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/JDMAclBlock.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/JDMInformBlock.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/JDMTrapBlock.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/JJTParserState.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/Parser.java ! src/share/classes/com/sun/jmx/snmp/IPAcl/SnmpAcl.java ! src/share/classes/com/sun/jmx/snmp/InetAddressAcl.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpErrorHandlerAgent.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpGenericObjectServer.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpIndex.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMib.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibAgent.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibGroup.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibOid.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibRequest.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibRequestImpl.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibSubRequest.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpMibTable.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpRequestTree.java ! src/share/classes/com/sun/jmx/snmp/agent/SnmpStandardObjectServer.java ! src/share/classes/com/sun/jmx/snmp/daemon/CommunicatorServer.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpAdaptorServer.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpAdaptorServerMBean.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpMibTree.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpSubBulkRequestHandler.java ! src/share/classes/com/sun/jmx/snmp/defaults/SnmpProperties.java ! src/share/classes/com/sun/jmx/snmp/tasks/ThreadService.java ! src/share/classes/sun/management/snmp/AdaptorBootstrap.java Changeset: 262b3b2f3aa3 Author: dfuchs Date: 2012-11-28 10:08 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/262b3b2f3aa3 Merge Changeset: 09bef1e118e3 Author: mchung Date: 2012-11-28 10:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/09bef1e118e3 8003851: MethodHandleNatives dependency on java.sql.DriverManager Reviewed-by: alanb, dholmes ! src/share/classes/java/lang/invoke/MethodHandleNatives.java Changeset: 80ddee59a21d Author: mchung Date: 2012-11-28 10:50 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/80ddee59a21d 8003869: Eliminate java.lang.invoke.InnerClassLambdaMetafactory dependency on java.util.logging Reviewed-by: alanb, dholmes ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java Changeset: 13ec794734f5 Author: michaelm Date: 2012-11-29 09:41 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/13ec794734f5 7200720: crash in net.dll during NTLM authentication Reviewed-by: chegar, dsamersoff ! make/java/net/Makefile ! src/windows/classes/sun/net/www/protocol/http/ntlm/NTLMAuthSequence.java ! src/windows/classes/sun/net/www/protocol/http/ntlm/NTLMAuthentication.java ! src/windows/native/sun/net/www/protocol/http/ntlm/NTLMAuthSequence.c Changeset: ba5eabd6a37b Author: michaelm Date: 2012-11-29 09:47 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ba5eabd6a37b Merge Changeset: 2b829a5a46ee Author: jgish Date: 2012-11-29 12:28 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2b829a5a46ee 8003380: Compiler warnings in logging test code Summary: Use generics, suppress warnings where appropriate, remove unused imports, etc. Reviewed-by: lancea, chegar ! test/java/util/logging/ClassLoaderLeakTest.java ! test/java/util/logging/Listeners.java ! test/java/util/logging/ListenersWithSM.java ! test/java/util/logging/LoggerResourceBundleRace.java ! test/java/util/logging/LoggingDeadlock2.java ! test/java/util/logging/LoggingDeadlock3.java ! test/java/util/logging/LoggingDeadlock4.java ! test/java/util/logging/LoggingMXBeanTest.java ! test/java/util/logging/LoggingMXBeanTest2.java ! test/java/util/logging/MemoryHandlerTest.java ! test/java/util/logging/ParentLoggersTest.java ! test/java/util/logging/SimpleFormatterFormat.java Changeset: d91e6cb1da41 Author: shade Date: 2012-11-29 17:03 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d91e6cb1da41 8004141: UnsafeStaticFieldAccessorImpl#base should be final Reviewed-by: chegar, alanb Contributed-by: peter.levart at gmail.com ! src/share/classes/sun/reflect/UnsafeStaticFieldAccessorImpl.java Changeset: bf6ceb6b8f80 Author: mduigou Date: 2012-11-29 14:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bf6ceb6b8f80 7175464: entrySetView field is never updated in NavigableSubMap Summary: The method entrySet() in AscendingSubMap and DescendingSubMap failed to cache the entrySetView. Reviewed-by: alanb, psandoz ! src/share/classes/java/util/TreeMap.java Changeset: 75cb07a7b622 Author: mduigou Date: 2012-11-29 14:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/75cb07a7b622 6553074: String{Buffer,Builder}.indexOf(Str, int) contains unnecessary allocation Summary: It is not necessary to extract the value array with toCharArray. The value array can now be used directly. Reviewed-by: alanb ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/String.java Changeset: 83d9f30ebeed Author: smarks Date: 2012-11-28 17:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/83d9f30ebeed 8004131: move jdi tests out of core testset Reviewed-by: alanb, chegar ! make/jprt.properties Changeset: 7ccf93c60c4d Author: smarks Date: 2012-11-29 14:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7ccf93c60c4d 8004134: More ProblemList.txt updates (11/2012) Reviewed-by: alanb Contributed-by: amy.lu at oracle.com ! test/ProblemList.txt Changeset: 55f8ddc2f9c6 Author: sla Date: 2012-11-30 08:17 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/55f8ddc2f9c6 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo Reviewed-by: okutsu ! test/java/util/TimeZone/Bug6912560.java Changeset: e988de7465d4 Author: zhangshj Date: 2012-11-30 17:24 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e988de7465d4 8004211: Remove unused dlinfo local variable in launcher code Reviewed-by: alanb ! src/solaris/bin/java_md_solinux.c Changeset: 72d3d07b625d Author: alanb Date: 2012-11-30 11:18 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/72d3d07b625d 8003949: LogManager, downgrade normative reference to ${java.home}/lib/logging.properties Reviewed-by: psandoz, mchung ! src/share/classes/java/util/logging/LogManager.java Changeset: c370048be8fc Author: alanb Date: 2012-11-30 16:29 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c370048be8fc 7165762: (aio) Default thread pool should be configured so that threads terminated after a timeout period Reviewed-by: chegar ! src/share/classes/sun/nio/ch/ThreadPool.java Changeset: e7edb0da9c6a Author: jfranck Date: 2012-11-30 09:47 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e7edb0da9c6a 8004110: Remove debug code form sun/reflect/annotation/AnnotationSupport.java Reviewed-by: jjg, darcy ! src/share/classes/sun/reflect/annotation/AnnotationSupport.java Changeset: 43d2e02c4098 Author: khazra Date: 2012-11-30 12:00 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/43d2e02c4098 7197662: (prefs) java/util/prefs/AddNodeChangeListener.java fails by timeout or by "couldn't get file lock" Summary: Set -Djava.util.prefs.userRoot to current working directory of user in the prefs tests Reviewed-by: alanb, chegar, weijun, dxu ! test/java/util/prefs/AddNodeChangeListener.java ! test/java/util/prefs/CheckUserPrefsStorage.sh ! test/java/util/prefs/CommentsInXml.java ! test/java/util/prefs/ConflictInFlush.java ! test/java/util/prefs/ExportNode.java ! test/java/util/prefs/ExportSubtree.java ! test/java/util/prefs/PrefsSpi.sh ! test/java/util/prefs/RemoveNullKeyCheck.java ! test/java/util/prefs/RemoveReadOnlyNode.java ! test/java/util/prefs/RemoveUnregedListener.java Changeset: e66ec5b8c15e Author: lana Date: 2012-11-30 16:33 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e66ec5b8c15e Merge Changeset: fd8ba2d8baec Author: sherman Date: 2012-12-01 11:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/fd8ba2d8baec 8004212: java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written Summary: to return the length instead of position Reviewed-by: alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java Changeset: f657adf4fe78 Author: alanb Date: 2012-12-02 16:37 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f657adf4fe78 8003846: Override mechanism for currency data should not require creating currency.properties in java.home Reviewed-by: naoto ! src/share/classes/java/util/Currency.java ! test/java/util/Currency/PropertiesTest.java ! test/java/util/Currency/PropertiesTest.sh Changeset: 60550cd2b527 Author: dholmes Date: 2012-12-02 19:16 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/60550cd2b527 7200297: agent code does not handle multiple boot library path elements correctly Summary: When bug 6819213 was fixed it enabled sun.boot.library.path property to contain multiple paths. Code in agents does not handle multiple paths when attempting to find dependent shared libs. Reviewed-by: dholmes, sspitsyn, dsamersoff Contributed-by: Bill Pittore ! src/share/back/debugInit.c ! src/share/back/error_messages.c ! src/share/back/transport.c ! src/share/demo/jvmti/hprof/hprof.h ! src/share/demo/jvmti/hprof/hprof_init.c ! src/solaris/back/linker_md.c ! src/solaris/demo/jvmti/hprof/hprof_md.c ! src/solaris/npt/npt_md.h ! src/windows/back/linker_md.c ! src/windows/demo/jvmti/hprof/hprof_md.c ! src/windows/npt/npt_md.h Changeset: a42da685dfca Author: weijun Date: 2012-12-03 17:14 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a42da685dfca 7198507: [TEST_BUG] sun/security/tools/keytool/console.sh should be rewritten Reviewed-by: xuelei ! test/sun/security/tools/keytool/console.sh Changeset: ead651efb271 Author: xuelei Date: 2012-12-03 06:00 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ead651efb271 8004184: security tests leave JSSEServer running Summary: Use othervm mode to release resources, and correct the system properties issues in JSSE Reviewed-by: chegar ! test/sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java Changeset: ee9846f351d7 Author: mullan Date: 2012-12-03 11:07 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ee9846f351d7 7199143: RFE: OCSP revocation checker should provide possibility to specify connection timeout Summary: Added com.sun.security.ocsp.timeout system property to control timeout Reviewed-by: mullan, vinnie Contributed-by: jason.uh at oracle.com ! src/share/classes/sun/security/provider/certpath/OCSP.java Changeset: 38ec2838dd86 Author: dxu Date: 2012-12-04 14:07 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/38ec2838dd86 7142921: (fs) Files.probeContentType reports a MIME type of "text/plain" on Ubuntu 11.04 7144997: (fs) Files.probeContentType returns null on Solaris 64-bit Reviewed-by: alanb, mduigou ! make/java/nio/Makefile ! make/java/nio/mapfile-linux ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/mapfiles/libnio/mapfile-linux ! src/solaris/classes/sun/nio/fs/BsdFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/LinuxFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/MacOSXFileSystemProvider.java + src/solaris/classes/sun/nio/fs/MagicFileTypeDetector.java + src/solaris/classes/sun/nio/fs/MimeTypesFileTypeDetector.java ! src/solaris/classes/sun/nio/fs/SolarisFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/UnixFileSystemProvider.java + src/solaris/native/sun/nio/fs/MagicFileTypeDetector.c Changeset: 2e8863c4f7d0 Author: kmo Date: 2012-12-04 15:10 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2e8863c4f7d0 8004066: TEST_BUG: test/java/lang/Math/DivModTests.java assumes ArithmeticException message Reviewed-by: twisti, alanb, dholmes ! test/java/lang/Math/DivModTests.java Changeset: 87028eb3f020 Author: lana Date: 2012-12-04 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/87028eb3f020 Merge Changeset: b68a5404de60 Author: lana Date: 2012-12-10 20:58 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b68a5404de60 Merge ! makefiles/CompileJavaClasses.gmk - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: 379e3dfa521d Author: erikj Date: 2012-12-06 12:09 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/379e3dfa521d 8004104: build-infra: Minor cleanup Reviewed-by: ohrstrom, tbell ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk Changeset: 2689f6cfe835 Author: erikj Date: 2012-12-11 12:27 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2689f6cfe835 8001753: build-infra: mismatch with full debug symbol control for hotspot Summary: Changing boolean values of ENABLE_DEBUG_SYMBOLS. Reviewed-by: dholmes, ohair ! makefiles/CompileNativeLibraries.gmk Changeset: 53fb43e4d614 Author: katleman Date: 2012-12-12 13:21 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/53fb43e4d614 Merge ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk Changeset: 7fd56a5abd94 Author: katleman Date: 2012-12-13 09:05 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7fd56a5abd94 Added tag jdk8-b68 for changeset 53fb43e4d614 ! .hgtags Changeset: fd9e6b4c8488 Author: lana Date: 2012-12-14 11:21 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/fd9e6b4c8488 Merge Changeset: c69424f78060 Author: serb Date: 2012-12-11 19:45 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c69424f78060 7154778: [macosx] NSView-based implementation of sun.awt.EmbeddedFrame Summary: The new implementation of EmbeddedFrame to support SWT_AWT Bridge Reviewed-by: anthony, serb, leonidr Contributed-by: Petr Pchelko ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CMouseInfoPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPrinterDialogPeer.java + src/macosx/classes/sun/lwawt/macosx/CViewEmbeddedFrame.java + src/macosx/classes/sun/lwawt/macosx/CViewPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CWrapper.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/AWTSurfaceLayers.m ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/CCursorManager.m ! src/macosx/native/sun/awt/CWrapper.m ! src/macosx/native/sun/awt/awt.m ! src/macosx/native/sun/java2d/opengl/CGLLayer.m ! src/macosx/native/sun/osxapp/ThreadUtilities.h ! src/macosx/native/sun/osxapp/ThreadUtilities.m Changeset: e016ad35a764 Author: kshefov Date: 2012-12-13 15:14 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e016ad35a764 7132385: [macosx] IconifyTest of RepaintManager could use some delay Reviewed-by: serb, alexsch + test/javax/swing/RepaintManager/IconifyTest/IconifyTest.java Changeset: 71e03e17c183 Author: kshefov Date: 2012-12-14 13:32 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/71e03e17c183 6757986: javax/swing/JInternalFrame/5066752/bug5066752.java needs correction Reviewed-by: serb, alexsch + test/javax/swing/JInternalFrame/5066752/bug5066752.java Changeset: 9fc7460ca3ac Author: lana Date: 2012-12-14 11:22 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9fc7460ca3ac Merge Changeset: 7004848974a2 Author: jgish Date: 2012-12-04 20:21 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7004848974a2 8003596: TEST_BUG: java/util/logging/CheckLockLocationTest.java failing [win] Reviewed-by: alanb ! test/ProblemList.txt ! test/java/util/logging/CheckLockLocationTest.java Changeset: 44ae777564eb Author: mullan Date: 2012-12-04 17:40 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/44ae777564eb 8004188: Rename src/share/lib/security/java.security to java.security-linux Reviewed-by: mullan, mchung Contributed-by: jason.uh at oracle.com ! make/java/security/Makefile - src/share/lib/security/java.security + src/share/lib/security/java.security-linux Changeset: b54a5b7d2e65 Author: alanb Date: 2012-12-05 12:20 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b54a5b7d2e65 8004491: Build breakage on Linux due to 8004188 Reviewed-by: chegar, erikj ! makefiles/CopyFiles.gmk Changeset: a971516029ab Author: jgish Date: 2012-12-05 21:08 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a971516029ab 8004317: TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported Reviewed-by: alanb, dmocek, smarks ! test/java/rmi/testlibrary/TestLibrary.java Changeset: 41a1b110f34d Author: lancea Date: 2012-12-06 15:51 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/41a1b110f34d 8004374: CachedRowSetSwriter.writeData reports wrong number of conflicts in SyncProviderException Reviewed-by: naoto ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java Changeset: 896d4af2ebfd Author: rfield Date: 2012-12-06 21:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/896d4af2ebfd 8003881: Prevent lambda implementing inner classes from allowing the creation of new instances Summary: Lambda implementing inner classes now has private constructor (thanks Kumar) Reviewed-by: ksrini ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java + test/java/lang/invoke/lambda/LambdaAccessControlDoPrivilegedTest.java + test/java/lang/invoke/lambda/LambdaAccessControlTest.java Changeset: da387f0cecb7 Author: ksrini Date: 2012-12-09 07:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/da387f0cecb7 8004042: Arrrghs.java test failed on windows with access error. Reviewed-by: smarks, jjh, ksrini Contributed-by: david.dehaven at oracle.com ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/TestHelper.java Changeset: 343615aa0539 Author: dxu Date: 2012-12-09 19:13 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/343615aa0539 7194370: (fs) WatchService fails if volume S/N is 0 [win] Reviewed-by: alanb, forax ! src/windows/classes/sun/nio/fs/WindowsFileAttributes.java Changeset: fda257689786 Author: okutsu Date: 2012-12-10 10:52 +0900 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/fda257689786 8000983: Support narrow display names for calendar fields 8003267: Support generic time zone names in TimeZoneNameProvider (SPI) Reviewed-by: naoto ! make/tools/src/build/tools/cldrconverter/Bundle.java ! make/tools/src/build/tools/cldrconverter/BundleGenerator.java ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java ! make/tools/src/build/tools/cldrconverter/LDMLParseHandler.java ! make/tools/src/build/tools/cldrconverter/MetaZonesParseHandler.java ! make/tools/src/build/tools/cldrconverter/ResourceBundleGenerator.java ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/spi/CalendarNameProvider.java ! src/share/classes/java/util/spi/TimeZoneNameProvider.java ! src/share/classes/sun/text/resources/FormatData.java ! src/share/classes/sun/text/resources/ar/FormatData_ar.java ! src/share/classes/sun/text/resources/be/FormatData_be.java ! src/share/classes/sun/text/resources/bg/FormatData_bg.java ! src/share/classes/sun/text/resources/ca/FormatData_ca.java ! src/share/classes/sun/text/resources/cs/FormatData_cs.java ! src/share/classes/sun/text/resources/da/FormatData_da.java ! src/share/classes/sun/text/resources/de/FormatData_de.java ! src/share/classes/sun/text/resources/el/FormatData_el.java ! src/share/classes/sun/text/resources/es/FormatData_es.java ! src/share/classes/sun/text/resources/et/FormatData_et.java ! src/share/classes/sun/text/resources/fi/FormatData_fi.java ! src/share/classes/sun/text/resources/fr/FormatData_fr.java ! src/share/classes/sun/text/resources/hi/FormatData_hi_IN.java ! src/share/classes/sun/text/resources/hr/FormatData_hr.java ! src/share/classes/sun/text/resources/hu/FormatData_hu.java ! src/share/classes/sun/text/resources/is/FormatData_is.java ! src/share/classes/sun/text/resources/it/FormatData_it.java ! src/share/classes/sun/text/resources/iw/FormatData_iw.java ! src/share/classes/sun/text/resources/ja/FormatData_ja.java ! src/share/classes/sun/text/resources/ko/FormatData_ko.java ! src/share/classes/sun/text/resources/lt/FormatData_lt.java ! src/share/classes/sun/text/resources/lv/FormatData_lv.java ! src/share/classes/sun/text/resources/mk/FormatData_mk.java ! src/share/classes/sun/text/resources/ms/FormatData_ms.java ! src/share/classes/sun/text/resources/mt/FormatData_mt.java ! src/share/classes/sun/text/resources/nl/FormatData_nl.java ! src/share/classes/sun/text/resources/pl/FormatData_pl.java ! src/share/classes/sun/text/resources/pt/FormatData_pt.java ! src/share/classes/sun/text/resources/ro/FormatData_ro.java ! src/share/classes/sun/text/resources/ru/FormatData_ru.java ! src/share/classes/sun/text/resources/sk/FormatData_sk.java ! src/share/classes/sun/text/resources/sl/FormatData_sl.java ! src/share/classes/sun/text/resources/sq/FormatData_sq.java ! src/share/classes/sun/text/resources/sr/FormatData_sr.java ! src/share/classes/sun/text/resources/sv/FormatData_sv.java ! src/share/classes/sun/text/resources/th/FormatData_th.java ! src/share/classes/sun/text/resources/tr/FormatData_tr.java ! src/share/classes/sun/text/resources/uk/FormatData_uk.java ! src/share/classes/sun/text/resources/vi/FormatData_vi.java ! src/share/classes/sun/text/resources/zh/FormatData_zh.java ! src/share/classes/sun/util/cldr/CLDRLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java ! src/share/classes/sun/util/locale/provider/SPILocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java ! src/share/classes/sun/util/resources/LocaleData.java ! src/share/classes/sun/util/resources/OpenListResourceBundle.java ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java + test/java/util/Calendar/GenericTimeZoneNamesTest.java + test/java/util/Calendar/GenericTimeZoneNamesTest.sh + test/java/util/Calendar/NarrowNamesTest.java + test/java/util/Calendar/NarrowNamesTest.sh ! test/java/util/PluggableLocale/GenericTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.sh ! test/java/util/PluggableLocale/barprovider.jar + test/java/util/PluggableLocale/providersrc/GenericTimeZoneNameProviderImpl.java ! test/java/util/PluggableLocale/providersrc/Makefile ! test/java/util/PluggableLocale/providersrc/java.util.spi.TimeZoneNameProvider ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: fda2b2b5b98b Author: michaelm Date: 2012-12-10 14:56 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/fda2b2b5b98b 8003948: NTLM/Negotiate authentication problem Reviewed-by: chegar, weijun ! src/share/classes/sun/net/www/MessageHeader.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/MessageHeaderTest.java Changeset: cac1bfaceaaa Author: mchung Date: 2012-12-10 15:15 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cac1bfaceaaa 4819681: Typo in http://java.sun.com/j2se/1.4.1/docs/api/java/util/logging/LogManager.html Summary: Simple capitalization typo in LogManager() description Reviewed-by: darcy, mchung ! src/share/classes/java/util/logging/LogManager.java Changeset: 883feced1cdd Author: dingxmin Date: 2012-12-11 10:42 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/883feced1cdd 6512101: Incorrect encoding in NetworkInterface.getDisplayName() Reviewed-by: chegar, dsamersoff ! src/windows/native/java/net/NetworkInterface.c Changeset: d206e52bf8a6 Author: weijun Date: 2012-12-11 13:14 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d206e52bf8a6 8004488: wrong permissions checked in krb5 Reviewed-by: xuelei ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java ! src/share/classes/sun/security/jgss/krb5/Krb5Util.java + test/sun/security/krb5/auto/KeyPermissions.java ! test/sun/security/krb5/auto/KeyTabCompat.java Changeset: c4bd81de2868 Author: akhil Date: 2012-12-11 15:33 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c4bd81de2868 8003246: Add InitialValue Supplier to ThreadLocal Reviewed-by: mduigou, forax, dl, chegar, briangoetz ! src/share/classes/java/lang/ThreadLocal.java + test/java/lang/ThreadLocal/ThreadLocalSupplierTest.java Changeset: 6c795437f212 Author: mduigou Date: 2012-12-11 20:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6c795437f212 8004905: Correct license of test to remove classpath exception Reviewed-by: akhil ! test/java/lang/ThreadLocal/ThreadLocalSupplierTest.java Changeset: 12fba0974a9d Author: weijun Date: 2012-12-12 18:39 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/12fba0974a9d 8004904: Makefile for ntlm Reviewed-by: erikj, chegar ! make/com/sun/security/Makefile + make/com/sun/security/ntlm/Makefile Changeset: 806cf26e5063 Author: chegar Date: 2012-12-12 11:35 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/806cf26e5063 8004921: Trivial javadoc warnings in Base64 Reviewed-by: darcy ! src/share/classes/java/util/Base64.java Changeset: 81640e75c7a7 Author: alanb Date: 2012-12-12 13:03 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/81640e75c7a7 8004874: Reduce dependency on java.beans to only add/removePropertyChangeListener Reviewed-by: ksrini, mchung, dholmes ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java ! src/share/classes/java/util/logging/LogManager.java Changeset: 346c0af4af41 Author: mullan Date: 2012-12-12 09:25 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/346c0af4af41 8004064: Downgrade normative references to ${java.home}/lib/security/java.security Reviewed-by: alanb, vinnie, xuelei ! src/share/classes/com/sun/net/ssl/KeyManagerFactory.java ! src/share/classes/com/sun/net/ssl/TrustManagerFactory.java ! src/share/classes/com/sun/security/auth/PolicyFile.java ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/java/net/doc-files/net-properties.html ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/Policy.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/cert/CertPathBuilder.java ! src/share/classes/java/security/cert/CertPathValidator.java ! src/share/classes/java/security/cert/CertStore.java ! src/share/classes/javax/net/ssl/KeyManagerFactory.java ! src/share/classes/javax/net/ssl/TrustManagerFactory.java ! src/share/classes/javax/security/auth/Policy.java ! src/share/classes/javax/security/auth/callback/CallbackHandler.java ! src/share/classes/javax/security/auth/login/Configuration.java ! src/share/classes/javax/security/auth/login/LoginContext.java ! src/share/classes/javax/security/cert/X509Certificate.java Changeset: c7f86908d5fd Author: mullan Date: 2012-12-12 09:27 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c7f86908d5fd Merge - src/share/lib/security/java.security Changeset: 68374c6e65c1 Author: robm Date: 2012-12-12 15:57 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/68374c6e65c1 8004337: java/sql tests aren't run in test/Makefile Reviewed-by: lancea, alanb ! test/Makefile Changeset: bd84d0927a2e Author: smarks Date: 2012-12-12 09:53 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bd84d0927a2e 8004748: clean up @build tags in RMI tests Reviewed-by: alanb, darcy, mchung ! test/java/rmi/MarshalledObject/compare/Compare.java ! test/java/rmi/MarshalledObject/compare/HashCode.java ! test/java/rmi/MarshalledObject/compare/NullReference.java ! test/java/rmi/Naming/DefaultRegistryPort.java ! test/java/rmi/Naming/LookupIPv6.java ! test/java/rmi/Naming/RmiIsNoScheme.java ! test/java/rmi/Naming/UnderscoreHost.java ! test/java/rmi/Naming/legalRegistryNames/LegalRegistryNames.java ! test/java/rmi/RMISecurityManager/checkPackageAccess/CheckPackageAccess.java ! test/java/rmi/activation/Activatable/checkActivateRef/CheckActivateRef.java ! test/java/rmi/activation/Activatable/checkAnnotations/CheckAnnotations.java ! test/java/rmi/activation/Activatable/checkImplClassLoader/CheckImplClassLoader.java ! test/java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java ! test/java/rmi/activation/Activatable/createPrivateActivable/CreatePrivateActivatable.java ! test/java/rmi/activation/Activatable/downloadParameterClass/DownloadParameterClass.java ! test/java/rmi/activation/Activatable/elucidateNoSuchMethod/ElucidateNoSuchMethod.java ! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh ! test/java/rmi/activation/Activatable/forceLogSnapshot/ForceLogSnapshot.java ! test/java/rmi/activation/Activatable/inactiveGroup/InactiveGroup.java ! test/java/rmi/activation/Activatable/lookupActivationSystem/LookupActivationSystem.java ! test/java/rmi/activation/Activatable/nestedActivate/NestedActivate.java ! test/java/rmi/activation/Activatable/nonExistentActivatable/NonExistentActivatable.java ! test/java/rmi/activation/Activatable/restartCrashedService/RestartCrashedService.java ! test/java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java ! test/java/rmi/activation/Activatable/restartService/RestartService.java ! test/java/rmi/activation/Activatable/shutdownGracefully/ShutdownGracefully.java ! test/java/rmi/activation/Activatable/unregisterInactive/UnregisterInactive.java ! test/java/rmi/activation/ActivateFailedException/activateFails/ActivateFails.java ! test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup.java ! test/java/rmi/activation/ActivationGroupDesc/checkDefaultGroupName/CheckDefaultGroupName.java ! test/java/rmi/activation/ActivationSystem/activeGroup/IdempotentActiveGroup.java ! test/java/rmi/activation/ActivationSystem/modifyDescriptor/ModifyDescriptor.java ! test/java/rmi/activation/ActivationSystem/stubClassesPermitted/StubClassesPermitted.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup.java ! test/java/rmi/activation/CommandEnvironment/NullOptions.java ! test/java/rmi/activation/CommandEnvironment/SetChildEnv.java ! test/java/rmi/activation/checkusage/CheckUsage.java ! test/java/rmi/activation/log/LogTest.java ! test/java/rmi/activation/rmidViaInheritedChannel/InheritedChannelNotServerSocket.java ! test/java/rmi/activation/rmidViaInheritedChannel/RmidViaInheritedChannel.java ! test/java/rmi/dgc/VMID/CheckVMID.java ! test/java/rmi/dgc/dgcAckFailure/DGCAckFailure.java ! test/java/rmi/dgc/dgcImplInsulation/DGCImplInsulation.java ! test/java/rmi/dgc/retryDirtyCalls/RetryDirtyCalls.java ! test/java/rmi/invalidName/InvalidName.java ! test/java/rmi/registry/altSecurityManager/AltSecurityManager.java ! test/java/rmi/registry/checkusage/CheckUsage.java ! test/java/rmi/registry/classPathCodebase/ClassPathCodebase.java ! test/java/rmi/registry/interfaceHash/InterfaceHash.java ! test/java/rmi/registry/multipleRegistries/MultipleRegistries.java ! test/java/rmi/registry/readTest/readTest.sh ! test/java/rmi/registry/reexport/Reexport.java ! test/java/rmi/reliability/benchmark/runRmiBench.sh ! test/java/rmi/reliability/benchmark/runSerialBench.sh ! test/java/rmi/reliability/juicer/AppleUserImpl.java ! test/java/rmi/server/ObjID/randomIDs/RandomIDs.java ! test/java/rmi/server/RMIClassLoader/delegateBeforePermissionCheck/DelegateBeforePermissionCheck.java ! test/java/rmi/server/RMIClassLoader/delegateToContextLoader/DelegateToContextLoader.java ! test/java/rmi/server/RMIClassLoader/downloadArrayClass/DownloadArrayClass.java ! test/java/rmi/server/RMIClassLoader/getClassAnnotation/NullClass.java ! test/java/rmi/server/RMIClassLoader/getClassLoader/GetClassLoader.java ! test/java/rmi/server/RMIClassLoader/loadProxyClasses/LoadProxyClasses.java ! test/java/rmi/server/RMIClassLoader/noSecurityManager/NoSecurityManager.java ! test/java/rmi/server/RMIClassLoader/spi/ContextInsulation.java ! test/java/rmi/server/RMIClassLoader/spi/DefaultProperty.java ! test/java/rmi/server/RMIClassLoader/spi/Installed.java ! test/java/rmi/server/RMIClassLoader/spi/InvalidProperty.java ! test/java/rmi/server/RMIClassLoader/spi/Property.java ! test/java/rmi/server/RMIClassLoader/useCodebaseOnly/UseCodebaseOnly.java ! test/java/rmi/server/RMIClassLoader/useGetURLs/UseGetURLs.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/activatable/UseCustomSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/registry/UseCustomSocketFactory.java ! test/java/rmi/server/RMISocketFactory/useSocketFactory/unicast/UseCustomSocketFactory.java ! test/java/rmi/server/RemoteObject/notExtending/NotExtending.java ! test/java/rmi/server/RemoteObject/verifyRemoteEquals/VerifyRemoteEquals.java ! test/java/rmi/server/RemoteServer/AddrInUse.java ! test/java/rmi/server/UnicastRemoteObject/changeHostName/ChangeHostName.java ! test/java/rmi/server/UnicastRemoteObject/exportObject/GcDuringExport.java ! test/java/rmi/server/UnicastRemoteObject/keepAliveDuringCall/KeepAliveDuringCall.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport.java ! test/java/rmi/server/UnicastRemoteObject/marshalAfterUnexport/MarshalAfterUnexport2.java ! test/java/rmi/server/UnicastRemoteObject/unexportObject/UnexportLeak.java ! test/java/rmi/server/Unmarshal/PrimitiveClasses.java + test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshal.java ! test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshalOnStopThread.java - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java ! test/java/rmi/server/Unreferenced/finiteGCLatency/FiniteGCLatency.java ! test/java/rmi/server/Unreferenced/leaseCheckInterval/LeaseCheckInterval.java ! test/java/rmi/server/Unreferenced/marshalledObjectGet/MarshalledObjectGet.java ! test/java/rmi/server/Unreferenced/unreferencedContext/UnreferencedContext.java ! test/java/rmi/server/clientStackTrace/ClientStackTrace.java ! test/java/rmi/server/getRemoteClass/GetRemoteClass.java ! test/java/rmi/server/serverStackTrace/ServerStackTrace.java ! test/java/rmi/server/serverStackTrace/SuppressStackTraces.java ! test/java/rmi/server/useCustomRef/UseCustomRef.java ! test/java/rmi/transport/acceptLoop/CloseServerSocketOnTermination.java ! test/java/rmi/transport/checkFQDN/CheckFQDN.java ! test/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java ! test/java/rmi/transport/closeServerSocket/CloseServerSocket.java ! test/java/rmi/transport/dgcDeadLock/DGCDeadLock.java ! test/java/rmi/transport/handshakeFailure/HandshakeFailure.java ! test/java/rmi/transport/handshakeTimeout/HandshakeTimeout.java ! test/java/rmi/transport/httpSocket/HttpSocketTest.java ! test/java/rmi/transport/rapidExportUnexport/RapidExportUnexport.java ! test/java/rmi/transport/readTimeout/ReadTimeoutTest.java ! test/java/rmi/transport/reuseDefaultPort/ReuseDefaultPort.java ! test/java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak.java ! test/javax/rmi/ssl/SocketFactoryTest.java ! test/sun/rmi/log/ReliableLog/LogAlignmentTest.java ! test/sun/rmi/log/ReliableLog/SnapshotSize.java ! test/sun/rmi/rmic/RMIGenerator/RmicDefault.java ! test/sun/rmi/rmic/newrmic/equivalence/run.sh ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java ! test/sun/rmi/runtime/Log/checkLogging/CheckLogStreams.java ! test/sun/rmi/runtime/Log/checkLogging/CheckLogging.java ! test/sun/rmi/server/MarshalOutputStream/marshalForeignStub/MarshalForeignStub.java ! test/sun/rmi/transport/proxy/EagerHttpFallback.java ! test/sun/rmi/transport/tcp/DeadCachedConnection.java ! test/sun/rmi/transport/tcp/blockAccept/BlockAcceptTest.java ! test/sun/rmi/transport/tcp/disableMultiplexing/DisableMultiplexing.java Changeset: 56fd5479a98f Author: jgish Date: 2012-12-12 15:37 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/56fd5479a98f 8004651: TEST: java/util/logging/CheckLockLocationTest.java failed to delete file (win) Summary: Failure to delete test log file should be a warning instead of test failure Reviewed-by: mduigou, smarks ! test/java/util/logging/CheckLockLocationTest.java Changeset: 5a2ab2c3f106 Author: weijun Date: 2012-12-13 08:11 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5a2ab2c3f106 8004235: Disable native JGSS provider on Mac Reviewed-by: erikj, valeriep ! make/sun/security/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java Changeset: 7a8978a5bb6e Author: lancea Date: 2012-12-12 20:57 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7a8978a5bb6e 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety Reviewed-by: naoto ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/share/classes/javax/sql/rowset/serial/SerialDatalink.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java Changeset: 775b0050144a Author: chegar Date: 2012-12-13 09:55 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/775b0050144a 8004925: java/net/Socks/SocksV4Test.java failing on all platforms Reviewed-by: alanb, dsamersoff ! test/java/net/Socks/SocksV4Test.java Changeset: 682d2d3ccff5 Author: chegar Date: 2012-12-13 14:33 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/682d2d3ccff5 8004675: Inet6Address.getHostAddress should use string scope identifier where available Summary: ...and some minor stylistic cleanup Reviewed-by: khazra, dsamersoff, michaelm ! src/share/classes/java/net/Inet6Address.java ! src/share/native/java/net/Inet6Address.c + test/java/net/Inet6Address/StringScope.java Changeset: c97618a3c8c2 Author: juh Date: 2012-12-13 09:35 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c97618a3c8c2 7193792: sun/security/pkcs11/ec/TestECDSA.java failing intermittently Reviewed-by: vinnie, wetmore ! test/ProblemList.txt ! test/sun/security/pkcs11/ec/TestECDSA.java Changeset: 7b697da6626a Author: mullan Date: 2012-12-13 09:37 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7b697da6626a Merge Changeset: ae5d04dbacd6 Author: chegar Date: 2012-12-13 14:47 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ae5d04dbacd6 8003890: corelibs test scripts should pass TESTVMOPTS Reviewed-by: chegar, alanb Contributed-by: Mark Sheppard ! test/com/oracle/net/sanity.sh ! test/com/sun/corba/cachedSocket/7056731.sh ! test/com/sun/management/OperatingSystemMXBean/TestTotalSwap.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh ! test/com/sun/tools/attach/ApplicationSetup.sh ! test/com/sun/tools/attach/BasicTests.sh ! test/com/sun/tools/attach/PermissionTests.sh ! test/com/sun/tools/attach/ProviderTests.sh ! test/com/sun/tools/extcheck/TestExtcheckArgs.sh ! test/demo/zipfs/basic.sh ! test/java/io/File/GetXSpace.sh ! test/java/io/File/MacPathTest.sh ! test/java/io/File/basic.sh ! test/java/io/FileOutputStream/FileOpen.sh ! test/java/io/Serializable/class/run.sh ! test/java/io/Serializable/evolution/AddedExternField/run.sh ! test/java/io/Serializable/evolution/RenamePackage/run.sh ! test/java/io/Serializable/maskSyntheticModifier/run.sh ! test/java/io/Serializable/packageAccess/run.sh ! test/java/io/Serializable/resolveClass/consTest/run.sh ! test/java/io/Serializable/resolveClass/deserializeButton/run.sh ! test/java/io/Serializable/subclass/run.sh ! test/java/io/Serializable/superclassDataLoss/run.sh ! test/java/io/Serializable/unnamedPackageSwitch/run.sh ! test/java/lang/Class/forName/NonJavaNames.sh ! test/java/lang/ClassLoader/Assert.sh ! test/java/lang/ClassLoader/deadlock/TestCrossDelegate.sh ! test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh ! test/java/lang/ClassLoader/getdotresource.sh ! test/java/lang/Runtime/exec/setcwd.sh ! test/java/lang/StringCoding/CheckEncodings.sh ! test/java/lang/System/finalization/FinExit.sh ! test/java/lang/annotation/loaderLeak/LoaderLeak.sh ! test/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh ! test/java/net/Authenticator/B4933582.sh ! test/java/net/DatagramSocket/SetDatagramSocketImplFactory/ADatagramSocket.sh ! test/java/net/InetAddress/ptr/lookup.sh ! test/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.sh ! test/java/net/Socket/OldSocketImpl.sh ! test/java/net/URL/B5086147.sh ! test/java/net/URL/runconstructor.sh ! test/java/net/URLClassLoader/B5077773.sh ! test/java/net/URLClassLoader/getresourceasstream/test.sh ! test/java/net/URLClassLoader/sealing/checksealed.sh ! test/java/net/URLConnection/6212146/test.sh ! test/java/net/URLConnection/UNCTest.sh ! test/java/nio/Buffer/LimitDirectMemory.sh ! test/java/nio/channels/AsynchronousChannelGroup/run_any_task.sh ! test/java/nio/channels/spi/AsynchronousChannelProvider/custom_provider.sh ! test/java/nio/charset/Charset/default.sh ! test/java/nio/charset/coders/CheckSJISMappingProp.sh ! test/java/nio/charset/spi/basic.sh ! test/java/nio/file/Files/delete_on_close.sh ! test/java/nio/file/Files/walkFileTree/walk_file_tree.sh ! test/java/nio/file/Path/MacPathTest.sh ! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh ! test/java/rmi/registry/readTest/readTest.sh ! test/java/rmi/reliability/benchmark/runSerialBench.sh ! test/java/security/Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh ! test/java/security/Security/ClassLoaderDeadlock/Deadlock.sh ! test/java/security/Security/ClassLoaderDeadlock/Deadlock2.sh ! test/java/security/Security/signedfirst/Dyn.sh ! test/java/security/Security/signedfirst/Static.sh ! test/java/security/cert/CertificateFactory/slowstream.sh ! test/java/util/Currency/PropertiesTest.sh ! test/java/util/Locale/LocaleCategory.sh ! test/java/util/Locale/LocaleProviders.sh ! test/java/util/PluggableLocale/ExecTest.sh ! test/java/util/ResourceBundle/Bug6299235Test.sh ! test/java/util/ResourceBundle/Control/MissingResourceCauseTest.sh ! test/java/util/ServiceLoader/basic.sh ! test/java/util/TimeZone/OldIDMappingTest.sh ! test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh ! test/java/util/prefs/CheckUserPrefsStorage.sh ! test/java/util/prefs/PrefsSpi.sh ! test/java/util/spi/ResourceBundleControlProvider/UserDefaultControlTest.sh ! test/java/util/zip/3GBZipFiles.sh ! test/java/util/zip/ZipFile/deletetempjar.sh ! test/javax/crypto/SecretKeyFactory/FailOverTest.sh ! test/javax/print/applet/AppletPrintLookup.sh ! test/javax/script/ProviderTest.sh ! test/javax/security/auth/Subject/doAs/Test.sh ! test/lib/security/java.policy/Ext_AllPolicy.sh ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.sh ! test/sun/management/jmxremote/bootstrap/LocalManagementTest.sh ! test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.sh ! test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/misc/Cleaner/exitOnThrow.sh ! test/sun/net/InetAddress/nameservice/dns/cname.sh ! test/sun/net/sdp/sanity.sh ! test/sun/net/www/MarkResetTest.sh ! test/sun/net/www/http/HttpClient/RetryPost.sh ! test/sun/net/www/protocol/file/DirPermissionDenied.sh ! test/sun/net/www/protocol/jar/B5105410.sh ! test/sun/net/www/protocol/jar/getcontenttype.sh ! test/sun/net/www/protocol/jar/jarbug/run.sh ! test/sun/rmi/rmic/manifestClassPath/run.sh ! test/sun/rmi/rmic/minimizeWrapperInstances/run.sh ! test/sun/rmi/rmic/oldjavacRemoved/sunToolsJavacMain.sh ! test/sun/security/krb5/runNameEquals.sh ! test/sun/security/krb5/tools/ktcheck.sh ! test/sun/security/mscapi/AccessKeyStore.sh ! test/sun/security/mscapi/IsSunMSCAPIAvailable.sh ! test/sun/security/mscapi/KeyStoreCompatibilityMode.sh ! test/sun/security/mscapi/PublicKeyInterop.sh ! test/sun/security/mscapi/RSAEncryptDecrypt.sh ! test/sun/security/mscapi/ShortRSAKey1024.sh ! test/sun/security/mscapi/SignUsingNONEwithRSA.sh ! test/sun/security/mscapi/SignUsingSHA2withRSA.sh ! test/sun/security/pkcs11/KeyStore/Basic.sh ! test/sun/security/pkcs11/KeyStore/ClientAuth.sh ! test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh ! test/sun/security/pkcs11/KeyStore/Solaris.sh ! test/sun/security/pkcs11/Provider/ConfigQuotedString.sh ! test/sun/security/pkcs11/Provider/Login.sh ! test/sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.sh ! test/sun/security/provider/PolicyFile/getinstance/getinstance.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NotifyHandshakeTest.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.sh ! test/sun/security/tools/jarsigner/emptymanifest.sh ! test/sun/security/tools/jarsigner/ts.sh ! test/sun/security/tools/keytool/printssl.sh ! test/sun/security/tools/keytool/standard.sh ! test/sun/security/validator/certreplace.sh ! test/sun/security/validator/samedn.sh ! test/tools/launcher/6842838/Test6842838.sh ! test/tools/launcher/MultipleJRE.sh Changeset: 087425441a48 Author: robm Date: 2012-12-13 15:28 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/087425441a48 8000525: Java.net.httpcookie api does not support 2-digit year format Reviewed-by: chegar ! src/share/classes/java/net/HttpCookie.java ! test/java/net/CookieHandler/B6791927.java ! test/java/net/CookieHandler/CookieManagerTest.java + test/java/net/HttpCookie/ExpiredCookieTest.java Changeset: 8d7323a9d8ed Author: dholmes Date: 2012-12-13 21:18 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/8d7323a9d8ed 8003632: HPROF class file version java.lang.RuntimeException errors Reviewed-by: mchung, lancea ! src/share/javavm/export/classfile_constants.h Changeset: de6b54a60d60 Author: lana Date: 2012-12-14 13:14 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/de6b54a60d60 Merge ! makefiles/CompileNativeLibraries.gmk - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java From james.graham at oracle.com Thu Dec 20 04:47:30 2012 From: james.graham at oracle.com (Jim Graham) Date: Wed, 19 Dec 2012 20:47:30 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50CCB2CA.8030307@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> Message-ID: <50D29862.2060806@oracle.com> Hi Sergey, This is all a lot more complicated than I think it needs to be. Why not just detect incoming empty rectangles and force an empty composite clip in that case? No heuristics necessary... ...jim On 12/15/2012 9:26 AM, Sergey Bylokhov wrote: > Hi, Jim. > Could you please review the updated version of the fix: > http://cr.openjdk.java.net/~serb/8004859/webrev.01 > 14.12.2012 0:40, Jim Graham wrote: >> This fix breaks other behavior. >> >> You need to use setFrameFromDiagonal on the results of the transform >> because a flip or rotation can cause the transformed points to be >> unordered and setFFD will sort them as they need to be. It is the >> incoming rectangle that needs to be checked for being empty, not the >> results of the transform. > In the new version I restore coordinates relation, if it were changed > during transform. > Swap needed: > - If the user provide incorrect rectangle and after transformation we > get correct rectangle. > - If the user provide correct rectangle and after transformation we > get incorrect rectangle. >> >> The case that will fail with this fix is setting the clip to a valid >> rectangle in a coordinate system that is rotated by a multiple of 90 >> degrees or is flipped horizontally or vertically. Those cases will >> result in an empty clip, but the clip was not empty coming in... >> >> ...jim >> >> On 12/13/2012 3:08 AM, Sergey Bylokhov wrote: >>> Hello, >>> Please review the fix for jdk 8. >>> Change description: >>> 1 transformShape now symmetric to untransformShape() >>> (setFrameFromDiagonal was removed). >>> 2 getClipBounds now always uses getBounds2D which does not return empty >>> Rectangle if the userclip has negative width or height. >>> >>> Note that if the userclip has negative width or height, our real graphic >>> clip will be empty/no-area. This wasn't true before the fix for the >>> scaled graphics. >>> >>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004859 >>> Webrev can be found at: >>> http://cr.openjdk.java.net/~serb/8004859/webrev.00 >>> > > From james.graham at oracle.com Thu Dec 20 09:49:22 2012 From: james.graham at oracle.com (Jim Graham) Date: Thu, 20 Dec 2012 01:49:22 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50D29862.2060806@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> Message-ID: <50D2DF22.7020007@oracle.com> More to the point, if you substitute a 0x0 clip when an incoming clip is an empty rectangle then it will always be empty under any kind of transform. This could be done by performing a "max(w,0);max(h,0);" operation on the incoming data. Once a clip is accepted as non-empty, then I think the current code will adequately deal with flipped transforms, won't it? ...jim On 12/19/2012 8:47 PM, Jim Graham wrote: > Hi Sergey, > > This is all a lot more complicated than I think it needs to be. Why not > just detect incoming empty rectangles and force an empty composite clip > in that case? No heuristics necessary... > > ...jim > > On 12/15/2012 9:26 AM, Sergey Bylokhov wrote: >> Hi, Jim. >> Could you please review the updated version of the fix: >> http://cr.openjdk.java.net/~serb/8004859/webrev.01 >> 14.12.2012 0:40, Jim Graham wrote: >>> This fix breaks other behavior. >>> >>> You need to use setFrameFromDiagonal on the results of the transform >>> because a flip or rotation can cause the transformed points to be >>> unordered and setFFD will sort them as they need to be. It is the >>> incoming rectangle that needs to be checked for being empty, not the >>> results of the transform. >> In the new version I restore coordinates relation, if it were changed >> during transform. >> Swap needed: >> - If the user provide incorrect rectangle and after transformation we >> get correct rectangle. >> - If the user provide correct rectangle and after transformation we >> get incorrect rectangle. >>> >>> The case that will fail with this fix is setting the clip to a valid >>> rectangle in a coordinate system that is rotated by a multiple of 90 >>> degrees or is flipped horizontally or vertically. Those cases will >>> result in an empty clip, but the clip was not empty coming in... >>> >>> ...jim >>> >>> On 12/13/2012 3:08 AM, Sergey Bylokhov wrote: >>>> Hello, >>>> Please review the fix for jdk 8. >>>> Change description: >>>> 1 transformShape now symmetric to untransformShape() >>>> (setFrameFromDiagonal was removed). >>>> 2 getClipBounds now always uses getBounds2D which does not return empty >>>> Rectangle if the userclip has negative width or height. >>>> >>>> Note that if the userclip has negative width or height, our real >>>> graphic >>>> clip will be empty/no-area. This wasn't true before the fix for the >>>> scaled graphics. >>>> >>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004859 >>>> Webrev can be found at: >>>> http://cr.openjdk.java.net/~serb/8004859/webrev.00 >>>> >> >> From Sergey.Bylokhov at oracle.com Thu Dec 20 10:12:20 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 20 Dec 2012 14:12:20 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50D2DF22.7020007@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> <50D2DF22.7020007@oracle.com> Message-ID: <50D2E484.3030004@oracle.com> 20.12.2012 13:49, Jim Graham wrote: > More to the point, if you substitute a 0x0 clip when an incoming clip > is an empty rectangle then it will always be empty under any kind of > transform. This could be done by performing a "max(w,0);max(h,0);" > operation on the incoming data. Once a clip is accepted as non-empty, > then I think the current code will adequately deal with flipped > transforms, won't it? Yes, but with one exception. What to do with getClip:untransformShape methods in this case, it executes the reverse transformation. The question is: if the incoming clip is an empty how to store it? If we did not transform incoming clip, we should change getClip/clip/untransformShape + some flag which should indicate that incoming clip(not a result of transformation) was empty. > > ...jim > > On 12/19/2012 8:47 PM, Jim Graham wrote: >> Hi Sergey, >> >> This is all a lot more complicated than I think it needs to be. Why not >> just detect incoming empty rectangles and force an empty composite clip >> in that case? No heuristics necessary... >> >> ...jim >> >> On 12/15/2012 9:26 AM, Sergey Bylokhov wrote: >>> Hi, Jim. >>> Could you please review the updated version of the fix: >>> http://cr.openjdk.java.net/~serb/8004859/webrev.01 >>> 14.12.2012 0:40, Jim Graham wrote: >>>> This fix breaks other behavior. >>>> >>>> You need to use setFrameFromDiagonal on the results of the transform >>>> because a flip or rotation can cause the transformed points to be >>>> unordered and setFFD will sort them as they need to be. It is the >>>> incoming rectangle that needs to be checked for being empty, not the >>>> results of the transform. >>> In the new version I restore coordinates relation, if it were changed >>> during transform. >>> Swap needed: >>> - If the user provide incorrect rectangle and after transformation we >>> get correct rectangle. >>> - If the user provide correct rectangle and after transformation we >>> get incorrect rectangle. >>>> >>>> The case that will fail with this fix is setting the clip to a valid >>>> rectangle in a coordinate system that is rotated by a multiple of 90 >>>> degrees or is flipped horizontally or vertically. Those cases will >>>> result in an empty clip, but the clip was not empty coming in... >>>> >>>> ...jim >>>> >>>> On 12/13/2012 3:08 AM, Sergey Bylokhov wrote: >>>>> Hello, >>>>> Please review the fix for jdk 8. >>>>> Change description: >>>>> 1 transformShape now symmetric to untransformShape() >>>>> (setFrameFromDiagonal was removed). >>>>> 2 getClipBounds now always uses getBounds2D which does not return >>>>> empty >>>>> Rectangle if the userclip has negative width or height. >>>>> >>>>> Note that if the userclip has negative width or height, our real >>>>> graphic >>>>> clip will be empty/no-area. This wasn't true before the fix for the >>>>> scaled graphics. >>>>> >>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004859 >>>>> Webrev can be found at: >>>>> http://cr.openjdk.java.net/~serb/8004859/webrev.00 >>>>> >>> >>> -- Best regards, Sergey. From Sergey.Bylokhov at oracle.com Thu Dec 20 17:52:37 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 20 Dec 2012 21:52:37 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50D2E484.3030004@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> <50D2DF22.7020007@oracle.com> <50D2E484.3030004@oracle.com> Message-ID: <50D35065.1080307@oracle.com> 20.12.2012 14:12, Sergey Bylokhov ?????: > 20.12.2012 13:49, Jim Graham wrote: >> More to the point, if you substitute a 0x0 clip when an incoming clip >> is an empty rectangle then it will always be empty under any kind of >> transform. This could be done by performing a "max(w,0);max(h,0);" >> operation on the incoming data. Once a clip is accepted as >> non-empty, then I think the current code will adequately deal with >> flipped transforms, won't it? > Yes, but with one exception. What to do with getClip:untransformShape > methods in this case, it executes the reverse transformation. > The question is: if the incoming clip is an empty how to store it? If > we did not transform incoming clip, we should change > getClip/clip/untransformShape + some flag which should indicate that > incoming clip(not a result of transformation) was empty. Another solution: don't use transformShape/untransformShape in the set/get methods. store usrClip as is, and transform usrClip->usrClipTmp in validateCompClip(). In this case setters/getters will become much simpler. >> >> ...jim >> >> On 12/19/2012 8:47 PM, Jim Graham wrote: >>> Hi Sergey, >>> >>> This is all a lot more complicated than I think it needs to be. Why not >>> just detect incoming empty rectangles and force an empty composite clip >>> in that case? No heuristics necessary... >>> >>> ...jim >>> >>> On 12/15/2012 9:26 AM, Sergey Bylokhov wrote: >>>> Hi, Jim. >>>> Could you please review the updated version of the fix: >>>> http://cr.openjdk.java.net/~serb/8004859/webrev.01 >>>> 14.12.2012 0:40, Jim Graham wrote: >>>>> This fix breaks other behavior. >>>>> >>>>> You need to use setFrameFromDiagonal on the results of the transform >>>>> because a flip or rotation can cause the transformed points to be >>>>> unordered and setFFD will sort them as they need to be. It is the >>>>> incoming rectangle that needs to be checked for being empty, not the >>>>> results of the transform. >>>> In the new version I restore coordinates relation, if it were changed >>>> during transform. >>>> Swap needed: >>>> - If the user provide incorrect rectangle and after >>>> transformation we >>>> get correct rectangle. >>>> - If the user provide correct rectangle and after transformation we >>>> get incorrect rectangle. >>>>> >>>>> The case that will fail with this fix is setting the clip to a valid >>>>> rectangle in a coordinate system that is rotated by a multiple of 90 >>>>> degrees or is flipped horizontally or vertically. Those cases will >>>>> result in an empty clip, but the clip was not empty coming in... >>>>> >>>>> ...jim >>>>> >>>>> On 12/13/2012 3:08 AM, Sergey Bylokhov wrote: >>>>>> Hello, >>>>>> Please review the fix for jdk 8. >>>>>> Change description: >>>>>> 1 transformShape now symmetric to untransformShape() >>>>>> (setFrameFromDiagonal was removed). >>>>>> 2 getClipBounds now always uses getBounds2D which does not return >>>>>> empty >>>>>> Rectangle if the userclip has negative width or height. >>>>>> >>>>>> Note that if the userclip has negative width or height, our real >>>>>> graphic >>>>>> clip will be empty/no-area. This wasn't true before the fix for the >>>>>> scaled graphics. >>>>>> >>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004859 >>>>>> Webrev can be found at: >>>>>> http://cr.openjdk.java.net/~serb/8004859/webrev.00 >>>>>> >>>> >>>> > > -- Best regards, Sergey. From Sergey.Bylokhov at oracle.com Thu Dec 20 17:52:50 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 20 Dec 2012 21:52:50 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50D2E484.3030004@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> <50D2DF22.7020007@oracle.com> <50D2E484.3030004@oracle.com> Message-ID: <50D35072.4080409@oracle.com> 20.12.2012 14:12, Sergey Bylokhov wrote: > 20.12.2012 13:49, Jim Graham wrote: >> More to the point, if you substitute a 0x0 clip when an incoming clip >> is an empty rectangle then it will always be empty under any kind of >> transform. This could be done by performing a "max(w,0);max(h,0);" >> operation on the incoming data. Once a clip is accepted as >> non-empty, then I think the current code will adequately deal with >> flipped transforms, won't it? > Yes, but with one exception. What to do with getClip:untransformShape > methods in this case, it executes the reverse transformation. > The question is: if the incoming clip is an empty how to store it? If > we did not transform incoming clip, we should change > getClip/clip/untransformShape + some flag which should indicate that > incoming clip(not a result of transformation) was empty. Another solution: don't use transformShape/untransformShape in the set/get methods. store usrClip as is, and transform usrClip->usrClipTmp in validateCompClip(). In this case setters/getters will become much simpler. >> >> ...jim >> >> On 12/19/2012 8:47 PM, Jim Graham wrote: >>> Hi Sergey, >>> >>> This is all a lot more complicated than I think it needs to be. Why not >>> just detect incoming empty rectangles and force an empty composite clip >>> in that case? No heuristics necessary... >>> >>> ...jim >>> >>> On 12/15/2012 9:26 AM, Sergey Bylokhov wrote: >>>> Hi, Jim. >>>> Could you please review the updated version of the fix: >>>> http://cr.openjdk.java.net/~serb/8004859/webrev.01 >>>> 14.12.2012 0:40, Jim Graham wrote: >>>>> This fix breaks other behavior. >>>>> >>>>> You need to use setFrameFromDiagonal on the results of the transform >>>>> because a flip or rotation can cause the transformed points to be >>>>> unordered and setFFD will sort them as they need to be. It is the >>>>> incoming rectangle that needs to be checked for being empty, not the >>>>> results of the transform. >>>> In the new version I restore coordinates relation, if it were changed >>>> during transform. >>>> Swap needed: >>>> - If the user provide incorrect rectangle and after >>>> transformation we >>>> get correct rectangle. >>>> - If the user provide correct rectangle and after transformation we >>>> get incorrect rectangle. >>>>> >>>>> The case that will fail with this fix is setting the clip to a valid >>>>> rectangle in a coordinate system that is rotated by a multiple of 90 >>>>> degrees or is flipped horizontally or vertically. Those cases will >>>>> result in an empty clip, but the clip was not empty coming in... >>>>> >>>>> ...jim >>>>> >>>>> On 12/13/2012 3:08 AM, Sergey Bylokhov wrote: >>>>>> Hello, >>>>>> Please review the fix for jdk 8. >>>>>> Change description: >>>>>> 1 transformShape now symmetric to untransformShape() >>>>>> (setFrameFromDiagonal was removed). >>>>>> 2 getClipBounds now always uses getBounds2D which does not return >>>>>> empty >>>>>> Rectangle if the userclip has negative width or height. >>>>>> >>>>>> Note that if the userclip has negative width or height, our real >>>>>> graphic >>>>>> clip will be empty/no-area. This wasn't true before the fix for the >>>>>> scaled graphics. >>>>>> >>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004859 >>>>>> Webrev can be found at: >>>>>> http://cr.openjdk.java.net/~serb/8004859/webrev.00 >>>>>> >>>> >>>> > > -- Best regards, Sergey. From james.graham at oracle.com Thu Dec 20 21:42:00 2012 From: james.graham at oracle.com (Jim Graham) Date: Thu, 20 Dec 2012 13:42:00 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50D35065.1080307@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> <50D2DF22.7020007@oracle.com> <50D2E484.3030004@oracle.com> <50D35065.1080307@oracle.com> Message-ID: <50D38628.2050807@oracle.com> Hi Sergey, Avoiding the transform only works if they read it back in the same coordinate system that they set it. It will fail if they do: setClip or clip(...); scale(5, 5); getClip(); The answer from getClip in that case should be scaled down by 5x. Going through device space is the most straightforward way to manage any potential differences in transform, but more direct results are possible if you want to get into (storing and) comparing the before and after results. The drawbacks are the storage for the original transform and complicated code to compute the difference in the transforms. I suppose you could keep it as an optimization and simply disable the optimization if the transform changes at all, but that means you then still have to have the backup plan. Also, it becomes pretty much unmanageable if they combine a few different shapes in a few different coordinate systems (using clip, not setClip) - at that point you pretty much must go through the common denominator of device space anyway so just doing that in all cases is the path of least resistance by a wide margin. So, given that we have to deal with the transform/untransform issues anyway then a user-space clip caching solution isn't going to solve the immediate problem for all cases. I'd have to look closely at the code to know for sure, but I imagine that it would be easy enough to ensure that the [un]transform methods always turn a rectangle with 0 dimensions into another rectangle with 0 dimensions (whether one or both are 0). The setFFD normalization only hurts us when we have negative dimensions, but it should be OK with 0 dimensions, no? So, if we normalize negative dimensions to 0 going in then it might be safe? ...jim On 12/20/2012 9:52 AM, Sergey Bylokhov wrote: > 20.12.2012 14:12, Sergey Bylokhov ?????: >> 20.12.2012 13:49, Jim Graham wrote: >>> More to the point, if you substitute a 0x0 clip when an incoming clip >>> is an empty rectangle then it will always be empty under any kind of >>> transform. This could be done by performing a "max(w,0);max(h,0);" >>> operation on the incoming data. Once a clip is accepted as >>> non-empty, then I think the current code will adequately deal with >>> flipped transforms, won't it? >> Yes, but with one exception. What to do with getClip:untransformShape >> methods in this case, it executes the reverse transformation. >> The question is: if the incoming clip is an empty how to store it? If >> we did not transform incoming clip, we should change >> getClip/clip/untransformShape + some flag which should indicate that >> incoming clip(not a result of transformation) was empty. > Another solution: don't use transformShape/untransformShape in the > set/get methods. store usrClip as is, and transform usrClip->usrClipTmp > in validateCompClip(). > In this case setters/getters will become much simpler. >>> >>> ...jim >>> >>> On 12/19/2012 8:47 PM, Jim Graham wrote: >>>> Hi Sergey, >>>> >>>> This is all a lot more complicated than I think it needs to be. Why not >>>> just detect incoming empty rectangles and force an empty composite clip >>>> in that case? No heuristics necessary... >>>> >>>> ...jim >>>> >>>> On 12/15/2012 9:26 AM, Sergey Bylokhov wrote: >>>>> Hi, Jim. >>>>> Could you please review the updated version of the fix: >>>>> http://cr.openjdk.java.net/~serb/8004859/webrev.01 >>>>> 14.12.2012 0:40, Jim Graham wrote: >>>>>> This fix breaks other behavior. >>>>>> >>>>>> You need to use setFrameFromDiagonal on the results of the transform >>>>>> because a flip or rotation can cause the transformed points to be >>>>>> unordered and setFFD will sort them as they need to be. It is the >>>>>> incoming rectangle that needs to be checked for being empty, not the >>>>>> results of the transform. >>>>> In the new version I restore coordinates relation, if it were changed >>>>> during transform. >>>>> Swap needed: >>>>> - If the user provide incorrect rectangle and after >>>>> transformation we >>>>> get correct rectangle. >>>>> - If the user provide correct rectangle and after transformation we >>>>> get incorrect rectangle. >>>>>> >>>>>> The case that will fail with this fix is setting the clip to a valid >>>>>> rectangle in a coordinate system that is rotated by a multiple of 90 >>>>>> degrees or is flipped horizontally or vertically. Those cases will >>>>>> result in an empty clip, but the clip was not empty coming in... >>>>>> >>>>>> ...jim >>>>>> >>>>>> On 12/13/2012 3:08 AM, Sergey Bylokhov wrote: >>>>>>> Hello, >>>>>>> Please review the fix for jdk 8. >>>>>>> Change description: >>>>>>> 1 transformShape now symmetric to untransformShape() >>>>>>> (setFrameFromDiagonal was removed). >>>>>>> 2 getClipBounds now always uses getBounds2D which does not return >>>>>>> empty >>>>>>> Rectangle if the userclip has negative width or height. >>>>>>> >>>>>>> Note that if the userclip has negative width or height, our real >>>>>>> graphic >>>>>>> clip will be empty/no-area. This wasn't true before the fix for the >>>>>>> scaled graphics. >>>>>>> >>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004859 >>>>>>> Webrev can be found at: >>>>>>> http://cr.openjdk.java.net/~serb/8004859/webrev.00 >>>>>>> >>>>> >>>>> >> >> > > From jennifer.godinez at oracle.com Thu Dec 20 22:44:18 2012 From: jennifer.godinez at oracle.com (jennifer.godinez at oracle.com) Date: Thu, 20 Dec 2012 22:44:18 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 7180359: Assertion in awt_Win32GraphicsDevice.cpp when running specjbb in jprt Message-ID: <20121220224501.3AC6347309@hg.openjdk.java.net> Changeset: a988c23b8553 Author: jgodinez Date: 2012-12-20 14:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a988c23b8553 7180359: Assertion in awt_Win32GraphicsDevice.cpp when running specjbb in jprt Reviewed-by: bae, prr ! src/windows/native/sun/windows/awt_Debug.cpp From Sergey.Bylokhov at oracle.com Thu Dec 20 23:26:28 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 21 Dec 2012 03:26:28 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50D38628.2050807@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> <50D2DF22.7020007@oracle.com> <50D2E484.3030004@oracle.com> <50D35065.1080307@oracle.com> <50D38628.2050807@oracle.com> Message-ID: <50D39EA4.6050802@oracle.com> Hi, Jim. 21.12.2012 1:42, Jim Graham wrote: > Hi Sergey, > > Avoiding the transform only works if they read it back in the same > coordinate system that they set it. It will fail if they do: > > setClip or clip(...); > scale(5, 5); > getClip(); > > So, given that we have to deal with the transform/untransform issues > anyway then a user-space clip caching solution isn't going to solve > the immediate problem for all cases. Yes, right, second solution does not work in this case. > > I'd have to look closely at the code to know for sure, but I imagine > that it would be easy enough to ensure that the [un]transform methods > always turn a rectangle with 0 dimensions into another rectangle with > 0 dimensions (whether one or both are 0). Well, I expect that solution from the webrev does this, isn't it? Approach is simple if we have correct clip from the user, we always get correct clip after transformation, and vice versa. > The setFFD normalization only hurts us when we have negative > dimensions, but it should be OK with 0 dimensions, no? So, if we > normalize negative dimensions to 0 going in then it might be safe? Do you mean just change Rectangle(0,0,-100,-100) to (100,100,0,0)? How we can revert back this operation? > > ...jim > > On 12/20/2012 9:52 AM, Sergey Bylokhov wrote: >> 20.12.2012 14:12, Sergey Bylokhov ?????: >>> 20.12.2012 13:49, Jim Graham wrote: >>>> More to the point, if you substitute a 0x0 clip when an incoming clip >>>> is an empty rectangle then it will always be empty under any kind of >>>> transform. This could be done by performing a "max(w,0);max(h,0);" >>>> operation on the incoming data. Once a clip is accepted as >>>> non-empty, then I think the current code will adequately deal with >>>> flipped transforms, won't it? >>> Yes, but with one exception. What to do with getClip:untransformShape >>> methods in this case, it executes the reverse transformation. >>> The question is: if the incoming clip is an empty how to store it? If >>> we did not transform incoming clip, we should change >>> getClip/clip/untransformShape + some flag which should indicate that >>> incoming clip(not a result of transformation) was empty. >> Another solution: don't use transformShape/untransformShape in the >> set/get methods. store usrClip as is, and transform usrClip->usrClipTmp >> in validateCompClip(). >> In this case setters/getters will become much simpler. >>>> >>>> ...jim >>>> >>>> On 12/19/2012 8:47 PM, Jim Graham wrote: >>>>> Hi Sergey, >>>>> >>>>> This is all a lot more complicated than I think it needs to be. >>>>> Why not >>>>> just detect incoming empty rectangles and force an empty composite >>>>> clip >>>>> in that case? No heuristics necessary... >>>>> >>>>> ...jim >>>>> >>>>> On 12/15/2012 9:26 AM, Sergey Bylokhov wrote: >>>>>> Hi, Jim. >>>>>> Could you please review the updated version of the fix: >>>>>> http://cr.openjdk.java.net/~serb/8004859/webrev.01 >>>>>> 14.12.2012 0:40, Jim Graham wrote: >>>>>>> This fix breaks other behavior. >>>>>>> >>>>>>> You need to use setFrameFromDiagonal on the results of the >>>>>>> transform >>>>>>> because a flip or rotation can cause the transformed points to be >>>>>>> unordered and setFFD will sort them as they need to be. It is the >>>>>>> incoming rectangle that needs to be checked for being empty, not >>>>>>> the >>>>>>> results of the transform. >>>>>> In the new version I restore coordinates relation, if it were >>>>>> changed >>>>>> during transform. >>>>>> Swap needed: >>>>>> - If the user provide incorrect rectangle and after >>>>>> transformation we >>>>>> get correct rectangle. >>>>>> - If the user provide correct rectangle and after >>>>>> transformation we >>>>>> get incorrect rectangle. >>>>>>> >>>>>>> The case that will fail with this fix is setting the clip to a >>>>>>> valid >>>>>>> rectangle in a coordinate system that is rotated by a multiple >>>>>>> of 90 >>>>>>> degrees or is flipped horizontally or vertically. Those cases will >>>>>>> result in an empty clip, but the clip was not empty coming in... >>>>>>> >>>>>>> ...jim >>>>>>> >>>>>>> On 12/13/2012 3:08 AM, Sergey Bylokhov wrote: >>>>>>>> Hello, >>>>>>>> Please review the fix for jdk 8. >>>>>>>> Change description: >>>>>>>> 1 transformShape now symmetric to untransformShape() >>>>>>>> (setFrameFromDiagonal was removed). >>>>>>>> 2 getClipBounds now always uses getBounds2D which does not return >>>>>>>> empty >>>>>>>> Rectangle if the userclip has negative width or height. >>>>>>>> >>>>>>>> Note that if the userclip has negative width or height, our real >>>>>>>> graphic >>>>>>>> clip will be empty/no-area. This wasn't true before the fix for >>>>>>>> the >>>>>>>> scaled graphics. >>>>>>>> >>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004859 >>>>>>>> Webrev can be found at: >>>>>>>> http://cr.openjdk.java.net/~serb/8004859/webrev.00 >>>>>>>> >>>>>> >>>>>> >>> >>> >> >> -- Best regards, Sergey. From Sergey.Bylokhov at oracle.com Thu Dec 20 23:35:13 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 21 Dec 2012 03:35:13 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50D39EA4.6050802@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> <50D2DF22.7020007@oracle.com> <50D2E484.3030004@oracle.com> <50D35065.1080307@oracle.com> <50D38628.2050807@oracle.com> <50D39EA4.6050802@oracle.com> Message-ID: <50D3A0B1.2040407@oracle.com> 21.12.2012 3:26, Sergey Bylokhov ?????: > Hi, Jim. > 21.12.2012 1:42, Jim Graham wrote: >> Hi Sergey, >> >> Avoiding the transform only works if they read it back in the same >> coordinate system that they set it. It will fail if they do: >> >> setClip or clip(...); >> scale(5, 5); >> getClip(); >> >> So, given that we have to deal with the transform/untransform issues >> anyway then a user-space clip caching solution isn't going to solve >> the immediate problem for all cases. > Yes, right, second solution does not work in this case. >> >> I'd have to look closely at the code to know for sure, but I imagine >> that it would be easy enough to ensure that the [un]transform methods >> always turn a rectangle with 0 dimensions into another rectangle with >> 0 dimensions (whether one or both are 0). > Well, I expect that solution from the webrev does this, isn't it? > Approach is simple if we have correct clip from the user, we always > get correct clip after transformation, and vice versa. >> The setFFD normalization only hurts us when we have negative >> dimensions, but it should be OK with 0 dimensions, no? So, if we >> normalize negative dimensions to 0 going in then it might be safe? > Do you mean just change Rectangle(0,0,-100,-100) to (100,100,0,0)? I just realise that (100,100,0,0) is incorrect here. So the question more general: Do you mean just change Rectangle(0,0,-100,-100) to .. "what"? > How we can revert back this operation? > >> >> ...jim >> >> On 12/20/2012 9:52 AM, Sergey Bylokhov wrote: >>> 20.12.2012 14:12, Sergey Bylokhov ?????: >>>> 20.12.2012 13:49, Jim Graham wrote: >>>>> More to the point, if you substitute a 0x0 clip when an incoming clip >>>>> is an empty rectangle then it will always be empty under any kind of >>>>> transform. This could be done by performing a "max(w,0);max(h,0);" >>>>> operation on the incoming data. Once a clip is accepted as >>>>> non-empty, then I think the current code will adequately deal with >>>>> flipped transforms, won't it? >>>> Yes, but with one exception. What to do with getClip:untransformShape >>>> methods in this case, it executes the reverse transformation. >>>> The question is: if the incoming clip is an empty how to store it? If >>>> we did not transform incoming clip, we should change >>>> getClip/clip/untransformShape + some flag which should indicate that >>>> incoming clip(not a result of transformation) was empty. >>> Another solution: don't use transformShape/untransformShape in the >>> set/get methods. store usrClip as is, and transform usrClip->usrClipTmp >>> in validateCompClip(). >>> In this case setters/getters will become much simpler. >>>>> >>>>> ...jim >>>>> >>>>> On 12/19/2012 8:47 PM, Jim Graham wrote: >>>>>> Hi Sergey, >>>>>> >>>>>> This is all a lot more complicated than I think it needs to be. >>>>>> Why not >>>>>> just detect incoming empty rectangles and force an empty >>>>>> composite clip >>>>>> in that case? No heuristics necessary... >>>>>> >>>>>> ...jim >>>>>> >>>>>> On 12/15/2012 9:26 AM, Sergey Bylokhov wrote: >>>>>>> Hi, Jim. >>>>>>> Could you please review the updated version of the fix: >>>>>>> http://cr.openjdk.java.net/~serb/8004859/webrev.01 >>>>>>> 14.12.2012 0:40, Jim Graham wrote: >>>>>>>> This fix breaks other behavior. >>>>>>>> >>>>>>>> You need to use setFrameFromDiagonal on the results of the >>>>>>>> transform >>>>>>>> because a flip or rotation can cause the transformed points to be >>>>>>>> unordered and setFFD will sort them as they need to be. It is the >>>>>>>> incoming rectangle that needs to be checked for being empty, >>>>>>>> not the >>>>>>>> results of the transform. >>>>>>> In the new version I restore coordinates relation, if it were >>>>>>> changed >>>>>>> during transform. >>>>>>> Swap needed: >>>>>>> - If the user provide incorrect rectangle and after >>>>>>> transformation we >>>>>>> get correct rectangle. >>>>>>> - If the user provide correct rectangle and after >>>>>>> transformation we >>>>>>> get incorrect rectangle. >>>>>>>> >>>>>>>> The case that will fail with this fix is setting the clip to a >>>>>>>> valid >>>>>>>> rectangle in a coordinate system that is rotated by a multiple >>>>>>>> of 90 >>>>>>>> degrees or is flipped horizontally or vertically. Those cases will >>>>>>>> result in an empty clip, but the clip was not empty coming in... >>>>>>>> >>>>>>>> ...jim >>>>>>>> >>>>>>>> On 12/13/2012 3:08 AM, Sergey Bylokhov wrote: >>>>>>>>> Hello, >>>>>>>>> Please review the fix for jdk 8. >>>>>>>>> Change description: >>>>>>>>> 1 transformShape now symmetric to untransformShape() >>>>>>>>> (setFrameFromDiagonal was removed). >>>>>>>>> 2 getClipBounds now always uses getBounds2D which does not return >>>>>>>>> empty >>>>>>>>> Rectangle if the userclip has negative width or height. >>>>>>>>> >>>>>>>>> Note that if the userclip has negative width or height, our real >>>>>>>>> graphic >>>>>>>>> clip will be empty/no-area. This wasn't true before the fix >>>>>>>>> for the >>>>>>>>> scaled graphics. >>>>>>>>> >>>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004859 >>>>>>>>> Webrev can be found at: >>>>>>>>> http://cr.openjdk.java.net/~serb/8004859/webrev.00 >>>>>>>>> >>>>>>> >>>>>>> >>>> >>>> >>> >>> > > -- Best regards, Sergey. From james.graham at oracle.com Thu Dec 20 23:54:24 2012 From: james.graham at oracle.com (Jim Graham) Date: Thu, 20 Dec 2012 15:54:24 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50D3A0B1.2040407@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> <50D2DF22.7020007@oracle.com> <50D2E484.3030004@oracle.com> <50D35065.1080307@oracle.com> <50D38628.2050807@oracle.com> <50D39EA4.6050802@oracle.com> <50D3A0B1.2040407@oracle.com> Message-ID: <50D3A530.4070604@oracle.com> Hi Sergey, The getClip methods don't claim to return the exact same shape that the user handed in - it just has to cover the territory covered by the clip. x,y,-N,-M covers the same territory as x,y,0,0 so it would be fine to substitute that value in its place. It is arguable whether it matters if we convert x,y,+N,-M to x,y,+N,0 or x,y,0,0 since both rectangles cover no ground. Also, preserving the x,y is questionable since any 0-dimensioned rectangle covers no ground and is equally representative of the fact that the clip is empty. There isn't even any guarantee that we will hand them back a rectangle from getClip(). After all, if you end up in the drop through case then we hand the paths to Area to do intersections and Area will do all sorts of surgery on the geometry. We could hand them back a hard-coded "I'm an empty shape" object that isn't any class that they'd recognize and would return 0,0,0,0 for bounds and a singleton iterator that immediately claims "isDone()==true". If it passes tests (meaning our clever optimizations in the transform/untransform helper methods don't unravel it incorrectly) then I think simply replacing any negative dimensions with zeros would be the least surprising result. I'm not sure what value there is in attempting to return a rectangle that conveys the "same negative dimensions"... ...jim On 12/20/2012 3:35 PM, Sergey Bylokhov wrote: > 21.12.2012 3:26, Sergey Bylokhov ?????: >> Hi, Jim. >> 21.12.2012 1:42, Jim Graham wrote: >>> Hi Sergey, >>> >>> Avoiding the transform only works if they read it back in the same >>> coordinate system that they set it. It will fail if they do: >>> >>> setClip or clip(...); >>> scale(5, 5); >>> getClip(); >>> >>> So, given that we have to deal with the transform/untransform issues >>> anyway then a user-space clip caching solution isn't going to solve >>> the immediate problem for all cases. >> Yes, right, second solution does not work in this case. >>> >>> I'd have to look closely at the code to know for sure, but I imagine >>> that it would be easy enough to ensure that the [un]transform methods >>> always turn a rectangle with 0 dimensions into another rectangle with >>> 0 dimensions (whether one or both are 0). >> Well, I expect that solution from the webrev does this, isn't it? >> Approach is simple if we have correct clip from the user, we always >> get correct clip after transformation, and vice versa. >>> The setFFD normalization only hurts us when we have negative >>> dimensions, but it should be OK with 0 dimensions, no? So, if we >>> normalize negative dimensions to 0 going in then it might be safe? >> Do you mean just change Rectangle(0,0,-100,-100) to (100,100,0,0)? > I just realise that (100,100,0,0) is incorrect here. So the question > more general: Do you mean just change Rectangle(0,0,-100,-100) to .. > "what"? >> How we can revert back this operation? >> >>> >>> ...jim >>> >>> On 12/20/2012 9:52 AM, Sergey Bylokhov wrote: >>>> 20.12.2012 14:12, Sergey Bylokhov ?????: >>>>> 20.12.2012 13:49, Jim Graham wrote: >>>>>> More to the point, if you substitute a 0x0 clip when an incoming clip >>>>>> is an empty rectangle then it will always be empty under any kind of >>>>>> transform. This could be done by performing a "max(w,0);max(h,0);" >>>>>> operation on the incoming data. Once a clip is accepted as >>>>>> non-empty, then I think the current code will adequately deal with >>>>>> flipped transforms, won't it? >>>>> Yes, but with one exception. What to do with getClip:untransformShape >>>>> methods in this case, it executes the reverse transformation. >>>>> The question is: if the incoming clip is an empty how to store it? If >>>>> we did not transform incoming clip, we should change >>>>> getClip/clip/untransformShape + some flag which should indicate that >>>>> incoming clip(not a result of transformation) was empty. >>>> Another solution: don't use transformShape/untransformShape in the >>>> set/get methods. store usrClip as is, and transform usrClip->usrClipTmp >>>> in validateCompClip(). >>>> In this case setters/getters will become much simpler. >>>>>> >>>>>> ...jim >>>>>> >>>>>> On 12/19/2012 8:47 PM, Jim Graham wrote: >>>>>>> Hi Sergey, >>>>>>> >>>>>>> This is all a lot more complicated than I think it needs to be. >>>>>>> Why not >>>>>>> just detect incoming empty rectangles and force an empty >>>>>>> composite clip >>>>>>> in that case? No heuristics necessary... >>>>>>> >>>>>>> ...jim >>>>>>> >>>>>>> On 12/15/2012 9:26 AM, Sergey Bylokhov wrote: >>>>>>>> Hi, Jim. >>>>>>>> Could you please review the updated version of the fix: >>>>>>>> http://cr.openjdk.java.net/~serb/8004859/webrev.01 >>>>>>>> 14.12.2012 0:40, Jim Graham wrote: >>>>>>>>> This fix breaks other behavior. >>>>>>>>> >>>>>>>>> You need to use setFrameFromDiagonal on the results of the >>>>>>>>> transform >>>>>>>>> because a flip or rotation can cause the transformed points to be >>>>>>>>> unordered and setFFD will sort them as they need to be. It is the >>>>>>>>> incoming rectangle that needs to be checked for being empty, >>>>>>>>> not the >>>>>>>>> results of the transform. >>>>>>>> In the new version I restore coordinates relation, if it were >>>>>>>> changed >>>>>>>> during transform. >>>>>>>> Swap needed: >>>>>>>> - If the user provide incorrect rectangle and after >>>>>>>> transformation we >>>>>>>> get correct rectangle. >>>>>>>> - If the user provide correct rectangle and after >>>>>>>> transformation we >>>>>>>> get incorrect rectangle. >>>>>>>>> >>>>>>>>> The case that will fail with this fix is setting the clip to a >>>>>>>>> valid >>>>>>>>> rectangle in a coordinate system that is rotated by a multiple >>>>>>>>> of 90 >>>>>>>>> degrees or is flipped horizontally or vertically. Those cases will >>>>>>>>> result in an empty clip, but the clip was not empty coming in... >>>>>>>>> >>>>>>>>> ...jim >>>>>>>>> >>>>>>>>> On 12/13/2012 3:08 AM, Sergey Bylokhov wrote: >>>>>>>>>> Hello, >>>>>>>>>> Please review the fix for jdk 8. >>>>>>>>>> Change description: >>>>>>>>>> 1 transformShape now symmetric to untransformShape() >>>>>>>>>> (setFrameFromDiagonal was removed). >>>>>>>>>> 2 getClipBounds now always uses getBounds2D which does not return >>>>>>>>>> empty >>>>>>>>>> Rectangle if the userclip has negative width or height. >>>>>>>>>> >>>>>>>>>> Note that if the userclip has negative width or height, our real >>>>>>>>>> graphic >>>>>>>>>> clip will be empty/no-area. This wasn't true before the fix >>>>>>>>>> for the >>>>>>>>>> scaled graphics. >>>>>>>>>> >>>>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004859 >>>>>>>>>> Webrev can be found at: >>>>>>>>>> http://cr.openjdk.java.net/~serb/8004859/webrev.00 >>>>>>>>>> >>>>>>>> >>>>>>>> >>>>> >>>>> >>>> >>>> >> >> > > From Sergey.Bylokhov at oracle.com Fri Dec 21 00:42:43 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 21 Dec 2012 04:42:43 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50D3A530.4070604@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> <50D2DF22.7020007@oracle.com> <50D2E484.3030004@oracle.com> <50D35065.1080307@oracle.com> <50D38628.2050807@oracle.com> <50D39EA4.6050802@oracle.com> <50D3A0B1.2040407@oracle.com> <50D3A530.4070604@oracle.com> Message-ID: <50D3B083.800@oracle.com> Hi, Jim. 21.12.2012 3:54, Jim Graham wrote: > Hi Sergey, > > The getClip methods don't claim to return the exact same shape that > the user handed in - it just has to cover the territory covered by the > clip. x,y,-N,-M covers the same territory as x,y,0,0 so it would be > fine to substitute that value in its place. It is arguable whether it > matters if we convert x,y,+N,-M to x,y,+N,0 or x,y,0,0 since both > rectangles cover no ground. Also, preserving the x,y is questionable > since any 0-dimensioned rectangle covers no ground and is equally > representative of the fact that the clip is empty. Yes, they covers the same territory, but how we can check, that the these shapes equivalent? Because equals return false for them. Note that equals of the Area states about > There isn't even any guarantee that we will hand them back a rectangle > from getClip(). One of the jck tests expect this, but I think that this is the wrong test. > After all, if you end up in the drop through case then we hand the > paths to Area to do intersections and Area will do all sorts of > surgery on the geometry. But I sure this area will be equal to the user's clip? > We could hand them back a hard-coded "I'm an empty shape" object > that isn't any class that they'd recognize and would return 0,0,0,0 > for bounds and a singleton iterator that immediately claims > "isDone()==true". > > If it passes tests (meaning our clever optimizations in the > transform/untransform helper methods don't unravel it incorrectly) > then I think simply replacing any negative dimensions with zeros would > be the least surprising result. I'm not sure what value there is in > attempting to return a rectangle that conveys the "same negative > dimensions"... > > ...jim > > On 12/20/2012 3:35 PM, Sergey Bylokhov wrote: >> 21.12.2012 3:26, Sergey Bylokhov ?????: >>> Hi, Jim. >>> 21.12.2012 1:42, Jim Graham wrote: >>>> Hi Sergey, >>>> >>>> Avoiding the transform only works if they read it back in the same >>>> coordinate system that they set it. It will fail if they do: >>>> >>>> setClip or clip(...); >>>> scale(5, 5); >>>> getClip(); >>>> >>>> So, given that we have to deal with the transform/untransform issues >>>> anyway then a user-space clip caching solution isn't going to solve >>>> the immediate problem for all cases. >>> Yes, right, second solution does not work in this case. >>>> >>>> I'd have to look closely at the code to know for sure, but I imagine >>>> that it would be easy enough to ensure that the [un]transform methods >>>> always turn a rectangle with 0 dimensions into another rectangle with >>>> 0 dimensions (whether one or both are 0). >>> Well, I expect that solution from the webrev does this, isn't it? >>> Approach is simple if we have correct clip from the user, we always >>> get correct clip after transformation, and vice versa. >>>> The setFFD normalization only hurts us when we have negative >>>> dimensions, but it should be OK with 0 dimensions, no? So, if we >>>> normalize negative dimensions to 0 going in then it might be safe? >>> Do you mean just change Rectangle(0,0,-100,-100) to (100,100,0,0)? >> I just realise that (100,100,0,0) is incorrect here. So the question >> more general: Do you mean just change Rectangle(0,0,-100,-100) to .. >> "what"? >>> How we can revert back this operation? >>> >>>> >>>> ...jim >>>> >>>> On 12/20/2012 9:52 AM, Sergey Bylokhov wrote: >>>>> 20.12.2012 14:12, Sergey Bylokhov ?????: >>>>>> 20.12.2012 13:49, Jim Graham wrote: >>>>>>> More to the point, if you substitute a 0x0 clip when an incoming >>>>>>> clip >>>>>>> is an empty rectangle then it will always be empty under any >>>>>>> kind of >>>>>>> transform. This could be done by performing a "max(w,0);max(h,0);" >>>>>>> operation on the incoming data. Once a clip is accepted as >>>>>>> non-empty, then I think the current code will adequately deal with >>>>>>> flipped transforms, won't it? >>>>>> Yes, but with one exception. What to do with >>>>>> getClip:untransformShape >>>>>> methods in this case, it executes the reverse transformation. >>>>>> The question is: if the incoming clip is an empty how to store >>>>>> it? If >>>>>> we did not transform incoming clip, we should change >>>>>> getClip/clip/untransformShape + some flag which should indicate that >>>>>> incoming clip(not a result of transformation) was empty. >>>>> Another solution: don't use transformShape/untransformShape in the >>>>> set/get methods. store usrClip as is, and transform >>>>> usrClip->usrClipTmp >>>>> in validateCompClip(). >>>>> In this case setters/getters will become much simpler. >>>>>>> >>>>>>> ...jim >>>>>>> >>>>>>> On 12/19/2012 8:47 PM, Jim Graham wrote: >>>>>>>> Hi Sergey, >>>>>>>> >>>>>>>> This is all a lot more complicated than I think it needs to be. >>>>>>>> Why not >>>>>>>> just detect incoming empty rectangles and force an empty >>>>>>>> composite clip >>>>>>>> in that case? No heuristics necessary... >>>>>>>> >>>>>>>> ...jim >>>>>>>> >>>>>>>> On 12/15/2012 9:26 AM, Sergey Bylokhov wrote: >>>>>>>>> Hi, Jim. >>>>>>>>> Could you please review the updated version of the fix: >>>>>>>>> http://cr.openjdk.java.net/~serb/8004859/webrev.01 >>>>>>>>> 14.12.2012 0:40, Jim Graham wrote: >>>>>>>>>> This fix breaks other behavior. >>>>>>>>>> >>>>>>>>>> You need to use setFrameFromDiagonal on the results of the >>>>>>>>>> transform >>>>>>>>>> because a flip or rotation can cause the transformed points >>>>>>>>>> to be >>>>>>>>>> unordered and setFFD will sort them as they need to be. It is >>>>>>>>>> the >>>>>>>>>> incoming rectangle that needs to be checked for being empty, >>>>>>>>>> not the >>>>>>>>>> results of the transform. >>>>>>>>> In the new version I restore coordinates relation, if it were >>>>>>>>> changed >>>>>>>>> during transform. >>>>>>>>> Swap needed: >>>>>>>>> - If the user provide incorrect rectangle and after >>>>>>>>> transformation we >>>>>>>>> get correct rectangle. >>>>>>>>> - If the user provide correct rectangle and after >>>>>>>>> transformation we >>>>>>>>> get incorrect rectangle. >>>>>>>>>> >>>>>>>>>> The case that will fail with this fix is setting the clip to a >>>>>>>>>> valid >>>>>>>>>> rectangle in a coordinate system that is rotated by a multiple >>>>>>>>>> of 90 >>>>>>>>>> degrees or is flipped horizontally or vertically. Those cases >>>>>>>>>> will >>>>>>>>>> result in an empty clip, but the clip was not empty coming in... >>>>>>>>>> >>>>>>>>>> ...jim >>>>>>>>>> >>>>>>>>>> On 12/13/2012 3:08 AM, Sergey Bylokhov wrote: >>>>>>>>>>> Hello, >>>>>>>>>>> Please review the fix for jdk 8. >>>>>>>>>>> Change description: >>>>>>>>>>> 1 transformShape now symmetric to untransformShape() >>>>>>>>>>> (setFrameFromDiagonal was removed). >>>>>>>>>>> 2 getClipBounds now always uses getBounds2D which does not >>>>>>>>>>> return >>>>>>>>>>> empty >>>>>>>>>>> Rectangle if the userclip has negative width or height. >>>>>>>>>>> >>>>>>>>>>> Note that if the userclip has negative width or height, our >>>>>>>>>>> real >>>>>>>>>>> graphic >>>>>>>>>>> clip will be empty/no-area. This wasn't true before the fix >>>>>>>>>>> for the >>>>>>>>>>> scaled graphics. >>>>>>>>>>> >>>>>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004859 >>>>>>>>>>> Webrev can be found at: >>>>>>>>>>> http://cr.openjdk.java.net/~serb/8004859/webrev.00 >>>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>> >>> >> >> -- Best regards, Sergey. From james.graham at oracle.com Fri Dec 21 00:59:11 2012 From: james.graham at oracle.com (Jim Graham) Date: Thu, 20 Dec 2012 16:59:11 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50D3B083.800@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> <50D2DF22.7020007@oracle.com> <50D2E484.3030004@oracle.com> <50D35065.1080307@oracle.com> <50D38628.2050807@oracle.com> <50D39EA4.6050802@oracle.com> <50D3A0B1.2040407@oracle.com> <50D3A530.4070604@oracle.com> <50D3B083.800@oracle.com> Message-ID: <50D3B45F.4010903@oracle.com> Hi Sergey, On 12/20/2012 4:42 PM, Sergey Bylokhov wrote: > Hi, Jim. > 21.12.2012 3:54, Jim Graham wrote: >> Hi Sergey, >> >> The getClip methods don't claim to return the exact same shape that >> the user handed in - it just has to cover the territory covered by the >> clip. x,y,-N,-M covers the same territory as x,y,0,0 so it would be >> fine to substitute that value in its place. It is arguable whether it >> matters if we convert x,y,+N,-M to x,y,+N,0 or x,y,0,0 since both >> rectangles cover no ground. Also, preserving the x,y is questionable >> since any 0-dimensioned rectangle covers no ground and is equally >> representative of the fact that the clip is empty. > Yes, they covers the same territory, but how we can check, that the > these shapes equivalent? Because equals return false for them. Note that > equals of the Area states about The Object.equals() method is not intended to compare geometries. While Area.equals() attempts to perform geometric comparison I think that was a bad idea in retrospect for many reasons: - In practice you can only really compare within a tolerance due to the many ways for computations to every so slightly shift the results - There is no decent way to satisfy the equals/hashcode contract with such a comparison so Area is forever broken with respect to that contract. - It's a complicated test that can only serve to convince developers to invite performance drains into their code by making them think it is a reasonable thing to compare. For testing we should probably use Shape.contains() to verify answers for rectangle arguments and if we want to perform verification on arbitrary shape arguments then we'd need to write our own fuzzy comparator. >> There isn't even any guarantee that we will hand them back a rectangle >> from getClip(). > One of the jck tests expect this, but I think that this is the wrong test. There is nothing in the documentation that guarantees a specific type returned from the method. If a JCK test was written to expect a Rectangle from the method then that is a separate problem that we'll have to address at some point. For now I'm only suggesting modifying the process for negative-empty rectangles. Does that trigger the JCK failure? If so, we are still satisfying the documented spec and so we will simply have to confince JCK to allow this exception. >> After all, if you end up in the drop through case then we hand the >> paths to Area to do intersections and Area will do all sorts of >> surgery on the geometry. > But I sure this area will be equal to the user's clip? For all practical purposes it should be, but not only will the Area code encapsulate the answer in a different class (even if the result is a rectangle), it may reverse the order of the segments, it may represent the area as two separate rectangles that abut each other in a way that they are equivalent to one larger rectangle, but the Area code failed to notice that optimization, etc. All it will guarantee is that it returns a shape that describes the same interior, it will make no guarantees about minimalism or association of segments... ...jim From Sergey.Bylokhov at oracle.com Fri Dec 21 02:05:09 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 21 Dec 2012 06:05:09 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50D3B45F.4010903@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> <50D2DF22.7020007@oracle.com> <50D2E484.3030004@oracle.com> <50D35065.1080307@oracle.com> <50D38628.2050807@oracle.com> <50D39EA4.6050802@oracle.com> <50D3A0B1.2040407@oracle.com> <50D3A530.4070604@oracle.com> <50D3B083.800@oracle.com> <50D3B45F.4010903@oracle.com> Message-ID: <50D3C3D5.7080506@oracle.com> Hi, Jim. 21.12.2012 4:59, Jim Graham wrote: > The Object.equals() method is not intended to compare geometries. > While Area.equals() attempts to perform geometric comparison I think > that was a bad idea in retrospect for many reasons: > > - In practice you can only really compare within a tolerance due to > the many ways for computations to every so slightly shift the results > > - There is no decent way to satisfy the equals/hashcode contract with > such a comparison so Area is forever broken with respect to that > contract. > > - It's a complicated test that can only serve to convince developers > to invite performance drains into their code by making them think it > is a reasonable thing to compare. > > For testing we should probably use Shape.contains() to verify answers > for rectangle arguments and if we want to perform verification on > arbitrary shape arguments then we'd need to write our own fuzzy > comparator. But why fix is incorrect? It just use the same code as sffd for the correct shapes and have additional code for incorrect. Only conditionchanged from width/height should be positive, to width/height should be the same direction as incoming rectangle. >>> There isn't even any guarantee that we will hand them back a rectangle >>> from getClip(). >> One of the jck tests expect this, but I think that this is the wrong >> test. > > There is nothing in the documentation that guarantees a specific type > returned from the method. If a JCK test was written to expect a > Rectangle from the method then that is a separate problem that we'll > have to address at some point. For now I'm only suggesting modifying > the process for negative-empty rectangles. Does that trigger the JCK > failure? If so, we are still satisfying the documented spec and so we > will simply have to confince JCK to allow this exception. Problem in jck come from the fact that Rectangle differs from Rectangle2d. Note that everything is ok if graphics is not transformed or just translated. But if we scale graphics we get: 1 getClip() return non equivalent object. 2 getClipBounds for Rectangle return it as is, but for Rectangle2D it is call getBounds, which return an empty bounds or wrong bounds if rectangle2d was normalized by sffd. 3 Some tests expects class equivalence between set/get clip. I'll prepare CR for them soon. Also there is the difference in the real clip, if we use type for the empty Rectangle to Rectangle2D the real clip became correct. All these issues are carried out in the testcase. >>> After all, if you end up in the drop through case then we hand the >>> paths to Area to do intersections and Area will do all sorts of >>> surgery on the geometry. >> But I sure this area will be equal to the user's clip? > > For all practical purposes it should be, but not only will the Area > code encapsulate the answer in a different class (even if the result > is a rectangle), it may reverse the order of the segments, it may > represent the area as two separate rectangles that abut each other in > a way that they are equivalent to one larger rectangle, but the Area > code failed to notice that optimization, etc. All it will guarantee > is that it returns a shape that describes the same interior, it will > make no guarantees about minimalism or association of segments... > > ...jim -- Best regards, Sergey. -------------- next part -------------- An HTML attachment was scrubbed... URL: From Sergey.Bylokhov at oracle.com Fri Dec 21 11:21:51 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 21 Dec 2012 15:21:51 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50D3C3D5.7080506@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> <50D2DF22.7020007@oracle.com> <50D2E484.3030004@oracle.com> <50D35065.1080307@oracle.com> <50D38628.2050807@oracle.com> <50D39EA4.6050802@oracle.com> <50D3A0B1.2040407@oracle.com> <50D3A530.4070604@oracle.com> <50D3B083.800@oracle.com> <50D3B45F.4010903@oracle.com> <50D3C3D5.7080506@oracle.com> Message-ID: <50D4464F.8050401@oracle.com> 21.12.2012 6:05, Sergey Bylokhov ?????: > Hi, Jim. > 21.12.2012 4:59, Jim Graham wrote: >> The Object.equals() method is not intended to compare geometries. >> While Area.equals() attempts to perform geometric comparison I think >> that was a bad idea in retrospect for many reasons: >> >> - In practice you can only really compare within a tolerance due to >> the many ways for computations to every so slightly shift the results >> >> - There is no decent way to satisfy the equals/hashcode contract with >> such a comparison so Area is forever broken with respect to that >> contract. >> >> - It's a complicated test that can only serve to convince developers >> to invite performance drains into their code by making them think it >> is a reasonable thing to compare. >> >> For testing we should probably use Shape.contains() to verify answers >> for rectangle arguments and if we want to perform verification on >> arbitrary shape arguments then we'd need to write our own fuzzy >> comparator. > But why fix is incorrect? It just use the same code as sffd for the > correct shapes and have additional code for incorrect. Only > conditionchanged from width/height should be positive, to > width/height should be the same direction as incoming rectangle. >>>> There isn't even any guarantee that we will hand them back a rectangle >>>> from getClip(). >>> One of the jck tests expect this, but I think that this is the wrong >>> test. >> >> There is nothing in the documentation that guarantees a specific type >> returned from the method. If a JCK test was written to expect a >> Rectangle from the method then that is a separate problem that we'll >> have to address at some point. For now I'm only suggesting modifying >> the process for negative-empty rectangles. Does that trigger the JCK >> failure? If so, we are still satisfying the documented spec and so >> we will simply have to confince JCK to allow this exception. > Problem in jck come from the fact that Rectangle differs from > Rectangle2d. Note that everything is ok if graphics is not transformed > or just translated. But if we scale graphics we get: > 1 getClip() return non equivalent object. > 2 getClipBounds for Rectangle return it as is, but for Rectangle2D it > is call getBounds, which return an empty bounds or wrong bounds if > rectangle2d was normalized by sffd. > 3 Some tests expects class equivalence between set/get clip. I'll > prepare CR for them soon. > > Also there is the difference in the real clip, if we use type for the > empty Rectangle to Rectangle2D the real clip became correct. typo: Also there is the difference in the real clip, if we change type from the empty Rectangle to the empty Rectangle2D, the real clip will become correct. > All these issues are carried out in the testcase. >>>> After all, if you end up in the drop through case then we hand the >>>> paths to Area to do intersections and Area will do all sorts of >>>> surgery on the geometry. >>> But I sure this area will be equal to the user's clip? >> >> For all practical purposes it should be, but not only will the Area >> code encapsulate the answer in a different class (even if the result >> is a rectangle), it may reverse the order of the segments, it may >> represent the area as two separate rectangles that abut each other in >> a way that they are equivalent to one larger rectangle, but the Area >> code failed to notice that optimization, etc. All it will guarantee >> is that it returns a shape that describes the same interior, it will >> make no guarantees about minimalism or association of segments... >> >> ...jim > > > -- > Best regards, Sergey. -- Best regards, Sergey. -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.brygin at oracle.com Fri Dec 21 17:10:10 2012 From: andrew.brygin at oracle.com (Andrew Brygin) Date: Fri, 21 Dec 2012 21:10:10 +0400 Subject: [OpenJDK 2D-Dev] [8] request for review: 7124245: [lcms] ColorConvertOp to color space CS_GRAY apparently converts orange to 244, 244, 0 Message-ID: <50D497F2.7000309@oracle.com> Hello Jennifer and Phil, could you please review a fix for CR 8005402? Bug: http://bugs.sun.com/view_bug.do?bug_id=8005402 Webrev: http://cr.openjdk.java.net/~bae/8005402/webrev.00/ This fix extends J2DBench with benchmarks for color management: - ColorConvertOp performance for images and rasters. - rendering speed for images with non-sRGB color spaces. - performance of access to profile data. Please take a look. Thanks, Andrew. From andrew.brygin at oracle.com Fri Dec 21 17:13:48 2012 From: andrew.brygin at oracle.com (Andrew Brygin) Date: Fri, 21 Dec 2012 21:13:48 +0400 Subject: [OpenJDK 2D-Dev] [8] request for review: 8005402: Need to provide benchmarks for color management Message-ID: <50D498CC.3010402@oracle.com> Hello Jennifer and Phil, could you please review a fix for CR 8005402? Bug: http://bugs.sun.com/view_bug.do?bug_id=8005402 Webrev: http://cr.openjdk.java.net/~bae/8005402/webrev.00/ This fix extends J2DBench with benchmarks for color management: - ColorConvertOp performance for images and rasters. - rendering speed for images with non-sRGB color spaces. - performance of access to profile data. Please take a look. Thanks, Andrew. From philip.race at oracle.com Fri Dec 21 17:29:19 2012 From: philip.race at oracle.com (Phil Race) Date: Fri, 21 Dec 2012 09:29:19 -0800 Subject: [OpenJDK 2D-Dev] [8] request for review: 7124245: [lcms] ColorConvertOp to color space CS_GRAY apparently converts orange to 244, 244, 0 In-Reply-To: <50D497F2.7000309@oracle.com> References: <50D497F2.7000309@oracle.com> Message-ID: <50D49C6F.2080808@oracle.com> Fine by me. -phi.l. On 12/21/12 9:10 AM, Andrew Brygin wrote: > Hello Jennifer and Phil, > > could you please review a fix for CR 8005402? > > Bug: http://bugs.sun.com/view_bug.do?bug_id=8005402 > Webrev: http://cr.openjdk.java.net/~bae/8005402/webrev.00/ > > This fix extends J2DBench with benchmarks for color management: > - ColorConvertOp performance for images and rasters. > - rendering speed for images with non-sRGB color spaces. > - performance of access to profile data. > > Please take a look. > > Thanks, > Andrew. From jennifer.godinez at oracle.com Fri Dec 21 18:15:49 2012 From: jennifer.godinez at oracle.com (Jennifer Godinez) Date: Fri, 21 Dec 2012 10:15:49 -0800 Subject: [OpenJDK 2D-Dev] [8] request for review: 7124245: [lcms] ColorConvertOp to color space CS_GRAY apparently converts orange to 244, 244, 0 In-Reply-To: <50D497F2.7000309@oracle.com> References: <50D497F2.7000309@oracle.com> Message-ID: <50D4A755.6010305@oracle.com> Looks good. Jennifer On 12/21/2012 9:10 AM, Andrew Brygin wrote: > Hello Jennifer and Phil, > > could you please review a fix for CR 8005402? > > Bug: http://bugs.sun.com/view_bug.do?bug_id=8005402 > Webrev: http://cr.openjdk.java.net/~bae/8005402/webrev.00/ > > This fix extends J2DBench with benchmarks for color management: > - ColorConvertOp performance for images and rasters. > - rendering speed for images with non-sRGB color spaces. > - performance of access to profile data. > > Please take a look. > > Thanks, > Andrew. From philip.race at oracle.com Fri Dec 21 21:03:20 2012 From: philip.race at oracle.com (Phil Race) Date: Fri, 21 Dec 2012 13:03:20 -0800 Subject: [OpenJDK 2D-Dev] [8] request for review: 7124245: [lcms] ColorConvertOp to color space CS_GRAY apparently converts orange to 244, 244, 0 In-Reply-To: <50CF339F.7090009@oracle.com> References: <50CF339F.7090009@oracle.com> Message-ID: <50D4CE98.6050503@oracle.com> Fix is OK but please fix the typoes in the test summary before committing this : covresion does not distors => conversion does not distort -phil. On 12/17/2012 7:00 AM, Andrew Brygin wrote: > Hello Jennifer and Phil, > > could you please review a fix for CR 7124245? > > Bug: http://bugs.sun.com/view_bug.do?bug_id=7124245 > Webrev: http://cr.openjdk.java.net/~bae/7124245/8/webrev.00/ > > The problem with wrong colors is caused by using incorrect image > format for buffered images based on integer data buffers. > Lcms interprets image data as a sequence of bytes, so we have to > adjust data formats for such kind of images according to the > system endiannes. I.e. for INT_ARGB image we get BGRA byte sequence > on intel, and ARGB byte sequence on sparc. > > Lcms always creates transforms specific for formats of processed data > (input and output). These formats can not be changed, the transform > has to be re-created instead. > So, we have to adjust input and output formats to the system endianness > before we create the transform for given input and output images. > > Supplied regression test demonstrates the problem. > > Please take a look. > > Thanks, > Andrew. From anthony.petrov at oracle.com Mon Dec 24 09:52:22 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 24 Dec 2012 13:52:22 +0400 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <50D55E14.4080704@oracle.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> Message-ID: <50D825D6.30708@oracle.com> (CC'ing awt-dev@ and 2d-dev@) There's an RFE: 6565114: Allow using system copies of libjpeg, libpng and giflib for splashscreen http://bugs.sun.com/view_bug.do?bug_id=6565114 I think that the scope of this RFE might be extended to support using system copies of the libraries for the core JDK as well, not only for the splashscreen. However, the RFE is currently closed as a "Future Project" because the contributed patch contains some issues and the contributor was not available for a while. See the review thread for details (a link is in the Description of the bug). In any case, if you plan to integrate such a change to OpenJDK 8, it should be reviewed here on the awt-dev@ and 2d-dev@ mailing lists. -- best regards, Anthony On 12/22/2012 11:15, Dmitry Samersoff wrote: > Anthony, > > Should we do it for all system or at least, > use bundled header for bundled library? > > -Dmitry > > -------- Original Message -------- > Subject: openjdk7 - use installed png and jpeg libraries > Date: Fri, 21 Dec 2012 22:24:02 -0500 > From: Mikhail T. > To: glewis at FreeBSD.org > CC: java at FreeBSD.org > > Hello! > > The attached diff teaches java/openjdk7 to rely on the > graphics/{png,jpeg} ports instead of compiling libpng and libjpeg from > sources bundled by Oracle. > > This is especially important for jpeg, because currently build uses the > already installed headers while compiling the bundled sources -- in case > of any discrepancies there may be nasty problems. > > It is also just cleaner and affords the use of better optimized image > libraries (such as assembly-optimized png and jpeg-turbo). > > Unfortunately, the port currently does not include check/regression-test > target, so I my limited testing consisted of simply restarting vuze -- > this worked, but I am not certain, it exercises the modified code. > > Please, take a look. Thank you! Yours, > > -mi > > > > From andrew.brygin at oracle.com Mon Dec 24 10:05:22 2012 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Mon, 24 Dec 2012 10:05:22 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 7124245: [lcms] ColorConvertOp to color space CS_GRAY apparently converts orange to 244, 244, 0 Message-ID: <20121224100607.6B6C847388@hg.openjdk.java.net> Changeset: 2cf07dbdee64 Author: bae Date: 2012-12-24 14:03 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2cf07dbdee64 7124245: [lcms] ColorConvertOp to color space CS_GRAY apparently converts orange to 244,244,0 Reviewed-by: prr ! src/share/classes/sun/java2d/cmm/lcms/LCMS.java ! src/share/classes/sun/java2d/cmm/lcms/LCMSImageLayout.java ! src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java ! src/share/native/sun/java2d/cmm/lcms/LCMS.c + test/sun/java2d/cmm/ColorConvertOp/GrayTest.java From dhd at exnet.com Mon Dec 24 10:10:27 2012 From: dhd at exnet.com (Damon Hart-Davis) Date: Mon, 24 Dec 2012 10:10:27 +0000 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <50D825D6.30708@oracle.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> <50D825D6.30708@oracle.com> Message-ID: <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> If done right then this might help deal with the worrying incompatibility I noted before between the colour space values/range between OpenJDK and Oracle JDK: http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002496.html Rgds Damon On 24 Dec 2012, at 09:52, Anthony Petrov wrote: > (CC'ing awt-dev@ and 2d-dev@) > > There's an RFE: > > 6565114: Allow using system copies of libjpeg, libpng and giflib for splashscreen > http://bugs.sun.com/view_bug.do?bug_id=6565114 > > I think that the scope of this RFE might be extended to support using system copies of the libraries for the core JDK as well, not only for the splashscreen. > > However, the RFE is currently closed as a "Future Project" because the contributed patch contains some issues and the contributor was not available for a while. See the review thread for details (a link is in the Description of the bug). > > In any case, if you plan to integrate such a change to OpenJDK 8, it should be reviewed here on the awt-dev@ and 2d-dev@ mailing lists. > > -- > best regards, > Anthony > > On 12/22/2012 11:15, Dmitry Samersoff wrote: >> Anthony, >> Should we do it for all system or at least, >> use bundled header for bundled library? >> -Dmitry >> -------- Original Message -------- >> Subject: openjdk7 - use installed png and jpeg libraries >> Date: Fri, 21 Dec 2012 22:24:02 -0500 >> From: Mikhail T. >> To: glewis at FreeBSD.org >> CC: java at FreeBSD.org >> Hello! >> The attached diff teaches java/openjdk7 to rely on the >> graphics/{png,jpeg} ports instead of compiling libpng and libjpeg from >> sources bundled by Oracle. >> This is especially important for jpeg, because currently build uses the >> already installed headers while compiling the bundled sources -- in case >> of any discrepancies there may be nasty problems. >> It is also just cleaner and affords the use of better optimized image >> libraries (such as assembly-optimized png and jpeg-turbo). >> Unfortunately, the port currently does not include check/regression-test >> target, so I my limited testing consisted of simply restarting vuze -- >> this worked, but I am not certain, it exercises the modified code. >> Please, take a look. Thank you! Yours, >> -mi > From andrew.brygin at oracle.com Mon Dec 24 10:24:20 2012 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Mon, 24 Dec 2012 10:24:20 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8005402: Need to provide benchmarks for color management Message-ID: <20121224102445.1177F47389@hg.openjdk.java.net> Changeset: 3c1c0b7abe51 Author: bae Date: 2012-12-24 14:22 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3c1c0b7abe51 8005402: Need to provide benchmarks for color management Reviewed-by: jgodinez, prr ! src/share/demo/java2d/J2DBench/build.xml ! src/share/demo/java2d/J2DBench/src/j2dbench/J2DBench.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/CMMTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/ColorConversionTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/ColorConvertOpTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/DataConversionTests.java + src/share/demo/java2d/J2DBench/src/j2dbench/tests/cmm/ProfileTests.java From philip.race at oracle.com Mon Dec 24 18:42:13 2012 From: philip.race at oracle.com (Phil Race) Date: Mon, 24 Dec 2012 10:42:13 -0800 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> <50D825D6.30708@oracle.com> <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> Message-ID: <50D8A205.3020507@oracle.com> libpng and giflib are used solely by splashscreen so I don't think that matters so much. Distro builds can do this fairly safely since they link against a known quantity. Perhaps not so much the Oracle JDK which builds on one distro but is run on many .. But jpeg might matter. Oracle JDK does not/cannot use the system libjpeg for all purposes because of some necessary proprietary code in the version used by ImageIO. So a change would have to be confined to the OpenJDK and even if done solely for splashscreen in Oracle JDK would mean two libjpegs being loaded .. BTW I responded on the thread you cite and mentioned this http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002509.html I do not believe that switching alone would fix anything here. I'd prefer at this point to defer such a change for jpeg to early in JDK 9. -phil. On 12/24/2012 2:10 AM, Damon Hart-Davis wrote: > If done right then this might help deal with the worrying incompatibility I noted before between the colour space values/range between OpenJDK and Oracle JDK: > > http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002496.html > > Rgds > > Damon > > > On 24 Dec 2012, at 09:52, Anthony Petrov wrote: > >> (CC'ing awt-dev@ and 2d-dev@) >> >> There's an RFE: >> >> 6565114: Allow using system copies of libjpeg, libpng and giflib for splashscreen >> http://bugs.sun.com/view_bug.do?bug_id=6565114 >> >> I think that the scope of this RFE might be extended to support using system copies of the libraries for the core JDK as well, not only for the splashscreen. >> >> However, the RFE is currently closed as a "Future Project" because the contributed patch contains some issues and the contributor was not available for a while. See the review thread for details (a link is in the Description of the bug). >> >> In any case, if you plan to integrate such a change to OpenJDK 8, it should be reviewed here on the awt-dev@ and 2d-dev@ mailing lists. >> >> -- >> best regards, >> Anthony >> >> On 12/22/2012 11:15, Dmitry Samersoff wrote: >>> Anthony, >>> Should we do it for all system or at least, >>> use bundled header for bundled library? >>> -Dmitry >>> -------- Original Message -------- >>> Subject: openjdk7 - use installed png and jpeg libraries >>> Date: Fri, 21 Dec 2012 22:24:02 -0500 >>> From: Mikhail T. >>> To: glewis at FreeBSD.org >>> CC: java at FreeBSD.org >>> Hello! >>> The attached diff teaches java/openjdk7 to rely on the >>> graphics/{png,jpeg} ports instead of compiling libpng and libjpeg from >>> sources bundled by Oracle. >>> This is especially important for jpeg, because currently build uses the >>> already installed headers while compiling the bundled sources -- in case >>> of any discrepancies there may be nasty problems. >>> It is also just cleaner and affords the use of better optimized image >>> libraries (such as assembly-optimized png and jpeg-turbo). >>> Unfortunately, the port currently does not include check/regression-test >>> target, so I my limited testing consisted of simply restarting vuze -- >>> this worked, but I am not certain, it exercises the modified code. >>> Please, take a look. Thank you! Yours, >>> -mi From philip.race at oracle.com Mon Dec 24 18:51:46 2012 From: philip.race at oracle.com (Phil Race) Date: Mon, 24 Dec 2012 10:51:46 -0800 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <50D8A2D3.8060105@oracle.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> <50D825D6.30708@oracle.com> <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> <50D8A205.3020507@oracle.com> <50D8A2D3.8060105@oracle.com> Message-ID: <50D8A442.9050707@oracle.com> On 12/24/2012 10:45 AM, Dmitry Samersoff wrote: > Phil, > > Thank you for the explanation. > > My main concern is a mismatch between jpeg library and header. > > i.e. if we use bundled libjpeg could we use bundled header as well. Do you mean "must we" ? I think that has to be a yes - they need to match. I don't see the diff but I'd think the first priority would be to make the bundled jpeg being used pick up its own headers during compilation. -phil. > -Dmitry > > > On 2012-12-24 22:42, Phil Race wrote: >> libpng and giflib are used solely by splashscreen so I don't think that >> matters so much. >> Distro builds can do this fairly safely since they link against a known >> quantity. >> Perhaps not so much the Oracle JDK which builds on one distro but is run >> on many .. >> >> But jpeg might matter. >> Oracle JDK does not/cannot use the system libjpeg for all purposes >> because of some necessary proprietary code in the version used by ImageIO. >> So a change would have to be confined to the OpenJDK and even if done >> solely for splashscreen in Oracle JDK would mean two libjpegs being >> loaded .. >> >> BTW I responded on the thread you cite and mentioned this >> http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002509.html >> I do not believe that switching alone would fix anything here. >> >> I'd prefer at this point to defer such a change for jpeg to early in JDK 9. >> >> -phil. >> >> On 12/24/2012 2:10 AM, Damon Hart-Davis wrote: >>> If done right then this might help deal with the worrying >>> incompatibility I noted before between the colour space values/range >>> between OpenJDK and Oracle JDK: >>> >>> http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002496.html >>> >>> Rgds >>> >>> Damon >>> >>> >>> On 24 Dec 2012, at 09:52, Anthony Petrov wrote: >>> >>>> (CC'ing awt-dev@ and 2d-dev@) >>>> >>>> There's an RFE: >>>> >>>> 6565114: Allow using system copies of libjpeg, libpng and giflib for >>>> splashscreen >>>> http://bugs.sun.com/view_bug.do?bug_id=6565114 >>>> >>>> I think that the scope of this RFE might be extended to support using >>>> system copies of the libraries for the core JDK as well, not only for >>>> the splashscreen. >>>> >>>> However, the RFE is currently closed as a "Future Project" because >>>> the contributed patch contains some issues and the contributor was >>>> not available for a while. See the review thread for details (a link >>>> is in the Description of the bug). >>>> >>>> In any case, if you plan to integrate such a change to OpenJDK 8, it >>>> should be reviewed here on the awt-dev@ and 2d-dev@ mailing lists. >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 12/22/2012 11:15, Dmitry Samersoff wrote: >>>>> Anthony, >>>>> Should we do it for all system or at least, >>>>> use bundled header for bundled library? >>>>> -Dmitry >>>>> -------- Original Message -------- >>>>> Subject: openjdk7 - use installed png and jpeg libraries >>>>> Date: Fri, 21 Dec 2012 22:24:02 -0500 >>>>> From: Mikhail T. >>>>> To: glewis at FreeBSD.org >>>>> CC: java at FreeBSD.org >>>>> Hello! >>>>> The attached diff teaches java/openjdk7 to rely on the >>>>> graphics/{png,jpeg} ports instead of compiling libpng and libjpeg from >>>>> sources bundled by Oracle. >>>>> This is especially important for jpeg, because currently build uses the >>>>> already installed headers while compiling the bundled sources -- in >>>>> case >>>>> of any discrepancies there may be nasty problems. >>>>> It is also just cleaner and affords the use of better optimized image >>>>> libraries (such as assembly-optimized png and jpeg-turbo). >>>>> Unfortunately, the port currently does not include >>>>> check/regression-test >>>>> target, so I my limited testing consisted of simply restarting vuze -- >>>>> this worked, but I am not certain, it exercises the modified code. >>>>> Please, take a look. Thank you! Yours, >>>>> -mi > From dmitry.samersoff at oracle.com Mon Dec 24 18:45:39 2012 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Mon, 24 Dec 2012 22:45:39 +0400 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <50D8A205.3020507@oracle.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> <50D825D6.30708@oracle.com> <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> <50D8A205.3020507@oracle.com> Message-ID: <50D8A2D3.8060105@oracle.com> Phil, Thank you for the explanation. My main concern is a mismatch between jpeg library and header. i.e. if we use bundled libjpeg could we use bundled header as well. -Dmitry On 2012-12-24 22:42, Phil Race wrote: > libpng and giflib are used solely by splashscreen so I don't think that > matters so much. > Distro builds can do this fairly safely since they link against a known > quantity. > Perhaps not so much the Oracle JDK which builds on one distro but is run > on many .. > > But jpeg might matter. > Oracle JDK does not/cannot use the system libjpeg for all purposes > because of some necessary proprietary code in the version used by ImageIO. > So a change would have to be confined to the OpenJDK and even if done > solely for splashscreen in Oracle JDK would mean two libjpegs being > loaded .. > > BTW I responded on the thread you cite and mentioned this > http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002509.html > I do not believe that switching alone would fix anything here. > > I'd prefer at this point to defer such a change for jpeg to early in JDK 9. > > -phil. > > On 12/24/2012 2:10 AM, Damon Hart-Davis wrote: >> If done right then this might help deal with the worrying >> incompatibility I noted before between the colour space values/range >> between OpenJDK and Oracle JDK: >> >> http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002496.html >> >> Rgds >> >> Damon >> >> >> On 24 Dec 2012, at 09:52, Anthony Petrov wrote: >> >>> (CC'ing awt-dev@ and 2d-dev@) >>> >>> There's an RFE: >>> >>> 6565114: Allow using system copies of libjpeg, libpng and giflib for >>> splashscreen >>> http://bugs.sun.com/view_bug.do?bug_id=6565114 >>> >>> I think that the scope of this RFE might be extended to support using >>> system copies of the libraries for the core JDK as well, not only for >>> the splashscreen. >>> >>> However, the RFE is currently closed as a "Future Project" because >>> the contributed patch contains some issues and the contributor was >>> not available for a while. See the review thread for details (a link >>> is in the Description of the bug). >>> >>> In any case, if you plan to integrate such a change to OpenJDK 8, it >>> should be reviewed here on the awt-dev@ and 2d-dev@ mailing lists. >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 12/22/2012 11:15, Dmitry Samersoff wrote: >>>> Anthony, >>>> Should we do it for all system or at least, >>>> use bundled header for bundled library? >>>> -Dmitry >>>> -------- Original Message -------- >>>> Subject: openjdk7 - use installed png and jpeg libraries >>>> Date: Fri, 21 Dec 2012 22:24:02 -0500 >>>> From: Mikhail T. >>>> To: glewis at FreeBSD.org >>>> CC: java at FreeBSD.org >>>> Hello! >>>> The attached diff teaches java/openjdk7 to rely on the >>>> graphics/{png,jpeg} ports instead of compiling libpng and libjpeg from >>>> sources bundled by Oracle. >>>> This is especially important for jpeg, because currently build uses the >>>> already installed headers while compiling the bundled sources -- in >>>> case >>>> of any discrepancies there may be nasty problems. >>>> It is also just cleaner and affords the use of better optimized image >>>> libraries (such as assembly-optimized png and jpeg-turbo). >>>> Unfortunately, the port currently does not include >>>> check/regression-test >>>> target, so I my limited testing consisted of simply restarting vuze -- >>>> this worked, but I am not certain, it exercises the modified code. >>>> Please, take a look. Thank you! Yours, >>>> -mi > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * Give Rabbit time, and he'll always get the answer From dmitry.samersoff at oracle.com Mon Dec 24 18:58:40 2012 From: dmitry.samersoff at oracle.com (Dmitry Samersoff) Date: Mon, 24 Dec 2012 22:58:40 +0400 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <50D8A442.9050707@oracle.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> <50D825D6.30708@oracle.com> <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> <50D8A205.3020507@oracle.com> <50D8A2D3.8060105@oracle.com> <50D8A442.9050707@oracle.com> Message-ID: <50D8A5E0.30109@oracle.com> Phil, Thanks! Could someone from java2d team file a bug to have it fixed? -Dmitry On 2012-12-24 22:51, Phil Race wrote: > On 12/24/2012 10:45 AM, Dmitry Samersoff wrote: >> Phil, >> >> Thank you for the explanation. >> >> My main concern is a mismatch between jpeg library and header. >> >> i.e. if we use bundled libjpeg could we use bundled header as well. > > Do you mean "must we" ? I think that has to be a yes - they need to match. > I don't see the diff but I'd think the first priority would be to make > the bundled > jpeg being used pick up its own headers during compilation. > > -phil. > >> -Dmitry >> >> >> On 2012-12-24 22:42, Phil Race wrote: >>> libpng and giflib are used solely by splashscreen so I don't think that >>> matters so much. >>> Distro builds can do this fairly safely since they link against a known >>> quantity. >>> Perhaps not so much the Oracle JDK which builds on one distro but is run >>> on many .. >>> >>> But jpeg might matter. >>> Oracle JDK does not/cannot use the system libjpeg for all purposes >>> because of some necessary proprietary code in the version used by >>> ImageIO. >>> So a change would have to be confined to the OpenJDK and even if done >>> solely for splashscreen in Oracle JDK would mean two libjpegs being >>> loaded .. >>> >>> BTW I responded on the thread you cite and mentioned this >>> http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002509.html >>> I do not believe that switching alone would fix anything here. >>> >>> I'd prefer at this point to defer such a change for jpeg to early in >>> JDK 9. >>> >>> -phil. >>> >>> On 12/24/2012 2:10 AM, Damon Hart-Davis wrote: >>>> If done right then this might help deal with the worrying >>>> incompatibility I noted before between the colour space values/range >>>> between OpenJDK and Oracle JDK: >>>> >>>> http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002496.html >>>> >>>> Rgds >>>> >>>> Damon >>>> >>>> >>>> On 24 Dec 2012, at 09:52, Anthony Petrov wrote: >>>> >>>>> (CC'ing awt-dev@ and 2d-dev@) >>>>> >>>>> There's an RFE: >>>>> >>>>> 6565114: Allow using system copies of libjpeg, libpng and giflib for >>>>> splashscreen >>>>> http://bugs.sun.com/view_bug.do?bug_id=6565114 >>>>> >>>>> I think that the scope of this RFE might be extended to support using >>>>> system copies of the libraries for the core JDK as well, not only for >>>>> the splashscreen. >>>>> >>>>> However, the RFE is currently closed as a "Future Project" because >>>>> the contributed patch contains some issues and the contributor was >>>>> not available for a while. See the review thread for details (a link >>>>> is in the Description of the bug). >>>>> >>>>> In any case, if you plan to integrate such a change to OpenJDK 8, it >>>>> should be reviewed here on the awt-dev@ and 2d-dev@ mailing lists. >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>>> >>>>> On 12/22/2012 11:15, Dmitry Samersoff wrote: >>>>>> Anthony, >>>>>> Should we do it for all system or at least, >>>>>> use bundled header for bundled library? >>>>>> -Dmitry >>>>>> -------- Original Message -------- >>>>>> Subject: openjdk7 - use installed png and jpeg libraries >>>>>> Date: Fri, 21 Dec 2012 22:24:02 -0500 >>>>>> From: Mikhail T. >>>>>> To: glewis at FreeBSD.org >>>>>> CC: java at FreeBSD.org >>>>>> Hello! >>>>>> The attached diff teaches java/openjdk7 to rely on the >>>>>> graphics/{png,jpeg} ports instead of compiling libpng and libjpeg >>>>>> from >>>>>> sources bundled by Oracle. >>>>>> This is especially important for jpeg, because currently build >>>>>> uses the >>>>>> already installed headers while compiling the bundled sources -- in >>>>>> case >>>>>> of any discrepancies there may be nasty problems. >>>>>> It is also just cleaner and affords the use of better optimized image >>>>>> libraries (such as assembly-optimized png and jpeg-turbo). >>>>>> Unfortunately, the port currently does not include >>>>>> check/regression-test >>>>>> target, so I my limited testing consisted of simply restarting >>>>>> vuze -- >>>>>> this worked, but I am not certain, it exercises the modified code. >>>>>> Please, take a look. Thank you! Yours, >>>>>> -mi >> > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * Give Rabbit time, and he'll always get the answer From philip.race at oracle.com Mon Dec 24 19:24:13 2012 From: philip.race at oracle.com (Phil Race) Date: Mon, 24 Dec 2012 11:24:13 -0800 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <50D8A654.7020806@aldan.algebra.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> <50D825D6.30708@oracle.com> <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> <50D8A205.3020507@oracle.com> <50D8A654.7020806@aldan.algebra.com> Message-ID: <50D8ABDD.7060803@oracle.com> Yes I know. I was the one who did that about 6 years ago now :-) They have to be disabled since OpenJDK doesn't have the sources. I am pointing out that anyone changing how this is built would need to be careful not to break that. -phil. On 12/24/2012 11:00 AM, Mikhail T. wrote: > On 24.12.2012 13:42, Phil Race wrote: >> But jpeg might matter. >> Oracle JDK does not/cannot use the system libjpeg for all purposes >> because of some necessary proprietary code in the version used by >> ImageIO. >> So a change would have to be confined to the OpenJDK and even if done >> solely for splashscreen in Oracle JDK would mean two libjpegs being >> loaded .. > The proprietary JPEG-extensions are already disabled in the Makefile, > when building OpenJDK (as opposite to Oracle JDK). From > openjdk/jdk/make/sun/jpeg/Makefile > > ... > # OpenJDK doesn't use the non-standard jpeg classes which we hope > to remove. > ifndef OPENJDK > FILES_m = mapfile-vers-closed > FILES_export += \ > sun/awt/image/codec/JPEGImageDecoderImpl.java \ > sun/awt/image/codec/JPEGImageEncoderImpl.java > vpath %.c $(CLOSED_SRC)/share/native/$(PKGDIR)/image/jpeg > OTHER_INCLUDES += -I$(CLOSED_SRC)/share/native/$(PKGDIR)/image/jpeg > endif > ... > > So, I don't think, this is still a concern (with OpenJDK, that is). Yours, > > -mi > From philip.race at oracle.com Mon Dec 24 21:21:51 2012 From: philip.race at oracle.com (Phil Race) Date: Mon, 24 Dec 2012 13:21:51 -0800 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <1593565117-1356383065-cardhu_decombobulator_blackberry.rim.net-1607923238-@b28.c8.bise6.blackberry> References: <1593565117-1356383065-cardhu_decombobulator_blackberry.rim.net-1607923238-@b28.c8.bise6.blackberry> Message-ID: <50D8C76F.9030604@oracle.com> On 12/24/2012 1:04 PM, Mikhail T. wrote: > Are the JPEG-proprietary extensions so invasive, the whole library must be replaced, or can they be made into an add-on? Invasive. If it were possible to make it an add-on I would have done it 6 years ago. -phil. From alexey.utkin at oracle.com Tue Dec 25 14:47:56 2012 From: alexey.utkin at oracle.com (Alexey Utkin) Date: Tue, 25 Dec 2012 18:47:56 +0400 Subject: [OpenJDK 2D-Dev] Review request: JDK-8005250 Downgrade normative references to ${java.home}/lib folder from Java client code. Message-ID: <50D9BC9C.5060103@oracle.com> The bug description: http://bugs.sun.com/view_bug.do?bug_id=8005250 The suggested fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8005250/webrev.01/ The specification change: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8005250/specdiff.01/overview-summary.html Problem: As part of the effort to prepare the platform for modules (see http://openjdk.java.net/jeps/162) we need to re-examine all normative references to files/resources in the ${java.home} directory as these may be candidates to be replaced or candidates to move to module-private locations in the future. The focus of this fix is various client APIs that specify that the default values of client properties are loaded from property files in ${java.home}/lib directory. We need the flexibility to be able to re-locate the property files when we move to modules and a module image in jdk9. Solution: Change the specification to downgrade normative references to ${java.home}/lib directory to non-normative status. All references to this directory have been removed from external or private client APIs. Compatibility risk: minimal There is no compatibility risk as the implementation of the applicable APIs always call the specialized methods to retrieve the values of client properties, and that implementation will continue to pre-populate any properties that have been set in the properties files in ${java.home}/lib directory. Notes have been added to the class summaries of the java.awt.datatransfer.SystemFlavorMap, javax.swing.UIManager, javax.sound.midi.MidiSystem, javax.sound.sampled.AudioSystem, javax.imageio.spi.IIORegistry APIs to state that default values for client properties are read from an implementation-specific location, and the location is typically the ${java.home}/lib directory. Regards, -uta From mi+bb2012 at aldan.algebra.com Mon Dec 24 21:04:24 2012 From: mi+bb2012 at aldan.algebra.com (Mikhail T.) Date: Mon, 24 Dec 2012 21:04:24 +0000 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries Message-ID: <1593565117-1356383065-cardhu_decombobulator_blackberry.rim.net-1607923238-@b28.c8.bise6.blackberry> Are the JPEG-proprietary extensions so invasive, the whole library must be replaced, or can they be made into an add-on? -- Sent from my BlackBerry From mi+thun at aldan.algebra.com Mon Dec 24 19:00:36 2012 From: mi+thun at aldan.algebra.com (Mikhail T.) Date: Mon, 24 Dec 2012 14:00:36 -0500 Subject: [OpenJDK 2D-Dev] Fwd: openjdk7 - use installed png and jpeg libraries In-Reply-To: <50D8A205.3020507@oracle.com> References: <50D527D2.9060100@aldan.algebra.com> <50D55E14.4080704@oracle.com> <50D825D6.30708@oracle.com> <073DD4E5-CC84-44FC-B559-90E994A0B5AF@exnet.com> <50D8A205.3020507@oracle.com> Message-ID: <50D8A654.7020806@aldan.algebra.com> On 24.12.2012 13:42, Phil Race wrote: > But jpeg might matter. > Oracle JDK does not/cannot use the system libjpeg for all purposes > because of some necessary proprietary code in the version used by > ImageIO. > So a change would have to be confined to the OpenJDK and even if done > solely for splashscreen in Oracle JDK would mean two libjpegs being > loaded .. The proprietary JPEG-extensions are already disabled in the Makefile, when building OpenJDK (as opposite to Oracle JDK). From openjdk/jdk/make/sun/jpeg/Makefile ... # OpenJDK doesn't use the non-standard jpeg classes which we hope to remove. ifndef OPENJDK FILES_m = mapfile-vers-closed FILES_export += \ sun/awt/image/codec/JPEGImageDecoderImpl.java \ sun/awt/image/codec/JPEGImageEncoderImpl.java vpath %.c $(CLOSED_SRC)/share/native/$(PKGDIR)/image/jpeg OTHER_INCLUDES += -I$(CLOSED_SRC)/share/native/$(PKGDIR)/image/jpeg endif ... So, I don't think, this is still a concern (with OpenJDK, that is). Yours, -mi -------------- next part -------------- An HTML attachment was scrubbed... URL: From mikhail.cherkasov at oracle.com Sat Dec 29 12:00:56 2012 From: mikhail.cherkasov at oracle.com (mikhail cherkasov) Date: Sat, 29 Dec 2012 16:00:56 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005492: Reduce number of warnings in sun/awt/* classes In-Reply-To: <50DED652.10706@oracle.com> References: <50DEC8C0.5090503@oracle.com> <50DECF29.60302@oracle.com> <50DED652.10706@oracle.com> Message-ID: <50DEDB78.2050707@oracle.com> Hello 2d Team, Could you please review changes in FontMetrics and Graphics classes? http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/ Thanks, Mikhail. 29.12.2012 15:38, Artem Ananiev ?????: > Hi, Mikhail, > > On 12/29/2012 3:08 PM, mikhail cherkasov wrote: >> I'm not sure about replacing getPeer() with peer, but I didn't find >> any overriding inside JDK and I've no idea for what reason users >> would do this. > > getPeer() is deprecated, so it shouldn't be used by applications. I > don't have any preferences whether to use peer or getPeer(), probably > the best way is to leave everything as is. > > In general, the webrev look fine, except Charset changes in > FontMetrics and Graphics. Please, contact Java2D team about this part > of the webrev. > > Thanks, > > Artem > >> Anyway if you thinks that change breaks compatibility, please notify >> me ASAP, I'll prepare new patch and will stop breaking other classes. >> >> Thanks, >> Mikhail. >> >> >> 29.12.2012 14:41, mikhail cherkasov ?????: >>> Hello All, >>> >>> Please review the following patch: >>> >>> webrev: http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/ >>> >>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005492 >>> >>> the following classes was cleaned from warnings: >>> src/share/classes/java/awt/Button.java >>> src/share/classes/java/awt/Canvas.java >>> src/share/classes/java/awt/Checkbox.java >>> src/share/classes/java/awt/Choice.java >>> src/share/classes/java/awt/Component.java >>> src/share/classes/java/awt/Container.java >>> src/share/classes/java/awt/Dialog.java >>> src/share/classes/java/awt/FontMetrics.java >>> src/share/classes/java/awt/Frame.java >>> src/share/classes/java/awt/Graphics.java >>> src/share/classes/java/awt/KeyboardFocusManager.java >>> src/share/classes/java/awt/ScrollPane.java >>> src/share/classes/java/awt/Scrollbar.java >>> src/share/classes/java/awt/TextArea.java >>> src/share/classes/java/awt/TextComponent.java >>> src/share/classes/java/awt/TextField.java >>> src/share/classes/java/awt/Toolkit.java >>> src/share/classes/java/awt/Window.java >>> src/share/classes/sun/awt/image/SurfaceManager.java >>> >>> Thanks, >>> Mikhail. >> From philip.race at oracle.com Sat Dec 29 15:03:14 2012 From: philip.race at oracle.com (Phil Race) Date: Sat, 29 Dec 2012 07:03:14 -0800 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005492: Reduce number of warnings in sun/awt/* classes In-Reply-To: <50DEDB78.2050707@oracle.com> References: <50DEC8C0.5090503@oracle.com> <50DECF29.60302@oracle.com> <50DED652.10706@oracle.com> <50DEDB78.2050707@oracle.com> Message-ID: <50DF0632.5080604@oracle.com> The drawString one is an incompatible change as before the platform's default charset would be used, now you are explicitly using ISO 8859 So long as the two agree, no problem, but that is not assured. In general changing long standing API like this to get rid of deprecation warnings is something I would steer well clear of. -phil. On 12/29/12 4:00 AM, mikhail cherkasov wrote: > Hello 2d Team, > > Could you please review changes in FontMetrics and Graphics classes? > http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/ > > > Thanks, > Mikhail. > > 29.12.2012 15:38, Artem Ananiev ?????: >> Hi, Mikhail, >> >> On 12/29/2012 3:08 PM, mikhail cherkasov wrote: >>> I'm not sure about replacing getPeer() with peer, but I didn't find >>> any overriding inside JDK and I've no idea for what reason users >>> would do this. >> >> getPeer() is deprecated, so it shouldn't be used by applications. I >> don't have any preferences whether to use peer or getPeer(), probably >> the best way is to leave everything as is. >> >> In general, the webrev look fine, except Charset changes in >> FontMetrics and Graphics. Please, contact Java2D team about this part >> of the webrev. >> >> Thanks, >> >> Artem >> >>> Anyway if you thinks that change breaks compatibility, please notify >>> me ASAP, I'll prepare new patch and will stop breaking other classes. >>> >>> Thanks, >>> Mikhail. >>> >>> >>> 29.12.2012 14:41, mikhail cherkasov ?????: >>>> Hello All, >>>> >>>> Please review the following patch: >>>> >>>> webrev: http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/ >>>> >>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005492 >>>> >>>> the following classes was cleaned from warnings: >>>> src/share/classes/java/awt/Button.java >>>> src/share/classes/java/awt/Canvas.java >>>> src/share/classes/java/awt/Checkbox.java >>>> src/share/classes/java/awt/Choice.java >>>> src/share/classes/java/awt/Component.java >>>> src/share/classes/java/awt/Container.java >>>> src/share/classes/java/awt/Dialog.java >>>> src/share/classes/java/awt/FontMetrics.java >>>> src/share/classes/java/awt/Frame.java >>>> src/share/classes/java/awt/Graphics.java >>>> src/share/classes/java/awt/KeyboardFocusManager.java >>>> src/share/classes/java/awt/ScrollPane.java >>>> src/share/classes/java/awt/Scrollbar.java >>>> src/share/classes/java/awt/TextArea.java >>>> src/share/classes/java/awt/TextComponent.java >>>> src/share/classes/java/awt/TextField.java >>>> src/share/classes/java/awt/Toolkit.java >>>> src/share/classes/java/awt/Window.java >>>> src/share/classes/sun/awt/image/SurfaceManager.java >>>> >>>> Thanks, >>>> Mikhail. >>> > From helbrass at gmail.com Sun Dec 30 20:06:03 2012 From: helbrass at gmail.com (Helbrass) Date: Sun, 30 Dec 2012 22:06:03 +0200 Subject: [OpenJDK 2D-Dev] what is X11FontScaler? Message-ID: Hi All! Sorry for dumb question, but what's X11FontScaler? Is it used together with freetypeScaler or instead of it? Could not find any info anywhere. In build system it looks like it is build but I can't find it used on java side... Thanx in advance. From anton.litvinov at oracle.com Sat Dec 29 13:44:12 2012 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Sat, 29 Dec 2012 17:44:12 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux Message-ID: <50DEF3AC.2070600@oracle.com> Hello, Please review the following fix for a bug. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 https://jbs.oracle.com/bugs/browse/JDK-8005607 Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 The bug consists in a crash which is caused by a stack overflow for the reason of an infinite recursion in AWT native function J2DXErrHandler() under certain circumstances on 32-bit Linux OS. The fix is based on introduction of the logic, which detects indirect recursive calls to J2DXErrHandler() by means of a simple counter, to J2DXErrHandler() native function. Such a solution requires minimum code changes, does not alter the handler's code significantly and eliminates this bug. Adding 2d-dev at openjdk.java.net e-mail alias to the list of recipients of this letter, because the edited function's name is related to Java 2D area of JDK, despite of the fact that the edited file is located in AWT directory. Thank you, Anton