[OpenJDK 2D-Dev] Request for review: : [NEW BUG] Printer - tempfile having incorrect extension

Jonathan Lu luchsh at linux.vnet.ibm.com
Wed Dec 12 05:37:48 UTC 2012


Hello Andrew,

Thanks a lot for reviewing,
I've pushed the patch @ 
http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e8b54ae97344

Cheers
- Jonathan

On 12/11/2012 05:59 PM, Andrew Brygin wrote:
> Hello Jonathan,
>
>  the change looks fine to me.
>
> Thanks,
> Andrew
>
> On 11.12.2012 13:14, Jonathan Lu wrote:
>> Thanks a lot, Jannifer!
>>
>> Could anybody else please help to take a look?
>>
>> Best regards
>> - Jonathan
>>
>> On 12/05/2012 12:22 AM, Jennifer Godinez wrote:
>>> I approve the change but we need one more reviewer before pushing 
>>> the change.
>>>
>>> Jennifer
>>>
>>> On 12/3/2012 10:26 PM, jayashree viswanathan wrote:
>>>> On 03-12-2012 11:28 AM, jayashree viswanathan wrote:
>>>>> On 13-09-2012 7:35 PM, jayashree viswanathan wrote:
>>>>>> Hi ,
>>>>>>
>>>>>> Looking for a reviewer for a change request  .
>>>>>>
>>>>>> Problem statement:
>>>>>>  In UnixPrintJob class while constructing a lpr command to queue up
>>>>>> the jobs, we are creating tempfile with .ps extension .
>>>>>> The content of the tempfile will not have appropriate postscript
>>>>>> header[like PSPrinterJob], rather just the data to be printed .
>>>>>> In certain environments[ex., RHEL 6.1]  this causes failure and even
>>>>>> the native command [lpr] as constructed by Java just queues up 
>>>>>> the job
>>>>>> but doesn't prints them.
>>>>>>
>>>>>> webrev for the change is available at
>>>>>> http://cr.openjdk.java.net/~shirishk/20120913_02/webrev.01/
>>>>>>
>>>>>> Thanks and Regards,
>>>>>> Jayashree Viswanathan
>>>>>>
>>>>> Hi ,
>>>>>
>>>>> If you raise a sun bug , can you please share the number ?
>>>>>
>>>>> Thanks and Regards,
>>>>> Jayashree Viswanathan
>>>> Thanks Jennifer for sharing the bug number . It is 8004316 . I see 
>>>> that it is yet to be available in sun bug database and might be 
>>>> available soon .
>>>>
>>>> If you are happy with the fix can you please push the change ?
>>>>
>>>> Thanks and Regards,
>>>> Jayashree Viswanathan
>>>>
>>>
>>
>




More information about the 2d-dev mailing list