[OpenJDK 2D-Dev] Request for review: 7151427: Potential memory leak in error handling code in X11SurfaceData.c

[Phil Race]

Looks OK to me.  Just one question. Was the part in
X11SD_DisposeXImage() a necessary change? My guess is
no and that you observed XDestroyImage() does the free()
and XFree() for us, so this is just to have some cleaner code.

Also you should try to find one more qualified reviewer as the
general client area policy is 2 reviewers.

-phil.


On 3/6/2012 1:07 AM, Sean Chou wrote:
> Hi all,
>
>     The error handling code in X11SurfaceData.c does not free all the 
> memory allocated, it rarely causes problems because applications 
> almost never go there. However, we got one machine actually 
> encountered this problem.
>     Although there is no simple testcase for this bug, it is so 
> obvious that we just need read the code.
>
>     I reported a bug (7151427) for it and the webrev is at:
> http://cr.openjdk.java.net/~zhouyx/7151427/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ezhouyx/7151427/webrev.00/>  .
>
>     Can anyone take a look ? Thanks.
>
> -- 
> Best Regards,
> Sean Chou
>