[OpenJDK 2D-Dev] [PATCH FOR REVIEW] Minor clean-up of jdk/src/share/classes/sun/font/SunFontManager.java

Phil Race philip.race at oracle.com
Fri Oct 26 16:38:48 UTC 2012


It might look cleaner but its probably slower in practice as toLowerCase()
on the full font names will generate a lot of garbage and it does a fair 
amount of work,
and endsWidth(..) is implemented by calling startsWith() and calculating the
appropriate offset, so you added the method call overhead there too.

Regardless, this doesn't seem to be sufficiently important to backport.

-phil.

On 10/26/12 7:34 AM, Jiri Vanek wrote:
> Hi!
>
> I would like to offer this minor clean-up of 
> jdk/src/share/classes/sun/font/SunFontManager.java.
>
> WebRev can be found here: 
> http://jvanek.fedorapeople.org/oracle/jdk8/webrevs/sunFontManagerMinorCleanUp/
>
> If this changeset will be found worthy to be accepted to OpenJDK, will 
> it be possible to backport it also to OpenJDK7?
>
> With kind regards
> Jiri Vanek




More information about the 2d-dev mailing list