[OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for bug 8011693: Remove redundant fontconfig files

Vladislav Karnaukhov Vladislav.Karnaukhov at oracle.com
Mon Apr 8 12:39:05 UTC 2013


Hi Jiri,

I've tested Windows build (fresh open jdk8 clone + your patch) and 
unfortunately it failed:

=========================================================
BUILDTOOL:                commentchecker
PACKAGE:                  build.tools.commentchecker
BUILDTOOL_SOURCE_ROOT:    ../../tools/src
BUILTTOOL_MAINCLASS:      build.tools.commentchecker.CommentChecker
BUILDTOOL_JAR_FILE:       c:/build/jdk8-open-debug/btjars/commentchecker.jar
=========================================================
make[4]: Leaving directory 
`/cygdrive/c/projects/jdk8-open/jdk/make/tools/commentchecker'
make: Entering an unknown directory
make: *** compile_font_config: No such file or directory.  Stop.
make: Leaving an unknown directory
make[3]: *** [all] Error 1
make[3]: Leaving directory `/cygdrive/c/projects/jdk8-open/jdk/make/tools'
make[2]: *** [all] Error 1
make[2]: Leaving directory `/cygdrive/c/projects/jdk8-open/jdk/make'
make[1]: *** [jdk-build] Error 2
make[1]: Leaving directory `/cygdrive/c/projects/jdk8-open'
make: *** [build_product_image] Error 2

I hope this will help.

Regards,
- Vlad

On 4/8/2013 03:35 PM, Jiri Vanek wrote:
> On 04/08/2013 01:13 PM, Vladislav Karnaukhov wrote:
>> I'm quite surprised to hear that fontconfig.properties file are now
>> redundant... I've worked on some
>> fontconfig issues just recently, and I cannot say that fontconfig.*
>> files are in any way
>> "unnecessary"...
>>
>> A removal of fontconfig.* files will require a very thorough
>> re-evaluation and re-design of many JDK
>> classes, as well a very exhaustive testing.
>>
>> Am I missing something here?
>
> Yap, I guess you do.
> Try to remove them, and you can be surprised that your configurations
> will work better then with them.
>
> Probably better then my words will be to read Phils answers from nearly
> year ago:
> http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002528.html
> and especially
> http://mail.openjdk.java.net/pipermail/2d-dev/2012-May/002547.html
>
> However, I'm 100% sure just for linux based builds. For windows I'm
> going to test later, but have no idea where to test Mac....
>
> Please note, this is for jdk7+8. Jdk6 still needs those config files.
>
> Best regards,
>     J.
>
>> On 4/8/2013 02:53 PM, Jiri Vanek wrote:
>>> Hi!
>>>
>>> As fontconfig.properties  files are no longer necessary for jdk7/8 and
>>> theirs deletion was suggested above, I would like to offer this
>>> clean-up[1] for jdk8(7 if possible later too)
>>>
>>> I have tested on fedora, and jdk8 built and run correctly.
>>>
>>>
>>>   Best regards
>>>     Jiri Vanek
>>>
>>>
>>> [1]
>>> http://jvanek.fedorapeople.org/oracle/jdk8/webrevs/removedFontConfigFiles/
>>>
>>
>>
>





More information about the 2d-dev mailing list