From lana.steuck at oracle.com Fri Feb 1 03:26:37 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 01 Feb 2013 03:26:37 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d: 24 new changesets Message-ID: <20130201032642.8DE3B47728@hg.openjdk.java.net> Changeset: 50307da0149e Author: jqzuo Date: 2012-12-31 14:52 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/rev/50307da0149e 8005583: Install build(gnumake all) failed preventing RE from doing JDK8 combo builds Reviewed-by: paulk, billyh ! make/install-rules.gmk Changeset: e5664599a127 Author: cgruszka Date: 2013-01-02 14:54 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/rev/e5664599a127 Merge Changeset: 75634cbeab47 Author: cgruszka Date: 2013-01-04 13:11 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/rev/75634cbeab47 Merge Changeset: 61d7e2971723 Author: cgruszka Date: 2013-01-14 14:40 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/rev/61d7e2971723 Merge Changeset: f9163f9cb1da Author: cgruszka Date: 2013-01-23 08:50 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/rev/f9163f9cb1da Merge Changeset: 5a5e97f9ac0a Author: erikj Date: 2013-01-18 09:58 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/5a5e97f9ac0a 8006520: build-infra: Fix sparkle-framework configure parameter Reviewed-by: tbell, ohair ! common/autoconf/generated-configure.sh ! common/makefiles/Jprt.gmk Changeset: edad83acbd46 Author: erikj Date: 2013-01-18 16:48 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/edad83acbd46 8003693: build-infra: bridgeBuild should allow for partial build (no hotspot) Reviewed-by: tbell ! common/makefiles/Jprt.gmk Changeset: c3bf62746a80 Author: tbell Date: 2013-01-23 13:30 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/c3bf62746a80 8006797: build-infra JPRT builds need JPRT_ARCHIVE_INSTALL_BUNDLE in common/makefiles/Jprt.gmk Reviewed-by: ohair ! common/makefiles/Jprt.gmk Changeset: b43aa5bd8ca5 Author: katleman Date: 2013-01-23 15:40 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/b43aa5bd8ca5 Merge Changeset: cd2fa0d0ed3d Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/cd2fa0d0ed3d Added tag jdk8-b74 for changeset b43aa5bd8ca5 ! .hgtags Changeset: 1129fb75f611 Author: jjg Date: 2013-01-10 19:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/1129fb75f611 8004834: Add doclint support into javadoc Reviewed-by: erikj, tbell ! common/makefiles/javadoc/Javadoc.gmk Changeset: cecfba251e4a Author: lana Date: 2013-01-16 11:58 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/cecfba251e4a Merge Changeset: 2e12a508d7ae Author: lana Date: 2013-01-20 23:35 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/2e12a508d7ae Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers ! common/makefiles/javadoc/Javadoc.gmk Changeset: 8209c91b751d Author: sherman Date: 2013-01-22 21:02 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/8209c91b751d 8003680: JSR 310 Date/Time API Summary: Integration of JSR310 Date/Time API for M6 Reviewed-by: alanb, naoto, dholmes Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, richard.warburton at gmail.com, misterm at gmail.com ! common/makefiles/javadoc/CORE_PKGS.gmk ! make/jprt.properties ! test/Makefile Changeset: 039783b67959 Author: lana Date: 2013-01-26 18:24 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/039783b67959 Merge Changeset: e28985c549aa Author: raginip Date: 2013-01-18 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/e28985c549aa 8000839: Integrate the Java Access Bridge with Java Runtime Reviewed-by: ptbrunet, erikj ! common/bin/compare_exceptions.sh.incl Changeset: db46b1c27a93 Author: erikj Date: 2013-01-28 14:23 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/db46b1c27a93 Merge - common/autoconf/closed.version.numbers ! common/autoconf/generated-configure.sh - common/autoconf/version.numbers ! common/bin/compare_exceptions.sh.incl Changeset: 8baaaba2ee6b Author: lana Date: 2013-01-29 20:16 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/8baaaba2ee6b Merge Changeset: 0d4b0a13adb2 Author: erikj Date: 2013-01-23 11:37 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/0d4b0a13adb2 8005855: build-infra: Remove -R flag when cross compiling Reviewed-by: dholmes, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: ea6379d4624f Author: erikj Date: 2013-01-23 11:41 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/ea6379d4624f 8006663: build-infra: Compare two arbitrary zip/jar files with compare.sh Reviewed-by: tbell ! common/bin/compare.sh Changeset: 0d46733cfffb Author: erikj Date: 2013-01-23 11:42 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/0d46733cfffb 8006658: build-infra: Make MILESTONE behave the same as JDK_BUILD_NUMBER Reviewed-by: ohrstrom, dholmes, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: 9e5847257731 Author: erikj Date: 2013-01-24 09:17 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/9e5847257731 Merge Changeset: 2a713921952c Author: katleman Date: 2013-01-30 13:39 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/2a713921952c Merge ! common/autoconf/generated-configure.sh Changeset: 5b19cef637a6 Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/5b19cef637a6 Added tag jdk8-b75 for changeset 2a713921952c ! .hgtags From lana.steuck at oracle.com Fri Feb 1 03:26:37 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 01 Feb 2013 03:26:37 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/corba: 2 new changesets Message-ID: <20130201032643.E8B0F47729@hg.openjdk.java.net> Changeset: d4e68ce17795 Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/d4e68ce17795 Added tag jdk8-b74 for changeset 2132845cf5f7 ! .hgtags Changeset: 4a6be02e66a3 Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/4a6be02e66a3 Added tag jdk8-b75 for changeset d4e68ce17795 ! .hgtags From lana.steuck at oracle.com Fri Feb 1 03:26:44 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 01 Feb 2013 03:26:44 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxws: 2 new changesets Message-ID: <20130201032657.4FFB74772A@hg.openjdk.java.net> Changeset: 966bf9f3c41a Author: katleman Date: 2013-01-24 16:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/966bf9f3c41a Added tag jdk8-b74 for changeset 12db3c5a3393 ! .hgtags Changeset: a63ef2391c20 Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/a63ef2391c20 Added tag jdk8-b75 for changeset 966bf9f3c41a ! .hgtags From lana.steuck at oracle.com Fri Feb 1 03:26:44 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 01 Feb 2013 03:26:44 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxp: 6 new changesets Message-ID: <20130201032721.A66054772B@hg.openjdk.java.net> Changeset: 69bc57b1ebdd Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/69bc57b1ebdd Added tag jdk8-b74 for changeset 2087e24a4357 ! .hgtags Changeset: 47738fa4d411 Author: dbuck Date: 2013-01-10 20:26 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/47738fa4d411 8003147: port fix for BCEL bug 39695 Summary: Added support for Local Variable Type Table so that BCEL library can be used to modify methods with generics-related debug data without violating class file format Reviewed-by: lancea ! src/com/sun/org/apache/bcel/internal/Constants.java ! src/com/sun/org/apache/bcel/internal/classfile/Attribute.java ! src/com/sun/org/apache/bcel/internal/classfile/DescendingVisitor.java ! src/com/sun/org/apache/bcel/internal/classfile/EmptyVisitor.java + src/com/sun/org/apache/bcel/internal/classfile/LocalVariableTypeTable.java ! src/com/sun/org/apache/bcel/internal/classfile/Visitor.java ! src/com/sun/org/apache/bcel/internal/generic/MethodGen.java Changeset: 06827097cdd3 Author: lana Date: 2013-01-16 12:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/06827097cdd3 Merge Changeset: 4e049aa2495f Author: lana Date: 2013-01-20 23:37 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/4e049aa2495f Merge Changeset: ff0b73a6b3f6 Author: lana Date: 2013-01-26 18:25 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/ff0b73a6b3f6 Merge Changeset: 8d65b381880b Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/8d65b381880b Added tag jdk8-b75 for changeset ff0b73a6b3f6 ! .hgtags From lana.steuck at oracle.com Fri Feb 1 03:27:18 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 01 Feb 2013 03:27:18 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/langtools: 36 new changesets Message-ID: <20130201033056.17C624772C@hg.openjdk.java.net> Changeset: 54e4ba223319 Author: katleman Date: 2013-01-24 16:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/54e4ba223319 Added tag jdk8-b74 for changeset 56c97aff46bb ! .hgtags Changeset: fc4cb1577ad6 Author: jjg Date: 2013-01-10 19:38 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/fc4cb1577ad6 8004834: Add doclint support into javadoc Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MessageRetriever.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java ! test/com/sun/javadoc/5093723/T5093723.java ! test/com/sun/javadoc/testBadSourceFile/TestBadSourceFile.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testReturnTag/TestReturnTag.java ! test/com/sun/javadoc/testTagInheritence/TestTagInheritence.java ! test/com/sun/javadoc/testTagMisuse/TestTagMisuse.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java ! test/com/sun/javadoc/testWarnBadParamNames/TestWarnBadParamNames.java ! test/com/sun/javadoc/testWarnings/TestWarnings.java ! test/tools/javadoc/6958836/Test.java ! test/tools/javadoc/6964914/Test.java ! test/tools/javadoc/6964914/TestStdDoclet.java ! test/tools/javadoc/MaxWarns.java ! test/tools/javadoc/T6551367.java + test/tools/javadoc/doclint/DocLintTest.java Changeset: 9f42a06a49c0 Author: jfranck Date: 2013-01-14 19:52 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/9f42a06a49c0 7193719: Support repeating annotations in javax.lang.model Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/javax/lang/model/element/Element.java Changeset: df694c775e8a Author: jjg Date: 2013-01-14 13:50 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/df694c775e8a 8006119: update javac to follow latest spec for repeatable annotations Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContaineeSynthDoc.java ! test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerSynthDoc.java ! test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContaineeSynthDoc.java ! test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerSynthNotDoc.java ! test/tools/javac/annotations/repeatingAnnotations/BaseAnnoAsContainerAnno.java ! test/tools/javac/annotations/repeatingAnnotations/BaseAnnoAsContainerAnno.out ! test/tools/javac/annotations/repeatingAnnotations/BasicRepeatingAnnotations.java ! test/tools/javac/annotations/repeatingAnnotations/CheckTargets.java ! test/tools/javac/annotations/repeatingAnnotations/ClassReaderDefault.java ! test/tools/javac/annotations/repeatingAnnotations/ContainerHasRepeatedContained.java ! test/tools/javac/annotations/repeatingAnnotations/CyclicAnnotation.java ! test/tools/javac/annotations/repeatingAnnotations/CyclicAnnotation.out ! test/tools/javac/annotations/repeatingAnnotations/DefaultCasePresent.java ! test/tools/javac/annotations/repeatingAnnotations/DelayRepeatedContainer.java ! test/tools/javac/annotations/repeatingAnnotations/DocumentedContainerAnno.java ! test/tools/javac/annotations/repeatingAnnotations/DocumentedContainerAnno.out ! test/tools/javac/annotations/repeatingAnnotations/InheritedContainerAnno.java ! test/tools/javac/annotations/repeatingAnnotations/InheritedContainerAnno.out ! test/tools/javac/annotations/repeatingAnnotations/InvalidTarget.java - test/tools/javac/annotations/repeatingAnnotations/MissingContainedBy.java ! test/tools/javac/annotations/repeatingAnnotations/MissingContainer.java ! test/tools/javac/annotations/repeatingAnnotations/MissingContainer.out - test/tools/javac/annotations/repeatingAnnotations/MissingContainerFor.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase1.out ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.java ! test/tools/javac/annotations/repeatingAnnotations/MissingDefaultCase2.out ! test/tools/javac/annotations/repeatingAnnotations/MissingValueMethod.java ! test/tools/javac/annotations/repeatingAnnotations/MissingValueMethod.out ! test/tools/javac/annotations/repeatingAnnotations/MultiLevelRepeatableAnno.java ! test/tools/javac/annotations/repeatingAnnotations/MultipleAnnoMixedOrder.java ! test/tools/javac/annotations/repeatingAnnotations/NestedContainers.java ! test/tools/javac/annotations/repeatingAnnotations/NoRepeatableAnno.out ! test/tools/javac/annotations/repeatingAnnotations/RepMemberAnno.java ! test/tools/javac/annotations/repeatingAnnotations/RepSelfMemberAnno.java ! test/tools/javac/annotations/repeatingAnnotations/RepeatingAndContainerPresent.java ! test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.java ! test/tools/javac/annotations/repeatingAnnotations/RepeatingTargetNotAllowed.out ! test/tools/javac/annotations/repeatingAnnotations/SelfRepeatingAnnotations.java ! test/tools/javac/annotations/repeatingAnnotations/SingleRepeatingAndContainer.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainerFor.java + test/tools/javac/annotations/repeatingAnnotations/UseWrongRepeatable.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainerFor.java ! test/tools/javac/annotations/repeatingAnnotations/WrongReturnTypeForValue.java ! test/tools/javac/annotations/repeatingAnnotations/WrongReturnTypeForValue.out ! test/tools/javac/annotations/repeatingAnnotations/combo/BasicSyntaxCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/DeprecatedAnnoCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/DocumentedAnnoCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/Helper.java ! test/tools/javac/annotations/repeatingAnnotations/combo/InheritedAnnoCombo.java ! test/tools/javac/annotations/repeatingAnnotations/combo/RetentionAnnoCombo.java ! test/tools/javac/diags/examples.not-yet.txt - test/tools/javac/diags/examples/ContainedByDocumentedMismatch.java - test/tools/javac/diags/examples/ContainedByInheritedMismatch.java - test/tools/javac/diags/examples/ContainedByNoValue.java - test/tools/javac/diags/examples/ContainedByNonDefault.java - test/tools/javac/diags/examples/ContainedByRetentionMismatch.java - test/tools/javac/diags/examples/ContainedByTargetMismatch.java - test/tools/javac/diags/examples/ContainedByWrongValueType.java ! test/tools/javac/diags/examples/InvalidDuplicateAnnotation.java + test/tools/javac/diags/examples/RepeatableDocumentedMismatch.java + test/tools/javac/diags/examples/RepeatableInheritedMismatch.java + test/tools/javac/diags/examples/RepeatableNoValue.java + test/tools/javac/diags/examples/RepeatableNonDefault.java + test/tools/javac/diags/examples/RepeatableRetentionMismatch.java + test/tools/javac/diags/examples/RepeatableTargetMismatch.java + test/tools/javac/diags/examples/RepeatableWrongValueType.java ! test/tools/javac/diags/examples/RepeatingAnnotationAndContainer.java - test/tools/javac/diags/examples/WrongContainedBy.java - test/tools/javac/diags/examples/WrongContainerFor.java Changeset: d54b4a091450 Author: jjg Date: 2013-01-14 14:17 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/d54b4a091450 8006241: Test DocRootSlash.java fails Reviewed-by: darcy ! test/com/sun/javadoc/DocRootSlash/DocRootSlash.java Changeset: f805b5e3c9d1 Author: chegar Date: 2013-01-15 20:38 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/f805b5e3c9d1 8006344: Broken javadoc link in javax.lang.model.element.Element Reviewed-by: lancea, alanb, jfranck ! src/share/classes/javax/lang/model/element/Element.java Changeset: bc1023e0e533 Author: jjg Date: 2013-01-15 13:03 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/bc1023e0e533 8006224: Doclint NPE for attribute with no value Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties + test/tools/doclint/AnchorTest.java + test/tools/doclint/AnchorTest.out Changeset: f785dcac17b7 Author: mcimadamore Date: 2013-01-16 16:27 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/f785dcac17b7 8005854: Add support for array constructor references Summary: Support constructor references of the kind int[]::new Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java + test/tools/javac/lambda/MethodReference59.java + test/tools/javac/lambda/MethodReference60.java + test/tools/javac/lambda/MethodReference60.out Changeset: 7aa2025bbb7b Author: mcimadamore Date: 2013-01-16 16:30 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/7aa2025bbb7b 8005299: Add FunctionalInterface checking to javac Summary: Javac should check that types annotated with @FunctionalInterface are indeed functional interfaces Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/BadFunctionalIntfAnno.java ! test/tools/javac/lambda/BadConv03.out ! test/tools/javac/lambda/BadLambdaPos.out ! test/tools/javac/lambda/BadTargetType.out + test/tools/javac/lambda/FunctionalInterfaceAnno.java + test/tools/javac/lambda/FunctionalInterfaceAnno.out ! test/tools/javac/lambda/Intersection01.out ! test/tools/javac/lambda/LambdaConv09.out ! test/tools/javac/lambda/LambdaExpr10.out ! test/tools/javac/lambda/MethodReference04.out ! test/tools/javac/lambda/TargetType17.out ! test/tools/javac/lambda/TargetType43.out ! test/tools/javac/lambda/funcInterfaces/LambdaTest2_neg1.out ! test/tools/javac/lambda/funcInterfaces/NonSAM1.out ! test/tools/javac/lambda/funcInterfaces/NonSAM3.out ! test/tools/javac/lambda/lambdaExpression/AbstractClass_neg.out ! test/tools/javac/lambda/lambdaExpression/InvalidExpression5.out Changeset: 1afdf1f1472b Author: mcimadamore Date: 2013-01-16 17:40 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/1afdf1f1472b 8005964: Regression: difference in error recovery after ambiguity causes JCK test failure Summary: Wrong implementation of ResolveError.access in AmbiguityError Reviewed-by: jjh ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: 6b6311a8c9cc Author: jjg Date: 2013-01-16 10:29 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/6b6311a8c9cc 8006236: doclint: structural issue hidden Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java + test/tools/doclint/EndTagsTest.java + test/tools/doclint/EndTagsTest.out Changeset: 63b20bde7cd6 Author: lana Date: 2013-01-16 12:14 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/63b20bde7cd6 Merge Changeset: 8b749558767b Author: darcy Date: 2013-01-16 13:22 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/8b749558767b 8006283: Change to Class.cast() in javax.lang.model implementation for repeating annotations Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/model/JavacElements.java Changeset: 916143318f10 Author: jjg Date: 2013-01-16 20:41 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/916143318f10 8006228: Doclint doesn't detect {@code nested inline} Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties + test/tools/doclint/LiteralTest.java + test/tools/doclint/LiteralTest.out Changeset: 2d2b2be57c78 Author: mcimadamore Date: 2013-01-17 18:15 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/2d2b2be57c78 8005852: Treatment of '_' as identifier Summary: warn when '_' is found in an identifier position Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/lambda/LambdaParserTest.java Changeset: 22e417cdddee Author: ohrstrom Date: 2013-01-18 00:16 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/22e417cdddee 8004658: Add internal smart javac wrapper to solve JEP 139 Reviewed-by: jjg ! make/build.properties ! make/build.xml + src/share/classes/com/sun/tools/sjavac/BuildState.java + src/share/classes/com/sun/tools/sjavac/CleanProperties.java + src/share/classes/com/sun/tools/sjavac/CompileChunk.java + src/share/classes/com/sun/tools/sjavac/CompileJavaPackages.java + src/share/classes/com/sun/tools/sjavac/CompileProperties.java + src/share/classes/com/sun/tools/sjavac/CopyFile.java + src/share/classes/com/sun/tools/sjavac/JavacState.java + src/share/classes/com/sun/tools/sjavac/Log.java + src/share/classes/com/sun/tools/sjavac/Main.java + src/share/classes/com/sun/tools/sjavac/Module.java + src/share/classes/com/sun/tools/sjavac/Package.java + src/share/classes/com/sun/tools/sjavac/ProblemException.java + src/share/classes/com/sun/tools/sjavac/Source.java + src/share/classes/com/sun/tools/sjavac/Transformer.java + src/share/classes/com/sun/tools/sjavac/Util.java + src/share/classes/com/sun/tools/sjavac/comp/Dependencies.java + src/share/classes/com/sun/tools/sjavac/comp/JavaCompilerWithDeps.java + src/share/classes/com/sun/tools/sjavac/comp/PubapiVisitor.java + src/share/classes/com/sun/tools/sjavac/comp/ResolveWithDeps.java + src/share/classes/com/sun/tools/sjavac/comp/SmartFileManager.java + src/share/classes/com/sun/tools/sjavac/comp/SmartFileObject.java + src/share/classes/com/sun/tools/sjavac/comp/SmartWriter.java + src/share/classes/com/sun/tools/sjavac/server/CompilerPool.java + src/share/classes/com/sun/tools/sjavac/server/CompilerThread.java + src/share/classes/com/sun/tools/sjavac/server/JavacServer.java + src/share/classes/com/sun/tools/sjavac/server/PortFile.java + src/share/classes/com/sun/tools/sjavac/server/SysInfo.java + test/tools/sjavac/SJavac.java Changeset: 3d84ae209919 Author: mcimadamore Date: 2013-01-18 15:38 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/3d84ae209919 8006561: Langtools test failure: missing diags/examples Summary: forgot to hg add tests Reviewed-by: jjg + test/tools/javac/diags/examples/UnderscoreAsIdentifier.java + test/tools/javac/lambda/WarnUnderscoreAsIdent.java + test/tools/javac/lambda/WarnUnderscoreAsIdent.out Changeset: 4a3cfc970c6f Author: jjg Date: 2013-01-21 10:00 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/4a3cfc970c6f 8006263: Supplementary test cases needed for doclint Reviewed-by: mcimadamore Contributed-by: peter.jensen at oracle.com ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/share/classes/com/sun/tools/doclint/Entity.java ! src/share/classes/com/sun/tools/doclint/HtmlTag.java + test/tools/doclint/CoverageExtras.java ! test/tools/doclint/DocLintTester.java + test/tools/doclint/html/EntitiesTest.java + test/tools/doclint/html/EntitiesTest.out + test/tools/doclint/tool/HelpTest.java + test/tools/doclint/tool/HelpTest.out + test/tools/doclint/tool/MaxDiagsTest.java + test/tools/doclint/tool/MaxDiagsTest.out + test/tools/doclint/tool/PathsTest.java + test/tools/doclint/tool/RunTest.java + test/tools/doclint/tool/StatsTest.java + test/tools/doclint/tool/StatsTest.out Changeset: 967052c425a1 Author: jjg Date: 2013-01-21 10:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/967052c425a1 8006251: doclint: incorrect position for diagnostic for illegal text in tags Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/HtmlTag.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! test/tools/doclint/HtmlTagsTest.java ! test/tools/doclint/HtmlTagsTest.out + test/tools/doclint/html/BlockTagsTest.java + test/tools/doclint/html/InlineTagsTest.java + test/tools/doclint/html/ListTagsTest.java + test/tools/doclint/html/OtherTagsTest.java + test/tools/doclint/html/OtherTagsTest.out + test/tools/doclint/html/TableTagsTest.java + test/tools/doclint/html/TagNotAllowed.java + test/tools/doclint/html/TagNotAllowed.out + test/tools/doclint/html/TextNotAllowed.java + test/tools/doclint/html/TextNotAllowed.out ! test/tools/doclint/tidy/ParaInPre.out ! test/tools/doclint/tidy/TextNotAllowed.out Changeset: b450959b42ff Author: lana Date: 2013-01-20 23:39 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/b450959b42ff Merge Changeset: 1985e35e97b2 Author: lana Date: 2013-01-21 11:16 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/1985e35e97b2 Merge Changeset: 7873d37f5b37 Author: mcimadamore Date: 2013-01-21 20:13 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/7873d37f5b37 8005244: Implement overload resolution as per latest spec EDR Summary: Add support for stuck expressions and provisional applicability Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! test/tools/javac/Diagnostics/6722234/T6722234d_1.out ! test/tools/javac/Diagnostics/6722234/T6722234d_2.out ! test/tools/javac/diags/examples.not-yet.txt ! test/tools/javac/diags/examples/CyclicInference.java - test/tools/javac/diags/examples/InferredDoNotConformToLower.java - test/tools/javac/diags/examples/NoUniqueMaximalInstance.java ! test/tools/javac/diags/examples/WhereIntersection.java ! test/tools/javac/generics/diamond/T6939780.out ! test/tools/javac/generics/diamond/neg/Neg05.out ! test/tools/javac/generics/diamond/neg/Neg10.java ! test/tools/javac/generics/diamond/neg/Neg10.out ! test/tools/javac/generics/inference/6315770/T6315770.out ! test/tools/javac/generics/inference/6638712/T6638712b.out ! test/tools/javac/generics/inference/6650759/T6650759m.out ! test/tools/javac/lambda/MethodReference25.java + test/tools/javac/lambda/MethodReference25.out ! test/tools/javac/lambda/MethodReference26.java - test/tools/javac/lambda/MethodReference26.out ! test/tools/javac/lambda/MethodReference43.java ! test/tools/javac/lambda/TargetType01.java + test/tools/javac/lambda/TargetType01.out ! test/tools/javac/lambda/TargetType06.java - test/tools/javac/lambda/TargetType06.out ! test/tools/javac/lambda/TargetType10.out ! test/tools/javac/lambda/TargetType11.java - test/tools/javac/lambda/TargetType11.out ! test/tools/javac/lambda/TargetType14.out ! test/tools/javac/lambda/TargetType21.java ! test/tools/javac/lambda/TargetType21.out ! test/tools/javac/lambda/TargetType26.out ! test/tools/javac/lambda/TargetType27.out ! test/tools/javac/lambda/TargetType28.out ! test/tools/javac/lambda/TargetType39.out ! test/tools/javac/lambda/TargetType45.java - test/tools/javac/lambda/TargetType45.out ! test/tools/javac/lambda/TargetType50.out + test/tools/javac/lambda/TargetType51.java + test/tools/javac/lambda/TargetType52.java + test/tools/javac/lambda/TargetType52.out ! test/tools/javac/lambda/VoidCompatibility.java - test/tools/javac/lambda/VoidCompatibility.out ! test/tools/javac/lambda/lambdaExpression/SamConversionComboTest.java ! test/tools/javac/lambda/methodReference/SamConversion.java ! test/tools/javac/lambda/methodReference/SamConversionComboTest.java ! test/tools/javac/lambda/typeInference/InferenceTest_neg5.out ! test/tools/javac/resolve/tests/PrimitiveOverReferenceVarargsAmbiguous.java Changeset: c7c41a044e7c Author: mcimadamore Date: 2013-01-21 20:14 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/c7c41a044e7c 8006566: Remove transient lambda-related guards from JavacParser Summary: Remove transitional internal flag for allowing intersection types in cast Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! test/tools/javac/cast/intersection/IntersectionTypeCastTest.java ! test/tools/javac/cast/intersection/IntersectionTypeParserTest.java ! test/tools/javac/cast/intersection/model/Model01.java ! test/tools/javac/diags/examples/SecondaryBoundMustBeMarkerIntf.java ! test/tools/javac/lambda/Intersection01.java ! test/tools/javac/lambda/intersection/IntersectionTargetTypeTest.java Changeset: b12ffdfa1341 Author: mcimadamore Date: 2013-01-21 20:15 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/b12ffdfa1341 8005851: Remove support for synchronized interface methods Summary: Synchronized default methods are no longer supported Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! test/tools/javac/defaultMethods/syntax/TestDefaultMethodsSyntax.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java Changeset: cf84b07a82db Author: mcimadamore Date: 2013-01-21 20:19 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/cf84b07a82db 8005166: Add support for static interface methods Summary: Support public static interface methods Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/defaultMethods/static/Static01.java + test/tools/javac/defaultMethods/static/Static02.java + test/tools/javac/defaultMethods/static/Static02.out + test/tools/javac/defaultMethods/static/hiding/InterfaceMethodHidingTest.java + test/tools/javac/defaultMethods/static/import/StaticImport1.java + test/tools/javac/defaultMethods/static/import/StaticImport2.java + test/tools/javac/defaultMethods/static/import/StaticImport2.out + test/tools/javac/defaultMethods/static/import/StaticImport3.java + test/tools/javac/defaultMethods/static/import/StaticImport3.out + test/tools/javac/defaultMethods/static/import/pkg/A.java + test/tools/javac/defaultMethods/static/import/pkg/B.java + test/tools/javac/defaultMethods/static/import/pkg/C.java ! test/tools/javac/defaultMethods/syntax/TestDefaultMethodsSyntax.java + test/tools/javac/diags/examples/IllegalStaticIntfMethCall.java + test/tools/javac/diags/examples/StaticIntfMethodNotSupported.java Changeset: be443002e970 Author: mcimadamore Date: 2013-01-22 16:23 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/be443002e970 8006673: TargetType52 fails because of bad golden file Summary: Fix golden file in negative test Reviewed-by: jjg ! test/tools/javac/lambda/TargetType52.out Changeset: b61e5f801f7c Author: mcimadamore Date: 2013-01-22 16:39 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/b61e5f801f7c 8006684: Compiler produces java.lang.VerifyError: Bad type on operand stack Summary: Lambda desugaring generates spurious references to 'this' in static contexts Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaExpr21.java Changeset: 8943b4213f59 Author: jjg Date: 2013-01-22 18:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/8943b4213f59 8006723: sjavac test fails to compile on clean build Reviewed-by: ksrini ! test/tools/sjavac/SJavac.java + test/tools/sjavac/SJavacWrapper.java Changeset: f5b70712e0d5 Author: jjg Date: 2013-01-22 19:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/f5b70712e0d5 8006728: temporarily workaround jtreg problems for doclint tests in othervm Reviewed-by: jjh + test/tools/doclint/html/AAA.java + test/tools/doclint/tidy/AAA.java + test/tools/doclint/tool/AAA.java Changeset: 385828dd5604 Author: jjg Date: 2013-01-22 19:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/385828dd5604 Merge Changeset: 97bd5e7151bc Author: mcimadamore Date: 2013-01-23 15:08 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/97bd5e7151bc 8006692: jdk/test/java/util/Collections/BigBinarySearch.java fails to compile Summary: Missing boxing cause spurious inference failure Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/8006692/T8006692.java Changeset: 5c956be64b9e Author: vromero Date: 2013-01-23 20:57 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/5c956be64b9e 8006694: temporarily workaround combo tests are causing time out in several platforms Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! test/Makefile ! test/tools/javac/Diagnostics/6769027/T6769027.java ! test/tools/javac/T7093325.java ! test/tools/javac/cast/intersection/IntersectionTypeCastTest.java ! test/tools/javac/defaultMethods/super/TestDefaultSuperCall.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/generics/diamond/7046778/DiamondAndInnerClassTest.java ! test/tools/javac/generics/rawOverride/7062745/GenericOverrideTest.java ! test/tools/javac/lambda/FunctionalInterfaceConversionTest.java ! test/tools/javac/lambda/LambdaParserTest.java ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/lambda/TestInvokeDynamic.java ! test/tools/javac/lambda/mostSpecific/StructuralMostSpecificTest.java ! test/tools/javac/lambda/typeInference/combo/TypeInferenceComboTest.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/FDSeparateCompilationTest.java ! test/tools/javac/lib/JavacTestingAbstractThreadedTest.java ! test/tools/javac/multicatch/7030606/DisjunctiveTypeWellFormednessTest.java ! test/tools/javac/varargs/7042566/T7042566.java ! test/tools/javac/varargs/warning/Warn4.java ! test/tools/javac/varargs/warning/Warn5.java Changeset: 71f35e4b93a5 Author: jjg Date: 2013-01-23 13:27 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/71f35e4b93a5 8006775: JSR 308: Compiler changes in JDK8 Reviewed-by: jjg Contributed-by: mernst at cs.washington.edu, wmdietl at cs.washington.edu, mpapi at csail.mit.edu, mahmood at notnoop.com + src/share/classes/com/sun/javadoc/AnnotatedType.java ! src/share/classes/com/sun/javadoc/ExecutableMemberDoc.java ! src/share/classes/com/sun/javadoc/Type.java ! src/share/classes/com/sun/javadoc/TypeVariable.java + src/share/classes/com/sun/source/tree/AnnotatedTypeTree.java ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TaskEvent.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java + src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java + src/share/classes/com/sun/tools/classfile/TypeAnnotation.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java + src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/ConstFold.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/parser/UnicodeReader.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_ja.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javadoc/AbstractTypeImpl.java + src/share/classes/com/sun/tools/javadoc/AnnotatedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/PrimitiveType.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! src/share/classes/com/sun/tools/javap/InstructionDetailWriter.java + src/share/classes/com/sun/tools/javap/TypeAnnotationWriter.java ! src/share/classes/javax/lang/model/SourceVersion.java + src/share/classes/javax/lang/model/type/AnnotatedType.java ! src/share/classes/javax/lang/model/type/ExecutableType.java ! src/share/classes/javax/lang/model/type/TypeKind.java ! src/share/classes/javax/lang/model/type/TypeVisitor.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/Types.java + test/com/sun/javadoc/testAnnotationOptional/TestAnnotationOptional.java + test/com/sun/javadoc/testAnnotationOptional/pkg/AnnotationOptional.java + test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java + test/com/sun/javadoc/typeAnnotations/smoke/pkg/TargetTypes.java ! test/tools/javac/7129225/TestImportStar.java ! test/tools/javac/7129225/TestImportStar.ref ! test/tools/javac/T6873845.java + test/tools/javac/T6985181.java ! test/tools/javac/annotations/6881115/T6881115.java ! test/tools/javac/annotations/6881115/T6881115.out + test/tools/javac/annotations/typeAnnotations/6967002/T6967002.java + test/tools/javac/annotations/typeAnnotations/6967002/T6967002.out + test/tools/javac/annotations/typeAnnotations/InnerClass.java + test/tools/javac/annotations/typeAnnotations/MultipleTargets.java + test/tools/javac/annotations/typeAnnotations/TargetTypes.java + test/tools/javac/annotations/typeAnnotations/TypeParameterTarget.java + test/tools/javac/annotations/typeAnnotations/TypeProcOnly.java + test/tools/javac/annotations/typeAnnotations/TypeUseTarget.java + test/tools/javac/annotations/typeAnnotations/api/AnnotatedArrayOrder.java + test/tools/javac/annotations/typeAnnotations/api/ArrayCreationTree.java + test/tools/javac/annotations/typeAnnotations/api/ArrayPositionConsistency.java + test/tools/javac/annotations/typeAnnotations/attribution/Scopes.java + test/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java + test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java + test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java + test/tools/javac/annotations/typeAnnotations/classfile/DeadCode.java + test/tools/javac/annotations/typeAnnotations/classfile/NewTypeArguments.java + test/tools/javac/annotations/typeAnnotations/classfile/NoTargetAnnotations.java + test/tools/javac/annotations/typeAnnotations/classfile/TypeCasts.java + test/tools/javac/annotations/typeAnnotations/classfile/Wildcards.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage1.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage2.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotatedPackage2.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.java + test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.out + test/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion7.out + test/tools/javac/annotations/typeAnnotations/failures/BadCast.java + test/tools/javac/annotations/typeAnnotations/failures/BadCast.out + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java + test/tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.out + test/tools/javac/annotations/typeAnnotations/failures/IncompleteArray.java + test/tools/javac/annotations/typeAnnotations/failures/IncompleteArray.out + test/tools/javac/annotations/typeAnnotations/failures/IncompleteVararg.java + test/tools/javac/annotations/typeAnnotations/failures/IncompleteVararg.out + test/tools/javac/annotations/typeAnnotations/failures/IndexArray.java + test/tools/javac/annotations/typeAnnotations/failures/IndexArray.out + test/tools/javac/annotations/typeAnnotations/failures/LintCast.java + test/tools/javac/annotations/typeAnnotations/failures/LintCast.out + test/tools/javac/annotations/typeAnnotations/failures/OldArray.java + test/tools/javac/annotations/typeAnnotations/failures/Scopes.java + test/tools/javac/annotations/typeAnnotations/failures/Scopes.out + test/tools/javac/annotations/typeAnnotations/failures/StaticFields.java + test/tools/javac/annotations/typeAnnotations/failures/StaticFields.out + test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.java + test/tools/javac/annotations/typeAnnotations/failures/StaticMethods.out + test/tools/javac/annotations/typeAnnotations/failures/TypeAndField.java + test/tools/javac/annotations/typeAnnotations/failures/VoidGenericMethod.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/arrays/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/newarray/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/BrokenAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/BrokenAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/Nesting.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/StaticThings.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/StaticThings.out + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.java + test/tools/javac/annotations/typeAnnotations/failures/common/receiver/WrongType.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/rest/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/InvalidLocation.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/InvalidLocation.out + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.java + test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.out + test/tools/javac/annotations/typeAnnotations/failures/target/Constructor.java + test/tools/javac/annotations/typeAnnotations/failures/target/Constructor.out + test/tools/javac/annotations/typeAnnotations/failures/target/DotClass.java + test/tools/javac/annotations/typeAnnotations/failures/target/DotClass.out + test/tools/javac/annotations/typeAnnotations/failures/target/IncompleteArray.java + test/tools/javac/annotations/typeAnnotations/failures/target/IncompleteArray.out + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeParameter.java + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeParameter.out + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeUse.java + test/tools/javac/annotations/typeAnnotations/failures/target/NotTypeUse.out + test/tools/javac/annotations/typeAnnotations/failures/target/VoidMethod.java + test/tools/javac/annotations/typeAnnotations/failures/target/VoidMethod.out + test/tools/javac/annotations/typeAnnotations/newlocations/BasicTest.java + test/tools/javac/annotations/typeAnnotations/newlocations/ClassExtends.java + test/tools/javac/annotations/typeAnnotations/newlocations/ClassParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/ConstructorTypeArgs.java + test/tools/javac/annotations/typeAnnotations/newlocations/ExceptionParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/Expressions.java + test/tools/javac/annotations/typeAnnotations/newlocations/Fields.java + test/tools/javac/annotations/typeAnnotations/newlocations/LocalVariables.java + test/tools/javac/annotations/typeAnnotations/newlocations/MethodReturnType.java + test/tools/javac/annotations/typeAnnotations/newlocations/MethodTypeArgs.java + test/tools/javac/annotations/typeAnnotations/newlocations/MethodTypeParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/MultiCatch.java + test/tools/javac/annotations/typeAnnotations/newlocations/NestedTypes.java + test/tools/javac/annotations/typeAnnotations/newlocations/Parameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/Receivers.java + test/tools/javac/annotations/typeAnnotations/newlocations/RepeatingTypeAnnotations.java + test/tools/javac/annotations/typeAnnotations/newlocations/RepeatingTypeAnnotations.out + test/tools/javac/annotations/typeAnnotations/newlocations/ResourceVariables.java + test/tools/javac/annotations/typeAnnotations/newlocations/Throws.java + test/tools/javac/annotations/typeAnnotations/newlocations/TopLevelBlocks.java + test/tools/javac/annotations/typeAnnotations/newlocations/TypeCasts.java + test/tools/javac/annotations/typeAnnotations/newlocations/TypeParameters.java + test/tools/javac/annotations/typeAnnotations/newlocations/Varargs.java + test/tools/javac/annotations/typeAnnotations/newlocations/Wildcards.java + test/tools/javac/annotations/typeAnnotations/packageanno/PackageProcessor.java + test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/Anno.java + test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/MyClass.java + test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/package-info.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ClassExtends.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ClassTypeParam.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ExceptionParameters.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Fields.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/FromSpecification.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodParameters.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodReceivers.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodReturns.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodThrows.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodTypeParam.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/NestedTypes.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/NewObjects.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/ReferenceInfoUtil.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/RepeatingTypeAnnotations.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/TypeCasts.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/TypeTests.java ! test/tools/javac/api/EndPositions.java ! test/tools/javac/diags/CheckResourceKeys.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/CantAnnotateNestedType.java + test/tools/javac/diags/examples/CantAnnotateStaticClass.java + test/tools/javac/diags/examples/IncorrectReceiverType.java + test/tools/javac/diags/examples/NoAnnotationsOnDotClass.java + test/tools/javac/diags/examples/ThisAsIdentifier.java + test/tools/javac/diags/examples/TypeAnnotationsNotSupported.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/processing/6994946/SemanticErrorTest.2.out ! test/tools/javac/processing/model/element/TestAnonClassNames.java ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java + test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.ref ! test/tools/javac/processing/model/util/directSupersOfErr/DirectSupersOfErr.java + test/tools/javac/processing/model/util/directSupersOfErr/DirectSupersOfErr.ref ! test/tools/javac/tree/TreeKindTest.java ! test/tools/javac/tree/TreePosTest.java + test/tools/javac/treeannotests/AnnoTreeTests.java ! test/tools/javac/treeannotests/TestProcessor.java - test/tools/javac/typeAnnotations/newlocations/BasicTest.java - test/tools/javac/typeAnnotations/newlocations/BasicTest.out + test/tools/javap/typeAnnotations/JSR175Annotations.java + test/tools/javap/typeAnnotations/NewArray.java + test/tools/javap/typeAnnotations/Presence.java + test/tools/javap/typeAnnotations/PresenceInner.java + test/tools/javap/typeAnnotations/T6855990.java + test/tools/javap/typeAnnotations/TypeCasts.java + test/tools/javap/typeAnnotations/Visibility.java + test/tools/javap/typeAnnotations/Wildcards.java Changeset: 09f65aad4759 Author: darcy Date: 2013-01-23 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/09f65aad4759 8006264: Add explanation of why default methods cannot be used in JDK 8 javax.lang.model Reviewed-by: jjg ! src/share/classes/javax/lang/model/element/AnnotationValueVisitor.java ! src/share/classes/javax/lang/model/element/ElementVisitor.java ! src/share/classes/javax/lang/model/type/TypeVisitor.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor8.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor8.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor6.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor7.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor6.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor7.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor8.java Changeset: c2e11e2ec4a3 Author: lana Date: 2013-01-26 19:24 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/c2e11e2ec4a3 Merge - test/tools/javac/annotations/repeatingAnnotations/MissingContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/MissingContainerFor.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainerFor.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainerFor.java - test/tools/javac/diags/examples/ContainedByDocumentedMismatch.java - test/tools/javac/diags/examples/ContainedByInheritedMismatch.java - test/tools/javac/diags/examples/ContainedByNoValue.java - test/tools/javac/diags/examples/ContainedByNonDefault.java - test/tools/javac/diags/examples/ContainedByRetentionMismatch.java - test/tools/javac/diags/examples/ContainedByTargetMismatch.java - test/tools/javac/diags/examples/ContainedByWrongValueType.java - test/tools/javac/diags/examples/InferredDoNotConformToLower.java - test/tools/javac/diags/examples/NoUniqueMaximalInstance.java - test/tools/javac/diags/examples/WrongContainedBy.java - test/tools/javac/diags/examples/WrongContainerFor.java - test/tools/javac/lambda/MethodReference26.out - test/tools/javac/lambda/TargetType06.out - test/tools/javac/lambda/TargetType11.out - test/tools/javac/lambda/TargetType45.out - test/tools/javac/lambda/VoidCompatibility.out - test/tools/javac/typeAnnotations/newlocations/BasicTest.java - test/tools/javac/typeAnnotations/newlocations/BasicTest.out Changeset: 716935fec613 Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/716935fec613 Added tag jdk8-b75 for changeset c2e11e2ec4a3 ! .hgtags From lana.steuck at oracle.com Fri Feb 1 03:27:41 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 01 Feb 2013 03:27:41 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/hotspot: 66 new changesets Message-ID: <20130201033247.45B304772E@hg.openjdk.java.net> Changeset: 89fc17e8d808 Author: katleman Date: 2013-01-24 16:48 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/89fc17e8d808 Added tag jdk8-b74 for changeset 1a3e54283c54 ! .hgtags Changeset: d58b7b43031b Author: amurillo Date: 2013-01-11 02:02 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d58b7b43031b 8006034: new hotspot build - hs25-b16 Reviewed-by: jcoomes ! make/hotspot_version Changeset: adc176e95bf2 Author: acorn Date: 2013-01-09 11:39 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/adc176e95bf2 8005689: InterfaceAccessFlagsTest failures in Lambda-JDK tests Summary: Fix verifier for new interface access flags Reviewed-by: acorn, kvn Contributed-by: bharadwaj.yadavalli at oracle.com ! src/share/vm/classfile/classFileParser.cpp Changeset: dd7248d3e151 Author: zgu Date: 2013-01-09 14:46 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/dd7248d3e151 7152671: RFE: Windows decoder should add some std dirs to the symbol search path Summary: Added JRE/JDK bin directories to decoder's symbol search path Reviewed-by: dcubed, sla ! src/os/windows/vm/decoder_windows.cpp ! src/os/windows/vm/decoder_windows.hpp Changeset: 97ee8abd6ab2 Author: zgu Date: 2013-01-09 12:10 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/97ee8abd6ab2 Merge Changeset: aefb345d3f5e Author: acorn Date: 2013-01-10 17:38 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/aefb345d3f5e 7199207: NPG: Crash in PlaceholderTable::verify after StackOverflow Summary: Reduce scope of placeholder table entries to improve cleanup Reviewed-by: dholmes, coleenp ! src/share/vm/classfile/placeholders.cpp ! src/share/vm/classfile/placeholders.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/utilities/exceptions.hpp Changeset: 91bf7da5c609 Author: mikael Date: 2013-01-10 17:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/91bf7da5c609 8004747: Remove last_entry from VM_STRUCT macros Summary: Instead of passing in last_entry to all the VM_ macros just expand it in the main vmStructs.cpp file. Reviewed-by: dholmes, sspitsyn, minqi ! src/cpu/sparc/vm/vmStructs_sparc.hpp ! src/cpu/x86/vm/vmStructs_x86.hpp ! src/cpu/zero/vm/vmStructs_zero.hpp ! src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp ! src/os_cpu/bsd_zero/vm/vmStructs_bsd_zero.hpp ! src/os_cpu/linux_sparc/vm/vmStructs_linux_sparc.hpp ! src/os_cpu/linux_x86/vm/vmStructs_linux_x86.hpp ! src/os_cpu/linux_zero/vm/vmStructs_linux_zero.hpp ! src/os_cpu/solaris_sparc/vm/vmStructs_solaris_sparc.hpp ! src/os_cpu/solaris_x86/vm/vmStructs_solaris_x86.hpp ! src/os_cpu/windows_x86/vm/vmStructs_windows_x86.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: c1c8479222cd Author: dholmes Date: 2013-01-10 21:00 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c1c8479222cd 8005921: Memory leaks in vmStructs.cpp Reviewed-by: dholmes, mikael, rasbold Contributed-by: Jeremy Manson ! src/share/vm/runtime/vmStructs.cpp Changeset: e0cf9af8978e Author: zgu Date: 2013-01-11 12:30 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e0cf9af8978e 8005936: PrintNMTStatistics doesn't work for normal JVM exit Summary: Moved NMT shutdown code to JVM exit handler to ensure NMT statistics is printed when PrintNMTStatistics is enabled Reviewed-by: acorn, dholmes, coleenp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/thread.cpp Changeset: 90a92d5bca17 Author: zgu Date: 2013-01-11 09:53 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/90a92d5bca17 Merge Changeset: 4a916f2ce331 Author: jwilhelm Date: 2013-01-14 15:17 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4a916f2ce331 8003985: Support @Contended Annotation - JEP 142 Summary: HotSpot changes to support @Contended annotation. Reviewed-by: coleenp, kvn, jrose Contributed-by: Aleksey Shipilev ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/fieldInfo.hpp ! src/share/vm/oops/fieldStreams.hpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: f9eb431c3efe Author: coleenp Date: 2013-01-14 11:01 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f9eb431c3efe 8006005: Fix constant pool index validation and alignment trap for method parameter reflection Summary: This patch addresses an alignment trap due to the storage format of method parameters data in constMethod. It also adds code to validate constant pool indexes for method parameters data. Reviewed-by: jrose, dholmes Contributed-by: eric.mccorkle at oracle.com ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/reflection.cpp Changeset: 5b6a231e5a86 Author: coleenp Date: 2013-01-14 08:37 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5b6a231e5a86 Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: fe1472c87a27 Author: mikael Date: 2013-01-14 11:00 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/fe1472c87a27 8005592: ClassLoaderDataGraph::_unloading incorrectly defined as nonstatic in vmStructs Summary: Added assertion to catch problem earlier and removed the unused field Reviewed-by: dholmes, acorn ! src/share/vm/runtime/vmStructs.cpp Changeset: c793367610c1 Author: coleenp Date: 2013-01-15 17:05 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c793367610c1 8005467: CDS size information is incorrect and unfriendly Summary: Changed words to bytes, and added usage percentage information Reviewed-by: coleenp, twisti Contributed-by: ioi.lam at oracle.com ! src/share/vm/memory/metaspaceShared.cpp Changeset: 92d4b5d8dde4 Author: acorn Date: 2013-01-16 18:23 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/92d4b5d8dde4 Merge ! src/cpu/x86/vm/vm_version_x86.cpp ! src/share/vm/runtime/globals.hpp Changeset: 337e1dd9d902 Author: jiangli Date: 2013-01-11 16:55 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/337e1dd9d902 8005895: Inefficient InstanceKlass field packing wasts memory. Summary: Pack _misc_has_default_methods into the _misc_flags, move _idnum_allocated_count. Reviewed-by: coleenp, shade ! src/share/vm/oops/instanceKlass.hpp Changeset: 94fa3c4e7643 Author: vladidan Date: 2013-01-14 13:44 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/94fa3c4e7643 8005639: Move InlineSynchronizedMethods flag from develop to product Summary: Move InlineSynchronizedMethods flag from develop to product Reviewed-by: kvn, vladidan Contributed-by: Alexander Harlap ! src/share/vm/c1/c1_globals.hpp Changeset: 9deda4d8e126 Author: vladidan Date: 2013-01-14 13:52 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/9deda4d8e126 8005204: Code Cache Reduction: command line options implementation Summary: Adding more detailed output on CodeCache usage Reviewed-by: kvn, vladidan Contributed-by: Alexander Harlap ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/utilities/vmError.cpp Changeset: 212c5b9c38e7 Author: dlong Date: 2013-01-17 01:27 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/212c5b9c38e7 Merge ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp Changeset: a3f92e6c0274 Author: twisti Date: 2013-01-11 14:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/a3f92e6c0274 8006031: LibraryCallKit::inline_array_copyOf disabled unintentionally with 7172640 Reviewed-by: kvn ! src/share/vm/opto/library_call.cpp Changeset: f9bda35f4226 Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f9bda35f4226 8005816: Shark: fix volatile float field access Reviewed-by: twisti Contributed-by: Roman Kennke ! src/share/vm/shark/sharkBlock.cpp Changeset: c566b81b3323 Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c566b81b3323 8005817: Shark: implement deoptimization support Reviewed-by: twisti Contributed-by: Roman Kennke ! src/cpu/zero/vm/frame_zero.cpp ! src/cpu/zero/vm/frame_zero.inline.hpp ! src/cpu/zero/vm/sharkFrame_zero.hpp ! src/share/vm/shark/sharkInvariants.hpp ! src/share/vm/shark/sharkTopLevelBlock.cpp Changeset: c095a7f289aa Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c095a7f289aa 8005818: Shark: fix OSR for non-empty incoming stack Reviewed-by: twisti Contributed-by: Roman Kennke ! src/share/vm/shark/sharkCompiler.cpp ! src/share/vm/shark/sharkFunction.cpp ! src/share/vm/shark/sharkInvariants.hpp Changeset: 606eada1bf86 Author: twisti Date: 2013-01-11 16:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/606eada1bf86 8005820: Shark: enable JSR292 support Reviewed-by: twisti Contributed-by: Roman Kennke ! src/share/vm/compiler/abstractCompiler.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/shark/sharkBlock.cpp ! src/share/vm/shark/sharkCompiler.hpp ! src/share/vm/shark/sharkConstant.cpp ! src/share/vm/shark/sharkInliner.cpp ! src/share/vm/shark/sharkTopLevelBlock.cpp Changeset: 6d1f5516534e Author: twisti Date: 2013-01-11 20:01 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6d1f5516534e 8006127: remove printing code added with 8006031 Reviewed-by: kvn ! src/share/vm/opto/library_call.cpp Changeset: d92fa52a5d03 Author: vlivanov Date: 2013-01-14 08:22 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d92fa52a5d03 8006095: C1: SIGSEGV w/ -XX:+LogCompilation Summary: avoid printing inlining decision when compilation fails Reviewed-by: kvn, roland ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: f1de9dbc914e Author: twisti Date: 2013-01-15 12:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f1de9dbc914e 8006109: test/java/util/AbstractSequentialList/AddAll.java fails: assert(rtype == ctype) failed: mismatched return types Reviewed-by: kvn ! src/share/vm/ci/ciType.cpp ! src/share/vm/ci/ciType.hpp ! src/share/vm/opto/doCall.cpp Changeset: 5b8548391bf3 Author: kvn Date: 2013-01-15 14:45 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5b8548391bf3 8005821: C2: -XX:+PrintIntrinsics is broken Summary: Check all print inlining flags when processing inlining list. Reviewed-by: kvn, twisti Contributed-by: david.r.chase at oracle.com ! src/share/vm/opto/compile.cpp Changeset: bf623b2d5508 Author: kvn Date: 2013-01-16 14:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/bf623b2d5508 8006204: please JTREGify test/compiler/7190310/Test7190310.java Summary: Add proper jtreg annotations in the preceding comment, including an explicit timeout. Reviewed-by: kvn, twisti Contributed-by: david.r.chase at oracle.com ! test/compiler/7190310/Test7190310.java Changeset: eab4f9ed602c Author: kvn Date: 2013-01-17 18:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/eab4f9ed602c Merge ! src/share/vm/compiler/compileBroker.cpp Changeset: 689e1218d7fe Author: brutisso Date: 2013-01-14 09:58 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/689e1218d7fe 8004018: Remove old initialization flags Reviewed-by: dholmes, stefank Contributed-by: erik.helin at oracle.com ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp Changeset: a30e7b564541 Author: brutisso Date: 2013-01-14 21:30 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/a30e7b564541 8005972: ParNew should not update the tenuring threshold when promotion failed has occurred Reviewed-by: ysr, johnc, jwilhelm ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.hpp Changeset: ed6154d7d259 Author: stefank Date: 2013-01-15 13:32 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ed6154d7d259 8005590: java_lang_Class injected field resolved_constructor appears unused Reviewed-by: coleenp, dholmes ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: ff0a7943fd29 Author: stefank Date: 2013-01-15 10:09 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ff0a7943fd29 8005994: Method annotations are allocated unnecessarily during class file parsing Summary: Also reviewed by: vitalyd at gmail.com Reviewed-by: coleenp, acorn ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/prims/jvm.cpp Changeset: 4967eb4f67a9 Author: johnc Date: 2013-01-15 12:32 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4967eb4f67a9 8001425: G1: Change the default values for certain G1 specific flags Summary: Changes to default and ergonomic flag values recommended by performance team. Changes were also reviewed by Monica Beckwith . Reviewed-by: brutisso, huntch ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: 2dce7c34c564 Author: stefank Date: 2013-01-17 11:39 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/2dce7c34c564 8006513: Null pointer in DefaultMethods::generate_default_methods when merging annotations Reviewed-by: brutisso, jfranck ! src/share/vm/classfile/defaultMethods.cpp Changeset: 59a58e20dc60 Author: jmasa Date: 2013-01-17 19:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/59a58e20dc60 8006537: Assert when dumping archive with default methods Reviewed-by: coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/memory/metadataFactory.hpp Changeset: f422634e5828 Author: brutisso Date: 2013-01-18 11:03 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f422634e5828 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 70c89bd6b895 Author: amurillo Date: 2013-01-18 05:19 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/70c89bd6b895 Merge Changeset: 2b878edabfc0 Author: amurillo Date: 2013-01-18 05:19 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/2b878edabfc0 Added tag hs25-b16 for changeset 70c89bd6b895 ! .hgtags Changeset: 46e60405583b Author: amurillo Date: 2013-01-18 05:33 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/46e60405583b 8006511: new hotspot build - hs25-b17 Reviewed-by: jcoomes ! make/hotspot_version Changeset: e94ed1591b42 Author: sla Date: 2013-01-16 16:30 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e94ed1591b42 8006403: Regression: jstack failed due to the FieldInfo regression in SA Reviewed-by: sla, dholmes Contributed-by: Aleksey Shipilev ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! src/share/vm/runtime/vmStructs.cpp Changeset: 557bda927cc2 Author: sla Date: 2013-01-18 14:15 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/557bda927cc2 Merge ! src/share/vm/runtime/vmStructs.cpp Changeset: 617b18aadb33 Author: sla Date: 2013-01-18 19:13 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/617b18aadb33 Merge Changeset: 203f64878aab Author: hseigel Date: 2013-01-17 10:25 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/203f64878aab 7102489: RFE: cleanup jlong typedef on __APPLE__and _LLP64 systems. Summary: Define jlong as long on all LP64 platforms and add JLONG_FORMAT macro. Reviewed-by: dholmes, coleenp, mikael, kvn ! src/cpu/x86/vm/jni_x86.h ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/posix/launcher/java_md.c ! src/os/posix/launcher/java_md.h ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/windows/launcher/java_md.c ! src/os/windows/launcher/java_md.h ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.inline.hpp ! src/share/tools/launcher/java.c ! src/share/tools/launcher/java.h ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/shared/ageTable.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/runtime/aprofiler.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/perfData.cpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/lowMemoryDetector.cpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/globalDefinitions_gcc.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/taskqueue.cpp Changeset: b14da2e6f2dc Author: coleenp Date: 2013-01-17 13:40 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b14da2e6f2dc 7174978: NPG: Fix bactrace builder for class redefinition Summary: Remove Method* from backtrace but save version so redefine classes doesn't give inaccurate line numbers. Removed old Merlin API with duplicate code. Reviewed-by: dholmes, sspitsyn ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: b5f6465019f6 Author: coleenp Date: 2013-01-17 22:11 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b5f6465019f6 8006548: version wrong in new constantPool code Summary: fix increment problem with saved_version Reviewed-by: dholmes ! src/share/vm/oops/constantPool.hpp Changeset: c07c102cbad7 Author: brutisso Date: 2013-01-21 09:00 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c07c102cbad7 8006431: os::Bsd::initialize_system_info() sets _physical_memory too large Summary: Use HW_MEMSIZE instead of HW_USERMEM to get a 64 bit value of the physical memory on the machine. Also reviewed by vitalyd at gmail.com. Reviewed-by: sla, dholmes, dlong, mikael ! src/os/bsd/vm/os_bsd.cpp Changeset: c73c3f2c5b3b Author: acorn Date: 2013-01-21 16:11 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c73c3f2c5b3b Merge ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/services/diagnosticArgument.cpp Changeset: f3184f32ce0b Author: dcubed Date: 2013-01-22 05:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f3184f32ce0b 6444286: Possible naked oop related to biased locking revocation safepoint in jni_exit() Summary: Add missing Handle. Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: karen.kinnear at oracle.com ! src/share/vm/runtime/synchronizer.cpp Changeset: 22ba8c8ce6a6 Author: dcubed Date: 2013-01-22 05:56 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/22ba8c8ce6a6 8004902: correctness fixes motivated by contended locking work (6607129) Summary: misc correctness fixes Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: dave.dice at oracle.com ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/objectMonitor.inline.hpp Changeset: 5ce621176715 Author: dcubed Date: 2013-01-22 05:57 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5ce621176715 8004903: VMThread::execute() calls Thread::check_for_valid_safepoint_state() on concurrent VM ops Summary: check_for_valid_safepoint_state() only applies to blocking VM ops Reviewed-by: acorn, dholmes, dice, sspitsyn Contributed-by: karen.kinnear at oracle.com ! src/share/vm/runtime/vmThread.cpp Changeset: edd23b35b1a5 Author: zgu Date: 2013-01-22 14:27 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/edd23b35b1a5 6871190: Don't terminate JVM if it is running in a non-interactive session Summary: Don't handle CTRL_LOGOFF_EVENT event when the process is running in a non-interactive session Reviewed-by: ctornqvi, acorn ! src/os/windows/vm/os_windows.cpp Changeset: 2ef7061f13b4 Author: zgu Date: 2013-01-22 11:54 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/2ef7061f13b4 Merge ! src/os/windows/vm/os_windows.cpp Changeset: 7df93f7c14a5 Author: brutisso Date: 2013-01-16 12:46 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/7df93f7c14a5 8006242: G1: WorkerDataArray::verify() too strict for double calculations Summary: Also reviewed by vitalyd at gmail.com. Reviewed-by: johnc, mgerdin ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp Changeset: bf8c2b2c8cfa Author: mgerdin Date: 2013-01-22 13:42 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/bf8c2b2c8cfa 8004147: test/Makefile jtreg_tests target does not work with cygwin Reviewed-by: ctornqvi, brutisso ! test/Makefile Changeset: d754ef7b9352 Author: jmasa Date: 2013-01-24 06:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d754ef7b9352 Merge Changeset: a7114d3d712e Author: kvn Date: 2013-01-22 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/a7114d3d712e 8005055: pass outputStream to more opto debug routines Summary: pass the output stream to node->dump() and everything reachable from there Reviewed-by: kvn Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/optoreg.hpp ! src/share/vm/opto/regalloc.cpp ! src/share/vm/opto/regmask.cpp ! src/share/vm/opto/regmask.hpp Changeset: b30b3c2a0cf2 Author: kvn Date: 2013-01-22 15:34 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b30b3c2a0cf2 6896617: Optimize sun.nio.cs.ISO_8859_1$Encode.encodeArrayLoop() on x86 Summary: Use SSE4.2 and AVX2 instructions for encodeArray intrinsic. Reviewed-by: roland ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp + test/compiler/6896617/Test6896617.java Changeset: 522c328b8b77 Author: kvn Date: 2013-01-23 15:11 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/522c328b8b77 8003878: compiler/7196199 test failed on OS X since 8b54, jdk7u12b01 Summary: Limit vectors size to 16 bytes on BSD until the problem is fixed Reviewed-by: twisti ! src/cpu/x86/vm/vm_version_x86.cpp Changeset: 22ead76da3f4 Author: kmo Date: 2013-01-24 02:03 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/22ead76da3f4 8006758: LinkResolver assertion (caused by @Contended changes) Summary: treat anonymous classes as privileged code to restore the special handling for @Compiled during class file parsing Reviewed-by: jrose, coleenp, kvn, dholmes ! src/share/vm/classfile/classFileParser.cpp Changeset: 274a29bf5682 Author: kmo Date: 2013-01-24 09:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/274a29bf5682 Merge Changeset: b4391649e91e Author: amurillo Date: 2013-01-25 02:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b4391649e91e Merge ! .hgtags Changeset: 6778d0b16593 Author: amurillo Date: 2013-01-25 02:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6778d0b16593 Added tag hs25-b17 for changeset b4391649e91e ! .hgtags Changeset: 20b605466ccb Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/20b605466ccb Added tag jdk8-b75 for changeset 6778d0b16593 ! .hgtags From lana.steuck at oracle.com Fri Feb 1 03:31:10 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 01 Feb 2013 03:31:10 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 103 new changesets Message-ID: <20130201040311.83D4347735@hg.openjdk.java.net> Changeset: 6d849e883c40 Author: yhuang Date: 2013-01-13 18:45 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6d849e883c40 7114053: [sq] Inproper tanslation for iso lanugage of Albanian Reviewed-by: naoto ! src/share/classes/sun/util/resources/sq/LocaleNames_sq.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 2de23975ee10 Author: yhuang Date: 2013-01-15 19:08 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2de23975ee10 Merge Changeset: 68fc838d5e89 Author: yhuang Date: 2013-01-16 19:05 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/68fc838d5e89 Merge Changeset: 595baf3cc781 Author: yhuang Date: 2013-01-16 23:08 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/595baf3cc781 Merge Changeset: 478d8354285a Author: erikj Date: 2013-01-18 16:44 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/478d8354285a 8006567: jre/lib/applet missing from Mac JDK installation Reviewed-by: tbell ! makefiles/Bundles.gmk Changeset: 92d8880d5406 Author: erikj Date: 2013-01-21 11:42 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/92d8880d5406 8006583: build-infra: Remove /javax/swing/SwingBeanInfoBase.java from src.zip Reviewed-by: tbell ! makefiles/GensrcSwing.gmk Changeset: a9839ed93340 Author: erikj Date: 2013-01-21 11:42 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a9839ed93340 Merge Changeset: 506bf3d23f06 Author: erikj Date: 2013-01-21 14:58 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/506bf3d23f06 8006579: build-infra: In jvm.cfg, alias -server to -client when no server jvm is built. Reviewed-by: tbell ! makefiles/CopyFiles.gmk Changeset: 57d5d9544628 Author: erikj Date: 2013-01-22 09:01 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/57d5d9544628 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable Reviewed-by: dholmes, ohrstrom ! makefiles/GensrcX11Wrappers.gmk + src/solaris/classes/sun/awt/X11/generator/sizes.32 + src/solaris/classes/sun/awt/X11/generator/sizes.64 Changeset: ef592aceb40e Author: katleman Date: 2013-01-24 16:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ef592aceb40e Added tag jdk8-b74 for changeset 57d5d9544628 ! .hgtags Changeset: c6e8a518c3cd Author: jjg Date: 2013-01-10 19:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c6e8a518c3cd 8004834: Add doclint support into javadoc Reviewed-by: erikj, tbell ! make/docs/Makefile Changeset: c9308137ad9e Author: jjg Date: 2013-01-10 19:37 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c9308137ad9e Merge - test/java/util/Properties/MacJNUEncoding/ExpectedEncoding.java - test/java/util/Properties/MacJNUEncoding/MacJNUEncoding.sh Changeset: 86c563dc70ca Author: darcy Date: 2013-01-10 21:12 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/86c563dc70ca 8006062: Add @Repeatable to repeating annotations regression tests in JDK repo Reviewed-by: jjg ! test/java/lang/annotation/repeatingAnnotations/subpackage/Containee.java ! test/java/lang/annotation/repeatingAnnotations/subpackage/InheritedContainee.java Changeset: 0ca2e39a110d Author: alanb Date: 2013-01-11 12:27 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0ca2e39a110d 8005566: (fs) test/java/nio/file/Files/Misc.java failing (sol) Reviewed-by: chegar ! src/solaris/classes/sun/nio/fs/SolarisAclFileAttributeView.java ! test/java/nio/file/Files/Misc.java Changeset: 7da291690aa0 Author: alanb Date: 2013-01-11 20:19 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7da291690aa0 8005978: shell tests need to use the $COMPILEJDK for javac, jar and other tools Reviewed-by: chegar ! test/ProblemList.txt ! test/com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.sh ! test/com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh ! test/java/io/FileOutputStream/FileOpen.sh ! test/java/io/Serializable/class/run.sh ! test/java/io/Serializable/evolution/RenamePackage/run.sh ! test/java/io/Serializable/maskSyntheticModifier/run.sh ! test/java/io/Serializable/packageAccess/run.sh ! test/java/io/Serializable/resolveClass/consTest/run.sh ! test/java/io/Serializable/resolveClass/deserializeButton/run.sh ! test/java/io/Serializable/superclassDataLoss/run.sh ! test/java/io/Serializable/unnamedPackageSwitch/run.sh ! test/java/lang/Class/getEnclosingClass/build.sh ! test/java/lang/ClassLoader/Assert.sh ! test/java/lang/ClassLoader/deadlock/TestCrossDelegate.sh ! test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh ! test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh ! test/java/lang/Thread/UncaughtExceptions.sh ! test/java/lang/annotation/loaderLeak/LoaderLeak.sh ! test/java/lang/instrument/AppendToBootstrapClassPathSetUp.sh ! test/java/lang/instrument/AppendToClassPathSetUp.sh ! test/java/lang/instrument/BootClassPath/BootClassPathTest.sh ! test/java/lang/instrument/MakeJAR.sh ! test/java/lang/instrument/MakeJAR2.sh ! test/java/lang/instrument/MakeJAR3.sh ! test/java/lang/instrument/MakeJAR4.sh ! test/java/lang/instrument/ManifestTest.sh ! test/java/lang/instrument/ParallelTransformerLoader.sh ! test/java/lang/instrument/PremainClass/NoPremainAgent.sh ! test/java/lang/instrument/PremainClass/PremainClassTest.sh ! test/java/lang/instrument/PremainClass/ZeroArgPremainAgent.sh ! test/java/lang/instrument/RedefineBigClass.sh ! test/java/lang/instrument/RedefineClassWithNativeMethod.sh ! test/java/lang/instrument/RedefineMethodAddInvoke.sh ! test/java/lang/instrument/RedefineSetUp.sh ! test/java/lang/instrument/RetransformBigClass.sh ! test/java/lang/instrument/appendToClassLoaderSearch/CircularityErrorTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/ClassUnloadTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/CommonSetup.sh ! test/java/lang/instrument/appendToClassLoaderSearch/run_tests.sh ! test/java/net/Authenticator/B4933582.sh ! test/java/net/URL/B5086147.sh ! test/java/net/URL/runconstructor.sh ! test/java/net/URLClassLoader/B5077773.sh ! test/java/net/URLClassLoader/closetest/build.sh ! test/java/net/URLClassLoader/getresourceasstream/test.sh ! test/java/net/URLClassLoader/sealing/checksealed.sh ! test/java/net/URLConnection/6212146/test.sh ! test/java/net/URLConnection/UNCTest.sh ! test/java/nio/charset/spi/basic.sh ! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh ! test/java/rmi/registry/readTest/readTest.sh ! test/java/security/Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh ! test/java/security/Security/ClassLoaderDeadlock/Deadlock2.sh ! test/java/security/Security/signedfirst/Dyn.sh ! test/java/security/Security/signedfirst/Static.sh ! test/java/security/cert/CertificateFactory/slowstream.sh ! test/java/util/Formatter/Basic.sh ! test/java/util/Locale/LocaleProviders.sh ! test/java/util/PluggableLocale/ExecTest.sh ! test/java/util/ServiceLoader/basic.sh ! test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh ! test/java/util/prefs/PrefsSpi.sh ! test/javax/crypto/SecretKeyFactory/FailOverTest.sh ! test/javax/script/CommonSetup.sh ! test/javax/script/ProviderTest.sh ! test/javax/security/auth/Subject/doAs/Test.sh ! test/lib/security/java.policy/Ext_AllPolicy.sh ! test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.sh ! test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/net/www/MarkResetTest.sh ! test/sun/net/www/http/HttpClient/RetryPost.sh ! test/sun/net/www/protocol/jar/B5105410.sh ! test/sun/net/www/protocol/jar/jarbug/run.sh ! test/sun/security/krb5/config/dns.sh ! test/sun/security/krb5/runNameEquals.sh ! test/sun/security/mscapi/IsSunMSCAPIAvailable.sh ! test/sun/security/pkcs11/KeyStore/Basic.sh ! test/sun/security/pkcs11/KeyStore/ClientAuth.sh ! test/sun/security/pkcs11/KeyStore/Solaris.sh ! test/sun/security/pkcs11/Provider/ConfigQuotedString.sh ! test/sun/security/pkcs11/Provider/Login.sh ! test/sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.sh ! test/sun/security/provider/PolicyFile/getinstance/getinstance.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NotifyHandshakeTest.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.sh ! test/sun/security/tools/keytool/autotest.sh ! test/sun/security/tools/keytool/printssl.sh ! test/sun/security/tools/keytool/readjar.sh ! test/sun/security/tools/keytool/standard.sh ! test/sun/security/util/Oid/S11N.sh ! test/sun/security/validator/certreplace.sh ! test/sun/security/validator/samedn.sh ! test/tools/launcher/ClassPathWildCard.sh ! test/tools/launcher/MultipleJRE.sh Changeset: bc1f16f5566f Author: darcy Date: 2013-01-11 15:39 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bc1f16f5566f 7131459: [Fmt-De] DecimalFormat produces wrong format() results when close to a tie Reviewed-by: darcy Contributed-by: olivier.lagneau at oracle.com ! src/share/classes/java/text/DigitList.java ! src/share/classes/sun/misc/FloatingDecimal.java + test/java/text/Format/DecimalFormat/TieRoundingTest.java Changeset: 6f6246aced89 Author: sherman Date: 2013-01-11 22:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6f6246aced89 8005466: JAR file entry hash table uses too much memory (zlib_util.c) Summary: realign the fields of jzcell struct Reviewed-by: sherman Contributed-by: ioi.lam at oracle.com ! src/share/native/java/util/zip/zip_util.h Changeset: 8009c7e3899e Author: sherman Date: 2013-01-11 22:45 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/8009c7e3899e Merge Changeset: 7db04ae3378f Author: chegar Date: 2013-01-13 22:09 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7db04ae3378f 8006153: HTTP protocol handler authenication should use Base64 API Reviewed-by: chegar, alanb Contributed-by: Mark Sheppard ! src/share/classes/sun/net/www/protocol/http/BasicAuthentication.java ! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java Changeset: 1109bfff4e92 Author: dholmes Date: 2013-01-13 19:57 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1109bfff4e92 8005232: (JEP-149) Class Instance size reduction Summary: Moved the fields for cached reflection objects into a seperate ReflectionData object to reduce dynamic footprint. Reviewed-by: dholmes, mchung, shade Contributed-by: Peter Levart ! src/share/classes/java/lang/Class.java Changeset: 1d7a6adf499f Author: naoto Date: 2013-01-14 11:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1d7a6adf499f 7162007: Clean up i18n related caches Reviewed-by: okutsu, ohair ! make/java/java/FILES_java.gmk ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/DecimalFormatSymbols.java ! src/share/classes/java/text/NumberFormat.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/sun/text/resources/zh/CollationData_zh_HK.java ! src/share/classes/sun/text/resources/zh/FormatData_zh_HK.java ! src/share/classes/sun/util/locale/provider/AuxLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/BreakIteratorProviderImpl.java ! src/share/classes/sun/util/locale/provider/CalendarDataProviderImpl.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/CollatorProviderImpl.java ! src/share/classes/sun/util/locale/provider/CurrencyNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java + src/share/classes/sun/util/locale/provider/ResourceBundleBasedAdapter.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java ! src/share/classes/sun/util/resources/LocaleData.java ! src/share/classes/sun/util/resources/zh/CurrencyNames_zh_HK.java ! src/share/classes/sun/util/resources/zh/CurrencyNames_zh_SG.java ! src/share/classes/sun/util/resources/zh/LocaleNames_zh_HK.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_HK.java ! test/java/util/PluggableLocale/BreakIteratorProviderTest.java ! test/java/util/PluggableLocale/CollatorProviderTest.java ! test/java/util/PluggableLocale/CurrencyNameProviderTest.java ! test/java/util/PluggableLocale/DateFormatProviderTest.java ! test/java/util/PluggableLocale/DateFormatSymbolsProviderTest.java ! test/java/util/PluggableLocale/DecimalFormatSymbolsProviderTest.java ! test/java/util/PluggableLocale/LocaleNameProviderTest.java ! test/java/util/PluggableLocale/NumberFormatProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java Changeset: dcb64d498d5b Author: ksrini Date: 2013-01-14 15:46 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/dcb64d498d5b 8005252: pack200 should support MethodParameters Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/native/com/sun/java/util/jar/pack/bands.cpp ! src/share/native/com/sun/java/util/jar/pack/bands.h ! src/share/native/com/sun/java/util/jar/pack/constants.h ! src/share/native/com/sun/java/util/jar/pack/main.cpp ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! test/ProblemList.txt ! test/tools/pack200/AttributeTests.java ! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java Changeset: edb7e34a0531 Author: xuelei Date: 2013-01-14 18:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/edb7e34a0531 8006265: Add test SSLEngineDeadlock.java to ProblemList Reviewed-by: weijun ! test/ProblemList.txt Changeset: a40052a54801 Author: uta Date: 2013-01-15 14:26 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a40052a54801 8005250: Downgrade normative references to ${java.home}/lib folder from Java client code. Summary: Javadoc was changed in accordance with CCC-8005250 request. Reviewed-by: alanb, amenkov ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java ! src/share/classes/javax/imageio/spi/IIORegistry.java ! src/share/classes/javax/sound/midi/MidiSystem.java ! src/share/classes/javax/sound/sampled/AudioSystem.java ! src/share/classes/javax/swing/UIManager.java Changeset: 4b012af44f24 Author: chegar Date: 2013-01-15 11:44 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4b012af44f24 8005406: HTTP server implementation should use Base64 API Reviewed-by: khazra, alanb, chegar Contributed-by: Mark Sheppard ! src/share/classes/com/sun/net/httpserver/BasicAuthenticator.java ! src/share/classes/sun/net/www/protocol/http/BasicAuthentication.java Changeset: 44d6cabc9a3f Author: robm Date: 2013-01-15 19:58 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/44d6cabc9a3f 8005618: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently Reviewed-by: alanb, martin, dholmes ! test/java/lang/ProcessBuilder/Basic.java Changeset: 9d8ef6174cfd Author: dl Date: 2013-01-16 10:14 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9d8ef6174cfd 8005926: Merge ThreadLocalRandom state into java.lang.Thread Reviewed-by: shade, chegar ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/util/concurrent/ThreadLocalRandom.java Changeset: a546d8897e0d Author: dl Date: 2013-01-16 12:09 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a546d8897e0d 8001666: Add lambda-compatible atomics and accumulators to the ActomicXXX classes Reviewed-by: dl, chegar, darcy, goetz Contributed-by: dl at cs.oswego.edu, chris.hegarty at oracle.com ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java Changeset: c7d54f93d3e5 Author: juh Date: 2013-01-16 09:51 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c7d54f93d3e5 8005389: Backout fix for JDK-6500133 Reviewed-by: mullan ! src/share/classes/sun/security/x509/URIName.java ! test/sun/security/x509/URIName/Parse.java Changeset: f7f77bdf248b Author: juh Date: 2013-01-16 13:35 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f7f77bdf248b 8005939: sun/security/x509/{X509CRLImplX509CertImpl}/Verify.java fail in confusing way when some providers not present Reviewed-by: mullan, weijun ! test/sun/security/x509/X509CRLImpl/Verify.java ! test/sun/security/x509/X509CertImpl/Verify.java Changeset: 9fed48caac80 Author: lana Date: 2013-01-16 12:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9fed48caac80 Merge Changeset: 787c7c1c210f Author: sherman Date: 2013-01-17 12:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/787c7c1c210f 8006090: Formatter asserts with -esa Summary: removed the offending assert Reviewed-by: alanb, darcy Contributed-by: brian.burkhalter at oracle.com ! src/share/classes/java/util/Formatter.java ! test/ProblemList.txt Changeset: e8414d69692c Author: khazra Date: 2013-01-17 14:50 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e8414d69692c 7171415: java.net.URI.equals/hashCode not consistent for some URIs Summary: Rewrite URI.hashCode() to consider encoded characters, also reviewed by vitalyd at gmail.com, schlosna at gmail.com Reviewed-by: chegar ! src/share/classes/java/net/URI.java ! test/java/net/URI/Test.java Changeset: 79fed1733d4a Author: jgish Date: 2013-01-17 15:09 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/79fed1733d4a 8006534: CLONE - TestLibrary.getUnusedRandomPort() fails intermittently-doesn't retry enough times Summary: Increase number of retries to twice the number of ports in the reserved range Reviewed-by: mduigou ! test/java/rmi/testlibrary/TestLibrary.java Changeset: f88e963960ae Author: jzavgren Date: 2013-01-18 17:34 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f88e963960ae 8005120: Compiler warnings in socket transport native code Reviewed-by: chegar, dsamersoff ! src/share/transport/socket/socketTransport.c ! src/share/transport/socket/sysSocket.h ! src/solaris/transport/socket/socket_md.c ! src/windows/transport/socket/socket_md.c Changeset: 06da87777d0e Author: alanb Date: 2013-01-18 18:48 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/06da87777d0e 6939260: (fs) BasicFileAttributes.lastModifiedTime() should return last modified time with higher precision Reviewed-by: chegar ! src/solaris/classes/sun/nio/fs/UnixFileAttributes.java ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c ! test/java/nio/file/attribute/BasicFileAttributeView/Basic.java Changeset: 33d0175ea8d9 Author: msheppar Date: 2013-01-19 08:39 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/33d0175ea8d9 8006568: HTTP protocol handler NLTM Authentication should use Base64 API Reviewed-by: chegar, alanb ! src/solaris/classes/sun/net/www/protocol/http/ntlm/NTLMAuthentication.java ! src/windows/classes/sun/net/www/protocol/http/ntlm/NTLMAuthSequence.java ! test/sun/net/www/protocol/http/ProxyTunnelServer.java Changeset: 78514544980d Author: lancea Date: 2013-01-19 10:11 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/78514544980d 8006139: add missing methods to javax.sql.rowset.serial.SQLInputImpl, SQLOutputImpl Reviewed-by: naoto, ulfzibis, alanb ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java Changeset: d3da0d29d7cd Author: lancea Date: 2013-01-19 10:53 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d3da0d29d7cd 8005080: JDBC 4.2 Core changes Reviewed-by: naoto ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/Driver.java ! src/share/classes/java/sql/DriverManager.java + src/share/classes/java/sql/JDBCType.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLTimeoutException.java + src/share/classes/java/sql/SQLType.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/sql/Types.java ! src/share/classes/java/sql/package.html ! src/share/classes/javax/sql/DataSource.java ! src/share/classes/javax/sql/XADataSource.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java Changeset: bb2ed83676d2 Author: chegar Date: 2013-01-20 09:37 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bb2ed83676d2 8006560: java/net/ipv6tests/B6521014.java fails intermittently Reviewed-by: khazra, wetmore ! test/java/net/ipv6tests/B6521014.java Changeset: 6ca6b6f07653 Author: okutsu Date: 2013-01-21 12:04 +0900 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6ca6b6f07653 4745761: (cal) RFE: Support builder for constructing Calendar Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/JapaneseImperialCalendar.java + test/java/util/Calendar/Builder/BuilderTest.java ! test/java/util/Calendar/CalendarTypeTest.java Changeset: 3c1a440a1e12 Author: okutsu Date: 2013-01-21 15:41 +0900 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3c1a440a1e12 8004489: Add support for Minguo and Hijrah calendars to CalendarNameProvider SPI 8006509: Add more calendar symbol names from CLDR Reviewed-by: peytoia ! make/tools/src/build/tools/cldrconverter/Bundle.java ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java ! make/tools/src/build/tools/cldrconverter/CalendarType.java ! make/tools/src/build/tools/cldrconverter/LDMLParseHandler.java ! src/share/classes/java/util/spi/CalendarNameProvider.java ! src/share/classes/sun/text/resources/FormatData.java ! src/share/classes/sun/text/resources/ar/FormatData_ar.java ! src/share/classes/sun/text/resources/be/FormatData_be.java ! src/share/classes/sun/text/resources/bg/FormatData_bg.java ! src/share/classes/sun/text/resources/ca/FormatData_ca.java ! src/share/classes/sun/text/resources/cs/FormatData_cs.java ! src/share/classes/sun/text/resources/da/FormatData_da.java ! src/share/classes/sun/text/resources/de/FormatData_de.java ! src/share/classes/sun/text/resources/el/FormatData_el.java ! src/share/classes/sun/text/resources/es/FormatData_es.java ! src/share/classes/sun/text/resources/et/FormatData_et.java ! src/share/classes/sun/text/resources/fi/FormatData_fi.java ! src/share/classes/sun/text/resources/fr/FormatData_fr.java ! src/share/classes/sun/text/resources/hi/FormatData_hi_IN.java ! src/share/classes/sun/text/resources/hr/FormatData_hr.java ! src/share/classes/sun/text/resources/hu/FormatData_hu.java ! src/share/classes/sun/text/resources/is/FormatData_is.java ! src/share/classes/sun/text/resources/it/FormatData_it.java ! src/share/classes/sun/text/resources/iw/FormatData_iw.java ! src/share/classes/sun/text/resources/ja/FormatData_ja.java ! src/share/classes/sun/text/resources/ko/FormatData_ko.java ! src/share/classes/sun/text/resources/lt/FormatData_lt.java ! src/share/classes/sun/text/resources/lv/FormatData_lv.java ! src/share/classes/sun/text/resources/mk/FormatData_mk.java ! src/share/classes/sun/text/resources/ms/FormatData_ms.java ! src/share/classes/sun/text/resources/mt/FormatData_mt.java ! src/share/classes/sun/text/resources/nl/FormatData_nl.java ! src/share/classes/sun/text/resources/pl/FormatData_pl.java ! src/share/classes/sun/text/resources/pt/FormatData_pt.java ! src/share/classes/sun/text/resources/ro/FormatData_ro.java ! src/share/classes/sun/text/resources/ru/FormatData_ru.java ! src/share/classes/sun/text/resources/sk/FormatData_sk.java ! src/share/classes/sun/text/resources/sl/FormatData_sl.java ! src/share/classes/sun/text/resources/sr/FormatData_sr.java ! src/share/classes/sun/text/resources/sv/FormatData_sv.java ! src/share/classes/sun/text/resources/th/FormatData_th.java ! src/share/classes/sun/text/resources/tr/FormatData_tr.java ! src/share/classes/sun/text/resources/uk/FormatData_uk.java ! src/share/classes/sun/text/resources/vi/FormatData_vi.java ! src/share/classes/sun/text/resources/zh/FormatData_zh.java ! src/share/classes/sun/text/resources/zh/FormatData_zh_TW.java ! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java + test/java/util/Calendar/CldrFormatNamesTest.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: bb940b2107bd Author: juh Date: 2013-01-21 15:05 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bb940b2107bd 8006092: SecurityPermission: printIdentity doesn't exist Reviewed-by: weijun ! test/sun/security/tools/policytool/UpdatePermissions.html Changeset: f21a3c273fb2 Author: dl Date: 2013-01-21 13:50 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f21a3c273fb2 8005311: Add Scalable Updatable Variables, DoubleAccumulator, DoubleAdder, LongAccumulator, LongAdder Reviewed-by: chegar, darcy, goetz ! make/java/java/FILES_java.gmk + src/share/classes/java/util/concurrent/atomic/DoubleAccumulator.java + src/share/classes/java/util/concurrent/atomic/DoubleAdder.java + src/share/classes/java/util/concurrent/atomic/LongAccumulator.java + src/share/classes/java/util/concurrent/atomic/LongAdder.java + src/share/classes/java/util/concurrent/atomic/Striped64.java + test/java/util/concurrent/atomic/DoubleAdderDemo.java + test/java/util/concurrent/atomic/LongAdderDemo.java Changeset: de30e46250c5 Author: lancea Date: 2013-01-21 14:08 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/de30e46250c5 8006642: Fix javadoc warnings due to Integer.MAX_VALUE Reviewed-by: alanb ! src/share/classes/java/sql/BatchUpdateException.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/Statement.java Changeset: 8b1857409159 Author: lana Date: 2013-01-20 23:38 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/8b1857409159 Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java Changeset: 7f4e3da76ec1 Author: lana Date: 2013-01-21 11:16 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7f4e3da76ec1 Merge Changeset: 8ee6d45348ba Author: vinnie Date: 2013-01-22 23:32 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/8ee6d45348ba 6263419: No way to clean the memory for a java.security.Key Reviewed-by: mullan ! src/share/classes/java/security/PrivateKey.java ! src/share/classes/javax/crypto/SecretKey.java ! src/share/classes/javax/security/auth/Destroyable.java + test/javax/security/auth/Destroyable/KeyDestructionTest.java Changeset: c18f28312c49 Author: smarks Date: 2013-01-22 18:30 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c18f28312c49 8005646: TEST_BUG: java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup leaves process running Reviewed-by: mchung ! test/java/rmi/activation/ActivationSystem/unregisterGroup/ActivateMe.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java ! test/java/rmi/activation/ActivationSystem/unregisterGroup/rmid.security.policy Changeset: 919afffa70b0 Author: sherman Date: 2013-01-22 20:59 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/919afffa70b0 8003680: JSR 310 Date/Time API Summary: Integration of JSR310 Date/Time API for M6 Reviewed-by: alanb, naoto, dholmes Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, richard.warburton at gmail.com, misterm at gmail.com ! make/docs/CORE_PKGS.gmk ! make/java/Makefile + make/java/time/Makefile ! make/jprt.properties ! make/sun/Makefile + make/sun/tzdb/Makefile ! make/tools/Makefile + make/tools/src/build/tools/tzdb/ChronoField.java + make/tools/src/build/tools/tzdb/DateTimeException.java + make/tools/src/build/tools/tzdb/LocalDate.java + make/tools/src/build/tools/tzdb/LocalDateTime.java + make/tools/src/build/tools/tzdb/LocalTime.java + make/tools/src/build/tools/tzdb/TimeDefinition.java + make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java + make/tools/src/build/tools/tzdb/Utils.java + make/tools/src/build/tools/tzdb/ZoneOffset.java + make/tools/src/build/tools/tzdb/ZoneOffsetTransition.java + make/tools/src/build/tools/tzdb/ZoneOffsetTransitionRule.java + make/tools/src/build/tools/tzdb/ZoneRules.java + make/tools/src/build/tools/tzdb/ZoneRulesBuilder.java + make/tools/tzdb/Makefile ! makefiles/CreateJars.gmk + makefiles/GendataTZDB.gmk ! makefiles/GenerateData.gmk ! makefiles/Tools.gmk + src/share/classes/java/time/Clock.java + src/share/classes/java/time/DateTimeException.java + src/share/classes/java/time/DayOfWeek.java + src/share/classes/java/time/Duration.java + src/share/classes/java/time/Instant.java + src/share/classes/java/time/LocalDate.java + src/share/classes/java/time/LocalDateTime.java + src/share/classes/java/time/LocalTime.java + src/share/classes/java/time/Month.java + src/share/classes/java/time/Period.java + src/share/classes/java/time/PeriodParser.java + src/share/classes/java/time/Ser.java + src/share/classes/java/time/ZoneId.java + src/share/classes/java/time/ZoneOffset.java + src/share/classes/java/time/ZoneRegion.java + src/share/classes/java/time/ZonedDateTime.java + src/share/classes/java/time/calendar/ChronoDateImpl.java + src/share/classes/java/time/calendar/HijrahChrono.java + src/share/classes/java/time/calendar/HijrahDate.java + src/share/classes/java/time/calendar/HijrahDeviationReader.java + src/share/classes/java/time/calendar/HijrahEra.java + src/share/classes/java/time/calendar/JapaneseChrono.java + src/share/classes/java/time/calendar/JapaneseDate.java + src/share/classes/java/time/calendar/JapaneseEra.java + src/share/classes/java/time/calendar/MinguoChrono.java + src/share/classes/java/time/calendar/MinguoDate.java + src/share/classes/java/time/calendar/MinguoEra.java + src/share/classes/java/time/calendar/Ser.java + src/share/classes/java/time/calendar/ThaiBuddhistChrono.java + src/share/classes/java/time/calendar/ThaiBuddhistDate.java + src/share/classes/java/time/calendar/ThaiBuddhistEra.java + src/share/classes/java/time/calendar/package-info.java + src/share/classes/java/time/format/DateTimeBuilder.java + src/share/classes/java/time/format/DateTimeFormatStyleProvider.java + src/share/classes/java/time/format/DateTimeFormatSymbols.java + src/share/classes/java/time/format/DateTimeFormatter.java + src/share/classes/java/time/format/DateTimeFormatterBuilder.java + src/share/classes/java/time/format/DateTimeFormatters.java + src/share/classes/java/time/format/DateTimeParseContext.java + src/share/classes/java/time/format/DateTimeParseException.java + src/share/classes/java/time/format/DateTimePrintContext.java + src/share/classes/java/time/format/DateTimePrintException.java + src/share/classes/java/time/format/DateTimeTextProvider.java + src/share/classes/java/time/format/FormatStyle.java + src/share/classes/java/time/format/SignStyle.java + src/share/classes/java/time/format/TextStyle.java + src/share/classes/java/time/format/package-info.java + src/share/classes/java/time/overview.html + src/share/classes/java/time/package-info.java + src/share/classes/java/time/temporal/Adjusters.java + src/share/classes/java/time/temporal/Chrono.java + src/share/classes/java/time/temporal/ChronoField.java + src/share/classes/java/time/temporal/ChronoLocalDate.java + src/share/classes/java/time/temporal/ChronoLocalDateTime.java + src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java + src/share/classes/java/time/temporal/ChronoUnit.java + src/share/classes/java/time/temporal/ChronoZonedDateTime.java + src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java + src/share/classes/java/time/temporal/Era.java + src/share/classes/java/time/temporal/ISOChrono.java + src/share/classes/java/time/temporal/ISOEra.java + src/share/classes/java/time/temporal/ISOFields.java + src/share/classes/java/time/temporal/JulianFields.java + src/share/classes/java/time/temporal/MonthDay.java + src/share/classes/java/time/temporal/OffsetDate.java + src/share/classes/java/time/temporal/OffsetDateTime.java + src/share/classes/java/time/temporal/OffsetTime.java + src/share/classes/java/time/temporal/Queries.java + src/share/classes/java/time/temporal/Ser.java + src/share/classes/java/time/temporal/SimplePeriod.java + src/share/classes/java/time/temporal/Temporal.java + src/share/classes/java/time/temporal/TemporalAccessor.java + src/share/classes/java/time/temporal/TemporalAdder.java + src/share/classes/java/time/temporal/TemporalAdjuster.java + src/share/classes/java/time/temporal/TemporalField.java + src/share/classes/java/time/temporal/TemporalQuery.java + src/share/classes/java/time/temporal/TemporalSubtractor.java + src/share/classes/java/time/temporal/TemporalUnit.java + src/share/classes/java/time/temporal/ValueRange.java + src/share/classes/java/time/temporal/WeekFields.java + src/share/classes/java/time/temporal/Year.java + src/share/classes/java/time/temporal/YearMonth.java + src/share/classes/java/time/temporal/package-info.java + src/share/classes/java/time/zone/Ser.java + src/share/classes/java/time/zone/TzdbZoneRulesProvider.java + src/share/classes/java/time/zone/ZoneOffsetTransition.java + src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java + src/share/classes/java/time/zone/ZoneRules.java + src/share/classes/java/time/zone/ZoneRulesException.java + src/share/classes/java/time/zone/ZoneRulesProvider.java + src/share/classes/java/time/zone/package-info.java ! src/share/classes/java/util/Formatter.java ! test/Makefile + test/java/time/META-INF/services/java.time.temporal.Chrono + test/java/time/TEST.properties + test/java/time/tck/java/time/AbstractDateTimeTest.java + test/java/time/tck/java/time/AbstractTCKTest.java + test/java/time/tck/java/time/TCKClock.java + test/java/time/tck/java/time/TCKClock_Fixed.java + test/java/time/tck/java/time/TCKClock_Offset.java + test/java/time/tck/java/time/TCKClock_System.java + test/java/time/tck/java/time/TCKClock_Tick.java + test/java/time/tck/java/time/TCKDayOfWeek.java + test/java/time/tck/java/time/TCKDuration.java + test/java/time/tck/java/time/TCKInstant.java + test/java/time/tck/java/time/TCKLocalDate.java + test/java/time/tck/java/time/TCKLocalDateTime.java + test/java/time/tck/java/time/TCKLocalTime.java + test/java/time/tck/java/time/TCKMonth.java + test/java/time/tck/java/time/TCKZoneId.java + test/java/time/tck/java/time/TCKZoneOffset.java + test/java/time/tck/java/time/TCKZonedDateTime.java + test/java/time/tck/java/time/calendar/CopticChrono.java + test/java/time/tck/java/time/calendar/CopticDate.java + test/java/time/tck/java/time/calendar/CopticEra.java + test/java/time/tck/java/time/calendar/TestChronoLocalDate.java + test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java + test/java/time/tck/java/time/calendar/TestHijrahChrono.java + test/java/time/tck/java/time/calendar/TestJapaneseChrono.java + test/java/time/tck/java/time/calendar/TestMinguoChrono.java + test/java/time/tck/java/time/calendar/TestServiceLoader.java + test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java + test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java + test/java/time/tck/java/time/format/TCKDateTimeFormatter.java + test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java + test/java/time/tck/java/time/format/TCKDateTimeFormatters.java + test/java/time/tck/java/time/format/TCKDateTimePrintException.java + test/java/time/tck/java/time/format/TCKDateTimeTextPrinting.java + test/java/time/tck/java/time/format/TCKLocalizedFieldParser.java + test/java/time/tck/java/time/format/TCKLocalizedFieldPrinter.java + test/java/time/tck/java/time/temporal/TCKDateTimeAdjusters.java + test/java/time/tck/java/time/temporal/TCKISOFields.java + test/java/time/tck/java/time/temporal/TCKJulianFields.java + test/java/time/tck/java/time/temporal/TCKMonthDay.java + test/java/time/tck/java/time/temporal/TCKOffsetDate.java + test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java + test/java/time/tck/java/time/temporal/TCKOffsetTime.java + test/java/time/tck/java/time/temporal/TCKSimplePeriod.java + test/java/time/tck/java/time/temporal/TCKWeekFields.java + test/java/time/tck/java/time/temporal/TCKYear.java + test/java/time/tck/java/time/temporal/TCKYearMonth.java + test/java/time/tck/java/time/temporal/TestChrono.java + test/java/time/tck/java/time/temporal/TestChronoLocalDate.java + test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java + test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java + test/java/time/tck/java/time/temporal/TestISOChrono.java + test/java/time/tck/java/time/zone/TCKFixedZoneRules.java + test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java + test/java/time/tck/java/time/zone/TCKZoneOffsetTransitionRule.java + test/java/time/tck/java/time/zone/TCKZoneRules.java + test/java/time/tck/java/time/zone/TCKZoneRulesProvider.java + test/java/time/test/java/time/AbstractTest.java + test/java/time/test/java/time/MockSimplePeriod.java + test/java/time/test/java/time/TestClock_Fixed.java + test/java/time/test/java/time/TestClock_Offset.java + test/java/time/test/java/time/TestClock_System.java + test/java/time/test/java/time/TestClock_Tick.java + test/java/time/test/java/time/TestDuration.java + test/java/time/test/java/time/TestInstant.java + test/java/time/test/java/time/TestLocalDate.java + test/java/time/test/java/time/TestLocalDateTime.java + test/java/time/test/java/time/TestLocalTime.java + test/java/time/test/java/time/TestPeriod.java + test/java/time/test/java/time/TestPeriodParser.java + test/java/time/test/java/time/TestZoneId.java + test/java/time/test/java/time/TestZoneOffset.java + test/java/time/test/java/time/TestZonedDateTime.java + test/java/time/test/java/time/format/AbstractTestPrinterParser.java + test/java/time/test/java/time/format/MockIOExceptionAppendable.java + test/java/time/test/java/time/format/TestCharLiteralParser.java + test/java/time/test/java/time/format/TestCharLiteralPrinter.java + test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java + test/java/time/test/java/time/format/TestDateTimeFormatter.java + test/java/time/test/java/time/format/TestDateTimeFormatters.java + test/java/time/test/java/time/format/TestDateTimePrintException.java + test/java/time/test/java/time/format/TestDateTimeTextProvider.java + test/java/time/test/java/time/format/TestFractionPrinterParser.java + test/java/time/test/java/time/format/TestNumberParser.java + test/java/time/test/java/time/format/TestNumberPrinter.java + test/java/time/test/java/time/format/TestPadParserDecorator.java + test/java/time/test/java/time/format/TestPadPrinterDecorator.java + test/java/time/test/java/time/format/TestReducedParser.java + test/java/time/test/java/time/format/TestReducedPrinter.java + test/java/time/test/java/time/format/TestSettingsParser.java + test/java/time/test/java/time/format/TestStringLiteralParser.java + test/java/time/test/java/time/format/TestStringLiteralPrinter.java + test/java/time/test/java/time/format/TestTextParser.java + test/java/time/test/java/time/format/TestTextPrinter.java + test/java/time/test/java/time/format/TestZoneIdParser.java + test/java/time/test/java/time/format/TestZoneOffsetParser.java + test/java/time/test/java/time/format/TestZoneOffsetPrinter.java + test/java/time/test/java/time/format/TestZoneTextPrinterParser.java + test/java/time/test/java/time/temporal/MockFieldNoValue.java + test/java/time/test/java/time/temporal/MockFieldValue.java + test/java/time/test/java/time/temporal/TestChronoUnit.java + test/java/time/test/java/time/temporal/TestDateTimeAdjusters.java + test/java/time/test/java/time/temporal/TestDateTimeBuilderCombinations.java + test/java/time/test/java/time/temporal/TestDateTimeValueRange.java + test/java/time/test/java/time/temporal/TestISOChronoImpl.java + test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java + test/java/time/test/java/time/temporal/TestMonthDay.java + test/java/time/test/java/time/temporal/TestOffsetDate.java + test/java/time/test/java/time/temporal/TestOffsetDateTime.java + test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java + test/java/time/test/java/time/temporal/TestOffsetTime.java + test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java + test/java/time/test/java/time/temporal/TestYear.java + test/java/time/test/java/time/temporal/TestYearMonth.java + test/java/time/test/java/time/zone/TestFixedZoneRules.java + test/java/time/test/java/util/TestFormatter.java Changeset: 71691b9d45ab Author: vinnie Date: 2013-01-23 09:49 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/71691b9d45ab 8006741: javadoc cleanup for 6263419 Reviewed-by: alanb ! src/share/classes/java/security/PrivateKey.java ! src/share/classes/javax/crypto/SecretKey.java Changeset: 01b36b400145 Author: uta Date: 2013-01-23 15:06 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/01b36b400145 6519127: user.home property not set correctly Summary: Registry-based approach was changed to SHGetKnownFolderPath/SHGetFolderPathW Reviewed-by: alanb, anthony ! src/windows/native/java/lang/java_props_md.c Changeset: bf2a14ebb6e9 Author: chegar Date: 2013-01-23 14:45 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bf2a14ebb6e9 8006669: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh fails on mac Reviewed-by: alanb ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.java Changeset: 53064bbaeec5 Author: alanb Date: 2013-01-23 15:12 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/53064bbaeec5 8006764: FunctionalInterface missing from rt.jar (old build) Reviewed-by: lancea, forax ! make/java/java/FILES_java.gmk Changeset: c9eb1d3ef37f Author: robm Date: 2013-01-23 17:54 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c9eb1d3ef37f 8004729: Add java.lang.reflect.Parameter and related changes for parameter reflection Reviewed-by: darcy, forax, psandoz, dholmes, tbell ! make/java/java/Exportedfiles.gmk ! make/java/java/FILES_c.gmk ! make/java/java/mapfile-vers ! makefiles/mapfiles/libjava/mapfile-vers ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Method.java ! src/share/classes/java/lang/reflect/Modifier.java + src/share/classes/java/lang/reflect/Parameter.java ! src/share/javavm/export/jvm.h + src/share/native/java/lang/reflect/Executable.c + test/java/lang/reflect/Parameter/WithParameters.java + test/java/lang/reflect/Parameter/WithoutParameters.java Changeset: e0552f13f4a2 Author: sherman Date: 2013-01-23 10:29 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e0552f13f4a2 8006773: test/java/util/zip/ZipFile/FinalizeZipFile.java failing intermittently Summary: fixed the test case Reviewed-by: alanb ! test/java/util/zip/ZipFile/FinalizeZipFile.java Changeset: 87f5569effdd Author: sherman Date: 2013-01-23 10:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/87f5569effdd Merge Changeset: 0c86df653029 Author: vinnie Date: 2013-01-23 21:25 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0c86df653029 8006591: Protect keystore entries using stronger PBE algorithms Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java + test/java/security/KeyStore/PBETest.java Changeset: 1da93663f8f3 Author: vinnie Date: 2013-01-23 23:13 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1da93663f8f3 8005408: KeyStore API enhancements Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java + src/share/classes/java/security/PKCS12Attribute.java ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! src/share/classes/sun/security/x509/AlgorithmId.java + test/sun/security/pkcs12/StorePasswordTest.java + test/sun/security/pkcs12/StoreSecretKeyTest.java + test/sun/security/pkcs12/StoreTrustedCertTest.java + test/sun/security/pkcs12/trusted.pem Changeset: 89f37f7188df Author: mullan Date: 2013-01-23 20:46 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/89f37f7188df 8006813: Compilation error in PKCS12KeyStore.java Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: b68ac92d0b2a Author: alanb Date: 2013-01-24 09:47 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b68ac92d0b2a 8006524: JSR-3: Allows java.beans to be optional Reviewed-by: dfuchs, mchung ! src/share/classes/javax/management/MXBean.java ! src/share/classes/javax/management/monitor/package.html Changeset: 943af87e0269 Author: vinnie Date: 2013-01-24 16:44 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/943af87e0269 8006855: PKCS12 test failures due to unsupported algorithm Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! test/java/security/KeyStore/PBETest.java ! test/sun/security/pkcs12/StoreSecretKeyTest.java Changeset: 1fd613016ad9 Author: ksrini Date: 2013-01-24 09:34 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1fd613016ad9 8006850: [pack200] disable pack200 tests until JSR-308 is implemented Reviewed-by: alanb ! test/ProblemList.txt Changeset: b3f0e0c79bcc Author: vinnie Date: 2013-01-24 18:21 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b3f0e0c79bcc 8006863: javadoc cleanup for 8005408 Reviewed-by: alanb ! src/share/classes/java/security/PKCS12Attribute.java Changeset: 4d3c05cc21d5 Author: darcy Date: 2013-01-24 16:54 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4d3c05cc21d5 8006895: Clarify that FunctionalInferface is only informative Reviewed-by: briangoetz ! src/share/classes/java/lang/FunctionalInterface.java Changeset: 4c9fcb5cbc07 Author: dingxmin Date: 2013-01-25 17:00 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4c9fcb5cbc07 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource() Reviewed-by: chegar ! src/share/classes/sun/misc/URLClassPath.java + test/sun/misc/URLClassPath/JarLoaderTest.java Changeset: 4a4b97f7f83b Author: alanb Date: 2013-01-25 13:09 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4a4b97f7f83b 8006565: java.lang.instrument specification should make it clear that -javaagent is optional Reviewed-by: sla, dcubed, mchung ! src/share/classes/java/lang/instrument/package.html Changeset: c6ea84a629db Author: vinnie Date: 2013-01-25 16:19 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c6ea84a629db 8006946: PKCS12 test failure due to incorrect alias name Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: 117491dd58c2 Author: vinnie Date: 2013-01-25 17:47 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/117491dd58c2 8006951: Avoid storing duplicate PKCS12 attributes Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: 77bde15bc6a9 Author: khazra Date: 2013-01-25 11:52 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/77bde15bc6a9 7017962: Obsolete link is used in URL class level spec Summary: Change the link to an archived document Reviewed-by: chegar, mduigou ! src/share/classes/java/net/URL.java Changeset: 4209b3936a7f Author: mduigou Date: 2013-01-25 16:13 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4209b3936a7f 8005632: Extend java.util.Logger to use Supplier for messages Reviewed-by: briangoetz, mduigou Contributed-by: henry.jen at oracle.com ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/LoggerSupplierAPIsTest.java Changeset: 1d918647332e Author: mduigou Date: 2013-01-25 16:13 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1d918647332e 8004201: Add static utility methods to primitives to be used for redution operations. Reviewed-by: darcy, mduigou, briangoetz, dholmes Contributed-by: akhil.arora at oracle.com ! src/share/classes/java/lang/Boolean.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java + test/java/lang/PrimitiveSumMinMaxTest.java Changeset: 86a5b435c928 Author: jgish Date: 2013-01-22 11:14 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/86a5b435c928 4247235: (spec str) StringBuffer.insert(int, char[]) specification is inconsistent Summary: Add blanket null-handling statement to StringBuilder and StringBuffer Reviewed-by: mduigou ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/StringBuffer.java ! src/share/classes/java/lang/StringBuilder.java Changeset: e96577d82cbb Author: alanb Date: 2013-01-26 16:57 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e96577d82cbb 8006503: JVM_PrintStackTrace is not used in JDK Reviewed-by: alanb, darcy Contributed-by: eric.mccorkle at oracle.com ! src/share/javavm/export/jvm.h Changeset: 57561ea851d2 Author: lana Date: 2013-01-26 19:22 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/57561ea851d2 Merge - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 4faaaf5027a5 Author: alexsch Date: 2013-01-14 08:32 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4faaaf5027a5 7166409: bug4331515.java fail with NullPointerException on ubuntu10.04-x86 for JDK8 Reviewed-by: serb ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java Changeset: 9c6ca265b4a1 Author: alexsch Date: 2013-01-15 12:49 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9c6ca265b4a1 8003978: closed/javax/swing/JRootPane/bug4670486.java fails since jdk7u12b01 on macosx Reviewed-by: serb, leonidr ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/motif/MotifLookAndFeel.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/share/classes/sun/swing/SwingUtilities2.java ! test/java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.java Changeset: 1b886bd5e5bf Author: serb Date: 2013-01-15 21:57 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1b886bd5e5bf 7124525: [macosx] No animation on certain Swing components in Aqua LaF Reviewed-by: alexsch, swingler ! src/macosx/classes/com/apple/laf/AquaPainter.java ! src/macosx/classes/com/apple/laf/ImageCache.java Changeset: 7ea1372be2fe Author: mcherkas Date: 2013-01-16 17:26 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7ea1372be2fe 8005492: Reduce number of warnings in sun/awt/* classes Reviewed-by: art, anthony ! src/share/classes/java/awt/Button.java ! src/share/classes/java/awt/Checkbox.java ! src/share/classes/java/awt/Choice.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/Frame.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/Scrollbar.java ! src/share/classes/java/awt/TextArea.java ! src/share/classes/java/awt/TextComponent.java ! src/share/classes/java/awt/TextField.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/Window.java ! src/share/classes/sun/awt/image/SurfaceManager.java Changeset: 23f9955ae34a Author: lana Date: 2013-01-16 15:57 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/23f9955ae34a Merge Changeset: 47243a4efb8b Author: kshefov Date: 2013-01-17 15:08 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/47243a4efb8b 7124209: [macosx] SpringLayout issue. BASELINE is not in the range: [NORTH, SOUTH] Reviewed-by: serb, alexsch + test/javax/swing/SpringLayout/4726194/bug4726194.java Changeset: 035f87fc9f74 Author: anthony Date: 2013-01-18 14:17 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/035f87fc9f74 8005465: [macosx] Evaluate if checking for the -XstartOnFirstThread is still needed in awt.m Summary: Allow one to start AWT on the main thread w/o exceptions Reviewed-by: art, serb ! src/macosx/native/sun/awt/awt.m Changeset: 5309fed435b5 Author: serb Date: 2013-01-18 18:17 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5309fed435b5 7179050: [macosx] Make LWAWT be able to run on AppKit thread Summary: Removed irrelevant assertions from the LWAWT native methods Reviewed-by: serb, anthony Contributed-by: petr.pchelko at oracle.com ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTSurfaceLayers.m ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/ApplicationDelegate.m ! src/macosx/native/sun/awt/CClipboard.m ! src/macosx/native/sun/awt/CCursorManager.m ! src/macosx/native/sun/awt/CDesktopPeer.m ! src/macosx/native/sun/awt/CDragSourceContextPeer.m ! src/macosx/native/sun/awt/CImage.m ! src/macosx/native/sun/awt/CInputMethod.m ! src/macosx/native/sun/awt/CMenu.m ! src/macosx/native/sun/awt/CMenuComponent.m ! src/macosx/native/sun/awt/CMenuItem.m ! src/macosx/native/sun/awt/CPopupMenu.m ! src/macosx/native/sun/awt/CTrayIcon.m ! src/macosx/native/sun/awt/CWrapper.m ! src/macosx/native/sun/awt/JavaComponentAccessibility.m ! src/macosx/native/sun/awt/LWCToolkit.m ! src/macosx/native/sun/awt/awt.m ! src/macosx/native/sun/osxapp/ThreadUtilities.h ! src/macosx/native/sun/osxapp/ThreadUtilities.m Changeset: 112c08b41ca2 Author: alitvinov Date: 2013-01-18 18:34 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/112c08b41ca2 8006417: JComboBox.showPopup(), hidePopup() fails in JRE 1.7 on OS X Reviewed-by: art, serb ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java + test/javax/swing/JComboBox/ShowPopupAfterHidePopupTest/ShowPopupAfterHidePopupTest.java Changeset: b4131358120a Author: raginip Date: 2013-01-18 11:33 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b4131358120a 8000839: Integrate the Java Access Bridge with Java Runtime Reviewed-by: ptbrunet, erikj ! make/Makefile + make/bridge/AccessBridgeJava/Makefile + make/bridge/JAWTAccessBridge/Files_cpp.gmk + make/bridge/JAWTAccessBridge/Makefile + make/bridge/Jabswitch/Makefile + make/bridge/Jaccess/Makefile + make/bridge/JavaAccessBridge/Files_cpp.gmk + make/bridge/JavaAccessBridge/Makefile + make/bridge/Makefile + make/bridge/WindowsAccessBridge/Files_cpp.gmk + make/bridge/WindowsAccessBridge/Makefile ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CreateJars.gmk ! makefiles/GensrcMisc.gmk Changeset: f55d869052dd Author: alexsch Date: 2013-01-21 17:55 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f55d869052dd 8004298: NPE in WindowsTreeUI.ensureRowsAreVisible Reviewed-by: serb ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTreeUI.java + test/javax/swing/JTree/8004298/bug8004298.java Changeset: dd7e1cc4253c Author: alexp Date: 2013-01-24 15:26 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/dd7e1cc4253c 7147078: [macosx] Echo char set in TextField doesn't prevent word jumping Reviewed-by: art ! src/macosx/classes/com/apple/laf/AquaKeyBindings.java ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java Changeset: 04d2005fa178 Author: alexp Date: 2013-01-24 15:52 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/04d2005fa178 7132793: [macosx] setWheelScrollEnabled action reversed Reviewed-by: serb, art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWScrollPanePeer.java Changeset: 40a45a72a120 Author: serb Date: 2013-01-24 15:55 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/40a45a72a120 8005997: [macosx] Printer Dialog opens an additional title bar Reviewed-by: anthony, art Contributed-by: petr.pchelko at oracle.com ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: fab11b21ee6e Author: kizune Date: 2013-01-24 16:09 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/fab11b21ee6e 7143768: [macosx] Unexpected NullPointerException and java.io.IOException during DnD Reviewed-by: alexp ! src/macosx/classes/sun/lwawt/macosx/CDataTransferer.java Changeset: 7dd1896b37c8 Author: malenkov Date: 2013-01-24 17:26 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7dd1896b37c8 6817933: Setting the background of an HTML Widget changes the native Windows JFileChooser Reviewed-by: alexsch ! src/share/classes/sun/swing/WindowsPlacesBar.java + test/javax/swing/JFileChooser/6817933/Test6817933.java Changeset: f8526b99b825 Author: serb Date: 2013-01-24 17:50 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f8526b99b825 8003173: [macosx] Fullscreen on Mac leaves an empty rectangle Reviewed-by: anthony, alexsch ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java + test/java/awt/FullScreen/FullScreenInsets/FullScreenInsets.java Changeset: 32721a1a8da8 Author: malenkov Date: 2013-01-24 17:57 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/32721a1a8da8 8005138: test/java/beans/Introspector/TestTypeResolver.java fails Reviewed-by: alexsch ! test/java/beans/Introspector/TestTypeResolver.java Changeset: 7cda96a78260 Author: malenkov Date: 2013-01-24 18:06 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7cda96a78260 8003400: JTree scrolling problem when using large model in WindowsLookAndFeel Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java + test/javax/swing/JTree/8003400/Test8003400.java Changeset: e616c28c5120 Author: erikj Date: 2013-01-28 14:23 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e616c28c5120 Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CreateJars.gmk - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java Changeset: a1a55db02f34 Author: lana Date: 2013-01-29 20:19 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a1a55db02f34 Merge ! makefiles/CreateJars.gmk Changeset: 9d5c43050210 Author: dl Date: 2013-01-11 16:50 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9d5c43050210 8006123: Support @Contended Annotation - JEP 142 (jdk part) Summary: jdk changes for 8003895. Reviewed-by: darcy, jrose, coleenp, dholmes, kvn Contributed-by: Aleksey Shipilev + src/share/classes/sun/misc/Contended.java Changeset: 739351a0a7a1 Author: kvn Date: 2013-01-23 11:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/739351a0a7a1 8006799: Optimize sun.nio.cs.ISO_8859_1$Encode.encodeArrayLoop() (jdk part of 6896617) Summary: Move hot loop in ISO_8859_1$Encode.encodeArrayLoop() into separate method encodeISOArray() to be replaced by JVM JIT compiler with optimized intrinsic code. Reviewed-by: alanb, sherman ! src/share/classes/sun/nio/cs/ISO_8859_1.java Changeset: e9d00d30fcca Author: amurillo Date: 2013-01-25 03:02 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e9d00d30fcca Merge Changeset: ac286bf65242 Author: amurillo Date: 2013-01-30 10:18 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ac286bf65242 Merge - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java Changeset: 3c499051a5df Author: erikj Date: 2013-01-29 16:35 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3c499051a5df 8006873: SWAT-b74 msvcr100.dll does not have the permission for all Reviewed-by: alanb, tbell ! makefiles/CopyFiles.gmk Changeset: 4a67fdb752b7 Author: katleman Date: 2013-01-30 13:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4a67fdb752b7 Merge ! makefiles/CopyFiles.gmk Changeset: 6ba6353ab42c Author: katleman Date: 2013-01-31 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6ba6353ab42c Added tag jdk8-b75 for changeset 4a67fdb752b7 ! .hgtags From andrew.brygin at oracle.com Fri Feb 1 15:41:41 2013 From: andrew.brygin at oracle.com (Andrew Brygin) Date: Fri, 01 Feb 2013 19:41:41 +0400 Subject: [OpenJDK 2D-Dev] [8] request fro review: 8005530: [lcms] Improve performance of ColorConverOp for default destinations In-Reply-To: <5106F32A.5020807@oracle.com> References: <50ED61B6.20207@oracle.com> <50F7217F.7080108@oracle.com> <51064784.5030906@oracle.com> <5106F32A.5020807@oracle.com> Message-ID: <510BE235.20405@oracle.com> Hello Phil, please take yet another look at updated webrev: http://cr.openjdk.java.net/~bae/8005530/webrev.02/ Summary of changes: - LCMS.c: unused native method getTagSize() was removed. - mapfiles for lcms library are updated accordingly to changes in native methods of LCMS (affects new and old build systems, is visible on solaris) Thanks, Andrew On 1/29/2013 1:52 AM, Phil Race wrote: > This is all fine by me. > > -phil. > > On 1/28/2013 1:40 AM, Andrew Brygin wrote: >> Hello Phil, >> >> I have updated the fix according to your comment: >> >> http://cr.openjdk.java.net/~bae/8005530/webrev.01/ >> >> Beside this, I have included some improvements related to >> access to profile header (which is quite important in case >> of decoding jpeg images with embedded color profile), >> and to raster processing. >> New benchmark to estimate the performance of image >> decoding was also added to the fix. >> >> Please take a look to a comparison of performance level >> below. >> >> Regarding to the change in build files: I have verified that >> it works for both old and new build systems. I am pretty >> sure that the change is safe (the HIGHEST level of optimization >> is already used for other libraries in jdk). >> >> Would you like to see the change in build systems as a >> separate fix? >> >> Thanks, >> Andrew >> >> ====================================================================== >> Options common across all tests: >> cmm.colorconv.ccop.ccopOptions.content=photo >> cmm.colorconv.ccop.ccopOptions.srcType=BYTE_3BYTE_BGR >> cmm.colorconv.embed.embedOptions.Images=MEDIUM >> cmm.opts.profiles=1001 >> >> cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: >> >> OpenJDK Baseline: 0.008438818 (var=18.29%) (100.0%) >> *************************************** | >> ****************************************| >> ****************************************| >> OpenJDK Fix: 0.012336448 (var=7.36%) (146.19%) >> ****************************************|****************** >> ****************************************|***************** >> ****************************************|**************** >> cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: >> >> OpenJDK Baseline: 0.900596556 (var=2.93%) (100.0%) >> ******************************************************| >> ***************************************************** | >> ******************************************************| >> OpenJDK Fix: 0.193663771 (var=7.52%) (110.1%) >> ******************************************************|***** >> ******************************************************|** >> ******************************************************|***** >> cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: >> >> OpenJDK Baseline: 0.009548438 (var=16.26%) (100.0%) >> ***********************************************| >> ***********************************************| >> ********************************************* | >> OpenJDK Fix: 0.011871784 (var=7.76%) (124.33%) >> ***********************************************|************ >> ***********************************************|*********** >> ***********************************************|******** >> cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: >> >> OpenJDK Baseline: 0.927800441 (var=7.74%) (100.0%) >> ****************************************************| >> ****************************************************| >> ****************************************************| >> OpenJDK Fix: 0.247631935 (var=12.63%) (110.92%) >> ****************************************************|***** >> ****************************************************|***** >> ****************************************************|***** >> cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: >> >> OpenJDK Baseline: 0.171872303 (var=13.62%) (100.0%) >> ******************************************| >> ******************************************| >> ******************************************| >> OpenJDK Fix: 0.238933601 (var=3.17%) (139.02%) >> ******************************************|**************** >> ******************************************|**************** >> ******************************************|**************** >> cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: >> >> OpenJDK Baseline: 0.615214994 (var=7.92%) (100.0%) >> ******************************| >> ******************************| >> ******************************| >> OpenJDK Fix: 0.001296456 (var=2.15%) (195.98%) >> ******************************|***************************** >> ******************************|**************************** >> ******************************|***************************** >> cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: >> >> OpenJDK Baseline: 0.065811677 (var=6.25%) (100.0%) >> ****************| >> ****************| >> ****************| >> OpenJDK Fix: 0.236734693 (var=7.65%) (359.72%) >> ****************|***************************************** >> ****************|****************************************** >> ****************|****************************************** >> cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: >> >> OpenJDK Baseline: 0.763357432 (var=1.53%) (100.0%) >> ********| >> ********| >> ********| >> OpenJDK Fix: 0.001278227 (var=3.47%) (724.88%) >> ********|************************************************** >> ********|************************************************* >> ********|************************************************** >> cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: >> >> OpenJDK Baseline: 0.110134436 (var=1.92%) (100.0%) >> ***************************| >> ***************************| >> ***************************| >> OpenJDK Fix: 0.234074823 (var=4.62%) (212.54%) >> ***************************|****************************** >> ***************************|******************************* >> ***************************|****************************** >> cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: >> >> OpenJDK Baseline: 0.391746749 (var=16.2%) (100.0%) >> ****************| >> ****************| >> *************** | >> OpenJDK Fix: 0.001300390 (var=2.29%) (383.4%) >> ****************|******************************************* >> ****************|******************************************* >> ****************|****************************************** >> cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: >> >> OpenJDK Baseline: 0.110379746 (var=1.38%) (100.0%) >> ***************************| >> ***************************| >> ***************************| >> OpenJDK Fix: 0.238619309 (var=3.32%) (216.18%) >> ***************************|****************************** >> ***************************|****************************** >> ***************************|******************************* >> cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: >> >> OpenJDK Baseline: 0.846569883 (var=10.33%) (100.0%) >> *************| >> *************| >> *************| >> OpenJDK Fix: 0.001290600 (var=2.88%) (453.39%) >> *************|********************************************* >> *************|********************************************** >> *************|********************************************* >> cmm.colorconv.embed.embd_img_read: >> OpenJDK Baseline: 0.299874002 (var=7.04%) (100.0%) >> ************| >> ************| >> ************| >> OpenJDK Fix: 0.003114456 (var=9.07%) (494.37%) >> ************|********************************************* >> ************|********************************************** >> ************|********************************************** >> cmm.profiles.getHeader: >> OpenJDK Baseline: 136.4378577 (var=4.34%) (100.0%) >> *| >> *| >> *| >> OpenJDK Fix: 6858.467330 (var=1.36%) (5026.81%) >> *|********************************************************** >> *|********************************************************** >> *|********************************************************** >> cmm.profiles.getNumComponents: >> OpenJDK Baseline: 135.4737465 (var=2.49%) (100.0%) >> *| >> *| >> *| >> OpenJDK Fix: 6903.416838 (var=4.1%) (5095.76%) >> *|********************************************************* >> *|******************************************************** >> *|******************************************************** >> >> Summary: >> OpenJDK Baseline: >> Number of tests: 15 >> Overall average: 18.159329310271605 >> Best spread: 1.38% variance >> Worst spread: 18.29% variance >> (Basis for results comparison) >> >> OpenJDK Fix: >> Number of tests: 15 >> Overall average: 917.5243389674637 >> Best spread: 1.36% variance >> Worst spread: 12.63% variance >> Comparison to basis: >> Best result: 5095.76% of basis >> Worst result: 110.1% of basis >> Number of wins: 15 >> Number of ties: 0 >> Number of losses: 0 >> >> >> On 1/17/2013 1:54 AM, Phil Race wrote: >>> The variables >>> 154 ShortComponentRaster shortRaster; >>> 155 IntegerComponentRaster intRaster; >>> 156 ByteComponentRaster byteRaster; >>> >>> are each used only in a localised few lines of code, >>> can we move them to the block where they are used so >>> that their scope is limited to that ? I don't know for a fact >>> but I can imagine that the VM can then skip allocating stack for them >>> until you enter that block which actually needs them. >>> >>> As you note,this takes into account old and new builds in the >>> makefile changes >>> Have you tested both ? >>> And unless you are 100% confident in this [minimal] change >>> you should get sign off from the build group as they've recently >>> requested. >>> >>> You should add "noreg-perf" as a label in the JIRA >>> >>> -phil. >>> >>> On 1/9/2013 4:25 AM, Andrew Brygin wrote: >>>> Hello Jennifer and Phil, >>>> >>>> could you please review a fix for CR 8005530? >>>> >>>> CR: http://bugs.sun.com/view_bug.do?bug_id=8005530 >>>> Webrev:http://cr.openjdk.java.net/~bae/8005530/webrev.00/ >>>> >>>> This fix improves performance of ColorConvertOp.filter() >>>> operation in case of lcms. The fix can be divided into >>>> three separate changes: >>>> >>>> * provide support for custom component images in >>>> LCMSImageLayout. >>>> This change affects the case of conversion to default >>>> destination. >>>> >>>> * provide a way to process whole image, instead of >>>> scan-by-scan processing, if both source and >>>> destination images do not contain padding samples >>>> (i.e. next scan starts immediately after previous). >>>> >>>> * increase optimization level for lcms library from >>>> LOW to HIGHEST. This change affects both new and >>>> standard build systems. >>>> >>>> A benchmark comparison below illustrates the increase >>>> of performance: >>>> >>>> Options common across all tests: >>>> testname=cmm.colorconv.ccop.op_img >>>> cmm.colorconv.ccop.ccopOptions.srcType=BYTE_3BYTE_BGR >>>> cmm.colorconv.ccop.ccopOptions.content=photo >>>> cmm.opts.profiles=1001 >>>> >>>> cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: >>>> >>>> OpenJDK Baseline: 0.152008134 (var=1.02%) (100.0%) >>>> *************************************| >>>> *************************************| >>>> *************************************| >>>> OpenJDK Fix: 0.245116358 (var=2.0%) (161.25%) >>>> *************************************|********************** >>>> *************************************|********************** >>>> *************************************|********************* >>>> cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: >>>> >>>> OpenJDK Baseline: 0.914826498 (var=0.41%) (100.0%) >>>> ***************************| >>>> ***************************| >>>> ***************************| >>>> OpenJDK Fix: 0.001310043 (var=2.24%) (221.48%) >>>> ***************************|******************************** >>>> ***************************|******************************** >>>> ***************************|******************************** >>>> cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: >>>> >>>> OpenJDK Baseline: 0.060737151 (var=1.57%) (100.0%) >>>> ***************| >>>> ***************| >>>> ***************| >>>> OpenJDK Fix: 0.242736486 (var=1.53%) (399.65%) >>>> ***************|******************************************* >>>> ***************|******************************************** >>>> ***************|******************************************** >>>> cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: >>>> >>>> OpenJDK Baseline: 0.559251559 (var=0.7%) (100.0%) >>>> *******| >>>> *******| >>>> *******| >>>> OpenJDK Fix: 0.001306904 (var=1.05%) (838.16%) >>>> *******|*************************************************** >>>> *******|**************************************************** >>>> *******|**************************************************** >>>> >>>> Summary: >>>> OpenJDK Baseline: >>>> Number of tests: 4 >>>> Overall average: 0.053373173444166644 >>>> Best spread: 0.41% variance >>>> Worst spread: 1.57% variance >>>> (Basis for results comparison) >>>> >>>> OpenJDK Fix: >>>> Number of tests: 4 >>>> Overall average: 0.12261744826137347 >>>> Best spread: 1.05% variance >>>> Worst spread: 2.24% variance >>>> Comparison to basis: >>>> Best result: 838.16% of basis >>>> Worst result: 161.25% of basis >>>> Number of wins: 4 >>>> Number of ties: 0 >>>> Number of losses: 0 >>>> >>>> Thanks, >>>> Andrew >>>> >>> >> > From andrew.brygin at oracle.com Fri Feb 1 16:07:59 2013 From: andrew.brygin at oracle.com (andrew.brygin at oracle.com) Date: Fri, 01 Feb 2013 16:07:59 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8004801: The image of BufferedImage.TYPE_INT_ARGB is blank. Message-ID: <20130201160843.5781747757@hg.openjdk.java.net> Changeset: e63e7ee18412 Author: bae Date: 2013-02-01 20:06 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e63e7ee18412 8004801: The image of BufferedImage.TYPE_INT_ARGB is blank. Reviewed-by: prr ! src/share/native/sun/awt/image/awt_parseImage.c ! src/solaris/native/sun/awt/awt_Mlib.c ! src/solaris/native/sun/awt/awt_Mlib.h ! src/windows/native/sun/windows/awt_Mlib.cpp ! src/windows/native/sun/windows/awt_Mlib.h + test/java/awt/image/LookupOp/IntImageReverseTest.java From sergey.bylokhov at oracle.com Mon Feb 4 15:53:48 2013 From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com) Date: Mon, 04 Feb 2013 15:53:48 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8004821: Graphics2D.drawPolygon() fails with IllegalPathStateException Message-ID: <20130204155430.9A2BC477E7@hg.openjdk.java.net> Changeset: 1df2944db538 Author: serb Date: 2013-02-04 19:50 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1df2944db538 8004821: Graphics2D.drawPolygon() fails with IllegalPathStateException Reviewed-by: prr, flar ! src/share/classes/sun/java2d/pipe/PixelToShapeConverter.java + test/sun/java2d/pipe/Test8004821.java From jennifer.godinez at oracle.com Mon Feb 4 20:09:33 2013 From: jennifer.godinez at oracle.com (jennifer.godinez at oracle.com) Date: Mon, 04 Feb 2013 20:09:33 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8005052: [parfait] #416 X11SurfaceData.c UNINITIALISED OR MISSING RETURN VALUE; ... Message-ID: <20130204201012.D599F477F9@hg.openjdk.java.net> Changeset: 8fc3e4015b09 Author: jgodinez Date: 2013-02-04 12:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/8fc3e4015b09 8005052: [parfait] #416 X11SurfaceData.c UNINITIALISED OR MISSING RETURN VALUE 8005054: [parfait] #417 X11SurfaceData.c UNINITIALISED OR MISSING RETURN VALUE Reviewed-by: prr, vadim Contributed-by: jia-hong.chen at oracle.com ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c From jennifer.godinez at oracle.com Wed Feb 6 22:45:32 2013 From: jennifer.godinez at oracle.com (jennifer.godinez at oracle.com) Date: Wed, 06 Feb 2013 22:45:32 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8005194: [parfait] #353 sun/awt/image/jpeg/imageioJPEG.c Memory leak of pointer 'scale' allocated with calloc() Message-ID: <20130206224623.BCD46478A2@hg.openjdk.java.net> Changeset: 37719b174e87 Author: jgodinez Date: 2013-02-06 14:45 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/37719b174e87 8005194: [parfait] #353 sun/awt/image/jpeg/imageioJPEG.c Memory leak of pointer 'scale' allocated with calloc() Reviewed-by: prr, vadim Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c From anton.litvinov at oracle.com Fri Feb 8 16:09:39 2013 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Fri, 08 Feb 2013 20:09:39 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users Message-ID: <51152343.8060303@oracle.com> Hello, Please review the following fix for a bug. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007642 Webrev: http://cr.openjdk.java.net/~alitvinov/8007642/webrev.00 The bug consists in the fact that Java cross-platform Page Setup and Print dialogs do not always list all media sizes supported by a printer. The fix is based on addition of dynamic creation of new media names of the type "sun.print.Win32MediaSize" based on paper names received from Windows API function with corresponding media sizes of the type "javax.print.attribute.standard.MediaSize" for the case, when the printer's media size name, which is being analyzed in "sun.print.Win32PrintService.initMedia" method, is not added to the final list of media sizes supported by the printer because of an already existing duplicate in that list. In such a case the printer's paper size matches with one of the media sizes registered in JDK, while the paper size ID does not match with any ID known to JDK. Also the code in "Win32PrintService.findWin32Media" method was altered to allow three cases from "switch" block to work as expected, because currently they never match with "dmIndex" value, since it is always less then "dmPaperToPrintService.length" under "if" statement. Thank you, Anton From jennifer.godinez at oracle.com Fri Feb 8 19:26:21 2013 From: jennifer.godinez at oracle.com (jennifer.godinez at oracle.com) Date: Fri, 08 Feb 2013 19:26:21 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8005129: [parfait] #1122 - #1130 native/sun/awt/medialib/mlib_Image*.c Memory leak of pointer 'k' allocated with mlib_malloc Message-ID: <20130208192711.CC56647957@hg.openjdk.java.net> Changeset: ad49012d10a1 Author: jgodinez Date: 2013-02-08 11:25 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ad49012d10a1 8005129: [parfait] #1122 - #1130 native/sun/awt/medialib/mlib_Image*.c Memory leak of pointer 'k' allocated with mlib_malloc Reviewed-by: prr, vadim Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/awt/medialib/mlib_ImageConv.h ! src/share/native/sun/awt/medialib/mlib_ImageConvMxN_ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_16ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_16nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_32nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_8ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_8nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_u16ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_u16nw.c ! src/share/native/sun/awt/medialib/mlib_ImageCreate.c ! src/share/native/sun/awt/medialib/mlib_c_ImageConv.h From jennifer.godinez at oracle.com Fri Feb 8 19:36:47 2013 From: jennifer.godinez at oracle.com (jennifer.godinez at oracle.com) Date: Fri, 08 Feb 2013 19:36:47 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8005261: [parfait] #415 sun/java2d/opengl/GLXSurfaceData.c Memory leak of pointer 'glxsdo' allocated with malloc Message-ID: <20130208193658.972FC47959@hg.openjdk.java.net> Changeset: 1ea9feb6d8c5 Author: jgodinez Date: 2013-02-08 11:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1ea9feb6d8c5 8005261: [parfait] #415 sun/java2d/opengl/GLXSurfaceData.c Memory leak of pointer 'glxsdo' allocated with malloc Reviewed-by: prr, vadim Contributed-by: jia-hong.chen at oracle.com ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c From joe.darcy at oracle.com Sat Feb 9 00:11:55 2013 From: joe.darcy at oracle.com (Joseph Darcy) Date: Fri, 08 Feb 2013 16:11:55 -0800 Subject: [OpenJDK 2D-Dev] 2D-related types that are candidates to be FunctionalInterfaces in JDK 8 Message-ID: <5115944B.9040206@oracle.com> Hello, As part of Project Lambda, a FunctionalInterface annotation type was added to the platform to mark interfaces that are intended to be used in lambda expressions. I've sent out a code review request to add this annotation to types in the core-libs area [1] and have just pushed the changeset into TL [2]. To assist the 2D team in adding analogous annotations to your types, the list of candidate types in for 2D-related classes in java.* and javax.* is given below. I recommend sub-tasks of JDK-8005297 "Add FunctionalInterface support to the platform" be used to track the work of adding @FunctionalInterface annotations to 2D types In terms of how the annotation should be used, the benefit of the annotation is that is clearly documents the type is intended to be used for lambda expressions and is unlikely to evolve such that is cannot be used with lambda expressions. To a first approximation, if a candidate type today is commonly created using anonymous inner classes, it is reasonable to add the functionalInterface annotation. Note that the compiler will allow any type meeting the structural requirements of a functional interface to be used in a lambda expression; the annotation just provides documentation of intent. Having misplaced my 2D vs AWT vs Swing decoder ring, consideration of these 2D types was previously sent to other aliases [3] [4]. Thanks, -Joe [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-February/014292.html [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/522fb3867a3a [3] http://mail.openjdk.java.net/pipermail/awt-dev/2013-February/004213.html [4] http://mail.openjdk.java.net/pipermail/swing-dev/2013-February/002535.html -=-=-=-=- jdk/src/share/classes/java/awt/Stroke.java:58: Note: Candidate functional interface public interface Stroke { ^ jdk/src/share/classes/java/awt/image/TileObserver.java:39: Note: Candidate functional interface public interface TileObserver { jdk/src/share/classes/java/awt/image/ImageObserver.java:40: Note: Candidate functional interface public interface ImageObserver { ^ jdk/src/share/classes/java/awt/image/renderable/RenderedImageFactory.java:47: Note: Candidate functional interface public interface RenderedImageFactory { ^ jdk/src/share/classes/java/awt/image/TileObserver.java:39: Note: Candidate functional interface public interface TileObserver { jdk/src/share/classes/java/awt/print/Printable.java:105: Note: Candidate functional interface public interface Printable { ^ jdk/src/share/classes/java/awt/PrintGraphics.java:33: Note: Candidate functional interface public interface PrintGraphics { ^ jdk/src/share/classes/javax/print/FlavorException.java:39: Note: Candidate functional interface public interface FlavorException { ^ jdk/src/share/classes/javax/print/event/PrintServiceAttributeListener.java:37: Note: Candidate functional interface public interface PrintServiceAttributeListener { ^ jdk/src/share/classes/javax/print/event/PrintJobAttributeListener.java:34: Note: Candidate functional interface public interface PrintJobAttributeListener { ^ jdk/src/share/classes/javax/imageio/IIOParamController.java:99: Note: Candidate functional interface public interface IIOParamController { ^ jdk/src/share/classes/javax/imageio/event/IIOWriteWarningListener.java:46: Note: Candidate functional interface public interface IIOWriteWarningListener extends EventListener { ^ jdk/src/share/classes/javax/imageio/event/IIOReadWarningListener.java:46: Note: Candidate functional interface public interface IIOReadWarningListener extends EventListener { ^ jdk/src/share/classes/javax/imageio/metadata/IIOMetadataController.java:67: Note: Candidate functional interface public interface IIOMetadataController { ^ jdk/src/share/classes/javax/imageio/spi/ServiceRegistry.java:464: Note: Candidate functional interface public interface Filter { From philip.race at oracle.com Mon Feb 11 18:10:11 2013 From: philip.race at oracle.com (Phil Race) Date: Mon, 11 Feb 2013 10:10:11 -0800 Subject: [OpenJDK 2D-Dev] [8] request fro review: 8005530: [lcms] Improve performance of ColorConverOp for default destinations In-Reply-To: <510BE235.20405@oracle.com> References: <50ED61B6.20207@oracle.com> <50F7217F.7080108@oracle.com> <51064784.5030906@oracle.com> <5106F32A.5020807@oracle.com> <510BE235.20405@oracle.com> Message-ID: <51193403.7070702@oracle.com> Sounds good. -phil. On 2/1/2013 7:41 AM, Andrew Brygin wrote: > Hello Phil, > > please take yet another look at updated webrev: > > http://cr.openjdk.java.net/~bae/8005530/webrev.02/ > > Summary of changes: > - LCMS.c: unused native method getTagSize() was removed. > > - mapfiles for lcms library are updated accordingly to changes in > native methods of LCMS > (affects new and old build systems, is visible on solaris) > > Thanks, > Andrew > > On 1/29/2013 1:52 AM, Phil Race wrote: >> This is all fine by me. >> >> -phil. >> >> On 1/28/2013 1:40 AM, Andrew Brygin wrote: >>> Hello Phil, >>> >>> I have updated the fix according to your comment: >>> >>> http://cr.openjdk.java.net/~bae/8005530/webrev.01/ >>> >>> Beside this, I have included some improvements related to >>> access to profile header (which is quite important in case >>> of decoding jpeg images with embedded color profile), >>> and to raster processing. >>> New benchmark to estimate the performance of image >>> decoding was also added to the fix. >>> >>> Please take a look to a comparison of performance level >>> below. >>> >>> Regarding to the change in build files: I have verified that >>> it works for both old and new build systems. I am pretty >>> sure that the change is safe (the HIGHEST level of optimization >>> is already used for other libraries in jdk). >>> >>> Would you like to see the change in build systems as a >>> separate fix? >>> >>> Thanks, >>> Andrew >>> >>> ====================================================================== >>> Options common across all tests: >>> cmm.colorconv.ccop.ccopOptions.content=photo >>> cmm.colorconv.ccop.ccopOptions.srcType=BYTE_3BYTE_BGR >>> cmm.colorconv.embed.embedOptions.Images=MEDIUM >>> cmm.opts.profiles=1001 >>> >>> cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: >>> >>> OpenJDK Baseline: 0.008438818 (var=18.29%) (100.0%) >>> *************************************** | >>> ****************************************| >>> ****************************************| >>> OpenJDK Fix: 0.012336448 (var=7.36%) (146.19%) >>> ****************************************|****************** >>> ****************************************|***************** >>> ****************************************|**************** >>> cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: >>> >>> OpenJDK Baseline: 0.900596556 (var=2.93%) (100.0%) >>> ******************************************************| >>> ***************************************************** | >>> ******************************************************| >>> OpenJDK Fix: 0.193663771 (var=7.52%) (110.1%) >>> ******************************************************|***** >>> ******************************************************|** >>> ******************************************************|***** >>> cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: >>> >>> OpenJDK Baseline: 0.009548438 (var=16.26%) (100.0%) >>> ***********************************************| >>> ***********************************************| >>> ********************************************* | >>> OpenJDK Fix: 0.011871784 (var=7.76%) (124.33%) >>> ***********************************************|************ >>> ***********************************************|*********** >>> ***********************************************|******** >>> cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: >>> >>> OpenJDK Baseline: 0.927800441 (var=7.74%) (100.0%) >>> ****************************************************| >>> ****************************************************| >>> ****************************************************| >>> OpenJDK Fix: 0.247631935 (var=12.63%) (110.92%) >>> ****************************************************|***** >>> ****************************************************|***** >>> ****************************************************|***** >>> cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: >>> >>> OpenJDK Baseline: 0.171872303 (var=13.62%) (100.0%) >>> ******************************************| >>> ******************************************| >>> ******************************************| >>> OpenJDK Fix: 0.238933601 (var=3.17%) (139.02%) >>> ******************************************|**************** >>> ******************************************|**************** >>> ******************************************|**************** >>> cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: >>> >>> OpenJDK Baseline: 0.615214994 (var=7.92%) (100.0%) >>> ******************************| >>> ******************************| >>> ******************************| >>> OpenJDK Fix: 0.001296456 (var=2.15%) (195.98%) >>> ******************************|***************************** >>> ******************************|**************************** >>> ******************************|***************************** >>> cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: >>> >>> OpenJDK Baseline: 0.065811677 (var=6.25%) (100.0%) >>> ****************| >>> ****************| >>> ****************| >>> OpenJDK Fix: 0.236734693 (var=7.65%) (359.72%) >>> ****************|***************************************** >>> ****************|****************************************** >>> ****************|****************************************** >>> cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: >>> >>> OpenJDK Baseline: 0.763357432 (var=1.53%) (100.0%) >>> ********| >>> ********| >>> ********| >>> OpenJDK Fix: 0.001278227 (var=3.47%) (724.88%) >>> ********|************************************************** >>> ********|************************************************* >>> ********|************************************************** >>> cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: >>> >>> OpenJDK Baseline: 0.110134436 (var=1.92%) (100.0%) >>> ***************************| >>> ***************************| >>> ***************************| >>> OpenJDK Fix: 0.234074823 (var=4.62%) (212.54%) >>> ***************************|****************************** >>> ***************************|******************************* >>> ***************************|****************************** >>> cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: >>> >>> OpenJDK Baseline: 0.391746749 (var=16.2%) (100.0%) >>> ****************| >>> ****************| >>> *************** | >>> OpenJDK Fix: 0.001300390 (var=2.29%) (383.4%) >>> ****************|******************************************* >>> ****************|******************************************* >>> ****************|****************************************** >>> cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: >>> >>> OpenJDK Baseline: 0.110379746 (var=1.38%) (100.0%) >>> ***************************| >>> ***************************| >>> ***************************| >>> OpenJDK Fix: 0.238619309 (var=3.32%) (216.18%) >>> ***************************|****************************** >>> ***************************|****************************** >>> ***************************|******************************* >>> cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: >>> >>> OpenJDK Baseline: 0.846569883 (var=10.33%) (100.0%) >>> *************| >>> *************| >>> *************| >>> OpenJDK Fix: 0.001290600 (var=2.88%) (453.39%) >>> *************|********************************************* >>> *************|********************************************** >>> *************|********************************************* >>> cmm.colorconv.embed.embd_img_read: >>> OpenJDK Baseline: 0.299874002 (var=7.04%) (100.0%) >>> ************| >>> ************| >>> ************| >>> OpenJDK Fix: 0.003114456 (var=9.07%) (494.37%) >>> ************|********************************************* >>> ************|********************************************** >>> ************|********************************************** >>> cmm.profiles.getHeader: >>> OpenJDK Baseline: 136.4378577 (var=4.34%) (100.0%) >>> *| >>> *| >>> *| >>> OpenJDK Fix: 6858.467330 (var=1.36%) (5026.81%) >>> *|********************************************************** >>> *|********************************************************** >>> *|********************************************************** >>> cmm.profiles.getNumComponents: >>> OpenJDK Baseline: 135.4737465 (var=2.49%) (100.0%) >>> *| >>> *| >>> *| >>> OpenJDK Fix: 6903.416838 (var=4.1%) (5095.76%) >>> *|********************************************************* >>> *|******************************************************** >>> *|******************************************************** >>> >>> Summary: >>> OpenJDK Baseline: >>> Number of tests: 15 >>> Overall average: 18.159329310271605 >>> Best spread: 1.38% variance >>> Worst spread: 18.29% variance >>> (Basis for results comparison) >>> >>> OpenJDK Fix: >>> Number of tests: 15 >>> Overall average: 917.5243389674637 >>> Best spread: 1.36% variance >>> Worst spread: 12.63% variance >>> Comparison to basis: >>> Best result: 5095.76% of basis >>> Worst result: 110.1% of basis >>> Number of wins: 15 >>> Number of ties: 0 >>> Number of losses: 0 >>> >>> >>> On 1/17/2013 1:54 AM, Phil Race wrote: >>>> The variables >>>> 154 ShortComponentRaster shortRaster; >>>> 155 IntegerComponentRaster intRaster; >>>> 156 ByteComponentRaster byteRaster; >>>> >>>> are each used only in a localised few lines of code, >>>> can we move them to the block where they are used so >>>> that their scope is limited to that ? I don't know for a fact >>>> but I can imagine that the VM can then skip allocating stack for them >>>> until you enter that block which actually needs them. >>>> >>>> As you note,this takes into account old and new builds in the >>>> makefile changes >>>> Have you tested both ? >>>> And unless you are 100% confident in this [minimal] change >>>> you should get sign off from the build group as they've recently >>>> requested. >>>> >>>> You should add "noreg-perf" as a label in the JIRA >>>> >>>> -phil. >>>> >>>> On 1/9/2013 4:25 AM, Andrew Brygin wrote: >>>>> Hello Jennifer and Phil, >>>>> >>>>> could you please review a fix for CR 8005530? >>>>> >>>>> CR: http://bugs.sun.com/view_bug.do?bug_id=8005530 >>>>> Webrev:http://cr.openjdk.java.net/~bae/8005530/webrev.00/ >>>>> >>>>> This fix improves performance of ColorConvertOp.filter() >>>>> operation in case of lcms. The fix can be divided into >>>>> three separate changes: >>>>> >>>>> * provide support for custom component images in >>>>> LCMSImageLayout. >>>>> This change affects the case of conversion to default >>>>> destination. >>>>> >>>>> * provide a way to process whole image, instead of >>>>> scan-by-scan processing, if both source and >>>>> destination images do not contain padding samples >>>>> (i.e. next scan starts immediately after previous). >>>>> >>>>> * increase optimization level for lcms library from >>>>> LOW to HIGHEST. This change affects both new and >>>>> standard build systems. >>>>> >>>>> A benchmark comparison below illustrates the increase >>>>> of performance: >>>>> >>>>> Options common across all tests: >>>>> testname=cmm.colorconv.ccop.op_img >>>>> cmm.colorconv.ccop.ccopOptions.srcType=BYTE_3BYTE_BGR >>>>> cmm.colorconv.ccop.ccopOptions.content=photo >>>>> cmm.opts.profiles=1001 >>>>> >>>>> cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: >>>>> >>>>> OpenJDK Baseline: 0.152008134 (var=1.02%) (100.0%) >>>>> *************************************| >>>>> *************************************| >>>>> *************************************| >>>>> OpenJDK Fix: 0.245116358 (var=2.0%) (161.25%) >>>>> *************************************|********************** >>>>> *************************************|********************** >>>>> *************************************|********************* >>>>> cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: >>>>> >>>>> OpenJDK Baseline: 0.914826498 (var=0.41%) (100.0%) >>>>> ***************************| >>>>> ***************************| >>>>> ***************************| >>>>> OpenJDK Fix: 0.001310043 (var=2.24%) (221.48%) >>>>> ***************************|******************************** >>>>> ***************************|******************************** >>>>> ***************************|******************************** >>>>> cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: >>>>> >>>>> OpenJDK Baseline: 0.060737151 (var=1.57%) (100.0%) >>>>> ***************| >>>>> ***************| >>>>> ***************| >>>>> OpenJDK Fix: 0.242736486 (var=1.53%) (399.65%) >>>>> ***************|******************************************* >>>>> ***************|******************************************** >>>>> ***************|******************************************** >>>>> cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: >>>>> >>>>> OpenJDK Baseline: 0.559251559 (var=0.7%) (100.0%) >>>>> *******| >>>>> *******| >>>>> *******| >>>>> OpenJDK Fix: 0.001306904 (var=1.05%) (838.16%) >>>>> *******|*************************************************** >>>>> *******|**************************************************** >>>>> *******|**************************************************** >>>>> >>>>> Summary: >>>>> OpenJDK Baseline: >>>>> Number of tests: 4 >>>>> Overall average: 0.053373173444166644 >>>>> Best spread: 0.41% variance >>>>> Worst spread: 1.57% variance >>>>> (Basis for results comparison) >>>>> >>>>> OpenJDK Fix: >>>>> Number of tests: 4 >>>>> Overall average: 0.12261744826137347 >>>>> Best spread: 1.05% variance >>>>> Worst spread: 2.24% variance >>>>> Comparison to basis: >>>>> Best result: 838.16% of basis >>>>> Worst result: 161.25% of basis >>>>> Number of wins: 4 >>>>> Number of ties: 0 >>>>> Number of losses: 0 >>>>> >>>>> Thanks, >>>>> Andrew >>>>> >>>> >>> >> > From philip.race at oracle.com Mon Feb 11 22:21:53 2013 From: philip.race at oracle.com (Phil Race) Date: Mon, 11 Feb 2013 14:21:53 -0800 Subject: [OpenJDK 2D-Dev] 2D-related types that are candidates to be FunctionalInterfaces in JDK 8 In-Reply-To: <5115944B.9040206@oracle.com> References: <5115944B.9040206@oracle.com> Message-ID: <51196F01.2010903@oracle.com> Joe, |What were the criteria used to identify candidates? It looks like its finding a public API interface with a single abstract method. |My sense is that many of the ones identified are not ones that would be appropriate for lambda expressions. The pattern that would seem most useful is where the application will need to iterate over a collection of these in parallel, is that correct ? Some, like Printable, could not be properly used like that. Maybe some of the listeners/observers might match the pattern that there could be multiple of these that might need to be notified but in reality there will usually be zero, sometimes one. Perhaps the most likely candidate I see is ServiceRegistry.Filter|||. | BTW The decoder ring is here :- http://openjdk.java.net/groups/2d/ under "Regarding Java 2D's source code". and there's a link there to additional info here : http://openjdk.java.net/groups/2d/2dawtfiles.html -phil. On 2/8/2013 4:11 PM, Joseph Darcy wrote: > Hello, > > As part of Project Lambda, a FunctionalInterface annotation type was > added to the platform to mark interfaces that are intended to be used > in lambda expressions. I've sent out a code review request to add > this annotation to types in the core-libs area [1] and have just > pushed the changeset into TL [2]. > > To assist the 2D team in adding analogous annotations to your types, > the list of candidate types in for 2D-related classes in java.* and > javax.* is given below. I recommend sub-tasks of JDK-8005297 "Add > FunctionalInterface support to the platform" be used to track the work > of adding @FunctionalInterface annotations to 2D types > > In terms of how the annotation should be used, the benefit of the > annotation is that is clearly documents the type is intended to be > used for lambda expressions and is unlikely to evolve such that is > cannot be used with lambda expressions. > > To a first approximation, if a candidate type today is commonly > created using anonymous inner classes, it is reasonable to add the > functionalInterface annotation. Note that the compiler will allow any > type meeting the structural requirements of a functional interface to be > used in a lambda expression; the annotation just provides > documentation of intent. > > Having misplaced my 2D vs AWT vs Swing decoder ring, consideration of > these 2D types was previously sent to other aliases [3] [4]. > > Thanks, > > -Joe > > [1] > http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-February/014292.html > > > [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/522fb3867a3a > > [3] > http://mail.openjdk.java.net/pipermail/awt-dev/2013-February/004213.html > > [4] > http://mail.openjdk.java.net/pipermail/swing-dev/2013-February/002535.html > > -=-=-=-=- > > jdk/src/share/classes/java/awt/Stroke.java:58: Note: Candidate > functional interface > public interface Stroke { > ^ > > jdk/src/share/classes/java/awt/image/TileObserver.java:39: Note: > Candidate functional interface > public interface TileObserver { > > jdk/src/share/classes/java/awt/image/ImageObserver.java:40: Note: > Candidate functional interface > public interface ImageObserver { > ^ > jdk/src/share/classes/java/awt/image/renderable/RenderedImageFactory.java:47: > Note: Candidate functional interface > public interface RenderedImageFactory { > ^ > jdk/src/share/classes/java/awt/image/TileObserver.java:39: Note: > Candidate functional interface > public interface TileObserver { > > jdk/src/share/classes/java/awt/print/Printable.java:105: Note: > Candidate functional interface > public interface Printable { > ^ > jdk/src/share/classes/java/awt/PrintGraphics.java:33: Note: Candidate > functional interface > public interface PrintGraphics { > ^ > jdk/src/share/classes/javax/print/FlavorException.java:39: Note: > Candidate functional interface > public interface FlavorException { > ^ > jdk/src/share/classes/javax/print/event/PrintServiceAttributeListener.java:37: > Note: Candidate functional interface > public interface PrintServiceAttributeListener { > ^ > jdk/src/share/classes/javax/print/event/PrintJobAttributeListener.java:34: > Note: Candidate functional interface > public interface PrintJobAttributeListener { > ^ > jdk/src/share/classes/javax/imageio/IIOParamController.java:99: Note: > Candidate functional interface > public interface IIOParamController { > ^ > jdk/src/share/classes/javax/imageio/event/IIOWriteWarningListener.java:46: > Note: Candidate functional interface > public interface IIOWriteWarningListener extends EventListener { > ^ > jdk/src/share/classes/javax/imageio/event/IIOReadWarningListener.java:46: > Note: Candidate functional interface > public interface IIOReadWarningListener extends EventListener { > ^ > jdk/src/share/classes/javax/imageio/metadata/IIOMetadataController.java:67: > Note: Candidate functional interface > public interface IIOMetadataController { > ^ > jdk/src/share/classes/javax/imageio/spi/ServiceRegistry.java:464: > Note: Candidate functional interface > public interface Filter { > > From joe.darcy at oracle.com Tue Feb 12 01:01:29 2013 From: joe.darcy at oracle.com (Joseph Darcy) Date: Mon, 11 Feb 2013 17:01:29 -0800 Subject: [OpenJDK 2D-Dev] 2D-related types that are candidates to be FunctionalInterfaces in JDK 8 In-Reply-To: <51196F01.2010903@oracle.com> References: <5115944B.9040206@oracle.com> <51196F01.2010903@oracle.com> Message-ID: <51199469.8050006@oracle.com> Hi Phil, On 2/11/2013 2:21 PM, Phil Race wrote: > Joe, > > |What were the criteria used to identify candidates? > It looks like its finding a public API interface with a > single abstract method. > To a first approximation, that is correct. I ran an annotation processor over the sources in the jdk repo looking for interfaces which meet the structural definition of a functional interface. The summary of that definition is "defines one method," but there are complications in the full definition that are accounted for in the checks I ran. > |My sense is that many of the ones identified are not ones > that would be appropriate for lambda expressions. > > The pattern that would seem most useful is where the application > will need to iterate over a collection of these in parallel, is that > correct ? Not necessary. The guidance I would given is that candidate interfaces that are routinely instantiated today using anonymous classes should be annotated with @FunctionalInterface. Note that a compiler will allow one to use any type that meets the structural definition of a functional interface in a lambda expression; adding the @FunctionalInterface annotation just documents intent. > Some, like Printable, could not be properly used like that. > Maybe some of the listeners/observers might match the pattern > that there could be multiple of these that might need to be notified > but in reality there will usually be zero, sometimes one. > > Perhaps the most likely candidate I see is ServiceRegistry.Filter|||. > | > BTW The decoder ring is here :- http://openjdk.java.net/groups/2d/ > under "Regarding Java 2D's source code". > and there's a link there to additional info here : > http://openjdk.java.net/groups/2d/2dawtfiles.html Thanks for the pointer, -Joe > > -phil. > > > On 2/8/2013 4:11 PM, Joseph Darcy wrote: >> Hello, >> >> As part of Project Lambda, a FunctionalInterface annotation type was >> added to the platform to mark interfaces that are intended to be used >> in lambda expressions. I've sent out a code review request to add >> this annotation to types in the core-libs area [1] and have just >> pushed the changeset into TL [2]. >> >> To assist the 2D team in adding analogous annotations to your types, >> the list of candidate types in for 2D-related classes in java.* and >> javax.* is given below. I recommend sub-tasks of JDK-8005297 "Add >> FunctionalInterface support to the platform" be used to track the >> work of adding @FunctionalInterface annotations to 2D types >> >> In terms of how the annotation should be used, the benefit of the >> annotation is that is clearly documents the type is intended to be >> used for lambda expressions and is unlikely to evolve such that is >> cannot be used with lambda expressions. >> >> To a first approximation, if a candidate type today is commonly >> created using anonymous inner classes, it is reasonable to add the >> functionalInterface annotation. Note that the compiler will allow >> any type meeting the structural requirements of a functional >> interface to be >> used in a lambda expression; the annotation just provides >> documentation of intent. >> >> Having misplaced my 2D vs AWT vs Swing decoder ring, consideration of >> these 2D types was previously sent to other aliases [3] [4]. > >> >> Thanks, >> >> -Joe >> >> [1] >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-February/014292.html >> >> >> [2] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/522fb3867a3a >> >> [3] >> http://mail.openjdk.java.net/pipermail/awt-dev/2013-February/004213.html >> >> [4] >> http://mail.openjdk.java.net/pipermail/swing-dev/2013-February/002535.html >> >> -=-=-=-=- >> >> jdk/src/share/classes/java/awt/Stroke.java:58: Note: Candidate >> functional interface >> public interface Stroke { >> ^ >> >> jdk/src/share/classes/java/awt/image/TileObserver.java:39: Note: >> Candidate functional interface >> public interface TileObserver { >> >> jdk/src/share/classes/java/awt/image/ImageObserver.java:40: Note: >> Candidate functional interface >> public interface ImageObserver { >> ^ >> jdk/src/share/classes/java/awt/image/renderable/RenderedImageFactory.java:47: >> Note: Candidate functional interface >> public interface RenderedImageFactory { >> ^ >> jdk/src/share/classes/java/awt/image/TileObserver.java:39: Note: >> Candidate functional interface >> public interface TileObserver { >> >> jdk/src/share/classes/java/awt/print/Printable.java:105: Note: >> Candidate functional interface >> public interface Printable { >> ^ >> jdk/src/share/classes/java/awt/PrintGraphics.java:33: Note: Candidate >> functional interface >> public interface PrintGraphics { >> ^ >> jdk/src/share/classes/javax/print/FlavorException.java:39: Note: >> Candidate functional interface >> public interface FlavorException { >> ^ >> jdk/src/share/classes/javax/print/event/PrintServiceAttributeListener.java:37: >> Note: Candidate functional interface >> public interface PrintServiceAttributeListener { >> ^ >> jdk/src/share/classes/javax/print/event/PrintJobAttributeListener.java:34: >> Note: Candidate functional interface >> public interface PrintJobAttributeListener { >> ^ >> jdk/src/share/classes/javax/imageio/IIOParamController.java:99: Note: >> Candidate functional interface >> public interface IIOParamController { >> ^ >> jdk/src/share/classes/javax/imageio/event/IIOWriteWarningListener.java:46: >> Note: Candidate functional interface >> public interface IIOWriteWarningListener extends EventListener { >> ^ >> jdk/src/share/classes/javax/imageio/event/IIOReadWarningListener.java:46: >> Note: Candidate functional interface >> public interface IIOReadWarningListener extends EventListener { >> ^ >> jdk/src/share/classes/javax/imageio/metadata/IIOMetadataController.java:67: >> Note: Candidate functional interface >> public interface IIOMetadataController { >> ^ >> jdk/src/share/classes/javax/imageio/spi/ServiceRegistry.java:464: >> Note: Candidate functional interface >> public interface Filter { >> >> > From philip.race at oracle.com Tue Feb 12 17:58:30 2013 From: philip.race at oracle.com (philip.race at oracle.com) Date: Tue, 12 Feb 2013 17:58:30 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8007748: MacOSX build error : cast of type 'SEL' to 'uintptr_t' (aka 'unsigned long') is deprecated; use sel_getName instead Message-ID: <20130212175856.1DE8F479E6@hg.openjdk.java.net> Changeset: 5f0217537435 Author: prr Date: 2013-02-12 09:58 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5f0217537435 8007748: MacOSX build error : cast of type 'SEL' to 'uintptr_t' (aka 'unsigned long') is deprecated; use sel_getName instead Reviewed-by: anthony ! src/macosx/native/jobjc/src/core/native/SEL.m From james.graham at oracle.com Tue Feb 12 22:58:36 2013 From: james.graham at oracle.com (Jim Graham) Date: Tue, 12 Feb 2013 14:58:36 -0800 Subject: [OpenJDK 2D-Dev] 2D-related types that are candidates to be FunctionalInterfaces in JDK 8 In-Reply-To: <51199469.8050006@oracle.com> References: <5115944B.9040206@oracle.com> <51196F01.2010903@oracle.com> <51199469.8050006@oracle.com> Message-ID: <511AC91C.1010603@oracle.com> On 2/11/13 5:01 PM, Joseph Darcy wrote: >> The pattern that would seem most useful is where the application >> will need to iterate over a collection of these in parallel, is that >> correct ? > > Not necessary. The guidance I would given is that candidate interfaces > that are routinely instantiated today using anonymous classes should be > annotated with @FunctionalInterface. Note that a compiler will allow > one to use any type that meets the structural definition of a functional > interface in a lambda expression; adding the @FunctionalInterface > annotation just documents intent. I think ImageObserver might be the closest to that criteria, but most uses would tend to just use an AWT Component since that class already provides a decent default implementation. Stroke is out since that is used to implement a fairly extensive set of calculations (the default BasicStroke implementation takes 3 or 4 classes of a hundred lines of code each to implement [counted from a foggy memory], or the equivalent amount of native code in the non-open JDK). I don't think there could be a simple "inlinable" implementation of that interface. I'll leave the printing and ImageIO interfaces to Phil or others to comment on... ...jim From anton.litvinov at oracle.com Wed Feb 13 16:57:08 2013 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Wed, 13 Feb 2013 20:57:08 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <510A90DF.2060501@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> <50EE1CEB.5080500@oracle.com> <50EFED12.6070700@oracle.com> <50EFFB4F.4090405@oracle.com> <510946F7.3090709@oracle.com> <510A6A54.1080705@oracle.com> <510A90DF.2060501@oracle.com> Message-ID: <511BC5E4.9090302@oracle.com> Hello Anthony, Could you please review the third version of the fix containing modifications discussed with you in the previous letter. Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.02 This version of the fix differs from the previous in the following places: 1. A comment about the place of invocation of the method "XErrorHandlerUtil.init" was added to a documentation block of the method. 2. A code related to XShmAttach function common to the files "src/solaris/native/sun/awt/awt_GraphicsEnv.c" and "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" was extracted into a separate function "TryXShmAttach" declared in "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. 3. All JNI code related to X error handling was implemented as corresponding macros defined in "src/solaris/native/sun/awt/awt_util.h" file. Thank you, Anton On 1/31/2013 7:42 PM, Anton Litvinov wrote: > Hello Anthony, > > Thank you for the review and these remarks. Surely, the comment will > be added. I think that all JNI code related to XShmAttach can be > definitely transferred into a separate dedicated function, which will > be declared in "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. I > will try to wrap all JNU calls connected with XErrorHandler into the > particular "WITH_XERROR_HANDLER", "RESTORE_XERROR_HANDLER" functions > or macros. > > Thank you, > Anton > > On 1/31/2013 4:57 PM, Anthony Petrov wrote: >> Hi Anton, >> >> A couple comments: >> >> 1. src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java >>> 80 private static void init(long display) { >> >> This method is private and isn't called from anywhere in this class >> itself. This looks confusing. Please add a comment stating that this >> method is invoked from native code, and from where exactly. >> >> >> 2. Interesting that we use this machinery to call the XShmAttach() >> from native code twice, and the code looks quite similar in each >> case. Would it be possible to extract the common code in a separate >> function (a-la BOOL TryXShmAttach(...)) to avoid code replication? >> There are other usages as well, so we could also introduce a macro >> (such as the old EXEC_WITH_XERROR_HANDLER but now with other >> arguments) that would minimize all the JNU_ calls required to use >> this machinery. >> >> >> Otherwise the fix looks great. >> >> -- >> best regards, >> Anthony >> >> On 1/30/2013 20:14, Anton Litvinov wrote: >>> Hello Anthony, >>> >>> Could you, please, review a second version of the fix, which is >>> based on an idea of reusing the existing AWT native global error >>> handler from Java 2D native code. >>> >>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.01 >>> >>> The fix consists of the following parts: >>> >>> 1. Migration of all X error handling code from XToolkit to a new >>> XErrorHandlerUtil class for resolution of interdependency between >>> a static initialization block of XToolkit and a block >>> initializing >>> java.awt.GraphicsEnvironment singleton. Such dependency is >>> created >>> by new calls to XToolkit static methods from >>> "src/solaris/native/sun/awt/awt_GraphicsEnv.c", >>> "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" files. >>> 2. Substitution of XToolkit.WITH_XERROR_HANDLER, >>> XToolkit.RESTORE_XERROR_HANDLER ... for corresponding methods, >>> fields of XErrorHandlerUtil class in all places of JDK source >>> code, where they were used. >>> 3. Substitution of all found native X error handlers which are >>> set in >>> native code (awt_GraphicsEnv.c, X11SurfaceData.c, >>> GLXSurfaceData.c) for new synthetic Java error handlers. >>> 4. Removal of X error handling code used by the native error >>> handlers >>> from "solaris/native/sun/awt/awt_util.c" >>> "solaris/native/sun/awt/awt_util.h" files. >>> >>> Thank you, >>> Anton >>> >>> On 1/11/2013 3:45 PM, Anthony Petrov wrote: >>>> I'm not Jim, but as I indicated earlier my opinion is that the >>>> easiest way to fix this is to install the existing J2DXErrHandler() >>>> only once. That is, it is the second option listed by you. Of >>>> course, the J2DXErrHandler needs to be updated as well to detect >>>> whether 2D code wants to use it at the moment or it must simply >>>> delegate to the previous handler (i.e. where the code currently >>>> installs/uninstalls the handler, it must instead set a global >>>> boolean flag or something.) >>>> >>>> While the first option (reusing the existing AWT machinery) is an >>>> interesting idea in general, I think it is complex and would >>>> require too much additional testing and bring an unjustified risk >>>> to the solution for such a basic problem. >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 1/11/2013 14:44, Anton Litvinov wrote: >>>>> Hello Jim, >>>>> >>>>> Thank you very much for the review and provision of a new idea of >>>>> a solution. Elimination of the logic, which sets/unsets >>>>> J2DXErrHandler() for each call "XShmAttach(awt_display, >>>>> &shminfo))" should effectively resolve the issue, but only in case >>>>> if all other native error handlers, which were set by the system >>>>> function "XSetErrorHandler()" in JDK or in any external library, >>>>> observe the rule of relaying of all events, which are not relative >>>>> to them, to the previously saved error handlers. Otherwise an >>>>> error generated during "XShmAttach" function call will not be >>>>> handled by J2DXErrHandler(). >>>>> >>>>> Could you answer the following question. By setting >>>>> J2DXErrHandler() only once and forever do you mean usage of AWT >>>>> global event handler "static int ToolkitErrorHandler(Display * >>>>> dpy, XErrorEvent * event)" from >>>>> "src/solaris/native/sun/xawt/XlibWrapper.c" with Java synthetic >>>>> handlers or creation of another global native error handler with >>>>> J2DXErrHandler as native synthetic handler? >>>>> >>>>> Thank you, >>>>> Anton >>>>> >>>>> On 1/10/2013 5:44 AM, Jim Graham wrote: >>>>>> I think I'd rather see some way to prevent double-adding the >>>>>> handler in the first place as well. Since it is only ever used >>>>>> on errors I also think it is OK to set it once and leave it there >>>>>> forever... >>>>>> >>>>>> ...jim >>>>>> >>>>>> On 1/9/13 8:08 AM, Anthony Petrov wrote: >>>>>>> Hi Anton et al., >>>>>>> >>>>>>> If I read the description of the bug correctly, specifically >>>>>>> this part: >>>>>>> >>>>>>>> The problem occurs, if another thread (for example, GTK thread) is >>>>>>>> doing the same sort of thing concurrently. This can lead to the >>>>>>>> following situation. >>>>>>>> JVM thread: Sets J2DXErrHandler(), saves ANY_PREVIOUS_HANDLER as >>>>>>>> previous GTK thread: Sets some GTK_HANDLER, saves >>>>>>>> J2DXErrHandler() as previous JVM thread: Restores >>>>>>>> ANY_PREVIOUS_HANDLER GTK thread: Restores >>>>>>>> J2DXErrHandler() JVM >>>>>>>> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as previous >>>>>>> >>>>>>> It is obvious that at this final step 2D is in an inconsistent >>>>>>> state. We >>>>>>> don't expect to replace our own error handler (and it shouldn't >>>>>>> have >>>>>>> been there in the first place). >>>>>>> >>>>>>> I realize that the fix you propose works around this problem. >>>>>>> But this >>>>>>> doesn't look like an ideal solution to me. >>>>>>> >>>>>>> BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 error >>>>>>> handler only once and never replace it. All the rest of the >>>>>>> push_handler/pop_handler logic is now located in Java code (see >>>>>>> XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I >>>>>>> believe >>>>>>> that we should somehow share this machinery with the 2D code to >>>>>>> avoid >>>>>>> this sort of problems. Though I'm not sure if this will >>>>>>> eliminate this >>>>>>> exact issue. >>>>>>> >>>>>>> >>>>>>> 2D/AWT folks: any other thoughts? >>>>>>> >>>>>>> -- >>>>>>> best regards, >>>>>>> Anthony >>>>>>> >>>>>>> On 12/29/2012 17:44, Anton Litvinov wrote: >>>>>>>> Hello, >>>>>>>> >>>>>>>> Please review the following fix for a bug. >>>>>>>> >>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >>>>>>>> https://jbs.oracle.com/bugs/browse/JDK-8005607 >>>>>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >>>>>>>> >>>>>>>> The bug consists in a crash which is caused by a stack overflow >>>>>>>> for >>>>>>>> the reason of an infinite recursion in AWT native function >>>>>>>> J2DXErrHandler() under certain circumstances on 32-bit Linux >>>>>>>> OS. The >>>>>>>> fix is based on introduction of the logic, which detects indirect >>>>>>>> recursive calls to J2DXErrHandler() by means of a simple >>>>>>>> counter, to >>>>>>>> J2DXErrHandler() native function. Such a solution requires minimum >>>>>>>> code changes, does not alter the handler's code significantly and >>>>>>>> eliminates this bug. >>>>>>>> >>>>>>>> Adding 2d-dev at openjdk.java.net e-mail alias to the list of >>>>>>>> recipients >>>>>>>> of this letter, because the edited function's name is related >>>>>>>> to Java >>>>>>>> 2D area of JDK, despite of the fact that the edited file is >>>>>>>> located in >>>>>>>> AWT directory. >>>>>>>> >>>>>>>> Thank you, >>>>>>>> Anton -------------- next part -------------- An HTML attachment was scrubbed... URL: From jennifer.godinez at oracle.com Wed Feb 13 17:34:39 2013 From: jennifer.godinez at oracle.com (Jennifer Godinez) Date: Wed, 13 Feb 2013 09:34:39 -0800 Subject: [OpenJDK 2D-Dev] [8] request fro review: 8005530: [lcms] Improve performance of ColorConverOp for default destinations In-Reply-To: <510BE235.20405@oracle.com> References: <50ED61B6.20207@oracle.com> <50F7217F.7080108@oracle.com> <51064784.5030906@oracle.com> <5106F32A.5020807@oracle.com> <510BE235.20405@oracle.com> Message-ID: <511BCEAF.90706@oracle.com> Hi Andrew, Looks good. Jennifer On 2/1/2013 7:41 AM, Andrew Brygin wrote: > Hello Phil, > > please take yet another look at updated webrev: > > http://cr.openjdk.java.net/~bae/8005530/webrev.02/ > > Summary of changes: > - LCMS.c: unused native method getTagSize() was removed. > > - mapfiles for lcms library are updated accordingly to changes in > native methods of LCMS > (affects new and old build systems, is visible on solaris) > > Thanks, > Andrew > > On 1/29/2013 1:52 AM, Phil Race wrote: >> This is all fine by me. >> >> -phil. >> >> On 1/28/2013 1:40 AM, Andrew Brygin wrote: >>> Hello Phil, >>> >>> I have updated the fix according to your comment: >>> >>> http://cr.openjdk.java.net/~bae/8005530/webrev.01/ >>> >>> Beside this, I have included some improvements related to >>> access to profile header (which is quite important in case >>> of decoding jpeg images with embedded color profile), >>> and to raster processing. >>> New benchmark to estimate the performance of image >>> decoding was also added to the fix. >>> >>> Please take a look to a comparison of performance level >>> below. >>> >>> Regarding to the change in build files: I have verified that >>> it works for both old and new build systems. I am pretty >>> sure that the change is safe (the HIGHEST level of optimization >>> is already used for other libraries in jdk). >>> >>> Would you like to see the change in build systems as a >>> separate fix? >>> >>> Thanks, >>> Andrew >>> >>> ====================================================================== >>> Options common across all tests: >>> cmm.colorconv.ccop.ccopOptions.content=photo >>> cmm.colorconv.ccop.ccopOptions.srcType=BYTE_3BYTE_BGR >>> cmm.colorconv.embed.embedOptions.Images=MEDIUM >>> cmm.opts.profiles=1001 >>> >>> cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: >>> >>> OpenJDK Baseline: 0.008438818 (var=18.29%) (100.0%) >>> *************************************** | >>> ****************************************| >>> ****************************************| >>> OpenJDK Fix: 0.012336448 (var=7.36%) (146.19%) >>> ****************************************|****************** >>> ****************************************|***************** >>> ****************************************|**************** >>> cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: >>> >>> OpenJDK Baseline: 0.900596556 (var=2.93%) (100.0%) >>> ******************************************************| >>> ***************************************************** | >>> ******************************************************| >>> OpenJDK Fix: 0.193663771 (var=7.52%) (110.1%) >>> ******************************************************|***** >>> ******************************************************|** >>> ******************************************************|***** >>> cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: >>> >>> OpenJDK Baseline: 0.009548438 (var=16.26%) (100.0%) >>> ***********************************************| >>> ***********************************************| >>> ********************************************* | >>> OpenJDK Fix: 0.011871784 (var=7.76%) (124.33%) >>> ***********************************************|************ >>> ***********************************************|*********** >>> ***********************************************|******** >>> cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: >>> >>> OpenJDK Baseline: 0.927800441 (var=7.74%) (100.0%) >>> ****************************************************| >>> ****************************************************| >>> ****************************************************| >>> OpenJDK Fix: 0.247631935 (var=12.63%) (110.92%) >>> ****************************************************|***** >>> ****************************************************|***** >>> ****************************************************|***** >>> cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: >>> >>> OpenJDK Baseline: 0.171872303 (var=13.62%) (100.0%) >>> ******************************************| >>> ******************************************| >>> ******************************************| >>> OpenJDK Fix: 0.238933601 (var=3.17%) (139.02%) >>> ******************************************|**************** >>> ******************************************|**************** >>> ******************************************|**************** >>> cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: >>> >>> OpenJDK Baseline: 0.615214994 (var=7.92%) (100.0%) >>> ******************************| >>> ******************************| >>> ******************************| >>> OpenJDK Fix: 0.001296456 (var=2.15%) (195.98%) >>> ******************************|***************************** >>> ******************************|**************************** >>> ******************************|***************************** >>> cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: >>> >>> OpenJDK Baseline: 0.065811677 (var=6.25%) (100.0%) >>> ****************| >>> ****************| >>> ****************| >>> OpenJDK Fix: 0.236734693 (var=7.65%) (359.72%) >>> ****************|***************************************** >>> ****************|****************************************** >>> ****************|****************************************** >>> cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: >>> >>> OpenJDK Baseline: 0.763357432 (var=1.53%) (100.0%) >>> ********| >>> ********| >>> ********| >>> OpenJDK Fix: 0.001278227 (var=3.47%) (724.88%) >>> ********|************************************************** >>> ********|************************************************* >>> ********|************************************************** >>> cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: >>> >>> OpenJDK Baseline: 0.110134436 (var=1.92%) (100.0%) >>> ***************************| >>> ***************************| >>> ***************************| >>> OpenJDK Fix: 0.234074823 (var=4.62%) (212.54%) >>> ***************************|****************************** >>> ***************************|******************************* >>> ***************************|****************************** >>> cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: >>> >>> OpenJDK Baseline: 0.391746749 (var=16.2%) (100.0%) >>> ****************| >>> ****************| >>> *************** | >>> OpenJDK Fix: 0.001300390 (var=2.29%) (383.4%) >>> ****************|******************************************* >>> ****************|******************************************* >>> ****************|****************************************** >>> cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: >>> >>> OpenJDK Baseline: 0.110379746 (var=1.38%) (100.0%) >>> ***************************| >>> ***************************| >>> ***************************| >>> OpenJDK Fix: 0.238619309 (var=3.32%) (216.18%) >>> ***************************|****************************** >>> ***************************|****************************** >>> ***************************|******************************* >>> cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: >>> >>> OpenJDK Baseline: 0.846569883 (var=10.33%) (100.0%) >>> *************| >>> *************| >>> *************| >>> OpenJDK Fix: 0.001290600 (var=2.88%) (453.39%) >>> *************|********************************************* >>> *************|********************************************** >>> *************|********************************************* >>> cmm.colorconv.embed.embd_img_read: >>> OpenJDK Baseline: 0.299874002 (var=7.04%) (100.0%) >>> ************| >>> ************| >>> ************| >>> OpenJDK Fix: 0.003114456 (var=9.07%) (494.37%) >>> ************|********************************************* >>> ************|********************************************** >>> ************|********************************************** >>> cmm.profiles.getHeader: >>> OpenJDK Baseline: 136.4378577 (var=4.34%) (100.0%) >>> *| >>> *| >>> *| >>> OpenJDK Fix: 6858.467330 (var=1.36%) (5026.81%) >>> *|********************************************************** >>> *|********************************************************** >>> *|********************************************************** >>> cmm.profiles.getNumComponents: >>> OpenJDK Baseline: 135.4737465 (var=2.49%) (100.0%) >>> *| >>> *| >>> *| >>> OpenJDK Fix: 6903.416838 (var=4.1%) (5095.76%) >>> *|********************************************************* >>> *|******************************************************** >>> *|******************************************************** >>> >>> Summary: >>> OpenJDK Baseline: >>> Number of tests: 15 >>> Overall average: 18.159329310271605 >>> Best spread: 1.38% variance >>> Worst spread: 18.29% variance >>> (Basis for results comparison) >>> >>> OpenJDK Fix: >>> Number of tests: 15 >>> Overall average: 917.5243389674637 >>> Best spread: 1.36% variance >>> Worst spread: 12.63% variance >>> Comparison to basis: >>> Best result: 5095.76% of basis >>> Worst result: 110.1% of basis >>> Number of wins: 15 >>> Number of ties: 0 >>> Number of losses: 0 >>> >>> >>> On 1/17/2013 1:54 AM, Phil Race wrote: >>>> The variables >>>> 154 ShortComponentRaster shortRaster; >>>> 155 IntegerComponentRaster intRaster; >>>> 156 ByteComponentRaster byteRaster; >>>> >>>> are each used only in a localised few lines of code, >>>> can we move them to the block where they are used so >>>> that their scope is limited to that ? I don't know for a fact >>>> but I can imagine that the VM can then skip allocating stack for them >>>> until you enter that block which actually needs them. >>>> >>>> As you note,this takes into account old and new builds in the >>>> makefile changes >>>> Have you tested both ? >>>> And unless you are 100% confident in this [minimal] change >>>> you should get sign off from the build group as they've recently >>>> requested. >>>> >>>> You should add "noreg-perf" as a label in the JIRA >>>> >>>> -phil. >>>> >>>> On 1/9/2013 4:25 AM, Andrew Brygin wrote: >>>>> Hello Jennifer and Phil, >>>>> >>>>> could you please review a fix for CR 8005530? >>>>> >>>>> CR: http://bugs.sun.com/view_bug.do?bug_id=8005530 >>>>> Webrev:http://cr.openjdk.java.net/~bae/8005530/webrev.00/ >>>>> >>>>> This fix improves performance of ColorConvertOp.filter() >>>>> operation in case of lcms. The fix can be divided into >>>>> three separate changes: >>>>> >>>>> * provide support for custom component images in >>>>> LCMSImageLayout. >>>>> This change affects the case of conversion to default >>>>> destination. >>>>> >>>>> * provide a way to process whole image, instead of >>>>> scan-by-scan processing, if both source and >>>>> destination images do not contain padding samples >>>>> (i.e. next scan starts immediately after previous). >>>>> >>>>> * increase optimization level for lcms library from >>>>> LOW to HIGHEST. This change affects both new and >>>>> standard build systems. >>>>> >>>>> A benchmark comparison below illustrates the increase >>>>> of performance: >>>>> >>>>> Options common across all tests: >>>>> testname=cmm.colorconv.ccop.op_img >>>>> cmm.colorconv.ccop.ccopOptions.srcType=BYTE_3BYTE_BGR >>>>> cmm.colorconv.ccop.ccopOptions.content=photo >>>>> cmm.opts.profiles=1001 >>>>> >>>>> cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: >>>>> >>>>> OpenJDK Baseline: 0.152008134 (var=1.02%) (100.0%) >>>>> *************************************| >>>>> *************************************| >>>>> *************************************| >>>>> OpenJDK Fix: 0.245116358 (var=2.0%) (161.25%) >>>>> *************************************|********************** >>>>> *************************************|********************** >>>>> *************************************|********************* >>>>> cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: >>>>> >>>>> OpenJDK Baseline: 0.914826498 (var=0.41%) (100.0%) >>>>> ***************************| >>>>> ***************************| >>>>> ***************************| >>>>> OpenJDK Fix: 0.001310043 (var=2.24%) (221.48%) >>>>> ***************************|******************************** >>>>> ***************************|******************************** >>>>> ***************************|******************************** >>>>> cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: >>>>> >>>>> OpenJDK Baseline: 0.060737151 (var=1.57%) (100.0%) >>>>> ***************| >>>>> ***************| >>>>> ***************| >>>>> OpenJDK Fix: 0.242736486 (var=1.53%) (399.65%) >>>>> ***************|******************************************* >>>>> ***************|******************************************** >>>>> ***************|******************************************** >>>>> cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: >>>>> >>>>> OpenJDK Baseline: 0.559251559 (var=0.7%) (100.0%) >>>>> *******| >>>>> *******| >>>>> *******| >>>>> OpenJDK Fix: 0.001306904 (var=1.05%) (838.16%) >>>>> *******|*************************************************** >>>>> *******|**************************************************** >>>>> *******|**************************************************** >>>>> >>>>> Summary: >>>>> OpenJDK Baseline: >>>>> Number of tests: 4 >>>>> Overall average: 0.053373173444166644 >>>>> Best spread: 0.41% variance >>>>> Worst spread: 1.57% variance >>>>> (Basis for results comparison) >>>>> >>>>> OpenJDK Fix: >>>>> Number of tests: 4 >>>>> Overall average: 0.12261744826137347 >>>>> Best spread: 1.05% variance >>>>> Worst spread: 2.24% variance >>>>> Comparison to basis: >>>>> Best result: 838.16% of basis >>>>> Worst result: 161.25% of basis >>>>> Number of wins: 4 >>>>> Number of ties: 0 >>>>> Number of losses: 0 >>>>> >>>>> Thanks, >>>>> Andrew >>>>> >>>> >>> >> > From lana.steuck at oracle.com Wed Feb 13 22:02:38 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 13 Feb 2013 22:02:38 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d: 8 new changesets Message-ID: <20130213220238.E132947A54@hg.openjdk.java.net> Changeset: 6e296219633d Author: tbell Date: 2013-01-31 13:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/6e296219633d 8006933: Need to use nawk on Solaris to avoid awk limitations Reviewed-by: erikj, dholmes, dsamersoff ! common/makefiles/IdlCompilation.gmk Changeset: 12782ec1da5f Author: ohrstrom Date: 2013-01-31 14:00 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/12782ec1da5f 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! common/autoconf/spec.gmk.in ! common/makefiles/JavaCompilation.gmk ! common/makefiles/javadoc/Javadoc.gmk Changeset: 7e584be2ee58 Author: ohrstrom Date: 2013-02-01 11:22 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/7e584be2ee58 Merge Changeset: 339e4df096a2 Author: erikj Date: 2013-02-04 10:53 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/339e4df096a2 8007093: build-infra: Make should fail if spec is older than configure files Reviewed-by: tbell ! common/makefiles/Main.gmk Changeset: dea045cc48ca Author: erikj Date: 2013-02-04 11:02 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/dea045cc48ca 8007275: build-infra: Create final-images target Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/makefiles/Jprt.gmk Changeset: d3d9ab8ee7b0 Author: erikj Date: 2013-02-05 16:50 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/d3d9ab8ee7b0 8007524: build-infra: Incremental build of tools.jar broken Reviewed-by: tbell ! common/makefiles/JavaCompilation.gmk Changeset: 278af9fc67e7 Author: katleman Date: 2013-02-05 18:54 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/278af9fc67e7 Merge Changeset: 3933eebc659d Author: katleman Date: 2013-02-07 12:32 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/3933eebc659d Added tag jdk8-b76 for changeset 278af9fc67e7 ! .hgtags From lana.steuck at oracle.com Wed Feb 13 22:02:45 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 13 Feb 2013 22:02:45 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxp: 5 new changesets Message-ID: <20130213220302.B374847A57@hg.openjdk.java.net> Changeset: 8f6ca8755f46 Author: ohrstrom Date: 2013-01-31 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/8f6ca8755f46 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/BuildJaxp.gmk Changeset: 0c08593944d0 Author: katleman Date: 2013-02-05 18:54 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/0c08593944d0 Merge Changeset: 02195d0e96b9 Author: katleman Date: 2013-02-07 12:32 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/02195d0e96b9 Added tag jdk8-b76 for changeset 0c08593944d0 ! .hgtags Changeset: f0ad3747b40e Author: emc Date: 2013-02-05 14:56 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/f0ad3747b40e 8007389: Remove uses of _ as identifier in jaxp Reviewed-by: lancea, joehw ! src/javax/xml/validation/SchemaFactoryFinder.java ! src/javax/xml/xpath/XPathFactoryFinder.java Changeset: 573e789c187a Author: lana Date: 2013-02-11 16:12 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/573e789c187a Merge From lana.steuck at oracle.com Wed Feb 13 22:02:53 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 13 Feb 2013 22:02:53 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/langtools: 23 new changesets Message-ID: <20130213220359.D46F347A58@hg.openjdk.java.net> Changeset: 2d6789a725a4 Author: ohrstrom Date: 2013-01-31 14:01 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/2d6789a725a4 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/BuildLangtools.gmk Changeset: e81839b32337 Author: katleman Date: 2013-02-05 18:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/e81839b32337 Merge Changeset: 6fde20398015 Author: katleman Date: 2013-02-07 12:33 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/6fde20398015 Added tag jdk8-b76 for changeset e81839b32337 ! .hgtags Changeset: cbcd9b484759 Author: vromero Date: 2013-01-27 19:38 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/cbcd9b484759 8006944: javac, combo tests should print out the number of threads used Reviewed-by: mcimadamore ! test/tools/javac/lib/JavacTestingAbstractThreadedTest.java Changeset: 950d8195a5a4 Author: jjg Date: 2013-01-30 09:40 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/950d8195a5a4 8007096: DocLint parsing problems with some comments Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! src/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java + test/tools/doclint/EndWithIdentifierTest.java + test/tools/doclint/EndWithIdentifierTest.out + test/tools/doclint/UnfinishedInlineTagTest.java + test/tools/doclint/UnfinishedInlineTagTest.out Changeset: c924291865e5 Author: jjg Date: 2013-01-30 09:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/c924291865e5 8007034: debug printer for javac internals Reviewed-by: mcimadamore + test/tools/javac/lib/DPrinter.java Changeset: 8e4c22acebeb Author: darcy Date: 2013-01-31 12:16 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/8e4c22acebeb 8007313: Remove use of {ContainerFor/ContainedBy} from langtools Reviewed-by: jjg ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java ! test/tools/javac/annotations/typeAnnotations/newlocations/RepeatingTypeAnnotations.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java Changeset: b7cb3d7ade25 Author: lana Date: 2013-01-31 10:23 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/b7cb3d7ade25 Merge Changeset: 7b269e916e06 Author: lana Date: 2013-01-31 14:10 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/7b269e916e06 Merge Changeset: bec996065c45 Author: darcy Date: 2013-01-31 18:58 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/bec996065c45 8007351: Malformed copyright statements in typeAnnotations test directory Reviewed-by: jjg ! test/tools/javac/annotations/typeAnnotations/TargetTypes.java ! test/tools/javac/annotations/typeAnnotations/TypeProcOnly.java ! test/tools/javac/annotations/typeAnnotations/api/AnnotatedArrayOrder.java ! test/tools/javac/annotations/typeAnnotations/api/ArrayCreationTree.java ! test/tools/javac/annotations/typeAnnotations/api/ArrayPositionConsistency.java ! test/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest1.java ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java ! test/tools/javac/annotations/typeAnnotations/classfile/NewTypeArguments.java ! test/tools/javac/annotations/typeAnnotations/classfile/NoTargetAnnotations.java ! test/tools/javac/annotations/typeAnnotations/classfile/TypeCasts.java ! test/tools/javac/annotations/typeAnnotations/classfile/Wildcards.java ! test/tools/javac/annotations/typeAnnotations/failures/target/DotClass.java ! test/tools/javac/annotations/typeAnnotations/newlocations/Varargs.java ! test/tools/javac/annotations/typeAnnotations/packageanno/PackageProcessor.java ! test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/Anno.java ! test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/MyClass.java ! test/tools/javac/annotations/typeAnnotations/packageanno/mypackage/package-info.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ClassExtends.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ClassTypeParam.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Constructors.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ExceptionParameters.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Fields.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/FromSpecification.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodParameters.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodReceivers.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodReturns.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodThrows.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodTypeParam.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MultiCatch.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/NestedTypes.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/NewObjects.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/ReferenceInfoUtil.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/RepeatingTypeAnnotations.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/TypeCasts.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/TypeTests.java Changeset: 3ab64e4293a1 Author: jjg Date: 2013-01-31 19:19 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/3ab64e4293a1 8007329: minor issues in impl class hierarchry for DCTree.* classes Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/tree/DCTree.java Changeset: 3d97a9a7a82b Author: jjg Date: 2013-01-31 19:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/3d97a9a7a82b 8004353: Generated html is wrong for overview.html; content has incorrect css footer class Reviewed-by: jjg Contributed-by: roger.riggs at oracle.com ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java Changeset: 8590c20af3ce Author: jjg Date: 2013-02-01 08:33 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/8590c20af3ce 8007306: DPrinter: improve display of impl-class, internal tag/kind, and external tag/kind Reviewed-by: mcimadamore ! test/tools/javac/lib/DPrinter.java Changeset: 6df931ce1a81 Author: jjg Date: 2013-02-01 08:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/6df931ce1a81 8007305: DPrinter: provide better usage message Reviewed-by: mcimadamore ! test/tools/javac/lib/DPrinter.java Changeset: 0b1c88705568 Author: jjg Date: 2013-02-01 12:01 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/0b1c88705568 8007344: javac may not make tree end positions and/or doc comments available to processors and listeners Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/api/8007344/Test.java Changeset: 55cca2f38ee6 Author: darcy Date: 2013-02-01 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/55cca2f38ee6 8001614: Include annotation type to documented supported-ness Reviewed-by: alanb, jjg, tbell ! make/Makefile-classic ! make/build.properties + src/share/classes/jdk/Supported.java Changeset: 4cc73ec94686 Author: vromero Date: 2013-02-02 21:04 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/4cc73ec94686 8005075: Pool.Method, and Pool.Variable redundant Symbol field should be removed Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java Changeset: a51a8dac0a2f Author: vromero Date: 2013-02-03 02:31 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/a51a8dac0a2f 7199823: javac generates inner class that can't be verified Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/7199823/InnerClassCannotBeVerified.java Changeset: 1690928dc560 Author: jjg Date: 2013-02-04 15:30 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/1690928dc560 8007490: NPE from DocumentationTool.run Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/api/JavadocTool.java ! test/tools/javadoc/api/basic/RunTest.java Changeset: 62d91c13dce2 Author: jjg Date: 2013-02-04 18:14 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/62d91c13dce2 8007492: DocumentationTool cannot locate standard doclet when invoked from JRE Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/api/JavadocTool.java Changeset: 10619513f51a Author: lana Date: 2013-02-04 22:38 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/10619513f51a Merge Changeset: 2480aec9a3f1 Author: jjh Date: 2013-02-05 18:55 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/2480aec9a3f1 8007504: Remove @ignore from tests that no longer need it Reviewed-by: mcimadamore ! test/tools/javac/api/T6306137.java ! test/tools/javac/defaultMethods/TestNoBridgeOnDefaults.java ! test/tools/javac/lambda/LambdaCapture06.java ! test/tools/javac/lambda/LambdaExpr15.java Changeset: 89c664151689 Author: lana Date: 2013-02-11 16:15 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/89c664151689 Merge From lana.steuck at oracle.com Wed Feb 13 22:02:38 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 13 Feb 2013 22:02:38 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/corba: 3 new changesets Message-ID: <20130213220242.D90AD47A55@hg.openjdk.java.net> Changeset: ce106b6b7394 Author: ohrstrom Date: 2013-01-31 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/ce106b6b7394 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/BuildCorba.gmk Changeset: 58be6ca3c060 Author: katleman Date: 2013-02-05 18:54 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/58be6ca3c060 Merge Changeset: 35684a40c584 Author: katleman Date: 2013-02-07 12:32 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/35684a40c584 Added tag jdk8-b76 for changeset 58be6ca3c060 ! .hgtags From lana.steuck at oracle.com Wed Feb 13 22:02:44 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 13 Feb 2013 22:02:44 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxws: 3 new changesets Message-ID: <20130213220255.5D4C447A56@hg.openjdk.java.net> Changeset: 54beebb17494 Author: ohrstrom Date: 2013-01-31 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/54beebb17494 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/BuildJaxws.gmk Changeset: c4853f3f0e89 Author: katleman Date: 2013-02-05 18:54 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/c4853f3f0e89 Merge Changeset: 64dfba1bad16 Author: katleman Date: 2013-02-07 12:33 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/64dfba1bad16 Added tag jdk8-b76 for changeset c4853f3f0e89 ! .hgtags From lana.steuck at oracle.com Wed Feb 13 22:03:19 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 13 Feb 2013 22:03:19 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/hotspot: 74 new changesets Message-ID: <20130213220556.5E67447A59@hg.openjdk.java.net> Changeset: da53cb17186a Author: katleman Date: 2013-02-07 12:32 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/da53cb17186a Added tag jdk8-b76 for changeset 20b605466ccb ! .hgtags Changeset: 6fbe8a57549d Author: amurillo Date: 2013-01-25 03:03 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6fbe8a57549d 8006827: new hotspot build - hs25-b18 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 3c327c2b6782 Author: jmasa Date: 2013-01-03 15:03 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/3c327c2b6782 8004895: NPG: JMapPermCore test failure caused by warnings about missing field Reviewed-by: johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/binaryTreeDictionary.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: ef1e11845e18 Author: jmasa Date: 2013-02-04 12:01 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ef1e11845e18 Merge ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 5daaddd917a1 Author: coleenp Date: 2013-01-23 10:34 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5daaddd917a1 8006040: NPG: on_stack processing wastes space in ConstantPool Summary: Added on_stack bit to flags. Also MetadataMarkOnStack is used for more than JVMTI so had to be moved. Reviewed-by: dholmes, stefank ! src/share/vm/classfile/classLoaderData.cpp + src/share/vm/classfile/metadataOnStackMark.cpp + src/share/vm/classfile/metadataOnStackMark.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp Changeset: 6cf2530f7fd3 Author: minqi Date: 2013-01-24 23:30 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6cf2530f7fd3 8005278: Serviceability Agent: jmap -heap and jstack -m fail Summary: BinaryTreeDictionary is typedef'ed as AFLBinaryTreeDictionary in vmStructs and in SA we still use old name for that. FreeList now is a template based class which is not reflect in SA type library. When SA does calculation of heap for CMS, the former will cause failure to retrieve BinaryTreeDictionary sine the rename. The later will fail wherever it is used in SA. Reviewed-by: dholmes, sla, coleenp Contributed-by: yunda.mly at taobao.com + agent/src/share/classes/sun/jvm/hotspot/memory/AFLBinaryTreeDictionary.java - agent/src/share/classes/sun/jvm/hotspot/memory/BinaryTreeDictionary.java ! agent/src/share/classes/sun/jvm/hotspot/memory/CompactibleFreeListSpace.java ! agent/src/share/classes/sun/jvm/hotspot/memory/FreeList.java ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp Changeset: 8b46b0196eb0 Author: zgu Date: 2013-01-25 10:04 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8b46b0196eb0 8000692: Remove old KERNEL code Summary: Removed depreciated kernel VM source code from hotspot VM Reviewed-by: dholmes, acorn ! make/Makefile ! make/bsd/makefiles/dtrace.make ! make/solaris/Makefile ! make/solaris/makefiles/dtrace.make - make/solaris/makefiles/kernel.make ! make/windows/build.bat ! make/windows/create_obj_files.sh ! make/windows/makefiles/defs.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/vm.make ! src/cpu/x86/vm/assembler_x86.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/prims/jniCheck.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiCodeBlobEvents.hpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExtensions.hpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiImpl.hpp ! src/share/vm/prims/jvmtiRawMonitor.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiTagMap.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/attachListener.hpp Changeset: edd76a5856f7 Author: sspitsyn Date: 2013-01-24 22:13 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/edd76a5856f7 8005128: JSR 292: the mlvm redefineClassInBootstrap test crashes in ConstantPool::compare_entry_to Summary: When constant pool is copied in merge_constant_pools the invokedynamic operands must be copied before. Reviewed-by: coleenp, twisti Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: 4a0dd3799a44 Author: minqi Date: 2013-01-25 04:23 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4a0dd3799a44 Merge Changeset: 8d1fb417a42d Author: minqi Date: 2013-01-25 13:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8d1fb417a42d Merge ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: cf8470eaf7e5 Author: acorn Date: 2013-01-27 21:58 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/cf8470eaf7e5 Merge - agent/src/share/classes/sun/jvm/hotspot/memory/BinaryTreeDictionary.java - make/solaris/makefiles/kernel.make ! src/cpu/x86/vm/assembler_x86.hpp ! src/share/vm/classfile/vmSymbols.hpp Changeset: 16fb9f942703 Author: acorn Date: 2013-01-25 15:06 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/16fb9f942703 6479360: PrintClassHistogram improvements Summary: jcmd GC.class_stats (UnlockDiagnosticVMOptions) Reviewed-by: coleenp, hseigel, sla, acorn Contributed-by: ioi.lam at oracle.com ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.hpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/oops/annotations.cpp ! src/share/vm/oops/annotations.hpp ! src/share/vm/oops/arrayKlass.hpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/oops/methodData.hpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp Changeset: 0d26ce8e9251 Author: acorn Date: 2013-01-28 10:34 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/0d26ce8e9251 Merge - make/solaris/makefiles/kernel.make ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp Changeset: 815957d0203e Author: acorn Date: 2013-01-28 10:55 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/815957d0203e 8004967: Default method cause VerifyError: Illegal use of nonvirtual Summary: Recognize VM generated method in old verifier Reviewed-by: acorn, coleenp Contributed-by: bharadwaj.yadavelli at oracle.com ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h Changeset: 7885e162c30f Author: acorn Date: 2013-01-28 09:33 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/7885e162c30f Merge Changeset: 9be6cde7919d Author: ctornqvi Date: 2013-01-25 10:14 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/9be6cde7919d 8006413: Add utility classes for writing better multiprocess tests in jtreg Summary: Add a few utility classes to test/testlibrary to support multi process testing in jtreg tests. Added a test case for one of the utility classes. Also reviewed by Vitaly Davidovich Reviewed-by: brutisso, dholmes, vlivanov, nloodin, mgerdin + test/testlibrary/OutputAnalyzerTest.java + test/testlibrary/com/oracle/java/testlibrary/JDKToolFinder.java + test/testlibrary/com/oracle/java/testlibrary/OutputAnalyzer.java + test/testlibrary/com/oracle/java/testlibrary/OutputBuffer.java + test/testlibrary/com/oracle/java/testlibrary/ProcessTools.java + test/testlibrary/com/oracle/java/testlibrary/StreamPumper.java Changeset: baf7fac3167e Author: hseigel Date: 2013-02-01 14:14 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/baf7fac3167e 8006298: Specifying malformed JFR options (-XX:+FlightRecorderOptions) outputs non-sensical error Summary: Change error messages for malformed options so the messages are more useful. Reviewed-by: mikael, kvn, nloodin ! src/share/vm/runtime/arguments.cpp Changeset: 4c75576d18d0 Author: hseigel Date: 2013-02-01 13:30 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4c75576d18d0 Merge Changeset: 9bf5f643d1cf Author: sspitsyn Date: 2013-01-31 20:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/9bf5f643d1cf 8006542: JSR 292: the VM_RedefineClasses::append_entry() must support invokedynamic entry kinds Summary: Need a support for invokedynamic entry kinds when new and old constant pools are merged. Reviewed-by: coleenp, twisti Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp Changeset: dc31f560d6e7 Author: sspitsyn Date: 2013-01-31 20:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/dc31f560d6e7 8006546: JSR 292: typos in the ConstantPool::copy_cp_impl() Summary: Simple typos that need to be fixed Reviewed-by: coleenp, twisti Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/oops/constantPool.cpp Changeset: 79c1bb8fce5d Author: sspitsyn Date: 2013-01-31 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/79c1bb8fce5d 8006731: JSR 292: the VM_RedefineClasses::rewrite_cp_refs_in_method() must support invokedynamic Summary: The invokedynamic bytecode ref to a CP entry needs to be checked and fixed as well. Reviewed-by: coleenp, twisti Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: 9a9f870325cf Author: minqi Date: 2013-02-01 10:57 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/9a9f870325cf Merge Changeset: b935589d2807 Author: minqi Date: 2013-02-01 14:42 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b935589d2807 Merge Changeset: 44c5fcd9cb25 Author: iklam Date: 2013-01-24 10:57 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/44c5fcd9cb25 8006280: Need to reorder metadata structures to reduce size (64-bit) Summary: Reordered Klass, InstanceKlass and Method to save 8 bytes each Reviewed-by: coleenp, jiangli Contributed-by: ioi.lam at oracle.com ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.hpp Changeset: 1eae78177059 Author: jiangli Date: 2013-02-01 15:25 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1eae78177059 Merge - make/solaris/makefiles/kernel.make ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.hpp Changeset: dc8ad3fd7050 Author: jiangli Date: 2013-02-01 19:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/dc8ad3fd7050 Merge Changeset: 4102b59539ce Author: ctornqvi Date: 2013-02-01 23:48 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4102b59539ce 8005012: Add WB APIs to better support NMT testing Summary: Add WB API functions to enable better NMT testing Reviewed-by: dholmes, zgu ! src/share/tools/whitebox/sun/hotspot/WhiteBox.java ! src/share/vm/memory/allocation.hpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/services/memBaseline.cpp ! src/share/vm/services/memPtr.cpp ! src/share/vm/services/memPtr.hpp ! src/share/vm/services/memRecorder.cpp ! src/share/vm/services/memRecorder.hpp ! src/share/vm/services/memTrackWorker.cpp ! src/share/vm/services/memTrackWorker.hpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memTracker.hpp Changeset: 4460acf8687b Author: ctornqvi Date: 2013-02-02 07:24 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4460acf8687b Merge Changeset: 9fe95b01ad32 Author: ctornqvi Date: 2013-02-02 08:46 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/9fe95b01ad32 Merge Changeset: 43badbe2717a Author: minqi Date: 2013-01-31 17:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/43badbe2717a 8000973: SA on windows thread inspection is broken Summary: After bug 7161732, On Windows SA could not find correct address of thread_id of OSThread since _thread_id moved to end of the class . The presupposition of the address is following thread handle no longer stands. Fix by adding thread_id field to OSThread and getting the address directly from OSThread. Reviewed-by: nloodin, sspitsyn Contributed-by: yumin.qi at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/amd64/WindbgAMD64Thread.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/x86/WindbgX86Thread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/OSThread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/win32_amd64/Win32AMD64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/win32_x86/Win32X86JavaThreadPDAccess.java Changeset: 65b632b77a97 Author: minqi Date: 2013-02-01 22:41 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/65b632b77a97 Merge Changeset: ff5401ad5635 Author: minqi Date: 2013-02-02 03:51 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ff5401ad5635 Merge Changeset: 879c6de913d6 Author: ctornqvi Date: 2013-02-02 16:34 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/879c6de913d6 8005013: Add NMT tests Summary: Add tests for the Native Memory Tracking feature, includes regression tests for 8005936 and 8004802 Reviewed-by: zgu, coleenp ! test/TEST.ROOT + test/runtime/NMT/AllocTestType.java + test/runtime/NMT/BaselineWithParameter.java + test/runtime/NMT/CommandLineDetail.java + test/runtime/NMT/CommandLineEmptyArgument.java + test/runtime/NMT/CommandLineInvalidArgument.java + test/runtime/NMT/CommandLineSummary.java + test/runtime/NMT/CommandLineTurnOffNMT.java + test/runtime/NMT/JcmdScale.java + test/runtime/NMT/JcmdWithNMTDisabled.java + test/runtime/NMT/PrintNMTStatistics.java + test/runtime/NMT/PrintNMTStatisticsWithNMTDisabled.java + test/runtime/NMT/ShutdownTwice.java + test/runtime/NMT/SummaryAfterShutdown.java + test/runtime/NMT/SummarySanityCheck.java Changeset: a7f9a1195d86 Author: ctornqvi Date: 2013-02-02 20:13 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/a7f9a1195d86 8000363: runtime/7158988/FieldMonitor.java fails with exception Summary: Removed unnecessary shell script in the test. Reviewed-by: coleenp, sla ! test/runtime/7158988/FieldMonitor.java - test/runtime/7158988/TestFieldMonitor.sh Changeset: 8f696cf1a0fb Author: dsamersoff Date: 2013-02-03 22:28 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8f696cf1a0fb 8002048: Protocol to discovery of manageable Java processes on a network Summary: Introduce a protocol to discover manageble Java instances across a network subnet, JDP Reviewed-by: sla, dfuchs ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp Changeset: c4ef3380a70b Author: hseigel Date: 2013-02-03 16:49 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c4ef3380a70b 7197672: There are issues with shared data on windows Summary: On Windows, set rw protection on the CDS file just before removing it. Reviewed-by: dcubed, iklam ! src/share/vm/memory/filemap.cpp Changeset: ce5467120c84 Author: hseigel Date: 2013-02-03 17:12 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ce5467120c84 Merge Changeset: 10d5f25a7c67 Author: hseigel Date: 2013-02-04 08:26 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/10d5f25a7c67 8000968: NPG: UseCompressedKlassPointers asserts with ObjectAlignmentInBytes for > 32G CompressedOops Summary: Pick a base that works for both CompressedOpps alignment and CompressedKlassPtrs alignment. Reviewed-by: kvn, roland ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/runtime/arguments.cpp + test/runtime/8000968/Test8000968.sh Changeset: 24a91505f9d5 Author: emc Date: 2013-02-04 13:05 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/24a91505f9d5 8006949: Update hotspot for MethodParameters format change 8006907: Hotspot should reject classfiles with multiple MethodParameters attributes Summary: Update to Hotspot's processing of MethodParameters attributes in classfiles Reviewed-by: coleenp, jrose ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/prims/jvm.cpp Changeset: 42ea5e1fad75 Author: coleenp Date: 2013-02-04 13:51 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/42ea5e1fad75 Merge Changeset: ab826603e572 Author: simonis Date: 2013-02-04 13:14 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ab826603e572 8007475: Memory stomp with UseMallocOnly Summary: Fix off-by-one error Reviewed-by: coleenp, hseigel ! src/share/vm/classfile/stackMapFrame.hpp + test/runtime/8007475/StackMapFrameTest.java Changeset: a401757763f9 Author: coleenp Date: 2013-02-04 22:59 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/a401757763f9 Merge Changeset: 12285410684f Author: dholmes Date: 2013-02-04 23:53 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/12285410684f 8006508: Wrong frame constructor is called in os_linux_x86.cpp Reviewed-by: dholmes, coleenp Contributed-by: Jeremy Manson ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp Changeset: f3ea1af9207a Author: dholmes Date: 2013-02-05 00:59 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f3ea1af9207a Merge Changeset: 454d7cc622ab Author: dcubed Date: 2013-02-06 15:22 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/454d7cc622ab Merge - agent/src/share/classes/sun/jvm/hotspot/memory/BinaryTreeDictionary.java - make/solaris/makefiles/kernel.make ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp - test/runtime/7158988/TestFieldMonitor.sh Changeset: fcc9e7681d63 Author: vlivanov Date: 2013-02-01 02:50 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/fcc9e7681d63 8006410: allocating without ResourceMark when CompileCommand was specified Reviewed-by: kvn, vlivanov Contributed-by: Igor Ignatyev ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethodData.cpp ! src/share/vm/oops/symbol.cpp Changeset: 60bba1398c51 Author: vlivanov Date: 2013-02-01 03:02 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/60bba1398c51 8005439: no message about inline method if it specifed by CompileCommand Reviewed-by: kvn, vlivanov Contributed-by: Igor Ignatyev ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/parse.hpp Changeset: e4bb0bda20a4 Author: morris Date: 2013-01-25 16:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e4bb0bda20a4 8005811: Turn off TierdCompilation in JDK8 trunk for all platforms Summary: Disable tiered compilation in jdk8 because of CodeCache and performance anomalies Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp Changeset: 76341426b645 Author: drchase Date: 2013-01-25 16:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/76341426b645 8006500: compiler/8004741/Test8004741.java fails intermediately Summary: rewrote the test to be more reliable, add test for invalid size exception Reviewed-by: kvn ! test/compiler/8004741/Test8004741.java Changeset: 9fae07c31641 Author: morris Date: 2013-01-25 16:50 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/9fae07c31641 6518907: cleanup IA64 specific code in Hotspot Summary: removed unused IA64 specific code Reviewed-by: twisti, kvn, dholmes ! agent/src/os/linux/LinuxDebuggerLocal.c ! agent/src/os/linux/libproc.h ! agent/src/os/win32/windbg/sawindbg.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/opto/generateOptoStub.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/vframeArray.cpp Changeset: 37c18711a0df Author: roland Date: 2013-02-04 09:11 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/37c18711a0df 8005114: VM is crashing in ciKlass*ciObjArrayKlass::element_klass() if metaspaces are full Summary: missing test for loaded klass in c1 Reviewed-by: kvn ! src/share/vm/c1/c1_Instruction.cpp Changeset: 39901f2f1abe Author: mikael Date: 2013-02-04 10:28 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/39901f2f1abe 8007403: Incorrect format arguments in adlparse.cpp Reviewed-by: kvn, twisti ! src/share/vm/adlc/adlparse.cpp Changeset: 8bd61471a109 Author: roland Date: 2013-02-04 11:30 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8bd61471a109 8007144: Incremental inlining mistakes some call sites for dead ones and doesn't inline them Summary: wrong detection for dead call sites. Reviewed-by: kvn ! src/share/vm/opto/callGenerator.cpp Changeset: 6a51fc70a15e Author: vlivanov Date: 2013-02-05 08:25 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6a51fc70a15e 8006613: adding reason to made_not_compilable Reviewed-by: kvn, vlivanov Contributed-by: Igor Ignatyev ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/oops/methodData.hpp ! src/share/vm/runtime/deoptimization.cpp Changeset: 4fcf990aa34a Author: drchase Date: 2013-02-06 11:33 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4fcf990aa34a 8006807: C2 crash due to out of bounds array access in Parse::do_multianewarray Summary: check ndimensions before accessing length[i] element Reviewed-by: kvn Contributed-by: volker.simonis at gmail.com ! src/share/vm/opto/parse3.cpp Changeset: d05ff4bf41b3 Author: vlivanov Date: 2013-02-07 12:23 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d05ff4bf41b3 Merge ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/oops/methodData.hpp Changeset: db9981fd3124 Author: jprovino Date: 2013-01-23 13:02 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/db9981fd3124 8005915: Unify SERIALGC and INCLUDE_ALTERNATE_GCS Summary: Rename INCLUDE_ALTERNATE_GCS to INCLUDE_ALL_GCS and replace SERIALGC with INCLUDE_ALL_GCS. Reviewed-by: coleenp, stefank ! make/bsd/makefiles/minimal1.make ! make/excludeSrc.make ! make/linux/makefiles/minimal1.make ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.hpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/share/vm/c1/c1_CodeStubs.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.hpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/shared/allocationStats.cpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/gc_implementation/shared/concurrentGCThread.hpp ! src/share/vm/gc_implementation/shared/gSpaceCounters.cpp ! src/share/vm/gc_implementation/shared/gSpaceCounters.hpp ! src/share/vm/gc_implementation/shared/gcAdaptivePolicyCounters.hpp ! src/share/vm/gc_implementation/shared/hSpaceCounters.hpp ! src/share/vm/gc_implementation/shared/immutableSpace.cpp ! src/share/vm/gc_implementation/shared/isGCActiveMark.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.hpp ! src/share/vm/gc_implementation/shared/mutableSpace.cpp ! src/share/vm/gc_implementation/shared/spaceCounters.cpp ! src/share/vm/gc_implementation/shared/spaceCounters.hpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/freeList.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/generationSpec.cpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/memory/specialized_oop_closures.hpp ! src/share/vm/memory/tenuredGeneration.cpp ! src/share/vm/memory/tenuredGeneration.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/instanceClassLoaderKlass.cpp ! src/share/vm/oops/instanceClassLoaderKlass.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceMirrorKlass.cpp ! src/share/vm/oops/instanceMirrorKlass.hpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/instanceRefKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/klassPS.hpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlass.hpp ! src/share/vm/oops/objArrayKlass.inline.hpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/oops/oop.pcgc.inline.hpp ! src/share/vm/oops/oop.psgc.inline.hpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/precompiled/precompiled.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiEnvBase.hpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals_extension.hpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/classLoadingService.cpp ! src/share/vm/services/classLoadingService.hpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp ! src/share/vm/services/g1MemoryPool.hpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/memReporter.hpp ! src/share/vm/services/memoryPool.cpp ! src/share/vm/services/memoryPool.hpp ! src/share/vm/services/memoryService.cpp ! src/share/vm/services/psMemoryPool.hpp ! src/share/vm/services/runtimeService.cpp ! src/share/vm/utilities/macros.hpp ! src/share/vm/utilities/top.hpp ! src/share/vm/utilities/yieldingWorkgroup.cpp ! src/share/vm/utilities/yieldingWorkgroup.hpp Changeset: 8391fdd36e1f Author: dlong Date: 2013-01-27 01:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8391fdd36e1f Merge ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/heapDumper.cpp Changeset: 3c9bc17b9403 Author: bpittore Date: 2013-02-07 16:05 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/3c9bc17b9403 Merge ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp Changeset: df8462fbe585 Author: vladidan Date: 2013-02-07 20:40 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/df8462fbe585 Merge ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: ec0c4951286c Author: stefank Date: 2013-01-29 10:51 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ec0c4951286c 8004710: NPG: jmap could throw sun.jvm.hotspot.types.WrongTypeException after PermGen removal Summary: When calculating live object regions, make sure that the alignment reserve, at the end of a TLAB, is excluded. Reviewed-by: jmasa, brutisso ! agent/src/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/ThreadLocalAllocBuffer.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/share/vm/runtime/vmStructs.cpp Changeset: 4700e77d44c1 Author: johnc Date: 2013-02-01 13:17 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4700e77d44c1 8006894: G1: Number of marking threads missing from PrintFlagsFinal output Summary: Set ConcGCThreads to the calculated number of marking threads. Reviewed-by: jmasa, ysr ! src/share/vm/gc_implementation/g1/concurrentMark.cpp Changeset: d9058e388631 Author: mikael Date: 2013-02-01 17:21 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d9058e388631 8007257: NPG: metaspace.cpp: Incorrect arguments in calls to err_msg Summary: Fix size checks in assert and corrected some print formats. Also reviewed by vitalyd at gmail.com. Reviewed-by: coleenp, sspitsyn ! src/share/vm/memory/metaspace.cpp Changeset: 256d3f43c177 Author: johnc Date: 2013-01-31 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/256d3f43c177 8005875: G1: Kitchensink fails with ParallelGCThreads=0 Summary: Check that the concurrent marking worker gang exists in ConcurrentMark::print_worker_threads_on(). Changes were also reviewed by Vitaly Davidovich . Reviewed-by: brutisso ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp Changeset: 80518f4ecf32 Author: jmasa Date: 2013-02-04 12:51 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/80518f4ecf32 Merge ! src/share/vm/runtime/vmStructs.cpp Changeset: f2f0cf0f5444 Author: jmasa Date: 2013-02-04 13:26 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f2f0cf0f5444 Merge Changeset: 06fd03af6ce4 Author: johnc Date: 2013-02-04 13:24 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/06fd03af6ce4 8001384: G1: assert(!is_null(v)) failed: narrow oop value can never be zero Summary: Flush any deferred card mark before a Java thread exits. Reviewed-by: brutisso, jmasa ! src/share/vm/runtime/thread.cpp Changeset: 84304a77c4e3 Author: johnc Date: 2013-02-04 19:40 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/84304a77c4e3 Merge Changeset: 95ccff9eee8e Author: jwilhelm Date: 2013-01-28 15:41 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/95ccff9eee8e 6348447: Specifying -XX:OldSize crashes 64-bit VMs Summary: Heap size will be set to allow for OldSize to fit. Also reviewed by vitalyd at gmail.com Reviewed-by: ehelin, jmasa ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp Changeset: f90b9bceb8e5 Author: johnc Date: 2013-02-05 09:13 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f90b9bceb8e5 8005032: G1: Cleanup serial reference processing closures in concurrent marking Summary: Reuse the parallel reference processing oop closures during serial reference processing. Reviewed-by: brutisso ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp Changeset: 50d3b37d5bcd Author: johnc Date: 2013-02-05 22:24 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/50d3b37d5bcd Merge Changeset: 1135141fb97e Author: brutisso Date: 2013-02-08 10:08 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1135141fb97e Merge ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 412d722168bc Author: amurillo Date: 2013-02-08 08:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/412d722168bc Merge - agent/src/share/classes/sun/jvm/hotspot/memory/BinaryTreeDictionary.java - make/solaris/makefiles/kernel.make - test/runtime/7158988/TestFieldMonitor.sh Changeset: cdb46031e718 Author: amurillo Date: 2013-02-08 08:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/cdb46031e718 Added tag hs25-b18 for changeset 412d722168bc ! .hgtags From lana.steuck at oracle.com Wed Feb 13 22:03:46 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 13 Feb 2013 22:03:46 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 42 new changesets Message-ID: <20130213221223.3E11847A5B@hg.openjdk.java.net> Changeset: c5a7ac2a721f Author: ohrstrom Date: 2013-01-31 14:03 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c5a7ac2a721f 8006872: Stop creating four jars with identical content in the new build system. Reviewed-by: erikj ! makefiles/CreateJars.gmk ! makefiles/GensrcSwing.gmk ! makefiles/Setup.gmk Changeset: 35cf77f633c9 Author: tbell Date: 2013-02-01 09:16 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/35cf77f633c9 8006808: mapfile use check in jdk/make/common/shared/Defs-solaris.gmk is throwing 'egrep: syntax error' Summary: Use a valid egrep expression in the non-SPARC case Reviewed-by: dholmes ! make/common/shared/Defs-solaris.gmk Changeset: 5692ebe15321 Author: erikj Date: 2013-02-04 10:58 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5692ebe15321 8007268: build-infra: configure reports Solaris needs gcc for deploy, but logs don't indicate it's used. Reviewed-by: tbell, katleman ! make/common/shared/Sanity.gmk Changeset: 3a2630528661 Author: katleman Date: 2013-02-05 18:54 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3a2630528661 Merge Changeset: 933742f4bb4c Author: katleman Date: 2013-02-07 12:33 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/933742f4bb4c Added tag jdk8-b76 for changeset 3a2630528661 ! .hgtags Changeset: fd61fcc1a5a9 Author: leonidr Date: 2013-01-31 18:25 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/fd61fcc1a5a9 8007006: [macosx] Closing subwindow loses main window menus Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 452deb976c92 Author: ptbrunet Date: 2013-01-31 18:51 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/452deb976c92 7179482: Component.accessibleContext and JComponent.accessibleContext refactoring Reviewed-by: art, anthony, alexsch ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/javax/swing/JComponent.java Changeset: 0b56a169295f Author: pchelko Date: 2013-02-04 13:54 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0b56a169295f 8005405: [macosx] Drag and Drop: wrong animation when dropped outside any drop target. Summary: Changed the calculation of the drag image offset Reviewed-by: serb, kizune ! src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java ! src/macosx/native/sun/awt/CDragSource.m Changeset: 171443b1eb3b Author: kshefov Date: 2013-02-04 16:01 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/171443b1eb3b 7077259: [TEST_BUG] [macosx] Test work correctly only when default L&F is Metal Reviewed-by: serb, alexsch ! test/javax/swing/JSlider/4252173/bug4252173.java ! test/javax/swing/JSpinner/6532833/bug6532833.java ! test/javax/swing/plaf/metal/MetalSliderUI/Test6657026.java Changeset: 0e929be3a9da Author: lana Date: 2013-02-05 11:10 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0e929be3a9da Merge Changeset: a343d280bd8c Author: jfranck Date: 2013-01-29 10:32 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a343d280bd8c 8004698: Implement Core Reflection for Type Annotations Reviewed-by: darcy ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/System.java + src/share/classes/java/lang/reflect/AnnotatedArrayType.java + src/share/classes/java/lang/reflect/AnnotatedParameterizedType.java + src/share/classes/java/lang/reflect/AnnotatedType.java + src/share/classes/java/lang/reflect/AnnotatedTypeVariable.java + src/share/classes/java/lang/reflect/AnnotatedWildcardType.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Method.java ! src/share/classes/java/lang/reflect/ReflectAccess.java ! src/share/classes/java/lang/reflect/TypeVariable.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/reflect/LangReflectAccess.java ! src/share/classes/sun/reflect/ReflectionFactory.java + src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/share/classes/sun/reflect/annotation/AnnotationParser.java + src/share/classes/sun/reflect/annotation/TypeAnnotation.java + src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java ! src/share/javavm/export/jvm.h ! src/share/native/java/lang/Class.c + test/java/lang/annotation/TypeAnnotationReflection.java + test/java/lang/annotation/TypeParamAnnotation.java Changeset: 5097fe015763 Author: jfranck Date: 2013-01-31 10:10 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5097fe015763 8005712: Simplify support for repeating annotations in j.l.r.AnnotatedElement 8004919: AnnotationSupport uses possibly half-constructed AnnotationType instances Summary: Implements the simplified semantics for repeating annotations and removes the incorrect obtaining of an AnnotationType Reviewed-by: darcy, abuckley ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/reflect/AnnotatedElement.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Parameter.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/reflect/annotation/AnnotationSupport.java ! test/java/lang/annotation/repeatingAnnotations/RepeatedUnitTest.java ! test/java/lang/annotation/repeatingAnnotations/subpackage/Containee.java ! test/java/lang/annotation/repeatingAnnotations/subpackage/Container.java ! test/java/lang/annotation/repeatingAnnotations/subpackage/InheritedContainee.java ! test/java/lang/annotation/repeatingAnnotations/subpackage/InheritedContainer.java Changeset: 3f766f58c48a Author: dbuck Date: 2013-01-31 10:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3f766f58c48a 7042126: (alt-rt) HashMap.clone implementation should be re-examined Summary: Test case for cr7042126. Issue only found in OracleJDK, but test case is valid for OpenJDK as well Reviewed-by: mduigou + test/java/util/HashMap/HashMapCloneLeak.java Changeset: 857d99bef21d Author: sherman Date: 2013-01-31 11:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/857d99bef21d 8005394: Base64.Decoder/Encoder.wrap(XStream) don't throw NPE for null args passed Summary: to check null for dec/enc.wrap methods Reviewed-by: alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java Changeset: 278397f752da Author: darcy Date: 2013-01-31 12:13 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/278397f752da 8005832: Remove java.lang.annotation.{ContainedBy, ContainerFor} annotation types Reviewed-by: mduigou - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java ! src/share/classes/java/lang/annotation/InvalidContainerAnnotationError.java Changeset: a5f38e811ab0 Author: darcy Date: 2013-01-31 12:23 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a5f38e811ab0 8007115: Refactor regression tests for java.lang.reflect.Parameter Reviewed-by: emc ! test/java/lang/reflect/Parameter/WithoutParameters.java Changeset: e5ce312a5b10 Author: sherman Date: 2013-01-31 13:13 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e5ce312a5b10 8007298: Base64.getMimeDecoder().decode() throws IAE for a single non-base64 character 8006526: Base64.Decoder.decode(String) spec contains a copy-paste mistake Summary: to ignore single non-base64 char in mime decoding Reviewed-by: alanb ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java Changeset: cff8d7768d72 Author: mduigou Date: 2013-01-31 13:27 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cff8d7768d72 8006709: Add minimal support of MacOSX platform for NetBeans Projects Summary: Adds support for MacOSX platform and architecture detection. Other minor updates (-source/target 1.8) Reviewed-by: ohair + make/netbeans/common/architectures/arch-x86_64.properties + make/netbeans/common/architectures/name-Macosx.properties ! make/netbeans/common/java-data-native.ent ! make/netbeans/common/java-data-no-native.ent ! make/netbeans/common/make.xml ! make/netbeans/common/shared.xml Changeset: 771551bc9e02 Author: lana Date: 2013-01-31 10:22 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/771551bc9e02 Merge Changeset: e822b4d50a5b Author: lana Date: 2013-01-31 14:10 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e822b4d50a5b Merge - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java Changeset: a09a37cff333 Author: mchung Date: 2013-01-31 14:29 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a09a37cff333 6355704: (fmt) %f formatting of BigDecimals is incorrect Reviewed-by: darcy Contributed-by: brian.burkhalter at oracle.com ! test/java/util/Formatter/Basic-X.java.template ! test/java/util/Formatter/BasicBigDecimal.java Changeset: d2495b9984fa Author: weijun Date: 2013-02-01 07:39 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d2495b9984fa 8006564: Test sun/security/util/Oid/S11N.sh fails with timeout on Linux 32-bit Reviewed-by: alanb + test/sun/security/util/Oid/S11N.java - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java Changeset: 17b643956999 Author: chegar Date: 2013-02-01 06:51 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/17b643956999 8006395: Race in async socket close on Linux Reviewed-by: alanb, dsamersoff ! src/solaris/native/java/net/linux_close.c + test/java/net/Socket/asyncClose/Race.java Changeset: ea8f3ca83501 Author: ksrini Date: 2013-02-01 07:25 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ea8f3ca83501 8006536: [launcher] removes trailing slashes on arguments Reviewed-by: ksrini, akhil Contributed-by: jviswana at linux.vnet.ibm.com ! src/windows/bin/cmdtoargs.c ! test/tools/launcher/Arrrghs.java Changeset: 5e47ee4d7196 Author: alanb Date: 2013-02-01 21:01 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5e47ee4d7196 5035569: Formatter should document that %a conversion unsupported for BigDecimal args Reviewed-by: darcy Contributed-by: brian.burkhalter at oracle.com ! src/share/classes/java/util/Formatter.java Changeset: cba578db5f39 Author: darcy Date: 2013-02-01 19:30 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cba578db5f39 6964528: Double.toHexString(double d) String manipulation with + in an append of StringBuilder Reviewed-by: shade ! src/share/classes/java/lang/Double.java Changeset: c1aaa8451547 Author: ksrini Date: 2013-02-01 22:12 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c1aaa8451547 8003549: (pack200) assertion errors when processing lambda class files with IMethods Summary: add more check for opcode, sketch provided by jrose Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java ! src/share/classes/com/sun/java/util/jar/pack/Instruction.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java ! test/ProblemList.txt + test/tools/pack200/InstructionTests.java ! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java Changeset: 6c88a12ea834 Author: ksrini Date: 2013-02-01 22:18 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6c88a12ea834 8007428: [launcher] add tools/launcher/FXLauncherTest.java to ProblemList.txt Reviewed-by: mchung ! test/ProblemList.txt Changeset: ee83319029a5 Author: chegar Date: 2013-02-02 17:15 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ee83319029a5 8007322: untangle ftp protocol from general networking URL tests Reviewed-by: alanb ! test/java/net/URL/Constructor.java ! test/java/net/URL/HandlerLoop.java ! test/java/net/URL/Test.java ! test/java/net/URL/URIToURLTest.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls ! test/java/net/URLConnection/RequestProperties.java ! test/java/net/URLConnection/RequestPropertyValues.java + test/sun/net/ftp/EncDec.doc + test/sun/net/ftp/MarkResetTest.java + test/sun/net/ftp/MarkResetTest.sh - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh ! test/sun/net/www/http/HttpClient/ProxyTest.java Changeset: 25831e7009c4 Author: ksrini Date: 2013-02-02 12:08 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/25831e7009c4 8007135: tools/launcher/VersionCheck.java failing with new tool jabswitch Reviewed-by: ksrini, mduigou Contributed-by: ragini.prasad at oracle.com ! test/tools/launcher/VersionCheck.java Changeset: 308d1362b60a Author: dmeetry Date: 2013-02-03 18:20 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/308d1362b60a 6471906: java.lang.NegativeArraySizeException in tenToThe Reviewed-by: darcy Contributed-by: brian.burkhalter at oracle.com ! src/share/classes/java/math/BigDecimal.java Changeset: 962d6612cace Author: dsamersoff Date: 2013-02-03 21:39 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/962d6612cace 8002048: Protocol to discovery of manageable Java processes on a network Summary: Introduce a protocol to discover manageble Java instances across a network subnet, JDP Reviewed-by: sla, dfuchs ! src/share/classes/sun/management/Agent.java + src/share/classes/sun/management/jdp/JdpBroadcaster.java + src/share/classes/sun/management/jdp/JdpController.java + src/share/classes/sun/management/jdp/JdpException.java + src/share/classes/sun/management/jdp/JdpGenericPacket.java + src/share/classes/sun/management/jdp/JdpJmxPacket.java + src/share/classes/sun/management/jdp/JdpPacket.java + src/share/classes/sun/management/jdp/JdpPacketReader.java + src/share/classes/sun/management/jdp/JdpPacketWriter.java + src/share/classes/sun/management/jdp/package-info.java + test/sun/management/jdp/JdpClient.java + test/sun/management/jdp/JdpDoSomething.java + test/sun/management/jdp/JdpTest.sh + test/sun/management/jdp/JdpUnitTest.java Changeset: 5bf1c9e6be60 Author: vinnie Date: 2013-02-04 17:20 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5bf1c9e6be60 8006994: Cleanup PKCS12 tests to ensure streams get closed Reviewed-by: mullan ! test/java/security/KeyStore/PBETest.java ! test/sun/security/pkcs12/StorePasswordTest.java ! test/sun/security/pkcs12/StoreSecretKeyTest.java ! test/sun/security/pkcs12/StoreTrustedCertTest.java Changeset: e202f43a8b8a Author: sherman Date: 2013-02-04 11:58 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e202f43a8b8a 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte stream 8006315: Base64.Decoder decoding methods are not consistent in treating non-padded data 8006530: Base64.getMimeDecoder().decode() throws exception for non-base64 character after adding = Summary: updated the spec to describe the expected behave explicitly and the implementation to follow Reviewed-by: alanb, chegar, lancea ! src/share/classes/java/util/Base64.java ! test/java/util/Base64/TestBase64.java Changeset: e04467fa13af Author: darcy Date: 2013-02-04 17:56 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e04467fa13af 8007113: Upgrade AnnotatedElement.isAnnotionPresent to be a default method Reviewed-by: chegar, jfranck ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/reflect/AccessibleObject.java ! src/share/classes/java/lang/reflect/AnnotatedElement.java ! src/share/classes/java/lang/reflect/Parameter.java ! src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java Changeset: fd37f0846653 Author: lana Date: 2013-02-04 22:37 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/fd37f0846653 Merge Changeset: 9ffcd758e2be Author: jbachorik Date: 2013-02-05 12:28 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9ffcd758e2be 7170447: Intermittent DeadListenerTest.java failure Summary: Due to asynchronous nature of processing server notifications it may happen that an "unregister" notification ha$ Reviewed-by: sjiang ! test/javax/management/remote/mandatory/notif/DeadListenerTest.java Changeset: 3119f0ebb58d Author: jbachorik Date: 2013-02-05 12:36 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3119f0ebb58d 8005791: Remove java.beans.* imports from com.sun.jmx.mbeanserver.Introspector Reviewed-by: rbackman ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java Changeset: e526277b51be Author: vinnie Date: 2013-02-05 14:25 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e526277b51be 8007483: attributes are ignored when loading keys from a PKCS12 keystore Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! test/sun/security/pkcs12/StorePasswordTest.java Changeset: f26b539bf1d5 Author: lana Date: 2013-02-05 11:11 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f26b539bf1d5 Merge - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java Changeset: b2fc8e31cecc Author: lana Date: 2013-02-11 16:14 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b2fc8e31cecc Merge - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java Changeset: 1b47e2dfa89a Author: lana Date: 2013-02-13 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1b47e2dfa89a Merge - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java From philip.race at oracle.com Wed Feb 13 23:08:48 2013 From: philip.race at oracle.com (philip.race at oracle.com) Date: Wed, 13 Feb 2013 23:08:48 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8008017: The fix for 8005129 does not build on Windows Message-ID: <20130213230910.DDE8647A5D@hg.openjdk.java.net> Changeset: 6df3acd02449 Author: prr Date: 2013-02-13 15:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6df3acd02449 8008017: The fix for 8005129 does not build on Windows Reviewed-by: prr, jgodinez Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/awt/medialib/mlib_ImageConv_16ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_16nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_8ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_8nw.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_u16ext.c ! src/share/native/sun/awt/medialib/mlib_ImageConv_u16nw.c From jennifer.godinez at oracle.com Thu Feb 14 22:15:02 2013 From: jennifer.godinez at oracle.com (jennifer.godinez at oracle.com) Date: Thu, 14 Feb 2013 22:15:02 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8008173: [parfait] #1173 Uninitialised variable -- TransformHelper.cpp Message-ID: <20130214221551.8112A47AA2@hg.openjdk.java.net> Changeset: f6eb212081b2 Author: jgodinez Date: 2013-02-14 14:14 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f6eb212081b2 8008173: [parfait] #1173 Uninitialised variable -- TransformHelper.cpp Reviewed-by: prr, vadim Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/java2d/loops/TransformHelper.c From anthony.petrov at oracle.com Fri Feb 15 12:18:40 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 15 Feb 2013 16:18:40 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <511BC5E4.9090302@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> <50EE1CEB.5080500@oracle.com> <50EFED12.6070700@oracle.com> <50EFFB4F.4090405@oracle.com> <510946F7.3090709@oracle.com> <510A6A54.1080705@oracle.com> <510A90DF.2060501@oracle.com> <511BC5E4.9090302@oracle.com> Message-ID: <511E27A0.7030800@oracle.com> Hi Anton, The fix looks great to me. Thanks for all your hard work! -- best regards, Anthony On 2/13/2013 20:57, Anton Litvinov wrote: > Hello Anthony, > > Could you please review the third version of the fix containing > modifications discussed with you in the previous letter. > > Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.02 > > This version of the fix differs from the previous in the following places: > > 1. A comment about the place of invocation of the method > "XErrorHandlerUtil.init" was added to a documentation block of the > method. > 2. A code related to XShmAttach function common to the files > "src/solaris/native/sun/awt/awt_GraphicsEnv.c" and > "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" was extracted > into a separate function "TryXShmAttach" declared in > "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. > 3. All JNI code related to X error handling was implemented as > corresponding macros defined in > "src/solaris/native/sun/awt/awt_util.h" file. > > Thank you, > Anton > > On 1/31/2013 7:42 PM, Anton Litvinov wrote: >> Hello Anthony, >> >> Thank you for the review and these remarks. Surely, the comment will >> be added. I think that all JNI code related to XShmAttach can be >> definitely transferred into a separate dedicated function, which will >> be declared in "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. I >> will try to wrap all JNU calls connected with XErrorHandler into the >> particular "WITH_XERROR_HANDLER", "RESTORE_XERROR_HANDLER" functions >> or macros. >> >> Thank you, >> Anton >> >> On 1/31/2013 4:57 PM, Anthony Petrov wrote: >>> Hi Anton, >>> >>> A couple comments: >>> >>> 1. src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java >>>> 80 private static void init(long display) { >>> >>> This method is private and isn't called from anywhere in this class >>> itself. This looks confusing. Please add a comment stating that this >>> method is invoked from native code, and from where exactly. >>> >>> >>> 2. Interesting that we use this machinery to call the XShmAttach() >>> from native code twice, and the code looks quite similar in each >>> case. Would it be possible to extract the common code in a separate >>> function (a-la BOOL TryXShmAttach(...)) to avoid code replication? >>> There are other usages as well, so we could also introduce a macro >>> (such as the old EXEC_WITH_XERROR_HANDLER but now with other >>> arguments) that would minimize all the JNU_ calls required to use >>> this machinery. >>> >>> >>> Otherwise the fix looks great. >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 1/30/2013 20:14, Anton Litvinov wrote: >>>> Hello Anthony, >>>> >>>> Could you, please, review a second version of the fix, which is >>>> based on an idea of reusing the existing AWT native global error >>>> handler from Java 2D native code. >>>> >>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.01 >>>> >>>> The fix consists of the following parts: >>>> >>>> 1. Migration of all X error handling code from XToolkit to a new >>>> XErrorHandlerUtil class for resolution of interdependency between >>>> a static initialization block of XToolkit and a block >>>> initializing >>>> java.awt.GraphicsEnvironment singleton. Such dependency is >>>> created >>>> by new calls to XToolkit static methods from >>>> "src/solaris/native/sun/awt/awt_GraphicsEnv.c", >>>> "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" files. >>>> 2. Substitution of XToolkit.WITH_XERROR_HANDLER, >>>> XToolkit.RESTORE_XERROR_HANDLER ... for corresponding methods, >>>> fields of XErrorHandlerUtil class in all places of JDK source >>>> code, where they were used. >>>> 3. Substitution of all found native X error handlers which are >>>> set in >>>> native code (awt_GraphicsEnv.c, X11SurfaceData.c, >>>> GLXSurfaceData.c) for new synthetic Java error handlers. >>>> 4. Removal of X error handling code used by the native error >>>> handlers >>>> from "solaris/native/sun/awt/awt_util.c" >>>> "solaris/native/sun/awt/awt_util.h" files. >>>> >>>> Thank you, >>>> Anton >>>> >>>> On 1/11/2013 3:45 PM, Anthony Petrov wrote: >>>>> I'm not Jim, but as I indicated earlier my opinion is that the >>>>> easiest way to fix this is to install the existing J2DXErrHandler() >>>>> only once. That is, it is the second option listed by you. Of >>>>> course, the J2DXErrHandler needs to be updated as well to detect >>>>> whether 2D code wants to use it at the moment or it must simply >>>>> delegate to the previous handler (i.e. where the code currently >>>>> installs/uninstalls the handler, it must instead set a global >>>>> boolean flag or something.) >>>>> >>>>> While the first option (reusing the existing AWT machinery) is an >>>>> interesting idea in general, I think it is complex and would >>>>> require too much additional testing and bring an unjustified risk >>>>> to the solution for such a basic problem. >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>>> >>>>> On 1/11/2013 14:44, Anton Litvinov wrote: >>>>>> Hello Jim, >>>>>> >>>>>> Thank you very much for the review and provision of a new idea of >>>>>> a solution. Elimination of the logic, which sets/unsets >>>>>> J2DXErrHandler() for each call "XShmAttach(awt_display, >>>>>> &shminfo))" should effectively resolve the issue, but only in case >>>>>> if all other native error handlers, which were set by the system >>>>>> function "XSetErrorHandler()" in JDK or in any external library, >>>>>> observe the rule of relaying of all events, which are not relative >>>>>> to them, to the previously saved error handlers. Otherwise an >>>>>> error generated during "XShmAttach" function call will not be >>>>>> handled by J2DXErrHandler(). >>>>>> >>>>>> Could you answer the following question. By setting >>>>>> J2DXErrHandler() only once and forever do you mean usage of AWT >>>>>> global event handler "static int ToolkitErrorHandler(Display * >>>>>> dpy, XErrorEvent * event)" from >>>>>> "src/solaris/native/sun/xawt/XlibWrapper.c" with Java synthetic >>>>>> handlers or creation of another global native error handler with >>>>>> J2DXErrHandler as native synthetic handler? >>>>>> >>>>>> Thank you, >>>>>> Anton >>>>>> >>>>>> On 1/10/2013 5:44 AM, Jim Graham wrote: >>>>>>> I think I'd rather see some way to prevent double-adding the >>>>>>> handler in the first place as well. Since it is only ever used >>>>>>> on errors I also think it is OK to set it once and leave it there >>>>>>> forever... >>>>>>> >>>>>>> ...jim >>>>>>> >>>>>>> On 1/9/13 8:08 AM, Anthony Petrov wrote: >>>>>>>> Hi Anton et al., >>>>>>>> >>>>>>>> If I read the description of the bug correctly, specifically >>>>>>>> this part: >>>>>>>> >>>>>>>>> The problem occurs, if another thread (for example, GTK thread) is >>>>>>>>> doing the same sort of thing concurrently. This can lead to the >>>>>>>>> following situation. >>>>>>>>> JVM thread: Sets J2DXErrHandler(), saves ANY_PREVIOUS_HANDLER as >>>>>>>>> previous GTK thread: Sets some GTK_HANDLER, saves >>>>>>>>> J2DXErrHandler() as previous JVM thread: Restores >>>>>>>>> ANY_PREVIOUS_HANDLER GTK thread: Restores >>>>>>>>> J2DXErrHandler() JVM >>>>>>>>> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as previous >>>>>>>> >>>>>>>> It is obvious that at this final step 2D is in an inconsistent >>>>>>>> state. We >>>>>>>> don't expect to replace our own error handler (and it shouldn't >>>>>>>> have >>>>>>>> been there in the first place). >>>>>>>> >>>>>>>> I realize that the fix you propose works around this problem. >>>>>>>> But this >>>>>>>> doesn't look like an ideal solution to me. >>>>>>>> >>>>>>>> BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 error >>>>>>>> handler only once and never replace it. All the rest of the >>>>>>>> push_handler/pop_handler logic is now located in Java code (see >>>>>>>> XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I >>>>>>>> believe >>>>>>>> that we should somehow share this machinery with the 2D code to >>>>>>>> avoid >>>>>>>> this sort of problems. Though I'm not sure if this will >>>>>>>> eliminate this >>>>>>>> exact issue. >>>>>>>> >>>>>>>> >>>>>>>> 2D/AWT folks: any other thoughts? >>>>>>>> >>>>>>>> -- >>>>>>>> best regards, >>>>>>>> Anthony >>>>>>>> >>>>>>>> On 12/29/2012 17:44, Anton Litvinov wrote: >>>>>>>>> Hello, >>>>>>>>> >>>>>>>>> Please review the following fix for a bug. >>>>>>>>> >>>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >>>>>>>>> https://jbs.oracle.com/bugs/browse/JDK-8005607 >>>>>>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >>>>>>>>> >>>>>>>>> The bug consists in a crash which is caused by a stack overflow >>>>>>>>> for >>>>>>>>> the reason of an infinite recursion in AWT native function >>>>>>>>> J2DXErrHandler() under certain circumstances on 32-bit Linux >>>>>>>>> OS. The >>>>>>>>> fix is based on introduction of the logic, which detects indirect >>>>>>>>> recursive calls to J2DXErrHandler() by means of a simple >>>>>>>>> counter, to >>>>>>>>> J2DXErrHandler() native function. Such a solution requires minimum >>>>>>>>> code changes, does not alter the handler's code significantly and >>>>>>>>> eliminates this bug. >>>>>>>>> >>>>>>>>> Adding 2d-dev at openjdk.java.net e-mail alias to the list of >>>>>>>>> recipients >>>>>>>>> of this letter, because the edited function's name is related >>>>>>>>> to Java >>>>>>>>> 2D area of JDK, despite of the fact that the edited file is >>>>>>>>> located in >>>>>>>>> AWT directory. >>>>>>>>> >>>>>>>>> Thank you, >>>>>>>>> Anton > From anton.litvinov at oracle.com Fri Feb 15 12:29:27 2013 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Fri, 15 Feb 2013 16:29:27 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <511E27A0.7030800@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> <50EE1CEB.5080500@oracle.com> <50EFED12.6070700@oracle.com> <50EFFB4F.4090405@oracle.com> <510946F7.3090709@oracle.com> <510A6A54.1080705@oracle.com> <510A90DF.2060501@oracle.com> <511BC5E4.9090302@oracle.com> <511E27A0.7030800@oracle.com> Message-ID: <511E2A27.5000907@oracle.com> Hello Anthony, Thank you very much for approval of this fix. Thank you, Anton On 2/15/2013 4:18 PM, Anthony Petrov wrote: > Hi Anton, > > The fix looks great to me. Thanks for all your hard work! > > -- > best regards, > Anthony > > On 2/13/2013 20:57, Anton Litvinov wrote: >> Hello Anthony, >> >> Could you please review the third version of the fix containing >> modifications discussed with you in the previous letter. >> >> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.02 >> >> This version of the fix differs from the previous in the following >> places: >> >> 1. A comment about the place of invocation of the method >> "XErrorHandlerUtil.init" was added to a documentation block of the >> method. >> 2. A code related to XShmAttach function common to the files >> "src/solaris/native/sun/awt/awt_GraphicsEnv.c" and >> "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" was extracted >> into a separate function "TryXShmAttach" declared in >> "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. >> 3. All JNI code related to X error handling was implemented as >> corresponding macros defined in >> "src/solaris/native/sun/awt/awt_util.h" file. >> >> Thank you, >> Anton >> >> On 1/31/2013 7:42 PM, Anton Litvinov wrote: >>> Hello Anthony, >>> >>> Thank you for the review and these remarks. Surely, the comment will >>> be added. I think that all JNI code related to XShmAttach can be >>> definitely transferred into a separate dedicated function, which >>> will be declared in "src/solaris/native/sun/awt/awt_GraphicsEnv.h" >>> file. I will try to wrap all JNU calls connected with XErrorHandler >>> into the particular "WITH_XERROR_HANDLER", "RESTORE_XERROR_HANDLER" >>> functions or macros. >>> >>> Thank you, >>> Anton >>> >>> On 1/31/2013 4:57 PM, Anthony Petrov wrote: >>>> Hi Anton, >>>> >>>> A couple comments: >>>> >>>> 1. src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java >>>>> 80 private static void init(long display) { >>>> >>>> This method is private and isn't called from anywhere in this class >>>> itself. This looks confusing. Please add a comment stating that >>>> this method is invoked from native code, and from where exactly. >>>> >>>> >>>> 2. Interesting that we use this machinery to call the XShmAttach() >>>> from native code twice, and the code looks quite similar in each >>>> case. Would it be possible to extract the common code in a separate >>>> function (a-la BOOL TryXShmAttach(...)) to avoid code replication? >>>> There are other usages as well, so we could also introduce a macro >>>> (such as the old EXEC_WITH_XERROR_HANDLER but now with other >>>> arguments) that would minimize all the JNU_ calls required to use >>>> this machinery. >>>> >>>> >>>> Otherwise the fix looks great. >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 1/30/2013 20:14, Anton Litvinov wrote: >>>>> Hello Anthony, >>>>> >>>>> Could you, please, review a second version of the fix, which is >>>>> based on an idea of reusing the existing AWT native global error >>>>> handler from Java 2D native code. >>>>> >>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.01 >>>>> >>>>> The fix consists of the following parts: >>>>> >>>>> 1. Migration of all X error handling code from XToolkit to a new >>>>> XErrorHandlerUtil class for resolution of interdependency >>>>> between >>>>> a static initialization block of XToolkit and a block >>>>> initializing >>>>> java.awt.GraphicsEnvironment singleton. Such dependency is >>>>> created >>>>> by new calls to XToolkit static methods from >>>>> "src/solaris/native/sun/awt/awt_GraphicsEnv.c", >>>>> "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" files. >>>>> 2. Substitution of XToolkit.WITH_XERROR_HANDLER, >>>>> XToolkit.RESTORE_XERROR_HANDLER ... for corresponding methods, >>>>> fields of XErrorHandlerUtil class in all places of JDK source >>>>> code, where they were used. >>>>> 3. Substitution of all found native X error handlers which are >>>>> set in >>>>> native code (awt_GraphicsEnv.c, X11SurfaceData.c, >>>>> GLXSurfaceData.c) for new synthetic Java error handlers. >>>>> 4. Removal of X error handling code used by the native error >>>>> handlers >>>>> from "solaris/native/sun/awt/awt_util.c" >>>>> "solaris/native/sun/awt/awt_util.h" files. >>>>> >>>>> Thank you, >>>>> Anton >>>>> >>>>> On 1/11/2013 3:45 PM, Anthony Petrov wrote: >>>>>> I'm not Jim, but as I indicated earlier my opinion is that the >>>>>> easiest way to fix this is to install the existing >>>>>> J2DXErrHandler() only once. That is, it is the second option >>>>>> listed by you. Of course, the J2DXErrHandler needs to be updated >>>>>> as well to detect whether 2D code wants to use it at the moment >>>>>> or it must simply delegate to the previous handler (i.e. where >>>>>> the code currently installs/uninstalls the handler, it must >>>>>> instead set a global boolean flag or something.) >>>>>> >>>>>> While the first option (reusing the existing AWT machinery) is an >>>>>> interesting idea in general, I think it is complex and would >>>>>> require too much additional testing and bring an unjustified risk >>>>>> to the solution for such a basic problem. >>>>>> >>>>>> -- >>>>>> best regards, >>>>>> Anthony >>>>>> >>>>>> On 1/11/2013 14:44, Anton Litvinov wrote: >>>>>>> Hello Jim, >>>>>>> >>>>>>> Thank you very much for the review and provision of a new idea >>>>>>> of a solution. Elimination of the logic, which sets/unsets >>>>>>> J2DXErrHandler() for each call "XShmAttach(awt_display, >>>>>>> &shminfo))" should effectively resolve the issue, but only in >>>>>>> case if all other native error handlers, which were set by the >>>>>>> system function "XSetErrorHandler()" in JDK or in any external >>>>>>> library, observe the rule of relaying of all events, which are >>>>>>> not relative to them, to the previously saved error handlers. >>>>>>> Otherwise an error generated during "XShmAttach" function call >>>>>>> will not be handled by J2DXErrHandler(). >>>>>>> >>>>>>> Could you answer the following question. By setting >>>>>>> J2DXErrHandler() only once and forever do you mean usage of AWT >>>>>>> global event handler "static int ToolkitErrorHandler(Display * >>>>>>> dpy, XErrorEvent * event)" from >>>>>>> "src/solaris/native/sun/xawt/XlibWrapper.c" with Java synthetic >>>>>>> handlers or creation of another global native error handler with >>>>>>> J2DXErrHandler as native synthetic handler? >>>>>>> >>>>>>> Thank you, >>>>>>> Anton >>>>>>> >>>>>>> On 1/10/2013 5:44 AM, Jim Graham wrote: >>>>>>>> I think I'd rather see some way to prevent double-adding the >>>>>>>> handler in the first place as well. Since it is only ever used >>>>>>>> on errors I also think it is OK to set it once and leave it >>>>>>>> there forever... >>>>>>>> >>>>>>>> ...jim >>>>>>>> >>>>>>>> On 1/9/13 8:08 AM, Anthony Petrov wrote: >>>>>>>>> Hi Anton et al., >>>>>>>>> >>>>>>>>> If I read the description of the bug correctly, specifically >>>>>>>>> this part: >>>>>>>>> >>>>>>>>>> The problem occurs, if another thread (for example, GTK >>>>>>>>>> thread) is >>>>>>>>>> doing the same sort of thing concurrently. This can lead to the >>>>>>>>>> following situation. >>>>>>>>>> JVM thread: Sets J2DXErrHandler(), saves >>>>>>>>>> ANY_PREVIOUS_HANDLER as >>>>>>>>>> previous GTK thread: Sets some GTK_HANDLER, saves >>>>>>>>>> J2DXErrHandler() as previous JVM thread: Restores >>>>>>>>>> ANY_PREVIOUS_HANDLER GTK thread: Restores >>>>>>>>>> J2DXErrHandler() JVM >>>>>>>>>> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as >>>>>>>>>> previous >>>>>>>>> >>>>>>>>> It is obvious that at this final step 2D is in an inconsistent >>>>>>>>> state. We >>>>>>>>> don't expect to replace our own error handler (and it >>>>>>>>> shouldn't have >>>>>>>>> been there in the first place). >>>>>>>>> >>>>>>>>> I realize that the fix you propose works around this problem. >>>>>>>>> But this >>>>>>>>> doesn't look like an ideal solution to me. >>>>>>>>> >>>>>>>>> BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 >>>>>>>>> error >>>>>>>>> handler only once and never replace it. All the rest of the >>>>>>>>> push_handler/pop_handler logic is now located in Java code (see >>>>>>>>> XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I >>>>>>>>> believe >>>>>>>>> that we should somehow share this machinery with the 2D code >>>>>>>>> to avoid >>>>>>>>> this sort of problems. Though I'm not sure if this will >>>>>>>>> eliminate this >>>>>>>>> exact issue. >>>>>>>>> >>>>>>>>> >>>>>>>>> 2D/AWT folks: any other thoughts? >>>>>>>>> >>>>>>>>> -- >>>>>>>>> best regards, >>>>>>>>> Anthony >>>>>>>>> >>>>>>>>> On 12/29/2012 17:44, Anton Litvinov wrote: >>>>>>>>>> Hello, >>>>>>>>>> >>>>>>>>>> Please review the following fix for a bug. >>>>>>>>>> >>>>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >>>>>>>>>> https://jbs.oracle.com/bugs/browse/JDK-8005607 >>>>>>>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >>>>>>>>>> >>>>>>>>>> The bug consists in a crash which is caused by a stack >>>>>>>>>> overflow for >>>>>>>>>> the reason of an infinite recursion in AWT native function >>>>>>>>>> J2DXErrHandler() under certain circumstances on 32-bit Linux >>>>>>>>>> OS. The >>>>>>>>>> fix is based on introduction of the logic, which detects >>>>>>>>>> indirect >>>>>>>>>> recursive calls to J2DXErrHandler() by means of a simple >>>>>>>>>> counter, to >>>>>>>>>> J2DXErrHandler() native function. Such a solution requires >>>>>>>>>> minimum >>>>>>>>>> code changes, does not alter the handler's code significantly >>>>>>>>>> and >>>>>>>>>> eliminates this bug. >>>>>>>>>> >>>>>>>>>> Adding 2d-dev at openjdk.java.net e-mail alias to the list of >>>>>>>>>> recipients >>>>>>>>>> of this letter, because the edited function's name is related >>>>>>>>>> to Java >>>>>>>>>> 2D area of JDK, despite of the fact that the edited file is >>>>>>>>>> located in >>>>>>>>>> AWT directory. >>>>>>>>>> >>>>>>>>>> Thank you, >>>>>>>>>> Anton >> From jvanek at redhat.com Fri Feb 15 14:54:20 2013 From: jvanek at redhat.com (Jiri Vanek) Date: Fri, 15 Feb 2013 15:54:20 +0100 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for fontmanager when no fonts are installed - RHBZ#862355, In-Reply-To: <51090882.4010307@redhat.com> References: <51090882.4010307@redhat.com> Message-ID: <511E4C1C.7060908@redhat.com> ping? -------- Original Message -------- Subject: Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for fontmanager when no fonts are installed - RHBZ#862355, Date: Wed, 30 Jan 2013 12:48:18 +0100 From: Jiri Vanek To: Phil Race CC: 2d-dev <2d-dev at openjdk.java.net> Ugh, sorry for delay, I had to find some free-time to attempt 2:) I have kept NoFontsFound exception which is thrown out of the Win32 or x11 font manager. It is then cough in SunFontMAnager and fallback font is provided for OpenJDK. I must admit that my win32 hacks were not completely tested yet. This fallback font consists just from substitute character, and source file is maintainable via fontofrge. During build of jdk tff font is generated by fontforge and deployed to LIBDIR/fonts I have chosen this approach because it is providing source file. And so it can be properly tracked and have "opens source" (and thus avoiding possible comunity issues) and.. it can grow.. I'm quite affraid that fontoforge dependence will be unacceptable for openjdk:( If so, then direct tff file can be provided. The "just substitute character" font should avoid any license issues, but if acceptable - on fontforge page are several BSD-like licensed - fonts http://fontforge.org/sfds/ Some of those fonts can be used instead if license is ok. Makefile changes are not complete as I will continue work on them according to your wishes. http://jvanek.fedorapeople.org/oracle/jdk8/webrevs/noFontsFound/v2/webrev/ http://jvanek.fedorapeople.org/oracle/jdk8/webrevs/noFontsFound/v2/webrev.zip Still some work awaiting, and I'm looking forward for feedback! Best regards J. On 11/27/2012 01:26 AM, Phil Race wrote: > I'd like to find something to make this more survivable, but > my main point is that having only Font.createFont() work and not system fonts > is a configuration not worth supporting. Its too fragile. > Your suggestion below makes it less fragile, but its still not widely useful. > If no one calls Font.createFont() in time, none of this will help. > > If the problem is "just" fontconfig then perhaps we can add a filesystem > search of well known locations as a fallback. Once upon a time that was > more or less all we had .. before fontconfig came along. This is independent > of Font.createFont() as a solution. That code is still there but I'm not > sure if its still being kicked in if fontconfig is present and fails. > Also its list of locations to search may have become dated .. > > But if there are absoutely zero fonts - and no one calls Font.createFont() > early, there's still a problem. > > Shipping a default font with the JRE is the only answer to that. > Seems like that's going to be awkward in the short term as we'd > need to find a font that could be stored in the OpenJDK repo to > be included automatically by the build and it would have to be > one that satisfies Oracle's lawyers as OK to include. > > But distros could do whatever makes sense and the missing piece > is to have the JRE look for this default font. The logic in > SunFontManager needs to have something in the isOpenJDK() branch > to check for a system property (perhaps) to fill in defaultFontFileName etc. > > -phil. > > On 11/19/2012 3:47 AM, Jiri Vanek wrote: >> Not sure if last email was final refuse ;) - I would like to continue in fixing this. From >> current "trialogue" I guess I have several possible ways of fixing it - >> - Add another font-manager, which will be possible to enable via sun.font.fontmanager >> - add command line switch which will "enable" "my fix" >> >> Or what about this approach: >> - when createFont(f) is called, and no fonts are found, then use this font as default font. >> >> >> Do you have any preferences for any of above approaches or do you really want idea behind this >> patch to be scratched away from table? >> >> Thank you very much for already given feedback, >> Best regards, >> J. >> >> On 11/13/2012 03:47 PM, Jiri Vanek wrote: >>> >>> Thank you both for valuable feedback, >>> >>> Yes, this was very straight-forward fix, but also the less harmful. I tested it quite heavvily, and >>> it does not move failure to "just later". Jre is working pretty find (as all calls to >>> FontManagerFactory are returning this stub, which is making its job quite fine:) >>> This fix was really intended for small (but maybe bigger then we think) group of headless devices, >>> where openjdk have its place. Such a device can have pretty good output eg via html, but no need for >>> fonts at "server" at all. This headless device will definitely have no need for fonts at all. >>> Except eg generating captcha which can be exactly the usage you have described. >>> >>> However your contra-usecase with misconfigured system or JRE is more then true, and I agree with >>> it. The workaround for user, to provide his ttf as default font can be maybe best solution. >>> >>> The approach of OracleJDK is well known to me - It have its default fonts. In world of opensource >>> the fonts were always little bit painful topic, but still this solution may be working to. >>> >>> Anyway both solution above are workarounds and does not fix the issue that createFont(or even most >>> of jre) should work no meter what fonts are installed. >>> >>> >>> Another suggested patch was make it configurable - but then it already is, as one can easily provide >>> custom font manager via sun.font.fontmanager property. Then we can maybe make life little bit more >>> easier by adding such "improved" fontmanager implementation. >>> >>> >>> I'm sorry for providing just linux implementation, but linux is probably target platform in such a >>> devices. It was also serving as proof of concept. I'm definitely going to implement this also for >>> win/mac when possible solution will be clarified. >>> >>> Currently I'm definitely for adding NoFontsFound exception (better then NullPointException, and >>> maybe extend it also for case that this Array have 0 length[just idea during writing]?), and think >>> little bit more about it. >>> Although I still like "my approach" the most, I'm going to obey yours advice but I still believe >>> this issue is worthy to be fixed. >>> >>> Best regards, >>> J. >>> >>> >>>> 2012/11/12 Phil Race > >>>> >>>> Well this seems like a really narrow use case for an extremely rare system >>>> misconfiguration. It wouldn't help the 99.999% of apps which expect to >>>> kick off AWT or Swing. >>>> >>>> And can you ensure that nothing in the app, or in the implementation makes >>>> the (reasonable) expectation that there are other fonts installed ? >>>> The most you could do is render to a BufferedImage or similar using the explicitly >>>> loaded font. The default logical font installed on a SG2D will be backed by a non-existent >>>> physical font, so you'd need to swap that in sooner rather than later. >>>> >>>> At some point you have to say that if JRE or system components are missing, >>>> then the source of the problem is what you should fix rather than make the >>>> JRE work around it. >>>> >>>> If you do want to try something, then in this case you get a much more usable >>>> runtime by providing a default font that the JRE can ensure is available so >>>> that the other 99.999% of apps can get by. >>>> >>>> The "Oracle" JDK gets by in this case precisely because it has a real physical font >>>> to fall back on. >>>> >>>> -phil. >>>> >>>> >>>> >>>> Hi Phil, >>>> >>>> I'm thinking here of Headless or embedded devices where the full Swing/AWT support may not be >>>> needed. >>>> >>>> Anyway, I see your point that those cases are definitely the minority and if OpenJDK doesn't >>>> want to >>>> work on those system, then I can only say that whoever is going to have such use case can just >>>> apply >>>> this patch and live with it. >>>> >>>> I totally agree however that if this comes from a misconfiguration rather than a conscious decision >>>> the JDK should probably protect itself by failing earlier (it will fail anyway, as you noted >>>> though). >>>> >>>> Perhaps a better patch would be to allow this to be configurable, by still introducing this new >>>> FontManager but making it a named class and allow this as an option, defaulting on the old >>>> behaviour, and at the same time giving a better error message. >>>> >>>> Also, like you suggest, ship a fallback in jre/lib/fonts sound a better idea in most cases. >>>> >>>> Cheers, >>>> Mario >>>> >>>> On 11/12/2012 12:29 PM, Mario Torre wrote: >>>> >>>> Hi Phil, >>>> >>>> I believe that the underlying problem here is that it should be legal to create a font from >>>> a file, even if the FontManager doesn't have any fonts installed. >>>> >>>> So, code like the one in the example: >>>> public class Test { >>>> public static void main(String[] args) throws Exception { >>>> Font.createFont(Font.TRUETYPE___FONT, new File("example.ttf")); >>>> } >>>> } >>>> >>>> When passed a real, valid font (example.ttf in this case) would still fail with the old >>>> code, and instead would work with the given patch (at least, I think this is the idea here, >>>> Jiri can probably explain in more details his intentions?). >>>> >>>> Cheers, >>>> Mario >>>> >>>> >>>> 2012/11/12 Phil Race >>>> __>> >>>> >>>> >>>> Hello Jiri, >>>> >>>> Doesn't this just move the point of failure to a bit later ? >>>> I can't see how having zero fonts on the system is survivable for an >>>> app that uses fonts. That's the principal reason we haven't tried >>>> to do something like this already. >>>> >>>> When facing system configuration issues maybe we just need to >>>> print a better message for the exception such as >>>> throw new InternalError("Can't find any fonts installed on this >>>> system."); >>>> >>>> Or make the default font more configurable and distros could ship >>>> one in jre/lib/fonts. >>>> >>>> BTW it appears you are only trying to solve the problem for >>>> Linux/Unix. >>>> Nothing for Windows or OS X. >>>> >>>> -phil. >>>> >>>> >>>> On 11/12/2012 10:07 AM, Jiri Vanek wrote: >>>> >>>> Hi! >>>> >>>> This is attempt to fix >>>> https://bugzilla.redhat.com/__show_bug.cgi?id=862355 >>>> >>>> The patch is introducing new exception >>>> src/share/classes/sun/font/__NoFontsFoundException.java, which >>>> is thrown from >>>> /src/solaris/classes/sun/awt/__X11FontManager.java instead of >>>> null pointer exception when no fonts are found on system. >>>> Exception is then catch in >>>> src/share/classes/sun/font/__FontManagerFactory.java, and in >>>> this case it returns (and not caching the instance of it) >>>> dummy font manager instead of continue in failure. >>>> the dummy manager do nothing, except that it is able to create >>>> java.awt.Font in same way as SunFontManager is doing, but is >>>> not doing any caching. >>>> >>>> To avoid duplicate code with >>>> src/share/classes/sun/font/__SunFontManager.java, i have >>>> extracted code from method createFont2D to new method here - >>>> prepareFont2D - which is responsible for creating font until >>>> caching.. >>>> >>>> Best regards, >>>> J. >>>> >>>> webrev >>>> http://jvanek.fedorapeople.__org/oracle/jdk8/webrevs/__fontProperties/ >>>> >>>> with test (although it will probably need some tuning and I'm >>>> not sure where is the best place for it) >>>> >>>> http://jvanek.fedorapeople.__org/oracle/jdk8/webrevs/__fontProperties/test/src/__nofontsreproducer/ >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>> > From artem.ananiev at oracle.com Mon Feb 18 11:16:52 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 18 Feb 2013 15:16:52 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <511BC5E4.9090302@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> <50EE1CEB.5080500@oracle.com> <50EFED12.6070700@oracle.com> <50EFFB4F.4090405@oracle.com> <510946F7.3090709@oracle.com> <510A6A54.1080705@oracle.com> <510A90DF.2060501@oracle.com> <511BC5E4.9090302@oracle.com> Message-ID: <51220DA4.7040608@oracle.com> Hi, Anton, a few minor comments: 1. XErrorHandlerUtil: can saved_error be private instead of package protected? 2. XErrorHandlerUtil.getDisplay() seems to be redundant. In general, the fix looks perfectly fine to me. Please, wait for comments from Java2D team, though. Thanks, Artem On 2/13/2013 8:57 PM, Anton Litvinov wrote: > Hello Anthony, > > Could you please review the third version of the fix containing > modifications discussed with you in the previous letter. > > Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.02 > > This version of the fix differs from the previous in the following places: > > 1. A comment about the place of invocation of the method > "XErrorHandlerUtil.init" was added to a documentation block of the > method. > 2. A code related to XShmAttach function common to the files > "src/solaris/native/sun/awt/awt_GraphicsEnv.c" and > "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" was extracted > into a separate function "TryXShmAttach" declared in > "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. > 3. All JNI code related to X error handling was implemented as > corresponding macros defined in > "src/solaris/native/sun/awt/awt_util.h" file. > > Thank you, > Anton > > On 1/31/2013 7:42 PM, Anton Litvinov wrote: >> Hello Anthony, >> >> Thank you for the review and these remarks. Surely, the comment will >> be added. I think that all JNI code related to XShmAttach can be >> definitely transferred into a separate dedicated function, which will >> be declared in "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. I >> will try to wrap all JNU calls connected with XErrorHandler into the >> particular "WITH_XERROR_HANDLER", "RESTORE_XERROR_HANDLER" functions >> or macros. >> >> Thank you, >> Anton >> >> On 1/31/2013 4:57 PM, Anthony Petrov wrote: >>> Hi Anton, >>> >>> A couple comments: >>> >>> 1. src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java >>>> 80 private static void init(long display) { >>> >>> This method is private and isn't called from anywhere in this class >>> itself. This looks confusing. Please add a comment stating that this >>> method is invoked from native code, and from where exactly. >>> >>> >>> 2. Interesting that we use this machinery to call the XShmAttach() >>> from native code twice, and the code looks quite similar in each >>> case. Would it be possible to extract the common code in a separate >>> function (a-la BOOL TryXShmAttach(...)) to avoid code replication? >>> There are other usages as well, so we could also introduce a macro >>> (such as the old EXEC_WITH_XERROR_HANDLER but now with other >>> arguments) that would minimize all the JNU_ calls required to use >>> this machinery. >>> >>> >>> Otherwise the fix looks great. >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 1/30/2013 20:14, Anton Litvinov wrote: >>>> Hello Anthony, >>>> >>>> Could you, please, review a second version of the fix, which is >>>> based on an idea of reusing the existing AWT native global error >>>> handler from Java 2D native code. >>>> >>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.01 >>>> >>>> The fix consists of the following parts: >>>> >>>> 1. Migration of all X error handling code from XToolkit to a new >>>> XErrorHandlerUtil class for resolution of interdependency between >>>> a static initialization block of XToolkit and a block >>>> initializing >>>> java.awt.GraphicsEnvironment singleton. Such dependency is >>>> created >>>> by new calls to XToolkit static methods from >>>> "src/solaris/native/sun/awt/awt_GraphicsEnv.c", >>>> "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" files. >>>> 2. Substitution of XToolkit.WITH_XERROR_HANDLER, >>>> XToolkit.RESTORE_XERROR_HANDLER ... for corresponding methods, >>>> fields of XErrorHandlerUtil class in all places of JDK source >>>> code, where they were used. >>>> 3. Substitution of all found native X error handlers which are >>>> set in >>>> native code (awt_GraphicsEnv.c, X11SurfaceData.c, >>>> GLXSurfaceData.c) for new synthetic Java error handlers. >>>> 4. Removal of X error handling code used by the native error >>>> handlers >>>> from "solaris/native/sun/awt/awt_util.c" >>>> "solaris/native/sun/awt/awt_util.h" files. >>>> >>>> Thank you, >>>> Anton >>>> >>>> On 1/11/2013 3:45 PM, Anthony Petrov wrote: >>>>> I'm not Jim, but as I indicated earlier my opinion is that the >>>>> easiest way to fix this is to install the existing J2DXErrHandler() >>>>> only once. That is, it is the second option listed by you. Of >>>>> course, the J2DXErrHandler needs to be updated as well to detect >>>>> whether 2D code wants to use it at the moment or it must simply >>>>> delegate to the previous handler (i.e. where the code currently >>>>> installs/uninstalls the handler, it must instead set a global >>>>> boolean flag or something.) >>>>> >>>>> While the first option (reusing the existing AWT machinery) is an >>>>> interesting idea in general, I think it is complex and would >>>>> require too much additional testing and bring an unjustified risk >>>>> to the solution for such a basic problem. >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>>> >>>>> On 1/11/2013 14:44, Anton Litvinov wrote: >>>>>> Hello Jim, >>>>>> >>>>>> Thank you very much for the review and provision of a new idea of >>>>>> a solution. Elimination of the logic, which sets/unsets >>>>>> J2DXErrHandler() for each call "XShmAttach(awt_display, >>>>>> &shminfo))" should effectively resolve the issue, but only in case >>>>>> if all other native error handlers, which were set by the system >>>>>> function "XSetErrorHandler()" in JDK or in any external library, >>>>>> observe the rule of relaying of all events, which are not relative >>>>>> to them, to the previously saved error handlers. Otherwise an >>>>>> error generated during "XShmAttach" function call will not be >>>>>> handled by J2DXErrHandler(). >>>>>> >>>>>> Could you answer the following question. By setting >>>>>> J2DXErrHandler() only once and forever do you mean usage of AWT >>>>>> global event handler "static int ToolkitErrorHandler(Display * >>>>>> dpy, XErrorEvent * event)" from >>>>>> "src/solaris/native/sun/xawt/XlibWrapper.c" with Java synthetic >>>>>> handlers or creation of another global native error handler with >>>>>> J2DXErrHandler as native synthetic handler? >>>>>> >>>>>> Thank you, >>>>>> Anton >>>>>> >>>>>> On 1/10/2013 5:44 AM, Jim Graham wrote: >>>>>>> I think I'd rather see some way to prevent double-adding the >>>>>>> handler in the first place as well. Since it is only ever used >>>>>>> on errors I also think it is OK to set it once and leave it there >>>>>>> forever... >>>>>>> >>>>>>> ...jim >>>>>>> >>>>>>> On 1/9/13 8:08 AM, Anthony Petrov wrote: >>>>>>>> Hi Anton et al., >>>>>>>> >>>>>>>> If I read the description of the bug correctly, specifically >>>>>>>> this part: >>>>>>>> >>>>>>>>> The problem occurs, if another thread (for example, GTK thread) is >>>>>>>>> doing the same sort of thing concurrently. This can lead to the >>>>>>>>> following situation. >>>>>>>>> JVM thread: Sets J2DXErrHandler(), saves ANY_PREVIOUS_HANDLER as >>>>>>>>> previous GTK thread: Sets some GTK_HANDLER, saves >>>>>>>>> J2DXErrHandler() as previous JVM thread: Restores >>>>>>>>> ANY_PREVIOUS_HANDLER GTK thread: Restores >>>>>>>>> J2DXErrHandler() JVM >>>>>>>>> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as previous >>>>>>>> >>>>>>>> It is obvious that at this final step 2D is in an inconsistent >>>>>>>> state. We >>>>>>>> don't expect to replace our own error handler (and it shouldn't >>>>>>>> have >>>>>>>> been there in the first place). >>>>>>>> >>>>>>>> I realize that the fix you propose works around this problem. >>>>>>>> But this >>>>>>>> doesn't look like an ideal solution to me. >>>>>>>> >>>>>>>> BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 error >>>>>>>> handler only once and never replace it. All the rest of the >>>>>>>> push_handler/pop_handler logic is now located in Java code (see >>>>>>>> XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I >>>>>>>> believe >>>>>>>> that we should somehow share this machinery with the 2D code to >>>>>>>> avoid >>>>>>>> this sort of problems. Though I'm not sure if this will >>>>>>>> eliminate this >>>>>>>> exact issue. >>>>>>>> >>>>>>>> >>>>>>>> 2D/AWT folks: any other thoughts? >>>>>>>> >>>>>>>> -- >>>>>>>> best regards, >>>>>>>> Anthony >>>>>>>> >>>>>>>> On 12/29/2012 17:44, Anton Litvinov wrote: >>>>>>>>> Hello, >>>>>>>>> >>>>>>>>> Please review the following fix for a bug. >>>>>>>>> >>>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >>>>>>>>> https://jbs.oracle.com/bugs/browse/JDK-8005607 >>>>>>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >>>>>>>>> >>>>>>>>> The bug consists in a crash which is caused by a stack overflow >>>>>>>>> for >>>>>>>>> the reason of an infinite recursion in AWT native function >>>>>>>>> J2DXErrHandler() under certain circumstances on 32-bit Linux >>>>>>>>> OS. The >>>>>>>>> fix is based on introduction of the logic, which detects indirect >>>>>>>>> recursive calls to J2DXErrHandler() by means of a simple >>>>>>>>> counter, to >>>>>>>>> J2DXErrHandler() native function. Such a solution requires minimum >>>>>>>>> code changes, does not alter the handler's code significantly and >>>>>>>>> eliminates this bug. >>>>>>>>> >>>>>>>>> Adding 2d-dev at openjdk.java.net e-mail alias to the list of >>>>>>>>> recipients >>>>>>>>> of this letter, because the edited function's name is related >>>>>>>>> to Java >>>>>>>>> 2D area of JDK, despite of the fact that the edited file is >>>>>>>>> located in >>>>>>>>> AWT directory. >>>>>>>>> >>>>>>>>> Thank you, >>>>>>>>> Anton > From anton.litvinov at oracle.com Mon Feb 18 12:04:55 2013 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Mon, 18 Feb 2013 16:04:55 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <51220DA4.7040608@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> <50EE1CEB.5080500@oracle.com> <50EFED12.6070700@oracle.com> <50EFFB4F.4090405@oracle.com> <510946F7.3090709@oracle.com> <510A6A54.1080705@oracle.com> <510A90DF.2060501@oracle.com> <511BC5E4.9090302@oracle.com> <51220DA4.7040608@oracle.com> Message-ID: <512218E7.9090808@oracle.com> Hello Artem, Thank you very much for the review of this fix. My responses to your questions are provided below in the same order, which you defined. 1. I think that "XErrorHandlerUtil.saved_error" field can surely be marked as private, but in this case the corresponding "XErrorHandlerUtil.getSavedError" method will be necessary, because this field is actively accessed from other classes which set a certain instance of XErrorHandler. For example "MotifDnDDropTargetProtocol.java", "XDragSourceProtocol.java" and a few other classes edited in this fix. 2. Yes, I completely agree that "XErrorHandlerUtil.getDisplay()" is reduntant. This method will be eliminated. Thank you, Anton On 2/18/2013 3:16 PM, Artem Ananiev wrote: > Hi, Anton, > > a few minor comments: > > 1. XErrorHandlerUtil: can saved_error be private instead of package > protected? > > 2. XErrorHandlerUtil.getDisplay() seems to be redundant. > > In general, the fix looks perfectly fine to me. Please, wait for > comments from Java2D team, though. > > Thanks, > > Artem > > On 2/13/2013 8:57 PM, Anton Litvinov wrote: >> Hello Anthony, >> >> Could you please review the third version of the fix containing >> modifications discussed with you in the previous letter. >> >> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.02 >> >> This version of the fix differs from the previous in the following >> places: >> >> 1. A comment about the place of invocation of the method >> "XErrorHandlerUtil.init" was added to a documentation block of the >> method. >> 2. A code related to XShmAttach function common to the files >> "src/solaris/native/sun/awt/awt_GraphicsEnv.c" and >> "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" was extracted >> into a separate function "TryXShmAttach" declared in >> "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. >> 3. All JNI code related to X error handling was implemented as >> corresponding macros defined in >> "src/solaris/native/sun/awt/awt_util.h" file. >> >> Thank you, >> Anton >> >> On 1/31/2013 7:42 PM, Anton Litvinov wrote: >>> Hello Anthony, >>> >>> Thank you for the review and these remarks. Surely, the comment will >>> be added. I think that all JNI code related to XShmAttach can be >>> definitely transferred into a separate dedicated function, which will >>> be declared in "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. I >>> will try to wrap all JNU calls connected with XErrorHandler into the >>> particular "WITH_XERROR_HANDLER", "RESTORE_XERROR_HANDLER" functions >>> or macros. >>> >>> Thank you, >>> Anton >>> >>> On 1/31/2013 4:57 PM, Anthony Petrov wrote: >>>> Hi Anton, >>>> >>>> A couple comments: >>>> >>>> 1. src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java >>>>> 80 private static void init(long display) { >>>> >>>> This method is private and isn't called from anywhere in this class >>>> itself. This looks confusing. Please add a comment stating that this >>>> method is invoked from native code, and from where exactly. >>>> >>>> >>>> 2. Interesting that we use this machinery to call the XShmAttach() >>>> from native code twice, and the code looks quite similar in each >>>> case. Would it be possible to extract the common code in a separate >>>> function (a-la BOOL TryXShmAttach(...)) to avoid code replication? >>>> There are other usages as well, so we could also introduce a macro >>>> (such as the old EXEC_WITH_XERROR_HANDLER but now with other >>>> arguments) that would minimize all the JNU_ calls required to use >>>> this machinery. >>>> >>>> >>>> Otherwise the fix looks great. >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 1/30/2013 20:14, Anton Litvinov wrote: >>>>> Hello Anthony, >>>>> >>>>> Could you, please, review a second version of the fix, which is >>>>> based on an idea of reusing the existing AWT native global error >>>>> handler from Java 2D native code. >>>>> >>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.01 >>>>> >>>>> The fix consists of the following parts: >>>>> >>>>> 1. Migration of all X error handling code from XToolkit to a new >>>>> XErrorHandlerUtil class for resolution of interdependency >>>>> between >>>>> a static initialization block of XToolkit and a block >>>>> initializing >>>>> java.awt.GraphicsEnvironment singleton. Such dependency is >>>>> created >>>>> by new calls to XToolkit static methods from >>>>> "src/solaris/native/sun/awt/awt_GraphicsEnv.c", >>>>> "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" files. >>>>> 2. Substitution of XToolkit.WITH_XERROR_HANDLER, >>>>> XToolkit.RESTORE_XERROR_HANDLER ... for corresponding methods, >>>>> fields of XErrorHandlerUtil class in all places of JDK source >>>>> code, where they were used. >>>>> 3. Substitution of all found native X error handlers which are >>>>> set in >>>>> native code (awt_GraphicsEnv.c, X11SurfaceData.c, >>>>> GLXSurfaceData.c) for new synthetic Java error handlers. >>>>> 4. Removal of X error handling code used by the native error >>>>> handlers >>>>> from "solaris/native/sun/awt/awt_util.c" >>>>> "solaris/native/sun/awt/awt_util.h" files. >>>>> >>>>> Thank you, >>>>> Anton >>>>> >>>>> On 1/11/2013 3:45 PM, Anthony Petrov wrote: >>>>>> I'm not Jim, but as I indicated earlier my opinion is that the >>>>>> easiest way to fix this is to install the existing J2DXErrHandler() >>>>>> only once. That is, it is the second option listed by you. Of >>>>>> course, the J2DXErrHandler needs to be updated as well to detect >>>>>> whether 2D code wants to use it at the moment or it must simply >>>>>> delegate to the previous handler (i.e. where the code currently >>>>>> installs/uninstalls the handler, it must instead set a global >>>>>> boolean flag or something.) >>>>>> >>>>>> While the first option (reusing the existing AWT machinery) is an >>>>>> interesting idea in general, I think it is complex and would >>>>>> require too much additional testing and bring an unjustified risk >>>>>> to the solution for such a basic problem. >>>>>> >>>>>> -- >>>>>> best regards, >>>>>> Anthony >>>>>> >>>>>> On 1/11/2013 14:44, Anton Litvinov wrote: >>>>>>> Hello Jim, >>>>>>> >>>>>>> Thank you very much for the review and provision of a new idea of >>>>>>> a solution. Elimination of the logic, which sets/unsets >>>>>>> J2DXErrHandler() for each call "XShmAttach(awt_display, >>>>>>> &shminfo))" should effectively resolve the issue, but only in case >>>>>>> if all other native error handlers, which were set by the system >>>>>>> function "XSetErrorHandler()" in JDK or in any external library, >>>>>>> observe the rule of relaying of all events, which are not relative >>>>>>> to them, to the previously saved error handlers. Otherwise an >>>>>>> error generated during "XShmAttach" function call will not be >>>>>>> handled by J2DXErrHandler(). >>>>>>> >>>>>>> Could you answer the following question. By setting >>>>>>> J2DXErrHandler() only once and forever do you mean usage of AWT >>>>>>> global event handler "static int ToolkitErrorHandler(Display * >>>>>>> dpy, XErrorEvent * event)" from >>>>>>> "src/solaris/native/sun/xawt/XlibWrapper.c" with Java synthetic >>>>>>> handlers or creation of another global native error handler with >>>>>>> J2DXErrHandler as native synthetic handler? >>>>>>> >>>>>>> Thank you, >>>>>>> Anton >>>>>>> >>>>>>> On 1/10/2013 5:44 AM, Jim Graham wrote: >>>>>>>> I think I'd rather see some way to prevent double-adding the >>>>>>>> handler in the first place as well. Since it is only ever used >>>>>>>> on errors I also think it is OK to set it once and leave it there >>>>>>>> forever... >>>>>>>> >>>>>>>> ...jim >>>>>>>> >>>>>>>> On 1/9/13 8:08 AM, Anthony Petrov wrote: >>>>>>>>> Hi Anton et al., >>>>>>>>> >>>>>>>>> If I read the description of the bug correctly, specifically >>>>>>>>> this part: >>>>>>>>> >>>>>>>>>> The problem occurs, if another thread (for example, GTK >>>>>>>>>> thread) is >>>>>>>>>> doing the same sort of thing concurrently. This can lead to the >>>>>>>>>> following situation. >>>>>>>>>> JVM thread: Sets J2DXErrHandler(), saves >>>>>>>>>> ANY_PREVIOUS_HANDLER as >>>>>>>>>> previous GTK thread: Sets some GTK_HANDLER, saves >>>>>>>>>> J2DXErrHandler() as previous JVM thread: Restores >>>>>>>>>> ANY_PREVIOUS_HANDLER GTK thread: Restores >>>>>>>>>> J2DXErrHandler() JVM >>>>>>>>>> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as >>>>>>>>>> previous >>>>>>>>> >>>>>>>>> It is obvious that at this final step 2D is in an inconsistent >>>>>>>>> state. We >>>>>>>>> don't expect to replace our own error handler (and it shouldn't >>>>>>>>> have >>>>>>>>> been there in the first place). >>>>>>>>> >>>>>>>>> I realize that the fix you propose works around this problem. >>>>>>>>> But this >>>>>>>>> doesn't look like an ideal solution to me. >>>>>>>>> >>>>>>>>> BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 >>>>>>>>> error >>>>>>>>> handler only once and never replace it. All the rest of the >>>>>>>>> push_handler/pop_handler logic is now located in Java code (see >>>>>>>>> XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I >>>>>>>>> believe >>>>>>>>> that we should somehow share this machinery with the 2D code to >>>>>>>>> avoid >>>>>>>>> this sort of problems. Though I'm not sure if this will >>>>>>>>> eliminate this >>>>>>>>> exact issue. >>>>>>>>> >>>>>>>>> >>>>>>>>> 2D/AWT folks: any other thoughts? >>>>>>>>> >>>>>>>>> -- >>>>>>>>> best regards, >>>>>>>>> Anthony >>>>>>>>> >>>>>>>>> On 12/29/2012 17:44, Anton Litvinov wrote: >>>>>>>>>> Hello, >>>>>>>>>> >>>>>>>>>> Please review the following fix for a bug. >>>>>>>>>> >>>>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >>>>>>>>>> https://jbs.oracle.com/bugs/browse/JDK-8005607 >>>>>>>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >>>>>>>>>> >>>>>>>>>> The bug consists in a crash which is caused by a stack overflow >>>>>>>>>> for >>>>>>>>>> the reason of an infinite recursion in AWT native function >>>>>>>>>> J2DXErrHandler() under certain circumstances on 32-bit Linux >>>>>>>>>> OS. The >>>>>>>>>> fix is based on introduction of the logic, which detects >>>>>>>>>> indirect >>>>>>>>>> recursive calls to J2DXErrHandler() by means of a simple >>>>>>>>>> counter, to >>>>>>>>>> J2DXErrHandler() native function. Such a solution requires >>>>>>>>>> minimum >>>>>>>>>> code changes, does not alter the handler's code significantly >>>>>>>>>> and >>>>>>>>>> eliminates this bug. >>>>>>>>>> >>>>>>>>>> Adding 2d-dev at openjdk.java.net e-mail alias to the list of >>>>>>>>>> recipients >>>>>>>>>> of this letter, because the edited function's name is related >>>>>>>>>> to Java >>>>>>>>>> 2D area of JDK, despite of the fact that the edited file is >>>>>>>>>> located in >>>>>>>>>> AWT directory. >>>>>>>>>> >>>>>>>>>> Thank you, >>>>>>>>>> Anton >> -------------- next part -------------- An HTML attachment was scrubbed... URL: From martin.desruisseaux at geomatys.fr Mon Feb 18 12:11:02 2013 From: martin.desruisseaux at geomatys.fr (Martin Desruisseaux) Date: Mon, 18 Feb 2013 13:11:02 +0100 Subject: [OpenJDK 2D-Dev] ImageInputStream.close() not idempotent - confusing behaviour Message-ID: <51221A56.4030308@geomatys.fr> Hello all 8 months ago we had a thread about 'ImageInputStream.close()' not being idempotent, which is a violation of 'java.io.Closeable' contract. Joe Darcy suggested that the best way to address the problem would be to make those 'close()' method idempotent [1], but I don't know if there is any follow-up on this topic... But we have just hit another argument in favour of making 'ImageInputStream.close()' idempotent. Looking in 'javax.imageio.ImageIO' Javadoc, we found the following: * For ImageIO.read(InputStream), the Javadoc said "This method does not close the provided InputStream after the read operation has completed; it is the responsibility of the caller to close the stream, if desired." [2] * But for ImageIO.read(ImageInputStream), the Javadoc said "Unlike most other methods in this class, this method does close the provided ImageInputStream after the read operation has completed, unless null is returned, in which case this method does not close the stream." [3] So the following code work as expected: try (InputStream in = getMyImageInputStream()) { image = ImageIO.read(in); } But just replacing InputStream by ImageInputStream in the above snipset causes unexpected IOException to be thrown with "stream closed" message, unless (ironically) ImageIO.read(...) fails to recognize the image format. I guess that we can not change the ImageIO specification, but making 'ImageInputStream.close()' idempotent would both makes it conform to the Closeable contract, and avoid the above surprising behaviour. Is making 'ImageInputStream.close()' idempotent something that could be done? I could contribute patch, but before doing so I would like to know if this is something that the Java2D team consider desirable. Thanks, Martin Desruisseaux [1] http://mail.openjdk.java.net/pipermail/2d-dev/2012-June/002607.html [2] http://download.java.net/jdk8/docs/api/javax/imageio/ImageIO.html#read%28java.io.InputStream%29 [3] http://download.java.net/jdk8/docs/api/javax/imageio/ImageIO.html#read%28javax.imageio.stream.ImageInputStream%29 -------------- next part -------------- An HTML attachment was scrubbed... URL: From artem.ananiev at oracle.com Mon Feb 18 12:23:09 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 18 Feb 2013 16:23:09 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <512218E7.9090808@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> <50EE1CEB.5080500@oracle.com> <50EFED12.6070700@oracle.com> <50EFFB4F.4090405@oracle.com> <510946F7.3090709@oracle.com> <510A6A54.1080705@oracle.com> <510A90DF.2060501@oracle.com> <511BC5E4.9090302@oracle.com> <51220DA4.7040608@oracle.com> <512218E7.9090808@oracle.com> Message-ID: <51221D2D.9070907@oracle.com> On 2/18/2013 4:04 PM, Anton Litvinov wrote: > Hello Artem, > > Thank you very much for the review of this fix. My responses to your > questions are provided below in the same order, which you defined. > > 1. I think that "XErrorHandlerUtil.saved_error" field can surely be > marked as private, but in this case the corresponding > "XErrorHandlerUtil.getSavedError" method will be necessary, because > this field is actively accessed from other classes which set a > certain instance of XErrorHandler. For example > "MotifDnDDropTargetProtocol.java", "XDragSourceProtocol.java" and a > few other classes edited in this fix. OK, I missed that usages when looking at the webrev. Let it stay unchanged now. > 2. Yes, I completely agree that "XErrorHandlerUtil.getDisplay()" is > reduntant. This method will be eliminated. Thanks, Artem > Thank you, > Anton > > On 2/18/2013 3:16 PM, Artem Ananiev wrote: >> Hi, Anton, >> >> a few minor comments: >> >> 1. XErrorHandlerUtil: can saved_error be private instead of package >> protected? >> >> 2. XErrorHandlerUtil.getDisplay() seems to be redundant. >> >> In general, the fix looks perfectly fine to me. Please, wait for >> comments from Java2D team, though. >> >> Thanks, >> >> Artem >> >> On 2/13/2013 8:57 PM, Anton Litvinov wrote: >>> Hello Anthony, >>> >>> Could you please review the third version of the fix containing >>> modifications discussed with you in the previous letter. >>> >>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.02 >>> >>> This version of the fix differs from the previous in the following >>> places: >>> >>> 1. A comment about the place of invocation of the method >>> "XErrorHandlerUtil.init" was added to a documentation block of the >>> method. >>> 2. A code related to XShmAttach function common to the files >>> "src/solaris/native/sun/awt/awt_GraphicsEnv.c" and >>> "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" was extracted >>> into a separate function "TryXShmAttach" declared in >>> "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. >>> 3. All JNI code related to X error handling was implemented as >>> corresponding macros defined in >>> "src/solaris/native/sun/awt/awt_util.h" file. >>> >>> Thank you, >>> Anton >>> >>> On 1/31/2013 7:42 PM, Anton Litvinov wrote: >>>> Hello Anthony, >>>> >>>> Thank you for the review and these remarks. Surely, the comment will >>>> be added. I think that all JNI code related to XShmAttach can be >>>> definitely transferred into a separate dedicated function, which will >>>> be declared in "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. I >>>> will try to wrap all JNU calls connected with XErrorHandler into the >>>> particular "WITH_XERROR_HANDLER", "RESTORE_XERROR_HANDLER" functions >>>> or macros. >>>> >>>> Thank you, >>>> Anton >>>> >>>> On 1/31/2013 4:57 PM, Anthony Petrov wrote: >>>>> Hi Anton, >>>>> >>>>> A couple comments: >>>>> >>>>> 1. src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java >>>>>> 80 private static void init(long display) { >>>>> >>>>> This method is private and isn't called from anywhere in this class >>>>> itself. This looks confusing. Please add a comment stating that this >>>>> method is invoked from native code, and from where exactly. >>>>> >>>>> >>>>> 2. Interesting that we use this machinery to call the XShmAttach() >>>>> from native code twice, and the code looks quite similar in each >>>>> case. Would it be possible to extract the common code in a separate >>>>> function (a-la BOOL TryXShmAttach(...)) to avoid code replication? >>>>> There are other usages as well, so we could also introduce a macro >>>>> (such as the old EXEC_WITH_XERROR_HANDLER but now with other >>>>> arguments) that would minimize all the JNU_ calls required to use >>>>> this machinery. >>>>> >>>>> >>>>> Otherwise the fix looks great. >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>>> >>>>> On 1/30/2013 20:14, Anton Litvinov wrote: >>>>>> Hello Anthony, >>>>>> >>>>>> Could you, please, review a second version of the fix, which is >>>>>> based on an idea of reusing the existing AWT native global error >>>>>> handler from Java 2D native code. >>>>>> >>>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.01 >>>>>> >>>>>> The fix consists of the following parts: >>>>>> >>>>>> 1. Migration of all X error handling code from XToolkit to a new >>>>>> XErrorHandlerUtil class for resolution of interdependency >>>>>> between >>>>>> a static initialization block of XToolkit and a block >>>>>> initializing >>>>>> java.awt.GraphicsEnvironment singleton. Such dependency is >>>>>> created >>>>>> by new calls to XToolkit static methods from >>>>>> "src/solaris/native/sun/awt/awt_GraphicsEnv.c", >>>>>> "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" files. >>>>>> 2. Substitution of XToolkit.WITH_XERROR_HANDLER, >>>>>> XToolkit.RESTORE_XERROR_HANDLER ... for corresponding methods, >>>>>> fields of XErrorHandlerUtil class in all places of JDK source >>>>>> code, where they were used. >>>>>> 3. Substitution of all found native X error handlers which are >>>>>> set in >>>>>> native code (awt_GraphicsEnv.c, X11SurfaceData.c, >>>>>> GLXSurfaceData.c) for new synthetic Java error handlers. >>>>>> 4. Removal of X error handling code used by the native error >>>>>> handlers >>>>>> from "solaris/native/sun/awt/awt_util.c" >>>>>> "solaris/native/sun/awt/awt_util.h" files. >>>>>> >>>>>> Thank you, >>>>>> Anton >>>>>> >>>>>> On 1/11/2013 3:45 PM, Anthony Petrov wrote: >>>>>>> I'm not Jim, but as I indicated earlier my opinion is that the >>>>>>> easiest way to fix this is to install the existing J2DXErrHandler() >>>>>>> only once. That is, it is the second option listed by you. Of >>>>>>> course, the J2DXErrHandler needs to be updated as well to detect >>>>>>> whether 2D code wants to use it at the moment or it must simply >>>>>>> delegate to the previous handler (i.e. where the code currently >>>>>>> installs/uninstalls the handler, it must instead set a global >>>>>>> boolean flag or something.) >>>>>>> >>>>>>> While the first option (reusing the existing AWT machinery) is an >>>>>>> interesting idea in general, I think it is complex and would >>>>>>> require too much additional testing and bring an unjustified risk >>>>>>> to the solution for such a basic problem. >>>>>>> >>>>>>> -- >>>>>>> best regards, >>>>>>> Anthony >>>>>>> >>>>>>> On 1/11/2013 14:44, Anton Litvinov wrote: >>>>>>>> Hello Jim, >>>>>>>> >>>>>>>> Thank you very much for the review and provision of a new idea of >>>>>>>> a solution. Elimination of the logic, which sets/unsets >>>>>>>> J2DXErrHandler() for each call "XShmAttach(awt_display, >>>>>>>> &shminfo))" should effectively resolve the issue, but only in case >>>>>>>> if all other native error handlers, which were set by the system >>>>>>>> function "XSetErrorHandler()" in JDK or in any external library, >>>>>>>> observe the rule of relaying of all events, which are not relative >>>>>>>> to them, to the previously saved error handlers. Otherwise an >>>>>>>> error generated during "XShmAttach" function call will not be >>>>>>>> handled by J2DXErrHandler(). >>>>>>>> >>>>>>>> Could you answer the following question. By setting >>>>>>>> J2DXErrHandler() only once and forever do you mean usage of AWT >>>>>>>> global event handler "static int ToolkitErrorHandler(Display * >>>>>>>> dpy, XErrorEvent * event)" from >>>>>>>> "src/solaris/native/sun/xawt/XlibWrapper.c" with Java synthetic >>>>>>>> handlers or creation of another global native error handler with >>>>>>>> J2DXErrHandler as native synthetic handler? >>>>>>>> >>>>>>>> Thank you, >>>>>>>> Anton >>>>>>>> >>>>>>>> On 1/10/2013 5:44 AM, Jim Graham wrote: >>>>>>>>> I think I'd rather see some way to prevent double-adding the >>>>>>>>> handler in the first place as well. Since it is only ever used >>>>>>>>> on errors I also think it is OK to set it once and leave it there >>>>>>>>> forever... >>>>>>>>> >>>>>>>>> ...jim >>>>>>>>> >>>>>>>>> On 1/9/13 8:08 AM, Anthony Petrov wrote: >>>>>>>>>> Hi Anton et al., >>>>>>>>>> >>>>>>>>>> If I read the description of the bug correctly, specifically >>>>>>>>>> this part: >>>>>>>>>> >>>>>>>>>>> The problem occurs, if another thread (for example, GTK >>>>>>>>>>> thread) is >>>>>>>>>>> doing the same sort of thing concurrently. This can lead to the >>>>>>>>>>> following situation. >>>>>>>>>>> JVM thread: Sets J2DXErrHandler(), saves >>>>>>>>>>> ANY_PREVIOUS_HANDLER as >>>>>>>>>>> previous GTK thread: Sets some GTK_HANDLER, saves >>>>>>>>>>> J2DXErrHandler() as previous JVM thread: Restores >>>>>>>>>>> ANY_PREVIOUS_HANDLER GTK thread: Restores >>>>>>>>>>> J2DXErrHandler() JVM >>>>>>>>>>> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as >>>>>>>>>>> previous >>>>>>>>>> >>>>>>>>>> It is obvious that at this final step 2D is in an inconsistent >>>>>>>>>> state. We >>>>>>>>>> don't expect to replace our own error handler (and it shouldn't >>>>>>>>>> have >>>>>>>>>> been there in the first place). >>>>>>>>>> >>>>>>>>>> I realize that the fix you propose works around this problem. >>>>>>>>>> But this >>>>>>>>>> doesn't look like an ideal solution to me. >>>>>>>>>> >>>>>>>>>> BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 >>>>>>>>>> error >>>>>>>>>> handler only once and never replace it. All the rest of the >>>>>>>>>> push_handler/pop_handler logic is now located in Java code (see >>>>>>>>>> XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I >>>>>>>>>> believe >>>>>>>>>> that we should somehow share this machinery with the 2D code to >>>>>>>>>> avoid >>>>>>>>>> this sort of problems. Though I'm not sure if this will >>>>>>>>>> eliminate this >>>>>>>>>> exact issue. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> 2D/AWT folks: any other thoughts? >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> best regards, >>>>>>>>>> Anthony >>>>>>>>>> >>>>>>>>>> On 12/29/2012 17:44, Anton Litvinov wrote: >>>>>>>>>>> Hello, >>>>>>>>>>> >>>>>>>>>>> Please review the following fix for a bug. >>>>>>>>>>> >>>>>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >>>>>>>>>>> https://jbs.oracle.com/bugs/browse/JDK-8005607 >>>>>>>>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >>>>>>>>>>> >>>>>>>>>>> The bug consists in a crash which is caused by a stack overflow >>>>>>>>>>> for >>>>>>>>>>> the reason of an infinite recursion in AWT native function >>>>>>>>>>> J2DXErrHandler() under certain circumstances on 32-bit Linux >>>>>>>>>>> OS. The >>>>>>>>>>> fix is based on introduction of the logic, which detects >>>>>>>>>>> indirect >>>>>>>>>>> recursive calls to J2DXErrHandler() by means of a simple >>>>>>>>>>> counter, to >>>>>>>>>>> J2DXErrHandler() native function. Such a solution requires >>>>>>>>>>> minimum >>>>>>>>>>> code changes, does not alter the handler's code significantly >>>>>>>>>>> and >>>>>>>>>>> eliminates this bug. >>>>>>>>>>> >>>>>>>>>>> Adding 2d-dev at openjdk.java.net e-mail alias to the list of >>>>>>>>>>> recipients >>>>>>>>>>> of this letter, because the edited function's name is related >>>>>>>>>>> to Java >>>>>>>>>>> 2D area of JDK, despite of the fact that the edited file is >>>>>>>>>>> located in >>>>>>>>>>> AWT directory. >>>>>>>>>>> >>>>>>>>>>> Thank you, >>>>>>>>>>> Anton >>> > From anton.litvinov at oracle.com Mon Feb 18 16:08:16 2013 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Mon, 18 Feb 2013 20:08:16 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <51221D2D.9070907@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> <50EE1CEB.5080500@oracle.com> <50EFED12.6070700@oracle.com> <50EFFB4F.4090405@oracle.com> <510946F7.3090709@oracle.com> <510A6A54.1080705@oracle.com> <510A90DF.2060501@oracle.com> <511BC5E4.9090302@oracle.com> <51220DA4.7040608@oracle.com> <512218E7.9090808@oracle.com> <51221D2D.9070907@oracle.com> Message-ID: <512251F0.7020204@oracle.com> Hello Artem, Could you please review a new version of the fix. The method "XErrorHandlerUtil.getDisplay()" was removed and "XErrorHandlerUtil.XSync()" method refers to the field "display" directly now. Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.03 Thank you, Anton On 2/18/2013 4:23 PM, Artem Ananiev wrote: > > On 2/18/2013 4:04 PM, Anton Litvinov wrote: >> Hello Artem, >> >> Thank you very much for the review of this fix. My responses to your >> questions are provided below in the same order, which you defined. >> >> 1. I think that "XErrorHandlerUtil.saved_error" field can surely be >> marked as private, but in this case the corresponding >> "XErrorHandlerUtil.getSavedError" method will be necessary, because >> this field is actively accessed from other classes which set a >> certain instance of XErrorHandler. For example >> "MotifDnDDropTargetProtocol.java", "XDragSourceProtocol.java" and a >> few other classes edited in this fix. > > OK, I missed that usages when looking at the webrev. Let it stay > unchanged now. > >> 2. Yes, I completely agree that "XErrorHandlerUtil.getDisplay()" is >> reduntant. This method will be eliminated. > > Thanks, > > Artem > >> Thank you, >> Anton >> >> On 2/18/2013 3:16 PM, Artem Ananiev wrote: >>> Hi, Anton, >>> >>> a few minor comments: >>> >>> 1. XErrorHandlerUtil: can saved_error be private instead of package >>> protected? >>> >>> 2. XErrorHandlerUtil.getDisplay() seems to be redundant. >>> >>> In general, the fix looks perfectly fine to me. Please, wait for >>> comments from Java2D team, though. >>> >>> Thanks, >>> >>> Artem >>> >>> On 2/13/2013 8:57 PM, Anton Litvinov wrote: >>>> Hello Anthony, >>>> >>>> Could you please review the third version of the fix containing >>>> modifications discussed with you in the previous letter. >>>> >>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.02 >>>> >>>> This version of the fix differs from the previous in the following >>>> places: >>>> >>>> 1. A comment about the place of invocation of the method >>>> "XErrorHandlerUtil.init" was added to a documentation block of the >>>> method. >>>> 2. A code related to XShmAttach function common to the files >>>> "src/solaris/native/sun/awt/awt_GraphicsEnv.c" and >>>> "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" was extracted >>>> into a separate function "TryXShmAttach" declared in >>>> "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. >>>> 3. All JNI code related to X error handling was implemented as >>>> corresponding macros defined in >>>> "src/solaris/native/sun/awt/awt_util.h" file. >>>> >>>> Thank you, >>>> Anton >>>> >>>> On 1/31/2013 7:42 PM, Anton Litvinov wrote: >>>>> Hello Anthony, >>>>> >>>>> Thank you for the review and these remarks. Surely, the comment will >>>>> be added. I think that all JNI code related to XShmAttach can be >>>>> definitely transferred into a separate dedicated function, which will >>>>> be declared in "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. I >>>>> will try to wrap all JNU calls connected with XErrorHandler into the >>>>> particular "WITH_XERROR_HANDLER", "RESTORE_XERROR_HANDLER" functions >>>>> or macros. >>>>> >>>>> Thank you, >>>>> Anton >>>>> >>>>> On 1/31/2013 4:57 PM, Anthony Petrov wrote: >>>>>> Hi Anton, >>>>>> >>>>>> A couple comments: >>>>>> >>>>>> 1. src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java >>>>>>> 80 private static void init(long display) { >>>>>> >>>>>> This method is private and isn't called from anywhere in this class >>>>>> itself. This looks confusing. Please add a comment stating that this >>>>>> method is invoked from native code, and from where exactly. >>>>>> >>>>>> >>>>>> 2. Interesting that we use this machinery to call the XShmAttach() >>>>>> from native code twice, and the code looks quite similar in each >>>>>> case. Would it be possible to extract the common code in a separate >>>>>> function (a-la BOOL TryXShmAttach(...)) to avoid code replication? >>>>>> There are other usages as well, so we could also introduce a macro >>>>>> (such as the old EXEC_WITH_XERROR_HANDLER but now with other >>>>>> arguments) that would minimize all the JNU_ calls required to use >>>>>> this machinery. >>>>>> >>>>>> >>>>>> Otherwise the fix looks great. >>>>>> >>>>>> -- >>>>>> best regards, >>>>>> Anthony >>>>>> >>>>>> On 1/30/2013 20:14, Anton Litvinov wrote: >>>>>>> Hello Anthony, >>>>>>> >>>>>>> Could you, please, review a second version of the fix, which is >>>>>>> based on an idea of reusing the existing AWT native global error >>>>>>> handler from Java 2D native code. >>>>>>> >>>>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.01 >>>>>>> >>>>>>> The fix consists of the following parts: >>>>>>> >>>>>>> 1. Migration of all X error handling code from XToolkit to a new >>>>>>> XErrorHandlerUtil class for resolution of interdependency >>>>>>> between >>>>>>> a static initialization block of XToolkit and a block >>>>>>> initializing >>>>>>> java.awt.GraphicsEnvironment singleton. Such dependency is >>>>>>> created >>>>>>> by new calls to XToolkit static methods from >>>>>>> "src/solaris/native/sun/awt/awt_GraphicsEnv.c", >>>>>>> "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" files. >>>>>>> 2. Substitution of XToolkit.WITH_XERROR_HANDLER, >>>>>>> XToolkit.RESTORE_XERROR_HANDLER ... for corresponding >>>>>>> methods, >>>>>>> fields of XErrorHandlerUtil class in all places of JDK source >>>>>>> code, where they were used. >>>>>>> 3. Substitution of all found native X error handlers which are >>>>>>> set in >>>>>>> native code (awt_GraphicsEnv.c, X11SurfaceData.c, >>>>>>> GLXSurfaceData.c) for new synthetic Java error handlers. >>>>>>> 4. Removal of X error handling code used by the native error >>>>>>> handlers >>>>>>> from "solaris/native/sun/awt/awt_util.c" >>>>>>> "solaris/native/sun/awt/awt_util.h" files. >>>>>>> >>>>>>> Thank you, >>>>>>> Anton >>>>>>> >>>>>>> On 1/11/2013 3:45 PM, Anthony Petrov wrote: >>>>>>>> I'm not Jim, but as I indicated earlier my opinion is that the >>>>>>>> easiest way to fix this is to install the existing >>>>>>>> J2DXErrHandler() >>>>>>>> only once. That is, it is the second option listed by you. Of >>>>>>>> course, the J2DXErrHandler needs to be updated as well to detect >>>>>>>> whether 2D code wants to use it at the moment or it must simply >>>>>>>> delegate to the previous handler (i.e. where the code currently >>>>>>>> installs/uninstalls the handler, it must instead set a global >>>>>>>> boolean flag or something.) >>>>>>>> >>>>>>>> While the first option (reusing the existing AWT machinery) is an >>>>>>>> interesting idea in general, I think it is complex and would >>>>>>>> require too much additional testing and bring an unjustified risk >>>>>>>> to the solution for such a basic problem. >>>>>>>> >>>>>>>> -- >>>>>>>> best regards, >>>>>>>> Anthony >>>>>>>> >>>>>>>> On 1/11/2013 14:44, Anton Litvinov wrote: >>>>>>>>> Hello Jim, >>>>>>>>> >>>>>>>>> Thank you very much for the review and provision of a new idea of >>>>>>>>> a solution. Elimination of the logic, which sets/unsets >>>>>>>>> J2DXErrHandler() for each call "XShmAttach(awt_display, >>>>>>>>> &shminfo))" should effectively resolve the issue, but only in >>>>>>>>> case >>>>>>>>> if all other native error handlers, which were set by the system >>>>>>>>> function "XSetErrorHandler()" in JDK or in any external library, >>>>>>>>> observe the rule of relaying of all events, which are not >>>>>>>>> relative >>>>>>>>> to them, to the previously saved error handlers. Otherwise an >>>>>>>>> error generated during "XShmAttach" function call will not be >>>>>>>>> handled by J2DXErrHandler(). >>>>>>>>> >>>>>>>>> Could you answer the following question. By setting >>>>>>>>> J2DXErrHandler() only once and forever do you mean usage of AWT >>>>>>>>> global event handler "static int ToolkitErrorHandler(Display * >>>>>>>>> dpy, XErrorEvent * event)" from >>>>>>>>> "src/solaris/native/sun/xawt/XlibWrapper.c" with Java synthetic >>>>>>>>> handlers or creation of another global native error handler with >>>>>>>>> J2DXErrHandler as native synthetic handler? >>>>>>>>> >>>>>>>>> Thank you, >>>>>>>>> Anton >>>>>>>>> >>>>>>>>> On 1/10/2013 5:44 AM, Jim Graham wrote: >>>>>>>>>> I think I'd rather see some way to prevent double-adding the >>>>>>>>>> handler in the first place as well. Since it is only ever used >>>>>>>>>> on errors I also think it is OK to set it once and leave it >>>>>>>>>> there >>>>>>>>>> forever... >>>>>>>>>> >>>>>>>>>> ...jim >>>>>>>>>> >>>>>>>>>> On 1/9/13 8:08 AM, Anthony Petrov wrote: >>>>>>>>>>> Hi Anton et al., >>>>>>>>>>> >>>>>>>>>>> If I read the description of the bug correctly, specifically >>>>>>>>>>> this part: >>>>>>>>>>> >>>>>>>>>>>> The problem occurs, if another thread (for example, GTK >>>>>>>>>>>> thread) is >>>>>>>>>>>> doing the same sort of thing concurrently. This can lead to >>>>>>>>>>>> the >>>>>>>>>>>> following situation. >>>>>>>>>>>> JVM thread: Sets J2DXErrHandler(), saves >>>>>>>>>>>> ANY_PREVIOUS_HANDLER as >>>>>>>>>>>> previous GTK thread: Sets some GTK_HANDLER, saves >>>>>>>>>>>> J2DXErrHandler() as previous JVM thread: Restores >>>>>>>>>>>> ANY_PREVIOUS_HANDLER GTK thread: Restores >>>>>>>>>>>> J2DXErrHandler() JVM >>>>>>>>>>>> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as >>>>>>>>>>>> previous >>>>>>>>>>> >>>>>>>>>>> It is obvious that at this final step 2D is in an inconsistent >>>>>>>>>>> state. We >>>>>>>>>>> don't expect to replace our own error handler (and it shouldn't >>>>>>>>>>> have >>>>>>>>>>> been there in the first place). >>>>>>>>>>> >>>>>>>>>>> I realize that the fix you propose works around this problem. >>>>>>>>>>> But this >>>>>>>>>>> doesn't look like an ideal solution to me. >>>>>>>>>>> >>>>>>>>>>> BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 >>>>>>>>>>> error >>>>>>>>>>> handler only once and never replace it. All the rest of the >>>>>>>>>>> push_handler/pop_handler logic is now located in Java code (see >>>>>>>>>>> XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I >>>>>>>>>>> believe >>>>>>>>>>> that we should somehow share this machinery with the 2D code to >>>>>>>>>>> avoid >>>>>>>>>>> this sort of problems. Though I'm not sure if this will >>>>>>>>>>> eliminate this >>>>>>>>>>> exact issue. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> 2D/AWT folks: any other thoughts? >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> best regards, >>>>>>>>>>> Anthony >>>>>>>>>>> >>>>>>>>>>> On 12/29/2012 17:44, Anton Litvinov wrote: >>>>>>>>>>>> Hello, >>>>>>>>>>>> >>>>>>>>>>>> Please review the following fix for a bug. >>>>>>>>>>>> >>>>>>>>>>>> Bug: >>>>>>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >>>>>>>>>>>> https://jbs.oracle.com/bugs/browse/JDK-8005607 >>>>>>>>>>>> Webrev: >>>>>>>>>>>> http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >>>>>>>>>>>> >>>>>>>>>>>> The bug consists in a crash which is caused by a stack >>>>>>>>>>>> overflow >>>>>>>>>>>> for >>>>>>>>>>>> the reason of an infinite recursion in AWT native function >>>>>>>>>>>> J2DXErrHandler() under certain circumstances on 32-bit Linux >>>>>>>>>>>> OS. The >>>>>>>>>>>> fix is based on introduction of the logic, which detects >>>>>>>>>>>> indirect >>>>>>>>>>>> recursive calls to J2DXErrHandler() by means of a simple >>>>>>>>>>>> counter, to >>>>>>>>>>>> J2DXErrHandler() native function. Such a solution requires >>>>>>>>>>>> minimum >>>>>>>>>>>> code changes, does not alter the handler's code significantly >>>>>>>>>>>> and >>>>>>>>>>>> eliminates this bug. >>>>>>>>>>>> >>>>>>>>>>>> Adding 2d-dev at openjdk.java.net e-mail alias to the list of >>>>>>>>>>>> recipients >>>>>>>>>>>> of this letter, because the edited function's name is related >>>>>>>>>>>> to Java >>>>>>>>>>>> 2D area of JDK, despite of the fact that the edited file is >>>>>>>>>>>> located in >>>>>>>>>>>> AWT directory. >>>>>>>>>>>> >>>>>>>>>>>> Thank you, >>>>>>>>>>>> Anton >>>> >> From jennifer.godinez at oracle.com Mon Feb 18 22:04:32 2013 From: jennifer.godinez at oracle.com (jennifer.godinez at oracle.com) Date: Mon, 18 Feb 2013 22:04:32 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8005191: [parfait] #384 sun/font/layout/LookupProcessor.cpp Null pointer dereference Message-ID: <20130218220534.BD96547B75@hg.openjdk.java.net> Changeset: 4b11045a9c4c Author: jgodinez Date: 2013-02-18 14:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4b11045a9c4c 8005191: [parfait] #384 sun/font/layout/LookupProcessor.cpp Null pointer dereference Reviewed-by: prr, vadim Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/font/layout/LookupProcessor.cpp From lana.steuck at oracle.com Wed Feb 20 07:23:05 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 20 Feb 2013 07:23:05 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d: 7 new changesets Message-ID: <20130220072306.C3C4047BDB@hg.openjdk.java.net> Changeset: 45dcccc6d221 Author: katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/45dcccc6d221 Added tag jdk8-b77 for changeset 3933eebc659d ! .hgtags Changeset: 8dd61906da5f Author: chegar Date: 2013-02-06 11:36 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/rev/8dd61906da5f 8007625: race with nested repos in /common/bin/hgforest.sh Reviewed-by: dholmes, ohair, ohrstrom ! common/bin/hgforest.sh ! get_source.sh Changeset: 168dd033604a Author: mduigou Date: 2013-02-06 11:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/168dd033604a 8004726: Link bug ids to jbs rather than monaco. Reviewed-by: ohair, chegar, katleman ! make/scripts/webrev.ksh Changeset: 7817368287cd Author: mduigou Date: 2013-02-06 11:12 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/7817368287cd 8006595: Use jdk/test/Makefile targets in preference to local definitions Reviewed-by: alanb ! common/makefiles/Main.gmk ! test/Makefile Changeset: fdb1e09519ed Author: sherman Date: 2013-02-12 09:27 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/fdb1e09519ed 8007392: JSR 310: DateTime API Updates Summary: Integration of JSR310 Date/Time API for M7 Reviewed-by: darcy, alanb, naoto Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, masayoshi.okutsu at oracle.com, patrick.zhang at oracle.com ! common/makefiles/javadoc/CORE_PKGS.gmk Changeset: 76808fb4194a Author: lana Date: 2013-02-13 11:21 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/76808fb4194a Merge ! common/makefiles/Main.gmk Changeset: bbb7548d45c7 Author: lana Date: 2013-02-14 22:11 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/bbb7548d45c7 Merge From lana.steuck at oracle.com Wed Feb 20 07:23:05 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 20 Feb 2013 07:23:05 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/corba: Added tag jdk8-b77 for changeset 35684a40c584 Message-ID: <20130220072312.23BB047BDC@hg.openjdk.java.net> Changeset: 27d6368ae8ba Author: katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/27d6368ae8ba Added tag jdk8-b77 for changeset 35684a40c584 ! .hgtags From lana.steuck at oracle.com Wed Feb 20 07:23:08 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 20 Feb 2013 07:23:08 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxp: Added tag jdk8-b77 for changeset 573e789c187a Message-ID: <20130220072325.B1E7847BDD@hg.openjdk.java.net> Changeset: 00958c5a7070 Author: katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/00958c5a7070 Added tag jdk8-b77 for changeset 573e789c187a ! .hgtags From lana.steuck at oracle.com Wed Feb 20 07:23:18 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 20 Feb 2013 07:23:18 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxws: Added tag jdk8-b77 for changeset 64dfba1bad16 Message-ID: <20130220072328.05F2847BDE@hg.openjdk.java.net> Changeset: 391de4c992d1 Author: katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/391de4c992d1 Added tag jdk8-b77 for changeset 64dfba1bad16 ! .hgtags From lana.steuck at oracle.com Wed Feb 20 07:23:26 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 20 Feb 2013 07:23:26 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/langtools: 20 new changesets Message-ID: <20130220072459.C8D4247BDF@hg.openjdk.java.net> Changeset: bc24411bcc37 Author: katleman Date: 2013-02-14 11:44 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/bc24411bcc37 Added tag jdk8-b77 for changeset 89c664151689 ! .hgtags Changeset: de932285124c Author: jjg Date: 2013-02-05 21:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/de932285124c 8007485: test creates .class files in the test/ directory Reviewed-by: mcimadamore ! test/tools/javac/api/8007344/Test.java Changeset: 1df20330f6bd Author: mcimadamore Date: 2013-02-06 14:03 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/1df20330f6bd 8007463: Cleanup inference related classes Summary: Make Infer.InferenceContext an inner class; adjust bound replacement logic in Type.UndetVar Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/util/List.java ! test/tools/javac/generics/inference/7154127/T7154127.out ! test/tools/javac/lib/DPrinter.java Changeset: 8cdd96f2fdb9 Author: mcimadamore Date: 2013-02-06 14:04 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/8cdd96f2fdb9 8007479: Refactor DeferredAttrContext so that it points to parent context Summary: Move DeferredAttrNode out of DeferredAttrContext; add support for nested deferred contexts Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: 153d20d0cac5 Author: jjg Date: 2013-02-06 07:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/153d20d0cac5 8007566: DocLint too aggressive with not allowed here:

Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/Checker.java + test/tools/doclint/ParaTagTest.java Changeset: b386b8c45387 Author: jjh Date: 2013-02-06 23:10 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/b386b8c45387 8007698: jtreg test T6306137.java won't compile with ASCII encoding Reviewed-by: ksrini ! test/tools/javac/api/T6306137.java Changeset: 5125b9854d07 Author: darcy Date: 2013-02-07 20:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/5125b9854d07 7195131: Update 2 compiler combo tests for repeating annotations to include package and default use cases Reviewed-by: darcy Contributed-by: sonali.goel at oracle.com ! test/tools/javac/annotations/repeatingAnnotations/combo/Helper.java + test/tools/javac/annotations/repeatingAnnotations/combo/TargetAnnoCombo.java + test/tools/javac/annotations/repeatingAnnotations/combo/TestCaseGenerator.java Changeset: 762d0af062f5 Author: vromero Date: 2013-02-08 09:12 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/762d0af062f5 7166455: javac doesn't set ACC_STRICT bit on for strictfp class Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/7166455/CheckACC_STRICTFlagOnclinitTest.java Changeset: b1deb90d2e37 Author: vromero Date: 2013-02-08 09:15 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/b1deb90d2e37 8005931: javac doesn't set ACC_STRICT for classes with package access Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/8005931/CheckACC_STRICTFlagOnPkgAccessClassTest.java Changeset: 017e8bdd440f Author: vromero Date: 2013-02-08 09:21 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/017e8bdd440f 7167125: Two variables after the same operation in a inner class return different results Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/7167125/DiffResultAfterSameOperationInnerClasses.java Changeset: 60caf53b98e2 Author: jjg Date: 2013-02-08 17:35 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/60caf53b98e2 8007610: javadoc doclint does not work with -private Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! test/com/sun/javadoc/T6735320/T6735320.java ! test/tools/javadoc/doclint/DocLintTest.java Changeset: 01af1b5c631d Author: darcy Date: 2013-02-11 13:37 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/01af1b5c631d 8007574: Provide isFunctionalInterface in javax.lang.model Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/javax/lang/model/element/TypeElement.java ! src/share/classes/javax/lang/model/util/Elements.java + test/tools/javac/processing/model/util/elements/TestIsFunctionalInterface.java Changeset: 973646bf043a Author: jfranck Date: 2013-02-12 11:28 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/973646bf043a 8004822: RFE to write language model API tests for repeating annotations based on the spec updates Reviewed-by: jjg, abuckley Contributed-by: Matherey Nunez + test/tools/javac/processing/model/element/repeatingAnnotations/ElementRepAnnoTester.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerBasicTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedA1Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedA2Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB1Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB2Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerBasicTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerInheritedA1Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerInheritedA2Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerInheritedB1Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/MixSingularAndUnofficialContainerInheritedB2Test.java + test/tools/javac/processing/model/element/repeatingAnnotations/OfficialContainerBasicTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/OfficialContainerInheritedTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableBasicTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableInheritedTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOfficialContainerBasicTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOfficialContainerInheritedTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideATest.java + test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideBTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/SingularBasicTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/SingularInheritedATest.java + test/tools/javac/processing/model/element/repeatingAnnotations/SingularInheritedBTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/UnofficialContainerBasicTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/UnofficialContainerInheritedTest.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/Bar.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/BarContainer.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/BarContainerContainer.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/BarInherited.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/BarInheritedContainer.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/BarInheritedContainerContainer.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/ExpectedBase.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/ExpectedContainer.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/Foo.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/FooInherited.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/UnofficialContainer.java + test/tools/javac/processing/model/element/repeatingAnnotations/supportingAnnotations/UnofficialInheritedContainer.java Changeset: 073696f59241 Author: vromero Date: 2013-02-12 13:36 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/073696f59241 8006334: javap, JavapTask constructor breaks with null pointer exception if parameter options is null Reviewed-by: jjg ! src/share/classes/com/sun/tools/javap/JavapTask.java + test/tools/javap/8006334/JavapTaskCtorFailWithNPE.java Changeset: 2154ed9ff6c8 Author: mcimadamore Date: 2013-02-12 19:25 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/2154ed9ff6c8 8007464: Add graph inference support Summary: Add support for more aggressive type-inference scheme Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + src/share/classes/com/sun/tools/javac/util/GraphUtils.java ! test/tools/javac/6758789/T6758789b.out ! test/tools/javac/Diagnostics/6799605/T6799605.out ! test/tools/javac/diags/examples/CantApplyDiamond1.java ! test/tools/javac/diags/examples/InferredDoNotConformToEq.java ! test/tools/javac/diags/examples/InferredDoNotConformToUpper.java ! test/tools/javac/diags/examples/WhereFreshTvar.java ! test/tools/javac/generics/7015430/T7015430.out ! test/tools/javac/generics/7151802/T7151802.out ! test/tools/javac/generics/diamond/neg/Neg06.out ! test/tools/javac/generics/inference/6278587/T6278587Neg.java ! test/tools/javac/generics/inference/6638712/T6638712d.out ! test/tools/javac/generics/inference/6638712/T6638712e.out ! test/tools/javac/generics/inference/7154127/T7154127.java ! test/tools/javac/generics/inference/7154127/T7154127.out ! test/tools/javac/generics/inference/7177306/T7177306a.out ! test/tools/javac/generics/inference/7177306/T7177306e.java ! test/tools/javac/generics/inference/7177306/T7177306e.out ! test/tools/javac/generics/odersky/BadTest4.java ! test/tools/javac/lambda/TargetType14.out ! test/tools/javac/lambda/TargetType20.java - test/tools/javac/lambda/TargetType20.out ! test/tools/javac/lambda/TargetType28.out ! test/tools/javac/lambda/TargetType50.java - test/tools/javac/lambda/TargetType50.out ! test/tools/javac/lambda/TargetType51.java ! test/tools/javac/lambda/TargetType52.java ! test/tools/javac/lambda/TargetType52.out + test/tools/javac/lambda/TargetType53.java + test/tools/javac/lambda/TargetType54.java + test/tools/javac/lambda/TargetType55.java + test/tools/javac/lambda/TargetType56.java + test/tools/javac/lambda/TargetType57.java + test/tools/javac/lambda/TargetType57.out + test/tools/javac/lambda/TargetType58.java + test/tools/javac/lambda/TargetType59.java + test/tools/javac/lambda/TargetType61.java + test/tools/javac/lambda/TargetType62.java Changeset: bc456436c613 Author: jjg Date: 2013-02-12 17:15 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/bc456436c613 8008077: update reference impl for type-annotations Reviewed-by: jjg Contributed-by: wmdietl at cs.washington.edu ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/TypeAnnotation.java ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java + test/tools/javac/annotations/typeAnnotations/failures/LazyConstantValue.java + test/tools/javac/annotations/typeAnnotations/failures/TypeVariable.java ! test/tools/javac/annotations/typeAnnotations/failures/VoidGenericMethod.java + test/tools/javac/annotations/typeAnnotations/newlocations/Lambda.java + test/tools/javac/annotations/typeAnnotations/referenceinfos/Lambda.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/MethodParameters.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/TypeCasts.java Changeset: aeadaf905d78 Author: jfranck Date: 2013-02-13 10:33 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/aeadaf905d78 8007279: Rename javax.l.model.element.Element.getAnnotations(Class) to getAnnotationsByType(Class) Reviewed-by: darcy, abuckley ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/javax/lang/model/element/Element.java ! test/tools/javac/processing/model/element/repeatingAnnotations/ElementRepAnnoTester.java Changeset: d04960f05593 Author: mcimadamore Date: 2013-02-13 17:04 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/d04960f05593 8006345: Report Synthesized Parameters in java.lang.reflect.Parameter API 8006896: ClassReader doesn't see MethodParameters attr for method of anon inner class 8007098: Output Synthesized Parameters to MethodParameters Attributes Summary: Correctly report synthesized and mandated parameters Reviewed-by: mcimadamore, jjg Contributed-by: eric.mccorkle at oracle.com ! src/share/classes/com/sun/tools/classfile/AccessFlags.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java Changeset: 3f9875aa5d67 Author: lana Date: 2013-02-13 11:25 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/3f9875aa5d67 Merge Changeset: a3aa32fe4536 Author: lana Date: 2013-02-14 22:11 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/a3aa32fe4536 Merge From lana.steuck at oracle.com Wed Feb 20 07:23:42 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 20 Feb 2013 07:23:42 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/hotspot: 36 new changesets Message-ID: <20130220072520.9689147BE0@hg.openjdk.java.net> Changeset: 1f84c84f8e1a Author: katleman Date: 2013-02-14 11:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1f84c84f8e1a Added tag jdk8-b77 for changeset cdb46031e718 ! .hgtags Changeset: 1a0174612b49 Author: amurillo Date: 2013-02-08 08:16 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1a0174612b49 8007801: new hotspot build - hs25-b19 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 8d9fc28831cc Author: dcubed Date: 2013-02-06 14:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8d9fc28831cc 7182152: Instrumentation hot swap test incorrect monitor count Summary: Add/refine new tracing support using -XX:TraceRedefineClasses=16384. Reviewed-by: coleenp, acorn, sspitsyn ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp ! src/share/vm/prims/jvmtiRedefineClassesTrace.hpp ! src/share/vm/utilities/accessFlags.cpp ! src/share/vm/utilities/accessFlags.hpp Changeset: 3a88007634b0 Author: ctornqvi Date: 2013-02-08 10:42 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/3a88007634b0 8007434: Write tests for 8006298 Summary: Four tests written for 8006298 Reviewed-by: mgerdin, coleenp + test/runtime/CommandLine/BooleanFlagWithInvalidValue.java + test/runtime/CommandLine/FlagWithInvalidValue.java + test/runtime/CommandLine/NonBooleanFlagWithInvalidBooleanPrefix.java + test/runtime/CommandLine/UnrecognizedVMOption.java Changeset: 758935f7c23f Author: sla Date: 2013-02-08 12:48 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/758935f7c23f 8006423: SA: NullPointerException in sun.jvm.hotspot.debugger.bsd.BsdThread.getContext(BsdThread.java:67) Summary: Do not rely on mach thread port names to identify threads from SA Reviewed-by: dholmes, minqi, rbackman ! agent/src/os/bsd/MacosxDebuggerLocal.m ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThread.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/bsd_amd64/BsdAMD64JavaThreadPDAccess.java ! src/os/bsd/vm/osThread_bsd.hpp ! src/os/bsd/vm/os_bsd.cpp ! src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp Changeset: 7194f764221c Author: sla Date: 2013-02-08 14:05 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/7194f764221c Merge Changeset: 461a3adac4d1 Author: sspitsyn Date: 2013-02-08 09:14 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/461a3adac4d1 Merge ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp Changeset: 8bf62bd86a4e Author: zgu Date: 2013-02-08 14:49 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8bf62bd86a4e 8007791: More Restricted hs_err file permission Summary: Enforce more restricted hs_file permission Reviewed-by: acorn, dcubed, dsamersoff ! src/share/vm/utilities/vmError.cpp Changeset: 1ba5b18088a8 Author: zgu Date: 2013-02-08 14:32 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1ba5b18088a8 Merge Changeset: 41d73c9b30a8 Author: zgu Date: 2013-02-08 16:31 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/41d73c9b30a8 8006691: Remove jvm_version_info.is_kernel_jvm field Summary: Removed is_kernel_jvm from jvm_version_info as Kernel VM has been deprecated Reviewed-by: mchung, coleenp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h Changeset: 3f11b37f047c Author: zgu Date: 2013-02-08 13:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/3f11b37f047c Merge Changeset: f989aff6946f Author: zgu Date: 2013-02-08 16:56 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f989aff6946f Merge Changeset: 927a311d00f9 Author: coleenp Date: 2013-02-11 14:06 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/927a311d00f9 8007320: NPG: move method annotations Summary: allocate method annotations and attach to ConstMethod if present Reviewed-by: dcubed, jiangli, sspitsyn, iklam ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/oops/annotations.cpp ! src/share/vm/oops/annotations.hpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/vmStructs.cpp + test/runtime/8007320/ConstMethodTest.java Changeset: 5ee2b330eacd Author: zgu Date: 2013-02-12 12:19 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5ee2b330eacd 8007950: Undo hs_file permission change Summary: Reverse hs_err file permission back to 0666, as early push was premature Reviewed-by: dsamersoff, dcubed, acorn ! src/share/vm/utilities/vmError.cpp Changeset: deb43b8a436e Author: sspitsyn Date: 2013-02-13 08:42 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/deb43b8a436e Merge Changeset: bce1ac447f6b Author: johnc Date: 2013-02-06 14:50 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/bce1ac447f6b 7052429: G1: Avoid unnecessary scanning of humongous regions during concurrent marking Summary: Skip unnecessary scanning of bitmap for unmarked humongous objects/regions. Reviewed-by: jwilhelm, johnc Contributed-by: Tao Mao ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/runtime/globals.hpp Changeset: f64ffbf81af5 Author: jwilhelm Date: 2013-02-07 15:51 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f64ffbf81af5 8006432: Ratio flags should be unsigned Summary: Flags changed to be of uintx type Reviewed-by: johnc, tamao ! src/cpu/zero/vm/shark_globals_zero.hpp ! src/os_cpu/bsd_x86/vm/globals_bsd_x86.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 5d8325eb8240 Author: brutisso Date: 2013-02-07 22:04 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5d8325eb8240 Merge ! src/share/vm/runtime/thread.cpp Changeset: 9425ba04792d Author: brutisso Date: 2013-02-07 18:40 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/9425ba04792d Merge - agent/src/share/classes/sun/jvm/hotspot/memory/BinaryTreeDictionary.java - make/solaris/makefiles/kernel.make ! src/share/vm/runtime/arguments.cpp - test/runtime/7158988/TestFieldMonitor.sh Changeset: ad747ee9d0b1 Author: brutisso Date: 2013-02-10 21:15 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ad747ee9d0b1 8002144: G1: large number of evacuation failures may lead to large c heap memory usage Summary: Use Stack<> instead of GrowableArray to keep track of preserved marks. Also reviewed by vitalyd at gmail.com. Reviewed-by: johnc, jcoomes ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Changeset: 5e401ef52ec0 Author: johnc Date: 2013-02-11 15:24 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5e401ef52ec0 8007772: G1: assert(!hr->isHumongous() || mr.start() == hr->bottom()) failed: the start of HeapRegion and MemRegion should be consistent for humongous regions Summary: In do_marking_step(), we should always give up current region after scanning the object, if the region is humongous. Reviewed-by: brutisso, jwilhelm, tamao ! src/share/vm/gc_implementation/g1/concurrentMark.cpp Changeset: a83cd101fd62 Author: jmasa Date: 2013-01-23 19:08 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/a83cd101fd62 8005452: NPG: Create new flags for Metaspace resizing policy Reviewed-by: johnc, jwilhelm, coleenp, stefank ! src/share/vm/memory/metaspace.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: b8d5d7a6c94c Author: brutisso Date: 2013-02-14 11:01 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b8d5d7a6c94c Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/thread.cpp Changeset: 91a23b11d8dc Author: kvn Date: 2013-02-08 15:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/91a23b11d8dc 8007708: compiler/6855215 assert(VM_Version::supports_sse4_2()) Summary: Added missing UseSSE42 check. Also added missing avx2 assert for vpermq instruction. Reviewed-by: roland, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp Changeset: 309460dcedf7 Author: morris Date: 2013-02-08 15:39 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/309460dcedf7 8006851: When TieredCompilation is set, max code cache should be bumped to 256mb Summary: Set ReservedCodeCacheSize to (default value)*5 when TieredCompilation is on. Reviewed-by: kvn, twisti ! src/share/vm/runtime/arguments.cpp Changeset: 2c673161698a Author: drchase Date: 2013-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/2c673161698a 8007402: Code cleanup to remove Parfait false positive Summary: add array access range check Reviewed-by: kvn ! src/share/vm/opto/regmask.cpp ! src/share/vm/opto/regmask.hpp Changeset: 64d2a0a39954 Author: kmo Date: 2013-02-10 22:35 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/64d2a0a39954 8006430: TraceTypeProfile is a product flag while it should be a diagnostic flag Summary: make sure all diagnostic and experimental flag kinds are checked in Flag::is_unlocked() Reviewed-by: kvn ! src/share/vm/runtime/globals.cpp Changeset: a9c29dfc7d73 Author: morris Date: 2013-02-11 10:38 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/a9c29dfc7d73 8003251: ARM: move MacroAssembler into separate file Summary: moved MacroAssembler into separate file Reviewed-by: twisti, kvn, dlong ! src/share/vm/asm/macroAssembler.hpp ! src/share/vm/asm/macroAssembler.inline.hpp Changeset: 1e5e28bac299 Author: morris Date: 2013-02-11 14:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1e5e28bac299 8003252: PPC: move MacroAssembler into separate file Summary: moved MacroAssembler into separate file Reviewed-by: twisti, kvn, dlong ! src/share/vm/asm/macroAssembler.hpp ! src/share/vm/asm/macroAssembler.inline.hpp Changeset: 8b3da8d14c93 Author: roland Date: 2013-02-12 12:56 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8b3da8d14c93 7197327: 40% regression on 8 b41 comp 8 b40 on specjvm2008.mpegaudio on oob Summary: Add support for expensive nodes. Reviewed-by: kvn ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/subnode.hpp Changeset: c703f9c4b025 Author: kmo Date: 2013-02-12 07:39 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c703f9c4b025 8002169: TEST_BUG: compiler/7009359/Test7009359.java sometimes times out Summary: make the test less prone to timeout by reducing the amount of iteration and allowing main to be compiled Reviewed-by: jrose ! test/compiler/7009359/Test7009359.java Changeset: aaad39923cdb Author: kmo Date: 2013-02-12 14:33 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/aaad39923cdb Merge Changeset: 12e01444ca2d Author: iignatyev Date: 2013-02-13 08:29 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/12e01444ca2d 8006683: Add WhiteBox API to testing of compiler Reviewed-by: kvn, vlivanov ! src/share/tools/whitebox/sun/hotspot/WhiteBox.java ! src/share/vm/prims/wbtestmethods/parserTests.hpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/prims/whitebox.hpp + test/compiler/whitebox/CompilerWhiteBoxTest.java + test/compiler/whitebox/DeoptimizeAllTest.java + test/compiler/whitebox/DeoptimizeMethodTest.java + test/compiler/whitebox/IsMethodCompilableTest.java + test/compiler/whitebox/MakeMethodNotCompilableTest.java + test/compiler/whitebox/SetDontInlineMethodTest.java Changeset: 1cdf241a4b26 Author: vlivanov Date: 2013-02-14 05:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1cdf241a4b26 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 9f19f4a7d48a Author: amurillo Date: 2013-02-15 13:27 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/9f19f4a7d48a Merge Changeset: d5e12e7d2f71 Author: amurillo Date: 2013-02-15 13:27 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d5e12e7d2f71 Added tag hs25-b19 for changeset 9f19f4a7d48a ! .hgtags From lana.steuck at oracle.com Wed Feb 20 07:24:39 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 20 Feb 2013 07:24:39 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 43 new changesets Message-ID: <20130220073313.E4B3347BE2@hg.openjdk.java.net> Changeset: c1304eb051f6 Author: katleman Date: 2013-02-14 11:44 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c1304eb051f6 Added tag jdk8-b77 for changeset b2fc8e31cecc ! .hgtags Changeset: ac89a5d71466 Author: alexsch Date: 2013-02-06 18:25 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ac89a5d71466 8000326: Focus unable to traverse in the menubar Reviewed-by: alexsch, malenkov ! src/share/classes/javax/swing/JMenuBar.java Changeset: 6e17465f4a1a Author: mcherkas Date: 2013-02-08 22:08 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6e17465f4a1a 8005932: Java 7 on mac os x only provides text clipboard formats Reviewed-by: alexp, denis ! src/macosx/lib/flavormap.properties + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/AbsoluteComponentCenterCalculator.java + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/DataFlavorSearcher.java + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/InterprocessMessages.java + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/MyTransferable.java + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/NextFramePositionCalculator.java + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/SourcePanel.java + test/java/awt/DataFlavor/MissedHtmlAndRtfBug/TargetPanel.java Changeset: 5406c4e381e2 Author: kshefov Date: 2013-02-13 18:01 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5406c4e381e2 7161759: TEST_BUG: java/awt/Frame/WindowDragTest/WindowDragTest.java fails to compile, should be modified Summary: Added @build Util jtreg tag Reviewed-by: serb, alexsch Contributed-by: Vera Akulova ! test/java/awt/Frame/WindowDragTest/WindowDragTest.java Changeset: dd6cf41a6953 Author: kshefov Date: 2013-02-13 19:06 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/dd6cf41a6953 7132383: [macosx] bug6596966.java should be adapted for Mac Reviewed-by: serb, alexsch Contributed-by: Vera Akulova ! test/javax/swing/JLabel/6596966/bug6596966.java ! test/javax/swing/regtesthelpers/Util.java Changeset: caec64340f42 Author: vkarnauk Date: 2013-02-13 19:23 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/caec64340f42 4199622: RFE: JComboBox shouldn't sending ActionEvents for keyboard navigation Reviewed-by: alexp, alexsch ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java ! src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java + test/javax/swing/JComboBox/4199622/bug4199622.java Changeset: 4d9691e95e05 Author: pchelko Date: 2013-02-13 15:27 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4d9691e95e05 7079260: InputContext leaks memory Summary: Replaced strong refs with weak refs Reviewed-by: art, serb ! src/share/classes/sun/awt/im/CompositionAreaHandler.java ! src/solaris/classes/sun/awt/X11InputMethod.java + test/java/awt/im/memoryleak/InputContextMemoryLeakTest.java ! test/java/awt/regtesthelpers/Util.java Changeset: c552cde0e3f9 Author: pchelko Date: 2013-02-13 15:32 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c552cde0e3f9 8005629: javac warnings compiling java.awt.EventDispatchThread and sun.awt.X11.XIconWindow Summary: Removed macosx specific workaround from shared code and made macosx use public API Reviewed-by: art, serb ! src/macosx/classes/sun/lwawt/macosx/CPrinterJob.java - src/macosx/classes/sun/lwawt/macosx/EventDispatchAccess.java ! src/macosx/native/sun/awt/CPrinterJob.m ! src/share/classes/java/awt/EventDispatchThread.java ! src/solaris/classes/sun/awt/X11/XIconWindow.java Changeset: c95dc15ac183 Author: lana Date: 2013-02-13 12:38 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c95dc15ac183 Merge - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java Changeset: c9efb349b391 Author: lana Date: 2013-02-13 17:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c9efb349b391 Merge - src/macosx/classes/sun/lwawt/macosx/EventDispatchAccess.java Changeset: 0e7d5dd84fdf Author: dsamersoff Date: 2013-02-06 16:53 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0e7d5dd84fdf 8007277: JDK-8002048 testcase fails to compile Summary: sun.* classes is not included to ct.sym file and symbol file have to be ignored Reviewed-by: alanb ! test/sun/management/jdp/JdpTest.sh Changeset: 1574fa3df1c0 Author: lancea Date: 2013-02-06 14:15 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1574fa3df1c0 8006505: additional changes for JSR 310 support Reviewed-by: naoto, ulfzibis ! src/share/classes/java/sql/JDBCType.java ! src/share/classes/java/sql/SQLInput.java ! src/share/classes/java/sql/SQLOutput.java ! src/share/classes/java/sql/Types.java Changeset: 2f1505c49e79 Author: martin Date: 2013-02-06 17:59 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2f1505c49e79 8006995: java launcher fails to open executable JAR > 2GB Summary: Use O_LARGEFILE consistently when opening jar files Reviewed-by: alanb, sherman ! src/share/bin/parse_manifest.c Changeset: 2de8c6c2d652 Author: ykantser Date: 2013-02-07 11:22 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2de8c6c2d652 8007142: Add utility classes for writing better multiprocess tests in jtreg Reviewed-by: alanb, rbackman + test/lib/testlibrary/OutputAnalyzerTest.java + test/lib/testlibrary/jdk/testlibrary/JcmdBase.java + test/lib/testlibrary/jdk/testlibrary/JdkFinder.java + test/lib/testlibrary/jdk/testlibrary/OutputAnalyzer.java + test/lib/testlibrary/jdk/testlibrary/OutputBuffer.java + test/lib/testlibrary/jdk/testlibrary/ProcessTools.java + test/lib/testlibrary/jdk/testlibrary/StreamPumper.java Changeset: 79d7595abe95 Author: naoto Date: 2013-02-08 09:35 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/79d7595abe95 8007038: ArrayIndexOutOfBoundsException on calling localizedDateTime().print() with JapaneseChrono Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java + test/java/util/Calendar/Bug8007038.java Changeset: 522fb3867a3a Author: darcy Date: 2013-02-08 16:00 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/522fb3867a3a 8005623: Retrofit FunctionalInterface annotations to core platform interfaces Reviewed-by: mduigou, chegar, alanb ! src/share/classes/java/io/Closeable.java ! src/share/classes/java/io/FileFilter.java ! src/share/classes/java/io/FilenameFilter.java ! src/share/classes/java/io/Flushable.java ! src/share/classes/java/lang/AutoCloseable.java ! src/share/classes/java/lang/Comparable.java ! src/share/classes/java/lang/Iterable.java ! src/share/classes/java/lang/Readable.java ! src/share/classes/java/lang/Runnable.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/nio/file/DirectoryStream.java ! src/share/classes/java/nio/file/PathMatcher.java ! src/share/classes/java/util/Comparator.java ! src/share/classes/java/util/function/BinaryOperator.java ! src/share/classes/java/util/function/Block.java ! src/share/classes/java/util/function/DoubleBinaryOperator.java ! src/share/classes/java/util/function/DoubleBlock.java ! src/share/classes/java/util/function/DoubleFunction.java ! src/share/classes/java/util/function/DoubleSupplier.java ! src/share/classes/java/util/function/DoubleUnaryOperator.java ! src/share/classes/java/util/function/Function.java ! src/share/classes/java/util/function/IntBinaryOperator.java ! src/share/classes/java/util/function/IntBlock.java ! src/share/classes/java/util/function/IntFunction.java ! src/share/classes/java/util/function/IntSupplier.java ! src/share/classes/java/util/function/IntUnaryOperator.java ! src/share/classes/java/util/function/LongBinaryOperator.java ! src/share/classes/java/util/function/LongBlock.java ! src/share/classes/java/util/function/LongFunction.java ! src/share/classes/java/util/function/LongSupplier.java ! src/share/classes/java/util/function/LongUnaryOperator.java ! src/share/classes/java/util/function/Predicate.java ! src/share/classes/java/util/function/Supplier.java ! src/share/classes/java/util/function/UnaryOperator.java ! src/share/classes/java/util/logging/Filter.java ! src/share/classes/java/util/prefs/PreferenceChangeListener.java Changeset: 36d25dc2b8f0 Author: dl Date: 2013-02-09 08:35 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/36d25dc2b8f0 8005697: Add StampedLock Reviewed-by: chegar, alanb, dice, martin ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/concurrent/locks/LockSupport.java + src/share/classes/java/util/concurrent/locks/StampedLock.java + test/java/util/concurrent/locks/StampedLock/Basic.java Changeset: d14cd2272b2d Author: weijun Date: 2013-02-09 16:43 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d14cd2272b2d 8001104: Unbound SASL service: the GSSAPI/krb5 mech Reviewed-by: valeriep ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java ! src/share/classes/javax/security/auth/kerberos/JavaxSecurityAuthKerberosAccessImpl.java ! src/share/classes/javax/security/auth/kerberos/KeyTab.java ! src/share/classes/sun/security/jgss/LoginConfigImpl.java ! src/share/classes/sun/security/jgss/krb5/Krb5Util.java ! src/share/classes/sun/security/jgss/krb5/ServiceCreds.java ! src/share/classes/sun/security/jgss/krb5/SubjectComber.java ! src/share/classes/sun/security/krb5/JavaxSecurityAuthKerberosAccess.java ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/share/classes/sun/security/provider/ConfigSpiFile.java ! test/sun/security/krb5/ServiceCredsCombination.java ! test/sun/security/krb5/auto/AcceptPermissions.java + test/sun/security/krb5/auto/GSSUnbound.java ! test/sun/security/krb5/auto/OneKDC.java + test/sun/security/krb5/auto/SaslUnbound.java + test/sun/security/krb5/auto/UnboundService.java Changeset: 57cb988c811e Author: weijun Date: 2013-02-09 16:43 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/57cb988c811e 8007761: NTLM coding errors Reviewed-by: chegar ! src/share/classes/com/sun/security/ntlm/Client.java ! src/share/classes/com/sun/security/ntlm/NTLM.java Changeset: 58c95d0b6b1a Author: ksrini Date: 2013-02-10 08:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/58c95d0b6b1a 8007519: [unpack200] produces bad class files when producing BootstrapMethods attribute Reviewed-by: alanb ! test/ProblemList.txt Changeset: 520a3433883d Author: ksrini Date: 2013-02-10 08:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/520a3433883d 8007902: [unpack200] incorrect BootstrapMethods attribute Reviewed-by: jjh ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! test/tools/pack200/Pack200Test.java ! test/tools/pack200/pack200-verifier/data/golden.jar Changeset: 1df991184045 Author: dsamersoff Date: 2013-02-11 18:44 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1df991184045 8007536: Incorrect copyright header in JDP files Summary: Copyright header in JDP files missed the "classpath exception" rule. Reviewed-by: mikael ! src/share/classes/sun/management/jdp/JdpBroadcaster.java ! src/share/classes/sun/management/jdp/JdpController.java ! src/share/classes/sun/management/jdp/JdpException.java ! src/share/classes/sun/management/jdp/JdpGenericPacket.java ! src/share/classes/sun/management/jdp/JdpJmxPacket.java ! src/share/classes/sun/management/jdp/JdpPacket.java ! src/share/classes/sun/management/jdp/JdpPacketReader.java ! src/share/classes/sun/management/jdp/JdpPacketWriter.java ! src/share/classes/sun/management/jdp/package-info.java Changeset: abd530253f01 Author: dcubed Date: 2013-02-11 10:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/abd530253f01 8007420: add test for 6805864 to com/sun/jdi, add test for 7182152 to java/lang/instrument Reviewed-by: coleenp, sspitsyn + test/com/sun/jdi/RedefineAbstractClass.sh + test/java/lang/instrument/RedefineSubclassWithTwoInterfaces.sh + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesAgent.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesApp.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesImpl.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesImpl_1.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesIntf1.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesIntf2.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesRemote.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesTarget.java + test/java/lang/instrument/RedefineSubclassWithTwoInterfacesTarget_1.java Changeset: f21a4b761424 Author: alanb Date: 2013-02-11 20:16 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f21a4b761424 8007405: Update java.lang.reflect API to replace SYNTHESIZED with MANDATED Reviewed-by: darcy ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Modifier.java ! src/share/classes/java/lang/reflect/Parameter.java Changeset: 465cce29a9ed Author: mduigou Date: 2013-02-06 11:28 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/465cce29a9ed 8006594: Add jdk_core target to jdk/test/Makefile Reviewed-by: alanb ! make/jprt.properties ! test/Makefile ! test/ProblemList.txt Changeset: f7fb173ac833 Author: dsamersoff Date: 2013-02-12 16:02 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f7fb173ac833 8007786: JDK-8002048 testcase doesn't work on Solaris Summary: test built in into Solaris shell doesn't have -e operator Reviewed-by: sla, sspitsyn ! test/sun/management/jdp/JdpTest.sh Changeset: 7dcb74c3ffba Author: sherman Date: 2013-02-12 09:25 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7dcb74c3ffba 8007392: JSR 310: DateTime API Updates 8007520: Update date/time classes in j.util and j.sql packages 8007572: Replace existing jdk timezone data at /lib/zi with JSR310's tzdb Summary: Integration of JSR310 Date/Time API for M7 Reviewed-by: darcy, alanb, naoto Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, masayoshi.okutsu at oracle.com, patrick.zhang at oracle.com ! make/docs/CORE_PKGS.gmk ! make/java/java/FILES_java.gmk ! make/sun/Makefile ! make/sun/javazic/Makefile + make/sun/javazic/tzdata/gmt + make/sun/javazic/tzdata/jdk11_backward ! make/sun/tzdb/Makefile ! make/tools/Makefile ! make/tools/src/build/tools/javazic/Zoneinfo.java ! make/tools/src/build/tools/tzdb/TzdbZoneRulesCompiler.java ! makefiles/GendataTZDB.gmk ! makefiles/GendataTimeZone.gmk ! makefiles/GenerateData.gmk ! makefiles/Tools.gmk ! src/share/classes/java/sql/Date.java ! src/share/classes/java/sql/Time.java ! src/share/classes/java/sql/Timestamp.java ! src/share/classes/java/time/Clock.java ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java + src/share/classes/java/time/MonthDay.java + src/share/classes/java/time/OffsetDateTime.java + src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java - src/share/classes/java/time/PeriodParser.java ! src/share/classes/java/time/Ser.java + src/share/classes/java/time/Year.java + src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java - src/share/classes/java/time/calendar/ChronoDateImpl.java - src/share/classes/java/time/calendar/HijrahChrono.java - src/share/classes/java/time/calendar/HijrahDate.java - src/share/classes/java/time/calendar/HijrahDeviationReader.java - src/share/classes/java/time/calendar/HijrahEra.java - src/share/classes/java/time/calendar/JapaneseChrono.java - src/share/classes/java/time/calendar/JapaneseDate.java - src/share/classes/java/time/calendar/JapaneseEra.java - src/share/classes/java/time/calendar/MinguoChrono.java - src/share/classes/java/time/calendar/MinguoDate.java - src/share/classes/java/time/calendar/MinguoEra.java - src/share/classes/java/time/calendar/Ser.java - src/share/classes/java/time/calendar/ThaiBuddhistChrono.java - src/share/classes/java/time/calendar/ThaiBuddhistDate.java - src/share/classes/java/time/calendar/ThaiBuddhistEra.java - src/share/classes/java/time/calendar/package-info.java + src/share/classes/java/time/chrono/ChronoDateImpl.java + src/share/classes/java/time/chrono/ChronoLocalDate.java + src/share/classes/java/time/chrono/ChronoLocalDateTime.java + src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java + src/share/classes/java/time/chrono/ChronoZonedDateTime.java + src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java + src/share/classes/java/time/chrono/Chronology.java + src/share/classes/java/time/chrono/Era.java + src/share/classes/java/time/chrono/HijrahChronology.java + src/share/classes/java/time/chrono/HijrahDate.java + src/share/classes/java/time/chrono/HijrahDeviationReader.java + src/share/classes/java/time/chrono/HijrahEra.java + src/share/classes/java/time/chrono/IsoChronology.java + src/share/classes/java/time/chrono/IsoEra.java + src/share/classes/java/time/chrono/JapaneseChronology.java + src/share/classes/java/time/chrono/JapaneseDate.java + src/share/classes/java/time/chrono/JapaneseEra.java + src/share/classes/java/time/chrono/MinguoChronology.java + src/share/classes/java/time/chrono/MinguoDate.java + src/share/classes/java/time/chrono/MinguoEra.java + src/share/classes/java/time/chrono/Ser.java + src/share/classes/java/time/chrono/ThaiBuddhistChronology.java + src/share/classes/java/time/chrono/ThaiBuddhistDate.java + src/share/classes/java/time/chrono/ThaiBuddhistEra.java + src/share/classes/java/time/chrono/package-info.java ! src/share/classes/java/time/format/DateTimeBuilder.java ! src/share/classes/java/time/format/DateTimeFormatStyleProvider.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java - src/share/classes/java/time/format/DateTimeFormatters.java ! src/share/classes/java/time/format/DateTimeParseContext.java ! src/share/classes/java/time/format/DateTimePrintContext.java - src/share/classes/java/time/format/DateTimePrintException.java ! src/share/classes/java/time/format/DateTimeTextProvider.java ! src/share/classes/java/time/format/FormatStyle.java + src/share/classes/java/time/format/ZoneName.java ! src/share/classes/java/time/format/package-info.java ! src/share/classes/java/time/overview.html ! src/share/classes/java/time/package-info.java - src/share/classes/java/time/temporal/Chrono.java ! src/share/classes/java/time/temporal/ChronoField.java - src/share/classes/java/time/temporal/ChronoLocalDate.java - src/share/classes/java/time/temporal/ChronoLocalDateTime.java - src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/temporal/ChronoUnit.java - src/share/classes/java/time/temporal/ChronoZonedDateTime.java - src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/java/time/temporal/Era.java - src/share/classes/java/time/temporal/ISOChrono.java - src/share/classes/java/time/temporal/ISOEra.java - src/share/classes/java/time/temporal/ISOFields.java + src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java - src/share/classes/java/time/temporal/MonthDay.java - src/share/classes/java/time/temporal/OffsetDate.java - src/share/classes/java/time/temporal/OffsetDateTime.java - src/share/classes/java/time/temporal/OffsetTime.java ! src/share/classes/java/time/temporal/Queries.java - src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/SimplePeriod.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java - src/share/classes/java/time/temporal/TemporalAdder.java ! src/share/classes/java/time/temporal/TemporalAdjuster.java + src/share/classes/java/time/temporal/TemporalAmount.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalQuery.java - src/share/classes/java/time/temporal/TemporalSubtractor.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/WeekFields.java - src/share/classes/java/time/temporal/Year.java - src/share/classes/java/time/temporal/YearMonth.java ! src/share/classes/java/time/temporal/package-info.java ! src/share/classes/java/time/zone/TzdbZoneRulesProvider.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java ! src/share/classes/java/time/zone/ZoneRulesProvider.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/Date.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/sun/text/resources/FormatData.java ! src/share/classes/sun/text/resources/ar/FormatData_ar.java ! src/share/classes/sun/text/resources/el/FormatData_el.java ! src/share/classes/sun/text/resources/hr/FormatData_hr.java ! src/share/classes/sun/text/resources/ja/FormatData_ja.java ! src/share/classes/sun/text/resources/ko/FormatData_ko.java ! src/share/classes/sun/text/resources/sr/FormatData_sr.java ! src/share/classes/sun/text/resources/sv/FormatData_sv.java ! src/share/classes/sun/text/resources/zh/FormatData_zh.java ! src/share/classes/sun/text/resources/zh/FormatData_zh_TW.java ! src/share/classes/sun/util/calendar/CalendarSystem.java ! src/share/classes/sun/util/calendar/LocalGregorianCalendar.java - src/share/classes/sun/util/calendar/TzIDOldMapping.java ! src/share/classes/sun/util/calendar/ZoneInfo.java ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java + test/java/sql/JavatimeTest.java + test/java/time/META-INF/services/java.time.chrono.Chronology - test/java/time/META-INF/services/java.time.temporal.Chrono ! test/java/time/tck/java/time/AbstractTCKTest.java + test/java/time/tck/java/time/MockSimplePeriod.java ! test/java/time/tck/java/time/TCKClock.java ! test/java/time/tck/java/time/TCKClock_Fixed.java ! test/java/time/tck/java/time/TCKClock_Offset.java ! test/java/time/tck/java/time/TCKClock_System.java ! test/java/time/tck/java/time/TCKClock_Tick.java ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKDuration.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKMonth.java + test/java/time/tck/java/time/TCKMonthDay.java + test/java/time/tck/java/time/TCKOffsetDateTime.java + test/java/time/tck/java/time/TCKOffsetTime.java + test/java/time/tck/java/time/TCKPeriod.java + test/java/time/tck/java/time/TCKYear.java + test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneId.java ! test/java/time/tck/java/time/TCKZoneOffset.java ! test/java/time/tck/java/time/TCKZonedDateTime.java + test/java/time/tck/java/time/TestChronology.java + test/java/time/tck/java/time/TestIsoChronology.java - test/java/time/tck/java/time/calendar/CopticChrono.java - test/java/time/tck/java/time/calendar/CopticDate.java - test/java/time/tck/java/time/calendar/CopticEra.java - test/java/time/tck/java/time/calendar/TestChronoLocalDate.java - test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java - test/java/time/tck/java/time/calendar/TestHijrahChrono.java - test/java/time/tck/java/time/calendar/TestJapaneseChrono.java - test/java/time/tck/java/time/calendar/TestMinguoChrono.java - test/java/time/tck/java/time/calendar/TestServiceLoader.java - test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java + test/java/time/tck/java/time/chrono/CopticChronology.java + test/java/time/tck/java/time/chrono/CopticDate.java + test/java/time/tck/java/time/chrono/CopticEra.java + test/java/time/tck/java/time/chrono/TCKChronology.java + test/java/time/tck/java/time/chrono/TCKTestServiceLoader.java + test/java/time/tck/java/time/chrono/TestChronoLocalDate.java + test/java/time/tck/java/time/chrono/TestChronoLocalDateTime.java + test/java/time/tck/java/time/chrono/TestHijrahChronology.java + test/java/time/tck/java/time/chrono/TestJapaneseChronology.java + test/java/time/tck/java/time/chrono/TestMinguoChronology.java + test/java/time/tck/java/time/chrono/TestThaiBuddhistChronology.java + test/java/time/tck/java/time/format/TCKChronoPrinterParser.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatter.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java ! test/java/time/tck/java/time/format/TCKDateTimeFormatters.java - test/java/time/tck/java/time/format/TCKDateTimePrintException.java ! test/java/time/tck/java/time/format/TCKDateTimeTextPrinting.java ! test/java/time/tck/java/time/format/TCKLocalizedFieldParser.java ! test/java/time/tck/java/time/format/TCKLocalizedFieldPrinter.java + test/java/time/tck/java/time/format/TCKLocalizedPrinterParser.java + test/java/time/tck/java/time/format/TCKOffsetPrinterParser.java + test/java/time/tck/java/time/format/TCKPadPrinterParser.java + test/java/time/tck/java/time/format/TCKZoneIdPrinterParser.java - test/java/time/tck/java/time/temporal/TCKISOFields.java + test/java/time/tck/java/time/temporal/TCKIsoFields.java ! test/java/time/tck/java/time/temporal/TCKJulianFields.java - test/java/time/tck/java/time/temporal/TCKMonthDay.java - test/java/time/tck/java/time/temporal/TCKOffsetDate.java - test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java - test/java/time/tck/java/time/temporal/TCKOffsetTime.java - test/java/time/tck/java/time/temporal/TCKSimplePeriod.java ! test/java/time/tck/java/time/temporal/TCKWeekFields.java - test/java/time/tck/java/time/temporal/TCKYear.java - test/java/time/tck/java/time/temporal/TCKYearMonth.java - test/java/time/tck/java/time/temporal/TestChrono.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDate.java ! test/java/time/tck/java/time/temporal/TestChronoLocalDateTime.java ! test/java/time/tck/java/time/temporal/TestChronoZonedDateTime.java - test/java/time/tck/java/time/temporal/TestISOChrono.java ! test/java/time/tck/java/time/zone/TCKFixedZoneRules.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransition.java ! test/java/time/tck/java/time/zone/TCKZoneOffsetTransitionRule.java ! test/java/time/tck/java/time/zone/TCKZoneRules.java ! test/java/time/tck/java/time/zone/TCKZoneRulesProvider.java ! test/java/time/test/java/time/MockSimplePeriod.java ! test/java/time/test/java/time/TestDuration.java ! test/java/time/test/java/time/TestLocalDateTime.java ! test/java/time/test/java/time/TestLocalTime.java + test/java/time/test/java/time/TestMonthDay.java + test/java/time/test/java/time/TestOffsetDateTime.java + test/java/time/test/java/time/TestOffsetDateTime_instants.java + test/java/time/test/java/time/TestOffsetTime.java ! test/java/time/test/java/time/TestPeriod.java - test/java/time/test/java/time/TestPeriodParser.java + test/java/time/test/java/time/TestYear.java + test/java/time/test/java/time/TestYearMonth.java ! test/java/time/test/java/time/TestZoneId.java + test/java/time/test/java/time/chrono/TestExampleCode.java + test/java/time/test/java/time/chrono/TestIsoChronoImpl.java + test/java/time/test/java/time/chrono/TestServiceLoader.java ! test/java/time/test/java/time/format/TestCharLiteralParser.java ! test/java/time/test/java/time/format/TestCharLiteralPrinter.java + test/java/time/test/java/time/format/TestDateTimeFormatterBuilder.java - test/java/time/test/java/time/format/TestDateTimeFormatters.java - test/java/time/test/java/time/format/TestDateTimePrintException.java ! test/java/time/test/java/time/format/TestDateTimeTextProvider.java ! test/java/time/test/java/time/format/TestFractionPrinterParser.java + test/java/time/test/java/time/format/TestNonIsoFormatter.java ! test/java/time/test/java/time/format/TestNumberParser.java ! test/java/time/test/java/time/format/TestNumberPrinter.java - test/java/time/test/java/time/format/TestPadParserDecorator.java ! test/java/time/test/java/time/format/TestPadPrinterDecorator.java ! test/java/time/test/java/time/format/TestReducedParser.java ! test/java/time/test/java/time/format/TestReducedPrinter.java ! test/java/time/test/java/time/format/TestSettingsParser.java ! test/java/time/test/java/time/format/TestStringLiteralParser.java ! test/java/time/test/java/time/format/TestStringLiteralPrinter.java ! test/java/time/test/java/time/format/TestTextParser.java ! test/java/time/test/java/time/format/TestTextPrinter.java - test/java/time/test/java/time/format/TestZoneIdParser.java ! test/java/time/test/java/time/format/TestZoneOffsetParser.java ! test/java/time/test/java/time/format/TestZoneOffsetPrinter.java ! test/java/time/test/java/time/format/TestZoneTextPrinterParser.java + test/java/time/test/java/time/format/ZoneName.java ! test/java/time/test/java/time/temporal/MockFieldNoValue.java ! test/java/time/test/java/time/temporal/MockFieldValue.java ! test/java/time/test/java/time/temporal/TestChronoUnit.java ! test/java/time/test/java/time/temporal/TestDateTimeBuilderCombinations.java - test/java/time/test/java/time/temporal/TestISOChronoImpl.java ! test/java/time/test/java/time/temporal/TestJapaneseChronoImpl.java + test/java/time/test/java/time/temporal/TestJulianFields.java - test/java/time/test/java/time/temporal/TestMonthDay.java - test/java/time/test/java/time/temporal/TestOffsetDate.java - test/java/time/test/java/time/temporal/TestOffsetDateTime.java - test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java - test/java/time/test/java/time/temporal/TestOffsetTime.java ! test/java/time/test/java/time/temporal/TestThaiBuddhistChronoImpl.java - test/java/time/test/java/time/temporal/TestYear.java - test/java/time/test/java/time/temporal/TestYearMonth.java ! test/java/time/test/java/time/zone/TestFixedZoneRules.java ! test/java/time/test/java/util/TestFormatter.java + test/java/util/Calendar/JavatimeTest.java ! test/java/util/TimeZone/OldIDMappingTest.java + test/java/util/TimeZone/TzIDOldMapping.java + test/sun/util/calendar/zi/BackEnd.java + test/sun/util/calendar/zi/Checksum.java + test/sun/util/calendar/zi/DayOfWeek.java + test/sun/util/calendar/zi/Gen.java + test/sun/util/calendar/zi/GenDoc.java + test/sun/util/calendar/zi/Main.java + test/sun/util/calendar/zi/Mappings.java + test/sun/util/calendar/zi/Month.java + test/sun/util/calendar/zi/Rule.java + test/sun/util/calendar/zi/RuleDay.java + test/sun/util/calendar/zi/RuleRec.java + test/sun/util/calendar/zi/Simple.java + test/sun/util/calendar/zi/TestZoneInfo310.java + test/sun/util/calendar/zi/Time.java + test/sun/util/calendar/zi/Timezone.java + test/sun/util/calendar/zi/TzIDOldMapping.java + test/sun/util/calendar/zi/Zone.java + test/sun/util/calendar/zi/ZoneInfoFile.java + test/sun/util/calendar/zi/ZoneInfoOld.java + test/sun/util/calendar/zi/ZoneRec.java + test/sun/util/calendar/zi/Zoneinfo.java + test/sun/util/calendar/zi/tzdata/VERSION + test/sun/util/calendar/zi/tzdata/africa + test/sun/util/calendar/zi/tzdata/antarctica + test/sun/util/calendar/zi/tzdata/asia + test/sun/util/calendar/zi/tzdata/australasia + test/sun/util/calendar/zi/tzdata/backward + test/sun/util/calendar/zi/tzdata/etcetera + test/sun/util/calendar/zi/tzdata/europe + test/sun/util/calendar/zi/tzdata/factory + test/sun/util/calendar/zi/tzdata/gmt + test/sun/util/calendar/zi/tzdata/iso3166.tab + test/sun/util/calendar/zi/tzdata/jdk11_backward + test/sun/util/calendar/zi/tzdata/leapseconds + test/sun/util/calendar/zi/tzdata/northamerica + test/sun/util/calendar/zi/tzdata/pacificnew + test/sun/util/calendar/zi/tzdata/solar87 + test/sun/util/calendar/zi/tzdata/solar88 + test/sun/util/calendar/zi/tzdata/solar89 + test/sun/util/calendar/zi/tzdata/southamerica + test/sun/util/calendar/zi/tzdata/systemv + test/sun/util/calendar/zi/tzdata/zone.tab + test/sun/util/calendar/zi/tzdata_jdk/gmt + test/sun/util/calendar/zi/tzdata_jdk/jdk11_backward + test/sun/util/calendar/zi/tzdata_jdk/jdk11_full_backward Changeset: 2cd67a8c7abc Author: jfranck Date: 2013-02-13 10:36 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2cd67a8c7abc 8007278: Rename j.l.r.AnnotatedElement.getAnnotations(Class) to getAnnotationsByType(Class) Reviewed-by: darcy, abuckley ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/reflect/AccessibleObject.java ! src/share/classes/java/lang/reflect/AnnotatedElement.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Parameter.java ! src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java ! test/java/lang/annotation/TypeParamAnnotation.java ! test/java/lang/annotation/repeatingAnnotations/RepeatedUnitTest.java Changeset: cd111064d4e9 Author: zgu Date: 2013-02-12 14:47 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cd111064d4e9 8006691: Remove jvm_version_info->is_kernel_jvm field Summary: Remove is_kernel_jvm field in jvm_version_info structure, as kernel VM has been deprecated Reviewed-by: mchung ! src/share/javavm/export/jvm.h Changeset: bf64f83aa0cd Author: vinnie Date: 2013-02-13 16:01 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bf64f83aa0cd 8007934: algorithm parameters for PBE Scheme 2 not decoded correctly in PKCS12 keystore Reviewed-by: mullan ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! test/java/security/KeyStore/PBETest.java Changeset: ceb7c712c693 Author: vinnie Date: 2013-02-13 16:03 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ceb7c712c693 Merge Changeset: 8181be9a3538 Author: dsamersoff Date: 2013-02-13 21:06 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/8181be9a3538 8008095: TEST_BUG: JDK-8002048 one more testcase failure on Solaris Summary: fixed couple of more Solaris shell incompatibilities Reviewed-by: chegar ! test/sun/management/jdp/JdpTest.sh Changeset: 11438befdd4c Author: vinnie Date: 2013-02-13 19:40 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/11438befdd4c 8007755: Support the logical grouping of keystores Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java + src/share/classes/sun/security/provider/DomainKeyStore.java ! src/share/classes/sun/security/provider/PolicyParser.java ! src/share/classes/sun/security/provider/Sun.java ! src/share/classes/sun/security/provider/SunEntries.java ! src/share/classes/sun/security/util/Resources.java + test/sun/security/provider/KeyStore/DKSTest.java + test/sun/security/provider/KeyStore/DKSTest.sh + test/sun/security/provider/KeyStore/domains.cfg ! test/sun/security/tools/keytool/AltProviderPath.sh ! test/sun/security/tools/keytool/DummyProvider.java Changeset: efc66fe16f91 Author: sherman Date: 2013-02-13 11:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/efc66fe16f91 8008161: Regression: j.u.TimeZone.getAvailableIDs(rawOffset) returns non-sorted list Summary: to return a sorted list Reviewed-by: lancea, naoto ! src/share/classes/sun/util/calendar/ZoneInfoFile.java ! test/sun/util/calendar/zi/TestZoneInfo310.java Changeset: ff80a6b2ae9b Author: lana Date: 2013-02-13 11:25 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ff80a6b2ae9b Merge Changeset: a5aad284904e Author: lana Date: 2013-02-13 11:57 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a5aad284904e Merge Changeset: 83c09292f5ad Author: ksrini Date: 2013-02-13 12:56 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/83c09292f5ad 8005750: [parfait] Memory leak at jdk/src/share/bin/parse_manifest.c Reviewed-by: jjh ! src/share/bin/parse_manifest.c Changeset: b13247d5408d Author: dcubed Date: 2013-02-13 13:22 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b13247d5408d 8007935: java/lang/instrument/RedefineSubclassWithTwoInterfaces.sh should use $COMPILEJAVA for javac Reviewed-by: sspitsyn, alanb ! test/java/lang/instrument/RedefineSubclassWithTwoInterfaces.sh Changeset: 4f520ce7ba3f Author: acorn Date: 2013-02-13 16:09 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4f520ce7ba3f 8007888: jdk fix default method: VerifyError: Illegal use of nonvirtual Summary: Recognize VM generated method in old verifier. With 8004967 Reviewed-by: coleenp, acorn Contributed-by: bharadwaj.yadavalli at oracle.com ! src/share/javavm/export/jvm.h ! src/share/native/common/check_code.c Changeset: e6f34051c60c Author: acorn Date: 2013-02-13 16:15 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e6f34051c60c Merge Changeset: dc3019a336c0 Author: lana Date: 2013-02-13 17:57 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/dc3019a336c0 Merge - src/share/classes/java/time/PeriodParser.java - src/share/classes/java/time/calendar/ChronoDateImpl.java - src/share/classes/java/time/calendar/HijrahChrono.java - src/share/classes/java/time/calendar/HijrahDate.java - src/share/classes/java/time/calendar/HijrahDeviationReader.java - src/share/classes/java/time/calendar/HijrahEra.java - src/share/classes/java/time/calendar/JapaneseChrono.java - src/share/classes/java/time/calendar/JapaneseDate.java - src/share/classes/java/time/calendar/JapaneseEra.java - src/share/classes/java/time/calendar/MinguoChrono.java - src/share/classes/java/time/calendar/MinguoDate.java - src/share/classes/java/time/calendar/MinguoEra.java - src/share/classes/java/time/calendar/Ser.java - src/share/classes/java/time/calendar/ThaiBuddhistChrono.java - src/share/classes/java/time/calendar/ThaiBuddhistDate.java - src/share/classes/java/time/calendar/ThaiBuddhistEra.java - src/share/classes/java/time/calendar/package-info.java - src/share/classes/java/time/format/DateTimeFormatters.java - src/share/classes/java/time/format/DateTimePrintException.java - src/share/classes/java/time/temporal/Chrono.java - src/share/classes/java/time/temporal/ChronoLocalDate.java - src/share/classes/java/time/temporal/ChronoLocalDateTime.java - src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java - src/share/classes/java/time/temporal/ChronoZonedDateTime.java - src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/java/time/temporal/Era.java - src/share/classes/java/time/temporal/ISOChrono.java - src/share/classes/java/time/temporal/ISOEra.java - src/share/classes/java/time/temporal/ISOFields.java - src/share/classes/java/time/temporal/MonthDay.java - src/share/classes/java/time/temporal/OffsetDate.java - src/share/classes/java/time/temporal/OffsetDateTime.java - src/share/classes/java/time/temporal/OffsetTime.java - src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/SimplePeriod.java - src/share/classes/java/time/temporal/TemporalAdder.java - src/share/classes/java/time/temporal/TemporalSubtractor.java - src/share/classes/java/time/temporal/Year.java - src/share/classes/java/time/temporal/YearMonth.java - src/share/classes/sun/util/calendar/TzIDOldMapping.java - test/java/time/META-INF/services/java.time.temporal.Chrono - test/java/time/tck/java/time/calendar/CopticChrono.java - test/java/time/tck/java/time/calendar/CopticDate.java - test/java/time/tck/java/time/calendar/CopticEra.java - test/java/time/tck/java/time/calendar/TestChronoLocalDate.java - test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java - test/java/time/tck/java/time/calendar/TestHijrahChrono.java - test/java/time/tck/java/time/calendar/TestJapaneseChrono.java - test/java/time/tck/java/time/calendar/TestMinguoChrono.java - test/java/time/tck/java/time/calendar/TestServiceLoader.java - test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java - test/java/time/tck/java/time/format/TCKDateTimePrintException.java - test/java/time/tck/java/time/temporal/TCKISOFields.java - test/java/time/tck/java/time/temporal/TCKMonthDay.java - test/java/time/tck/java/time/temporal/TCKOffsetDate.java - test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java - test/java/time/tck/java/time/temporal/TCKOffsetTime.java - test/java/time/tck/java/time/temporal/TCKSimplePeriod.java - test/java/time/tck/java/time/temporal/TCKYear.java - test/java/time/tck/java/time/temporal/TCKYearMonth.java - test/java/time/tck/java/time/temporal/TestChrono.java - test/java/time/tck/java/time/temporal/TestISOChrono.java - test/java/time/test/java/time/TestPeriodParser.java - test/java/time/test/java/time/format/TestDateTimeFormatters.java - test/java/time/test/java/time/format/TestDateTimePrintException.java - test/java/time/test/java/time/format/TestPadParserDecorator.java - test/java/time/test/java/time/format/TestZoneIdParser.java - test/java/time/test/java/time/temporal/TestISOChronoImpl.java - test/java/time/test/java/time/temporal/TestMonthDay.java - test/java/time/test/java/time/temporal/TestOffsetDate.java - test/java/time/test/java/time/temporal/TestOffsetDateTime.java - test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java - test/java/time/test/java/time/temporal/TestOffsetTime.java - test/java/time/test/java/time/temporal/TestYear.java - test/java/time/test/java/time/temporal/TestYearMonth.java Changeset: 5ea0024ba765 Author: lana Date: 2013-02-14 22:12 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5ea0024ba765 Merge Changeset: 41008f5cef1a Author: lana Date: 2013-02-19 22:10 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/41008f5cef1a Merge - src/macosx/classes/sun/lwawt/macosx/EventDispatchAccess.java - src/share/classes/java/time/PeriodParser.java - src/share/classes/java/time/calendar/ChronoDateImpl.java - src/share/classes/java/time/calendar/HijrahChrono.java - src/share/classes/java/time/calendar/HijrahDate.java - src/share/classes/java/time/calendar/HijrahDeviationReader.java - src/share/classes/java/time/calendar/HijrahEra.java - src/share/classes/java/time/calendar/JapaneseChrono.java - src/share/classes/java/time/calendar/JapaneseDate.java - src/share/classes/java/time/calendar/JapaneseEra.java - src/share/classes/java/time/calendar/MinguoChrono.java - src/share/classes/java/time/calendar/MinguoDate.java - src/share/classes/java/time/calendar/MinguoEra.java - src/share/classes/java/time/calendar/Ser.java - src/share/classes/java/time/calendar/ThaiBuddhistChrono.java - src/share/classes/java/time/calendar/ThaiBuddhistDate.java - src/share/classes/java/time/calendar/ThaiBuddhistEra.java - src/share/classes/java/time/calendar/package-info.java - src/share/classes/java/time/format/DateTimeFormatters.java - src/share/classes/java/time/format/DateTimePrintException.java - src/share/classes/java/time/temporal/Chrono.java - src/share/classes/java/time/temporal/ChronoLocalDate.java - src/share/classes/java/time/temporal/ChronoLocalDateTime.java - src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java - src/share/classes/java/time/temporal/ChronoZonedDateTime.java - src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/java/time/temporal/Era.java - src/share/classes/java/time/temporal/ISOChrono.java - src/share/classes/java/time/temporal/ISOEra.java - src/share/classes/java/time/temporal/ISOFields.java - src/share/classes/java/time/temporal/MonthDay.java - src/share/classes/java/time/temporal/OffsetDate.java - src/share/classes/java/time/temporal/OffsetDateTime.java - src/share/classes/java/time/temporal/OffsetTime.java - src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/SimplePeriod.java - src/share/classes/java/time/temporal/TemporalAdder.java - src/share/classes/java/time/temporal/TemporalSubtractor.java - src/share/classes/java/time/temporal/Year.java - src/share/classes/java/time/temporal/YearMonth.java - src/share/classes/sun/util/calendar/TzIDOldMapping.java - test/java/time/META-INF/services/java.time.temporal.Chrono - test/java/time/tck/java/time/calendar/CopticChrono.java - test/java/time/tck/java/time/calendar/CopticDate.java - test/java/time/tck/java/time/calendar/CopticEra.java - test/java/time/tck/java/time/calendar/TestChronoLocalDate.java - test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java - test/java/time/tck/java/time/calendar/TestHijrahChrono.java - test/java/time/tck/java/time/calendar/TestJapaneseChrono.java - test/java/time/tck/java/time/calendar/TestMinguoChrono.java - test/java/time/tck/java/time/calendar/TestServiceLoader.java - test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java - test/java/time/tck/java/time/format/TCKDateTimePrintException.java - test/java/time/tck/java/time/temporal/TCKISOFields.java - test/java/time/tck/java/time/temporal/TCKMonthDay.java - test/java/time/tck/java/time/temporal/TCKOffsetDate.java - test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java - test/java/time/tck/java/time/temporal/TCKOffsetTime.java - test/java/time/tck/java/time/temporal/TCKSimplePeriod.java - test/java/time/tck/java/time/temporal/TCKYear.java - test/java/time/tck/java/time/temporal/TCKYearMonth.java - test/java/time/tck/java/time/temporal/TestChrono.java - test/java/time/tck/java/time/temporal/TestISOChrono.java - test/java/time/test/java/time/TestPeriodParser.java - test/java/time/test/java/time/format/TestDateTimeFormatters.java - test/java/time/test/java/time/format/TestDateTimePrintException.java - test/java/time/test/java/time/format/TestPadParserDecorator.java - test/java/time/test/java/time/format/TestZoneIdParser.java - test/java/time/test/java/time/temporal/TestISOChronoImpl.java - test/java/time/test/java/time/temporal/TestMonthDay.java - test/java/time/test/java/time/temporal/TestOffsetDate.java - test/java/time/test/java/time/temporal/TestOffsetDateTime.java - test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java - test/java/time/test/java/time/temporal/TestOffsetTime.java - test/java/time/test/java/time/temporal/TestYear.java - test/java/time/test/java/time/temporal/TestYearMonth.java From artem.ananiev at oracle.com Wed Feb 20 13:43:49 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Wed, 20 Feb 2013 17:43:49 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <512251F0.7020204@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> <50EE1CEB.5080500@oracle.com> <50EFED12.6070700@oracle.com> <50EFFB4F.4090405@oracle.com> <510946F7.3090709@oracle.com> <510A6A54.1080705@oracle.com> <510A90DF.2060501@oracle.com> <511BC5E4.9090302@oracle.com> <51220DA4.7040608@oracle.com> <512218E7.9090808@oracle.com> <51221D2D.9070907@oracle.com> <512251F0.7020204@oracle.com> Message-ID: <5124D315.8080809@oracle.com> Looks fine. Thanks, Artem On 2/18/2013 8:08 PM, Anton Litvinov wrote: > Hello Artem, > > Could you please review a new version of the fix. The method > "XErrorHandlerUtil.getDisplay()" was removed and > "XErrorHandlerUtil.XSync()" method refers to the field "display" > directly now. > > Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.03 > > Thank you, > Anton > > On 2/18/2013 4:23 PM, Artem Ananiev wrote: >> >> On 2/18/2013 4:04 PM, Anton Litvinov wrote: >>> Hello Artem, >>> >>> Thank you very much for the review of this fix. My responses to your >>> questions are provided below in the same order, which you defined. >>> >>> 1. I think that "XErrorHandlerUtil.saved_error" field can surely be >>> marked as private, but in this case the corresponding >>> "XErrorHandlerUtil.getSavedError" method will be necessary, because >>> this field is actively accessed from other classes which set a >>> certain instance of XErrorHandler. For example >>> "MotifDnDDropTargetProtocol.java", "XDragSourceProtocol.java" and a >>> few other classes edited in this fix. >> >> OK, I missed that usages when looking at the webrev. Let it stay >> unchanged now. >> >>> 2. Yes, I completely agree that "XErrorHandlerUtil.getDisplay()" is >>> reduntant. This method will be eliminated. >> >> Thanks, >> >> Artem >> >>> Thank you, >>> Anton >>> >>> On 2/18/2013 3:16 PM, Artem Ananiev wrote: >>>> Hi, Anton, >>>> >>>> a few minor comments: >>>> >>>> 1. XErrorHandlerUtil: can saved_error be private instead of package >>>> protected? >>>> >>>> 2. XErrorHandlerUtil.getDisplay() seems to be redundant. >>>> >>>> In general, the fix looks perfectly fine to me. Please, wait for >>>> comments from Java2D team, though. >>>> >>>> Thanks, >>>> >>>> Artem >>>> >>>> On 2/13/2013 8:57 PM, Anton Litvinov wrote: >>>>> Hello Anthony, >>>>> >>>>> Could you please review the third version of the fix containing >>>>> modifications discussed with you in the previous letter. >>>>> >>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.02 >>>>> >>>>> This version of the fix differs from the previous in the following >>>>> places: >>>>> >>>>> 1. A comment about the place of invocation of the method >>>>> "XErrorHandlerUtil.init" was added to a documentation block of the >>>>> method. >>>>> 2. A code related to XShmAttach function common to the files >>>>> "src/solaris/native/sun/awt/awt_GraphicsEnv.c" and >>>>> "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" was extracted >>>>> into a separate function "TryXShmAttach" declared in >>>>> "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. >>>>> 3. All JNI code related to X error handling was implemented as >>>>> corresponding macros defined in >>>>> "src/solaris/native/sun/awt/awt_util.h" file. >>>>> >>>>> Thank you, >>>>> Anton >>>>> >>>>> On 1/31/2013 7:42 PM, Anton Litvinov wrote: >>>>>> Hello Anthony, >>>>>> >>>>>> Thank you for the review and these remarks. Surely, the comment will >>>>>> be added. I think that all JNI code related to XShmAttach can be >>>>>> definitely transferred into a separate dedicated function, which will >>>>>> be declared in "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. I >>>>>> will try to wrap all JNU calls connected with XErrorHandler into the >>>>>> particular "WITH_XERROR_HANDLER", "RESTORE_XERROR_HANDLER" functions >>>>>> or macros. >>>>>> >>>>>> Thank you, >>>>>> Anton >>>>>> >>>>>> On 1/31/2013 4:57 PM, Anthony Petrov wrote: >>>>>>> Hi Anton, >>>>>>> >>>>>>> A couple comments: >>>>>>> >>>>>>> 1. src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java >>>>>>>> 80 private static void init(long display) { >>>>>>> >>>>>>> This method is private and isn't called from anywhere in this class >>>>>>> itself. This looks confusing. Please add a comment stating that this >>>>>>> method is invoked from native code, and from where exactly. >>>>>>> >>>>>>> >>>>>>> 2. Interesting that we use this machinery to call the XShmAttach() >>>>>>> from native code twice, and the code looks quite similar in each >>>>>>> case. Would it be possible to extract the common code in a separate >>>>>>> function (a-la BOOL TryXShmAttach(...)) to avoid code replication? >>>>>>> There are other usages as well, so we could also introduce a macro >>>>>>> (such as the old EXEC_WITH_XERROR_HANDLER but now with other >>>>>>> arguments) that would minimize all the JNU_ calls required to use >>>>>>> this machinery. >>>>>>> >>>>>>> >>>>>>> Otherwise the fix looks great. >>>>>>> >>>>>>> -- >>>>>>> best regards, >>>>>>> Anthony >>>>>>> >>>>>>> On 1/30/2013 20:14, Anton Litvinov wrote: >>>>>>>> Hello Anthony, >>>>>>>> >>>>>>>> Could you, please, review a second version of the fix, which is >>>>>>>> based on an idea of reusing the existing AWT native global error >>>>>>>> handler from Java 2D native code. >>>>>>>> >>>>>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.01 >>>>>>>> >>>>>>>> The fix consists of the following parts: >>>>>>>> >>>>>>>> 1. Migration of all X error handling code from XToolkit to a new >>>>>>>> XErrorHandlerUtil class for resolution of interdependency >>>>>>>> between >>>>>>>> a static initialization block of XToolkit and a block >>>>>>>> initializing >>>>>>>> java.awt.GraphicsEnvironment singleton. Such dependency is >>>>>>>> created >>>>>>>> by new calls to XToolkit static methods from >>>>>>>> "src/solaris/native/sun/awt/awt_GraphicsEnv.c", >>>>>>>> "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" files. >>>>>>>> 2. Substitution of XToolkit.WITH_XERROR_HANDLER, >>>>>>>> XToolkit.RESTORE_XERROR_HANDLER ... for corresponding >>>>>>>> methods, >>>>>>>> fields of XErrorHandlerUtil class in all places of JDK source >>>>>>>> code, where they were used. >>>>>>>> 3. Substitution of all found native X error handlers which are >>>>>>>> set in >>>>>>>> native code (awt_GraphicsEnv.c, X11SurfaceData.c, >>>>>>>> GLXSurfaceData.c) for new synthetic Java error handlers. >>>>>>>> 4. Removal of X error handling code used by the native error >>>>>>>> handlers >>>>>>>> from "solaris/native/sun/awt/awt_util.c" >>>>>>>> "solaris/native/sun/awt/awt_util.h" files. >>>>>>>> >>>>>>>> Thank you, >>>>>>>> Anton >>>>>>>> >>>>>>>> On 1/11/2013 3:45 PM, Anthony Petrov wrote: >>>>>>>>> I'm not Jim, but as I indicated earlier my opinion is that the >>>>>>>>> easiest way to fix this is to install the existing >>>>>>>>> J2DXErrHandler() >>>>>>>>> only once. That is, it is the second option listed by you. Of >>>>>>>>> course, the J2DXErrHandler needs to be updated as well to detect >>>>>>>>> whether 2D code wants to use it at the moment or it must simply >>>>>>>>> delegate to the previous handler (i.e. where the code currently >>>>>>>>> installs/uninstalls the handler, it must instead set a global >>>>>>>>> boolean flag or something.) >>>>>>>>> >>>>>>>>> While the first option (reusing the existing AWT machinery) is an >>>>>>>>> interesting idea in general, I think it is complex and would >>>>>>>>> require too much additional testing and bring an unjustified risk >>>>>>>>> to the solution for such a basic problem. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> best regards, >>>>>>>>> Anthony >>>>>>>>> >>>>>>>>> On 1/11/2013 14:44, Anton Litvinov wrote: >>>>>>>>>> Hello Jim, >>>>>>>>>> >>>>>>>>>> Thank you very much for the review and provision of a new idea of >>>>>>>>>> a solution. Elimination of the logic, which sets/unsets >>>>>>>>>> J2DXErrHandler() for each call "XShmAttach(awt_display, >>>>>>>>>> &shminfo))" should effectively resolve the issue, but only in >>>>>>>>>> case >>>>>>>>>> if all other native error handlers, which were set by the system >>>>>>>>>> function "XSetErrorHandler()" in JDK or in any external library, >>>>>>>>>> observe the rule of relaying of all events, which are not >>>>>>>>>> relative >>>>>>>>>> to them, to the previously saved error handlers. Otherwise an >>>>>>>>>> error generated during "XShmAttach" function call will not be >>>>>>>>>> handled by J2DXErrHandler(). >>>>>>>>>> >>>>>>>>>> Could you answer the following question. By setting >>>>>>>>>> J2DXErrHandler() only once and forever do you mean usage of AWT >>>>>>>>>> global event handler "static int ToolkitErrorHandler(Display * >>>>>>>>>> dpy, XErrorEvent * event)" from >>>>>>>>>> "src/solaris/native/sun/xawt/XlibWrapper.c" with Java synthetic >>>>>>>>>> handlers or creation of another global native error handler with >>>>>>>>>> J2DXErrHandler as native synthetic handler? >>>>>>>>>> >>>>>>>>>> Thank you, >>>>>>>>>> Anton >>>>>>>>>> >>>>>>>>>> On 1/10/2013 5:44 AM, Jim Graham wrote: >>>>>>>>>>> I think I'd rather see some way to prevent double-adding the >>>>>>>>>>> handler in the first place as well. Since it is only ever used >>>>>>>>>>> on errors I also think it is OK to set it once and leave it >>>>>>>>>>> there >>>>>>>>>>> forever... >>>>>>>>>>> >>>>>>>>>>> ...jim >>>>>>>>>>> >>>>>>>>>>> On 1/9/13 8:08 AM, Anthony Petrov wrote: >>>>>>>>>>>> Hi Anton et al., >>>>>>>>>>>> >>>>>>>>>>>> If I read the description of the bug correctly, specifically >>>>>>>>>>>> this part: >>>>>>>>>>>> >>>>>>>>>>>>> The problem occurs, if another thread (for example, GTK >>>>>>>>>>>>> thread) is >>>>>>>>>>>>> doing the same sort of thing concurrently. This can lead to >>>>>>>>>>>>> the >>>>>>>>>>>>> following situation. >>>>>>>>>>>>> JVM thread: Sets J2DXErrHandler(), saves >>>>>>>>>>>>> ANY_PREVIOUS_HANDLER as >>>>>>>>>>>>> previous GTK thread: Sets some GTK_HANDLER, saves >>>>>>>>>>>>> J2DXErrHandler() as previous JVM thread: Restores >>>>>>>>>>>>> ANY_PREVIOUS_HANDLER GTK thread: Restores >>>>>>>>>>>>> J2DXErrHandler() JVM >>>>>>>>>>>>> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as >>>>>>>>>>>>> previous >>>>>>>>>>>> >>>>>>>>>>>> It is obvious that at this final step 2D is in an inconsistent >>>>>>>>>>>> state. We >>>>>>>>>>>> don't expect to replace our own error handler (and it shouldn't >>>>>>>>>>>> have >>>>>>>>>>>> been there in the first place). >>>>>>>>>>>> >>>>>>>>>>>> I realize that the fix you propose works around this problem. >>>>>>>>>>>> But this >>>>>>>>>>>> doesn't look like an ideal solution to me. >>>>>>>>>>>> >>>>>>>>>>>> BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 >>>>>>>>>>>> error >>>>>>>>>>>> handler only once and never replace it. All the rest of the >>>>>>>>>>>> push_handler/pop_handler logic is now located in Java code (see >>>>>>>>>>>> XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I >>>>>>>>>>>> believe >>>>>>>>>>>> that we should somehow share this machinery with the 2D code to >>>>>>>>>>>> avoid >>>>>>>>>>>> this sort of problems. Though I'm not sure if this will >>>>>>>>>>>> eliminate this >>>>>>>>>>>> exact issue. >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> 2D/AWT folks: any other thoughts? >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> best regards, >>>>>>>>>>>> Anthony >>>>>>>>>>>> >>>>>>>>>>>> On 12/29/2012 17:44, Anton Litvinov wrote: >>>>>>>>>>>>> Hello, >>>>>>>>>>>>> >>>>>>>>>>>>> Please review the following fix for a bug. >>>>>>>>>>>>> >>>>>>>>>>>>> Bug: >>>>>>>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >>>>>>>>>>>>> https://jbs.oracle.com/bugs/browse/JDK-8005607 >>>>>>>>>>>>> Webrev: >>>>>>>>>>>>> http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >>>>>>>>>>>>> >>>>>>>>>>>>> The bug consists in a crash which is caused by a stack >>>>>>>>>>>>> overflow >>>>>>>>>>>>> for >>>>>>>>>>>>> the reason of an infinite recursion in AWT native function >>>>>>>>>>>>> J2DXErrHandler() under certain circumstances on 32-bit Linux >>>>>>>>>>>>> OS. The >>>>>>>>>>>>> fix is based on introduction of the logic, which detects >>>>>>>>>>>>> indirect >>>>>>>>>>>>> recursive calls to J2DXErrHandler() by means of a simple >>>>>>>>>>>>> counter, to >>>>>>>>>>>>> J2DXErrHandler() native function. Such a solution requires >>>>>>>>>>>>> minimum >>>>>>>>>>>>> code changes, does not alter the handler's code significantly >>>>>>>>>>>>> and >>>>>>>>>>>>> eliminates this bug. >>>>>>>>>>>>> >>>>>>>>>>>>> Adding 2d-dev at openjdk.java.net e-mail alias to the list of >>>>>>>>>>>>> recipients >>>>>>>>>>>>> of this letter, because the edited function's name is related >>>>>>>>>>>>> to Java >>>>>>>>>>>>> 2D area of JDK, despite of the fact that the edited file is >>>>>>>>>>>>> located in >>>>>>>>>>>>> AWT directory. >>>>>>>>>>>>> >>>>>>>>>>>>> Thank you, >>>>>>>>>>>>> Anton >>>>> >>> > From anton.litvinov at oracle.com Thu Feb 21 14:53:48 2013 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Thu, 21 Feb 2013 18:53:48 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users In-Reply-To: <51152343.8060303@oracle.com> References: <51152343.8060303@oracle.com> Message-ID: <512634FC.8060504@oracle.com> Hello, I am sorry for inconvenience. This is a reminder message. I am still interested in reception of the response to this review request and just want to be sure that it is not lost on the mail alias's archive. Thank you, Anton On 2/8/2013 8:09 PM, Anton Litvinov wrote: > Hello, > > Please review the following fix for a bug. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007642 > Webrev: http://cr.openjdk.java.net/~alitvinov/8007642/webrev.00 > > The bug consists in the fact that Java cross-platform Page Setup and > Print dialogs do not always list all media sizes supported by a > printer. The fix is based on addition of dynamic creation of new media > names of the type "sun.print.Win32MediaSize" based on paper names > received from Windows API function with corresponding media sizes of > the type "javax.print.attribute.standard.MediaSize" for the case, when > the printer's media size name, which is being analyzed in > "sun.print.Win32PrintService.initMedia" method, is not added to the > final list of media sizes supported by the printer because of an > already existing duplicate in that list. In such a case the printer's > paper size matches with one of the media sizes registered in JDK, > while the paper size ID does not match with any ID known to JDK. > > Also the code in "Win32PrintService.findWin32Media" method was altered > to allow three cases from "switch" block to work as expected, because > currently they never match with "dmIndex" value, since it is always > less then "dmPaperToPrintService.length" under "if" statement. > > Thank you, > Anton From Sergey.Bylokhov at oracle.com Fri Feb 22 18:05:36 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 22 Feb 2013 22:05:36 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8008660 : Failure in 2D Queue Flusher thread on Mac Message-ID: <5127B370.4010203@oracle.com> Hello, Please review the fix for jdk 8. Fix will be ported to jdk7 as well. There is a few problems: 1 To eliminate the crash we should check that the system return correct CGLConfigInfofrom in CGLGraphicsConfig.getConfig(). (see http://bugs.sun.com/view_bug.do?bug_id=6755274) 2 Requested opengl attributes are too strict, so we cannot fail-back to the "software renderer". Next attrs were removed: NSOpenGLPFANoRecovery, -> if an accelerated renderer fails due to lack of resources, OpenGL automatically switches to another renderer. NSOpenGLPFAAccelerated, -> accelerated renderers are still preferred. NSOpenGLPFAFullScreen, -> we don't use this functionality. Also in this code we try to mix "CoreGraphics display id" and "Screen index". Currently we never use "screen index" so all related code was removed/renamed to be more obvious. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008660 Webrev can be found at: http://cr.openjdk.java.net/~serb/8008660/webrev.00 -- Best regards, Sergey. From swingler at apple.com Fri Feb 22 18:34:52 2013 From: swingler at apple.com (Mike Swingler) Date: Fri, 22 Feb 2013 10:34:52 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8008660 : Failure in 2D Queue Flusher thread on Mac In-Reply-To: <5127B370.4010203@oracle.com> References: <5127B370.4010203@oracle.com> Message-ID: <36824436-3E09-4540-8265-B0C5C53ACC55@apple.com> On Feb 22, 2013, at 10:05 AM, Sergey Bylokhov wrote: > Hello, > Please review the fix for jdk 8. Fix will be ported to jdk7 as well. > There is a few problems: > 1 To eliminate the crash we should check that the system return correct CGLConfigInfofrom in CGLGraphicsConfig.getConfig(). (see http://bugs.sun.com/view_bug.do?bug_id=6755274) > 2 Requested opengl attributes are too strict, so we cannot fail-back to the "software renderer". > Next attrs were removed: > NSOpenGLPFANoRecovery, -> if an accelerated renderer fails due to lack of resources, OpenGL automatically switches to another renderer. > NSOpenGLPFAAccelerated, -> accelerated renderers are still preferred. > NSOpenGLPFAFullScreen, -> we don't use this functionality. > > Also in this code we try to mix "CoreGraphics display id" and "Screen index". Currently we never use "screen index" so all related code was removed/renamed to be more obvious. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008660 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8008660/webrev.00 This looks good. I like the simplification. Regards, Mike Swingler Apple Inc. From jennifer.godinez at oracle.com Fri Feb 22 19:01:55 2013 From: jennifer.godinez at oracle.com (jennifer.godinez at oracle.com) Date: Fri, 22 Feb 2013 19:01:55 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8006110: pageDialog is showing the swing dialog with DialogTypeSelection.NATIVE Message-ID: <20130222190303.1E72B47CCB@hg.openjdk.java.net> Changeset: d2d7da120c37 Author: jgodinez Date: 2013-02-22 11:01 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d2d7da120c37 8006110: pageDialog is showing the swing dialog with DialogTypeSelection.NATIVE Reviewed-by: bae, prr ! src/share/classes/sun/print/RasterPrinterJob.java From jennifer.godinez at oracle.com Fri Feb 22 21:20:40 2013 From: jennifer.godinez at oracle.com (jennifer.godinez at oracle.com) Date: Fri, 22 Feb 2013 21:20:40 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8005796: [parfait] Possible uninitialised variable at jdk/src/share/native/sun/java2d/loops/ByteBinary1Bit.c Message-ID: <20130222212111.8A69247D0E@hg.openjdk.java.net> Changeset: 99c1f910abcc Author: jgodinez Date: 2013-02-22 13:20 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/99c1f910abcc 8005796: [parfait] Possible uninitialised variable at jdk/src/share/native/sun/java2d/loops/ByteBinary1Bit.c Reviewed-by: prr, vadim, flar Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/java2d/loops/AnyByteBinary.h ! src/share/native/sun/java2d/loops/ByteIndexed.h ! src/share/native/sun/java2d/loops/IntArgb.h ! src/share/native/sun/java2d/loops/IntArgbBm.h ! src/share/native/sun/java2d/loops/IntArgbPre.h ! src/share/native/sun/java2d/loops/Ushort4444Argb.h ! src/share/native/sun/java2d/loops/UshortIndexed.h From lana.steuck at oracle.com Sat Feb 23 07:13:35 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 23 Feb 2013 07:13:35 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d: 9 new changesets Message-ID: <20130223071336.47DFD47D61@hg.openjdk.java.net> Changeset: ffb4d2e95140 Author: erikj Date: 2013-02-15 10:40 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/ffb4d2e95140 8005879: Add -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 to builds on Mac Reviewed-by: ohair ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 Changeset: b0642df54d63 Author: erikj Date: 2013-02-18 10:46 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/b0642df54d63 Merge Changeset: b80abec66e70 Author: bpatel Date: 2013-01-21 00:29 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/rev/b80abec66e70 8006124: javadoc/doclet should be updated to support profiles Reviewed-by: jjg, dholmes ! common/makefiles/javadoc/Javadoc.gmk Changeset: 7ed0c9db6943 Author: dholmes Date: 2013-01-21 01:50 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/rev/7ed0c9db6943 8004265: Add build support for Compact Profiles Reviewed-by: erikj, ohair ! NewMakefile.gmk ! common/autoconf/generated-configure.sh ! common/makefiles/Main.gmk Changeset: 2f8fd30f02e6 Author: dholmes Date: 2013-01-22 19:30 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/rev/2f8fd30f02e6 Merge ! common/autoconf/generated-configure.sh Changeset: bebeaa04ab8e Author: dholmes Date: 2013-02-04 18:08 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/rev/bebeaa04ab8e Merge ! common/autoconf/generated-configure.sh ! common/makefiles/javadoc/Javadoc.gmk Changeset: 28071e4ca1de Author: dholmes Date: 2013-02-17 16:44 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/rev/28071e4ca1de Merge ! common/autoconf/generated-configure.sh ! common/makefiles/Main.gmk Changeset: fd1a5574cf68 Author: dholmes Date: 2013-02-18 15:35 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/rev/fd1a5574cf68 Merge ! common/autoconf/generated-configure.sh Changeset: 91d35211e744 Author: katleman Date: 2013-02-21 11:12 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/91d35211e744 Added tag jdk8-b78 for changeset fd1a5574cf68 ! .hgtags From lana.steuck at oracle.com Sat Feb 23 07:13:34 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 23 Feb 2013 07:13:34 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/corba: Added tag jdk8-b78 for changeset 27d6368ae8ba Message-ID: <20130223071337.C522247D64@hg.openjdk.java.net> Changeset: e41fb1aa0329 Author: katleman Date: 2013-02-21 11:12 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/e41fb1aa0329 Added tag jdk8-b78 for changeset 27d6368ae8ba ! .hgtags From lana.steuck at oracle.com Sat Feb 23 07:13:34 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 23 Feb 2013 07:13:34 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxp: Added tag jdk8-b78 for changeset 00958c5a7070 Message-ID: <20130223071342.17BA647D6A@hg.openjdk.java.net> Changeset: 58fa065dd5d6 Author: katleman Date: 2013-02-21 11:13 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/58fa065dd5d6 Added tag jdk8-b78 for changeset 00958c5a7070 ! .hgtags From lana.steuck at oracle.com Sat Feb 23 07:13:36 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 23 Feb 2013 07:13:36 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/hotspot: Added tag jdk8-b78 for changeset d5e12e7d2f71 Message-ID: <20130223071343.0957047D6D@hg.openjdk.java.net> Changeset: db3359133cdd Author: katleman Date: 2013-02-21 11:12 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/db3359133cdd Added tag jdk8-b78 for changeset d5e12e7d2f71 ! .hgtags From lana.steuck at oracle.com Sat Feb 23 07:13:36 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 23 Feb 2013 07:13:36 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/nashorn: Added tag jdk8-b78 for changeset 000000000000 Message-ID: <20130223071336.2D62447D5E@hg.openjdk.java.net> Changeset: 8f49d8121c7e Author: katleman Date: 2013-02-21 11:13 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/nashorn/rev/8f49d8121c7e Added tag jdk8-b78 for changeset 000000000000 + .hgtags From lana.steuck at oracle.com Sat Feb 23 07:13:36 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 23 Feb 2013 07:13:36 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxws: Added tag jdk8-b78 for changeset 391de4c992d1 Message-ID: <20130223071341.1F88747D67@hg.openjdk.java.net> Changeset: 70d8658d2a30 Author: katleman Date: 2013-02-21 11:13 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/70d8658d2a30 Added tag jdk8-b78 for changeset 391de4c992d1 ! .hgtags From lana.steuck at oracle.com Sat Feb 23 07:13:53 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 23 Feb 2013 07:13:53 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/langtools: 5 new changesets Message-ID: <20130223071412.628E547D70@hg.openjdk.java.net> Changeset: 5f0731e4e5e6 Author: bpatel Date: 2013-01-21 00:45 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/5f0731e4e5e6 8006124: javadoc/doclet should be updated to support profiles Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/AbstractProfileIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/ProfileIndexFrameWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageWriterImpl.java + src/share/classes/com/sun/tools/doclets/formats/html/ProfileWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlConstants.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/ProfilePackageSummaryWriter.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/ProfileSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/WriterFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ProfilePackageSummaryBuilder.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ProfileSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPaths.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MetaKeywords.java + test/com/sun/javadoc/testProfiles/TestProfiles.java + test/com/sun/javadoc/testProfiles/pkg1/Class1Pkg1.java + test/com/sun/javadoc/testProfiles/pkg1/Class2Pkg1.java + test/com/sun/javadoc/testProfiles/pkg1/Class3Pkg1.java + test/com/sun/javadoc/testProfiles/pkg1/Interface1Pkg1.java + test/com/sun/javadoc/testProfiles/pkg2/Anno1Pkg2.java + test/com/sun/javadoc/testProfiles/pkg2/Anno2Pkg2.java + test/com/sun/javadoc/testProfiles/pkg2/Class1Pkg2.java + test/com/sun/javadoc/testProfiles/pkg3/Class1Pkg3.java + test/com/sun/javadoc/testProfiles/pkg3/Class2Pkg3.java + test/com/sun/javadoc/testProfiles/pkg3/Interface1Pkg3.java + test/com/sun/javadoc/testProfiles/pkg4/Anno1Pkg4.java + test/com/sun/javadoc/testProfiles/pkg4/Class1Pkg4.java + test/com/sun/javadoc/testProfiles/pkg5/Class1Pkg5.java + test/com/sun/javadoc/testProfiles/pkg5/Interface1Pkg5.java + test/com/sun/javadoc/testProfiles/profile-rtjar-includes.txt Changeset: 475eb15dfdad Author: jjg Date: 2013-01-21 01:27 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/475eb15dfdad 8004182: Add support for profiles in javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java + src/share/classes/com/sun/tools/javac/jvm/Profile.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java + src/share/classes/com/sun/tools/javac/sym/Profiles.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java + test/tools/javac/diags/examples/NotInProfile.java + test/tools/javac/profiles/ProfileOptionTest.java Changeset: f91144b7da75 Author: dholmes Date: 2013-02-04 18:08 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/f91144b7da75 Merge ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java - test/tools/javac/annotations/repeatingAnnotations/MissingContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/MissingContainerFor.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/UseWrongContainerFor.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainedBy.java - test/tools/javac/annotations/repeatingAnnotations/WrongContainerFor.java - test/tools/javac/diags/examples/ContainedByDocumentedMismatch.java - test/tools/javac/diags/examples/ContainedByInheritedMismatch.java - test/tools/javac/diags/examples/ContainedByNoValue.java - test/tools/javac/diags/examples/ContainedByNonDefault.java - test/tools/javac/diags/examples/ContainedByRetentionMismatch.java - test/tools/javac/diags/examples/ContainedByTargetMismatch.java - test/tools/javac/diags/examples/ContainedByWrongValueType.java - test/tools/javac/diags/examples/InferredDoNotConformToLower.java - test/tools/javac/diags/examples/NoUniqueMaximalInstance.java - test/tools/javac/diags/examples/WrongContainedBy.java - test/tools/javac/diags/examples/WrongContainerFor.java - test/tools/javac/lambda/MethodReference26.out - test/tools/javac/lambda/TargetType06.out - test/tools/javac/lambda/TargetType11.out - test/tools/javac/lambda/TargetType45.out - test/tools/javac/lambda/VoidCompatibility.out - test/tools/javac/typeAnnotations/newlocations/BasicTest.java - test/tools/javac/typeAnnotations/newlocations/BasicTest.out Changeset: af8417e590f4 Author: dholmes Date: 2013-02-17 16:44 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/af8417e590f4 Merge ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java - test/tools/javac/lambda/TargetType20.out - test/tools/javac/lambda/TargetType50.out Changeset: 56dfafbb9e1a Author: katleman Date: 2013-02-21 11:13 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/56dfafbb9e1a Added tag jdk8-b78 for changeset af8417e590f4 ! .hgtags From lana.steuck at oracle.com Sat Feb 23 07:14:58 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 23 Feb 2013 07:14:58 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 25 new changesets Message-ID: <20130223071954.8896B47D75@hg.openjdk.java.net> Changeset: 90707943f83c Author: erikj Date: 2013-02-15 10:41 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/90707943f83c 8005879: Add -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 to builds on Mac Reviewed-by: ohair ! make/common/Defs-macosx.gmk Changeset: 9a693ebd5595 Author: erikj Date: 2013-02-18 10:48 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9a693ebd5595 Merge - src/macosx/classes/sun/lwawt/macosx/EventDispatchAccess.java - src/share/classes/java/time/PeriodParser.java - src/share/classes/java/time/calendar/ChronoDateImpl.java - src/share/classes/java/time/calendar/HijrahChrono.java - src/share/classes/java/time/calendar/HijrahDate.java - src/share/classes/java/time/calendar/HijrahDeviationReader.java - src/share/classes/java/time/calendar/HijrahEra.java - src/share/classes/java/time/calendar/JapaneseChrono.java - src/share/classes/java/time/calendar/JapaneseDate.java - src/share/classes/java/time/calendar/JapaneseEra.java - src/share/classes/java/time/calendar/MinguoChrono.java - src/share/classes/java/time/calendar/MinguoDate.java - src/share/classes/java/time/calendar/MinguoEra.java - src/share/classes/java/time/calendar/Ser.java - src/share/classes/java/time/calendar/ThaiBuddhistChrono.java - src/share/classes/java/time/calendar/ThaiBuddhistDate.java - src/share/classes/java/time/calendar/ThaiBuddhistEra.java - src/share/classes/java/time/calendar/package-info.java - src/share/classes/java/time/format/DateTimeFormatters.java - src/share/classes/java/time/format/DateTimePrintException.java - src/share/classes/java/time/temporal/Chrono.java - src/share/classes/java/time/temporal/ChronoLocalDate.java - src/share/classes/java/time/temporal/ChronoLocalDateTime.java - src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java - src/share/classes/java/time/temporal/ChronoZonedDateTime.java - src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/java/time/temporal/Era.java - src/share/classes/java/time/temporal/ISOChrono.java - src/share/classes/java/time/temporal/ISOEra.java - src/share/classes/java/time/temporal/ISOFields.java - src/share/classes/java/time/temporal/MonthDay.java - src/share/classes/java/time/temporal/OffsetDate.java - src/share/classes/java/time/temporal/OffsetDateTime.java - src/share/classes/java/time/temporal/OffsetTime.java - src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/SimplePeriod.java - src/share/classes/java/time/temporal/TemporalAdder.java - src/share/classes/java/time/temporal/TemporalSubtractor.java - src/share/classes/java/time/temporal/Year.java - src/share/classes/java/time/temporal/YearMonth.java - src/share/classes/sun/util/calendar/TzIDOldMapping.java - test/java/time/META-INF/services/java.time.temporal.Chrono - test/java/time/tck/java/time/calendar/CopticChrono.java - test/java/time/tck/java/time/calendar/CopticDate.java - test/java/time/tck/java/time/calendar/CopticEra.java - test/java/time/tck/java/time/calendar/TestChronoLocalDate.java - test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java - test/java/time/tck/java/time/calendar/TestHijrahChrono.java - test/java/time/tck/java/time/calendar/TestJapaneseChrono.java - test/java/time/tck/java/time/calendar/TestMinguoChrono.java - test/java/time/tck/java/time/calendar/TestServiceLoader.java - test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java - test/java/time/tck/java/time/format/TCKDateTimePrintException.java - test/java/time/tck/java/time/temporal/TCKISOFields.java - test/java/time/tck/java/time/temporal/TCKMonthDay.java - test/java/time/tck/java/time/temporal/TCKOffsetDate.java - test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java - test/java/time/tck/java/time/temporal/TCKOffsetTime.java - test/java/time/tck/java/time/temporal/TCKSimplePeriod.java - test/java/time/tck/java/time/temporal/TCKYear.java - test/java/time/tck/java/time/temporal/TCKYearMonth.java - test/java/time/tck/java/time/temporal/TestChrono.java - test/java/time/tck/java/time/temporal/TestISOChrono.java - test/java/time/test/java/time/TestPeriodParser.java - test/java/time/test/java/time/format/TestDateTimeFormatters.java - test/java/time/test/java/time/format/TestDateTimePrintException.java - test/java/time/test/java/time/format/TestPadParserDecorator.java - test/java/time/test/java/time/format/TestZoneIdParser.java - test/java/time/test/java/time/temporal/TestISOChronoImpl.java - test/java/time/test/java/time/temporal/TestMonthDay.java - test/java/time/test/java/time/temporal/TestOffsetDate.java - test/java/time/test/java/time/temporal/TestOffsetDateTime.java - test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java - test/java/time/test/java/time/temporal/TestOffsetTime.java - test/java/time/test/java/time/temporal/TestYear.java - test/java/time/test/java/time/temporal/TestYearMonth.java Changeset: fb7e3edf22b2 Author: erikj Date: 2013-02-18 11:26 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/fb7e3edf22b2 8008294: build-infra: Build-infra closed fails on solaris 11.1 Reviewed-by: ohrstrom, dholmes, tbell ! makefiles/CompileDemos.gmk ! makefiles/CompileNativeLibraries.gmk Changeset: a23b0df73324 Author: erikj Date: 2013-02-18 11:27 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a23b0df73324 8008295: build-infra: Cleanup in Import.gmk Reviewed-by: ohrstrom, tbell ! makefiles/Import.gmk Changeset: 32549d339437 Author: bpatel Date: 2013-01-21 00:31 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/32549d339437 8006124: javadoc/doclet should be updated to support profiles Reviewed-by: jjg, dholmes ! make/docs/Makefile Changeset: 80afadbf967d Author: alanb Date: 2013-01-21 01:46 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/80afadbf967d 8004182: Add support for profiles in javac Reviewed-by: dholmes ! make/common/Release.gmk Changeset: 353b88963430 Author: dholmes Date: 2013-01-21 21:54 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/353b88963430 8006651: build-infra: Import.gmk needs to add support for the minimal VM Reviewed-by: erikj, ohair ! makefiles/Import.gmk Changeset: 7096f51288ab Author: dholmes Date: 2013-01-21 23:17 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7096f51288ab 8004265: Add build support for Compact Profiles Reviewed-by: erikj, ohair ! make/tools/src/build/tools/jarreorder/JarReorder.java ! makefiles/BuildJdk.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk + makefiles/ProfileNames.gmk + makefiles/Profiles.gmk Changeset: ccd0aceb1190 Author: alanb Date: 2013-01-21 23:20 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ccd0aceb1190 8003255: (profiles) Update JAR file specification to support profiles Reviewed-by: dholmes, mchung, ksrini ! src/share/classes/java/net/URLClassLoader.java ! src/share/classes/java/util/jar/Attributes.java + src/share/classes/java/util/jar/UnsupportedProfileException.java ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/launcher/resources/launcher.properties ! src/share/classes/sun/misc/URLClassPath.java ! src/share/classes/sun/tools/jar/Main.java ! src/share/classes/sun/tools/jar/resources/jar.properties + test/java/net/URLClassLoader/profiles/Basic.java + test/java/net/URLClassLoader/profiles/Lib.java + test/java/net/URLClassLoader/profiles/basic.sh + test/tools/jar/AddAndUpdateProfile.java + test/tools/launcher/profiles/Basic.java + test/tools/launcher/profiles/Logging.java + test/tools/launcher/profiles/Main.java Changeset: c024147205f6 Author: alanb Date: 2013-01-21 23:21 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c024147205f6 8003256: (profiles) Add support for profile identification Reviewed-by: dholmes, mchung, ksrini ! make/java/version/Makefile ! makefiles/GensrcMisc.gmk ! src/share/classes/sun/misc/Version.java.template + test/tools/launcher/profiles/VersionCheck.java Changeset: 4b3434f5f509 Author: alanb Date: 2013-01-21 23:23 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4b3434f5f509 8004931: add/removePropertyChangeListener should not exist in subset Profiles of Java SE Reviewed-by: dholmes, mchung, ksrini + make/tools/src/build/tools/RemoveMethods.java ! makefiles/Tools.gmk ! src/share/classes/java/util/jar/Pack200.java ! src/share/classes/java/util/logging/LogManager.java + test/java/util/logging/Reflect.java + test/tools/pack200/NoBeans.java + test/tools/pack200/Reflect.java Changeset: d9cfe581c8fe Author: alanb Date: 2013-01-21 23:35 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d9cfe581c8fe 8004502: Compact Profiles contents Reviewed-by: dholmes, mchung + makefiles/profile-includes.txt + makefiles/profile-rtjar-includes.txt + test/java/lang/SecurityManager/NoAWT.java + test/java/security/cert/CertStore/NoLDAP.java + test/javax/management/remote/mandatory/connection/NoIIOP.java + test/javax/naming/InitialContext/NoApplet.java + test/sun/net/www/protocol/http/NoNTLM.java + test/sun/security/ssl/sanity/ciphersuites/NoKerberos.java Changeset: d1b29d290ebd Author: dholmes Date: 2013-01-22 19:31 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d1b29d290ebd Merge Changeset: 0918d6d9c18b Author: dholmes Date: 2013-01-22 20:04 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0918d6d9c18b 8006667: Merge issue: Profile attribute need to be examined before custom attributes Summary: swap profile checking and FXHelper checking Reviewed-by: alanb ! src/share/classes/sun/launcher/LauncherHelper.java Changeset: 77668918a388 Author: dholmes Date: 2013-02-04 18:08 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/77668918a388 Merge ! make/docs/Makefile ! makefiles/CreateJars.gmk ! makefiles/GensrcMisc.gmk ! makefiles/Tools.gmk ! src/share/classes/sun/misc/URLClassPath.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/CallbackInterface.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/Callback_Stub.java - test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup_Stub.java Changeset: f308a689c049 Author: dholmes Date: 2013-02-17 16:44 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f308a689c049 Merge ! makefiles/Tools.gmk - src/macosx/classes/sun/lwawt/macosx/EventDispatchAccess.java - src/share/classes/java/lang/annotation/ContainedBy.java - src/share/classes/java/lang/annotation/ContainerFor.java - src/share/classes/java/time/PeriodParser.java - src/share/classes/java/time/calendar/ChronoDateImpl.java - src/share/classes/java/time/calendar/HijrahChrono.java - src/share/classes/java/time/calendar/HijrahDate.java - src/share/classes/java/time/calendar/HijrahDeviationReader.java - src/share/classes/java/time/calendar/HijrahEra.java - src/share/classes/java/time/calendar/JapaneseChrono.java - src/share/classes/java/time/calendar/JapaneseDate.java - src/share/classes/java/time/calendar/JapaneseEra.java - src/share/classes/java/time/calendar/MinguoChrono.java - src/share/classes/java/time/calendar/MinguoDate.java - src/share/classes/java/time/calendar/MinguoEra.java - src/share/classes/java/time/calendar/Ser.java - src/share/classes/java/time/calendar/ThaiBuddhistChrono.java - src/share/classes/java/time/calendar/ThaiBuddhistDate.java - src/share/classes/java/time/calendar/ThaiBuddhistEra.java - src/share/classes/java/time/calendar/package-info.java - src/share/classes/java/time/format/DateTimeFormatters.java - src/share/classes/java/time/format/DateTimePrintException.java - src/share/classes/java/time/temporal/Chrono.java - src/share/classes/java/time/temporal/ChronoLocalDate.java - src/share/classes/java/time/temporal/ChronoLocalDateTime.java - src/share/classes/java/time/temporal/ChronoLocalDateTimeImpl.java - src/share/classes/java/time/temporal/ChronoZonedDateTime.java - src/share/classes/java/time/temporal/ChronoZonedDateTimeImpl.java - src/share/classes/java/time/temporal/Era.java - src/share/classes/java/time/temporal/ISOChrono.java - src/share/classes/java/time/temporal/ISOEra.java - src/share/classes/java/time/temporal/ISOFields.java - src/share/classes/java/time/temporal/MonthDay.java - src/share/classes/java/time/temporal/OffsetDate.java - src/share/classes/java/time/temporal/OffsetDateTime.java - src/share/classes/java/time/temporal/OffsetTime.java - src/share/classes/java/time/temporal/Ser.java - src/share/classes/java/time/temporal/SimplePeriod.java - src/share/classes/java/time/temporal/TemporalAdder.java - src/share/classes/java/time/temporal/TemporalSubtractor.java - src/share/classes/java/time/temporal/Year.java - src/share/classes/java/time/temporal/YearMonth.java - src/share/classes/sun/util/calendar/TzIDOldMapping.java - test/java/net/URL/abnormal_http_urls - test/java/net/URL/ftp_urls - test/java/net/URL/jar_urls - test/java/net/URL/normal_http_urls - test/java/net/URL/runconstructor.sh - test/java/net/URL/share_file_urls - test/java/net/URL/win32_file_urls - test/java/time/META-INF/services/java.time.temporal.Chrono - test/java/time/tck/java/time/calendar/CopticChrono.java - test/java/time/tck/java/time/calendar/CopticDate.java - test/java/time/tck/java/time/calendar/CopticEra.java - test/java/time/tck/java/time/calendar/TestChronoLocalDate.java - test/java/time/tck/java/time/calendar/TestChronoLocalDateTime.java - test/java/time/tck/java/time/calendar/TestHijrahChrono.java - test/java/time/tck/java/time/calendar/TestJapaneseChrono.java - test/java/time/tck/java/time/calendar/TestMinguoChrono.java - test/java/time/tck/java/time/calendar/TestServiceLoader.java - test/java/time/tck/java/time/calendar/TestThaiBuddhistChrono.java - test/java/time/tck/java/time/format/TCKDateTimePrintException.java - test/java/time/tck/java/time/temporal/TCKISOFields.java - test/java/time/tck/java/time/temporal/TCKMonthDay.java - test/java/time/tck/java/time/temporal/TCKOffsetDate.java - test/java/time/tck/java/time/temporal/TCKOffsetDateTime.java - test/java/time/tck/java/time/temporal/TCKOffsetTime.java - test/java/time/tck/java/time/temporal/TCKSimplePeriod.java - test/java/time/tck/java/time/temporal/TCKYear.java - test/java/time/tck/java/time/temporal/TCKYearMonth.java - test/java/time/tck/java/time/temporal/TestChrono.java - test/java/time/tck/java/time/temporal/TestISOChrono.java - test/java/time/test/java/time/TestPeriodParser.java - test/java/time/test/java/time/format/TestDateTimeFormatters.java - test/java/time/test/java/time/format/TestDateTimePrintException.java - test/java/time/test/java/time/format/TestPadParserDecorator.java - test/java/time/test/java/time/format/TestZoneIdParser.java - test/java/time/test/java/time/temporal/TestISOChronoImpl.java - test/java/time/test/java/time/temporal/TestMonthDay.java - test/java/time/test/java/time/temporal/TestOffsetDate.java - test/java/time/test/java/time/temporal/TestOffsetDateTime.java - test/java/time/test/java/time/temporal/TestOffsetDateTime_instants.java - test/java/time/test/java/time/temporal/TestOffsetTime.java - test/java/time/test/java/time/temporal/TestYear.java - test/java/time/test/java/time/temporal/TestYearMonth.java - test/sun/net/www/EncDec.doc - test/sun/net/www/MarkResetTest.java - test/sun/net/www/MarkResetTest.sh - test/sun/security/util/Oid/S11N.sh - test/sun/security/util/Oid/SerialTest.java Changeset: 16c684b2ab82 Author: alanb Date: 2013-02-18 08:57 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/16c684b2ab82 8007436: (profiles) Add JSR-310 to Compact Profiles contents Reviewed-by: dholmes, erikj ! makefiles/profile-includes.txt ! makefiles/profile-rtjar-includes.txt Changeset: c24bc91caa67 Author: dholmes Date: 2013-02-18 15:35 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c24bc91caa67 Merge ! makefiles/Import.gmk Changeset: b46c75e221c7 Author: dholmes Date: 2013-02-19 06:27 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b46c75e221c7 8008424: Isolate PROFILE make variable from incidental setting in the environment Reviewed-by: erikj, alanb ! makefiles/BuildJdk.gmk Changeset: 6f4615fd32da Author: alanb Date: 2013-02-19 11:08 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6f4615fd32da 8007097: (profiles) Build needs test to ensure that profile definitions are updated Reviewed-by: dholmes, erikj - make/tools/src/build/tools/RemoveMethods.java + make/tools/src/build/tools/classfile/RemoveMethods.java + make/tools/src/build/tools/deps/CheckDeps.java + make/tools/src/build/tools/deps/refs.allowed ! makefiles/Images.gmk ! makefiles/Tools.gmk ! makefiles/profile-rtjar-includes.txt Changeset: 033f2707ef32 Author: alanb Date: 2013-02-19 11:32 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/033f2707ef32 Merge Changeset: 00b7535d743f Author: dholmes Date: 2013-02-19 17:32 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/00b7535d743f 8008481: Dependency analyzer needs exclusion for profile builds with JFR disabled Reviewed-by: alanb ! make/tools/src/build/tools/deps/refs.allowed Changeset: bb97c93e4fd7 Author: katleman Date: 2013-02-21 11:13 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bb97c93e4fd7 Added tag jdk8-b78 for changeset 00b7535d743f ! .hgtags Changeset: 934f5f10107d Author: lana Date: 2013-02-22 11:37 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/934f5f10107d Merge Changeset: 4fd6048a78c0 Author: lana Date: 2013-02-22 23:12 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4fd6048a78c0 Merge From andrew.brygin at oracle.com Wed Feb 27 09:45:44 2013 From: andrew.brygin at oracle.com (Andrew Brygin) Date: Wed, 27 Feb 2013 13:45:44 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8008660 : Failure in 2D Queue Flusher thread on Mac In-Reply-To: <5127B370.4010203@oracle.com> References: <5127B370.4010203@oracle.com> Message-ID: <512DD5C8.4060302@oracle.com> Hi Sergey, the fix looks fine to me. Thanks, Andrew On 2/22/2013 10:05 PM, Sergey Bylokhov wrote: > Hello, > Please review the fix for jdk 8. Fix will be ported to jdk7 as well. > There is a few problems: > 1 To eliminate the crash we should check that the system return > correct CGLConfigInfofrom in CGLGraphicsConfig.getConfig(). (see > http://bugs.sun.com/view_bug.do?bug_id=6755274) > 2 Requested opengl attributes are too strict, so we cannot fail-back > to the "software renderer". > Next attrs were removed: > NSOpenGLPFANoRecovery, -> if an accelerated renderer fails due to lack > of resources, OpenGL automatically switches to another renderer. > NSOpenGLPFAAccelerated, -> accelerated renderers are still preferred. > NSOpenGLPFAFullScreen, -> we don't use this functionality. > > Also in this code we try to mix "CoreGraphics display id" and "Screen > index". Currently we never use "screen index" so all related code was > removed/renamed to be more obvious. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008660 > Webrev can be found at: > http://cr.openjdk.java.net/~serb/8008660/webrev.00 >