From philip.race at oracle.com Wed Jan 2 17:23:38 2013 From: philip.race at oracle.com (Phil Race) Date: Wed, 02 Jan 2013 09:23:38 -0800 Subject: [OpenJDK 2D-Dev] what is X11FontScaler? In-Reply-To: References: Message-ID: <50E46D1A.2040706@oracle.com> You mean X11FontScaler.c ? It is (no surprise, surely?) used when needed to ask X11 to scale fonts. Its used instead of freetype when a font is only available via X11. I am not sure why you can't find where its being referenced in the Java sources, since it definitely is .. -phil. On 12/30/2012 12:06 PM, Helbrass wrote: > Hi All! > > Sorry for dumb question, but what's X11FontScaler? Is it used together > with freetypeScaler or instead of it? > > Could not find any info anywhere. In build system it looks like it is > build but I can't find it used on java side... > > Thanx in advance. From lana.steuck at oracle.com Wed Jan 2 19:37:27 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 02 Jan 2013 19:37:27 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/corba: 2 new changesets Message-ID: <20130102193731.D72AD474BD@hg.openjdk.java.net> Changeset: 603cceb495c8 Author: katleman Date: 2012-12-20 09:17 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/603cceb495c8 Added tag jdk8-b69 for changeset 22ddcac208a8 ! .hgtags Changeset: 8171d23e914d Author: katleman Date: 2012-12-27 12:14 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/8171d23e914d Added tag jdk8-b70 for changeset 603cceb495c8 ! .hgtags From lana.steuck at oracle.com Wed Jan 2 19:37:29 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 02 Jan 2013 19:37:29 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d: 12 new changesets Message-ID: <20130102193730.DF5DB474BC@hg.openjdk.java.net> Changeset: 8e36a0fabf58 Author: ohrstrom Date: 2012-12-18 09:57 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/8e36a0fabf58 8004145: New improved hgforest.sh, ctrl-c now properly terminates mercurial processes. Reviewed-by: ohair, erikj + common/bin/hgforest.sh ! get_source.sh Changeset: 51d3b65b8093 Author: erikj Date: 2012-12-18 17:54 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/51d3b65b8093 8001901: build-infra: Fix "misbehaving" which command on Solaris Summary: Removed all uses of which in configure on solaris. Reviewed-by: ohair ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: 6ee8080a6efe Author: katleman Date: 2012-12-19 13:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/6ee8080a6efe Merge Changeset: 32148e971ac8 Author: katleman Date: 2012-12-20 09:17 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/32148e971ac8 Added tag jdk8-b69 for changeset 6ee8080a6efe ! .hgtags Changeset: 6b93e7a4401d Author: dholmes Date: 2012-12-20 01:44 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/rev/6b93e7a4401d 7190137: Add support for JVM_VARIANT minimal1 Summary: Allow configuration of minimal1 as a target VM along with client and server Reviewed-by: ohair, erikj ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 Changeset: cd06b2ea58dd Author: katleman Date: 2012-12-20 16:22 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/cd06b2ea58dd 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! common/makefiles/RMICompilation.gmk Changeset: 105a25ffa4a4 Author: katleman Date: 2012-12-26 14:23 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/105a25ffa4a4 Merge Changeset: 3fb32a5a2388 Author: katleman Date: 2012-12-27 12:14 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/3fb32a5a2388 Added tag jdk8-b70 for changeset 105a25ffa4a4 ! .hgtags Changeset: 2ed5be3dd506 Author: lana Date: 2012-12-16 22:02 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/2ed5be3dd506 Merge Changeset: a0779b1e9a4d Author: jjg Date: 2012-12-17 08:34 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/a0779b1e9a4d 8005090: Include com.sun.source.doctree in Tree API docs Reviewed-by: erikj ! common/makefiles/javadoc/NON_CORE_PKGS.gmk Changeset: 68a81db3ceb1 Author: lana Date: 2012-12-18 17:42 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/68a81db3ceb1 Merge Changeset: 51ad2a343420 Author: lana Date: 2012-12-28 18:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/51ad2a343420 Merge From lana.steuck at oracle.com Wed Jan 2 19:37:36 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 02 Jan 2013 19:37:36 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxws: 2 new changesets Message-ID: <20130102193743.B8BA3474BE@hg.openjdk.java.net> Changeset: 3b1c2733d47e Author: katleman Date: 2012-12-20 09:18 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/3b1c2733d47e Added tag jdk8-b69 for changeset 756323c99011 ! .hgtags Changeset: f577a39c9fb3 Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/f577a39c9fb3 Added tag jdk8-b70 for changeset 3b1c2733d47e ! .hgtags From lana.steuck at oracle.com Wed Jan 2 19:37:36 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 02 Jan 2013 19:37:36 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxp: 9 new changesets Message-ID: <20130102193805.7AF52474BF@hg.openjdk.java.net> Changeset: 27421008f050 Author: katleman Date: 2012-12-20 09:18 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/27421008f050 Added tag jdk8-b69 for changeset 789a855de959 ! .hgtags Changeset: a72c8391cdd6 Author: katleman Date: 2012-12-20 16:23 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/a72c8391cdd6 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! src/com/sun/org/apache/xalan/internal/XalanConstants.java ! src/com/sun/org/apache/xalan/internal/utils/FactoryImpl.java Changeset: 6ec9edffc286 Author: katleman Date: 2012-12-26 14:23 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/6ec9edffc286 Merge Changeset: 63815efd132f Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/63815efd132f Added tag jdk8-b70 for changeset 6ec9edffc286 ! .hgtags Changeset: b1fdb101c82e Author: joehw Date: 2012-12-14 13:24 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/b1fdb101c82e 8003260: [findbug] some fields should be package protected Summary: change public or protected mutable static fields to private or package private. Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java Changeset: 8a20e948b806 Author: lana Date: 2012-12-16 22:05 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/8a20e948b806 Merge Changeset: 15b32367b23c Author: joehw Date: 2012-12-18 21:11 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/15b32367b23c 8003261: static field is public but not final Summary: add final to fVersion field, and make it a non-compile time constant. Reviewed-by: hawtin, lancea, dholmes, chegar ! src/com/sun/org/apache/xerces/internal/impl/Version.java Changeset: d4aea0225e80 Author: joehw Date: 2012-12-27 18:17 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/d4aea0225e80 8005473: Warnings compiling jaxp Summary: clean up compiling warnings. Reviewed-by: weijun, chegar, forax ! src/com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java ! src/javax/xml/transform/FactoryFinder.java ! src/javax/xml/validation/SchemaFactoryFinder.java ! src/javax/xml/xpath/XPathFactoryFinder.java Changeset: 499be952a291 Author: lana Date: 2012-12-28 18:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/499be952a291 Merge From lana.steuck at oracle.com Wed Jan 2 19:37:42 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 02 Jan 2013 19:37:42 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/langtools: 23 new changesets Message-ID: <20130102193847.A0F97474C0@hg.openjdk.java.net> Changeset: 2001991b1b40 Author: katleman Date: 2012-12-20 09:18 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/2001991b1b40 Added tag jdk8-b69 for changeset d7360bf35ee1 ! .hgtags Changeset: 7d34e91f66bb Author: katleman Date: 2012-12-20 16:24 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/7d34e91f66bb 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! make/Makefile-classic ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor8.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor8.java ! test/tools/javac/StringsInSwitch/StringSwitches.java ! test/tools/javac/api/T6395981.java ! test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java ! test/tools/javac/diags/examples/DuplicateAnnotation.java ! test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestKinds.java ! test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase1.java ! test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase2.java ! test/tools/javac/lambda/methodReferenceExecution/MethodReferenceTestSueCase4.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/AttributeInjector.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassFile.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassFilePreprocessor.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/ClassToInterfaceConverter.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/Compiler.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/DirectedClassLoader.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/SourceModel.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/TestHarness.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java ! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/FDSeparateCompilationTest.java ! test/tools/javac/nativeHeaders/javahComparison/CompareTest.java ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java Changeset: 47f71d7c124f Author: katleman Date: 2012-12-26 14:25 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/47f71d7c124f Merge Changeset: 7d5032c2d747 Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/7d5032c2d747 Added tag jdk8-b70 for changeset 47f71d7c124f ! .hgtags Changeset: 37a5d7eccb87 Author: vromero Date: 2012-12-14 11:16 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/37a5d7eccb87 8004976: test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java can fail Reviewed-by: jjg, mcimadamore ! test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java Changeset: de1ec6fc93fe Author: vromero Date: 2012-12-15 13:54 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/de1ec6fc93fe 8000518: Javac generates duplicate name_and_type constant pool entry for class BinaryOpValueExp.java Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java + test/tools/javac/8000518/DuplicateConstantPoolEntry.java ! test/tools/javac/lambda/TestInvokeDynamic.java Changeset: f72dc656a306 Author: lana Date: 2012-12-16 22:10 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/f72dc656a306 Merge Changeset: 02a18f209ab3 Author: vromero Date: 2012-12-17 14:54 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/02a18f209ab3 8004814: javadoc should be able to detect default methods Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/javadoc/ClassDoc.java ! src/share/classes/com/sun/javadoc/MethodDoc.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java Changeset: 75ab654b5cd5 Author: jjg Date: 2012-12-17 07:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/75ab654b5cd5 8004832: Add new doclint package Reviewed-by: mcimadamore ! make/build.properties ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/source/util/JavacTask.java ! src/share/classes/com/sun/source/util/TreePath.java + src/share/classes/com/sun/tools/doclint/Checker.java + src/share/classes/com/sun/tools/doclint/DocLint.java + src/share/classes/com/sun/tools/doclint/Entity.java + src/share/classes/com/sun/tools/doclint/Env.java + src/share/classes/com/sun/tools/doclint/HtmlTag.java + src/share/classes/com/sun/tools/doclint/Messages.java + src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/DCTree.java ! src/share/classes/com/sun/tools/javac/tree/DocPretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/doclint/AccessTest.java + test/tools/doclint/AccessTest.package.out + test/tools/doclint/AccessTest.private.out + test/tools/doclint/AccessTest.protected.out + test/tools/doclint/AccessTest.public.out + test/tools/doclint/AccessibilityTest.java + test/tools/doclint/AccessibilityTest.out + test/tools/doclint/DocLintTester.java + test/tools/doclint/EmptyAuthorTest.java + test/tools/doclint/EmptyAuthorTest.out + test/tools/doclint/EmptyExceptionTest.java + test/tools/doclint/EmptyExceptionTest.out + test/tools/doclint/EmptyParamTest.java + test/tools/doclint/EmptyParamTest.out + test/tools/doclint/EmptyReturnTest.java + test/tools/doclint/EmptyReturnTest.out + test/tools/doclint/EmptySerialDataTest.java + test/tools/doclint/EmptySerialDataTest.out + test/tools/doclint/EmptySerialFieldTest.java + test/tools/doclint/EmptySerialFieldTest.out + test/tools/doclint/EmptySinceTest.java + test/tools/doclint/EmptySinceTest.out + test/tools/doclint/EmptyVersionTest.java + test/tools/doclint/EmptyVersionTest.out + test/tools/doclint/HtmlAttrsTest.java + test/tools/doclint/HtmlAttrsTest.out + test/tools/doclint/HtmlTagsTest.java + test/tools/doclint/HtmlTagsTest.out + test/tools/doclint/MissingCommentTest.java + test/tools/doclint/MissingCommentTest.out + test/tools/doclint/MissingParamsTest.java + test/tools/doclint/MissingParamsTest.out + test/tools/doclint/MissingReturnTest.java + test/tools/doclint/MissingReturnTest.out + test/tools/doclint/MissingThrowsTest.java + test/tools/doclint/MissingThrowsTest.out + test/tools/doclint/OptionTest.java + test/tools/doclint/OverridesTest.java + test/tools/doclint/ReferenceTest.java + test/tools/doclint/ReferenceTest.out + test/tools/doclint/RunTest.java + test/tools/doclint/SyntaxTest.java + test/tools/doclint/SyntaxTest.out + test/tools/doclint/SyntheticTest.java + test/tools/doclint/ValidTest.java + test/tools/doclint/tidy/AnchorAlreadyDefined.java + test/tools/doclint/tidy/AnchorAlreadyDefined.out + test/tools/doclint/tidy/BadEnd.java + test/tools/doclint/tidy/BadEnd.out + test/tools/doclint/tidy/InsertImplicit.java + test/tools/doclint/tidy/InsertImplicit.out + test/tools/doclint/tidy/InvalidEntity.java + test/tools/doclint/tidy/InvalidEntity.out + test/tools/doclint/tidy/InvalidName.java + test/tools/doclint/tidy/InvalidName.out + test/tools/doclint/tidy/InvalidTag.java + test/tools/doclint/tidy/InvalidTag.out + test/tools/doclint/tidy/InvalidURI.java + test/tools/doclint/tidy/InvalidURI.out + test/tools/doclint/tidy/MissingGT.java + test/tools/doclint/tidy/MissingGT.out + test/tools/doclint/tidy/MissingTag.java + test/tools/doclint/tidy/MissingTag.out + test/tools/doclint/tidy/NestedTag.java + test/tools/doclint/tidy/NestedTag.out + test/tools/doclint/tidy/ParaInPre.java + test/tools/doclint/tidy/ParaInPre.out + test/tools/doclint/tidy/README.txt + test/tools/doclint/tidy/RepeatedAttr.java + test/tools/doclint/tidy/RepeatedAttr.out + test/tools/doclint/tidy/TextNotAllowed.java + test/tools/doclint/tidy/TextNotAllowed.out + test/tools/doclint/tidy/TrimmingEmptyTag.java + test/tools/doclint/tidy/TrimmingEmptyTag.out + test/tools/doclint/tidy/UnescapedOrUnknownEntity.java + test/tools/doclint/tidy/UnescapedOrUnknownEntity.out + test/tools/doclint/tidy/util/Main.java + test/tools/doclint/tidy/util/tidy.sh + test/tools/javac/diags/examples/NoContent.java Changeset: f20568328a57 Author: mcimadamore Date: 2012-12-17 16:13 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/f20568328a57 8004099: Bad compiler diagnostic generated when poly expression is passed to non-existent method Summary: Some code paths in resolve do not use methodArguments to correctly format actuals Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/lambda/BadMethodCall2.java + test/tools/javac/lambda/BadMethodCall2.out Changeset: 064e372f273d Author: jjg Date: 2012-12-17 10:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/064e372f273d 8004961: rename Plugin.call to Plugin.init Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/Plugin.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! test/tools/javac/plugin/showtype/ShowTypePlugin.java ! test/tools/javac/plugin/showtype/Test.java Changeset: ef537bcc825a Author: mchung Date: 2012-12-17 15:19 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/ef537bcc825a 8005137: Rename DocLint.call to DocLint.init which overrides Plugin.init Reviewed-by: darcy, jjh ! src/share/classes/com/sun/tools/doclint/DocLint.java Changeset: bc74006c2d8d Author: darcy Date: 2012-12-18 00:24 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/bc74006c2d8d 8005046: Provide checking for a default method in javax.lang.model Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/javax/lang/model/element/ExecutableElement.java + test/tools/javac/processing/model/element/TestExecutableElement.java Changeset: 92fcf299cd09 Author: ohrstrom Date: 2012-12-18 10:23 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/92fcf299cd09 8004657: Add hooks to javac to enable reporting dependency information. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java Changeset: 250f0acf880c Author: mcimadamore Date: 2012-12-18 22:16 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/250f0acf880c 8005193: New regression test test/tools/javac/lambda/BadMethodCall2.java fails Summary: Bad golden file in negative test Reviewed-by: jjh ! test/tools/javac/lambda/BadMethodCall2.out Changeset: 573b38691a74 Author: lana Date: 2012-12-18 18:15 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/573b38691a74 Merge Changeset: 67b01d295cd2 Author: jjg Date: 2012-12-19 11:29 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/67b01d295cd2 8004833: Integrate doclint support into javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/doclint/DocLintTest.java Changeset: f72c9c5aeaef Author: jfranck Date: 2012-12-16 11:09 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/f72c9c5aeaef 8005098: Provide isSynthesized() information on Attribute.Compound Reviewed-by: jjg ! make/build.properties ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterImpl.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java Changeset: a22f23fb7abf Author: jjg Date: 2012-12-20 17:59 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/a22f23fb7abf 8005307: fix missing @bug tags Reviewed-by: jjh ! test/tools/doclint/AccessTest.java ! test/tools/doclint/AccessTest.package.out ! test/tools/doclint/AccessTest.private.out ! test/tools/doclint/AccessTest.protected.out ! test/tools/doclint/AccessTest.public.out ! test/tools/doclint/AccessibilityTest.java ! test/tools/doclint/AccessibilityTest.out ! test/tools/doclint/EmptyAuthorTest.java ! test/tools/doclint/EmptyAuthorTest.out ! test/tools/doclint/EmptyExceptionTest.java ! test/tools/doclint/EmptyExceptionTest.out ! test/tools/doclint/EmptyParamTest.java ! test/tools/doclint/EmptyParamTest.out ! test/tools/doclint/EmptyReturnTest.java ! test/tools/doclint/EmptyReturnTest.out ! test/tools/doclint/EmptySerialDataTest.java ! test/tools/doclint/EmptySerialDataTest.out ! test/tools/doclint/EmptySerialFieldTest.java ! test/tools/doclint/EmptySerialFieldTest.out ! test/tools/doclint/EmptySinceTest.java ! test/tools/doclint/EmptySinceTest.out ! test/tools/doclint/EmptyVersionTest.java ! test/tools/doclint/EmptyVersionTest.out ! test/tools/doclint/HtmlAttrsTest.java ! test/tools/doclint/HtmlAttrsTest.out ! test/tools/doclint/HtmlTagsTest.java ! test/tools/doclint/HtmlTagsTest.out ! test/tools/doclint/MissingParamsTest.java ! test/tools/doclint/MissingParamsTest.out ! test/tools/doclint/MissingReturnTest.java ! test/tools/doclint/MissingReturnTest.out ! test/tools/doclint/MissingThrowsTest.java ! test/tools/doclint/MissingThrowsTest.out ! test/tools/doclint/OptionTest.java ! test/tools/doclint/OverridesTest.java ! test/tools/doclint/ReferenceTest.java ! test/tools/doclint/ReferenceTest.out ! test/tools/doclint/RunTest.java ! test/tools/doclint/SyntaxTest.java ! test/tools/doclint/SyntaxTest.out ! test/tools/doclint/SyntheticTest.java ! test/tools/doclint/ValidTest.java ! test/tools/doclint/tidy/AnchorAlreadyDefined.java ! test/tools/doclint/tidy/AnchorAlreadyDefined.out ! test/tools/doclint/tidy/BadEnd.java ! test/tools/doclint/tidy/BadEnd.out ! test/tools/doclint/tidy/InsertImplicit.java ! test/tools/doclint/tidy/InsertImplicit.out ! test/tools/doclint/tidy/InvalidEntity.java ! test/tools/doclint/tidy/InvalidEntity.out ! test/tools/doclint/tidy/InvalidName.java ! test/tools/doclint/tidy/InvalidName.out ! test/tools/doclint/tidy/InvalidTag.java ! test/tools/doclint/tidy/InvalidTag.out ! test/tools/doclint/tidy/InvalidURI.java ! test/tools/doclint/tidy/InvalidURI.out ! test/tools/doclint/tidy/MissingGT.java ! test/tools/doclint/tidy/MissingGT.out ! test/tools/doclint/tidy/MissingTag.java ! test/tools/doclint/tidy/MissingTag.out ! test/tools/doclint/tidy/NestedTag.java ! test/tools/doclint/tidy/NestedTag.out ! test/tools/doclint/tidy/ParaInPre.java ! test/tools/doclint/tidy/ParaInPre.out ! test/tools/doclint/tidy/RepeatedAttr.java ! test/tools/doclint/tidy/RepeatedAttr.out ! test/tools/doclint/tidy/TextNotAllowed.java ! test/tools/doclint/tidy/TextNotAllowed.out ! test/tools/doclint/tidy/TrimmingEmptyTag.java ! test/tools/doclint/tidy/TrimmingEmptyTag.out ! test/tools/doclint/tidy/UnescapedOrUnknownEntity.java ! test/tools/doclint/tidy/UnescapedOrUnknownEntity.out Changeset: b52a38d4536c Author: darcy Date: 2012-12-21 08:45 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/b52a38d4536c 8005282: Use @library tag with non-relative path for javac tests Reviewed-by: jjg ! test/tools/javac/7129225/TestImportStar.java ! test/tools/javac/cast/intersection/model/Model01.java ! test/tools/javac/classreader/T7031108.java ! test/tools/javac/enum/6350057/T6350057.java ! test/tools/javac/enum/6424358/T6424358.java ! test/tools/javac/file/T7018098.java ! test/tools/javac/multicatch/model/ModelChecker.java ! test/tools/javac/options/T7022337.java ! test/tools/javac/processing/6348499/T6348499.java ! test/tools/javac/processing/6359313/T6359313.java ! test/tools/javac/processing/6365040/T6365040.java ! test/tools/javac/processing/6413690/T6413690.java ! test/tools/javac/processing/6414633/T6414633.java ! test/tools/javac/processing/6430209/T6430209.java ! test/tools/javac/processing/6499119/ClassProcessor.java ! test/tools/javac/processing/6511613/clss41701.java ! test/tools/javac/processing/6512707/T6512707.java ! test/tools/javac/processing/6634138/T6634138.java ! test/tools/javac/processing/6994946/SemanticErrorTest.java ! test/tools/javac/processing/6994946/SyntaxErrorTest.java ! test/tools/javac/processing/T6920317.java ! test/tools/javac/processing/T7196462.java ! test/tools/javac/processing/TestWarnErrorCount.java ! test/tools/javac/processing/environment/TestSourceVersion.java ! test/tools/javac/processing/environment/round/TestContext.java ! test/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java ! test/tools/javac/processing/errors/TestErrorCount.java ! test/tools/javac/processing/errors/TestFatalityOfParseErrors.java ! test/tools/javac/processing/errors/TestOptionSyntaxErrors.java ! test/tools/javac/processing/errors/TestParseErrors/TestParseErrors.java ! test/tools/javac/processing/errors/TestReturnCode.java ! test/tools/javac/processing/filer/TestFilerConstraints.java ! test/tools/javac/processing/filer/TestGetResource.java ! test/tools/javac/processing/filer/TestGetResource2.java ! test/tools/javac/processing/filer/TestInvalidRelativeNames.java ! test/tools/javac/processing/filer/TestLastRound.java ! test/tools/javac/processing/filer/TestPackageInfo.java ! test/tools/javac/processing/filer/TestValidRelativeNames.java ! test/tools/javac/processing/messager/6362067/T6362067.java ! test/tools/javac/processing/messager/MessagerBasics.java ! test/tools/javac/processing/model/6194785/T6194785.java ! test/tools/javac/processing/model/6341534/T6341534.java ! test/tools/javac/processing/model/element/TestAnonClassNames.java ! test/tools/javac/processing/model/element/TestElement.java ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingClass.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass1.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass2.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface1.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface2.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingInterface.java ! test/tools/javac/processing/model/element/TestNames.java ! test/tools/javac/processing/model/element/TestPackageElement.java ! test/tools/javac/processing/model/element/TestResourceElement.java ! test/tools/javac/processing/model/element/TestResourceVariable.java ! test/tools/javac/processing/model/element/TestTypeParameter.java ! test/tools/javac/processing/model/element/TypeParamBounds.java ! test/tools/javac/processing/model/type/MirroredTypeEx/OverEager.java ! test/tools/javac/processing/model/type/MirroredTypeEx/Plurality.java ! test/tools/javac/processing/model/type/NoTypes.java ! test/tools/javac/processing/model/type/TestUnionType.java ! test/tools/javac/processing/model/util/BinaryName.java ! test/tools/javac/processing/model/util/GetTypeElemBadArg.java ! test/tools/javac/processing/model/util/NoSupers.java ! test/tools/javac/processing/model/util/OverridesSpecEx.java ! test/tools/javac/processing/model/util/TypesBadArg.java ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java ! test/tools/javac/processing/model/util/directSupersOfErr/DirectSupersOfErr.java ! test/tools/javac/processing/model/util/elements/TestGetConstantExpression.java ! test/tools/javac/processing/model/util/elements/TestGetPackageOf.java ! test/tools/javac/processing/model/util/filter/TestIterables.java ! test/tools/javac/processing/options/testCommandLineClasses/Test.java ! test/tools/javac/processing/options/testPrintProcessorInfo/Test.java ! test/tools/javac/processing/options/testPrintProcessorInfo/TestWithXstdout.java ! test/tools/javac/processing/warnings/UseImplicit/TestProcUseImplicitWarning.java ! test/tools/javac/processing/werror/WError1.java ! test/tools/javac/processing/werror/WErrorGen.java ! test/tools/javac/processing/werror/WErrorLast.java ! test/tools/javac/resolve/ResolveHarness.java ! test/tools/javac/util/T6597678.java ! test/tools/javac/util/context/T7021650.java Changeset: 189b26e3818f Author: vromero Date: 2012-12-21 15:27 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/189b26e3818f 8003512: javac doesn't work with jar files with >64k entries Reviewed-by: jjg, ksrini Contributed-by: martinrb at google.com ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java + test/tools/javac/file/zip/8003512/LoadClassFromJava6CreatedJarTest.java ! test/tools/javac/file/zip/Utils.java Changeset: 690c41cdab55 Author: bpatel Date: 2012-12-25 17:23 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/690c41cdab55 8004893: the javadoc/doclet needs to be updated to accommodate lambda changes Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MethodTypes.java ! test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java + test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java + test/com/sun/javadoc/testLambdaFeature/pkg/A.java + test/com/sun/javadoc/testLambdaFeature/pkg/B.java ! test/com/sun/javadoc/testMethodTypes/TestMethodTypes.java Changeset: 467e4d9281bc Author: lana Date: 2012-12-28 18:39 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/467e4d9281bc Merge ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java From lana.steuck at oracle.com Wed Jan 2 19:37:53 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 02 Jan 2013 19:37:53 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/hotspot: 47 new changesets Message-ID: <20130102193935.6F2CB474C1@hg.openjdk.java.net> Changeset: 4a2ed49abd51 Author: amurillo Date: 2012-12-07 10:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4a2ed49abd51 8004724: new hotspot build - hs25-b13 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 442f942757c0 Author: johnc Date: 2012-10-01 09:28 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/442f942757c0 8000244: G1: Ergonomically set MarkStackSize and use virtual space for global marking stack Summary: Set the value of MarkStackSize to a value based on the number of parallel marking threads with a reasonable minimum. Expand the marking stack if we have to restart marking due to an overflow up to a reasonable maximum. Allocate the underlying space for the marking stack from virtual memory. Reviewed-by: jmasa, brutisso ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/arguments.cpp Changeset: a14c5698a162 Author: johnc Date: 2012-12-07 16:08 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/a14c5698a162 Merge Changeset: 2aa953165ade Author: brutisso Date: 2012-12-13 10:09 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/2aa953165ade 8004661: Comment and function name java_lang_String::toHash is wrong Summary: renamed to hash_code Reviewed-by: dholmes, coleenp, brutisso Contributed-by: erik.helin at oracle.com ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/symbolTable.cpp Changeset: db8a7163c682 Author: stefank Date: 2012-12-13 09:28 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/db8a7163c682 8004674: Add necessary .inline.hpp files to fix non-PCH build Reviewed-by: stefank, coleenp Contributed-by: volker.simonis at gmail.com ! src/share/vm/gc_implementation/parallelScavenge/adjoiningVirtualSpaces.cpp ! src/share/vm/gc_implementation/shared/gcStats.cpp Changeset: 4459ef2189f5 Author: stefank Date: 2012-12-13 09:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4459ef2189f5 Merge Changeset: fd74228fd5ca Author: jiangli Date: 2012-12-11 12:41 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/fd74228fd5ca 8004076: Move _max_locals and _size_of_parameters to ConstMethod for better sharing. Summary: Move _max_locals and _size_of_parameters to ConstMethod for better sharing. Reviewed-by: coleenp, minqi, jrose ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 807f1d348f7b Author: collins Date: 2012-12-14 11:45 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/807f1d348f7b Merge Changeset: b6c9c0109a60 Author: amurillo Date: 2012-12-14 14:19 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b6c9c0109a60 Merge Changeset: cb8a4e04bc8c Author: amurillo Date: 2012-12-14 14:19 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/cb8a4e04bc8c Added tag hs25-b13 for changeset b6c9c0109a60 ! .hgtags Changeset: 8b4810c80f5d Author: katleman Date: 2012-12-20 09:17 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8b4810c80f5d Added tag jdk8-b69 for changeset cb8a4e04bc8c ! .hgtags Changeset: 1f323009c3ea Author: amurillo Date: 2012-12-14 14:27 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1f323009c3ea 8005036: new hotspot build - hs25-b14 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 892acf0431ef Author: dcubed Date: 2012-12-14 10:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/892acf0431ef 7153050: remove crufty '_g' support from HotSpot repo makefiles Summary: Phase 1 is removing '_g' support from the Makefiles. Reviewed-by: dcubed, sspitsyn, coleenp, tbell Contributed-by: ron.durbin at oracle.com ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/debug.make ! make/bsd/makefiles/dtrace.make ! make/bsd/makefiles/fastdebug.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/jsig.make ! make/bsd/makefiles/jvmg.make ! make/bsd/makefiles/optimized.make ! make/bsd/makefiles/product.make ! make/bsd/makefiles/saproc.make ! make/bsd/makefiles/vm.make ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/debug.make ! make/linux/makefiles/fastdebug.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/jvmg.make ! make/linux/makefiles/optimized.make ! make/linux/makefiles/product.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/vm.make ! make/solaris/Makefile ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/debug.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/fastdebug.make ! make/solaris/makefiles/gcc.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/jvmg.make ! make/solaris/makefiles/optimized.make ! make/solaris/makefiles/product.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/vm.make ! make/windows/build.make ! make/windows/projectfiles/compiler2/ADLCompiler.dsp ! make/windows/projectfiles/tiered/ADLCompiler.dsp Changeset: 30866cd626b0 Author: coleenp Date: 2012-12-12 11:39 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/30866cd626b0 8004883: NPG: clean up anonymous class fix Summary: Add klass_holder() to return either mirror or class_loader depending on if the class is anonymous or not. Reviewed-by: stefank, jrose ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.hpp Changeset: 18712b1caf7a Author: rkennke Date: 2012-12-12 21:40 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/18712b1caf7a 8004898: library_call.cpp build error after 7172640 with GCC 4.7.2 Summary: fix opto/library_call.cpp compilation errors Reviewed-by: twisti, coleenp ! src/share/vm/opto/library_call.cpp Changeset: 8580f22db905 Author: coleenp Date: 2012-12-14 16:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8580f22db905 Merge Changeset: 3f84e17b6bca Author: zgu Date: 2012-12-17 13:14 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/3f84e17b6bca 8004802: jcmd VM.native_memory baseline=false crashes VM Summary: NMT has to check option's value also to determine which command to execute Reviewed-by: acorn, coleenp, hseigel ! src/share/vm/services/nmtDCmd.cpp Changeset: 805aa223d540 Author: zgu Date: 2012-12-17 10:40 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/805aa223d540 Merge Changeset: 594b9b2119ed Author: minqi Date: 2012-12-19 16:10 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/594b9b2119ed Merge Changeset: 0c535211ef13 Author: bharadwaj Date: 2012-12-07 18:13 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/0c535211ef13 8004668: Build failure for Zero target Summary: fixed build failure for Zero target Reviewed-by: twisti, kvn ! src/cpu/zero/vm/assembler_zero.cpp Changeset: a70c88896791 Author: kvn Date: 2012-12-13 17:27 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/a70c88896791 8004713: Stackoverflowerror thrown when thread stack straddles 0x80000000 Summary: use unsigned comparison when checking for stack overflow Reviewed-by: kvn, twisti Contributed-by: paul.nauman at oracle.com ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp Changeset: 1b1e16471e46 Author: stefank Date: 2012-12-12 22:41 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1b1e16471e46 8005002: Crash because of a raw oop in ClassLoaderData::add_dependency Summary: Move the handelization of 'last' to a point before the GC might enter. Reviewed-by: dholmes, sspitsyn, coleenp ! src/share/vm/classfile/classLoaderData.cpp Changeset: 5c0931d15474 Author: twisti Date: 2012-12-14 12:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5c0931d15474 8003238: JSR 292: intermittent exception failure with java/lang/invoke/CallSiteTest.java Reviewed-by: jrose, kvn ! src/share/vm/prims/methodHandles.cpp Changeset: 3c433d080bae Author: twisti Date: 2012-12-14 12:11 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/3c433d080bae Merge Changeset: 18d56ca3e901 Author: twisti Date: 2012-12-17 11:00 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/18d56ca3e901 8004548: remove unused AbstractAssembler::print(Label&) Reviewed-by: kvn, twisti Contributed-by: Bharadwaj Yadavalli ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.hpp ! src/cpu/sparc/vm/macroAssembler_sparc.inline.hpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/assembler_zero.hpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp Changeset: ad5dd04754ee Author: roland Date: 2012-12-18 14:55 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ad5dd04754ee 8005031: Some cleanup in c2 to prepare for incremental inlining support Summary: collection of small changes to prepare for incremental inlining. Reviewed-by: twisti, kvn ! src/share/vm/ci/ciField.cpp ! src/share/vm/compiler/compilerOracle.cpp ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/stringopts.cpp Changeset: eb409f2f146e Author: vlivanov Date: 2012-12-18 06:52 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/eb409f2f146e 8003135: HotSpot inlines and hoists the Thread.currentThread().isInterrupted() out of the loop Summary: Make the load of TLS._osthread._interrupted flag in Thread.isInterrupted(Z)Z intrinsic effectively volatile. Reviewed-by: kvn, jrose ! src/share/vm/opto/library_call.cpp Changeset: 620e502e3f47 Author: vlivanov Date: 2012-12-18 08:19 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/620e502e3f47 Merge ! src/share/vm/opto/library_call.cpp Changeset: c4bd2eccea46 Author: twisti Date: 2012-12-18 10:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c4bd2eccea46 8004536: replace AbstractAssembler emit_word with emit_int16 Reviewed-by: jrose, kvn, twisti Contributed-by: Morris Meyer ! src/cpu/x86/vm/assembler_x86.cpp ! src/share/vm/asm/assembler.hpp Changeset: 1e41b0bc58a0 Author: kvn Date: 2012-12-18 17:37 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1e41b0bc58a0 8004318: JEP-171: Support Unsafe fences intrinsics Summary: Add three memory-ordering intrinsics to the sun.misc.Unsafe class. Reviewed-by: twisti, kvn Contributed-by: Aleksey Shipilev ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/prims/unsafe.cpp Changeset: 65c8342f726a Author: twisti Date: 2012-12-19 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/65c8342f726a 8005033: clear high word for integer pop count on SPARC Reviewed-by: kvn, twisti Contributed-by: Richard Reingruber ! src/cpu/sparc/vm/sparc.ad + test/compiler/8005033/Test8005033.java Changeset: 2c7f594145dc Author: kvn Date: 2012-12-19 15:40 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/2c7f594145dc 8004835: Improve AES intrinsics on x86 Summary: Enable AES intrinsics on non-AVX cpus, group together aes instructions in crypto stubs. Reviewed-by: roland, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! test/compiler/7184394/TestAESBase.java ! test/compiler/7184394/TestAESMain.java Changeset: 2d6c433b1f38 Author: kvn Date: 2012-12-19 19:21 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/2d6c433b1f38 8004741: Missing compiled exception handle table entry for multidimensional array allocation Summary: Added missing exception path for multidimensional array allocation and use Throwable type instead of OutOfMemoryError for allocation's exception. Reviewed-by: twisti ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp + test/compiler/8004741/Test8004741.java Changeset: a46457045d66 Author: kvn Date: 2012-12-20 14:17 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/a46457045d66 8004330: Add missing Unsafe entry points for addAndGet() family Summary: Fix java names for getAndSet intrinsics Reviewed-by: kvn Contributed-by: aleksey.shipilev at oracle.com ! src/share/vm/classfile/vmSymbols.hpp Changeset: d02120b7a34f Author: twisti Date: 2012-12-20 18:53 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d02120b7a34f 8004250: replace AbstractAssembler a_byte/a_long with emit_int8/emit_int32 Reviewed-by: jrose, kvn, twisti Contributed-by: Morris Meyer ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/zero/vm/assembler_zero.cpp ! src/os_cpu/solaris_x86/vm/assembler_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/assembler_windows_x86.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp Changeset: c52660592f37 Author: roland Date: 2012-12-21 01:39 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c52660592f37 Merge ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/opto/library_call.cpp Changeset: 0b3d19153cc6 Author: johnc Date: 2012-12-12 12:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/0b3d19153cc6 8001028: Improve GC option handling Summary: If there are not enough native resources to create the ReferenceHandler or Finalizer Java threads, the VM will attempt to throw an OOME before the java.lang.Class class has been initialized. This can result in assertion failures and other crashes. Move the initialization of the java.lang.Class class to just before the initialization of the java.lang.ref.Finalizer class. Reviewed-by: jwilhelm, dholmes, coleenp ! src/share/vm/runtime/thread.cpp Changeset: 730cc4ddd550 Author: brutisso Date: 2012-12-17 08:49 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/730cc4ddd550 7173959: Jvm crashed during coherence exabus (tmb) testing Summary: Mapping of aligned memory needs to be MT safe. Also reviewed by: vitalyd at gmail.com Reviewed-by: dholmes, coleenp, zgu ! src/os/posix/vm/os_posix.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/virtualspace.cpp Changeset: 32164d89fe9c Author: brutisso Date: 2012-12-17 15:25 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/32164d89fe9c 8004845: Catch incorrect usage of new and delete during compile time for value objects and stack objects Summary: Makes the "new" and "delete" operator of _ValueObj and StackObj private Reviewed-by: dholmes, coleenp Contributed-by: erik.helin at oracle.com ! src/share/vm/memory/allocation.hpp ! src/share/vm/opto/node.cpp ! src/share/vm/services/memBaseline.hpp ! src/share/vm/utilities/workgroup.hpp ! src/share/vm/utilities/yieldingWorkgroup.hpp Changeset: c71879335291 Author: stefank Date: 2012-12-18 10:40 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c71879335291 8005108: NPG: MetaspaceAux::used_in_bytes(), capacity_in_bytes() and reserved_in_bytes() return inconsistent numbers Summary: Reverted the changes to these functions from JDK-8000662 Reviewed-by: brutisso, jmasa ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp Changeset: 345bd97a77be Author: brutisso Date: 2012-12-20 05:31 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/345bd97a77be 8004691: Add a jtreg test that exercises the ExecuteInternalVMTests flag Reviewed-by: stefank, brutisso, kvn, ctornqvi Contributed-by: erik.helin at oracle.com + test/sanity/ExecuteInternalVMTests.java Changeset: 69627aa9ab10 Author: jwilhelm Date: 2012-12-21 16:33 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/69627aa9ab10 Merge ! src/share/vm/runtime/thread.cpp Changeset: 990bbd393c23 Author: amurillo Date: 2012-12-21 10:17 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/990bbd393c23 Merge Changeset: 6a1fc440b396 Author: amurillo Date: 2012-12-21 10:17 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6a1fc440b396 Added tag hs25-b14 for changeset 990bbd393c23 ! .hgtags Changeset: 79f492f184d0 Author: katleman Date: 2012-12-20 16:24 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/79f492f184d0 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! agent/src/share/classes/sun/jvm/hotspot/ci/ciArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciField.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciInstance.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciKlass.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciMetadata.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciObjArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciObject.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciObjectFactory.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciReceiverTypeData.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciSymbol.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciType.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciTypeArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/ci/ciVirtualCallData.java ! agent/src/share/classes/sun/jvm/hotspot/classfile/ClassLoaderData.java ! agent/src/share/classes/sun/jvm/hotspot/memory/LoaderConstraintTable.java ! agent/src/share/classes/sun/jvm/hotspot/oops/BitData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ProfileData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/RetData.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Block.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Block_Array.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Block_List.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallDynamicJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallRuntimeNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/CallStaticJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Compile.java ! agent/src/share/classes/sun/jvm/hotspot/opto/HaltNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/InlineTree.java ! agent/src/share/classes/sun/jvm/hotspot/opto/JVMState.java ! agent/src/share/classes/sun/jvm/hotspot/opto/LoopNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachCallJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachCallNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachCallRuntimeNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachCallStaticJavaNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachIfNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachReturnNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MachSafePointNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/MultiNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Node.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Node_Array.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Node_List.java ! agent/src/share/classes/sun/jvm/hotspot/opto/Phase.java ! agent/src/share/classes/sun/jvm/hotspot/opto/PhaseCFG.java ! agent/src/share/classes/sun/jvm/hotspot/opto/PhaseRegAlloc.java ! agent/src/share/classes/sun/jvm/hotspot/opto/PhiNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/ProjNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/RegionNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/RootNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/SafePointNode.java ! agent/src/share/classes/sun/jvm/hotspot/opto/TypeNode.java ! agent/src/share/classes/sun/jvm/hotspot/prims/JvmtiExport.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/GenericGrowableArray.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/GrowableArray.java ! agent/src/share/native/sadis.c ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/memory/metaspaceCounters.cpp ! src/share/vm/memory/metaspaceCounters.hpp ! src/share/vm/runtime/os_ext.hpp ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/services/diagnosticCommand_ext.hpp ! src/share/vm/services/memReporter.cpp ! src/share/vm/services/memReporter.hpp ! test/runtime/7158804/Test7158804.sh Changeset: e94068d4ff52 Author: katleman Date: 2012-12-26 14:23 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e94068d4ff52 Merge ! src/share/vm/classfile/classLoaderData.hpp Changeset: 0847210f8548 Author: katleman Date: 2012-12-27 12:14 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/0847210f8548 Added tag jdk8-b70 for changeset e94068d4ff52 ! .hgtags From lana.steuck at oracle.com Wed Jan 2 19:39:47 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 02 Jan 2013 19:39:47 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 62 new changesets Message-ID: <20130102195136.77EFB474C2@hg.openjdk.java.net> Changeset: 4ea0ac8e02d2 Author: erikj Date: 2012-12-19 09:46 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4ea0ac8e02d2 8004803: build-infra: Cannot use icedtea as boot for closed build. Summary: Set bootclasspath to javac and not the running jvm Reviewed-by: ohair ! makefiles/CreateJars.gmk Changeset: a8012d8d7e9c Author: katleman Date: 2012-12-19 13:38 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a8012d8d7e9c Merge Changeset: 4d5db5c038b4 Author: katleman Date: 2012-12-20 09:18 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4d5db5c038b4 Added tag jdk8-b69 for changeset a8012d8d7e9c ! .hgtags Changeset: ad6097d547e1 Author: kvn Date: 2012-12-18 17:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ad6097d547e1 8004318: JEP-171: Support Unsafe fences intrinsics Summary: Add three memory-ordering intrinsics to the sun.misc.Unsafe class. Reviewed-by: twisti, kvn Contributed-by: Aleksey Shipilev ! src/share/classes/sun/misc/Unsafe.java Changeset: 12fa4d7ecaf5 Author: twisti Date: 2012-12-20 11:16 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/12fa4d7ecaf5 8005345: JSR 292: JDK performance tweaks Reviewed-by: kvn, jrose ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/sun/invoke/util/ValueConversions.java Changeset: 8cf5b18488d1 Author: dl Date: 2012-12-20 12:24 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/8cf5b18488d1 8004330: Add missing Unsafe entry points for addAndGet() family Summary: Add Unsafe addAndGet() methods which have intrinsics in Hotspot (7023898) Reviewed-by: alanb, kvn ! src/share/classes/sun/misc/Unsafe.java Changeset: 6b41b40526c6 Author: amurillo Date: 2012-12-21 10:27 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6b41b40526c6 Merge Changeset: 1ad29569d6e9 Author: erikj Date: 2012-12-20 13:05 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1ad29569d6e9 8005178: build-infra: Dependency on libfdlibm on mac is broken Reviewed-by: tbell, ohair ! makefiles/CompileNativeLibraries.gmk Changeset: a68090f0dc1a Author: katleman Date: 2012-12-20 16:24 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a68090f0dc1a 8004982: JDK8 source with GPL header errors Reviewed-by: ohair ! src/macosx/native/sun/font/CCharToGlyphMapper.m ! src/share/classes/java/util/function/BinaryOperator.java ! src/share/classes/java/util/function/Block.java ! src/share/classes/java/util/function/DoubleBlock.java ! src/share/classes/java/util/function/Function.java ! src/share/classes/java/util/function/IntBlock.java ! src/share/classes/java/util/function/LongBlock.java ! src/share/classes/java/util/function/Predicate.java ! src/share/classes/sun/java2d/pipe/ParallelogramPipe.java ! src/share/classes/sun/tools/jcmd/JCmd.java ! src/share/native/java/util/zip/zlib-1.2.5/gzlib.c ! src/solaris/native/common/jdk_util_md.h ! src/solaris/native/sun/tools/attach/BsdVirtualMachine.c ! src/windows/classes/java/net/DualStackPlainDatagramSocketImpl.java ! src/windows/native/common/jdk_util_md.h ! test/com/sun/java/swing/plaf/windows/WindowsRadioButtonUI/7089914/bug7089914.java ! test/java/awt/Focus/6981400/Test1.java ! test/java/awt/Focus/6981400/Test2.java ! test/java/awt/Focus/6981400/Test3.java ! test/java/awt/Frame/ResizeAfterSetFont/ResizeAfterSetFont.java ! test/java/awt/JAWT/JAWT.sh ! test/java/awt/JAWT/Makefile.cygwin ! test/java/awt/JAWT/Makefile.unix ! test/java/awt/JAWT/Makefile.win ! test/java/awt/JAWT/MyCanvas.java ! test/java/awt/JAWT/myfile.c ! test/java/awt/JAWT/myfile.cpp ! test/java/awt/TextArea/DisposeTest/TestDispose.java ! test/java/awt/TextArea/TextAreaCaretVisibilityTest/bug7129742.java ! test/java/awt/TextField/DisposeTest/TestDispose.java ! test/java/lang/Integer/Unsigned.java ! test/java/lang/Long/Unsigned.java ! test/java/lang/Math/CubeRootTests.java ! test/java/lang/Math/Expm1Tests.java ! test/java/lang/Math/HyperbolicTests.java ! test/java/lang/Math/Log10Tests.java ! test/java/lang/Math/Log1pTests.java ! test/java/lang/Math/Tests.java ! test/java/lang/StringBuffer/TestSynchronization.java ! test/java/lang/invoke/remote/RemoteExample.java ! test/java/math/BigDecimal/FloatDoubleValueTests.java ! test/java/math/BigDecimal/StrippingZerosTest.java ! test/java/net/Inet4Address/PingThis.java ! test/java/net/ProxySelector/MultiThreadedSystemProxies.java ! test/java/security/Signature/VerifyRangeCheckOverflow.java ! test/java/util/AbstractCollection/ToArrayTest.java ! test/java/util/Map/EntryHashCode.java ! test/java/util/concurrent/FutureTask/DoneTimedGetLoops.java ! test/java/util/logging/LoggerResourceBundleRace.java ! test/java/util/logging/LoggingDeadlock2.java ! test/java/util/logging/LoggingDeadlock3.java ! test/java/util/logging/SimpleFormatterFormat.java ! test/java/util/spi/ResourceBundleControlProvider/providersrc/XmlRB.xml ! test/java/util/spi/ResourceBundleControlProvider/providersrc/XmlRB_ja.xml ! test/javax/swing/JComponent/7154030/bug7154030.java ! test/javax/swing/JTabbedPane/4310381/bug4310381.java ! test/javax/swing/JTable/4235420/bug4235420.java ! test/javax/swing/JTable/6788484/bug6788484.java ! test/javax/swing/JTable/7055065/bug7055065.java ! test/javax/swing/JTable/7188612/JTableAccessibleGetLocationOnScreen.java ! test/javax/swing/JTextArea/7049024/bug7049024.java ! test/javax/swing/border/Test7022041.java ! test/javax/swing/text/DefaultCaret/6938583/bug6938583.java ! test/sun/management/AgentCMETest.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/nio/ch/SelProvider.java ! test/sun/rmi/rmic/classpath/RMICClassPathTest.java ! test/sun/security/krb5/auto/ReplayCache.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/HttpsProxyStackOverflow.java ! test/sun/tools/jps/jps-V_2.sh ! test/tools/jar/JarBackSlash.java ! test/tools/launcher/UnicodeTest.java Changeset: 9dc1990c7d90 Author: yhuang Date: 2012-12-20 18:53 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9dc1990c7d90 7195759: ISO 4217 Amendment 154 Reviewed-by: naoto ! src/share/classes/java/util/CurrencyData.properties ! src/share/classes/java/util/LocaleISOData.java ! src/share/classes/sun/util/resources/CurrencyNames.properties ! test/java/util/Currency/ValidateISO4217.java ! test/java/util/Currency/tablea1.txt ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: cbf255324369 Author: yhuang Date: 2012-12-23 19:11 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cbf255324369 Merge - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: a996b57e5541 Author: katleman Date: 2012-12-26 14:24 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a996b57e5541 Merge Changeset: 8d7651351cfe Author: katleman Date: 2012-12-27 12:15 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/8d7651351cfe Added tag jdk8-b70 for changeset a996b57e5541 ! .hgtags Changeset: 1316d6d0900e Author: lana Date: 2012-12-28 18:28 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1316d6d0900e Merge Changeset: c25ea633b4de Author: malenkov Date: 2012-12-17 16:58 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c25ea633b4de 8005065: [findbugs] reference to mutable array in JavaBeans Reviewed-by: alexsch ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/EventSetDescriptor.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/Statement.java + test/java/beans/Introspector/Test8005065.java Changeset: a78cb3c5d434 Author: neugens Date: 2012-12-17 17:43 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a78cb3c5d434 8005018: X11: focus problems with openjdk 1.7.0 under gnome3 when selected keyboard is not the first in keyboard list Summary: Don't consider extraenous bits when checking button mask, so that grabWindowRef on the window is not confused and released correctly Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XBaseWindow.java ! src/solaris/classes/sun/awt/X11/XConstants.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/X11/XlibUtil.java Changeset: 985b523712c8 Author: kshefov Date: 2012-12-18 15:17 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/985b523712c8 7104594: [macosx] Test closed/javax/swing/JFrame/4962534/bug4962534 expects Metal L&F by default Reviewed-by: yan, alexsch + test/javax/swing/JFrame/4962534/bug4962534.html + test/javax/swing/JFrame/4962534/bug4962534.java Changeset: 90ad9e922042 Author: lana Date: 2012-12-18 16:14 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/90ad9e922042 Merge - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: 7082a96c02d2 Author: alexp Date: 2012-12-21 19:11 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7082a96c02d2 8003982: new test javax/swing/AncestorNotifier/7193219/bug7193219.java failed on macosx Reviewed-by: anthony, alexsch ! test/javax/swing/AncestorNotifier/7193219/bug7193219.java Changeset: 14269f504837 Author: dcherepanov Date: 2012-12-27 16:08 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/14269f504837 8001161: mac: EmbeddedFrame doesn't become active window Reviewed-by: ant ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java Changeset: cf2bcb293f0b Author: lana Date: 2012-12-28 18:30 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cf2bcb293f0b Merge Changeset: 69fd3f3d20c1 Author: alanb Date: 2012-12-15 15:07 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/69fd3f3d20c1 8004963: URLConnection, downgrade normative reference to ${java.home}/lib/content-types.properties Reviewed-by: chegar ! src/share/classes/java/net/URLConnection.java Changeset: eaaec81aa974 Author: weijun Date: 2012-12-17 12:18 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/eaaec81aa974 7197159: accept different kvno if there no match Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/EncryptionKey.java ! test/sun/security/krb5/auto/DynamicKeytab.java + test/sun/security/krb5/auto/KvnoNA.java ! test/sun/security/krb5/auto/MoreKvno.java Changeset: f959e0cc8766 Author: lana Date: 2012-12-16 22:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f959e0cc8766 Merge ! makefiles/CompileNativeLibraries.gmk - src/share/classes/sun/awt/TextureSizeConstraining.java Changeset: a02212de8db6 Author: uta Date: 2012-12-17 14:34 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a02212de8db6 8004928: TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem Summary: the tests were refactored to drop AWT dependence where it was possible. Reviewed-by: alanb, mchung ! test/java/io/Serializable/resolveProxyClass/NonPublicInterface.java ! test/java/lang/Throwable/LegacyChainedExceptionSerialization.java ! test/java/lang/management/CompilationMXBean/Basic.java ! test/java/lang/reflect/Generics/Probe.java ! test/java/lang/reflect/Proxy/ClassRestrictions.java ! test/java/util/Collections/EmptyIterator.java ! test/java/util/logging/LoggingDeadlock4.java ! test/sun/tools/jrunscript/common.sh Changeset: e4d88a7352c6 Author: mullan Date: 2012-12-17 08:28 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e4d88a7352c6 8004234: Downgrade normative references to ${java.home}/lib/security/krb5.conf Reviewed-by: alanb, weijun ! src/share/classes/javax/security/auth/kerberos/package.html Changeset: 4a21f818ebb1 Author: mullan Date: 2012-12-17 08:30 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4a21f818ebb1 Merge - src/share/classes/sun/awt/TextureSizeConstraining.java - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: bcf79e6f52a0 Author: chegar Date: 2012-12-17 16:27 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bcf79e6f52a0 8005081: java/util/prefs/PrefsSpi.sh fails on macos-x Reviewed-by: alanb ! test/java/util/prefs/PrefsSpi.sh Changeset: 9f1b516cd9cb Author: jjg Date: 2012-12-17 08:34 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9f1b516cd9cb 8005090: Include com.sun.source.doctree in Tree API docs Reviewed-by: erikj ! make/docs/NON_CORE_PKGS.gmk Changeset: bac477d67867 Author: jjg Date: 2012-12-17 10:31 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bac477d67867 8004832: Add new doclint package Reviewed-by: erikj, ohair ! make/common/Release.gmk ! make/common/internal/Defs-langtools.gmk ! makefiles/CreateJars.gmk Changeset: 0fabdf676395 Author: martin Date: 2012-12-17 18:39 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0fabdf676395 8004863: Infinite Loop in KeepAliveStream Reviewed-by: chegar ! src/share/classes/sun/net/www/http/KeepAliveStream.java + test/sun/net/www/http/KeepAliveStream/InfiniteLoop.java Changeset: 0a1398021c7c Author: darcy Date: 2012-12-18 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0a1398021c7c 8005042: Add Method.isDefault to core reflection Reviewed-by: alanb, forax, mduigou, jgish, mchung ! src/share/classes/java/lang/reflect/Method.java + test/java/lang/reflect/Method/IsDefaultTest.java Changeset: 6d977f61af5e Author: darcy Date: 2012-12-18 14:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6d977f61af5e 8004699: Add type annotation storage to Constructor, Field and Method Reviewed-by: darcy, dholmes Contributed-by: joel.franck at oracle.com ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Method.java Changeset: e515956879cd Author: lana Date: 2012-12-18 18:14 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e515956879cd Merge Changeset: c79b26b8efe0 Author: sjiang Date: 2012-12-19 11:06 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c79b26b8efe0 7158614: JMXStartStopTest.sh failing intermittently Summary: fixed 3 problems here: 1) checked the lock file too eary 2) never got the process id of a java test 3) some shell commands were not supported in some Solaris machines. Reviewed-by: dsamersoff, alanb ! test/ProblemList.txt ! test/sun/management/jmxremote/startstop/JMXStartStopDoSomething.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh Changeset: 3fd3bcc8bd42 Author: joehw Date: 2012-12-19 12:09 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3fd3bcc8bd42 8004371: (props) Properties.loadFromXML needs small footprint XML parser as fallback when JAXP is not present Reviewed-by: alanb, mchung, psandoz + src/share/classes/jdk/internal/org/xml/sax/Attributes.java + src/share/classes/jdk/internal/org/xml/sax/ContentHandler.java + src/share/classes/jdk/internal/org/xml/sax/DTDHandler.java + src/share/classes/jdk/internal/org/xml/sax/EntityResolver.java + src/share/classes/jdk/internal/org/xml/sax/ErrorHandler.java + src/share/classes/jdk/internal/org/xml/sax/InputSource.java + src/share/classes/jdk/internal/org/xml/sax/Locator.java + src/share/classes/jdk/internal/org/xml/sax/SAXException.java + src/share/classes/jdk/internal/org/xml/sax/SAXNotRecognizedException.java + src/share/classes/jdk/internal/org/xml/sax/SAXNotSupportedException.java + src/share/classes/jdk/internal/org/xml/sax/SAXParseException.java + src/share/classes/jdk/internal/org/xml/sax/XMLReader.java + src/share/classes/jdk/internal/org/xml/sax/helpers/DefaultHandler.java + src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java + src/share/classes/jdk/internal/util/xml/SAXParser.java + src/share/classes/jdk/internal/util/xml/XMLStreamException.java + src/share/classes/jdk/internal/util/xml/XMLStreamWriter.java + src/share/classes/jdk/internal/util/xml/impl/Attrs.java + src/share/classes/jdk/internal/util/xml/impl/Input.java + src/share/classes/jdk/internal/util/xml/impl/Pair.java + src/share/classes/jdk/internal/util/xml/impl/Parser.java + src/share/classes/jdk/internal/util/xml/impl/ParserSAX.java + src/share/classes/jdk/internal/util/xml/impl/ReaderUTF16.java + src/share/classes/jdk/internal/util/xml/impl/ReaderUTF8.java + src/share/classes/jdk/internal/util/xml/impl/SAXParserImpl.java + src/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java + src/share/classes/jdk/internal/util/xml/impl/XMLWriter.java Changeset: cf15abdcdf88 Author: alanb Date: 2012-12-19 14:53 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cf15abdcdf88 8005248: (props) Integrate small footprint parser into Properties Reviewed-by: joehw, mchung, psandoz, erikj ! make/jdk/Makefile - make/jdk/asm/Makefile ! src/share/classes/java/util/Properties.java + src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java ! test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/invalidxml/BadCase.xml + test/java/util/Properties/invalidxml/BadDocType.xml.excluded + test/java/util/Properties/invalidxml/NoClosingTag.xml + test/java/util/Properties/invalidxml/NoDocType.xml.excluded + test/java/util/Properties/invalidxml/NoRoot.xml + test/java/util/Properties/invalidxml/NotQuoted.xml + test/java/util/Properties/invalidxml/README.txt Changeset: 1f9c19741285 Author: darcy Date: 2012-12-19 11:53 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1f9c19741285 8005097: Tie isSynthetic javadoc to the JLS Reviewed-by: mduigou ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Member.java ! src/share/classes/java/lang/reflect/Method.java Changeset: b600d490dc57 Author: dsamersoff Date: 2012-12-20 16:02 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b600d490dc57 6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject Summary: call readObject in all cases Reviewed-by: emcmanus Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/javax/management/MBeanFeatureInfo.java ! src/share/classes/javax/management/MBeanInfo.java Changeset: e43f90d5af11 Author: dsamersoff Date: 2012-12-20 16:56 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e43f90d5af11 6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure Summary: the catch block in the fetchNotifs() method is extended to expect UnmarshalException Reviewed-by: emcmanus Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/com/sun/jmx/remote/internal/ClientNotifForwarder.java Changeset: 3f014bc09297 Author: dsamersoff Date: 2012-12-20 17:24 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3f014bc09297 7009998: JMX synchronization during connection restart is faulty Summary: add a return statement after the re-connecting has finished and the state is CONNECTED Reviewed-by: sjiang Contributed-by: jaroslav.bachorik at oracle.com ! make/netbeans/jmx/build.properties ! src/share/classes/com/sun/jmx/remote/internal/ClientCommunicatorAdmin.java Changeset: d01a810798e0 Author: dl Date: 2012-12-20 13:44 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d01a810798e0 8002356: Add ForkJoin common pool and CountedCompleter Reviewed-by: chegar, mduigou ! make/java/java/FILES_java.gmk + src/share/classes/java/util/concurrent/CountedCompleter.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ForkJoinWorkerThread.java Changeset: 31d2f9995d6c Author: chegar Date: 2012-12-20 15:04 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/31d2f9995d6c 8005306: Redundant cast warning in KeepAliveStream.java Reviewed-by: alanb ! src/share/classes/sun/net/www/http/KeepAliveStream.java Changeset: c1a55ee9618e Author: dsamersoff Date: 2012-12-20 20:12 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c1a55ee9618e 8005309: Missed tests for 6783290,6937053,7009998 Summary: Missed tests for 6783290,6937053,7009998 Reviewed-by: sjiang, emcmanus Contributed-by: jaroslav.bachorik at oracle.com + test/com/sun/jmx/remote/CCAdminReconnectTest.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/Client.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/ConfigKey.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Client/TestNotification.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/ConfigKey.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Server.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/Ste.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/SteMBean.java + test/com/sun/jmx/remote/NotificationMarshalVersions/Server/TestNotification.java + test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh + test/javax/management/MBeanInfo/SerializationTest1.java Changeset: edb71a37fcb7 Author: alanb Date: 2012-12-20 20:29 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/edb71a37fcb7 8001048: JSR-160: Allow IIOP transport to be optional Reviewed-by: dsamersoff, dfuchs, mchung ! src/share/classes/com/sun/jmx/remote/internal/IIOPHelper.java ! src/share/classes/javax/management/remote/JMXConnectorFactory.java ! src/share/classes/javax/management/remote/JMXConnectorServerFactory.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/share/classes/javax/management/remote/rmi/package.html ! test/javax/management/remote/mandatory/connection/AddressableTest.java ! test/javax/management/remote/mandatory/connection/CloseableTest.java ! test/javax/management/remote/mandatory/connection/ConnectionListenerNullTest.java ! test/javax/management/remote/mandatory/connection/IIOPURLTest.java ! test/javax/management/remote/mandatory/connection/IdleTimeoutTest.java ! test/javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java ! test/javax/management/remote/mandatory/connectorServer/SetMBeanServerForwarder.java ! test/javax/management/remote/mandatory/loading/MissingClassTest.java ! test/javax/management/remote/mandatory/provider/ProviderTest.java ! test/javax/management/remote/mandatory/serverError/JMXServerErrorTest.java Changeset: eeda18683ddc Author: alanb Date: 2012-12-20 20:40 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/eeda18683ddc 8005281: (props) loadFromXML/storeToXML with small parser is not thread safe Reviewed-by: mchung ! src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java + test/java/util/Properties/ConcurrentLoadAndStoreXML.java Changeset: 60adb69bf043 Author: smarks Date: 2012-12-20 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/60adb69bf043 8005290: remove -showversion from RMI test library subprocess mechanism Reviewed-by: jgish, chegar, dmocek ! test/java/rmi/testlibrary/JavaVM.java ! test/java/rmi/testlibrary/StreamPipe.java ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java Changeset: 42ee6b6ad373 Author: jbachorik Date: 2012-12-21 09:27 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/42ee6b6ad373 7146162: javax/management/remote/mandatory/connection/BrokenConnectionTest.java failing intermittently Summary: ClientCommunicatorAdmin should call gotIOException((IOException)e) instead of restart((IOException)e) when detecting a communication error, because the method gotIOException will send a failure notification if necessary. Reviewed-by: emcmanus, sjiang Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/com/sun/jmx/remote/internal/ClientCommunicatorAdmin.java Changeset: 86c10d1484e9 Author: sjiang Date: 2012-12-21 10:58 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/86c10d1484e9 8005325: The script should use TESTVMOPTS Summary: Put back TESTVMOPTS which was removed by mistake. Reviewed-by: smarks ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh Changeset: c1227b872a12 Author: joehw Date: 2012-12-21 17:29 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c1227b872a12 8005280: (props) Improve test coverage for small XML parser Summary: added a few more invalid XML files, international characters to LoadAndStore test, and a behavior compatibility test. Reviewed-by: alanb, lancea + test/java/util/Properties/Compatibility.xml + test/java/util/Properties/CompatibilityTest.java ! test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/invalidxml/BadDocType.xml - test/java/util/Properties/invalidxml/BadDocType.xml.excluded + test/java/util/Properties/invalidxml/DTDRootNotMatch.xml + test/java/util/Properties/invalidxml/IllegalComment.xml + test/java/util/Properties/invalidxml/IllegalEntry.xml + test/java/util/Properties/invalidxml/IllegalEntry1.xml + test/java/util/Properties/invalidxml/IllegalKeyAttribute.xml + test/java/util/Properties/invalidxml/NoDocType.xml - test/java/util/Properties/invalidxml/NoDocType.xml.excluded + test/java/util/Properties/invalidxml/NoNamespaceSupport.xml Changeset: 4d28776d7007 Author: mullan Date: 2012-12-26 10:07 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4d28776d7007 8005117: Eliminate dependency from ConfigSpiFile to com.sun.security.auth.login.ConfigFile Reviewed-by: alanb, mchung, weijun ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/sun/security/provider/ConfigSpiFile.java Changeset: d9cab18f326a Author: mullan Date: 2012-12-26 10:08 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d9cab18f326a Merge - make/jdk/asm/Makefile Changeset: 9d984ccd17fc Author: chegar Date: 2012-12-27 21:55 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9d984ccd17fc 8003981: Support Parallel Array Sorting - JEP 103 Reviewed-by: chegar, forax, dholmes, dl Contributed-by: david.holmes at oracle.com, dl at cs.oswego.edu, chris.hegarty at oracle.com ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/Arrays.java + src/share/classes/java/util/ArraysParallelSortHelpers.java + test/java/util/Arrays/ParallelSorting.java Changeset: 4ad38db38fff Author: okutsu Date: 2012-12-28 14:13 +0900 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4ad38db38fff 8005471: DateFormat: Time zone info is not localized when adapter is CLDR Reviewed-by: peytoia ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java + test/java/util/TimeZone/CLDRDisplayNamesTest.java Changeset: 1da019e7999a Author: peytoia Date: 2012-12-28 15:07 +0900 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1da019e7999a 8005277: Regression in JDK 7 in Bidi implementation Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java ! test/java/text/Bidi/BidiConformance.java + test/java/text/Bidi/Bug8005277.java Changeset: f3ac419e2bf0 Author: okutsu Date: 2012-12-28 16:39 +0900 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f3ac419e2bf0 8005561: typo in Calendar Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java Changeset: 645d774b683a Author: xuelei Date: 2012-12-28 00:48 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/645d774b683a 7109274: Restrict the use of certificates with RSA keys less than 1024 bits Summary: This restriction is applied via the Java Security property, "jdk.certpath.disabledAlgorithms". This will impact providers that adhere to this security property. Reviewed-by: mullan ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/security/cert/CertPathBuilder/targetConstraints/BuildEEBasicConstraints.java ! test/java/security/cert/pkix/policyChanges/TestPolicy.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPBuilder.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorIntermediate.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorTrustAnchor.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ClientHandshaker/RSAExport.java + test/sun/security/ssl/javax/net/ssl/TLSv12/DisabledShortRSAKeys.java ! test/sun/security/ssl/javax/net/ssl/TLSv12/ShortRSAKey512.java ! test/sun/security/tools/jarsigner/concise_jarsigner.sh Changeset: 4472a641b4dc Author: xuelei Date: 2012-12-28 03:50 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4472a641b4dc 8003265: Need to clone array of input/output parameters Reviewed-by: mullan ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java Changeset: 46675076f753 Author: sjiang Date: 2012-12-28 16:44 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/46675076f753 7120365: DiffHBTest.java fails due to ConcurrentModificationException Summary: The problem is from the server notification forwarder, it should use a copy of listener set to do iterate. Reviewed-by: alanb ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! test/ProblemList.txt + test/javax/management/remote/mandatory/notif/ConcurrentModificationTest.java Changeset: 0cfcba56cfa7 Author: jgish Date: 2012-12-28 18:32 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0cfcba56cfa7 8005594: Fix to 8003265 breaks build Summary: backout changeset 4472a641b4dc Reviewed-by: smarks, wetmore ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/ldap/BasicControl.java Changeset: ac5e29b62288 Author: smarks Date: 2012-12-28 17:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ac5e29b62288 Merge Changeset: 2a5af0f766d0 Author: lana Date: 2012-12-28 18:36 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2a5af0f766d0 Merge - make/jdk/asm/Makefile ! makefiles/CreateJars.gmk ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh From james.graham at oracle.com Thu Jan 3 01:10:17 2013 From: james.graham at oracle.com (Jim Graham) Date: Wed, 02 Jan 2013 17:10:17 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50D4464F.8050401@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> <50D2DF22.7020007@oracle.com> <50D2E484.3030004@oracle.com> <50D35065.1080307@oracle.com> <50D38628.2050807@oracle.com> <50D39EA4.6050802@oracle.com> <50D3A0B1.2040407@oracle.com> <50D3A530.4070604@oracle.com> <50D3B083.800@oracle.com> <50D3B45F.4010903@oracle.com> <50D3C3D5.7080506@oracle.com> <50D4464F.8050401@oracle.com> Message-ID: <50E4DA79.7020703@oracle.com> Hi Sergey, I guess my primary goal in maintaining this code is to try to find the simplest and most directed fix unless a rewrite is in order - i.e. simply normalizing incoming empty clips so that we end up in a stable "clip is empty" state would be my preference, but perhaps the proposed fix isn't so complicated that I need to worry about that. I've looked deeper into the various Rectangle methods and found lots of little issues with the way that the various bounds methods on Rectangle/Rectangle2D are implemented that complicate all of this. I think a larger rewrite of the clip maintenance code is likely in order at some point. In particular, while your changes have shifted from one set of problematic bounds-setting code to another and may have solved some test case we are currently looking at, I'm not convinced that other bugs, or perhaps even just as many different bugs, are not waiting to bite us with the new code. :( In the meantime, with respect to the new method you've added, I'd like to see the following changes: - The method has nothing really to do with "normalizing a matrix" and is probably misled by the fact that the "matrix" variable in the calling method should never have been called "matrix" in the first place since it is really just a list of coordinates. I'd suggest a name better suited to its purpose, like "fixRectangleOrientation" or "checkEmptyRectangle". - For performance - rather than call signum 4 times, why not use more direct tests like: if ((clip.getWidth() > 0) != (m[2] - m[0] > 0)) // i.e. we only care if their "non-emptiness" is different or: if (clip.getWidth() * (m[2] - m[0]) < 0) // i.e. we only care if their non-zero size is flipped - I still think that we don't owe anybody any need to preserve the size of the empty clip so the adjustments for cases that fail the above tests could simply be "m[2] = m[0]" and thus we get an empty result. Why did you feel that we need to maintain the sizes of empty rectangles? Was it just JCK test failures? Does flipping the results keep us from failing those tests? --------------------- Eventually I'd like to see the following simplifications to our SG2D clip handling: - we only keep a shape around so we can return a shape and we spend a lot of time maintaining it. I'd like to see the shape be only optionally kept if there is a non-rectangle handed in. Otherwise we just maintain the clipRegion. - we use Area to intersect non-rectangular shapes even though it is rare for anyone to call getClip() and even rarer that they do anything with it except to use setClip() on it to restore the clip. I'd rather see keeping an array of the incoming shapes, return a special object from getClip() that just holds that array, and then on setClip() simply restore the region - thus avoiding ever having to use Area. Only if they actually iterate the path of the returned getClip() would it dynamically use Area on the fly to produce that path iteration. - Avoid use of methods on Rectangle[2D] and write our own code that ensures that we perform the correct flipping and integer normalization. Most of that would happen in the Region bounds code if we do the above anyway and that code is much simpler than some of the corresponding methods on Rectangle[2D], plus we can fix bugs in there without worrying about possibly changing the behavior for other apps that may have started to rely on what we see as "bugs". ...jim On 12/21/2012 3:21 AM, Sergey Bylokhov wrote: > 21.12.2012 6:05, Sergey Bylokhov ?????: >> Hi, Jim. >> 21.12.2012 4:59, Jim Graham wrote: >>> The Object.equals() method is not intended to compare geometries. >>> While Area.equals() attempts to perform geometric comparison I think >>> that was a bad idea in retrospect for many reasons: >>> >>> - In practice you can only really compare within a tolerance due to >>> the many ways for computations to every so slightly shift the results >>> >>> - There is no decent way to satisfy the equals/hashcode contract with >>> such a comparison so Area is forever broken with respect to that >>> contract. >>> >>> - It's a complicated test that can only serve to convince developers >>> to invite performance drains into their code by making them think it >>> is a reasonable thing to compare. >>> >>> For testing we should probably use Shape.contains() to verify answers >>> for rectangle arguments and if we want to perform verification on >>> arbitrary shape arguments then we'd need to write our own fuzzy >>> comparator. >> But why fix is incorrect? It just use the same code as sffd for the >> correct shapes and have additional code for incorrect. Only >> conditionchanged from width/height should be positive, to >> width/height should be the same direction as incoming rectangle. >>>>> There isn't even any guarantee that we will hand them back a rectangle >>>>> from getClip(). >>>> One of the jck tests expect this, but I think that this is the wrong >>>> test. >>> >>> There is nothing in the documentation that guarantees a specific type >>> returned from the method. If a JCK test was written to expect a >>> Rectangle from the method then that is a separate problem that we'll >>> have to address at some point. For now I'm only suggesting modifying >>> the process for negative-empty rectangles. Does that trigger the JCK >>> failure? If so, we are still satisfying the documented spec and so >>> we will simply have to confince JCK to allow this exception. >> Problem in jck come from the fact that Rectangle differs from >> Rectangle2d. Note that everything is ok if graphics is not transformed >> or just translated. But if we scale graphics we get: >> 1 getClip() return non equivalent object. >> 2 getClipBounds for Rectangle return it as is, but for Rectangle2D it >> is call getBounds, which return an empty bounds or wrong bounds if >> rectangle2d was normalized by sffd. >> 3 Some tests expects class equivalence between set/get clip. I'll >> prepare CR for them soon. >> >> Also there is the difference in the real clip, if we use type for the >> empty Rectangle to Rectangle2D the real clip became correct. > typo: Also there is the difference in the real clip, if we change type > from the empty Rectangle to the empty Rectangle2D, the real clip will > become correct. >> All these issues are carried out in the testcase. >>>>> After all, if you end up in the drop through case then we hand the >>>>> paths to Area to do intersections and Area will do all sorts of >>>>> surgery on the geometry. >>>> But I sure this area will be equal to the user's clip? >>> >>> For all practical purposes it should be, but not only will the Area >>> code encapsulate the answer in a different class (even if the result >>> is a rectangle), it may reverse the order of the segments, it may >>> represent the area as two separate rectangles that abut each other in >>> a way that they are equivalent to one larger rectangle, but the Area >>> code failed to notice that optimization, etc. All it will guarantee >>> is that it returns a shape that describes the same interior, it will >>> make no guarantees about minimalism or association of segments... >>> >>> ...jim >> >> >> -- >> Best regards, Sergey. > > > -- > Best regards, Sergey. > From james.graham at oracle.com Thu Jan 3 01:16:31 2013 From: james.graham at oracle.com (Jim Graham) Date: Wed, 02 Jan 2013 17:16:31 -0800 Subject: [OpenJDK 2D-Dev] [8] request for review: 7124245: [lcms] ColorConvertOp to color space CS_GRAY apparently converts orange to 244, 244, 0 In-Reply-To: <50D497F2.7000309@oracle.com> References: <50D497F2.7000309@oracle.com> Message-ID: <50E4DBEF.1060506@oracle.com> Hi Andrew, Why the move to source base of 1.5? I have been trying to keep as much of J2DBench still running on 1.2 as I can so that we can do apple-to-apple comparisons across releases of the same benchmark code. Were the 1.5-isms something you could have written with 1.2 language idioms? (I think I saw an enum in there, was that the reason to up the language level to 1.5?) Basically, for the ability to use enums, did we just give up the ability to run the benchmark on 1.2 -> 1.4? Did we weigh those pros/cons? ...jim On 12/21/2012 9:10 AM, Andrew Brygin wrote: > Hello Jennifer and Phil, > > could you please review a fix for CR 8005402? > > Bug: http://bugs.sun.com/view_bug.do?bug_id=8005402 > Webrev: http://cr.openjdk.java.net/~bae/8005402/webrev.00/ > > This fix extends J2DBench with benchmarks for color management: > - ColorConvertOp performance for images and rasters. > - rendering speed for images with non-sRGB color spaces. > - performance of access to profile data. > > Please take a look. > > Thanks, > Andrew. From Sergey.Bylokhov at oracle.com Fri Jan 4 21:51:00 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Sat, 05 Jan 2013 01:51:00 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException In-Reply-To: <50C734F5.8040801@oracle.com> References: <50C734F5.8040801@oracle.com> Message-ID: <50E74EC4.9020302@oracle.com> Hello, 2d team. Does anybody have a chance to review this small fix? 11.12.2012 17:28, Sergey Bylokhov wrote: > Hello, > Please review the fix for jdk 8. > PixelToShapeConverter.makePoly() should not try to close path in case > of the empty arrays of points. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821 > Webrev can be found at: > http://cr.openjdk.java.net/~serb/8004821/webrev.00 > -- Best regards, Sergey. From james.graham at oracle.com Sat Jan 5 19:21:47 2013 From: james.graham at oracle.com (Jim Graham) Date: Sat, 05 Jan 2013 11:21:47 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException In-Reply-To: <50E74EC4.9020302@oracle.com> References: <50C734F5.8040801@oracle.com> <50E74EC4.9020302@oracle.com> Message-ID: <50E87D4B.1060109@oracle.com> Hi Sergey, Does this work OK with 1 point in the array as well? Also, it couldn't hurt to call fillPolygon and drawPolyline as well in the test case just to round out our testing... ...jim On 1/4/2013 1:51 PM, Sergey Bylokhov wrote: > Hello, 2d team. > Does anybody have a chance to review this small fix? > > 11.12.2012 17:28, Sergey Bylokhov wrote: >> Hello, >> Please review the fix for jdk 8. >> PixelToShapeConverter.makePoly() should not try to close path in case >> of the empty arrays of points. >> >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821 >> Webrev can be found at: >> http://cr.openjdk.java.net/~serb/8004821/webrev.00 >> > > From sadhak001 at gmail.com Sun Jan 6 15:24:34 2013 From: sadhak001 at gmail.com (Mani Sarkar) Date: Sun, 6 Jan 2013 15:24:34 +0000 Subject: [OpenJDK 2D-Dev] Fwd: OpenJDK builds: Ant build issues with jdk (netbeans) sub-projects - awt2d, j2se and jarzip In-Reply-To: <50E8D2DB.6090206@oracle.com> References: <50E8D2DB.6090206@oracle.com> Message-ID: Hi, I have been recommended to post my below query to your mailing lists, if it is the right place to post. If not could you recommend who would be best placed to answer the below questions. I couldn't find an appropriate mailing list for 'jarzip' (as it is part of langtools) - any suggestions? It would be great if you could answer my query about it too. Thanks. Regards, Mani On 01/05/2013 04:05 PM, Mani Sarkar wrote: > Hi all, > > I have made some progress with the below three sub-projects, and have > successfully built jarzip. But still get new error messages with awt2d and > j2se. > > I answered my own question about the -source 8, its basically expecting the > images/j2sdk-image to be assigned to the respective ALT_... variables via > the make.options property in build.properties for all three projects. > > Unfortunately I wasn't able to build swing via the .../javax/swing/ folder > where the required make file(s) are present. > > But my other queries still stand, if you can throw some light on them, it > would be help make progress with these builds using the new build system. > > Thanks. > > Regards, > Mani > > On Sat, Jan 5, 2013 at 12:39 AM, Mani Sarkar wrote: > > Hi All, >> >> I have furthered my pursuits with building *OpenJDK projects *by building >> >> the JDK sub-projects like swing, etc... but came across issues with >> building 3 different projects which I wasn't able to build due >> configuration issues. These sub-projects are located under the netbeans >> subfolder under the .../jdk/make/ folder. >> >> They all are getting compiled for version 8 with the below args (which is >> leading to a build failure): >> >> -source 8 -target 8 >> >> *jdk/awt2d* >> >> https://github.com/**neomatrix369/BuildHelpers/**blob/master/** >> EclipseProjectsForOpenJDK/**Logs/jdk/awt2d/awt2dAntBuild.**log >> >> *jdk/j2se* >> >> https://github.com/**neomatrix369/BuildHelpers/**blob/master/** >> EclipseProjectsForOpenJDK/**Logs/jdk/j2se/j2seAntBuild.log >> >> *jdk/jarzip* >> >> >> https://github.com/**neomatrix369/BuildHelpers/**blob/master/** >> EclipseProjectsForOpenJDK/**Logs/jdk/jarzip/**jarzipAntBuild.log >> >> Where is this version configuration set for these projects, that I can >> change either through file changes or alternative build.properties setting >> changes? My other question is why are there no make files available for >> the >> jdk sub-projects (i.e. *awt2d, j2se,* etc...) except for under * >> javax/swing* has make files to build this project instead Ant build.xml >> >> files are available. Is it possible to hook these ant files with the new >> build system, instead of only being able to build the sub-projects via the >> old build system (using the ALT_... variables via make.options). >> >> Thanks. >> >> Regards, >> mani >> >> -- >> Twitter: @theNeomatrix369 >> Blog: http://neomatrix369.wordpress.**com >> > >> >> *Don't chase success, rather aim for "Excellence", and success will come >> chasing after you!* >> >> > > -- Twitter: @theNeomatrix369 Blog: http://neomatrix369.wordpress.com *Don't chase success, rather aim for "Excellence", and success will come chasing after you!* -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.brygin at oracle.com Wed Jan 9 12:25:26 2013 From: andrew.brygin at oracle.com (Andrew Brygin) Date: Wed, 09 Jan 2013 16:25:26 +0400 Subject: [OpenJDK 2D-Dev] [8] request fro review: 8005530: [lcms] Improve performance of ColorConverOp for default destinations Message-ID: <50ED61B6.20207@oracle.com> Hello Jennifer and Phil, could you please review a fix for CR 8005530? CR: http://bugs.sun.com/view_bug.do?bug_id=8005530 Webrev:http://cr.openjdk.java.net/~bae/8005530/webrev.00/ This fix improves performance of ColorConvertOp.filter() operation in case of lcms. The fix can be divided into three separate changes: * provide support for custom component images in LCMSImageLayout. This change affects the case of conversion to default destination. * provide a way to process whole image, instead of scan-by-scan processing, if both source and destination images do not contain padding samples (i.e. next scan starts immediately after previous). * increase optimization level for lcms library from LOW to HIGHEST. This change affects both new and standard build systems. A benchmark comparison below illustrates the increase of performance: Options common across all tests: testname=cmm.colorconv.ccop.op_img cmm.colorconv.ccop.ccopOptions.srcType=BYTE_3BYTE_BGR cmm.colorconv.ccop.ccopOptions.content=photo cmm.opts.profiles=1001 cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: OpenJDK Baseline: 0.152008134 (var=1.02%) (100.0%) *************************************| *************************************| *************************************| OpenJDK Fix: 0.245116358 (var=2.0%) (161.25%) *************************************|********************** *************************************|********************** *************************************|********************* cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: OpenJDK Baseline: 0.914826498 (var=0.41%) (100.0%) ***************************| ***************************| ***************************| OpenJDK Fix: 0.001310043 (var=2.24%) (221.48%) ***************************|******************************** ***************************|******************************** ***************************|******************************** cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: OpenJDK Baseline: 0.060737151 (var=1.57%) (100.0%) ***************| ***************| ***************| OpenJDK Fix: 0.242736486 (var=1.53%) (399.65%) ***************|******************************************* ***************|******************************************** ***************|******************************************** cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: OpenJDK Baseline: 0.559251559 (var=0.7%) (100.0%) *******| *******| *******| OpenJDK Fix: 0.001306904 (var=1.05%) (838.16%) *******|*************************************************** *******|**************************************************** *******|**************************************************** Summary: OpenJDK Baseline: Number of tests: 4 Overall average: 0.053373173444166644 Best spread: 0.41% variance Worst spread: 1.57% variance (Basis for results comparison) OpenJDK Fix: Number of tests: 4 Overall average: 0.12261744826137347 Best spread: 1.05% variance Worst spread: 2.24% variance Comparison to basis: Best result: 838.16% of basis Worst result: 161.25% of basis Number of wins: 4 Number of ties: 0 Number of losses: 0 Thanks, Andrew From anthony.petrov at oracle.com Wed Jan 9 16:08:41 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 09 Jan 2013 20:08:41 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <50DEF3AC.2070600@oracle.com> References: <50DEF3AC.2070600@oracle.com> Message-ID: <50ED9609.1070002@oracle.com> Hi Anton et al., If I read the description of the bug correctly, specifically this part: > The problem occurs, if another thread (for example, GTK thread) is doing the same sort of thing concurrently. This can lead to the following situation. > > JVM thread: Sets J2DXErrHandler(), saves ANY_PREVIOUS_HANDLER as previous > GTK thread: Sets some GTK_HANDLER, saves J2DXErrHandler() as previous > JVM thread: Restores ANY_PREVIOUS_HANDLER > GTK thread: Restores J2DXErrHandler() > JVM thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as previous It is obvious that at this final step 2D is in an inconsistent state. We don't expect to replace our own error handler (and it shouldn't have been there in the first place). I realize that the fix you propose works around this problem. But this doesn't look like an ideal solution to me. BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 error handler only once and never replace it. All the rest of the push_handler/pop_handler logic is now located in Java code (see XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I believe that we should somehow share this machinery with the 2D code to avoid this sort of problems. Though I'm not sure if this will eliminate this exact issue. 2D/AWT folks: any other thoughts? -- best regards, Anthony On 12/29/2012 17:44, Anton Litvinov wrote: > Hello, > > Please review the following fix for a bug. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 > https://jbs.oracle.com/bugs/browse/JDK-8005607 > Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 > > The bug consists in a crash which is caused by a stack overflow for the > reason of an infinite recursion in AWT native function J2DXErrHandler() > under certain circumstances on 32-bit Linux OS. The fix is based on > introduction of the logic, which detects indirect recursive calls to > J2DXErrHandler() by means of a simple counter, to J2DXErrHandler() > native function. Such a solution requires minimum code changes, does not > alter the handler's code significantly and eliminates this bug. > > Adding 2d-dev at openjdk.java.net e-mail alias to the list of recipients of > this letter, because the edited function's name is related to Java 2D > area of JDK, despite of the fact that the edited file is located in AWT > directory. > > Thank you, > Anton From Sergey.Bylokhov at oracle.com Wed Jan 9 16:41:36 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 09 Jan 2013 20:41:36 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException In-Reply-To: <50E87D4B.1060109@oracle.com> References: <50C734F5.8040801@oracle.com> <50E74EC4.9020302@oracle.com> <50E87D4B.1060109@oracle.com> Message-ID: <50ED9DC0.3080509@oracle.com> Hi, Jim. Please review updated version of the fix. http://cr.openjdk.java.net/~serb/8004821/webrev.01 05.01.2013 23:21, Jim Graham wrote: > Hi Sergey, > > Does this work OK with 1 point in the array as well? > > Also, it couldn't hurt to call fillPolygon and drawPolyline as well in > the test case just to round out our testing... > > ...jim > > On 1/4/2013 1:51 PM, Sergey Bylokhov wrote: >> Hello, 2d team. >> Does anybody have a chance to review this small fix? >> >> 11.12.2012 17:28, Sergey Bylokhov wrote: >>> Hello, >>> Please review the fix for jdk 8. >>> PixelToShapeConverter.makePoly() should not try to close path in case >>> of the empty arrays of points. >>> >>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821 >>> Webrev can be found at: >>> http://cr.openjdk.java.net/~serb/8004821/webrev.00 >>> >> >> -- Best regards, Sergey. From philip.race at oracle.com Wed Jan 9 17:07:34 2013 From: philip.race at oracle.com (Phil Race) Date: Wed, 09 Jan 2013 09:07:34 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException In-Reply-To: <50ED9DC0.3080509@oracle.com> References: <50C734F5.8040801@oracle.com> <50E74EC4.9020302@oracle.com> <50E87D4B.1060109@oracle.com> <50ED9DC0.3080509@oracle.com> Message-ID: <50EDA3D6.9080308@oracle.com> Are you implicitly answering Jim's first question with a yes ? If so then the only issue is that you used the wrong GPL header in the test case. Tests should never include the classpath exception. -phil. On 1/9/13 8:41 AM, Sergey Bylokhov wrote: > Hi, Jim. > Please review updated version of the fix. > http://cr.openjdk.java.net/~serb/8004821/webrev.01 > > 05.01.2013 23:21, Jim Graham wrote: >> Hi Sergey, >> >> Does this work OK with 1 point in the array as well? >> >> Also, it couldn't hurt to call fillPolygon and drawPolyline as well >> in the test case just to round out our testing... >> >> ...jim >> >> On 1/4/2013 1:51 PM, Sergey Bylokhov wrote: >>> Hello, 2d team. >>> Does anybody have a chance to review this small fix? >>> >>> 11.12.2012 17:28, Sergey Bylokhov wrote: >>>> Hello, >>>> Please review the fix for jdk 8. >>>> PixelToShapeConverter.makePoly() should not try to close path in case >>>> of the empty arrays of points. >>>> >>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821 >>>> Webrev can be found at: >>>> http://cr.openjdk.java.net/~serb/8004821/webrev.00 >>>> >>> >>> > > From Sergey.Bylokhov at oracle.com Wed Jan 9 17:17:23 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 09 Jan 2013 21:17:23 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException In-Reply-To: <50EDA3D6.9080308@oracle.com> References: <50C734F5.8040801@oracle.com> <50E74EC4.9020302@oracle.com> <50E87D4B.1060109@oracle.com> <50ED9DC0.3080509@oracle.com> <50EDA3D6.9080308@oracle.com> Message-ID: <50EDA623.1010106@oracle.com> Hi, Phil. 09.01.2013 21:07, Phil Race wrote: > Are you implicitly answering Jim's first question with a yes ? Yes. Testcase was updated to verify this. > > If so then the only issue is that you used the wrong GPL header > in the test case. Tests should never include the classpath exception. I didn't know this. I found ~400 of tests contain this text. Where I can find this rule? Thanks. > > -phil. > > On 1/9/13 8:41 AM, Sergey Bylokhov wrote: >> Hi, Jim. >> Please review updated version of the fix. >> http://cr.openjdk.java.net/~serb/8004821/webrev.01 >> >> 05.01.2013 23:21, Jim Graham wrote: >>> Hi Sergey, >>> >>> Does this work OK with 1 point in the array as well? >>> >>> Also, it couldn't hurt to call fillPolygon and drawPolyline as well >>> in the test case just to round out our testing... >>> >>> ...jim >>> >>> On 1/4/2013 1:51 PM, Sergey Bylokhov wrote: >>>> Hello, 2d team. >>>> Does anybody have a chance to review this small fix? >>>> >>>> 11.12.2012 17:28, Sergey Bylokhov wrote: >>>>> Hello, >>>>> Please review the fix for jdk 8. >>>>> PixelToShapeConverter.makePoly() should not try to close path in case >>>>> of the empty arrays of points. >>>>> >>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821 >>>>> Webrev can be found at: >>>>> http://cr.openjdk.java.net/~serb/8004821/webrev.00 >>>>> >>>> >>>> >> >> > -- Best regards, Sergey. From philip.race at oracle.com Wed Jan 9 17:22:31 2013 From: philip.race at oracle.com (Phil Race) Date: Wed, 09 Jan 2013 09:22:31 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException In-Reply-To: <50EDA623.1010106@oracle.com> References: <50C734F5.8040801@oracle.com> <50E74EC4.9020302@oracle.com> <50E87D4B.1060109@oracle.com> <50ED9DC0.3080509@oracle.com> <50EDA3D6.9080308@oracle.com> <50EDA623.1010106@oracle.com> Message-ID: <50EDA757.9030504@oracle.com> I don't know where its phrased that way round but the FAQ at http://openjdk.java.net/faq/ actually says that files should have GPLv2 *except* class libraries which have GPL v2 + CP. So *not* having the classpath is actually the default/norm. Its just that we mostly work with the class libs so thing its the other way around .. -phil On 1/9/13 9:17 AM, Sergey Bylokhov wrote: > Hi, Phil. > 09.01.2013 21:07, Phil Race wrote: >> Are you implicitly answering Jim's first question with a yes ? > Yes. Testcase was updated to verify this. >> >> If so then the only issue is that you used the wrong GPL header >> in the test case. Tests should never include the classpath exception. > I didn't know this. I found ~400 of tests contain this text. Where I > can find this rule? > Thanks. >> >> -phil. >> >> On 1/9/13 8:41 AM, Sergey Bylokhov wrote: >>> Hi, Jim. >>> Please review updated version of the fix. >>> http://cr.openjdk.java.net/~serb/8004821/webrev.01 >>> >>> 05.01.2013 23:21, Jim Graham wrote: >>>> Hi Sergey, >>>> >>>> Does this work OK with 1 point in the array as well? >>>> >>>> Also, it couldn't hurt to call fillPolygon and drawPolyline as well >>>> in the test case just to round out our testing... >>>> >>>> ...jim >>>> >>>> On 1/4/2013 1:51 PM, Sergey Bylokhov wrote: >>>>> Hello, 2d team. >>>>> Does anybody have a chance to review this small fix? >>>>> >>>>> 11.12.2012 17:28, Sergey Bylokhov wrote: >>>>>> Hello, >>>>>> Please review the fix for jdk 8. >>>>>> PixelToShapeConverter.makePoly() should not try to close path in >>>>>> case >>>>>> of the empty arrays of points. >>>>>> >>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821 >>>>>> Webrev can be found at: >>>>>> http://cr.openjdk.java.net/~serb/8004821/webrev.00 >>>>>> >>>>> >>>>> >>> >>> >> > > From james.graham at oracle.com Thu Jan 10 01:42:03 2013 From: james.graham at oracle.com (Jim Graham) Date: Wed, 09 Jan 2013 17:42:03 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException In-Reply-To: <50EDA623.1010106@oracle.com> References: <50C734F5.8040801@oracle.com> <50E74EC4.9020302@oracle.com> <50E87D4B.1060109@oracle.com> <50ED9DC0.3080509@oracle.com> <50EDA3D6.9080308@oracle.com> <50EDA623.1010106@oracle.com> Message-ID: <50EE1C6B.9090509@oracle.com> This looks fine to me. I might add another pair of "test" calls before the translate (i.e. test, translate, test, scale, test, dispose). Approved with that minor change (and Phil's header issue)... ...jim On 1/9/13 9:17 AM, Sergey Bylokhov wrote: > Hi, Phil. > 09.01.2013 21:07, Phil Race wrote: >> Are you implicitly answering Jim's first question with a yes ? > Yes. Testcase was updated to verify this. >> >> If so then the only issue is that you used the wrong GPL header >> in the test case. Tests should never include the classpath exception. > I didn't know this. I found ~400 of tests contain this text. Where I can > find this rule? > Thanks. >> >> -phil. >> >> On 1/9/13 8:41 AM, Sergey Bylokhov wrote: >>> Hi, Jim. >>> Please review updated version of the fix. >>> http://cr.openjdk.java.net/~serb/8004821/webrev.01 >>> >>> 05.01.2013 23:21, Jim Graham wrote: >>>> Hi Sergey, >>>> >>>> Does this work OK with 1 point in the array as well? >>>> >>>> Also, it couldn't hurt to call fillPolygon and drawPolyline as well >>>> in the test case just to round out our testing... >>>> >>>> ...jim >>>> >>>> On 1/4/2013 1:51 PM, Sergey Bylokhov wrote: >>>>> Hello, 2d team. >>>>> Does anybody have a chance to review this small fix? >>>>> >>>>> 11.12.2012 17:28, Sergey Bylokhov wrote: >>>>>> Hello, >>>>>> Please review the fix for jdk 8. >>>>>> PixelToShapeConverter.makePoly() should not try to close path in case >>>>>> of the empty arrays of points. >>>>>> >>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821 >>>>>> Webrev can be found at: >>>>>> http://cr.openjdk.java.net/~serb/8004821/webrev.00 >>>>>> >>>>> >>>>> >>> >>> >> > > From james.graham at oracle.com Thu Jan 10 01:44:11 2013 From: james.graham at oracle.com (Jim Graham) Date: Wed, 09 Jan 2013 17:44:11 -0800 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <50ED9609.1070002@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> Message-ID: <50EE1CEB.5080500@oracle.com> I think I'd rather see some way to prevent double-adding the handler in the first place as well. Since it is only ever used on errors I also think it is OK to set it once and leave it there forever... ...jim On 1/9/13 8:08 AM, Anthony Petrov wrote: > Hi Anton et al., > > If I read the description of the bug correctly, specifically this part: > >> The problem occurs, if another thread (for example, GTK thread) is >> doing the same sort of thing concurrently. This can lead to the >> following situation. >> JVM thread: Sets J2DXErrHandler(), saves ANY_PREVIOUS_HANDLER as >> previous GTK thread: Sets some GTK_HANDLER, saves >> J2DXErrHandler() as previous JVM thread: Restores >> ANY_PREVIOUS_HANDLER GTK thread: Restores J2DXErrHandler() JVM >> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as previous > > It is obvious that at this final step 2D is in an inconsistent state. We > don't expect to replace our own error handler (and it shouldn't have > been there in the first place). > > I realize that the fix you propose works around this problem. But this > doesn't look like an ideal solution to me. > > BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 error > handler only once and never replace it. All the rest of the > push_handler/pop_handler logic is now located in Java code (see > XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I believe > that we should somehow share this machinery with the 2D code to avoid > this sort of problems. Though I'm not sure if this will eliminate this > exact issue. > > > 2D/AWT folks: any other thoughts? > > -- > best regards, > Anthony > > On 12/29/2012 17:44, Anton Litvinov wrote: >> Hello, >> >> Please review the following fix for a bug. >> >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >> https://jbs.oracle.com/bugs/browse/JDK-8005607 >> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >> >> The bug consists in a crash which is caused by a stack overflow for >> the reason of an infinite recursion in AWT native function >> J2DXErrHandler() under certain circumstances on 32-bit Linux OS. The >> fix is based on introduction of the logic, which detects indirect >> recursive calls to J2DXErrHandler() by means of a simple counter, to >> J2DXErrHandler() native function. Such a solution requires minimum >> code changes, does not alter the handler's code significantly and >> eliminates this bug. >> >> Adding 2d-dev at openjdk.java.net e-mail alias to the list of recipients >> of this letter, because the edited function's name is related to Java >> 2D area of JDK, despite of the fact that the edited file is located in >> AWT directory. >> >> Thank you, >> Anton From anthony.petrov at oracle.com Thu Jan 10 13:49:40 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 10 Jan 2013 17:49:40 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <50EE1CEB.5080500@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> <50EE1CEB.5080500@oracle.com> Message-ID: <50EEC6F4.5040001@oracle.com> Yes, I agree. I think the simplest fix would be to install the J2DXErrHandler() just once, and either simply relay to the ANY_PREVIOUS_HANDLER, or do its current job depending on whether the 2D code currently wants it. -- best regards, Anthony On 01/10/13 05:44, Jim Graham wrote: > I think I'd rather see some way to prevent double-adding the handler in > the first place as well. Since it is only ever used on errors I also > think it is OK to set it once and leave it there forever... > > ...jim > > On 1/9/13 8:08 AM, Anthony Petrov wrote: >> Hi Anton et al., >> >> If I read the description of the bug correctly, specifically this part: >> >>> The problem occurs, if another thread (for example, GTK thread) is >>> doing the same sort of thing concurrently. This can lead to the >>> following situation. >>> JVM thread: Sets J2DXErrHandler(), saves ANY_PREVIOUS_HANDLER as >>> previous GTK thread: Sets some GTK_HANDLER, saves >>> J2DXErrHandler() as previous JVM thread: Restores >>> ANY_PREVIOUS_HANDLER GTK thread: Restores J2DXErrHandler() JVM >>> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as previous >> >> It is obvious that at this final step 2D is in an inconsistent state. We >> don't expect to replace our own error handler (and it shouldn't have >> been there in the first place). >> >> I realize that the fix you propose works around this problem. But this >> doesn't look like an ideal solution to me. >> >> BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 error >> handler only once and never replace it. All the rest of the >> push_handler/pop_handler logic is now located in Java code (see >> XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I believe >> that we should somehow share this machinery with the 2D code to avoid >> this sort of problems. Though I'm not sure if this will eliminate this >> exact issue. >> >> >> 2D/AWT folks: any other thoughts? >> >> -- >> best regards, >> Anthony >> >> On 12/29/2012 17:44, Anton Litvinov wrote: >>> Hello, >>> >>> Please review the following fix for a bug. >>> >>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >>> https://jbs.oracle.com/bugs/browse/JDK-8005607 >>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >>> >>> The bug consists in a crash which is caused by a stack overflow for >>> the reason of an infinite recursion in AWT native function >>> J2DXErrHandler() under certain circumstances on 32-bit Linux OS. The >>> fix is based on introduction of the logic, which detects indirect >>> recursive calls to J2DXErrHandler() by means of a simple counter, to >>> J2DXErrHandler() native function. Such a solution requires minimum >>> code changes, does not alter the handler's code significantly and >>> eliminates this bug. >>> >>> Adding 2d-dev at openjdk.java.net e-mail alias to the list of recipients >>> of this letter, because the edited function's name is related to Java >>> 2D area of JDK, despite of the fact that the edited file is located in >>> AWT directory. >>> >>> Thank you, >>> Anton From Sergey.Bylokhov at oracle.com Thu Jan 10 15:34:03 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 10 Jan 2013 19:34:03 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException In-Reply-To: <50EDA757.9030504@oracle.com> References: <50C734F5.8040801@oracle.com> <50E74EC4.9020302@oracle.com> <50E87D4B.1060109@oracle.com> <50ED9DC0.3080509@oracle.com> <50EDA3D6.9080308@oracle.com> <50EDA623.1010106@oracle.com> <50EDA757.9030504@oracle.com> Message-ID: <50EEDF6B.2000003@oracle.com> Hi, Phil. The test updated according to your notes. http://cr.openjdk.java.net/~serb/8004821/webrev.02 09.01.2013 21:22, Phil Race wrote: > I don't know where its phrased that way round but the FAQ > at http://openjdk.java.net/faq/ > > actually says that files should have GPLv2 *except* class libraries > which have GPL v2 + CP. > > So *not* having the classpath is actually the default/norm. > Its just that we mostly work with the class libs so thing its > the other way around .. > > -phil > > On 1/9/13 9:17 AM, Sergey Bylokhov wrote: >> Hi, Phil. >> 09.01.2013 21:07, Phil Race wrote: >>> Are you implicitly answering Jim's first question with a yes ? >> Yes. Testcase was updated to verify this. >>> >>> If so then the only issue is that you used the wrong GPL header >>> in the test case. Tests should never include the classpath exception. >> I didn't know this. I found ~400 of tests contain this text. Where I >> can find this rule? >> Thanks. >>> >>> -phil. >>> >>> On 1/9/13 8:41 AM, Sergey Bylokhov wrote: >>>> Hi, Jim. >>>> Please review updated version of the fix. >>>> http://cr.openjdk.java.net/~serb/8004821/webrev.01 >>>> >>>> 05.01.2013 23:21, Jim Graham wrote: >>>>> Hi Sergey, >>>>> >>>>> Does this work OK with 1 point in the array as well? >>>>> >>>>> Also, it couldn't hurt to call fillPolygon and drawPolyline as >>>>> well in the test case just to round out our testing... >>>>> >>>>> ...jim >>>>> >>>>> On 1/4/2013 1:51 PM, Sergey Bylokhov wrote: >>>>>> Hello, 2d team. >>>>>> Does anybody have a chance to review this small fix? >>>>>> >>>>>> 11.12.2012 17:28, Sergey Bylokhov wrote: >>>>>>> Hello, >>>>>>> Please review the fix for jdk 8. >>>>>>> PixelToShapeConverter.makePoly() should not try to close path in >>>>>>> case >>>>>>> of the empty arrays of points. >>>>>>> >>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821 >>>>>>> Webrev can be found at: >>>>>>> http://cr.openjdk.java.net/~serb/8004821/webrev.00 >>>>>>> >>>>>> >>>>>> >>>> >>>> >>> >> >> > -- Best regards, Sergey. From james.graham at oracle.com Fri Jan 11 00:32:02 2013 From: james.graham at oracle.com (Jim Graham) Date: Thu, 10 Jan 2013 16:32:02 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException In-Reply-To: <50EEDF6B.2000003@oracle.com> References: <50C734F5.8040801@oracle.com> <50E74EC4.9020302@oracle.com> <50E87D4B.1060109@oracle.com> <50ED9DC0.3080509@oracle.com> <50EDA3D6.9080308@oracle.com> <50EDA623.1010106@oracle.com> <50EDA757.9030504@oracle.com> <50EEDF6B.2000003@oracle.com> Message-ID: <50EF5D82.1080103@oracle.com> Looks good from my perspective... ...jim On 1/10/13 7:34 AM, Sergey Bylokhov wrote: > Hi, Phil. > The test updated according to your notes. > > http://cr.openjdk.java.net/~serb/8004821/webrev.02 > > 09.01.2013 21:22, Phil Race wrote: >> I don't know where its phrased that way round but the FAQ >> at http://openjdk.java.net/faq/ >> >> actually says that files should have GPLv2 *except* class libraries >> which have GPL v2 + CP. >> >> So *not* having the classpath is actually the default/norm. >> Its just that we mostly work with the class libs so thing its >> the other way around .. >> >> -phil >> >> On 1/9/13 9:17 AM, Sergey Bylokhov wrote: >>> Hi, Phil. >>> 09.01.2013 21:07, Phil Race wrote: >>>> Are you implicitly answering Jim's first question with a yes ? >>> Yes. Testcase was updated to verify this. >>>> >>>> If so then the only issue is that you used the wrong GPL header >>>> in the test case. Tests should never include the classpath exception. >>> I didn't know this. I found ~400 of tests contain this text. Where I >>> can find this rule? >>> Thanks. >>>> >>>> -phil. >>>> >>>> On 1/9/13 8:41 AM, Sergey Bylokhov wrote: >>>>> Hi, Jim. >>>>> Please review updated version of the fix. >>>>> http://cr.openjdk.java.net/~serb/8004821/webrev.01 >>>>> >>>>> 05.01.2013 23:21, Jim Graham wrote: >>>>>> Hi Sergey, >>>>>> >>>>>> Does this work OK with 1 point in the array as well? >>>>>> >>>>>> Also, it couldn't hurt to call fillPolygon and drawPolyline as >>>>>> well in the test case just to round out our testing... >>>>>> >>>>>> ...jim >>>>>> >>>>>> On 1/4/2013 1:51 PM, Sergey Bylokhov wrote: >>>>>>> Hello, 2d team. >>>>>>> Does anybody have a chance to review this small fix? >>>>>>> >>>>>>> 11.12.2012 17:28, Sergey Bylokhov wrote: >>>>>>>> Hello, >>>>>>>> Please review the fix for jdk 8. >>>>>>>> PixelToShapeConverter.makePoly() should not try to close path in >>>>>>>> case >>>>>>>> of the empty arrays of points. >>>>>>>> >>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821 >>>>>>>> Webrev can be found at: >>>>>>>> http://cr.openjdk.java.net/~serb/8004821/webrev.00 >>>>>>>> >>>>>>> >>>>>>> >>>>> >>>>> >>>> >>> >>> >> > > From anton.litvinov at oracle.com Fri Jan 11 10:03:54 2013 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Fri, 11 Jan 2013 14:03:54 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <50ED9609.1070002@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> Message-ID: <50EFE38A.4030507@oracle.com> Hello Anthony, Thank you very much for the review of this request. Yes, you understood the description of the bug correctly. After several discussions with Artem I also was recommended to redesign J2DXErrHandler() as a Java synthetic handler and to exploit "sun.awt.X11.XTookit.WITH_XERROR_HANDLER" through JNI from all the places in native code which currently set/unset J2DXErrHandler(). I managed to implement this solution, but it led to a crash with IndexOutOfBoundsException not in places of "src/solaris/native/sun/awt/awt_GraphicsEnv.c", "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" files, where substitution for the Java synthetic handler was made, but in some other AWT Java files handling fonts. I was not able to resolve this crash and came to a conclusion that, perhaps, static initialization of "sun.awt.X11.XToolkit" class in void TryInitMITShm(JNIEnv *env, jint *shmExt, jint *shmPixmaps) function of "src/solaris/native/sun/awt/awt_GraphicsEnv.c", which was initiated by the code from the fix, should not have happened so early. Probably, some mistake was done in implementation of the fix involving JNI. Then I will try to return to the solution with synthetic handlers from XToolkit. Thank you, Anton On 1/9/2013 8:08 PM, Anthony Petrov wrote: > Hi Anton et al., > > If I read the description of the bug correctly, specifically this part: > >> The problem occurs, if another thread (for example, GTK thread) is >> doing the same sort of thing concurrently. This can lead to the >> following situation. >> JVM thread: Sets J2DXErrHandler(), saves ANY_PREVIOUS_HANDLER as >> previous GTK thread: Sets some GTK_HANDLER, saves >> J2DXErrHandler() as previous JVM thread: Restores >> ANY_PREVIOUS_HANDLER GTK thread: Restores J2DXErrHandler() JVM >> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as previous > > It is obvious that at this final step 2D is in an inconsistent state. > We don't expect to replace our own error handler (and it shouldn't > have been there in the first place). > > I realize that the fix you propose works around this problem. But this > doesn't look like an ideal solution to me. > > BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 error > handler only once and never replace it. All the rest of the > push_handler/pop_handler logic is now located in Java code (see > XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I believe > that we should somehow share this machinery with the 2D code to avoid > this sort of problems. Though I'm not sure if this will eliminate this > exact issue. > > > 2D/AWT folks: any other thoughts? > > -- > best regards, > Anthony > > On 12/29/2012 17:44, Anton Litvinov wrote: >> Hello, >> >> Please review the following fix for a bug. >> >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >> https://jbs.oracle.com/bugs/browse/JDK-8005607 >> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >> >> The bug consists in a crash which is caused by a stack overflow for >> the reason of an infinite recursion in AWT native function >> J2DXErrHandler() under certain circumstances on 32-bit Linux OS. The >> fix is based on introduction of the logic, which detects indirect >> recursive calls to J2DXErrHandler() by means of a simple counter, to >> J2DXErrHandler() native function. Such a solution requires minimum >> code changes, does not alter the handler's code significantly and >> eliminates this bug. >> >> Adding 2d-dev at openjdk.java.net e-mail alias to the list of recipients >> of this letter, because the edited function's name is related to Java >> 2D area of JDK, despite of the fact that the edited file is located >> in AWT directory. >> >> Thank you, >> Anton From anton.litvinov at oracle.com Fri Jan 11 10:44:34 2013 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Fri, 11 Jan 2013 14:44:34 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <50EE1CEB.5080500@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> <50EE1CEB.5080500@oracle.com> Message-ID: <50EFED12.6070700@oracle.com> Hello Jim, Thank you very much for the review and provision of a new idea of a solution. Elimination of the logic, which sets/unsets J2DXErrHandler() for each call "XShmAttach(awt_display, &shminfo))" should effectively resolve the issue, but only in case if all other native error handlers, which were set by the system function "XSetErrorHandler()" in JDK or in any external library, observe the rule of relaying of all events, which are not relative to them, to the previously saved error handlers. Otherwise an error generated during "XShmAttach" function call will not be handled by J2DXErrHandler(). Could you answer the following question. By setting J2DXErrHandler() only once and forever do you mean usage of AWT global event handler "static int ToolkitErrorHandler(Display * dpy, XErrorEvent * event)" from "src/solaris/native/sun/xawt/XlibWrapper.c" with Java synthetic handlers or creation of another global native error handler with J2DXErrHandler as native synthetic handler? Thank you, Anton On 1/10/2013 5:44 AM, Jim Graham wrote: > I think I'd rather see some way to prevent double-adding the handler > in the first place as well. Since it is only ever used on errors I > also think it is OK to set it once and leave it there forever... > > ...jim > > On 1/9/13 8:08 AM, Anthony Petrov wrote: >> Hi Anton et al., >> >> If I read the description of the bug correctly, specifically this part: >> >>> The problem occurs, if another thread (for example, GTK thread) is >>> doing the same sort of thing concurrently. This can lead to the >>> following situation. >>> JVM thread: Sets J2DXErrHandler(), saves ANY_PREVIOUS_HANDLER as >>> previous GTK thread: Sets some GTK_HANDLER, saves >>> J2DXErrHandler() as previous JVM thread: Restores >>> ANY_PREVIOUS_HANDLER GTK thread: Restores J2DXErrHandler() JVM >>> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as previous >> >> It is obvious that at this final step 2D is in an inconsistent state. We >> don't expect to replace our own error handler (and it shouldn't have >> been there in the first place). >> >> I realize that the fix you propose works around this problem. But this >> doesn't look like an ideal solution to me. >> >> BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 error >> handler only once and never replace it. All the rest of the >> push_handler/pop_handler logic is now located in Java code (see >> XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I believe >> that we should somehow share this machinery with the 2D code to avoid >> this sort of problems. Though I'm not sure if this will eliminate this >> exact issue. >> >> >> 2D/AWT folks: any other thoughts? >> >> -- >> best regards, >> Anthony >> >> On 12/29/2012 17:44, Anton Litvinov wrote: >>> Hello, >>> >>> Please review the following fix for a bug. >>> >>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >>> https://jbs.oracle.com/bugs/browse/JDK-8005607 >>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >>> >>> The bug consists in a crash which is caused by a stack overflow for >>> the reason of an infinite recursion in AWT native function >>> J2DXErrHandler() under certain circumstances on 32-bit Linux OS. The >>> fix is based on introduction of the logic, which detects indirect >>> recursive calls to J2DXErrHandler() by means of a simple counter, to >>> J2DXErrHandler() native function. Such a solution requires minimum >>> code changes, does not alter the handler's code significantly and >>> eliminates this bug. >>> >>> Adding 2d-dev at openjdk.java.net e-mail alias to the list of recipients >>> of this letter, because the edited function's name is related to Java >>> 2D area of JDK, despite of the fact that the edited file is located in >>> AWT directory. >>> >>> Thank you, >>> Anton From anthony.petrov at oracle.com Fri Jan 11 11:45:19 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 11 Jan 2013 15:45:19 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <50EFED12.6070700@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> <50EE1CEB.5080500@oracle.com> <50EFED12.6070700@oracle.com> Message-ID: <50EFFB4F.4090405@oracle.com> I'm not Jim, but as I indicated earlier my opinion is that the easiest way to fix this is to install the existing J2DXErrHandler() only once. That is, it is the second option listed by you. Of course, the J2DXErrHandler needs to be updated as well to detect whether 2D code wants to use it at the moment or it must simply delegate to the previous handler (i.e. where the code currently installs/uninstalls the handler, it must instead set a global boolean flag or something.) While the first option (reusing the existing AWT machinery) is an interesting idea in general, I think it is complex and would require too much additional testing and bring an unjustified risk to the solution for such a basic problem. -- best regards, Anthony On 1/11/2013 14:44, Anton Litvinov wrote: > Hello Jim, > > Thank you very much for the review and provision of a new idea of a > solution. Elimination of the logic, which sets/unsets J2DXErrHandler() > for each call "XShmAttach(awt_display, &shminfo))" should effectively > resolve the issue, but only in case if all other native error handlers, > which were set by the system function "XSetErrorHandler()" in JDK or in > any external library, observe the rule of relaying of all events, which > are not relative to them, to the previously saved error handlers. > Otherwise an error generated during "XShmAttach" function call will not > be handled by J2DXErrHandler(). > > Could you answer the following question. By setting J2DXErrHandler() > only once and forever do you mean usage of AWT global event handler > "static int ToolkitErrorHandler(Display * dpy, XErrorEvent * event)" > from "src/solaris/native/sun/xawt/XlibWrapper.c" with Java synthetic > handlers or creation of another global native error handler with > J2DXErrHandler as native synthetic handler? > > Thank you, > Anton > > On 1/10/2013 5:44 AM, Jim Graham wrote: >> I think I'd rather see some way to prevent double-adding the handler >> in the first place as well. Since it is only ever used on errors I >> also think it is OK to set it once and leave it there forever... >> >> ...jim >> >> On 1/9/13 8:08 AM, Anthony Petrov wrote: >>> Hi Anton et al., >>> >>> If I read the description of the bug correctly, specifically this part: >>> >>>> The problem occurs, if another thread (for example, GTK thread) is >>>> doing the same sort of thing concurrently. This can lead to the >>>> following situation. >>>> JVM thread: Sets J2DXErrHandler(), saves ANY_PREVIOUS_HANDLER as >>>> previous GTK thread: Sets some GTK_HANDLER, saves >>>> J2DXErrHandler() as previous JVM thread: Restores >>>> ANY_PREVIOUS_HANDLER GTK thread: Restores J2DXErrHandler() JVM >>>> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as previous >>> >>> It is obvious that at this final step 2D is in an inconsistent state. We >>> don't expect to replace our own error handler (and it shouldn't have >>> been there in the first place). >>> >>> I realize that the fix you propose works around this problem. But this >>> doesn't look like an ideal solution to me. >>> >>> BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 error >>> handler only once and never replace it. All the rest of the >>> push_handler/pop_handler logic is now located in Java code (see >>> XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I believe >>> that we should somehow share this machinery with the 2D code to avoid >>> this sort of problems. Though I'm not sure if this will eliminate this >>> exact issue. >>> >>> >>> 2D/AWT folks: any other thoughts? >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 12/29/2012 17:44, Anton Litvinov wrote: >>>> Hello, >>>> >>>> Please review the following fix for a bug. >>>> >>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >>>> https://jbs.oracle.com/bugs/browse/JDK-8005607 >>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >>>> >>>> The bug consists in a crash which is caused by a stack overflow for >>>> the reason of an infinite recursion in AWT native function >>>> J2DXErrHandler() under certain circumstances on 32-bit Linux OS. The >>>> fix is based on introduction of the logic, which detects indirect >>>> recursive calls to J2DXErrHandler() by means of a simple counter, to >>>> J2DXErrHandler() native function. Such a solution requires minimum >>>> code changes, does not alter the handler's code significantly and >>>> eliminates this bug. >>>> >>>> Adding 2d-dev at openjdk.java.net e-mail alias to the list of recipients >>>> of this letter, because the edited function's name is related to Java >>>> 2D area of JDK, despite of the fact that the edited file is located in >>>> AWT directory. >>>> >>>> Thank you, >>>> Anton From artem.ananiev at oracle.com Mon Jan 14 10:23:40 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 14 Jan 2013 14:23:40 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005492: Reduce number of warnings in sun/awt/* classes In-Reply-To: <50ED9FD5.5040708@oracle.com> References: <50DEC8C0.5090503@oracle.com> <50ED9FD5.5040708@oracle.com> Message-ID: <50F3DCAC.3060709@oracle.com> Hi, Mikhail, this .02 version of the webrev looks fine. Don't forget to revert ScrollPane.java before pushing the fix, as this file is not changed. Thanks, Artem On 1/9/2013 8:50 PM, mikhail cherkasov wrote: > Hello All, > > Could you please review new version: > http://cr.openjdk.java.net/~mcherkas/8005492/webrev.02/ > > > I revert all changes that replace deprecated API use. I think that > changes are not clear > and can produce problems for people who will migrate to jdk8. > > Thanks, > Mikhail. > > 29.12.2012 14:41, mikhail cherkasov ?????: >> Hello All, >> >> Please review the following patch: >> >> webrev: http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/ >> >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005492 >> >> the following classes was cleaned from warnings: >> src/share/classes/java/awt/Button.java >> src/share/classes/java/awt/Canvas.java >> src/share/classes/java/awt/Checkbox.java >> src/share/classes/java/awt/Choice.java >> src/share/classes/java/awt/Component.java >> src/share/classes/java/awt/Container.java >> src/share/classes/java/awt/Dialog.java >> src/share/classes/java/awt/FontMetrics.java >> src/share/classes/java/awt/Frame.java >> src/share/classes/java/awt/Graphics.java >> src/share/classes/java/awt/KeyboardFocusManager.java >> src/share/classes/java/awt/ScrollPane.java >> src/share/classes/java/awt/Scrollbar.java >> src/share/classes/java/awt/TextArea.java >> src/share/classes/java/awt/TextComponent.java >> src/share/classes/java/awt/TextField.java >> src/share/classes/java/awt/Toolkit.java >> src/share/classes/java/awt/Window.java >> src/share/classes/sun/awt/image/SurfaceManager.java >> >> Thanks, >> Mikhail. > From Sergey.Bylokhov at oracle.com Mon Jan 14 19:44:37 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Mon, 14 Jan 2013 23:44:37 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50E4DA79.7020703@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> <50D2DF22.7020007@oracle.com> <50D2E484.3030004@oracle.com> <50D35065.1080307@oracle.com> <50D38628.2050807@oracle.com> <50D39EA4.6050802@oracle.com> <50D3A0B1.2040407@oracle.com> <50D3A530.4070604@oracle.com> <50D3B083.800@oracle.com> <50D3B45F.4010903@oracle.com> <50D3C3D5.7080506@oracle.com> <50D4464F.8050401@oracle.com> <50E4DA79.7020703@oracle.com> Message-ID: <50F46025.7080705@oracle.com> Hi Jim. 03.01.2013 5:10, Jim Graham wrote: > Hi Sergey, > > I guess my primary goal in maintaining this code is to try to find the > simplest and most directed fix unless a rewrite is in order - i.e. > simply normalizing incoming empty clips so that we end up in a stable > "clip is empty" state would be my preference, but perhaps the proposed > fix isn't so complicated that I need to worry about that. Can you please review the updated version of the fix: http://cr.openjdk.java.net/~serb/8004859/webrev.02 > > I've looked deeper into the various Rectangle methods and found lots > of little issues with the way that the various bounds methods on > Rectangle/Rectangle2D are implemented that complicate all of this. I > think a larger rewrite of the clip maintenance code is likely in order > at some point. In particular, while your changes have shifted from > one set of problematic bounds-setting code to another and may have > solved some test case we are currently looking at, I'm not convinced > that other bugs, or perhaps even just as many different bugs, are not > waiting to bite us with the new code. :( Yes some cases in methods are strange. Especially considering that they in one hierarchy. > > In the meantime, with respect to the new method you've added, I'd like > to see the following changes: > > - The method has nothing really to do with "normalizing a matrix" and > is probably misled by the fact that the "matrix" variable in the > calling method should never have been called "matrix" in the first > place since it is really just a list of coordinates. I'd suggest a > name better suited to its purpose, like "fixRectangleOrientation" or > "checkEmptyRectangle". done > > - For performance - rather than call signum 4 times, why not use more > direct tests like: > > if ((clip.getWidth() > 0) != (m[2] - m[0] > 0)) > // i.e. we only care if their "non-emptiness" is different > or: > if (clip.getWidth() * (m[2] - m[0]) < 0) > // i.e. we only care if their non-zero size is flipped done > > - I still think that we don't owe anybody any need to preserve the > size of the empty clip so the adjustments for cases that fail the > above tests could simply be "m[2] = m[0]" and thus we get an empty > result. Why did you feel that we need to maintain the sizes of empty > rectangles? Was it just JCK test failures? Well I have only one reason to do it: If the user's code works with non-scaled Graphics, which is default, and it will fail when we change internal type of the graphics -> That's a problem. This is directly related to the retina support, when in general nothing should be changed for the existing applications. > Does flipping the results keep us from failing those tests? > > --------------------- > > Eventually I'd like to see the following simplifications to our SG2D > clip handling: > > - we only keep a shape around so we can return a shape and we spend a > lot of time maintaining it. I'd like to see the shape be only > optionally kept if there is a non-rectangle handed in. Otherwise we > just maintain the clipRegion. > > - we use Area to intersect non-rectangular shapes even though it is > rare for anyone to call getClip() and even rarer that they do anything > with it except to use setClip() on it to restore the clip. I'd rather > see keeping an array of the incoming shapes, return a special object > from getClip() that just holds that array, and then on setClip() > simply restore the region - thus avoiding ever having to use Area. > Only if they actually iterate the path of the returned getClip() would > it dynamically use Area on the fly to produce that path iteration. > > - Avoid use of methods on Rectangle[2D] and write our own code that > ensures that we perform the correct flipping and integer > normalization. Most of that would happen in the Region bounds code if > we do the above anyway and that code is much simpler than some of the > corresponding methods on Rectangle[2D], plus we can fix bugs in there > without worrying about possibly changing the behavior for other apps > that may have started to rely on what we see as "bugs". > > ...jim > > On 12/21/2012 3:21 AM, Sergey Bylokhov wrote: >> 21.12.2012 6:05, Sergey Bylokhov ?????: >>> Hi, Jim. >>> 21.12.2012 4:59, Jim Graham wrote: >>>> The Object.equals() method is not intended to compare geometries. >>>> While Area.equals() attempts to perform geometric comparison I think >>>> that was a bad idea in retrospect for many reasons: >>>> >>>> - In practice you can only really compare within a tolerance due to >>>> the many ways for computations to every so slightly shift the results >>>> >>>> - There is no decent way to satisfy the equals/hashcode contract with >>>> such a comparison so Area is forever broken with respect to that >>>> contract. >>>> >>>> - It's a complicated test that can only serve to convince developers >>>> to invite performance drains into their code by making them think it >>>> is a reasonable thing to compare. >>>> >>>> For testing we should probably use Shape.contains() to verify answers >>>> for rectangle arguments and if we want to perform verification on >>>> arbitrary shape arguments then we'd need to write our own fuzzy >>>> comparator. >>> But why fix is incorrect? It just use the same code as sffd for the >>> correct shapes and have additional code for incorrect. Only >>> conditionchanged from width/height should be positive, to >>> width/height should be the same direction as incoming rectangle. >>>>>> There isn't even any guarantee that we will hand them back a >>>>>> rectangle >>>>>> from getClip(). >>>>> One of the jck tests expect this, but I think that this is the wrong >>>>> test. >>>> >>>> There is nothing in the documentation that guarantees a specific type >>>> returned from the method. If a JCK test was written to expect a >>>> Rectangle from the method then that is a separate problem that we'll >>>> have to address at some point. For now I'm only suggesting modifying >>>> the process for negative-empty rectangles. Does that trigger the JCK >>>> failure? If so, we are still satisfying the documented spec and so >>>> we will simply have to confince JCK to allow this exception. >>> Problem in jck come from the fact that Rectangle differs from >>> Rectangle2d. Note that everything is ok if graphics is not transformed >>> or just translated. But if we scale graphics we get: >>> 1 getClip() return non equivalent object. >>> 2 getClipBounds for Rectangle return it as is, but for Rectangle2D it >>> is call getBounds, which return an empty bounds or wrong bounds if >>> rectangle2d was normalized by sffd. >>> 3 Some tests expects class equivalence between set/get clip. I'll >>> prepare CR for them soon. >>> >>> Also there is the difference in the real clip, if we use type for the >>> empty Rectangle to Rectangle2D the real clip became correct. >> typo: Also there is the difference in the real clip, if we change type >> from the empty Rectangle to the empty Rectangle2D, the real clip will >> become correct. >>> All these issues are carried out in the testcase. >>>>>> After all, if you end up in the drop through case then we hand the >>>>>> paths to Area to do intersections and Area will do all sorts of >>>>>> surgery on the geometry. >>>>> But I sure this area will be equal to the user's clip? >>>> >>>> For all practical purposes it should be, but not only will the Area >>>> code encapsulate the answer in a different class (even if the result >>>> is a rectangle), it may reverse the order of the segments, it may >>>> represent the area as two separate rectangles that abut each other in >>>> a way that they are equivalent to one larger rectangle, but the Area >>>> code failed to notice that optimization, etc. All it will guarantee >>>> is that it returns a shape that describes the same interior, it will >>>> make no guarantees about minimalism or association of segments... >>>> >>>> ...jim >>> >>> >>> -- >>> Best regards, Sergey. >> >> >> -- >> Best regards, Sergey. >> -- Best regards, Sergey. From philip.race at oracle.com Wed Jan 16 21:54:07 2013 From: philip.race at oracle.com (Phil Race) Date: Wed, 16 Jan 2013 13:54:07 -0800 Subject: [OpenJDK 2D-Dev] [8] request fro review: 8005530: [lcms] Improve performance of ColorConverOp for default destinations In-Reply-To: <50ED61B6.20207@oracle.com> References: <50ED61B6.20207@oracle.com> Message-ID: <50F7217F.7080108@oracle.com> The variables 154 ShortComponentRaster shortRaster; 155 IntegerComponentRaster intRaster; 156 ByteComponentRaster byteRaster; are each used only in a localised few lines of code, can we move them to the block where they are used so that their scope is limited to that ? I don't know for a fact but I can imagine that the VM can then skip allocating stack for them until you enter that block which actually needs them. As you note,this takes into account old and new builds in the makefile changes Have you tested both ? And unless you are 100% confident in this [minimal] change you should get sign off from the build group as they've recently requested. You should add "noreg-perf" as a label in the JIRA -phil. On 1/9/2013 4:25 AM, Andrew Brygin wrote: > Hello Jennifer and Phil, > > could you please review a fix for CR 8005530? > > CR: http://bugs.sun.com/view_bug.do?bug_id=8005530 > Webrev:http://cr.openjdk.java.net/~bae/8005530/webrev.00/ > > This fix improves performance of ColorConvertOp.filter() > operation in case of lcms. The fix can be divided into > three separate changes: > > * provide support for custom component images in > LCMSImageLayout. > This change affects the case of conversion to default > destination. > > * provide a way to process whole image, instead of > scan-by-scan processing, if both source and > destination images do not contain padding samples > (i.e. next scan starts immediately after previous). > > * increase optimization level for lcms library from > LOW to HIGHEST. This change affects both new and > standard build systems. > > A benchmark comparison below illustrates the increase > of performance: > > Options common across all tests: > testname=cmm.colorconv.ccop.op_img > cmm.colorconv.ccop.ccopOptions.srcType=BYTE_3BYTE_BGR > cmm.colorconv.ccop.ccopOptions.content=photo > cmm.opts.profiles=1001 > > cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: > > OpenJDK Baseline: 0.152008134 (var=1.02%) (100.0%) > *************************************| > *************************************| > *************************************| > OpenJDK Fix: 0.245116358 (var=2.0%) (161.25%) > *************************************|********************** > *************************************|********************** > *************************************|********************* > cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: > > OpenJDK Baseline: 0.914826498 (var=0.41%) (100.0%) > ***************************| > ***************************| > ***************************| > OpenJDK Fix: 0.001310043 (var=2.24%) (221.48%) > ***************************|******************************** > ***************************|******************************** > ***************************|******************************** > cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: > > OpenJDK Baseline: 0.060737151 (var=1.57%) (100.0%) > ***************| > ***************| > ***************| > OpenJDK Fix: 0.242736486 (var=1.53%) (399.65%) > ***************|******************************************* > ***************|******************************************** > ***************|******************************************** > cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: > > OpenJDK Baseline: 0.559251559 (var=0.7%) (100.0%) > *******| > *******| > *******| > OpenJDK Fix: 0.001306904 (var=1.05%) (838.16%) > *******|*************************************************** > *******|**************************************************** > *******|**************************************************** > > Summary: > OpenJDK Baseline: > Number of tests: 4 > Overall average: 0.053373173444166644 > Best spread: 0.41% variance > Worst spread: 1.57% variance > (Basis for results comparison) > > OpenJDK Fix: > Number of tests: 4 > Overall average: 0.12261744826137347 > Best spread: 1.05% variance > Worst spread: 2.24% variance > Comparison to basis: > Best result: 838.16% of basis > Worst result: 161.25% of basis > Number of wins: 4 > Number of ties: 0 > Number of losses: 0 > > Thanks, > Andrew > From james.graham at oracle.com Thu Jan 17 00:56:41 2013 From: james.graham at oracle.com (Jim Graham) Date: Wed, 16 Jan 2013 16:56:41 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform. In-Reply-To: <50F46025.7080705@oracle.com> References: <50C9B74A.7050806@oracle.com> <50CA3D30.5020104@oracle.com> <50CCB2CA.8030307@oracle.com> <50D29862.2060806@oracle.com> <50D2DF22.7020007@oracle.com> <50D2E484.3030004@oracle.com> <50D35065.1080307@oracle.com> <50D38628.2050807@oracle.com> <50D39EA4.6050802@oracle.com> <50D3A0B1.2040407@oracle.com> <50D3A530.4070604@oracle.com> <50D3B083.800@oracle.com> <50D3B45F.4010903@oracle.com> <50D3C3D5.7080506@oracle.com> <50D4464F.8050401@oracle.com> <50E4DA79.7020703@oracle.com> <50F46025.7080705@oracle.com> Message-ID: <50F74C49.9000800@oracle.com> Hi Sergey, I have one remaining question: On 1/14/13 11:44 AM, Sergey Bylokhov wrote: >> - I still think that we don't owe anybody any need to preserve the >> size of the empty clip so the adjustments for cases that fail the >> above tests could simply be "m[2] = m[0]" and thus we get an empty >> result. Why did you feel that we need to maintain the sizes of empty >> rectangles? Was it just JCK test failures? > Well I have only one reason to do it: If the user's code works with > non-scaled Graphics, which is default, and it will fail when we change > internal type of the graphics -> That's a problem. This is directly > related to the retina support, when in general nothing should be changed > for the existing applications. The original code in getClipBounds would end up returning a "new Rectangle()" if the clip was an empty rectangle due to the way that "Rectangle2D/Path2D.getBounds()" works. You now use setFrame(getBounds2D()) which will attempt to preserve the dimensions of empty clips. So, the "preserve the size of an empty clip" support is new. I then mentioned that we don't need to go out of our way to preserve the dimensions of an empty clip, but you seem to be saying that we don't want to change this behavior - but your new code represents the break with existing behaviors, no? ...jim From lana.steuck at oracle.com Thu Jan 17 05:21:27 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 17 Jan 2013 05:21:27 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/corba: 2 new changesets Message-ID: <20130117052132.818D147339@hg.openjdk.java.net> Changeset: cb40427f4714 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/cb40427f4714 Added tag jdk8-b71 for changeset 8171d23e914d ! .hgtags Changeset: 191afde59e7b Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/191afde59e7b Added tag jdk8-b72 for changeset cb40427f4714 ! .hgtags From lana.steuck at oracle.com Thu Jan 17 05:21:33 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 17 Jan 2013 05:21:33 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxws: 2 new changesets Message-ID: <20130117052142.C26BF4733A@hg.openjdk.java.net> Changeset: d9707230294d Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/d9707230294d Added tag jdk8-b71 for changeset f577a39c9fb3 ! .hgtags Changeset: c606f644a5d9 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/c606f644a5d9 Added tag jdk8-b72 for changeset d9707230294d ! .hgtags From lana.steuck at oracle.com Thu Jan 17 05:21:25 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 17 Jan 2013 05:21:25 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d: 5 new changesets Message-ID: <20130117052126.2C0B347338@hg.openjdk.java.net> Changeset: c1be681d80a1 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/c1be681d80a1 Added tag jdk8-b71 for changeset 51ad2a343420 ! .hgtags Changeset: f03f90a4308d Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/f03f90a4308d Added tag jdk8-b72 for changeset c1be681d80a1 ! .hgtags Changeset: c37401e77c80 Author: mchung Date: 2012-12-28 22:20 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/c37401e77c80 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! common/bin/compare_exceptions.sh.incl Changeset: b845a2494261 Author: lana Date: 2013-01-01 12:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/b845a2494261 Merge Changeset: 93b9664f97ee Author: lana Date: 2013-01-10 15:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/93b9664f97ee Merge From lana.steuck at oracle.com Thu Jan 17 05:21:31 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 17 Jan 2013 05:21:31 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxp: 2 new changesets Message-ID: <20130117052142.F3EC04733B@hg.openjdk.java.net> Changeset: bdf2af722a6b Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/bdf2af722a6b Added tag jdk8-b71 for changeset 499be952a291 ! .hgtags Changeset: 84946404d1e1 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/84946404d1e1 Added tag jdk8-b72 for changeset bdf2af722a6b ! .hgtags From lana.steuck at oracle.com Thu Jan 17 05:21:49 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 17 Jan 2013 05:21:49 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/hotspot: 39 new changesets Message-ID: <20130117052322.0623A4733D@hg.openjdk.java.net> Changeset: d5cb5830f570 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d5cb5830f570 Added tag jdk8-b71 for changeset 0847210f8548 ! .hgtags Changeset: 11619f33cd68 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/11619f33cd68 Added tag jdk8-b72 for changeset d5cb5830f570 ! .hgtags Changeset: cd962e15c08e Author: amurillo Date: 2012-12-21 10:27 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/cd962e15c08e 8005382: new hotspot build - hs25-b15 Reviewed-by: jcoomes ! make/hotspot_version Changeset: e51c9860cf66 Author: jmasa Date: 2012-12-03 15:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e51c9860cf66 8005082: NPG: Add specialized Metachunk sizes for reflection and anonymous classloaders Reviewed-by: johnc, coleenp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/metachunk.cpp ! src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/runtime/globals.hpp Changeset: 1de1b145f6bc Author: jmasa Date: 2012-12-26 15:05 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1de1b145f6bc 8005486: NPG: Incorrect assertion in ChunkManager::list_index() Reviewed-by: coleenp ! src/share/vm/memory/metaspace.cpp Changeset: b735136e0d82 Author: johnc Date: 2013-01-02 11:32 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b735136e0d82 8004132: SerialGC: ValidateMarkSweep broken when running GCOld Summary: Remove bit-rotten ValidateMarkSweep functionality and flag. Reviewed-by: johnc, jmasa Contributed-by: tamao ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/markSweep.inline.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/debug.cpp Changeset: 37f7535e5f18 Author: johnc Date: 2012-12-21 11:45 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/37f7535e5f18 8001424: G1: Rename certain G1-specific flags Summary: Rename G1DefaultMinNewGenPercent, G1DefaultMaxNewGenPercent, and G1OldCSetRegionLiveThresholdPercent to G1NewSizePercent, G1MaxNewSizePercent, and G1MixedGCLiveThresholdPercent respectively. The previous names are no longer accepted. Reviewed-by: brutisso, ysr ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: d275c3dc73e6 Author: johnc Date: 2013-01-03 16:28 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d275c3dc73e6 8004816: G1: Kitchensink failures after marking stack changes Summary: Reset the marking state, including the mark stack overflow flag, in the event of a marking stack overflow during serial reference processing. Reviewed-by: jmasa ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp Changeset: ca0a78017dc7 Author: brutisso Date: 2012-12-30 08:47 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ca0a78017dc7 8005396: Use ParNew with only one thread instead of DefNew as default for CMS on single CPU machines Reviewed-by: jmasa, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/tenuredGeneration.cpp ! src/share/vm/runtime/arguments.cpp Changeset: e0ab18eafbde Author: brutisso Date: 2013-01-04 11:10 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e0ab18eafbde 8003820: Deprecate untested and rarely used GC combinations Summary: Log warning messages for DefNew+CMS and ParNew+SerialOld Reviewed-by: ysr, jwilhelm, jcoomes ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: c98b676a98b4 Author: brutisso Date: 2013-01-04 21:33 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c98b676a98b4 8003822: Deprecate the incremental mode of CMS Reviewed-by: johnc, jwilhelm ! src/share/vm/runtime/arguments.cpp Changeset: 6e9174173e00 Author: jmasa Date: 2013-01-04 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6e9174173e00 8000325: Change default for CMSClassUnloadingEnabled to true Reviewed-by: stefank, ysr ! src/share/vm/runtime/globals.hpp Changeset: 0b54ffe4c2d3 Author: jmasa Date: 2013-01-04 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/0b54ffe4c2d3 8005672: Clean up some changes to GC logging with GCCause's Reviewed-by: johnc, ysr ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp ! src/share/vm/gc_interface/gcCause.hpp Changeset: 7d42f3b08300 Author: dcubed Date: 2012-12-19 10:35 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/7d42f3b08300 8005044: remove crufty '_g' support from HS runtime code Summary: Phase 2 is removing '_g' support from the Runtime code. Reviewed-by: dcubed, coleenp, hseigel Contributed-by: ron.durbin at oracle.com ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/tools/ProjectCreator/ProjectCreator.java ! src/share/vm/runtime/arguments.cpp Changeset: 35431a769282 Author: stefank Date: 2012-12-20 10:22 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/35431a769282 8004823: Add VM support for type annotation reflection Reviewed-by: dholmes, coleenp Contributed-by: joel.franck at oracle.com ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/annotations.cpp ! src/share/vm/oops/annotations.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/fieldDescriptor.hpp ! src/share/vm/runtime/reflection.cpp Changeset: 4daebd4cc1dd Author: minqi Date: 2012-12-24 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4daebd4cc1dd Merge ! src/os/windows/vm/os_windows.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/arguments.cpp Changeset: cc6a617fffd2 Author: coleenp Date: 2013-01-02 20:28 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/cc6a617fffd2 8005494: SIGSEGV in Rewriter::relocate_and_link() when testing Weblogic with CompressedOops and KlassPtrs Summary: Relocate functions with jsr's when rewriting so not repeated after reading shared archive Reviewed-by: twisti, jrose ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/handles.inline.hpp Changeset: 6c3f47d964f3 Author: hseigel Date: 2013-01-07 15:32 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6c3f47d964f3 8003705: CDS failed on Windows: can not map in the CDS. Summary: Map memory only once to prevent 'already mapped' failures. Reviewed-by: acorn, zgu ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/metaspaceShared.cpp Changeset: 561148896559 Author: hseigel Date: 2013-01-08 13:38 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/561148896559 8005076: Creating a CDS archive with one alignment and running another causes a crash. Summary: Save the alignment when writing the CDS and compare it when reading the CDS. Reviewed-by: kvn, coleenp ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/filemap.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: ade95d680b42 Author: coleenp Date: 2013-01-08 14:01 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ade95d680b42 8004728: Add hotspot support for parameter reflection Summary: Add hotspot support for parameter reflection Reviewed-by: acorn, jrose, coleenp Contributed-by: eric.mccorkle at oracle.com ! make/bsd/makefiles/mapfile-vers-debug ! make/bsd/makefiles/mapfile-vers-product ! make/linux/makefiles/mapfile-vers-debug ! make/linux/makefiles/mapfile-vers-product ! make/solaris/makefiles/mapfile-vers ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileStream.cpp ! src/share/vm/classfile/classFileStream.hpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constMethod.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/reflection.hpp Changeset: 185a2c979a0e Author: coleenp Date: 2013-01-08 13:44 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/185a2c979a0e Merge Changeset: ecd24264898b Author: zgu Date: 2013-01-08 14:04 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ecd24264898b 8005048: NMT: #loaded classes needs to just show the # defined classes Summary: Count number of instance classes so that it matches class metadata size Reviewed-by: coleenp, acorn ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/services/memBaseline.cpp ! src/share/vm/services/memRecorder.cpp ! src/share/vm/services/memRecorder.hpp ! src/share/vm/services/memSnapshot.cpp ! src/share/vm/services/memSnapshot.hpp ! src/share/vm/services/memTrackWorker.cpp ! src/share/vm/services/memTrackWorker.hpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memTracker.hpp Changeset: 37a3e8b7a1e9 Author: zgu Date: 2013-01-08 11:39 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/37a3e8b7a1e9 Merge ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp Changeset: 0c93d4818214 Author: zgu Date: 2013-01-08 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/0c93d4818214 Merge Changeset: 1f6d10b4cc0c Author: acorn Date: 2013-01-09 18:06 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1f6d10b4cc0c Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 608b2e8a0063 Author: bpittore Date: 2013-01-03 15:08 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/608b2e8a0063 8004051: assert(_oprs_len[mode] < maxNumberOfOperands) failed: array overflow Summary: assert is triggered when number of register based arguments passed to a java method exceeds 16. Reviewed-by: roland, vladidan ! src/share/vm/c1/c1_LIR.hpp Changeset: 0c8717a92b2d Author: jiangli Date: 2013-01-08 13:01 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/0c8717a92b2d 8001341: SIGSEGV in methodOopDesc::fast_exception_handler_bci_for(KlassHandle,int,Thread*)+0x3e9. Summary: Use methodHandle. Reviewed-by: coleenp, acorn, twisti, sspitsyn ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 18c3c3fa291b Author: dlong Date: 2013-01-09 21:18 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/18c3c3fa291b Merge ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp Changeset: 4c8bf5e55392 Author: brutisso Date: 2013-01-09 09:48 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4c8bf5e55392 8005489: VM hangs during GC with ParallelGC and ParallelGCThreads=0 Summary: Print an error message and exit the VM if UseParallalGC is combined with ParllelGCThreads==0. Also reviewed by vitalyd at gmail.com. Reviewed-by: stefank, ehelin ! src/share/vm/runtime/arguments.cpp Changeset: b2fef6b220e9 Author: jmasa Date: 2013-01-10 07:32 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b2fef6b220e9 Merge ! src/share/vm/runtime/arguments.cpp Changeset: d092d1b31229 Author: roland Date: 2012-12-23 17:08 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d092d1b31229 8005071: Incremental inlining for JSR 292 Summary: post parse inlining driven by number of live nodes. Reviewed-by: twisti, kvn, jrose ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/cfgnode.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 00af3a3a8df4 Author: kvn Date: 2013-01-03 15:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/00af3a3a8df4 8005522: use fast-string instructions on x86 for zeroing Summary: use 'rep stosb' instead of 'rep stosq' when fast-string operations are available. Reviewed-by: twisti, roland ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/globals_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/memnode.cpp Changeset: e2e6bf86682c Author: kvn Date: 2013-01-03 16:30 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e2e6bf86682c 8005544: Use 256bit YMM registers in arraycopy stubs on x86 Summary: Use YMM registers in arraycopy and array_fill stubs. Reviewed-by: roland, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: ffa87474d7a4 Author: twisti Date: 2013-01-07 14:08 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ffa87474d7a4 8004537: replace AbstractAssembler emit_long with emit_int32 Reviewed-by: jrose, kvn, twisti Contributed-by: Morris Meyer ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/share/vm/asm/assembler.hpp Changeset: 038dd2875b94 Author: kvn Date: 2013-01-08 11:30 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/038dd2875b94 8005419: Improve intrinsics code performance on x86 by using AVX2 Summary: use 256bit vpxor,vptest instructions in String.compareTo() and equals() intrinsics. Reviewed-by: twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp + test/compiler/8005419/Test8005419.java Changeset: 5698813d45eb Author: twisti Date: 2013-01-09 15:37 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5698813d45eb 8005418: JSR 292: virtual dispatch bug in 292 impl Reviewed-by: jrose, kvn ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp Changeset: f1c06dcee0b5 Author: kvn Date: 2013-01-10 10:00 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f1c06dcee0b5 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 1e129851479e Author: amurillo Date: 2013-01-11 01:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1e129851479e Merge Changeset: b5e6bec76f4a Author: amurillo Date: 2013-01-11 01:43 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b5e6bec76f4a Added tag hs25-b15 for changeset 1e129851479e ! .hgtags From lana.steuck at oracle.com Thu Jan 17 05:21:39 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 17 Jan 2013 05:21:39 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/langtools: 18 new changesets Message-ID: <20130117052237.604B04733C@hg.openjdk.java.net> Changeset: 6f0986ed9b7e Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/6f0986ed9b7e Added tag jdk8-b71 for changeset 467e4d9281bc ! .hgtags Changeset: 45fed5cfd1c3 Author: katleman Date: 2013-01-10 09:56 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/45fed5cfd1c3 Added tag jdk8-b72 for changeset 6f0986ed9b7e ! .hgtags Changeset: 0c244701188e Author: mchung Date: 2012-12-28 22:25 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/0c244701188e 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! make/build.properties ! makefiles/BuildLangtools.gmk ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/classfile/Dependency.java + src/share/classes/com/sun/tools/jdeps/Archive.java + src/share/classes/com/sun/tools/jdeps/ClassFileReader.java + src/share/classes/com/sun/tools/jdeps/JdepsTask.java + src/share/classes/com/sun/tools/jdeps/Main.java + src/share/classes/com/sun/tools/jdeps/PlatformClassPath.java + src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties + src/share/classes/com/sun/tools/jdeps/resources/jdk.properties + src/share/classes/com/sun/tools/jdeps/resources/version.properties-template ! test/Makefile + test/tools/jdeps/Basic.java + test/tools/jdeps/Test.java + test/tools/jdeps/p/Foo.java Changeset: 31780dd06ec7 Author: jjg Date: 2012-12-29 17:33 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/31780dd06ec7 8004727: Add compiler support for parameter reflection Reviewed-by: jjg Contributed-by: eric.mccorkle at oracle.com ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java + src/share/classes/com/sun/tools/classfile/MethodParameters_attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/util/Names.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java + test/tools/javac/MethodParameters.java + test/tools/javap/MethodParameters.java Changeset: 383bc0fbd759 Author: jjg Date: 2012-12-30 06:17 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/383bc0fbd759 8005195: Doclint regression tests fail on windows Reviewed-by: mcimadamore ! test/tools/doclint/DocLintTester.java Changeset: 1d8438db45f2 Author: lana Date: 2013-01-01 17:50 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/1d8438db45f2 Merge Changeset: 0e17c3c23e3b Author: bpatel Date: 2013-01-04 23:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/0e17c3c23e3b 8004891: Check for abstract method in javadoc does not conform to the language model Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java + test/com/sun/javadoc/testAbstractMethod/TestAbstractMethod.java + test/com/sun/javadoc/testAbstractMethod/pkg/A.java + test/com/sun/javadoc/testAbstractMethod/pkg/B.java + test/com/sun/javadoc/testAbstractMethod/pkg/C.java Changeset: 8c0c63a6e3b7 Author: bpatel Date: 2013-01-05 00:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/8c0c63a6e3b7 8005092: javadoc should check for synthesized bit on an annotation Reviewed-by: jjg ! src/share/classes/com/sun/javadoc/AnnotationDesc.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/javadoc/AnnotationDescImpl.java + test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/C.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContaineeRegDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContaineeSynthDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerRegDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerRegNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerSynthDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/D.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/NonSynthDocContainer.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegArryDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContaineeDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContaineeNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContainerDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContainerNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/C.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContaineeNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContaineeSynthDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerSynthNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerValDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerValNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContaineeDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContaineeNotDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContainerValDoc.java + test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContainerValNotDoc.java Changeset: a9cb93cca229 Author: jjh Date: 2013-01-07 17:51 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/a9cb93cca229 8005647: langtools/test/tools/javap/MethodParameters.java fails on windows Summary: Fix javap to not output \r\r\n Reviewed-by: jjg ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! test/tools/javac/MethodParameters.java ! test/tools/javap/MethodParameters.java Changeset: 38d3d1027f5a Author: mcimadamore Date: 2013-01-08 10:15 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/38d3d1027f5a 8005243: Restructure method check code to allow pluggable checkers Summary: Add interface to perform a method check - to be implemented by helper classes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: db91d860156a Author: mcimadamore Date: 2013-01-08 10:16 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/db91d860156a 8005179: Cleanup Resolve.AmbiguityError Summary: Linearize nested ambiguity errors Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/lambda/TargetType21.java ! test/tools/javac/lambda/TargetType21.out Changeset: d07340b61e6a Author: mcimadamore Date: 2013-01-08 10:17 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/d07340b61e6a 8005184: Restructure DeferredAttr to allow pluggable deferred type completers Summary: Add hooks to generalize deferred type completion via custom helper objects Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java Changeset: 954541f13717 Author: vromero Date: 2013-01-08 13:47 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/954541f13717 8005167: execution time of combo tests in javac should be improved Reviewed-by: jjg, jjh ! test/tools/javac/Diagnostics/6769027/T6769027.java ! test/tools/javac/T7093325.java ! test/tools/javac/cast/intersection/IntersectionTypeCastTest.java ! test/tools/javac/defaultMethods/super/TestDefaultSuperCall.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/generics/diamond/7046778/DiamondAndInnerClassTest.java ! test/tools/javac/generics/rawOverride/7062745/GenericOverrideTest.java ! test/tools/javac/lambda/FunctionalInterfaceConversionTest.java ! test/tools/javac/lambda/LambdaParserTest.java ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/lambda/TestInvokeDynamic.java ! test/tools/javac/lambda/mostSpecific/StructuralMostSpecificTest.java ! test/tools/javac/lambda/typeInference/combo/TypeInferenceComboTest.java + test/tools/javac/lib/JavacTestingAbstractThreadedTest.java ! test/tools/javac/multicatch/7030606/DisjunctiveTypeWellFormednessTest.java ! test/tools/javac/varargs/7042566/T7042566.java ! test/tools/javac/varargs/warning/Warn4.java ! test/tools/javac/varargs/warning/Warn5.java Changeset: d2eb08b3f64f Author: jjg Date: 2013-01-09 10:26 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/d2eb08b3f64f 8005644: set default max errs and max warns Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/Messager.java + test/tools/javadoc/MaxWarns.java Changeset: 7612fe48be90 Author: darcy Date: 2013-01-09 20:02 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/7612fe48be90 8004730: Add language model support for parameter reflection Reviewed-by: abuckley ! src/share/classes/javax/lang/model/element/Element.java ! src/share/classes/javax/lang/model/element/VariableElement.java ! src/share/classes/javax/lang/model/element/package-info.java Changeset: d462da465da6 Author: jjg Date: 2013-01-10 14:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/d462da465da6 8006037: extra space in javac -help for -J and @ options Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/Option.java + test/tools/javac/main/Option_J_At_Test.java Changeset: 7d2f628f04f1 Author: jjg Date: 2013-01-10 15:48 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/7d2f628f04f1 8006033: bug in Pretty.toSimpleString Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/tree/Pretty.java + test/tools/javac/tree/PrettySimpleStringTest.java Changeset: 8d0baee36c71 Author: lana Date: 2013-01-10 15:53 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/8d0baee36c71 Merge From lana.steuck at oracle.com Thu Jan 17 05:22:58 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 17 Jan 2013 05:22:58 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 32 new changesets Message-ID: <20130117052922.D70614733E@hg.openjdk.java.net> Changeset: 32a57e645e01 Author: katleman Date: 2013-01-03 12:44 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/32a57e645e01 Added tag jdk8-b71 for changeset 2a5af0f766d0 ! .hgtags Changeset: c9a914b11436 Author: katleman Date: 2013-01-10 09:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c9a914b11436 Added tag jdk8-b72 for changeset 32a57e645e01 ! .hgtags Changeset: d54922883f4c Author: alexsch Date: 2013-01-09 16:52 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d54922883f4c 8005019: JTable passes row index instead of length when inserts selection interval Reviewed-by: serb, denis ! src/share/classes/javax/swing/JTable.java + test/javax/swing/JTable/8005019/bug8005019.java Changeset: b2c425d7e5be Author: lana Date: 2013-01-10 15:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b2c425d7e5be Merge Changeset: 28b47ed08c63 Author: mchung Date: 2012-12-28 22:21 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/28b47ed08c63 8003562: Provide a CLI tool to analyze class dependencies Reviewed-by: jjg, alanb, ulfzibis, erikj ! make/common/Release.gmk ! make/docs/NON_CORE_PKGS.gmk ! make/launchers/Makefile ! make/launchers/Makefile.launcher ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk Changeset: 3cc25d0e3bb0 Author: chegar Date: 2012-12-29 11:00 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3cc25d0e3bb0 8005556: java/net/Socks/SocksV4Test.java is missing @run tag Reviewed-by: alanb ! test/java/net/Socks/SocksV4Test.java Changeset: 38b9a7646093 Author: lana Date: 2013-01-01 17:49 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/38b9a7646093 Merge ! makefiles/CreateJars.gmk Changeset: cc78ceb99284 Author: jgish Date: 2012-12-28 16:56 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cc78ceb99284 8005118: Javadoc styles are inconsistent Summary: use a common javadoc style in the String classes Reviewed-by: darcy ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/StringBuffer.java ! src/share/classes/java/lang/StringBuilder.java ! src/share/classes/java/lang/StringIndexOutOfBoundsException.java Changeset: 21708d15553b Author: chegar Date: 2013-01-03 10:00 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/21708d15553b 8005634: tools/launcher/VersionCheck.java fails version check on jdeps Summary: add jdeps to the list of tools that do not support '-version' Reviewed-by: mchung ! test/tools/launcher/VersionCheck.java Changeset: 438d37d16417 Author: chegar Date: 2013-01-04 11:18 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/438d37d16417 8005659: Add tools/pack200/AttributeTests.java to exclude list (ProblemList.txt) until pack200 updated to support method parameters Reviewed-by: mchung, ksrini ! test/ProblemList.txt Changeset: 6d814b2f9112 Author: chegar Date: 2013-01-04 11:34 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6d814b2f9112 8005638: Less secure Authentication schemes should work when more secure schemes are not available Reviewed-by: alanb ! src/share/classes/sun/net/www/protocol/http/AuthenticationHeader.java Changeset: 92c3b24a8e9a Author: smarks Date: 2013-01-04 16:10 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/92c3b24a8e9a 8005683: ProblemList.txt updates (01/2013) Reviewed-by: mchung, alanb Contributed-by: amy.lu at oracle.com ! test/ProblemList.txt Changeset: 0c89465b656a Author: chegar Date: 2013-01-05 17:06 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0c89465b656a 8005709: Add at since tags to new FJP getCommonPoolParallelism and commonPool Reviewed-by: dl ! src/share/classes/java/util/concurrent/ForkJoinPool.java Changeset: 1d9638ba5202 Author: ksrini Date: 2013-01-07 09:58 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1d9638ba5202 8004547: Extend JavaFX launcher support to allow full JavaFX launch feature set Reviewed-by: mchung, kcr, ksrini Contributed-by: david.dehaven at oracle.com ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/launcher/resources/launcher.properties ! test/tools/launcher/FXLauncherTest.java Changeset: dbc692ea3f0a Author: bchristi Date: 2013-01-07 13:19 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/dbc692ea3f0a 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] Summary: Hard-code sun.jnu.encoding to UTF-8 on Mac Reviewed-by: naoto ! src/share/native/java/lang/System.c ! src/solaris/native/java/lang/java_props_md.c + test/java/util/Properties/MacJNUEncoding/ExpectedEncoding.java + test/java/util/Properties/MacJNUEncoding/MacJNUEncoding.sh Changeset: 797e8a3dcd51 Author: smarks Date: 2013-01-07 18:09 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/797e8a3dcd51 7187882: TEST_BUG: java/rmi/activation/checkusage/CheckUsage.java fails intermittently Summary: Tighten up JavaVM test library API, and adjust tests to match. Reviewed-by: mchung, dmocek ! test/ProblemList.txt ! test/java/rmi/activation/Activatable/shutdownGracefully/ShutdownGracefully.java ! test/java/rmi/activation/checkusage/CheckUsage.java ! test/java/rmi/registry/altSecurityManager/AltSecurityManager.java ! test/java/rmi/registry/checkusage/CheckUsage.java ! test/java/rmi/registry/reexport/Reexport.java ! test/java/rmi/testlibrary/JavaVM.java ! test/java/rmi/testlibrary/RMID.java ! test/java/rmi/transport/checkFQDN/CheckFQDN.java ! test/java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java ! test/sun/rmi/runtime/Log/4504153/Test4504153.java ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java ! test/sun/rmi/transport/tcp/DeadCachedConnection.java Changeset: 98935c514de4 Author: weijun Date: 2013-01-08 14:54 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/98935c514de4 8005447: default principal should act as anyone Reviewed-by: valeriep ! src/share/classes/sun/security/jgss/krb5/InitSecContextToken.java ! src/share/classes/sun/security/jgss/krb5/Krb5AcceptCredential.java ! src/share/classes/sun/security/jgss/krb5/Krb5Context.java ! src/share/classes/sun/security/jgss/krb5/Krb5MechFactory.java ! src/share/classes/sun/security/jgss/krb5/Krb5Util.java + src/share/classes/sun/security/jgss/krb5/ServiceCreds.java ! src/share/classes/sun/security/jgss/krb5/SubjectComber.java ! src/share/classes/sun/security/krb5/KrbApReq.java ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/share/classes/sun/security/ssl/krb5/Krb5ProxyImpl.java + test/sun/security/krb5/ServiceCredsCombination.java + test/sun/security/krb5/auto/AcceptPermissions.java ! test/sun/security/krb5/auto/CleanState.java ! test/sun/security/krb5/auto/Context.java + test/sun/security/krb5/auto/DiffNameSameKey.java ! test/sun/security/krb5/auto/DynamicKeytab.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/KeyTabCompat.java + test/sun/security/krb5/auto/TwoOrThree.java Changeset: d29a7ce28189 Author: dxu Date: 2013-01-08 20:37 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d29a7ce28189 8002306: (se) Selector.open fails if invoked with thread interrupt status set [win] Reviewed-by: alanb ! src/windows/classes/sun/nio/ch/PipeImpl.java + test/java/nio/channels/Pipe/PipeInterrupt.java Changeset: 46e6a4b7ca26 Author: valeriep Date: 2013-01-07 11:11 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/46e6a4b7ca26 6996769: support AEAD cipher Summary: Added implementation for GCM mode under AES cipher Reviewed-by: weijun ! src/share/classes/com/sun/crypto/provider/AESCipher.java ! src/share/classes/com/sun/crypto/provider/CipherCore.java ! src/share/classes/com/sun/crypto/provider/CipherTextStealing.java ! src/share/classes/com/sun/crypto/provider/FeedbackCipher.java + src/share/classes/com/sun/crypto/provider/GCMParameters.java + src/share/classes/com/sun/crypto/provider/GCTR.java + src/share/classes/com/sun/crypto/provider/GHASH.java + src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/spec/GCMParameterSpec.java ! test/com/sun/crypto/provider/Cipher/AES/Test4512524.java ! test/com/sun/crypto/provider/Cipher/AES/Test4512704.java ! test/com/sun/crypto/provider/Cipher/AES/Test4517355.java ! test/com/sun/crypto/provider/Cipher/AES/Test4626070.java + test/com/sun/crypto/provider/Cipher/AES/TestGCMKeyAndIvCheck.java + test/com/sun/crypto/provider/Cipher/AES/TestKATForGCM.java ! test/javax/crypto/Cipher/GCMAPI.java Changeset: 5333a4c8cade Author: valeriep Date: 2013-01-07 14:40 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5333a4c8cade Merge Changeset: 3c5a62290939 Author: valeriep Date: 2013-01-08 11:55 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3c5a62290939 8004044: Lazily instantiate SunJCE.RANDOM Summary: Replace the static initialization of SunJCE.RANDOM object w/ lazy initialization Reviewed-by: mchung ! src/share/classes/com/sun/crypto/provider/AESKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/BlowfishKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/CipherCore.java ! src/share/classes/com/sun/crypto/provider/DESKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/DESedeKeyGenerator.java ! src/share/classes/com/sun/crypto/provider/DESedeWrapCipher.java ! src/share/classes/com/sun/crypto/provider/DHKeyPairGenerator.java ! src/share/classes/com/sun/crypto/provider/DHParameterGenerator.java ! src/share/classes/com/sun/crypto/provider/HmacMD5KeyGenerator.java ! src/share/classes/com/sun/crypto/provider/HmacPKCS12PBESHA1.java ! src/share/classes/com/sun/crypto/provider/HmacSHA1KeyGenerator.java ! src/share/classes/com/sun/crypto/provider/ISO10126Padding.java ! src/share/classes/com/sun/crypto/provider/KeyGeneratorCore.java ! src/share/classes/com/sun/crypto/provider/KeyProtector.java ! src/share/classes/com/sun/crypto/provider/PBECipherCore.java ! src/share/classes/com/sun/crypto/provider/PBES1Core.java ! src/share/classes/com/sun/crypto/provider/PBES2Core.java ! src/share/classes/com/sun/crypto/provider/PBMAC1Core.java ! src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java Changeset: 9b6a29cb04ac Author: valeriep Date: 2013-01-08 13:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9b6a29cb04ac Merge Changeset: ac5fd681a7a2 Author: darcy Date: 2013-01-08 16:08 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/ac5fd681a7a2 8005298: Add FunctionalInterface type to the core libraries Reviewed-by: mduigou + src/share/classes/java/lang/FunctionalInterface.java Changeset: 86828e84654f Author: mullan Date: 2013-01-08 19:00 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/86828e84654f 7019834: Eliminate dependency from PolicyFile to com.sun.security.auth.PrincipalComparator Summary: Add new java.security.Principal.implies method Reviewed-by: alanb ! src/share/classes/java/security/Principal.java ! src/share/classes/sun/security/provider/PolicyFile.java ! src/share/classes/sun/security/provider/PolicyParser.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java + test/java/security/Principal/Implies.java ! test/sun/security/provider/PolicyFile/Comparator.java Changeset: bf6d0bca5ea7 Author: mullan Date: 2013-01-08 19:02 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bf6d0bca5ea7 Merge - make/jdk/asm/Makefile - src/share/classes/sun/awt/TextureSizeConstraining.java - src/share/lib/security/java.security - test/java/rmi/server/Unmarshal/checkUnmarshalOnStopThread/CheckUnmarshall.java Changeset: f0ed9ef84637 Author: mullan Date: 2013-01-09 08:59 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f0ed9ef84637 Merge Changeset: 4c8b37f159f9 Author: mchung Date: 2013-01-09 16:58 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4c8b37f159f9 7103957: NegativeArraySizeException while initializing class IntegerCache Reviewed-by: darcy, mchung Contributed-by: brian.burkhalter at oracle.com ! src/share/classes/java/lang/Integer.java Changeset: 4176e6cc499e Author: darcy Date: 2013-01-09 20:20 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4176e6cc499e 8005713: Simplify library support for repeating annotations in java.lang.annotation Reviewed-by: abuckley + src/share/classes/java/lang/annotation/Repeatable.java Changeset: c622df692bfb Author: bchristi Date: 2013-01-10 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c622df692bfb 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments Summary: Test script now sets LC_ALL, other small changes, relocate test Reviewed-by: naoto, alanb + test/java/lang/System/MacJNUEncoding/ExpectedEncoding.java + test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh - test/java/util/Properties/MacJNUEncoding/ExpectedEncoding.java - test/java/util/Properties/MacJNUEncoding/MacJNUEncoding.sh Changeset: 13ff1089e625 Author: jgish Date: 2013-01-10 15:09 -0500 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/13ff1089e625 8005582: java/lang/Runtime/exec/WinCommand.java intermittent test failures Summary: Remove file-deletion code at cleanup which conflicts with jtreg cleanup Reviewed-by: chegar ! test/java/lang/Runtime/exec/WinCommand.java Changeset: 3e906ccad412 Author: chegar Date: 2013-01-10 21:52 +0000 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3e906ccad412 8006007: j.u.c.atomic classes should use intrinsic getAndXXX provided by 7023898 Reviewed-by: dl, shade ! src/share/classes/java/util/concurrent/atomic/AtomicBoolean.java ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java Changeset: 733885f57e14 Author: lana Date: 2013-01-10 15:52 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/733885f57e14 Merge From lana.steuck at oracle.com Tue Jan 22 22:13:06 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 22 Jan 2013 22:13:06 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d: 27 new changesets Message-ID: <20130122221310.2DEFC47481@hg.openjdk.java.net> Changeset: 4090847a5444 Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/4090847a5444 Added tag jdk8-b73 for changeset 93b9664f97ee ! .hgtags Changeset: 77f062a41850 Author: erikj Date: 2012-12-27 20:15 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/77f062a41850 8001942: build-infra: General permission problems on Windows/cygwin Summary: Added sanity check for file permissions in configure Reviewed-by: tbell, ohair ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: d2c1f80118de Author: erikj Date: 2012-12-27 20:18 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/d2c1f80118de 8005540: build-infra: Improve incremental build speed on windows by caching find results Reviewed-by: ohair ! common/makefiles/IdlCompilation.gmk ! common/makefiles/JavaCompilation.gmk ! common/makefiles/MakeBase.gmk ! common/makefiles/NativeCompilation.gmk Changeset: d5f3a6f60d51 Author: erikj Date: 2012-12-27 20:55 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/d5f3a6f60d51 8005548: build-infra: Fix docs target on windows Summary: Fix path sep variable Reviewed-by: tbell ! common/makefiles/javadoc/Javadoc.gmk Changeset: ef6adbf511cc Author: erikj Date: 2012-12-28 09:51 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/ef6adbf511cc 8005549: build-infra: Merge NewMakefile.gmk and common/makefiles/Makefile Reviewed-by: ohair, tbell ! NewMakefile.gmk ! common/autoconf/Makefile.in ! common/autoconf/generated-configure.sh + common/makefiles/Jprt.gmk ! common/makefiles/Main.gmk ! common/makefiles/MakeHelpers.gmk ! common/makefiles/Makefile Changeset: 2d9bb72b4e34 Author: erikj Date: 2012-12-30 12:15 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/2d9bb72b4e34 8004490: build-infra: mac: hotspot is always built in product, regardless of --with-debug-level setting Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: abc8078e070b Author: erikj Date: 2013-01-01 14:13 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/abc8078e070b 8001895: build-infra: Make JDK_BUILD_NUMBER and MILESTONE customizable Summary: Added configure params Reviewed-by: ohair ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in ! common/autoconf/version.numbers Changeset: 14d7ebe42c8d Author: erikj Date: 2013-01-02 11:29 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/14d7ebe42c8d 8005347: build-infra: Verify 'gnumake source' at the top level works ok Reviewed-by: tbell, ohair, dholmes ! common/autoconf/basics.m4 - common/autoconf/closed.version.numbers ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in = common/autoconf/version-numbers < common/autoconf/version.numbers Changeset: 348a881c6da0 Author: erikj Date: 2013-01-02 15:36 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/348a881c6da0 8005355: build-infra: Java security signing (need a top-level make target). Reviewed-by: tbell, ohair ! common/autoconf/spec.gmk.in ! common/makefiles/Main.gmk Changeset: befbad2e4d87 Author: erikj Date: 2013-01-03 20:54 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/befbad2e4d87 8005635: build-infra: Support building install in jprt Reviewed-by: ohair Contributed-by: tim.bell at oracle.com, erik.joelsson at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/bin/compare.sh ! common/bin/compare_exceptions.sh.incl ! common/makefiles/Jprt.gmk ! common/src/fixpath.c Changeset: 39194e004ade Author: erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/39194e004ade 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! common/autoconf/compare.sh.in ! common/bin/compare.sh Changeset: 9263657c2756 Author: erikj Date: 2013-01-04 16:56 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/9263657c2756 8005692: build-infra: Target "all" should do the right thing Reviewed-by: tbell ! common/makefiles/Main.gmk Changeset: c874a8a27933 Author: erikj Date: 2013-01-04 17:05 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/c874a8a27933 8005597: build-infra: bridgeBuild broken for pure openjdk build Reviewed-by: tbell ! common/makefiles/Jprt.gmk Changeset: 7b9c42f14281 Author: erikj Date: 2013-01-04 17:08 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/7b9c42f14281 8005654: build-infra: Create sec-bin.zip Reviewed-by: tbell ! common/bin/compare.sh ! common/makefiles/JavaCompilation.gmk Changeset: 2597feac57c0 Author: erikj Date: 2013-01-04 22:43 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/2597feac57c0 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing Reviewed-by: tbell ! common/bin/compare.sh ! common/bin/compare_exceptions.sh.incl Changeset: 5cf7750c8c43 Author: ohair Date: 2013-01-04 21:04 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/5cf7750c8c43 8004229: build-infra: Umbrella for switch of default "make" to new makefiles Reviewed-by: erikj, tbell ! Makefile ! make/jprt.properties Changeset: 7a3c6ffdf1fb Author: tbell Date: 2013-01-07 14:01 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/7a3c6ffdf1fb 8005442: autogen.sh sets DATE_WHEN_GENERATED to empty string on Solaris version 11 or later Reviewed-by: ohair ! common/autoconf/autogen.sh Changeset: 64a9ebad39fe Author: katleman Date: 2013-01-08 13:14 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/64a9ebad39fe Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers Changeset: b284980b7d9a Author: tbell Date: 2013-01-08 16:23 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/b284980b7d9a 8005794: in new infra, how do we change java -version? Summary: Added configure parameter --with-user-release-suffix Reviewed-by: ohair, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: db3984e4eb97 Author: erikj Date: 2013-01-10 12:20 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/db3984e4eb97 8005858: build-infra: Add missed comparison of sec-windows-bin.zip and friends to compare.sh Reviewed-by: tbell, ohair ! common/bin/compare.sh Changeset: 6f8f7a5449f6 Author: erikj Date: 2013-01-11 10:46 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/6f8f7a5449f6 8005850: build-infra: Make --enable-openjdk-only really disable custom Reviewed-by: ohair, dholmes ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: b66c81dfa291 Author: ohair Date: 2013-01-14 16:38 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/b66c81dfa291 8005284: build-infra: nonstandard copyright headers under common/autoconf/build-aux Reviewed-by: katleman ! common/autoconf/build-aux/autoconf-config.guess ! common/autoconf/build-aux/config.sub ! common/autoconf/build-aux/pkg.m4 Changeset: 3540aa40c868 Author: erikj Date: 2013-01-14 13:09 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/3540aa40c868 8006074: build-infra: Configure fails to find SetEnv.Cmd in microsoft sdk Reviewed-by: tbell, ohair ! common/autoconf/basics_windows.m4 ! common/autoconf/generated-configure.sh Changeset: 6e822b534678 Author: erikj Date: 2013-01-14 15:30 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/6e822b534678 8006100: build-infra: Bundle up the correct images in jprt Reviewed-by: tbell ! NewMakefile.gmk ! common/makefiles/Jprt.gmk Changeset: 52cce3326649 Author: erikj Date: 2013-01-15 09:50 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/rev/52cce3326649 Merge Changeset: fe1c94aca5a8 Author: katleman Date: 2013-01-15 10:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/fe1c94aca5a8 Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers Changeset: dc84b505b408 Author: katleman Date: 2013-01-16 22:16 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/rev/dc84b505b408 Merge - common/autoconf/closed.version.numbers - common/autoconf/version.numbers ! common/bin/compare_exceptions.sh.incl From lana.steuck at oracle.com Tue Jan 22 22:13:05 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 22 Jan 2013 22:13:05 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/corba: Added tag jdk8-b73 for changeset 191afde59e7b Message-ID: <20130122221310.4817C47482@hg.openjdk.java.net> Changeset: 2132845cf5f7 Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/2132845cf5f7 Added tag jdk8-b73 for changeset 191afde59e7b ! .hgtags From lana.steuck at oracle.com Tue Jan 22 22:13:10 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 22 Jan 2013 22:13:10 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/langtools: Added tag jdk8-b73 for changeset 8d0baee36c71 Message-ID: <20130122221320.F1A4B47483@hg.openjdk.java.net> Changeset: 56c97aff46bb Author: katleman Date: 2013-01-16 12:00 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/56c97aff46bb Added tag jdk8-b73 for changeset 8d0baee36c71 ! .hgtags From lana.steuck at oracle.com Tue Jan 22 22:13:08 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 22 Jan 2013 22:13:08 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxws: 5 new changesets Message-ID: <20130122221324.6BA1147484@hg.openjdk.java.net> Changeset: 68f508979ffe Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/68f508979ffe Added tag jdk8-b73 for changeset c606f644a5d9 ! .hgtags Changeset: 51f3117e2b75 Author: erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/51f3117e2b75 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! makefiles/BuildJaxws.gmk Changeset: dd7473082690 Author: katleman Date: 2013-01-08 13:14 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/dd7473082690 Merge Changeset: b8fd32e44c26 Author: katleman Date: 2013-01-15 10:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/b8fd32e44c26 Merge Changeset: 12db3c5a3393 Author: katleman Date: 2013-01-16 22:17 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/12db3c5a3393 Merge From lana.steuck at oracle.com Tue Jan 22 22:13:06 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 22 Jan 2013 22:13:06 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxp: 5 new changesets Message-ID: <20130122221328.A8A5A47485@hg.openjdk.java.net> Changeset: cf0917c0d771 Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/cf0917c0d771 Added tag jdk8-b73 for changeset 84946404d1e1 ! .hgtags Changeset: 278a2f60c55b Author: erikj Date: 2013-01-04 11:31 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/278a2f60c55b 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build Reviewed-by: ohair ! makefiles/BuildJaxp.gmk Changeset: 2e4d87e6662e Author: katleman Date: 2013-01-08 13:14 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/2e4d87e6662e Merge Changeset: a317d3e1bbac Author: katleman Date: 2013-01-15 10:07 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/a317d3e1bbac Merge Changeset: 2087e24a4357 Author: katleman Date: 2013-01-16 22:17 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/2087e24a4357 Merge From lana.steuck at oracle.com Tue Jan 22 22:13:14 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 22 Jan 2013 22:13:14 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/hotspot: 2 new changesets Message-ID: <20130122221331.0968147486@hg.openjdk.java.net> Changeset: 41ccb2e737fb Author: katleman Date: 2013-01-16 11:59 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/41ccb2e737fb Added tag jdk8-b73 for changeset 11619f33cd68 ! .hgtags Changeset: 1a3e54283c54 Author: katleman Date: 2013-01-16 20:53 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1a3e54283c54 Merge ! .hgtags From lana.steuck at oracle.com Tue Jan 22 22:13:27 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 22 Jan 2013 22:13:27 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 16 new changesets Message-ID: <20130122221639.0735A47487@hg.openjdk.java.net> Changeset: 965e89e2abd3 Author: katleman Date: 2013-01-16 12:00 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/965e89e2abd3 Added tag jdk8-b73 for changeset 733885f57e14 ! .hgtags Changeset: e91caf05f441 Author: erikj Date: 2012-12-27 20:18 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e91caf05f441 8005540: build-infra: Improve incremental build speed on windows by caching find results Reviewed-by: ohair ! makefiles/BuildJdk.gmk ! makefiles/CompileDemos.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/CreateJars.gmk ! makefiles/GensrcProperties.gmk ! makefiles/GensrcX11Wrappers.gmk ! makefiles/Images.gmk ! makefiles/Tools.gmk Changeset: 368fa50469da Author: erikj Date: 2012-12-28 09:51 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/368fa50469da 8005549: build-infra: Merge NewMakefile.gmk and common/makefiles/Makefile Reviewed-by: ohair, tbell ! makefiles/BuildJdk.gmk Changeset: 461b069100fa Author: erikj Date: 2013-01-02 15:35 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/461b069100fa 8005355: build-infra: Java security signing (need a top-level make target). Reviewed-by: tbell, ohair ! makefiles/BuildJdk.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CreateJars.gmk + makefiles/SignJars.gmk Changeset: 3841da683703 Author: erikj Date: 2013-01-03 20:55 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3841da683703 8005635: build-infra: Support building install in jprt Reviewed-by: ohair Contributed-by: tim.bell at oracle.com, erik.joelsson at oracle.com ! make/common/shared/Defs-windows.gmk ! makefiles/BuildJdk.gmk ! makefiles/Bundles.gmk ! makefiles/Images.gmk ! makefiles/Tools.gmk Changeset: a8d25b689563 Author: erikj Date: 2013-01-04 16:54 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a8d25b689563 8005694: build-infra: Cleanup of misc changes in build-infra Reviewed-by: tbell ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CreateJars.gmk Changeset: 3824d8469dcf Author: erikj Date: 2013-01-04 17:09 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3824d8469dcf 8005654: build-infra: Create sec-bin.zip Reviewed-by: tbell ! makefiles/CreateJars.gmk Changeset: d98e73b7bc78 Author: erikj Date: 2013-01-04 22:43 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d98e73b7bc78 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing Reviewed-by: tbell ! makefiles/CreateJars.gmk Changeset: 244e481f538b Author: katleman Date: 2013-01-08 13:15 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/244e481f538b Merge ! makefiles/CreateJars.gmk Changeset: 1868bde529b8 Author: ohrstrom Date: 2013-01-09 13:33 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/1868bde529b8 8005096: Move a few source files in swing/beaninfo and in a demo. Reviewed-by: ohair, erikj, malenkov ! make/javax/swing/beaninfo/SwingBeans.gmk - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java + make/tools/swing-beans/javax/swing/SwingBeanInfoBase.java + make/tools/swing-beans/sun/swing/BeanInfoUtils.java ! makefiles/CompileJavaClasses.gmk ! makefiles/GensrcSwing.gmk - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java + src/share/demo/jfc/CodePointIM/com/sun/inputmethods/internal/codepointim/CodePointInputMethod.java + src/share/demo/jfc/CodePointIM/com/sun/inputmethods/internal/codepointim/CodePointInputMethodDescriptor.java Changeset: 2cc29d0b9eaf Author: erikj Date: 2013-01-09 16:13 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2cc29d0b9eaf 8005903: build-infra: bad symlink: j2sdk-bundle/jdk1.8.0.jdk/Contents/MacOS/libjli.dylib Reviewed-by: tbell ! makefiles/Bundles.gmk Changeset: f92ab6dbbff8 Author: erikj Date: 2013-01-10 12:23 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f92ab6dbbff8 8005856: build-infra: Remove special handling of base module classes header generation Reviewed-by: alanb, tbell, ohair Contributed-by: fredrik.ohrstrom at oracle.com ! makefiles/CompileJavaClasses.gmk ! src/share/classes/java/io/FileSystem.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/net/SocketOptions.java ! src/share/classes/sun/nio/ch/IOStatus.java ! src/windows/classes/sun/nio/ch/PollArrayWrapper.java Changeset: 4d80ab394efa Author: erikj Date: 2013-01-15 16:50 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4d80ab394efa 8006296: build-infra: Unsigned sunmscapi.jar is missing manifest. Reviewed-by: alanb, tbell ! makefiles/CreateJars.gmk Changeset: 6d1a3d43851d Author: katleman Date: 2013-01-15 10:08 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6d1a3d43851d Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java Changeset: 3eef1e0540c4 Author: erikj Date: 2013-01-16 16:40 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3eef1e0540c4 8006385: build-infra: linux and solaris *-debuginfo-*.zip file created from the new makefile has extra HUDSON direcotry in jre/lib/i386/server Reviewed-by: tbell ! makefiles/Import.gmk Changeset: 54bbeb149525 Author: katleman Date: 2013-01-16 22:21 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/54bbeb149525 Merge - make/tools/swing-beans/beaninfo/BeanInfoUtils.java - make/tools/swing-beans/beaninfo/SwingBeanInfoBase.java ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk ! makefiles/Images.gmk ! src/share/classes/java/lang/Integer.java - src/share/demo/jfc/CodePointIM/CodePointInputMethod.java - src/share/demo/jfc/CodePointIM/CodePointInputMethodDescriptor.java From andrew.brygin at oracle.com Mon Jan 28 09:40:20 2013 From: andrew.brygin at oracle.com (Andrew Brygin) Date: Mon, 28 Jan 2013 13:40:20 +0400 Subject: [OpenJDK 2D-Dev] [8] request fro review: 8005530: [lcms] Improve performance of ColorConverOp for default destinations In-Reply-To: <50F7217F.7080108@oracle.com> References: <50ED61B6.20207@oracle.com> <50F7217F.7080108@oracle.com> Message-ID: <51064784.5030906@oracle.com> Hello Phil, I have updated the fix according to your comment: http://cr.openjdk.java.net/~bae/8005530/webrev.01/ Beside this, I have included some improvements related to access to profile header (which is quite important in case of decoding jpeg images with embedded color profile), and to raster processing. New benchmark to estimate the performance of image decoding was also added to the fix. Please take a look to a comparison of performance level below. Regarding to the change in build files: I have verified that it works for both old and new build systems. I am pretty sure that the change is safe (the HIGHEST level of optimization is already used for other libraries in jdk). Would you like to see the change in build systems as a separate fix? Thanks, Andrew ====================================================================== Options common across all tests: cmm.colorconv.ccop.ccopOptions.content=photo cmm.colorconv.ccop.ccopOptions.srcType=BYTE_3BYTE_BGR cmm.colorconv.embed.embedOptions.Images=MEDIUM cmm.opts.profiles=1001 cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: OpenJDK Baseline: 0.008438818 (var=18.29%) (100.0%) *************************************** | ****************************************| ****************************************| OpenJDK Fix: 0.012336448 (var=7.36%) (146.19%) ****************************************|****************** ****************************************|***************** ****************************************|**************** cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: OpenJDK Baseline: 0.900596556 (var=2.93%) (100.0%) ******************************************************| ***************************************************** | ******************************************************| OpenJDK Fix: 0.193663771 (var=7.52%) (110.1%) ******************************************************|***** ******************************************************|** ******************************************************|***** cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: OpenJDK Baseline: 0.009548438 (var=16.26%) (100.0%) ***********************************************| ***********************************************| ********************************************* | OpenJDK Fix: 0.011871784 (var=7.76%) (124.33%) ***********************************************|************ ***********************************************|*********** ***********************************************|******** cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: OpenJDK Baseline: 0.927800441 (var=7.74%) (100.0%) ****************************************************| ****************************************************| ****************************************************| OpenJDK Fix: 0.247631935 (var=12.63%) (110.92%) ****************************************************|***** ****************************************************|***** ****************************************************|***** cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: OpenJDK Baseline: 0.171872303 (var=13.62%) (100.0%) ******************************************| ******************************************| ******************************************| OpenJDK Fix: 0.238933601 (var=3.17%) (139.02%) ******************************************|**************** ******************************************|**************** ******************************************|**************** cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: OpenJDK Baseline: 0.615214994 (var=7.92%) (100.0%) ******************************| ******************************| ******************************| OpenJDK Fix: 0.001296456 (var=2.15%) (195.98%) ******************************|***************************** ******************************|**************************** ******************************|***************************** cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: OpenJDK Baseline: 0.065811677 (var=6.25%) (100.0%) ****************| ****************| ****************| OpenJDK Fix: 0.236734693 (var=7.65%) (359.72%) ****************|***************************************** ****************|****************************************** ****************|****************************************** cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: OpenJDK Baseline: 0.763357432 (var=1.53%) (100.0%) ********| ********| ********| OpenJDK Fix: 0.001278227 (var=3.47%) (724.88%) ********|************************************************** ********|************************************************* ********|************************************************** cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: OpenJDK Baseline: 0.110134436 (var=1.92%) (100.0%) ***************************| ***************************| ***************************| OpenJDK Fix: 0.234074823 (var=4.62%) (212.54%) ***************************|****************************** ***************************|******************************* ***************************|****************************** cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: OpenJDK Baseline: 0.391746749 (var=16.2%) (100.0%) ****************| ****************| *************** | OpenJDK Fix: 0.001300390 (var=2.29%) (383.4%) ****************|******************************************* ****************|******************************************* ****************|****************************************** cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: OpenJDK Baseline: 0.110379746 (var=1.38%) (100.0%) ***************************| ***************************| ***************************| OpenJDK Fix: 0.238619309 (var=3.32%) (216.18%) ***************************|****************************** ***************************|****************************** ***************************|******************************* cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: OpenJDK Baseline: 0.846569883 (var=10.33%) (100.0%) *************| *************| *************| OpenJDK Fix: 0.001290600 (var=2.88%) (453.39%) *************|********************************************* *************|********************************************** *************|********************************************* cmm.colorconv.embed.embd_img_read: OpenJDK Baseline: 0.299874002 (var=7.04%) (100.0%) ************| ************| ************| OpenJDK Fix: 0.003114456 (var=9.07%) (494.37%) ************|********************************************* ************|********************************************** ************|********************************************** cmm.profiles.getHeader: OpenJDK Baseline: 136.4378577 (var=4.34%) (100.0%) *| *| *| OpenJDK Fix: 6858.467330 (var=1.36%) (5026.81%) *|********************************************************** *|********************************************************** *|********************************************************** cmm.profiles.getNumComponents: OpenJDK Baseline: 135.4737465 (var=2.49%) (100.0%) *| *| *| OpenJDK Fix: 6903.416838 (var=4.1%) (5095.76%) *|********************************************************* *|******************************************************** *|******************************************************** Summary: OpenJDK Baseline: Number of tests: 15 Overall average: 18.159329310271605 Best spread: 1.38% variance Worst spread: 18.29% variance (Basis for results comparison) OpenJDK Fix: Number of tests: 15 Overall average: 917.5243389674637 Best spread: 1.36% variance Worst spread: 12.63% variance Comparison to basis: Best result: 5095.76% of basis Worst result: 110.1% of basis Number of wins: 15 Number of ties: 0 Number of losses: 0 On 1/17/2013 1:54 AM, Phil Race wrote: > The variables > 154 ShortComponentRaster shortRaster; > 155 IntegerComponentRaster intRaster; > 156 ByteComponentRaster byteRaster; > > are each used only in a localised few lines of code, > can we move them to the block where they are used so > that their scope is limited to that ? I don't know for a fact > but I can imagine that the VM can then skip allocating stack for them > until you enter that block which actually needs them. > > As you note,this takes into account old and new builds in the makefile > changes > Have you tested both ? > And unless you are 100% confident in this [minimal] change > you should get sign off from the build group as they've recently > requested. > > You should add "noreg-perf" as a label in the JIRA > > -phil. > > On 1/9/2013 4:25 AM, Andrew Brygin wrote: >> Hello Jennifer and Phil, >> >> could you please review a fix for CR 8005530? >> >> CR: http://bugs.sun.com/view_bug.do?bug_id=8005530 >> Webrev:http://cr.openjdk.java.net/~bae/8005530/webrev.00/ >> >> This fix improves performance of ColorConvertOp.filter() >> operation in case of lcms. The fix can be divided into >> three separate changes: >> >> * provide support for custom component images in >> LCMSImageLayout. >> This change affects the case of conversion to default >> destination. >> >> * provide a way to process whole image, instead of >> scan-by-scan processing, if both source and >> destination images do not contain padding samples >> (i.e. next scan starts immediately after previous). >> >> * increase optimization level for lcms library from >> LOW to HIGHEST. This change affects both new and >> standard build systems. >> >> A benchmark comparison below illustrates the increase >> of performance: >> >> Options common across all tests: >> testname=cmm.colorconv.ccop.op_img >> cmm.colorconv.ccop.ccopOptions.srcType=BYTE_3BYTE_BGR >> cmm.colorconv.ccop.ccopOptions.content=photo >> cmm.opts.profiles=1001 >> >> cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: >> >> OpenJDK Baseline: 0.152008134 (var=1.02%) (100.0%) >> *************************************| >> *************************************| >> *************************************| >> OpenJDK Fix: 0.245116358 (var=2.0%) (161.25%) >> *************************************|********************** >> *************************************|********************** >> *************************************|********************* >> cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: >> >> OpenJDK Baseline: 0.914826498 (var=0.41%) (100.0%) >> ***************************| >> ***************************| >> ***************************| >> OpenJDK Fix: 0.001310043 (var=2.24%) (221.48%) >> ***************************|******************************** >> ***************************|******************************** >> ***************************|******************************** >> cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: >> >> OpenJDK Baseline: 0.060737151 (var=1.57%) (100.0%) >> ***************| >> ***************| >> ***************| >> OpenJDK Fix: 0.242736486 (var=1.53%) (399.65%) >> ***************|******************************************* >> ***************|******************************************** >> ***************|******************************************** >> cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: >> >> OpenJDK Baseline: 0.559251559 (var=0.7%) (100.0%) >> *******| >> *******| >> *******| >> OpenJDK Fix: 0.001306904 (var=1.05%) (838.16%) >> *******|*************************************************** >> *******|**************************************************** >> *******|**************************************************** >> >> Summary: >> OpenJDK Baseline: >> Number of tests: 4 >> Overall average: 0.053373173444166644 >> Best spread: 0.41% variance >> Worst spread: 1.57% variance >> (Basis for results comparison) >> >> OpenJDK Fix: >> Number of tests: 4 >> Overall average: 0.12261744826137347 >> Best spread: 1.05% variance >> Worst spread: 2.24% variance >> Comparison to basis: >> Best result: 838.16% of basis >> Worst result: 161.25% of basis >> Number of wins: 4 >> Number of ties: 0 >> Number of losses: 0 >> >> Thanks, >> Andrew >> > From philip.race at oracle.com Mon Jan 28 21:52:42 2013 From: philip.race at oracle.com (Phil Race) Date: Mon, 28 Jan 2013 13:52:42 -0800 Subject: [OpenJDK 2D-Dev] [8] request fro review: 8005530: [lcms] Improve performance of ColorConverOp for default destinations In-Reply-To: <51064784.5030906@oracle.com> References: <50ED61B6.20207@oracle.com> <50F7217F.7080108@oracle.com> <51064784.5030906@oracle.com> Message-ID: <5106F32A.5020807@oracle.com> This is all fine by me. -phil. On 1/28/2013 1:40 AM, Andrew Brygin wrote: > Hello Phil, > > I have updated the fix according to your comment: > > http://cr.openjdk.java.net/~bae/8005530/webrev.01/ > > Beside this, I have included some improvements related to > access to profile header (which is quite important in case > of decoding jpeg images with embedded color profile), > and to raster processing. > New benchmark to estimate the performance of image > decoding was also added to the fix. > > Please take a look to a comparison of performance level > below. > > Regarding to the change in build files: I have verified that > it works for both old and new build systems. I am pretty > sure that the change is safe (the HIGHEST level of optimization > is already used for other libraries in jdk). > > Would you like to see the change in build systems as a > separate fix? > > Thanks, > Andrew > > ====================================================================== > Options common across all tests: > cmm.colorconv.ccop.ccopOptions.content=photo > cmm.colorconv.ccop.ccopOptions.srcType=BYTE_3BYTE_BGR > cmm.colorconv.embed.embedOptions.Images=MEDIUM > cmm.opts.profiles=1001 > > cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: > > OpenJDK Baseline: 0.008438818 (var=18.29%) (100.0%) > *************************************** | > ****************************************| > ****************************************| > OpenJDK Fix: 0.012336448 (var=7.36%) (146.19%) > ****************************************|****************** > ****************************************|***************** > ****************************************|**************** > cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: > > OpenJDK Baseline: 0.900596556 (var=2.93%) (100.0%) > ******************************************************| > ***************************************************** | > ******************************************************| > OpenJDK Fix: 0.193663771 (var=7.52%) (110.1%) > ******************************************************|***** > ******************************************************|** > ******************************************************|***** > cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: > > OpenJDK Baseline: 0.009548438 (var=16.26%) (100.0%) > ***********************************************| > ***********************************************| > ********************************************* | > OpenJDK Fix: 0.011871784 (var=7.76%) (124.33%) > ***********************************************|************ > ***********************************************|*********** > ***********************************************|******** > cmm.colorconv.ccop.op_draw,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: > > OpenJDK Baseline: 0.927800441 (var=7.74%) (100.0%) > ****************************************************| > ****************************************************| > ****************************************************| > OpenJDK Fix: 0.247631935 (var=12.63%) (110.92%) > ****************************************************|***** > ****************************************************|***** > ****************************************************|***** > cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: > > OpenJDK Baseline: 0.171872303 (var=13.62%) (100.0%) > ******************************************| > ******************************************| > ******************************************| > OpenJDK Fix: 0.238933601 (var=3.17%) (139.02%) > ******************************************|**************** > ******************************************|**************** > ******************************************|**************** > cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: > > OpenJDK Baseline: 0.615214994 (var=7.92%) (100.0%) > ******************************| > ******************************| > ******************************| > OpenJDK Fix: 0.001296456 (var=2.15%) (195.98%) > ******************************|***************************** > ******************************|**************************** > ******************************|***************************** > cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: > > OpenJDK Baseline: 0.065811677 (var=6.25%) (100.0%) > ****************| > ****************| > ****************| > OpenJDK Fix: 0.236734693 (var=7.65%) (359.72%) > ****************|***************************************** > ****************|****************************************** > ****************|****************************************** > cmm.colorconv.ccop.op_img,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: > > OpenJDK Baseline: 0.763357432 (var=1.53%) (100.0%) > ********| > ********| > ********| > OpenJDK Fix: 0.001278227 (var=3.47%) (724.88%) > ********|************************************************** > ********|************************************************* > ********|************************************************** > cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: > > OpenJDK Baseline: 0.110134436 (var=1.92%) (100.0%) > ***************************| > ***************************| > ***************************| > OpenJDK Fix: 0.234074823 (var=4.62%) (212.54%) > ***************************|****************************** > ***************************|******************************* > ***************************|****************************** > cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: > > OpenJDK Baseline: 0.391746749 (var=16.2%) (100.0%) > ****************| > ****************| > *************** | > OpenJDK Fix: 0.001300390 (var=2.29%) (383.4%) > ****************|******************************************* > ****************|******************************************* > ****************|****************************************** > cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: > > OpenJDK Baseline: 0.110379746 (var=1.38%) (100.0%) > ***************************| > ***************************| > ***************************| > OpenJDK Fix: 0.238619309 (var=3.32%) (216.18%) > ***************************|****************************** > ***************************|****************************** > ***************************|******************************* > cmm.colorconv.ccop.op_rst,cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: > > OpenJDK Baseline: 0.846569883 (var=10.33%) (100.0%) > *************| > *************| > *************| > OpenJDK Fix: 0.001290600 (var=2.88%) (453.39%) > *************|********************************************* > *************|********************************************** > *************|********************************************* > cmm.colorconv.embed.embd_img_read: > OpenJDK Baseline: 0.299874002 (var=7.04%) (100.0%) > ************| > ************| > ************| > OpenJDK Fix: 0.003114456 (var=9.07%) (494.37%) > ************|********************************************* > ************|********************************************** > ************|********************************************** > cmm.profiles.getHeader: > OpenJDK Baseline: 136.4378577 (var=4.34%) (100.0%) > *| > *| > *| > OpenJDK Fix: 6858.467330 (var=1.36%) (5026.81%) > *|********************************************************** > *|********************************************************** > *|********************************************************** > cmm.profiles.getNumComponents: > OpenJDK Baseline: 135.4737465 (var=2.49%) (100.0%) > *| > *| > *| > OpenJDK Fix: 6903.416838 (var=4.1%) (5095.76%) > *|********************************************************* > *|******************************************************** > *|******************************************************** > > Summary: > OpenJDK Baseline: > Number of tests: 15 > Overall average: 18.159329310271605 > Best spread: 1.38% variance > Worst spread: 18.29% variance > (Basis for results comparison) > > OpenJDK Fix: > Number of tests: 15 > Overall average: 917.5243389674637 > Best spread: 1.36% variance > Worst spread: 12.63% variance > Comparison to basis: > Best result: 5095.76% of basis > Worst result: 110.1% of basis > Number of wins: 15 > Number of ties: 0 > Number of losses: 0 > > > On 1/17/2013 1:54 AM, Phil Race wrote: >> The variables >> 154 ShortComponentRaster shortRaster; >> 155 IntegerComponentRaster intRaster; >> 156 ByteComponentRaster byteRaster; >> >> are each used only in a localised few lines of code, >> can we move them to the block where they are used so >> that their scope is limited to that ? I don't know for a fact >> but I can imagine that the VM can then skip allocating stack for them >> until you enter that block which actually needs them. >> >> As you note,this takes into account old and new builds in the >> makefile changes >> Have you tested both ? >> And unless you are 100% confident in this [minimal] change >> you should get sign off from the build group as they've recently >> requested. >> >> You should add "noreg-perf" as a label in the JIRA >> >> -phil. >> >> On 1/9/2013 4:25 AM, Andrew Brygin wrote: >>> Hello Jennifer and Phil, >>> >>> could you please review a fix for CR 8005530? >>> >>> CR: http://bugs.sun.com/view_bug.do?bug_id=8005530 >>> Webrev:http://cr.openjdk.java.net/~bae/8005530/webrev.00/ >>> >>> This fix improves performance of ColorConvertOp.filter() >>> operation in case of lcms. The fix can be divided into >>> three separate changes: >>> >>> * provide support for custom component images in >>> LCMSImageLayout. >>> This change affects the case of conversion to default >>> destination. >>> >>> * provide a way to process whole image, instead of >>> scan-by-scan processing, if both source and >>> destination images do not contain padding samples >>> (i.e. next scan starts immediately after previous). >>> >>> * increase optimization level for lcms library from >>> LOW to HIGHEST. This change affects both new and >>> standard build systems. >>> >>> A benchmark comparison below illustrates the increase >>> of performance: >>> >>> Options common across all tests: >>> testname=cmm.colorconv.ccop.op_img >>> cmm.colorconv.ccop.ccopOptions.srcType=BYTE_3BYTE_BGR >>> cmm.colorconv.ccop.ccopOptions.content=photo >>> cmm.opts.profiles=1001 >>> >>> cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=250: >>> >>> OpenJDK Baseline: 0.152008134 (var=1.02%) (100.0%) >>> *************************************| >>> *************************************| >>> *************************************| >>> OpenJDK Fix: 0.245116358 (var=2.0%) (161.25%) >>> *************************************|********************** >>> *************************************|********************** >>> *************************************|********************* >>> cmm.colorconv.ccop.ccopOptions.dstType=BYTE_3BYTE_BGR,cmm.colorconv.ccop.ccopOptions.size=4000: >>> >>> OpenJDK Baseline: 0.914826498 (var=0.41%) (100.0%) >>> ***************************| >>> ***************************| >>> ***************************| >>> OpenJDK Fix: 0.001310043 (var=2.24%) (221.48%) >>> ***************************|******************************** >>> ***************************|******************************** >>> ***************************|******************************** >>> cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=250: >>> >>> OpenJDK Baseline: 0.060737151 (var=1.57%) (100.0%) >>> ***************| >>> ***************| >>> ***************| >>> OpenJDK Fix: 0.242736486 (var=1.53%) (399.65%) >>> ***************|******************************************* >>> ***************|******************************************** >>> ***************|******************************************** >>> cmm.colorconv.ccop.ccopOptions.dstType=COMPATIBLE_DST,cmm.colorconv.ccop.ccopOptions.size=4000: >>> >>> OpenJDK Baseline: 0.559251559 (var=0.7%) (100.0%) >>> *******| >>> *******| >>> *******| >>> OpenJDK Fix: 0.001306904 (var=1.05%) (838.16%) >>> *******|*************************************************** >>> *******|**************************************************** >>> *******|**************************************************** >>> >>> Summary: >>> OpenJDK Baseline: >>> Number of tests: 4 >>> Overall average: 0.053373173444166644 >>> Best spread: 0.41% variance >>> Worst spread: 1.57% variance >>> (Basis for results comparison) >>> >>> OpenJDK Fix: >>> Number of tests: 4 >>> Overall average: 0.12261744826137347 >>> Best spread: 1.05% variance >>> Worst spread: 2.24% variance >>> Comparison to basis: >>> Best result: 838.16% of basis >>> Worst result: 161.25% of basis >>> Number of wins: 4 >>> Number of ties: 0 >>> Number of losses: 0 >>> >>> Thanks, >>> Andrew >>> >> > From jvanek at redhat.com Wed Jan 30 11:48:18 2013 From: jvanek at redhat.com (Jiri Vanek) Date: Wed, 30 Jan 2013 12:48:18 +0100 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for fontmanager when no fonts are installed - RHBZ#862355, In-Reply-To: <50B408C7.6000003@oracle.com> References: <50A13AE4.70701@redhat.com> <50A15A8A.7040505@oracle.com> <50A15F7A.9070701@oracle.com> <50A25D9D.9010100@redhat.com> <50AA1C5A.6050502@redhat.com> <50B408C7.6000003@oracle.com> Message-ID: <51090882.4010307@redhat.com> Ugh, sorry for delay, I had to find some free-time to attempt 2:) I have kept NoFontsFound exception which is thrown out of the Win32 or x11 font manager. It is then cough in SunFontMAnager and fallback font is provided for OpenJDK. I must admit that my win32 hacks were not completely tested yet. This fallback font consists just from substitute character, and source file is maintainable via fontofrge. During build of jdk tff font is generated by fontforge and deployed to LIBDIR/fonts I have chosen this approach because it is providing source file. And so it can be properly tracked and have "opens source" (and thus avoiding possible comunity issues) and.. it can grow.. I'm quite affraid that fontoforge dependence will be unacceptable for openjdk:( If so, then direct tff file can be provided. The "just substitute character" font should avoid any license issues, but if acceptable - on fontforge page are several BSD-like licensed - fonts http://fontforge.org/sfds/ Some of those fonts can be used instead if license is ok. Makefile changes are not complete as I will continue work on them according to your wishes. http://jvanek.fedorapeople.org/oracle/jdk8/webrevs/noFontsFound/v2/webrev/ http://jvanek.fedorapeople.org/oracle/jdk8/webrevs/noFontsFound/v2/webrev.zip Still some work awaiting, and I'm looking forward for feedback! Best regards J. On 11/27/2012 01:26 AM, Phil Race wrote: > I'd like to find something to make this more survivable, but > my main point is that having only Font.createFont() work and not system fonts > is a configuration not worth supporting. Its too fragile. > Your suggestion below makes it less fragile, but its still not widely useful. > If no one calls Font.createFont() in time, none of this will help. > > If the problem is "just" fontconfig then perhaps we can add a filesystem > search of well known locations as a fallback. Once upon a time that was > more or less all we had .. before fontconfig came along. This is independent > of Font.createFont() as a solution. That code is still there but I'm not > sure if its still being kicked in if fontconfig is present and fails. > Also its list of locations to search may have become dated .. > > But if there are absoutely zero fonts - and no one calls Font.createFont() > early, there's still a problem. > > Shipping a default font with the JRE is the only answer to that. > Seems like that's going to be awkward in the short term as we'd > need to find a font that could be stored in the OpenJDK repo to > be included automatically by the build and it would have to be > one that satisfies Oracle's lawyers as OK to include. > > But distros could do whatever makes sense and the missing piece > is to have the JRE look for this default font. The logic in > SunFontManager needs to have something in the isOpenJDK() branch > to check for a system property (perhaps) to fill in defaultFontFileName etc. > > -phil. > > On 11/19/2012 3:47 AM, Jiri Vanek wrote: >> Not sure if last email was final refuse ;) - I would like to continue in fixing this. From >> current "trialogue" I guess I have several possible ways of fixing it - >> - Add another font-manager, which will be possible to enable via sun.font.fontmanager >> - add command line switch which will "enable" "my fix" >> >> Or what about this approach: >> - when createFont(f) is called, and no fonts are found, then use this font as default font. >> >> >> Do you have any preferences for any of above approaches or do you really want idea behind this >> patch to be scratched away from table? >> >> Thank you very much for already given feedback, >> Best regards, >> J. >> >> On 11/13/2012 03:47 PM, Jiri Vanek wrote: >>> >>> Thank you both for valuable feedback, >>> >>> Yes, this was very straight-forward fix, but also the less harmful. I tested it quite heavvily, and >>> it does not move failure to "just later". Jre is working pretty find (as all calls to >>> FontManagerFactory are returning this stub, which is making its job quite fine:) >>> This fix was really intended for small (but maybe bigger then we think) group of headless devices, >>> where openjdk have its place. Such a device can have pretty good output eg via html, but no need for >>> fonts at "server" at all. This headless device will definitely have no need for fonts at all. >>> Except eg generating captcha which can be exactly the usage you have described. >>> >>> However your contra-usecase with misconfigured system or JRE is more then true, and I agree with >>> it. The workaround for user, to provide his ttf as default font can be maybe best solution. >>> >>> The approach of OracleJDK is well known to me - It have its default fonts. In world of opensource >>> the fonts were always little bit painful topic, but still this solution may be working to. >>> >>> Anyway both solution above are workarounds and does not fix the issue that createFont(or even most >>> of jre) should work no meter what fonts are installed. >>> >>> >>> Another suggested patch was make it configurable - but then it already is, as one can easily provide >>> custom font manager via sun.font.fontmanager property. Then we can maybe make life little bit more >>> easier by adding such "improved" fontmanager implementation. >>> >>> >>> I'm sorry for providing just linux implementation, but linux is probably target platform in such a >>> devices. It was also serving as proof of concept. I'm definitely going to implement this also for >>> win/mac when possible solution will be clarified. >>> >>> Currently I'm definitely for adding NoFontsFound exception (better then NullPointException, and >>> maybe extend it also for case that this Array have 0 length[just idea during writing]?), and think >>> little bit more about it. >>> Although I still like "my approach" the most, I'm going to obey yours advice but I still believe >>> this issue is worthy to be fixed. >>> >>> Best regards, >>> J. >>> >>> >>>> 2012/11/12 Phil Race > >>>> >>>> Well this seems like a really narrow use case for an extremely rare system >>>> misconfiguration. It wouldn't help the 99.999% of apps which expect to >>>> kick off AWT or Swing. >>>> >>>> And can you ensure that nothing in the app, or in the implementation makes >>>> the (reasonable) expectation that there are other fonts installed ? >>>> The most you could do is render to a BufferedImage or similar using the explicitly >>>> loaded font. The default logical font installed on a SG2D will be backed by a non-existent >>>> physical font, so you'd need to swap that in sooner rather than later. >>>> >>>> At some point you have to say that if JRE or system components are missing, >>>> then the source of the problem is what you should fix rather than make the >>>> JRE work around it. >>>> >>>> If you do want to try something, then in this case you get a much more usable >>>> runtime by providing a default font that the JRE can ensure is available so >>>> that the other 99.999% of apps can get by. >>>> >>>> The "Oracle" JDK gets by in this case precisely because it has a real physical font >>>> to fall back on. >>>> >>>> -phil. >>>> >>>> >>>> >>>> Hi Phil, >>>> >>>> I'm thinking here of Headless or embedded devices where the full Swing/AWT support may not be >>>> needed. >>>> >>>> Anyway, I see your point that those cases are definitely the minority and if OpenJDK doesn't >>>> want to >>>> work on those system, then I can only say that whoever is going to have such use case can just >>>> apply >>>> this patch and live with it. >>>> >>>> I totally agree however that if this comes from a misconfiguration rather than a conscious decision >>>> the JDK should probably protect itself by failing earlier (it will fail anyway, as you noted >>>> though). >>>> >>>> Perhaps a better patch would be to allow this to be configurable, by still introducing this new >>>> FontManager but making it a named class and allow this as an option, defaulting on the old >>>> behaviour, and at the same time giving a better error message. >>>> >>>> Also, like you suggest, ship a fallback in jre/lib/fonts sound a better idea in most cases. >>>> >>>> Cheers, >>>> Mario >>>> >>>> On 11/12/2012 12:29 PM, Mario Torre wrote: >>>> >>>> Hi Phil, >>>> >>>> I believe that the underlying problem here is that it should be legal to create a font from >>>> a file, even if the FontManager doesn't have any fonts installed. >>>> >>>> So, code like the one in the example: >>>> public class Test { >>>> public static void main(String[] args) throws Exception { >>>> Font.createFont(Font.TRUETYPE___FONT, new File("example.ttf")); >>>> } >>>> } >>>> >>>> When passed a real, valid font (example.ttf in this case) would still fail with the old >>>> code, and instead would work with the given patch (at least, I think this is the idea here, >>>> Jiri can probably explain in more details his intentions?). >>>> >>>> Cheers, >>>> Mario >>>> >>>> >>>> 2012/11/12 Phil Race >>>> __>> >>>> >>>> >>>> Hello Jiri, >>>> >>>> Doesn't this just move the point of failure to a bit later ? >>>> I can't see how having zero fonts on the system is survivable for an >>>> app that uses fonts. That's the principal reason we haven't tried >>>> to do something like this already. >>>> >>>> When facing system configuration issues maybe we just need to >>>> print a better message for the exception such as >>>> throw new InternalError("Can't find any fonts installed on this >>>> system."); >>>> >>>> Or make the default font more configurable and distros could ship >>>> one in jre/lib/fonts. >>>> >>>> BTW it appears you are only trying to solve the problem for >>>> Linux/Unix. >>>> Nothing for Windows or OS X. >>>> >>>> -phil. >>>> >>>> >>>> On 11/12/2012 10:07 AM, Jiri Vanek wrote: >>>> >>>> Hi! >>>> >>>> This is attempt to fix >>>> https://bugzilla.redhat.com/__show_bug.cgi?id=862355 >>>> >>>> The patch is introducing new exception >>>> src/share/classes/sun/font/__NoFontsFoundException.java, which >>>> is thrown from >>>> /src/solaris/classes/sun/awt/__X11FontManager.java instead of >>>> null pointer exception when no fonts are found on system. >>>> Exception is then catch in >>>> src/share/classes/sun/font/__FontManagerFactory.java, and in >>>> this case it returns (and not caching the instance of it) >>>> dummy font manager instead of continue in failure. >>>> the dummy manager do nothing, except that it is able to create >>>> java.awt.Font in same way as SunFontManager is doing, but is >>>> not doing any caching. >>>> >>>> To avoid duplicate code with >>>> src/share/classes/sun/font/__SunFontManager.java, i have >>>> extracted code from method createFont2D to new method here - >>>> prepareFont2D - which is responsible for creating font until >>>> caching.. >>>> >>>> Best regards, >>>> J. >>>> >>>> webrev >>>> http://jvanek.fedorapeople.__org/oracle/jdk8/webrevs/__fontProperties/ >>>> >>>> with test (although it will probably need some tuning and I'm >>>> not sure where is the best place for it) >>>> >>>> http://jvanek.fedorapeople.__org/oracle/jdk8/webrevs/__fontProperties/test/src/__nofontsreproducer/ >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>> > From anton.litvinov at oracle.com Wed Jan 30 16:14:47 2013 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Wed, 30 Jan 2013 20:14:47 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <50EFFB4F.4090405@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> <50EE1CEB.5080500@oracle.com> <50EFED12.6070700@oracle.com> <50EFFB4F.4090405@oracle.com> Message-ID: <510946F7.3090709@oracle.com> Hello Anthony, Could you, please, review a second version of the fix, which is based on an idea of reusing the existing AWT native global error handler from Java 2D native code. Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.01 The fix consists of the following parts: 1. Migration of all X error handling code from XToolkit to a new XErrorHandlerUtil class for resolution of interdependency between a static initialization block of XToolkit and a block initializing java.awt.GraphicsEnvironment singleton. Such dependency is created by new calls to XToolkit static methods from "src/solaris/native/sun/awt/awt_GraphicsEnv.c", "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" files. 2. Substitution of XToolkit.WITH_XERROR_HANDLER, XToolkit.RESTORE_XERROR_HANDLER ... for corresponding methods, fields of XErrorHandlerUtil class in all places of JDK source code, where they were used. 3. Substitution of all found native X error handlers which are set in native code (awt_GraphicsEnv.c, X11SurfaceData.c, GLXSurfaceData.c) for new synthetic Java error handlers. 4. Removal of X error handling code used by the native error handlers from "solaris/native/sun/awt/awt_util.c" "solaris/native/sun/awt/awt_util.h" files. Thank you, Anton On 1/11/2013 3:45 PM, Anthony Petrov wrote: > I'm not Jim, but as I indicated earlier my opinion is that the easiest > way to fix this is to install the existing J2DXErrHandler() only once. > That is, it is the second option listed by you. Of course, the > J2DXErrHandler needs to be updated as well to detect whether 2D code > wants to use it at the moment or it must simply delegate to the > previous handler (i.e. where the code currently installs/uninstalls > the handler, it must instead set a global boolean flag or something.) > > While the first option (reusing the existing AWT machinery) is an > interesting idea in general, I think it is complex and would require > too much additional testing and bring an unjustified risk to the > solution for such a basic problem. > > -- > best regards, > Anthony > > On 1/11/2013 14:44, Anton Litvinov wrote: >> Hello Jim, >> >> Thank you very much for the review and provision of a new idea of a >> solution. Elimination of the logic, which sets/unsets >> J2DXErrHandler() for each call "XShmAttach(awt_display, &shminfo))" >> should effectively resolve the issue, but only in case if all other >> native error handlers, which were set by the system function >> "XSetErrorHandler()" in JDK or in any external library, observe the >> rule of relaying of all events, which are not relative to them, to >> the previously saved error handlers. Otherwise an error generated >> during "XShmAttach" function call will not be handled by >> J2DXErrHandler(). >> >> Could you answer the following question. By setting J2DXErrHandler() >> only once and forever do you mean usage of AWT global event handler >> "static int ToolkitErrorHandler(Display * dpy, XErrorEvent * event)" >> from "src/solaris/native/sun/xawt/XlibWrapper.c" with Java synthetic >> handlers or creation of another global native error handler with >> J2DXErrHandler as native synthetic handler? >> >> Thank you, >> Anton >> >> On 1/10/2013 5:44 AM, Jim Graham wrote: >>> I think I'd rather see some way to prevent double-adding the handler >>> in the first place as well. Since it is only ever used on errors I >>> also think it is OK to set it once and leave it there forever... >>> >>> ...jim >>> >>> On 1/9/13 8:08 AM, Anthony Petrov wrote: >>>> Hi Anton et al., >>>> >>>> If I read the description of the bug correctly, specifically this >>>> part: >>>> >>>>> The problem occurs, if another thread (for example, GTK thread) is >>>>> doing the same sort of thing concurrently. This can lead to the >>>>> following situation. >>>>> JVM thread: Sets J2DXErrHandler(), saves ANY_PREVIOUS_HANDLER as >>>>> previous GTK thread: Sets some GTK_HANDLER, saves >>>>> J2DXErrHandler() as previous JVM thread: Restores >>>>> ANY_PREVIOUS_HANDLER GTK thread: Restores J2DXErrHandler() JVM >>>>> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as previous >>>> >>>> It is obvious that at this final step 2D is in an inconsistent >>>> state. We >>>> don't expect to replace our own error handler (and it shouldn't have >>>> been there in the first place). >>>> >>>> I realize that the fix you propose works around this problem. But this >>>> doesn't look like an ideal solution to me. >>>> >>>> BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 error >>>> handler only once and never replace it. All the rest of the >>>> push_handler/pop_handler logic is now located in Java code (see >>>> XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I believe >>>> that we should somehow share this machinery with the 2D code to avoid >>>> this sort of problems. Though I'm not sure if this will eliminate this >>>> exact issue. >>>> >>>> >>>> 2D/AWT folks: any other thoughts? >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 12/29/2012 17:44, Anton Litvinov wrote: >>>>> Hello, >>>>> >>>>> Please review the following fix for a bug. >>>>> >>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >>>>> https://jbs.oracle.com/bugs/browse/JDK-8005607 >>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >>>>> >>>>> The bug consists in a crash which is caused by a stack overflow for >>>>> the reason of an infinite recursion in AWT native function >>>>> J2DXErrHandler() under certain circumstances on 32-bit Linux OS. The >>>>> fix is based on introduction of the logic, which detects indirect >>>>> recursive calls to J2DXErrHandler() by means of a simple counter, to >>>>> J2DXErrHandler() native function. Such a solution requires minimum >>>>> code changes, does not alter the handler's code significantly and >>>>> eliminates this bug. >>>>> >>>>> Adding 2d-dev at openjdk.java.net e-mail alias to the list of recipients >>>>> of this letter, because the edited function's name is related to Java >>>>> 2D area of JDK, despite of the fact that the edited file is >>>>> located in >>>>> AWT directory. >>>>> >>>>> Thank you, >>>>> Anton -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrew.brygin at oracle.com Thu Jan 31 10:54:30 2013 From: andrew.brygin at oracle.com (Andrew Brygin) Date: Thu, 31 Jan 2013 14:54:30 +0400 Subject: [OpenJDK 2D-Dev] [8] request for review: 8004801: The image of BufferedImage.TYPE_INT_ARGB is blank. Message-ID: <510A4D66.6020209@oracle.com> Hello Jennifer and Phil, could you please review a fix for CR 8004801? Bug: http://bugs.sun.com/view_bug.do?bug_id=8004801 Webrev: http://cr.openjdk.java.net/~bae/8004801/8/webrev.00/ The test uses reverse lookup with single lookup table. This sort of operation should change only color components of processed images, but alpha channel should be unchanged. However, due to a mistake in color order detection, the reverse lookup is applied to the alpha channel, that results in completely transparent destination image. This mistake in color order is caused by the platform-depended implementation of awt_getBIColorOrder() routine: for all unix system, this routine is implemented in assumption that system is bigendian. Suggested solution is to move the awt_getBIColorOrder() to shared code, and re-write taking system endianness into account. Supplied regression test demonstrates the problem. Please take a look. Thanks, Andrew. From anthony.petrov at oracle.com Thu Jan 31 12:57:56 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 31 Jan 2013 16:57:56 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <510946F7.3090709@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> <50EE1CEB.5080500@oracle.com> <50EFED12.6070700@oracle.com> <50EFFB4F.4090405@oracle.com> <510946F7.3090709@oracle.com> Message-ID: <510A6A54.1080705@oracle.com> Hi Anton, A couple comments: 1. src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java > 80 private static void init(long display) { This method is private and isn't called from anywhere in this class itself. This looks confusing. Please add a comment stating that this method is invoked from native code, and from where exactly. 2. Interesting that we use this machinery to call the XShmAttach() from native code twice, and the code looks quite similar in each case. Would it be possible to extract the common code in a separate function (a-la BOOL TryXShmAttach(...)) to avoid code replication? There are other usages as well, so we could also introduce a macro (such as the old EXEC_WITH_XERROR_HANDLER but now with other arguments) that would minimize all the JNU_ calls required to use this machinery. Otherwise the fix looks great. -- best regards, Anthony On 1/30/2013 20:14, Anton Litvinov wrote: > Hello Anthony, > > Could you, please, review a second version of the fix, which is based on > an idea of reusing the existing AWT native global error handler from > Java 2D native code. > > Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.01 > > The fix consists of the following parts: > > 1. Migration of all X error handling code from XToolkit to a new > XErrorHandlerUtil class for resolution of interdependency between > a static initialization block of XToolkit and a block initializing > java.awt.GraphicsEnvironment singleton. Such dependency is created > by new calls to XToolkit static methods from > "src/solaris/native/sun/awt/awt_GraphicsEnv.c", > "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" files. > 2. Substitution of XToolkit.WITH_XERROR_HANDLER, > XToolkit.RESTORE_XERROR_HANDLER ... for corresponding methods, > fields of XErrorHandlerUtil class in all places of JDK source > code, where they were used. > 3. Substitution of all found native X error handlers which are set in > native code (awt_GraphicsEnv.c, X11SurfaceData.c, > GLXSurfaceData.c) for new synthetic Java error handlers. > 4. Removal of X error handling code used by the native error handlers > from "solaris/native/sun/awt/awt_util.c" > "solaris/native/sun/awt/awt_util.h" files. > > Thank you, > Anton > > On 1/11/2013 3:45 PM, Anthony Petrov wrote: >> I'm not Jim, but as I indicated earlier my opinion is that the easiest >> way to fix this is to install the existing J2DXErrHandler() only once. >> That is, it is the second option listed by you. Of course, the >> J2DXErrHandler needs to be updated as well to detect whether 2D code >> wants to use it at the moment or it must simply delegate to the >> previous handler (i.e. where the code currently installs/uninstalls >> the handler, it must instead set a global boolean flag or something.) >> >> While the first option (reusing the existing AWT machinery) is an >> interesting idea in general, I think it is complex and would require >> too much additional testing and bring an unjustified risk to the >> solution for such a basic problem. >> >> -- >> best regards, >> Anthony >> >> On 1/11/2013 14:44, Anton Litvinov wrote: >>> Hello Jim, >>> >>> Thank you very much for the review and provision of a new idea of a >>> solution. Elimination of the logic, which sets/unsets >>> J2DXErrHandler() for each call "XShmAttach(awt_display, &shminfo))" >>> should effectively resolve the issue, but only in case if all other >>> native error handlers, which were set by the system function >>> "XSetErrorHandler()" in JDK or in any external library, observe the >>> rule of relaying of all events, which are not relative to them, to >>> the previously saved error handlers. Otherwise an error generated >>> during "XShmAttach" function call will not be handled by >>> J2DXErrHandler(). >>> >>> Could you answer the following question. By setting J2DXErrHandler() >>> only once and forever do you mean usage of AWT global event handler >>> "static int ToolkitErrorHandler(Display * dpy, XErrorEvent * event)" >>> from "src/solaris/native/sun/xawt/XlibWrapper.c" with Java synthetic >>> handlers or creation of another global native error handler with >>> J2DXErrHandler as native synthetic handler? >>> >>> Thank you, >>> Anton >>> >>> On 1/10/2013 5:44 AM, Jim Graham wrote: >>>> I think I'd rather see some way to prevent double-adding the handler >>>> in the first place as well. Since it is only ever used on errors I >>>> also think it is OK to set it once and leave it there forever... >>>> >>>> ...jim >>>> >>>> On 1/9/13 8:08 AM, Anthony Petrov wrote: >>>>> Hi Anton et al., >>>>> >>>>> If I read the description of the bug correctly, specifically this >>>>> part: >>>>> >>>>>> The problem occurs, if another thread (for example, GTK thread) is >>>>>> doing the same sort of thing concurrently. This can lead to the >>>>>> following situation. >>>>>> JVM thread: Sets J2DXErrHandler(), saves ANY_PREVIOUS_HANDLER as >>>>>> previous GTK thread: Sets some GTK_HANDLER, saves >>>>>> J2DXErrHandler() as previous JVM thread: Restores >>>>>> ANY_PREVIOUS_HANDLER GTK thread: Restores J2DXErrHandler() JVM >>>>>> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as previous >>>>> >>>>> It is obvious that at this final step 2D is in an inconsistent >>>>> state. We >>>>> don't expect to replace our own error handler (and it shouldn't have >>>>> been there in the first place). >>>>> >>>>> I realize that the fix you propose works around this problem. But this >>>>> doesn't look like an ideal solution to me. >>>>> >>>>> BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 error >>>>> handler only once and never replace it. All the rest of the >>>>> push_handler/pop_handler logic is now located in Java code (see >>>>> XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I believe >>>>> that we should somehow share this machinery with the 2D code to avoid >>>>> this sort of problems. Though I'm not sure if this will eliminate this >>>>> exact issue. >>>>> >>>>> >>>>> 2D/AWT folks: any other thoughts? >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>>> >>>>> On 12/29/2012 17:44, Anton Litvinov wrote: >>>>>> Hello, >>>>>> >>>>>> Please review the following fix for a bug. >>>>>> >>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >>>>>> https://jbs.oracle.com/bugs/browse/JDK-8005607 >>>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >>>>>> >>>>>> The bug consists in a crash which is caused by a stack overflow for >>>>>> the reason of an infinite recursion in AWT native function >>>>>> J2DXErrHandler() under certain circumstances on 32-bit Linux OS. The >>>>>> fix is based on introduction of the logic, which detects indirect >>>>>> recursive calls to J2DXErrHandler() by means of a simple counter, to >>>>>> J2DXErrHandler() native function. Such a solution requires minimum >>>>>> code changes, does not alter the handler's code significantly and >>>>>> eliminates this bug. >>>>>> >>>>>> Adding 2d-dev at openjdk.java.net e-mail alias to the list of recipients >>>>>> of this letter, because the edited function's name is related to Java >>>>>> 2D area of JDK, despite of the fact that the edited file is >>>>>> located in >>>>>> AWT directory. >>>>>> >>>>>> Thank you, >>>>>> Anton From anton.litvinov at oracle.com Thu Jan 31 15:42:23 2013 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Thu, 31 Jan 2013 19:42:23 +0400 Subject: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux In-Reply-To: <510A6A54.1080705@oracle.com> References: <50DEF3AC.2070600@oracle.com> <50ED9609.1070002@oracle.com> <50EE1CEB.5080500@oracle.com> <50EFED12.6070700@oracle.com> <50EFFB4F.4090405@oracle.com> <510946F7.3090709@oracle.com> <510A6A54.1080705@oracle.com> Message-ID: <510A90DF.2060501@oracle.com> Hello Anthony, Thank you for the review and these remarks. Surely, the comment will be added. I think that all JNI code related to XShmAttach can be definitely transferred into a separate dedicated function, which will be declared in "src/solaris/native/sun/awt/awt_GraphicsEnv.h" file. I will try to wrap all JNU calls connected with XErrorHandler into the particular "WITH_XERROR_HANDLER", "RESTORE_XERROR_HANDLER" functions or macros. Thank you, Anton On 1/31/2013 4:57 PM, Anthony Petrov wrote: > Hi Anton, > > A couple comments: > > 1. src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java >> 80 private static void init(long display) { > > This method is private and isn't called from anywhere in this class > itself. This looks confusing. Please add a comment stating that this > method is invoked from native code, and from where exactly. > > > 2. Interesting that we use this machinery to call the XShmAttach() > from native code twice, and the code looks quite similar in each case. > Would it be possible to extract the common code in a separate function > (a-la BOOL TryXShmAttach(...)) to avoid code replication? There are > other usages as well, so we could also introduce a macro (such as the > old EXEC_WITH_XERROR_HANDLER but now with other arguments) that would > minimize all the JNU_ calls required to use this machinery. > > > Otherwise the fix looks great. > > -- > best regards, > Anthony > > On 1/30/2013 20:14, Anton Litvinov wrote: >> Hello Anthony, >> >> Could you, please, review a second version of the fix, which is based >> on an idea of reusing the existing AWT native global error handler >> from Java 2D native code. >> >> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.01 >> >> The fix consists of the following parts: >> >> 1. Migration of all X error handling code from XToolkit to a new >> XErrorHandlerUtil class for resolution of interdependency between >> a static initialization block of XToolkit and a block initializing >> java.awt.GraphicsEnvironment singleton. Such dependency is created >> by new calls to XToolkit static methods from >> "src/solaris/native/sun/awt/awt_GraphicsEnv.c", >> "src/solaris/native/sun/java2d/x11/X11SurfaceData.c" files. >> 2. Substitution of XToolkit.WITH_XERROR_HANDLER, >> XToolkit.RESTORE_XERROR_HANDLER ... for corresponding methods, >> fields of XErrorHandlerUtil class in all places of JDK source >> code, where they were used. >> 3. Substitution of all found native X error handlers which are set in >> native code (awt_GraphicsEnv.c, X11SurfaceData.c, >> GLXSurfaceData.c) for new synthetic Java error handlers. >> 4. Removal of X error handling code used by the native error handlers >> from "solaris/native/sun/awt/awt_util.c" >> "solaris/native/sun/awt/awt_util.h" files. >> >> Thank you, >> Anton >> >> On 1/11/2013 3:45 PM, Anthony Petrov wrote: >>> I'm not Jim, but as I indicated earlier my opinion is that the >>> easiest way to fix this is to install the existing J2DXErrHandler() >>> only once. That is, it is the second option listed by you. Of >>> course, the J2DXErrHandler needs to be updated as well to detect >>> whether 2D code wants to use it at the moment or it must simply >>> delegate to the previous handler (i.e. where the code currently >>> installs/uninstalls the handler, it must instead set a global >>> boolean flag or something.) >>> >>> While the first option (reusing the existing AWT machinery) is an >>> interesting idea in general, I think it is complex and would require >>> too much additional testing and bring an unjustified risk to the >>> solution for such a basic problem. >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 1/11/2013 14:44, Anton Litvinov wrote: >>>> Hello Jim, >>>> >>>> Thank you very much for the review and provision of a new idea of a >>>> solution. Elimination of the logic, which sets/unsets >>>> J2DXErrHandler() for each call "XShmAttach(awt_display, &shminfo))" >>>> should effectively resolve the issue, but only in case if all other >>>> native error handlers, which were set by the system function >>>> "XSetErrorHandler()" in JDK or in any external library, observe the >>>> rule of relaying of all events, which are not relative to them, to >>>> the previously saved error handlers. Otherwise an error generated >>>> during "XShmAttach" function call will not be handled by >>>> J2DXErrHandler(). >>>> >>>> Could you answer the following question. By setting >>>> J2DXErrHandler() only once and forever do you mean usage of AWT >>>> global event handler "static int ToolkitErrorHandler(Display * dpy, >>>> XErrorEvent * event)" from >>>> "src/solaris/native/sun/xawt/XlibWrapper.c" with Java synthetic >>>> handlers or creation of another global native error handler with >>>> J2DXErrHandler as native synthetic handler? >>>> >>>> Thank you, >>>> Anton >>>> >>>> On 1/10/2013 5:44 AM, Jim Graham wrote: >>>>> I think I'd rather see some way to prevent double-adding the >>>>> handler in the first place as well. Since it is only ever used on >>>>> errors I also think it is OK to set it once and leave it there >>>>> forever... >>>>> >>>>> ...jim >>>>> >>>>> On 1/9/13 8:08 AM, Anthony Petrov wrote: >>>>>> Hi Anton et al., >>>>>> >>>>>> If I read the description of the bug correctly, specifically this >>>>>> part: >>>>>> >>>>>>> The problem occurs, if another thread (for example, GTK thread) is >>>>>>> doing the same sort of thing concurrently. This can lead to the >>>>>>> following situation. >>>>>>> JVM thread: Sets J2DXErrHandler(), saves ANY_PREVIOUS_HANDLER as >>>>>>> previous GTK thread: Sets some GTK_HANDLER, saves >>>>>>> J2DXErrHandler() as previous JVM thread: Restores >>>>>>> ANY_PREVIOUS_HANDLER GTK thread: Restores J2DXErrHandler() >>>>>>> JVM >>>>>>> thread: Sets J2DXErrHandler(), saves J2DXErrHandler() as previous >>>>>> >>>>>> It is obvious that at this final step 2D is in an inconsistent >>>>>> state. We >>>>>> don't expect to replace our own error handler (and it shouldn't have >>>>>> been there in the first place). >>>>>> >>>>>> I realize that the fix you propose works around this problem. But >>>>>> this >>>>>> doesn't look like an ideal solution to me. >>>>>> >>>>>> BTW, IIRC, in JDK7 (and 6?) we decided to set the actual X11 error >>>>>> handler only once and never replace it. All the rest of the >>>>>> push_handler/pop_handler logic is now located in Java code (see >>>>>> XToolkit.SAVED_ERROR_HANDLER() and the surrounding logic). I believe >>>>>> that we should somehow share this machinery with the 2D code to >>>>>> avoid >>>>>> this sort of problems. Though I'm not sure if this will eliminate >>>>>> this >>>>>> exact issue. >>>>>> >>>>>> >>>>>> 2D/AWT folks: any other thoughts? >>>>>> >>>>>> -- >>>>>> best regards, >>>>>> Anthony >>>>>> >>>>>> On 12/29/2012 17:44, Anton Litvinov wrote: >>>>>>> Hello, >>>>>>> >>>>>>> Please review the following fix for a bug. >>>>>>> >>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005607 >>>>>>> https://jbs.oracle.com/bugs/browse/JDK-8005607 >>>>>>> Webrev: http://cr.openjdk.java.net/~alitvinov/8005607/webrev.00 >>>>>>> >>>>>>> The bug consists in a crash which is caused by a stack overflow for >>>>>>> the reason of an infinite recursion in AWT native function >>>>>>> J2DXErrHandler() under certain circumstances on 32-bit Linux OS. >>>>>>> The >>>>>>> fix is based on introduction of the logic, which detects indirect >>>>>>> recursive calls to J2DXErrHandler() by means of a simple >>>>>>> counter, to >>>>>>> J2DXErrHandler() native function. Such a solution requires minimum >>>>>>> code changes, does not alter the handler's code significantly and >>>>>>> eliminates this bug. >>>>>>> >>>>>>> Adding 2d-dev at openjdk.java.net e-mail alias to the list of >>>>>>> recipients >>>>>>> of this letter, because the edited function's name is related to >>>>>>> Java >>>>>>> 2D area of JDK, despite of the fact that the edited file is >>>>>>> located in >>>>>>> AWT directory. >>>>>>> >>>>>>> Thank you, >>>>>>> Anton From Sergey.Bylokhov at oracle.com Thu Jan 31 16:22:06 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 31 Jan 2013 20:22:06 +0400 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException In-Reply-To: <50EEDF6B.2000003@oracle.com> References: <50C734F5.8040801@oracle.com> <50E74EC4.9020302@oracle.com> <50E87D4B.1060109@oracle.com> <50ED9DC0.3080509@oracle.com> <50EDA3D6.9080308@oracle.com> <50EDA623.1010106@oracle.com> <50EDA757.9030504@oracle.com> <50EEDF6B.2000003@oracle.com> Message-ID: <510A9A2E.8080906@oracle.com> Hi, Phil. Can I consider you as the second reviewer? 10.01.2013 19:34, Sergey Bylokhov wrote: > Hi, Phil. > The test updated according to your notes. > > http://cr.openjdk.java.net/~serb/8004821/webrev.02 > > 09.01.2013 21:22, Phil Race wrote: >> I don't know where its phrased that way round but the FAQ >> at http://openjdk.java.net/faq/ >> >> actually says that files should have GPLv2 *except* class libraries >> which have GPL v2 + CP. >> >> So *not* having the classpath is actually the default/norm. >> Its just that we mostly work with the class libs so thing its >> the other way around .. >> >> -phil >> >> On 1/9/13 9:17 AM, Sergey Bylokhov wrote: >>> Hi, Phil. >>> 09.01.2013 21:07, Phil Race wrote: >>>> Are you implicitly answering Jim's first question with a yes ? >>> Yes. Testcase was updated to verify this. >>>> >>>> If so then the only issue is that you used the wrong GPL header >>>> in the test case. Tests should never include the classpath exception. >>> I didn't know this. I found ~400 of tests contain this text. Where I >>> can find this rule? >>> Thanks. >>>> >>>> -phil. >>>> >>>> On 1/9/13 8:41 AM, Sergey Bylokhov wrote: >>>>> Hi, Jim. >>>>> Please review updated version of the fix. >>>>> http://cr.openjdk.java.net/~serb/8004821/webrev.01 >>>>> >>>>> 05.01.2013 23:21, Jim Graham wrote: >>>>>> Hi Sergey, >>>>>> >>>>>> Does this work OK with 1 point in the array as well? >>>>>> >>>>>> Also, it couldn't hurt to call fillPolygon and drawPolyline as >>>>>> well in the test case just to round out our testing... >>>>>> >>>>>> ...jim >>>>>> >>>>>> On 1/4/2013 1:51 PM, Sergey Bylokhov wrote: >>>>>>> Hello, 2d team. >>>>>>> Does anybody have a chance to review this small fix? >>>>>>> >>>>>>> 11.12.2012 17:28, Sergey Bylokhov wrote: >>>>>>>> Hello, >>>>>>>> Please review the fix for jdk 8. >>>>>>>> PixelToShapeConverter.makePoly() should not try to close path >>>>>>>> in case >>>>>>>> of the empty arrays of points. >>>>>>>> >>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821 >>>>>>>> Webrev can be found at: >>>>>>>> http://cr.openjdk.java.net/~serb/8004821/webrev.00 >>>>>>>> >>>>>>> >>>>>>> >>>>> >>>>> >>>> >>> >>> >> > > -- Best regards, Sergey. From philip.race at oracle.com Thu Jan 31 19:49:23 2013 From: philip.race at oracle.com (Phil Race) Date: Thu, 31 Jan 2013 11:49:23 -0800 Subject: [OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException In-Reply-To: <510A9A2E.8080906@oracle.com> References: <50C734F5.8040801@oracle.com> <50E74EC4.9020302@oracle.com> <50E87D4B.1060109@oracle.com> <50ED9DC0.3080509@oracle.com> <50EDA3D6.9080308@oracle.com> <50EDA623.1010106@oracle.com> <50EDA757.9030504@oracle.com> <50EEDF6B.2000003@oracle.com> <510A9A2E.8080906@oracle.com> Message-ID: <510ACAC3.6020101@oracle.com> Yes. -phil. On 1/31/2013 8:22 AM, Sergey Bylokhov wrote: > Hi, Phil. > Can I consider you as the second reviewer? > > 10.01.2013 19:34, Sergey Bylokhov wrote: >> Hi, Phil. >> The test updated according to your notes. >> >> http://cr.openjdk.java.net/~serb/8004821/webrev.02 >> >> 09.01.2013 21:22, Phil Race wrote: >>> I don't know where its phrased that way round but the FAQ >>> at http://openjdk.java.net/faq/ >>> >>> actually says that files should have GPLv2 *except* class libraries >>> which have GPL v2 + CP. >>> >>> So *not* having the classpath is actually the default/norm. >>> Its just that we mostly work with the class libs so thing its >>> the other way around .. >>> >>> -phil >>> >>> On 1/9/13 9:17 AM, Sergey Bylokhov wrote: >>>> Hi, Phil. >>>> 09.01.2013 21:07, Phil Race wrote: >>>>> Are you implicitly answering Jim's first question with a yes ? >>>> Yes. Testcase was updated to verify this. >>>>> >>>>> If so then the only issue is that you used the wrong GPL header >>>>> in the test case. Tests should never include the classpath exception. >>>> I didn't know this. I found ~400 of tests contain this text. Where >>>> I can find this rule? >>>> Thanks. >>>>> >>>>> -phil. >>>>> >>>>> On 1/9/13 8:41 AM, Sergey Bylokhov wrote: >>>>>> Hi, Jim. >>>>>> Please review updated version of the fix. >>>>>> http://cr.openjdk.java.net/~serb/8004821/webrev.01 >>>>>> >>>>>> 05.01.2013 23:21, Jim Graham wrote: >>>>>>> Hi Sergey, >>>>>>> >>>>>>> Does this work OK with 1 point in the array as well? >>>>>>> >>>>>>> Also, it couldn't hurt to call fillPolygon and drawPolyline as >>>>>>> well in the test case just to round out our testing... >>>>>>> >>>>>>> ...jim >>>>>>> >>>>>>> On 1/4/2013 1:51 PM, Sergey Bylokhov wrote: >>>>>>>> Hello, 2d team. >>>>>>>> Does anybody have a chance to review this small fix? >>>>>>>> >>>>>>>> 11.12.2012 17:28, Sergey Bylokhov wrote: >>>>>>>>> Hello, >>>>>>>>> Please review the fix for jdk 8. >>>>>>>>> PixelToShapeConverter.makePoly() should not try to close path >>>>>>>>> in case >>>>>>>>> of the empty arrays of points. >>>>>>>>> >>>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821 >>>>>>>>> Webrev can be found at: >>>>>>>>> http://cr.openjdk.java.net/~serb/8004821/webrev.00 >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>> >>>>>> >>>>> >>>> >>>> >>> >> >> > > From philip.race at oracle.com Thu Jan 31 20:05:34 2013 From: philip.race at oracle.com (Phil Race) Date: Thu, 31 Jan 2013 12:05:34 -0800 Subject: [OpenJDK 2D-Dev] [8] request for review: 8004801: The image of BufferedImage.TYPE_INT_ARGB is blank. In-Reply-To: <510A4D66.6020209@oracle.com> References: <510A4D66.6020209@oracle.com> Message-ID: <510ACE8E.8060309@oracle.com> Approved, although I'm a bit surprised this didn't surface a long time ago. -phil. On 1/31/2013 2:54 AM, Andrew Brygin wrote: > Hello Jennifer and Phil, > > could you please review a fix for CR 8004801? > > Bug: http://bugs.sun.com/view_bug.do?bug_id=8004801 > Webrev: http://cr.openjdk.java.net/~bae/8004801/8/webrev.00/ > > The test uses reverse lookup with single lookup table. This sort of > operation should change only color components of processed images, > but alpha channel should be unchanged. > > However, due to a mistake in color order detection, the reverse > lookup is applied to the alpha channel, that results in completely > transparent destination image. > > This mistake in color order is caused by the platform-depended > implementation of awt_getBIColorOrder() routine: for all unix > system, this routine is implemented in assumption that system is > bigendian. > > Suggested solution is to move the awt_getBIColorOrder() to shared code, > and re-write taking system endianness into account. > Supplied regression test demonstrates the problem. > > Please take a look. > > Thanks, > Andrew.