[OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed Jan 9 16:41:36 UTC 2013


Hi, Jim.
Please review updated version of the fix.
http://cr.openjdk.java.net/~serb/8004821/webrev.01

05.01.2013 23:21, Jim Graham wrote:
> Hi Sergey,
>
> Does this work OK with 1 point in the array as well?
>
> Also, it couldn't hurt to call fillPolygon and drawPolyline as well in 
> the test case just to round out our testing...
>
> ...jim
>
> On 1/4/2013 1:51 PM, Sergey Bylokhov wrote:
>> Hello, 2d team.
>> Does anybody have a chance to review this small fix?
>>
>> 11.12.2012 17:28, Sergey Bylokhov wrote:
>>> Hello,
>>> Please review the fix for jdk 8.
>>> PixelToShapeConverter.makePoly() should not try to close path in case
>>> of the empty arrays of points.
>>>
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821
>>> Webrev can be found at:
>>> http://cr.openjdk.java.net/~serb/8004821/webrev.00
>>>
>>
>>


-- 
Best regards, Sergey.




More information about the 2d-dev mailing list