[OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException

[Sergey Bylokhov]

Hi, Phil.
The test updated according to your notes.

http://cr.openjdk.java.net/~serb/8004821/webrev.02

09.01.2013 21:22, Phil Race wrote:
> I don't know where its phrased that way round but the FAQ
> at http://openjdk.java.net/faq/
>
> actually says that files should have GPLv2 *except* class libraries
> which have GPL v2 + CP.
>
> So *not* having the classpath is actually the default/norm.
> Its just that we mostly work with the class libs so thing its
> the other way around ..
>
> -phil
>
> On 1/9/13 9:17 AM, Sergey Bylokhov wrote:
>> Hi, Phil.
>> 09.01.2013 21:07, Phil Race wrote:
>>> Are you implicitly answering Jim's first question with a yes ?
>> Yes. Testcase was updated to verify this.
>>>
>>> If so then the only issue is that you used the wrong GPL header
>>> in the test case. Tests should never include the classpath exception.
>> I didn't know this. I found ~400 of tests contain this text. Where I 
>> can find this rule?
>> Thanks.
>>>
>>> -phil.
>>>
>>> On 1/9/13 8:41 AM, Sergey Bylokhov wrote:
>>>> Hi, Jim.
>>>> Please review updated version of the fix.
>>>> http://cr.openjdk.java.net/~serb/8004821/webrev.01
>>>>
>>>> 05.01.2013 23:21, Jim Graham wrote:
>>>>> Hi Sergey,
>>>>>
>>>>> Does this work OK with 1 point in the array as well?
>>>>>
>>>>> Also, it couldn't hurt to call fillPolygon and drawPolyline as 
>>>>> well in the test case just to round out our testing...
>>>>>
>>>>> ...jim
>>>>>
>>>>> On 1/4/2013 1:51 PM, Sergey Bylokhov wrote:
>>>>>> Hello, 2d team.
>>>>>> Does anybody have a chance to review this small fix?
>>>>>>
>>>>>> 11.12.2012 17:28, Sergey Bylokhov wrote:
>>>>>>> Hello,
>>>>>>> Please review the fix for jdk 8.
>>>>>>> PixelToShapeConverter.makePoly() should not try to close path in 
>>>>>>> case
>>>>>>> of the empty arrays of points.
>>>>>>>
>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004821
>>>>>>> Webrev can be found at:
>>>>>>> http://cr.openjdk.java.net/~serb/8004821/webrev.00
>>>>>>>
>>>>>>
>>>>>>
>>>>
>>>>
>>>
>>
>>
>


-- 
Best regards, Sergey.