[OpenJDK 2D-Dev] [8] Request for review: 7190349 and 8013569.

[Sergey Bylokhov]

Hi, Phil.
On 03.07.2013 3:29, Phil Race wrote:
> This is fine with me, although we have an odd mixture of JRS and non 
> JRS functions here and
> as you and others have asked or implied, I am not sure why we need any 
> JRS
> functions in this part of the code. What do they do that we can't find 
> from
> public API ? However doing more here is for another day.
I guess we can replace them, but it should be done carefully.
>> fDevTx = CGAffineTransformInvert(invDevTx);
>
> Maybe you explained this before, but why don't we have the dev tx 
> anyway? Seems odd to recreate it from an inverse tx.
Since we need both devtx and invtx and we already have invtx, i don't 
see a problem to get devtx from it. Note that when we create invDevTx in 
the CStrike.java we handle NoninvertibleTransformException so we can 
invert it safely in the native code.

-- 
Best regards, Sergey.