[OpenJDK 2D-Dev] [8] request for review: 8020983: OutOfMemoryError caused by non garbage collected JPEGImageWriter Instances

[Andrew Brygin]

Hello,

  please take a look to updated fix:

  http://cr.openjdk.java.net/~bae/8020983/8/webrev.01/

  The name 'stream' is now eliminated.

  I have verified that the change does not trigger any existing
  regression tests for imageio jpeg.

Thanks,
Andrew

On 7/29/2013 7:21 PM, Mario Torre wrote:
> On Mon, 2013-07-29 at 19:05 +0400, Andrew Brygin wrote:
>> Hi Mario,
>>
>>    thanks for the comments!
>>
>>    I agree that 'stream' and 'streamRef' are not appropriate names now,
>>    because these entities point to instances of  writer/reader.
>>
>>    However, these entities use the writer/reader only as a holder of
>>    certain set of I/O routines, so probably names for these entities
>>    should reflect their I/O nature.
>>
>>    Would 'ioRef' and 'input'/'output' sound better than 'stream'?
> Hi Andrew,
>
> Those seems better defaults, yes.
>
> At first I got confused with "stream" because the struct used to hold
> the Input/Output stream for real. I guess what really bothers me though
> is the comment:
>
> jweak streamRef; // ImageInputStream or ImageOutputStream
>                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Which is misleading now :) so thanks for addressing this!
>
> Cheers,
> Mario
>
>