[OpenJDK 2D-Dev] <AWT Dev> RFR(XS): 7196866: CTW fails on Solaris

[Phil Race]

Morris,

I traced this review back to hotspot-compiler-dev
Thanks to Vladimir and Christian for the ponter to redirect but
this should really go to 2d-dev not awt-dev.
Xrender is the 2D pipeline for accelerated rendering on recent Xservers.
Also it I think it should be pushed via the 2D forest after review,
whereas it appears your webrev is against the hotspot forest.
If the display is NULL we should not enter Xrender but operate in
headless mode. So I'd like to take a closer look at this.
Where did you test this ? Solaris 10 doesn't trigger xrender ?
Did you actually use Solaris 11 on SPARC as the client *and* Xserver ?
Is there a regression test ?

-phil.

On 5/15/13 2:57 PM, Christian Thalinger wrote:
> Looks good.  Nit:  why is there an empty line?
>
> +    jlong fmt8;
> +
> +    jlong fmt32;
>
> -- Chris
>
> On May 15, 2013, at 1:21 PM, Morris Meyer <morris.meyer at oracle.com> wrote:
>
>> Folks,
>>
>> Could I get a review for these two small changes in src/solaris/native.  This is to fix the nightly CTW testing crashes on Solaris caused by a library SEGV internal to X11 that occurs during class initialization when the display is NULL.
>>
>> I've tested this patch on SfBay with JPRT and with the CTW tests on Solaris x86 and Sparc.
>>
>> Thanks much,
>>
>>         --morris
>>
>> JBS - https://jbs.oracle.com/bugs/browse/JDK-7196866
>> WEBREV - http://cr.openjdk.java.net/~morris/7196866