[OpenJDK 2D-Dev] <2D Dev> [8] Review Request: JDK-8025235 [javadoc] fix some errors in 2D

[Phil Race]

Approved.

-phil.

On 11/19/2013 7:23 AM, Dmitry Ginzburg wrote:
> Hi guys,
>
> Сould you please approve this 4-th version of doclint errors cleanup 
> change in 2d code: 
> http://cr.openjdk.java.net/~yan/jdk-8025235/webrev.03/ ?
> The changes are against 2d team repository of jdk8.
>
> The patch contains only simple markup fixes; no changes/fixes in 
> documentation text; the specification itself wasn't changed.
>
> Thanks,
> -Dmitry
>
> 13.11.2013 19:07, Dmitry Ginzburg wrote:
>> Hi Phil, Guys ,
>>
>>
>> This one is stuck waiting for review for quite long time.
>> Please review so we can push this change.
>>
>> Thanks,
>> -Dmitry
>>
>> 08.11.2013 12:40, Dmitry Ginzburg wrote:
>>> Colleagues,
>>>
>>> friendly reminder.
>>> Back in early October I did all proposed changes; could you please
>>> review this third version of doclint fix?
>>>
>>> Thanks,
>>> -Dmitry
>>>
>>> 30.10.2013 20:38, Dmitry Ginzburg wrote:
>>>> Hi guys
>>>> I haven't got any review from you on this issue. Can you please review it?
>>>> For some issue, my e-mail have changed todmitry.x.ginzburg at oracle.com
>>>> Thanks, Dmitry
>>>> *
>>>> Dmitry Ginzburg*  dmitry.ginzburg at oracle.com    <mailto:2d-dev%40openjdk.java.net?Subject=%5BOpenJDK%202D-Dev%5D%20%3C2D%20Dev%3E%20%5B8%5D%20Review%20Request%3A%20JDK-8025235%0A%20%5Bjavadoc%5D%20fix%20some%20errors%20in%202D&In-Reply-To=524EE4DB.8010602%40oracle.com>
>>>> /Tue Oct 15 06:02:58 PDT 2013/
>>>>
>>>> See new webrev:http://cr.openjdk.java.net/~yan/jdk-8025235/webrev.02/  <http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.02/>  
>>>> <http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.02/>
>>>> Some changes are deleted, because they're fixed by someone but me
>>>>
>>>> 04.10.2013 19:55, Phil Race wrote:
>>>> >/  Hi,
>>>> />/
>>>> />/  A few places you used {@code that is not code} : ie PageAttributes for
>>>> />/  the &
>>>> />/  and Line2D.Float() constructor and  in MultipleMaster are the ones I
>>>> />/  spotted
>>>> />/  probably aren't appropriate as they aren't code, and the {@code ..}
>>>> />/  will use
>>>> />/  a fixed width font. So one char will be in a different font.
>>>> />/  As I suggested in PageAttributes just use "and", there's no reason it
>>>> />/  has to
>>>> />/  be an ampersand.
>>>> />/
>>>> />/  -phil.
>>>> />/
>>>> />/  On 10/4/2013 5:59 AM, Dmitry Ginzburg wrote:
>>>> />>/  Hi, Phil
>>>> />>/
>>>> />>/  I renewed webrev against your issues:
>>>> />>/  http://cr.openjdk.java.net/~yan/jdk-8025235/webrev.01/  <http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.01/>  
>>>> />>/  <http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.01/>
>>>> />>/
>>>> />>/  Thanks,
>>>> />>/  -Dmitry
>>>> />>/
>>>> />>/  03.10.2013 08:41, Phil Race wrote:
>>>> />>>/  1. This webrev is not against the 2D forest. Please re-generate
>>>> />>>/  against 2D.
>>>> />>>/
>>>> />>>/  2.
>>>> />>>/  /local/work/jdk8/jdk8/jdk/src/share/classes/java/awt/GraphicsConfiguration.java:84:
>>>> />>>/  error: malformed HTML
>>>> />>>/     When you have < & > chars in code the preferred solution uses
>>>> />>>/  {@code .. }  like this :
>>>> />>>/  http://cr.openjdk.java.net/~prr/8022175/src/share/classes/javax/print/ServiceUI.java.sdiff.html  <http://cr.openjdk.java.net/%7Eprr/8022175/src/share/classes/javax/print/ServiceUI.java.sdiff.html>  
>>>> />>>/
>>>> />>>/
>>>> />>>/  3. Same as above for GraphicsDevice
>>>> />>>/
>>>> />>>/  4. Same as above for MediaTracker (it'll fix all 3 issues)
>>>> />>>/
>>>> />>>/  5. I think we should change all 12 or so of these to the word "and"
>>>> />>>/
>>>> />>>/  6. Rectangle : same as 2
>>>> />>>/
>>>> />>>/  7. LineBreakMeasurer : same again in all locations
>>>> />>>/
>>>> />>>/  8. {@code .. } should fix this too
>>>> />>>/
>>>> />>>/  9. LIne2D 626: {@code true} would be better here too
>>>> />>>/
>>>> />>>/  10. PrinterJob: {@code .. } again
>>>> />>>/
>>>> />>>/  Make sure you verify by re-running doclint on the fixed repo.
>>>> />>>/
>>>> />>>/  That's all.
>>>> />>>/
>>>> />>>/  -phil.
>>>> />>>/
>>>> />>>/  On 9/26/13 7:21 AM, Dmitry Ginzburg wrote:
>>>> />>>>/  Hello, 2D Team.
>>>> />>>>/
>>>> />>>>/  Please review the fix for the following issue:
>>>> />>>>/  https://bugs.openjdk.java.net/browse/JDK-8025235
>>>> />>>>/  The fix is available at:
>>>> />>>>/  http://cr.openjdk.java.net/~yan/jdk-8025235/webrev.00/  <http://cr.openjdk.java.net/%7Eyan/jdk-8025235/webrev.00/>
>>>> />>>>/
>>>> />>>>/  This is the fix for javadoc errors, on which doclint was showing
>>>> />>>>/  some issues.
>>>> />>>>/
>>>> />>>>/  The patch contains only simple markup fixes; no changes/fixes in
>>>> />>>>/  documentation text; the specification itself wasn't changed.
>>>> />>>>/
>>>> />>>>/  Thanks,
>>>> />>>>/  -Dmitry
>>>> />>>/
>>>> />>/
>>>> />>/
>>>> />>/  --
>>>> />>/  Dmitry Ginzburg, FXSQE team member
>>>> />/
>>>> /
>>>
>>
>