[OpenJDK 2D-Dev] [2d dev] [8] Review request for JDK-8028272 : Tidy warnings cleanup for javax.print package
Sergey Lugovoy
sergey.lugovoy at oracle.com
Thu Nov 21 12:54:01 UTC 2013
Hi Joe.
In most cases the author used this stray "<p>" as a line break.
A line break is necessary indeed but if it is followed by a block
element, it is considered erroneous by tidy.
So adding <br> does, in fact, better correspond to the author original
idea.
On Wednesday, November 20, 2013 04:46:59 PM Joe Darcy wrote:
> Hello,
>
> I'm not an HTML expert, but it seems preferable to me to just remove an
> unnecessary "<p>" tag rather than replacing it with "<br/>".
>
> Is there a reason to prefer "<br/>"?
>
> Otherwise the changes look fine.
>
> Thanks,
>
> -Joe
>
> On 11/20/2013 1:47 AM, Sergey Lugovoy wrote:
> > Hi all,
> > please review the fix.
> > bug: https://bugs.openjdk.java.net/browse/JDK-8028272
> > webrev : http://cr.openjdk.java.net/~yan/8028272/webrev.00/
> >
> > This patch cleanup tidy warnings for generated html documentation for
> > javax.print package, and do not affect the appearance of the
> > documentation.
> > The patch is created against jdk8/tl team repository according to
> > requirements of this cleanup project.
> >
> >
> > Best regards,
> > Serge V. Lugovoy
More information about the 2d-dev
mailing list