[OpenJDK 2D-Dev] <2D Dev> [8] Review Request: JDK-8025235 [javadoc] fix some errors in 2D
Phil Race
philip.race at oracle.com
Thu Oct 3 04:41:05 UTC 2013
1. This webrev is not against the 2D forest. Please re-generate against 2D.
2.
/local/work/jdk8/jdk8/jdk/src/share/classes/java/awt/GraphicsConfiguration.java:84:
error: malformed HTML
When you have < & > chars in code the preferred solution uses {@code
.. } like this :
http://cr.openjdk.java.net/~prr/8022175/src/share/classes/javax/print/ServiceUI.java.sdiff.html
3. Same as above for GraphicsDevice
4. Same as above for MediaTracker (it'll fix all 3 issues)
5. I think we should change all 12 or so of these to the word "and"
6. Rectangle : same as 2
7. LineBreakMeasurer : same again in all locations
8. {@code .. } should fix this too
9. LIne2D 626: {@code true} would be better here too
10. PrinterJob: {@code .. } again
Make sure you verify by re-running doclint on the fixed repo.
That's all.
-phil.
On 9/26/13 7:21 AM, Dmitry Ginzburg wrote:
> Hello, 2D Team.
>
> Please review the fix for the following issue:
> https://bugs.openjdk.java.net/browse/JDK-8025235
> The fix is available at:
> http://cr.openjdk.java.net/~yan/jdk-8025235/webrev.00/
>
> This is the fix for javadoc errors, on which doclint was showing some
> issues.
>
> The patch contains only simple markup fixes; no changes/fixes in
> documentation text; the specification itself wasn't changed.
>
> Thanks,
> -Dmitry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20131002/cbd03724/attachment.html>
More information about the 2d-dev
mailing list