[OpenJDK 2D-Dev] request for review: JDK-7082809 : xrender artifacts caused by different interpretation of SRC operator

Phil Race philip.race at oracle.com
Tue Oct 22 22:40:26 UTC 2013


This looks good to me. It fixes the test in
https://bugs.openjdk.java.net/browse/JDK-8023098

I'm going to commit under that bug ID and close 7082809 as a duplicate.
Note that 7082809 points to another bug 7122456 which has a test
case and this fixes that too!

There are also numerous SQE tests that are listed as failing.

I did have to make a couple of minor changes for
the patch to apply and build because I'd already applied
the fix for 8023483.

I also had to clean up tabs and trailing whitespace before it could be 
committed.

-phil.

On 10/18/2013 05:54 AM, Andrew Brygin wrote:
> Hi Clemens,
>
>  from my perspective, the fix looks fine.
>
> Thanks,
> Andrew
>
>
> On 10/18/2013 2:19 PM, Clemens Eisserer wrote:
>> Hi Andrew,
>>
>>>   a copyright header is missed in the new file XRSolidSrcPict.java.
>>>   Could you please add it?
>> Done.
>> Please find the updated webrev at:
>> http://cr.openjdk.java.net/~ceisserer/7082809/webrev.06/
>>
>> Thanks, Clemens
>




More information about the 2d-dev mailing list