[OpenJDK 2D-Dev] Review request for http://cr.openjdk.java.net/~ceisserer/fix10/

Johnny Chen jia-hong.chen at oracle.com
Thu Sep 26 23:02:14 UTC 2013


Looks good!

Thanks,
Johnny Chen

On Sep 26, 2013, at 12:04 PM, Clemens Eisserer <linuxhippy at gmail.com> wrote:

> Hi Phil,
> 
>> the webrev and test need a little clean-up : adding the @test and @bug tag +
>> GPL
> 
> Please find a corrected version at
> http://cr.openjdk.java.net/~ceisserer/8024895/webrev.01/
> along with a (hopefully) jtreg conformant testcase at
> http://cr.openjdk.java.net/~ceisserer/8024895/EABlitTest.java
> 
>> Other than that the fix is fine although without looking at bit more broadly
>> I'm unsure how this cache works in a MT scenario.
> 
> It is guarded by the AWT-lock, but you're right - it is not benefitial
> (but doesn't hurt either) under some circumstances.
> 
> Thanks, Clemens

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20130926/6e178923/attachment.html>


More information about the 2d-dev mailing list