[OpenJDK 2D-Dev] [9] Review Request: 8042199 The build of J2DBench via makefile is broken after the JDK-8005402

[Sergey Bylokhov]

Hello, Phil.
jdk 9 now supports "-target 1.6+/-source 1.6+" options only. Looks like 
we should use this minimum version too.
If you have no objections I'll prepare the new version of the fix

On 14.05.2014 21:09, Phil Race wrote:
> Hmm .. the thing here is that I know that Jim was very keen that this 
> benchmark always be runnable on JDK 1.2
> Deleting the comment to that effect and setting source level to 1.5 
> goes against this.
> What is the rationale, and why can't it be reverted to be able to 
> build on 1.4 and run
> on 1.2 ? If it uses JDK 1.5 language features, just back them out. If 
> it uses JDK 1.5
> APIs then maybe Jim had to handle something similar and has an idea ?
>
> -phil.
>
> On 4/30/2014 4:13 AM, Andrew Brygin wrote:
>> Hello Sergey,
>>
>>  the change looks fine to me.
>>
>> Thanks,
>> Andrew
>>
>> On 4/30/2014 3:12 PM, Sergey Bylokhov wrote:
>>> Hello.
>>> Please review the small fix for jdk 9.
>>> Makefile and README were fixed.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8042199
>>> Webrev can be found at: 
>>> http://cr.openjdk.java.net/~serb/8042199/webrev.00
>>>
>>> -- 
>>> Best regards, Sergey.
>>
>


-- 
Best regards, Sergey.