[OpenJDK 2D-Dev] <AWT Dev> Review request for 8034218: AIX: Provide a better fontconfig.properties file

Wed Aug 27 09:28:45 UTC 2014

Hi Jonathan,

any progress on this change?

With the changes proposed by me in my last mail below I'm fine with
the change (and I'm a reviewer now:)

Thank you and best regards,
Volker

On Thu, Jun 5, 2014 at 8:45 PM, Volker Simonis <volker.simonis at gmail.com> wrote:
> Hi Jonathan,
>
> sorry for the long delay. I think the change look good now.
>
> Can you please slightly update the comment in the 31-33 to something like:
>
> # This file references the standard Latin Type1 fonts from the AIX package
> # X11.fnt.iso_T1 and the Unicode TrueType fonts from X11.fnt.ucs.ttf. They
> # are located by default under "/usr/lpp/X11/lib/X11/fonts/{Type1,TrueType}"
> # and sym-linked to "/usr/lib/X11/fonts/".
>
> And can you please also change "iso10646-1" to "iso8859-1" in the
> following lines:
>
>   44 dialog.plain.latin-1=-*-helvetica-medium-r-normal--*-%d-100-100-p-*-iso10646-1
>   57 dialog.bold.latin-1=-*-helvetica-bold-r-normal--*-%d-100-100-p-*-iso10646-1
>   70 dialog.italic.latin-1=-*-helvetica-medium-o-normal--*-%d-100-100-p-*-iso10646-1
>   83 dialog.bolditalic.latin-1=-*-helvetica-bold-o-normal--*-%d-100-100-p-*-iso10646-1
>   96 dialoginput.plain.latin-1=-*-courier-medium-r-normal--*-%d-100-100-m-*-iso10646-1
>  109 dialoginput.bold.latin-1=-*-courier-bold-r-normal--*-%d-100-100-m-*-iso10646-1
>  122 dialoginput.italic.latin-1=-*-courier-medium-o-normal--*-%d-100-100-m-*-iso10646-1
>  135 dialoginput.bolditalic.latin-1=-*-courier-bold-o-normal--*-%d-100-100-m-*-iso10646-1
>  148 sansserif.plain.latin-1=-*-helvetica-medium-r-normal--*-%d-100-100-p-*-iso10646-1
>  161 sansserif.bold.latin-1=-*-helvetica-bold-r-normal--*-%d-100-100-p-*-iso10646-1
>  174 sansserif.italic.latin-1=-*-helvetica-medium-o-normal--*-%d-100-100-p-*-iso10646-1
>  187 sansserif.bolditalic.latin-1=-*-helvetica-bold-o-normal--*-%d-100-100-p-*-iso10646-1
>  200 serif.plain.latin-1=-*-times new
> roman-medium-r-normal--*-%d-100-100-p-*-iso10646-1
>  213 serif.bold.latin-1=-*-times new
> roman-bold-r-normal--*-%d-100-100-p-*-iso10646-1
>  227 serif.italic.latin-1=-*-times new
> roman-medium-i-normal--*-%d-100-100-p-*-iso10646-1
>  240 serif.bolditalic.latin-1=-*-times new
> roman-bold-i-normal--*-%d-100-100-p-*-iso10646-1
>  253 monospaced.plain.latin-1=-*-courier-medium-r-normal--*-%d-100-100-m-*-iso10646-1
>  266 monospaced.bold.latin-1=-*-courier-bold-r-normal--*-%d-100-100-m-*-iso10646-1
>  279 monospaced.italic.latin-1=-*-courier-medium-o-normal--*-%d-100-100-m-*-iso10646-1
>  292 monospaced.bolditalic.latin-1=-*-courier-bold-o-normal--*-%d-100-100-m-*-iso10646-1
>  336 filename.-*-courier-medium-r-normal--*-%d-100-100-m-*-iso10646-1=/usr/lpp/X11/lib/X11/fonts/Type1/cour.pfa
>  337 filename.-*-courier-bold-r-normal--*-%d-100-100-m-*-iso10646-1=/usr/lpp/X11/lib/X11/fonts/Type1/courb.pfa
>  338 filename.-*-courier-medium-o-normal--*-%d-100-100-m-*-iso10646-1=/usr/lpp/X11/lib/X11/fonts/Type1/couri.pfa
>  339 filename.-*-courier-bold-o-normal--*-%d-100-100-m-*-iso10646-1=/usr/lpp/X11/lib/X11/fonts/Type1/courbi.pfa
>  340 filename.-*-helvetica-medium-r-normal--*-%d-100-100-p-*-iso10646-1=/usr/lpp/X11/lib/X11/fonts/Type1/helv.pfa
>  341 filename.-*-helvetica-bold-r-normal--*-%d-100-100-p-*-iso10646-1=/usr/lpp/X11/lib/X11/fonts/Type1/helvb.pfa
>  342 filename.-*-helvetica-medium-o-normal--*-%d-100-100-p-*-iso10646-1=/usr/lpp/X11/lib/X11/fonts/Type1/helvi.pfa
>  343 filename.-*-helvetica-bold-o-normal--*-%d-100-100-p-*-iso10646-1=/usr/lpp/X11/lib/X11/fonts/Type1/helvbi.pfa
>  344 filename.-*-times_new_roman-medium-r-normal--*-%d-100-100-p-*-iso10646-1=/usr/lpp/X11/lib/X11/fonts/Type1/tnr.pfa
>  345 filename.-*-times_new_roman-bold-r-normal--*-%d-100-100-p-*-iso10646-1=/usr/lpp/X11/lib/X11/fonts/Type1/tnrb.pfa
>  346 filename.-*-times_new_roman-medium-i-normal--*-%d-100-100-p-*-iso10646-1=/usr/lpp/X11/lib/X11/fonts/Type1/tnri.pfa
>  347 filename.-*-times_new_roman-bold-i-normal--*-%d-100-100-p-*-iso10646-1=/usr/lpp/X11/lib/X11/fonts/Type1/tnrbi.pfa
>
> I know that you merged them from the original file, but I think they
> were wrong from the beginning (I have to blame:) because the Type1
> fonts are no Unicode fonts.
> Sorry for the extra work, but I think it will be better that way.
>
> Regarding the missing entries for the "latin-2, latin-4, cyrillic,
> arabic, greek, hebrew, latin-5, latin-9" compared to the original IBM
> version of the fontcontfig file, I think that's no problem. If we only
> have the Type1 fonts we can't display them anyway. And if we have the
> Unicode TrueType fonts the corresponding encodings work even without
> the concrete mapping (at least what I have tried out).
>
> Thanks for your patience and best regards,
> Volker
>
> On Thu, Jun 5, 2014 at 12:40 PM, Jonathan Lu <luchsh at linux.vnet.ibm.com> wrote:
>> Hello 2d-dev, Volker,
>>
>> Could I have the updated patch reviewed ?
>> any more comments ?
>>
>>
>> On Tue, May 20, 2014 at 2:17 PM, Jonathan Lu <luchsh at linux.vnet.ibm.com>
>> wrote:
>>>
>>> Hi Volker,
>>>
>>> I've updated the patch by dropping the those fonts configurations from
>>> $JRE_LIB_FONTS directory.
>>> The change is based on the SAP version, current change is primarily adding
>>> support for CJK fonts, pls review.
>>>
>>> http://cr.openjdk.java.net/~luchsh/JDK-8034218.v2/
>>>
>>> Thanks
>>> Jonathan
>>>
>>>
>>> On Tue, May 13, 2014 at 5:25 PM, Volker Simonis <volker.simonis at gmail.com>
>>> wrote:
>>>>
>>>> Hi Jonathan,
>>>>
>>>> from all fontconfig files in make/data/fontconfig,
>>>> solaris.fontconfig.properties is the only file which contains a single
>>>> line referring to $JRE_LIB_FONTS. This is obviously a first-day bug
>>>> which should be fixed.
>>>>
>>>> It simply makes no sense to define font files and default fonts with
>>>> references to files which won't be in a JDK for sure. Again, if you
>>>> could convince IBM to donate the corresponding fonts to the OpenJDK
>>>> that would be great. Otherwise these entries should be dropped from
>>>> the fontconfig files.
>>>>
>>>> Thank you and best regards,
>>>> Volker
>>>>
>>>>
>>>> On Tue, May 13, 2014 at 4:06 AM, Jonathan Lu <luchsh at linux.vnet.ibm.com>
>>>> wrote:
>>>> > Hi Phil, Volker,
>>>> >
>>>> > Thanks for your comments, but I noticed that JRE_LIB_FONTS has been
>>>> > referred
>>>> > by the solaris fontconfig file,
>>>> >
>>>> > jdk/make/data/fontconfig/solaris.fontconfig.properties
>>>> >
>>>> > So I'm wondering if we can do this in the same way as Solaris platform.
>>>> >
>>>> >
>>>> > Thanks
>>>> > Jonathan
>>>> >
>>>> >
>>>> >
>>>> > On Tue, May 13, 2014 at 12:47 AM, Phil Race <philip.race at oracle.com>
>>>> > wrote:
>>>> >>
>>>> >> removed awt-dev ...
>>>> >>
>>>> >>
>>>> >> > I don't think we should reference the fonts
>>>> >> > under $JRE_LIB_FONTS/ in the OpenJDK version of
>>>> >> > fontconfig.properties
>>>> >>
>>>> >> Volker is correct on this point.
>>>> >>
>>>> >> Since OpenJDK can't ship those fonts we made sure they were never used
>>>> >> in any openjdk fontconfig file.
>>>> >>
>>>> >> -phil.
>>>> >>
>>>> >>
>>>> >>
>>>> >> On 05/12/2014 09:42 AM, Phil Race wrote:
>>>> >>>
>>>> >>> All,
>>>> >>>
>>>> >>> If you want to continue this discussion i should be restarted on
>>>> >>> 2d-dev
>>>> >>> and awt-dev removed. AWT has nothing to do with the fonts ..
>>>> >>> I've fixed the bug sub-cat.
>>>> >>>
>>>> >>> -phil.
>>>> >>>
>>>> >>> On 05/12/2014 09:06 AM, Volker Simonis wrote:
>>>> >>>>
>>>> >>>> Hi Jonathan,
>>>> >>>>
>>>> >>>> thanks for submitting this patch.
>>>> >>>>
>>>> >>>> Overall it looks good, but I don't think we should reference the
>>>> >>>> fonts
>>>> >>>> under $JRE_LIB_FONTS/ in the OpenJDK version of
>>>> >>>> fontconfig.properties
>>>> >>>> (at least not until IBM will not also contribute the corresponding
>>>> >>>> fonts :)
>>>> >>>>
>>>> >>>> I would also find it helpful to keep a reworked version of the
>>>> >>>> comment:
>>>> >>>>
>>>> >>>>    27 # Minimal version for AIX using the standard Latin Type1 Fonts
>>>> >>>> from the
>>>> >>>>    28 # package X11.fnt.iso_T1. These fonts are installed by default
>>>> >>>> into
>>>> >>>>    29 # "/usr/lpp/X11/lib/X11/fonts/Type1" and sym-linked to
>>>> >>>> "/usr/lib/X11/fonts/Type1"
>>>> >>>>
>>>> >>>> which mentions which AIX packages provide the other referenced font
>>>> >>>> files.
>>>> >>>>
>>>> >>>> Thank you and best regards,
>>>> >>>> Volker
>>>> >>>>
>>>> >>>>
>>>> >>>>
>>>> >>>> On Mon, May 12, 2014 at 12:37 PM, Jonathan Lu
>>>> >>>> <luchsh at linux.vnet.ibm.com> wrote:
>>>> >>>>>
>>>> >>>>> Hi awt-dev,
>>>> >>>>>
>>>> >>>>> Please review the fix for issue:
>>>> >>>>> https://bugs.openjdk.java.net/browse/JDK-8034218
>>>> >>>>>
>>>> >>>>> The changes are placed at
>>>> >>>>> http://cr.openjdk.java.net/~luchsh/JDK-8034218/
>>>> >>>>>
>>>> >>>>> This patch is trying to provide a better fonctconfig.properties
>>>> >>>>> file
>>>> >>>>> for AIX
>>>> >>>>> platform,
>>>> >>>>> which contains support for more languages, like CJK.
>>>> >>>>>
>>>> >>>>>
>>>> >>>>> Thanks
>>>> >>>>> Jonathan
>>>> >>>>>
>>>> >>>>>
>>>> >>>
>>>> >>
>>>> >
>>>
>>>
>>
>> Many thanks
>> Jonathan