[OpenJDK 2D-Dev] <AWT Dev> [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

Jim Graham james.graham at oracle.com
Thu Feb 13 22:52:38 UTC 2014



On 2/13/14 5:03 AM, Anton V. Tarasov wrote:
> Hi Jim,
>
> Please, look at the update:
>
> http://cr.openjdk.java.net/~ant/JDK-8029455/webrev.5
>
> Here I'm correcting the rect after the transform in SG2D:
>
> 2123         // In case of negative scale transform, reflect the rect
> coords.
> 2124         if (w < 0) {
> 2125             w *= -1;
> 2126             x -= w;
> 2127         }
> 2128         if (h < 0) {
> 2129             h *= -1;
> 2130             y -= h;
> 2131         }
>
>
> The blit direction (dx, dy) remains transformed. Is this the right
> behavior from your perspective?

Yes, that looks good.  I wonder if the "w *= -1" results in a multiply 
byte code whereas "w = -w" would avoid the multiply?

			...jim



More information about the 2d-dev mailing list