[OpenJDK 2D-Dev] JDK9: RFR: 8034998: Fix raw and unchecked lint warnings in javax.imageio

Henry Jen henry.jen at oracle.com
Sun Feb 16 02:16:09 UTC 2014


On 02/15/2014 01:15 PM, Joe Darcy wrote:
> On 02/14/2014 06:43 PM, Henry Jen wrote:
>> Hi,
>>
>> Please review the webrev to clean up raw and unchecked warnings in
>> javax.imageio packag at,
>>
>> http://cr.openjdk.java.net/~henryjen/jdk9/8034998/0/webrev/
>>
>> The webrev does not cover javax.imageio.spi, that will come in anoter
>> webrev.
>>
>> Cheers,
>> Henry
>
> Hi Henry,
>
> I skimmed over the changeset and didn't see any issues.
>
> All the signature changes to methods seem to be on private methods or on
> public methods in package-private classes. If there are any change to
> public or protected methods in public or protected classes, whose would
> need a ccc request.
>


Thanks, as far as I know, all changes to public/protected fields/methods 
are within private classes, but don't trust me, that's the point of code 
review.

It seems to me, there was a round of generic type clean up for public 
APIs, only methods in two 
classes(javax.imageio.spi.Image[Reader|Writer].spi) returning Class[], 
which I am wondering why they are not Class<?>[] that I would like to 
file CCC with javax.imageio.spi package clean up.

Cheers,
Henry



More information about the 2d-dev mailing list