[OpenJDK 2D-Dev] RFR(S): JDK-8031134 : PPC64: implement printing on AIX

[Phil Race]

Hello Volker,

Interesting that all this is needed. How has AIX got by before ?
Is this taken from an existing IBM port or did you write this yourself ?
I'd hope you are getting help directly from IBM in this area.

I suppose that if CUPS is configured and running it'll take precedence 
over these
as it does for the other cases. Someone with AIX should test that at 
some point as
its the only way to know for sure that that works.

I'd hoped that AIX would be able to fit into either the BSD or SysV 
printing mold
but it seems like its got its own special commands
- lsallq is a new one on me and looks like an AIX special
- the "-W" arg to lpstat is completely different than what it means on 
OS X or Linux !
and there's the oddity that it doesn't expect spaces between the flag 
and the value ..
so I think your approach is the best one.

A few specific comments :-

  } else if (aixPrinterEnumerator.equalsIgnoreCase("lsallq")) {
  144                     aix_defaultPrinterEnumeration = aix_lsallq;
  145                 }

this code seems redundant since its just reasserting the default unless
you intend that this be something that can change multiple times but
I'd advise against that and anyway its in static block so that won't 
happen ..


I see you defined

167     static boolean isAIX( ) {
  168         return osname.equals("AIX");
  169     }
  170

so why are you using this here :-
  136         if (osname.equals("AIX")) {

instead of calling isAIX() as you do elsewhere ?


...

} else if (names.length != 1) {
          // No default printer found

In the other cases we chose to nominate the 1st printer as the default.
This seemed a better choice than making apps deal with a list of
installed printers but no default. Not sure what problems you might
encounter with this (if any). If the situation never occurs its not an 
issue.

-phil.

On 1/16/14 12:08 AM, Volker Simonis wrote:
> Resending one more time to 2d-dev upon request:
>
> Hi,
>
> could somebody please review the following small change:
>
> http://cr.openjdk.java.net/~simonis/webrevs/8031134/
>
> It's the straight forward implementation of the basic printing
> infrastructure on AIX and shouldn't have any impact on the existing
> platforms. As always, this change is intended for the
> http://hg.openjdk.java.net/ppc-aix-port/stage/jdk repository.
>
> Thank you and best regards,
> Volker