[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8033223: Fix serial lint warnings in sun.{font, java2d[.*]}

Joe Darcy joe.darcy at oracle.com
Thu Jan 30 06:17:08 UTC 2014


PS I updated the webrev to include changes to two additional files:

diff -r a4c07ee72d07 
src/share/classes/com/sun/imageio/plugins/common/BogusColorSpace.java
--- 
a/src/share/classes/com/sun/imageio/plugins/common/BogusColorSpace.java 
Wed Jan 29 17:37:40 2014 +0100
+++ 
b/src/share/classes/com/sun/imageio/plugins/common/BogusColorSpace.java 
Wed Jan 29 22:15:51 2014 -0800
@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2003, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2003, 2014, Oracle and/or its affiliates. All rights 
reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -31,6 +31,7 @@
   * A dummy <code>ColorSpace</code> to enable <code>ColorModel</code>
   * for image data which do not have an innate color representation.
   */
+ at SuppressWarnings("serial") // JDK-implementation class
  public class BogusColorSpace extends ColorSpace {
      /**
       * Return the type given the number of components.
diff -r a4c07ee72d07 
src/share/classes/com/sun/imageio/plugins/jpeg/JFIFMarkerSegment.java
--- 
a/src/share/classes/com/sun/imageio/plugins/jpeg/JFIFMarkerSegment.java 
Wed Jan 29 17:37:40 2014 +0100
+++ 
b/src/share/classes/com/sun/imageio/plugins/jpeg/JFIFMarkerSegment.java 
Wed Jan 29 22:15:51 2014 -0800
@@ -558,6 +558,7 @@

      // Could put reason codes in here to be parsed in writeJFXXSegment
      // in order to provide more meaningful warnings.
+    @SuppressWarnings("serial") // JDK-implementation class
      private class IllegalThumbException extends Exception {}

      /**

Thanks,

-Joe

On 01/29/2014 10:10 PM, Joe Darcy wrote:
> Hello,
>
> As another installment of addressing the serial warnings in the client 
> libraries, please review my changes for:
>
>     JDK-8033223: Fix serial lint warnings in sun.{font, java2d[.*]}
>     http://cr.openjdk.java.net/~darcy/8033223.0/
>
> Patch below.
>
> Thanks,
>
> -Joe
>
> --- old/src/share/classes/sun/font/FontScalerException.java 2014-01-29 
> 22:09:03.000000000 -0800
> +++ new/src/share/classes/sun/font/FontScalerException.java 2014-01-29 
> 22:09:03.000000000 -0800
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2007, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2007, 2014, Oracle and/or its affiliates. All rights 
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -25,6 +25,7 @@
>
>  package sun.font;
>
> + at SuppressWarnings("serial") // JDK-implementation class
>  public class FontScalerException extends Exception {
>      public FontScalerException() {
>        super("Font scaler encountered runtime problem.");
> --- old/src/share/classes/sun/java2d/InvalidPipeException.java 
> 2014-01-29 22:09:04.000000000 -0800
> +++ new/src/share/classes/sun/java2d/InvalidPipeException.java 
> 2014-01-29 22:09:04.000000000 -0800
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 1999, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 1999, 2014, Oracle and/or its affiliates. All rights 
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -34,6 +34,7 @@
>   * windows which toggle the need to use platform graphics or direct
>   * graphics access.
>   */
> + at SuppressWarnings("serial") // JDK-implementation class
>  public class InvalidPipeException extends IllegalStateException {
>      /**
>       * Constructs an InvalidPipeException with no detail message.
> --- old/src/share/classes/sun/java2d/cmm/lcms/LCMSImageLayout.java 
> 2014-01-29 22:09:04.000000000 -0800
> +++ new/src/share/classes/sun/java2d/cmm/lcms/LCMSImageLayout.java 
> 2014-01-29 22:09:04.000000000 -0800
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2007, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2007, 2014, Oracle and/or its affiliates. All rights 
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -376,6 +376,7 @@
>          return (int)res;
>      }
>
> +    @SuppressWarnings("serial") // JDK-implementation class
>      public static class ImageLayoutException extends Exception {
>          public ImageLayoutException(String message) {
>              super(message);
>




More information about the 2d-dev mailing list