[OpenJDK 2D-Dev] [9] Review request for 8041460, PNGImageWriter creates metadata with incorrect bitDepth

[Andrew Brygin]

Hello Mikhail,

  the fix looks fine to me.

Thanks,
Andrew

On 6/9/2014 10:32 PM, mikhail cherkasov wrote:
> Hi all,
>
> please review the fix:
> http://cr.openjdk.java.net/~mcherkas/8041460/webrev.02/
> for the following bug:
> https://bugs.openjdk.java.net/browse/JDK-8041460
>
> The problem is that during merging of metadata trees we take index of 
> IHDR_bitDepths
> and set this value to IHDR_bitDepth, but IHDR_bitDepth requires a real 
> number of bits.
> IHDR_bitDepths - store all valid values: "1", "2", "4", "8", "16", so 
> to get
> valid value we need: 1 << index.
>
> Thanks,
> Mikhail.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20140623/a0723487/attachment.html>