[OpenJDK 2D-Dev] [9] request for review: 6945174: IndexOutOfBoundsException calling ImageIO.read() on malformed PNG

Phil Race philip.race at oracle.com
Thu May 8 22:04:59 UTC 2014


Looks OK but please fix the typo in the exception string  .. lenght -> 
length

-phil.

On 5/8/14 11:43 AM, Andrew Brygin wrote:
> Hello,
>
> could you please review a fix for CR 6945174?
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-6945174
> Webrev: http://cr.openjdk.java.net/~bae/6945174/9/webrev.00/
>
> PNG image reader validates the length of chunk's data
> when reads image metadata. However, if metadata is ignored,
> the length  is used to skip data in the stream without
> any validation.
>
> Suggested fix just introduces a validation of the chunk
> data length for the case of ignored metadata in a similar
> way as it is done for the case of metadata processing.
>
> Supplied regression test demonstrates the problem.
>
> Please take a look.
>
> Thanks,
> Andrew.




More information about the 2d-dev mailing list