[OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

[Sergey Bylokhov]

Hi, Phil.
The fix looks good. But probably we can rename MFontConfiguration since 
dependency on motif was removed?

On 26.03.15 1:48, Phil Race wrote:
> Updated webrev http://cr.openjdk.java.net/~prr/8035302.2/
>
> - removed the jdk.charsets export to java.desktop from modules.xml
>
> - removed the COMPOUND_TEXT support which likely has not been used 
> since Motif support was removed
>
> -phil.
>
> On 3/20/15 2:39 PM, Phil Race wrote:
>> On 3/19/15 8:19 PM, Mandy Chung wrote:
>>>
>>> On 03/16/2015 02:32 PM, Phil Race wrote:
>>>>> Here is an updated fix that instead of removing the sun.nio 
>>>>> dependency instead removes the jdk.charsets static dependency. 
>>>>> From the internal API point of view its sun.nio.cs.ext that is the 
>>>>> issue, not sun.nio
>>>>>
>>>>> http://cr.openjdk.java.net/~prr/8035302.1/
>>>>>
>>>
>>> Looks quite good and much cleaner.
>>>
>>> src/jdk.charsets/unix/classes/sun/nio/cs/ext/CompoundTextSupport.java
>>>
>>>    cls = Class.forName("sun.awt.motif." + enc);
>>>
>>> Should we do something about this Class.forName?
>>
>> Hmm .. that class is littered with references to X11 !
>> eg
>>  if (isEncodingSupported("X11GB2312")) {
>>
>> Sherman : why is all of this here ?
>>
>>>
>>> modules.xml - you can take out <depend>jdk.charsets</depend>
>>> from java.desktop module.  You can verify the module access
>>> by make verify-modules target.
>>>
>>> There are tests referencing sun.awt.motif that I assume you will
>>> update and send out another webrev?
>>>
>>> Tests under test/java/awt are expected and surprisingly there are
>>> tests in test/sun/nio/cs:
>>>
>>> test/sun/nio/cs/TestX11CNS.java
>>> test/sun/nio/cs/TestX11JIS0201.java
>>
>> I am getting rid of these
>>>
>>> thank you for doing this.
>>> Mandy
>>>
>>
>


-- 
Best regards, Sergey.